[PATCH] D66981: Fix driver tests when `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR` is `ON`

This revision was automatically updated to reflect the committed changes. Closed by commit rL373565: Fix driver tests when `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR` is `ON` (authored by sepavloff, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r373565 - Fix driver tests when `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR` is `ON`

Author: sepavloff Date: Wed Oct 2 21:52:46 2019 New Revision: 373565 URL: http://llvm.org/viewvc/llvm-project?rev=373565&view=rev Log: Fix driver tests when `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR` is `ON` Some Driver tests relied on the default resource direcory having per-os per-arch subdirectory

[PATCH] D67980: [WIP][CLANG][BPF] do compile-once run-everywhere relocation for bitfields

anakryiko added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9321-9322 + if (IsError) +return IsBitField ? EmitLValue(Arg).getBitFieldPointer() + : EmitLValue(Arg).getPointer(); + move this under `if (!getDebugInfo)` abov

[PATCH] D68284: [HIP] Support -emit-llvm for device compilation

This revision was automatically updated to reflect the committed changes. Closed by commit rL373561: [HIP] Support -emit-llvm for device compilation (authored by yaxunl, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

r373561 - [HIP] Support -emit-llvm for device compilation

Author: yaxunl Date: Wed Oct 2 20:27:43 2019 New Revision: 373561 URL: http://llvm.org/viewvc/llvm-project?rev=373561&view=rev Log: [HIP] Support -emit-llvm for device compilation Sometimes it is useful to compile HIP device code to LLVM BC. It is not convenient to use clang -cc1 since there ar

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

apazos added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:631 + MachineBasicBlock::iterator NewMI = + BuildMI(MBB, MI, DL, TII.get(RISCV::PseudoCALL)) + .add(MI->getOperand(0)); Where are we making sure the

[PATCH] D68166: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries

JonChesterfield added a comment. > The tool indeed does not have anything specific to OpenMP at this step, but > that will change... That makes sense to me, thanks. I think we're going to have some trouble adapting this to our build as there's already a standalone tool that runs at link time.

r373556 - Revert 373538 and follow-ups 373549 and 373552.

Author: nico Date: Wed Oct 2 19:38:43 2019 New Revision: 373556 URL: http://llvm.org/viewvc/llvm-project?rev=373556&view=rev Log: Revert 373538 and follow-ups 373549 and 373552. They break tests on (at least) macOS. Added: cfe/trunk/test/InterfaceStubs/object.cpp Removed: cfe/trunk/lib/

[PATCH] D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests.

kousikk updated this revision to Diff 222953. kousikk added a comment. Update diff to include all commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68193/new/ https://reviews.llvm.org/D68193 Files: clang/include/clang/Tooling/DependencyScann

[PATCH] D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests.

kousikk added a comment. In D68193#1692293 , @arphaman wrote: > I don't quite understand the specific issue you're hitting, as it sounds that > the logic right now should handle it: > > > It seems that when the CachingFileSystem is first given a file to o

[PATCH] D68166: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries

sdmitriev added a comment. In D68166#1692071 , @JonChesterfield wrote: > I think this patch is a behaviour change. Currently, the target binary is > embedded in the host binary at link time. With this change, the contents of > the binary are embedded in

[PATCH] D68368: [ItaniumMangle] Fix mangling of GNU __null in an expression to match GCC

jrtc27 created this revision. jrtc27 added a reviewer: rsmith. Herald added subscribers: cfe-commits, erik.pilkington. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68368 Files: clang/lib/AST/ItaniumMangle.cpp clang/test/CodeGenCXX/mangle-expr

[PATCH] D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests.

arphaman added a comment. I don't quite understand the specific issue you're hitting, as it sounds that the logic right now should handle it: > It seems that when the CachingFileSystem is first given a file to open that > is actually a directory, it incorrectly > caches that path to be errenous

r373553 - PR43519: don't inject a diagnostic when constant-evaulation of a

Author: rsmith Date: Wed Oct 2 18:20:27 2019 New Revision: 373553 URL: http://llvm.org/viewvc/llvm-project?rev=373553&view=rev Log: PR43519: don't inject a diagnostic when constant-evaulation of a pointer-to-member call can't determine a callee. We will have produced a diagnostic already if the

r373552 - Fixing broken builds due to r373538, issues with filepath and hexagon toolchain.

Author: zer0 Date: Wed Oct 2 18:19:51 2019 New Revision: 373552 URL: http://llvm.org/viewvc/llvm-project?rev=373552&view=rev Log: Fixing broken builds due to r373538, issues with filepath and hexagon toolchain. It appears there are some issues with the hexagon toolchain, and also the file path f

[PATCH] D68364: Prototype implementation of P0784R7: mark all members of std::allocator and std::allocator_traits as constexpr.

rsmith updated this revision to Diff 222944. rsmith added a comment. Undo adding too many files to this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68364/new/ https://reviews.llvm.org/D68364 Files: libcxx/include/__config libcxx/incl

[PATCH] D68364: Prototype implementation of P0784R7: mark all members of std::allocator and std::allocator_traits as constexpr.

rsmith updated this revision to Diff 222943. rsmith added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Moved some changes from the vector patch to here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68364/new/ h

r373549 - Fixing broken builds due to r373538 due to test that should have been deleted.

Author: zer0 Date: Wed Oct 2 17:41:13 2019 New Revision: 373549 URL: http://llvm.org/viewvc/llvm-project?rev=373549&view=rev Log: Fixing broken builds due to r373538 due to test that should have been deleted. test/InterfaceStubs/object.cpp should have been deleted. Removed: cfe/trunk/test/I

r373548 - Mark P0784R7 as complete and start defining its feature-test macro.

Author: rsmith Date: Wed Oct 2 17:39:37 2019 New Revision: 373548 URL: http://llvm.org/viewvc/llvm-project?rev=373548&view=rev Log: Mark P0784R7 as complete and start defining its feature-test macro. Note that this only covers the language side of this feature. (The library side has its own feat

r373547 - For P0784R7: support placement new-expressions in constant evaluation.

Author: rsmith Date: Wed Oct 2 17:39:35 2019 New Revision: 373547 URL: http://llvm.org/viewvc/llvm-project?rev=373547&view=rev Log: For P0784R7: support placement new-expressions in constant evaluation. For now, we restrict this support to use from within the standard library implementation, sin

r373546 - For P0784R7: allow direct calls to operator new / operator delete from

Author: rsmith Date: Wed Oct 2 17:39:33 2019 New Revision: 373546 URL: http://llvm.org/viewvc/llvm-project?rev=373546&view=rev Log: For P0784R7: allow direct calls to operator new / operator delete from std::allocator::{allocate,deallocate} in constant evaluation. Added: cfe/trunk/test/SemaC

[PATCH] D68362: [libunwind][RISCV] Add 64-bit RISC-V support

mhorne created this revision. Herald added subscribers: s.egerton, lenary, benna, psnobl, PkmX, rkruppe, rogfer01, shiva0217, christof, kito-cheng, simoncook, krytarowski, aprantl. Add unwinding support for 64-bit RISC-V. This is from the FreeBSD implementation with the following minor changes:

Re: r373247 - Teach CallGraph to look into Generic Lambdas.

Thanks! If it takes a few hours to investigate, I think it's better to revert first and then investigate while the tree is green. On Mon, Sep 30, 2019 at 4:43 PM Keane, Erich wrote: > Should be fixe din r373259 > > > > *From:* Nico Weber > *Sent:* Monday, September 30, 2019 12:50 PM > *To:* Ke

Re: r373538 - [clang][ifs] Clang Interface Stubs ToolChain plumbing.

Looks like this broke a bunch of tests: http://lab.llvm.org:8011/builders/clang-cuda-build/builds/37720/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Aobject.cpp http://lab.llvm.org:8011/builders/clang-cuda-build/builds/37720/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Adriver-test.c If i

[PATCH] D67079: [analyzer] CastValueChecker: Model inheritance

Charusso added a comment. Well, the rebase is a little-bit weird, sorry for the inconvenience. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67079/new/ https://reviews.llvm.org/D67079 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67079: [analyzer] CastValueChecker: Model inheritance

Charusso updated this revision to Diff 222932. Charusso added a comment. - Rebase properly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67079/new/ https://reviews.llvm.org/D67079 Files: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h clang/include/clang/

[PATCH] D67079: [analyzer] CastValueChecker: Model inheritance

Charusso updated this revision to Diff 222931. Charusso added a comment. - Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67079/new/ https://reviews.llvm.org/D67079 Files: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h clang/include/clang/StaticAna

[PATCH] D68199: [analyzer] DynamicTypeInfo: Simplify the API

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yup, optional sounds perfect. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68199/new/ https://reviews.llvm.org/D68199 ___ cfe-commits mailing

[PATCH] D68199: [analyzer] DynamicTypeInfo: Simplify the API

Charusso updated this revision to Diff 222927. Charusso edited the summary of this revision. Charusso added a comment. - No comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68199/new/ https://reviews.llvm.org/D68199 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/D

[PATCH] D68199: [analyzer] DynamicTypeInfo: Simplify the API

Charusso marked 3 inline comments as done. Charusso added a comment. Sorry, I was sure it is working as expected. Comment at: clang/lib/StaticAnalyzer/Core/DynamicType.cpp:53-57 if (const auto *TR = dyn_cast(MR)) -return DynamicTypeInfo(TR->getLocationType(), /*CanBeSub=

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

This revision was automatically updated to reflect the committed changes. Closed by commit rL373538: [clang][ifs] Clang Interface Stubs ToolChain plumbing. (authored by zer0, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

r373538 - [clang][ifs] Clang Interface Stubs ToolChain plumbing.

Author: zer0 Date: Wed Oct 2 15:50:07 2019 New Revision: 373538 URL: http://llvm.org/viewvc/llvm-project?rev=373538&view=rev Log: [clang][ifs] Clang Interface Stubs ToolChain plumbing. This patch enables end to end support for generating ELF interface stubs directly from clang. Now the following

[PATCH] D68315: [libTooling] Add various Stencil combinators for expressions.

gribozavr marked an inline comment as done. gribozavr added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/Stencil.h:149 /// \returns the source corresponding to the selected range. StencilPart selection(RangeSelector Selector); ymandel

[PATCH] D67980: [WIP][CLANG][BPF] do compile-once run-everywhere relocation for bitfields

yonghong-song updated this revision to Diff 222920. yonghong-song edited the summary of this revision. yonghong-song added a comment. return byte_size/offset/lshift/rshift based on size alignment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67980/n

[PATCH] D68315: [libTooling] Add various Stencil combinators for expressions.

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/Stencil.h:149 /// \returns the source corresponding to the selected range. StencilPart selection(RangeSelector Selector); gribozavr wr

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

apazos added a comment. Lewis, with this patch we see less failures. But still some tests in SPEC and perennial test suites are failing. Pengxuan and I are trying to triage the failures. Here is what we see in one of the failed tests: Code right before rologue/Epilogue Insertion & Frame Finali

[PATCH] D68166: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries

sdmitriev updated this revision to Diff 222917. sdmitriev marked 2 inline comments as done. sdmitriev added a comment. Addressed some comments and rebased patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68166/new/ https://reviews.llvm.org/D68166 Files: clang/include/clang/Driver

[PATCH] D68166: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries

JonChesterfield added a comment. I think this patch is a behaviour change. Currently, the target binary is embedded in the host binary at link time. With this change, the contents of the binary are embedded in bitcode which is subsequently fed into the link. If indeed so, that seems strictly be

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:133 /// returned if there are no more bundles to be read. - virtual StringRef ReadBundleStart(MemoryBuffer &Input) = 0; + virtual Expected> + ReadBundleStart(MemoryBuffer

[PATCH] D68296: [clang-format] Add ability to wrap braces after multi-line control statements

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM and Thank you. Comment at: clang/lib/Format/Format.cpp:643 +true}; switch (Style.BreakBeforeBraces) { case FormatStyle:

[PATCH] D67980: [WIP][CLANG][BPF] do compile-once run-everywhere relocation for bitfields

yonghong-song updated this revision to Diff 222910. yonghong-song edited the summary of this revision. yonghong-song added a comment. use a bpf target builtin __builtin_get_field_info(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67980/new/ http

r373526 - Fix uninitialized variable warning in CodeGenPGO constructor. NFCI.

Author: rksimon Date: Wed Oct 2 14:05:21 2019 New Revision: 373526 URL: http://llvm.org/viewvc/llvm-project?rev=373526&view=rev Log: Fix uninitialized variable warning in CodeGenPGO constructor. NFCI. Modified: cfe/trunk/lib/CodeGen/CodeGenPGO.h Modified: cfe/trunk/lib/CodeGen/CodeGenPGO.h

[PATCH] D68296: [clang-format] Add ability to wrap braces after multi-line control statements

mitchell-stellar marked 4 inline comments as done. mitchell-stellar added inline comments. Comment at: clang/lib/Format/Format.cpp:643 +true}; switch (Style.BreakBeforeBraces) { case FormatStyle::BS_Linux: MyDeveloperDay wrote: >

[PATCH] D68296: [clang-format] Add ability to wrap braces after multi-line control statements

mitchell-stellar updated this revision to Diff 222907. mitchell-stellar added a comment. Renamed "OnlyMultiLine" option to "MultiLine", per reviewer request. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68296/new/ https://reviews.llvm.org/D68296 Files: clang/

[PATCH] D68284: [HIP] Support -emit-llvm for device compilation

tra accepted this revision. tra added a comment. LGTM. Thank you for fixing this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68284/new/ https://reviews.llvm.org/D68284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1610 + if (const auto *CXXC = dyn_cast(Method)) { +if (CXXC->getCanonicalDecl()->isDeleted()) + SPFlags |= llvm::DISubprogram::SPFlagDeleted; can you factor this block out into

[PATCH] D68284: [HIP] Support -emit-llvm for device compilation

yaxunl updated this revision to Diff 222904. yaxunl added a comment. fix -S CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68284/new/ https://reviews.llvm.org/D68284 Files: lib/Driver/Driver.cpp test/Driver/hip-device-compile.hip Index: test/Driver/hip-device-compile.hip ==

[PATCH] D67775: [Sema] Split out -Wformat-type-confusion from -Wformat-pedantic

erik.pilkington added a comment. Ping! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67775/new/ https://reviews.llvm.org/D67775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[PATCH] D68355: [Clang][Driver][NFC] Corrected DeviceActionBuilder methods' comments.

This revision was automatically updated to reflect the committed changes. Closed by commit rL373523: [Clang][Driver][NFC] Corrected DeviceActionBuilder methods' comments. (authored by sdmitriev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

r373525 - ItaniumCXXABI - silence static analyzer getAs null dereference warnings. NFCI.

Author: rksimon Date: Wed Oct 2 13:45:16 2019 New Revision: 373525 URL: http://llvm.org/viewvc/llvm-project?rev=373525&view=rev Log: ItaniumCXXABI - silence static analyzer getAs null dereference warnings. NFCI. The static analyzer is warning about potential null dereferences, but we should be

r373523 - [Clang][Driver][NFC] Corrected DeviceActionBuilder methods' comments.

Author: sdmitriev Date: Wed Oct 2 13:44:45 2019 New Revision: 373523 URL: http://llvm.org/viewvc/llvm-project?rev=373523&view=rev Log: [Clang][Driver][NFC] Corrected DeviceActionBuilder methods' comments. Differential Revision: https://reviews.llvm.org/D68355 Modified: cfe/trunk/lib/Driver/

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

vchuravy updated this revision to Diff 222900. vchuravy added a comment. - change anyref AS to 256 - fix some comments and address nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66035/new/ https://reviews.llvm.org/D66035 Files: clang/lib/Basi

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

vchuravy added a comment. Keno has asked me to take this over for him and I will work on getting this into shape so that it can get landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66035/new/ https://reviews.llvm.org/D66035 ___

[PATCH] D68355: [Clang][Driver][NFC] Corrected DeviceActionBuilder methods' comments.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. In D68355#1691963 , @sdmitriev wrote: > In D68355#1691961 , @ABataev wrote: > > > Mark the patch as NFC. > >

r373520 - CGObjCMac - silence static analyzer dyn_cast<>/getAs<> null dereference warnings. NFCI.

Author: rksimon Date: Wed Oct 2 13:30:37 2019 New Revision: 373520 URL: http://llvm.org/viewvc/llvm-project?rev=373520&view=rev Log: CGObjCMac - silence static analyzer dyn_cast<>/getAs<> null dereference warnings. NFCI. The static analyzer is warning about potential null dereferences, but we s

[PATCH] D68355: [Clang][Driver][NFC] Corrected DeviceActionBuilder methods' comments.

sdmitriev added a comment. In D68355#1691961 , @ABataev wrote: > Mark the patch as NFC. I think I have already done that by adding [NFC] to the commit message. Do I need to do anything in addition to that? Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D68355: [Clang][Driver][NFC] Corrected DeviceActionBuilder methods' comments.

ABataev added a comment. Mark the patch as NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68355/new/ https://reviews.llvm.org/D68355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D68355: [Clang][Driver][NFC] Corrected DeviceActionBuilder methods' comments.

sdmitriev created this revision. sdmitriev added a reviewer: ABataev. sdmitriev added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68355 Files: clang/lib/Driver/Driver.cpp Index: clang/lib/Driver/Driver.cpp

[PATCH] D68296: [clang-format] Add ability to wrap braces after multi-line control statements

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Looks good but I think the option would be better as just `MultiLine`, remember to mark the comments "Done" when you are complete Comment at: clang

[PATCH] D68166: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries

sdmitriev added inline comments. Comment at: clang/lib/Driver/Driver.cpp:2284-2289 -/// Append top level actions generated by the builder. Return true if errors -/// were found. +/// Append top level actions generated by the builder. virtual void appendTopLevelA

[PATCH] D66647: [clangd] DefineInline action apply logic with fully qualified names

kadircet updated this revision to Diff 222892. kadircet marked 5 inline comments as done. kadircet added a comment. - Update test helper to take an out parameter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66647/new/ https://reviews.llvm.org/D666

[PATCH] D68273: [clangd] Fix raciness in code completion tests

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:1141 +ReceivedRequestCV.wait(Lock, + [this, Num] { return NumRequestsReceived == Num; }); +NumRequestsReceived = 0; ilya-biryuko

[PATCH] D68273: [clangd] Fix raciness in code completion tests

kadircet updated this revision to Diff 222890. kadircet marked 5 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68273/new/ https://reviews.llvm.org/D68273 Files: clang-tools-ex

[PATCH] D68315: [libTooling] Add various Stencil combinators for expressions.

gribozavr added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/Stencil.h:149 /// \returns the source corresponding to the selected range. StencilPart selection(RangeSelector Selector); ymandel wrote: > gribozavr wrote: > > Should the com

[PATCH] D68296: [clang-format] Add ability to wrap braces after multi-line control statements

mitchell-stellar added a comment. @MyDeveloperDay I am not wedded to "OnlyMultiLine". I picked it, as it seemed reasonable to me, but if you think another string expresses the intent better, then feel free to use it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D68315: [libTooling] Add various Stencil combinators for expressions.

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/Stencil.h:149 /// \returns the source corresponding to the selected range. StencilPart selection(RangeSelector Selector); gribozavr wr

[PATCH] D68315: [libTooling] Add various Stencil combinators for expressions.

ymandel updated this revision to Diff 222889. ymandel marked 2 inline comments as done. ymandel added a comment. responded to comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68315/new/ https://reviews.llvm.org/D68315 Files: clang/include/

[PATCH] D68166: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries

JonChesterfield added a comment. I still don't understand what advantage the standalone tool has over renaming the file to `omp_offloading` and then using `objcopy -I binary`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68166/new/ https://review

[PATCH] D68296: [clang-format] Add ability to wrap braces after multi-line control statements

MyDeveloperDay added a comment. @klimek thanks for offering for me to make the decision. I think given the fact that blender has it in their style guide and that they are clearly working around clang-formats inability to handle this case, I'm minded to LGTM this revision I hope you are ok with

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

MyDeveloperDay requested changes to this revision. MyDeveloperDay added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Format/Format.h:1950 + /// similar) conditions. + bool SpacesAroundConditions; + its position

[PATCH] D68166: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries

ABataev added inline comments. Comment at: clang/lib/Driver/Driver.cpp:2284-2289 -/// Append top level actions generated by the builder. Return true if errors -/// were found. +/// Append top level actions generated by the builder. virtual void appendTopLevelAct

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

ABataev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:133 /// returned if there are no more bundles to be read. - virtual StringRef ReadBundleStart(MemoryBuffer &Input) = 0; + virtual Expected> + ReadBundleStart(MemoryBuffer &I

r373504 - [Stencil] Hide implementaion detai. NFC.

Author: d0k Date: Wed Oct 2 11:33:44 2019 New Revision: 373504 URL: http://llvm.org/viewvc/llvm-project?rev=373504&view=rev Log: [Stencil] Hide implementaion detai. NFC. Modified: cfe/trunk/lib/Tooling/Refactoring/Stencil.cpp Modified: cfe/trunk/lib/Tooling/Refactoring/Stencil.cpp URL: htt

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

mstorsjo added a comment. Another slightly related thread, regarding libs from the clang resource dir and how they are specified to the linker (regarding the builtins library): https://reviews.llvm.org/D51440 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D68166: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries

sdmitriev added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68166/new/ https://reviews.llvm.org/D68166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r373502 - [OPENMP50]Add parsing/sema analysis for declare variant score.

Author: abataev Date: Wed Oct 2 11:19:02 2019 New Revision: 373502 URL: http://llvm.org/viewvc/llvm-project?rev=373502&view=rev Log: [OPENMP50]Add parsing/sema analysis for declare variant score. Context selectors may include optional score clause in format `score():`, where `` must be a constan

[PATCH] D67161: [clang,ARM] Initial ACLE intrinsics for MVE.

dmgreen added inline comments. Comment at: clang/include/clang/Basic/arm_mve_defs.td:119 +// The type Void can be used for the return type of an intrinsic, and as the +// parameter type for intrinsics that aren't actually parametrised by any kind +// of _s32 / _f16 / _u8 suffix.

[PATCH] D68346: Clang-format: Add new option to add spaces around conditions

timwoj created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This diff adds a new option SpacesAroundConditions that inserts spaces inside the braces for conditional statements. It's used by the Zeek project (https://github.com/zeek/zeek) as described in t

[PATCH] D68300: [HIP] Add option -fno-link-builtin-bitcode to disable linking device lib

tra added inline comments. Comment at: include/clang/Driver/Options.td:606 +def flink_builtin_bitcode : Flag<["-"], "flink-builtin-bitcode">, + Flags<[CC1Option]>, HelpText<"Link builtin bitcode for HIP device compilation.">; +def fno_link_builtin_bitcode : Flag<["-"], "fno-lin

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

aaron.ballman closed this revision. aaron.ballman added a comment. In D64671#1691538 , @jpakkane wrote: > Rebased against latest Git master. Didn't see any rebase conflicts, though... Oh! I just noticed you made the patch against the monorepo which I'm n

[clang-tools-extra] r373489 - Add the misc-init-local-variables check.

Author: aaronballman Date: Wed Oct 2 10:18:57 2019 New Revision: 373489 URL: http://llvm.org/viewvc/llvm-project?rev=373489&view=rev Log: Add the misc-init-local-variables check. This checks finds all primitive type local variables (integers, doubles, pointers) that are declared without an init

[PATCH] D68284: [HIP] Support -emit-llvm for device compilation

tra added a comment. Could you also add a check for `-S` w/o `-emit-llvm`, too ? AFAICT it currently wants to produce a bundle, which is not very helpful. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68284/new/ https://reviews.llvm.org/D68284 ___

[PATCH] D68296: clang-format: Add ability to wrap braces after multi-line control statements

MyDeveloperDay added a comment. As I mentioned, its worth getting evidence from a large public project... https://wiki.blender.org/index.php/Dev:Doc/Code_Style Blender public repo on github.com has 90 Forks, 299 * and 90,000 commits From their style guide Exceptions to Braces on Same Line

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

xbolva00 added a comment. &a[0] is really UB in C? Oh =[ Can we have clang warning also for this case? And suggest “a”? Very common code, I think. Hopefully llvm’s optimizers do not exploit this case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

jpakkane updated this revision to Diff 222850. jpakkane added a comment. Rebased against latest Git master. Didn't see any rebase conflicts, though... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64671/new/ https://reviews.llvm.org/D64671 Files: clang-tools-extra/clang-tidy/cppcoreg

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

lebedev.ri added a comment. In D67122#1691307 , @lebedev.ri wrote: > Ping. > After talking with @aaron.ballman, revised the check to also handle the C > semantics ("ptr+0 is UB"). And that resulted in one more occurrence in test-suite - rL373486

[PATCH] D67723: [CodeView] Add option to disable inline line tables.

aprantl added a comment. There also needs to be a IR-based test for the inliner change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67723/new/ https://reviews.llvm.org/D67723 ___ cfe-commits mailing

[PATCH] D67723: [CodeView] Add option to disable inline line tables.

aprantl added inline comments. Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1426 + // If we are not generating inline line tables, set the debug location + // of the inlined code to be the call site. + DebugLoc IDL = aprant

[PATCH] D67723: [CodeView] Add option to disable inline line tables.

aprantl requested changes to this revision. aprantl added a comment. This revision now requires changes to proceed. I don't think the implementation is correct, see inline comments. Comment at: clang/include/clang/Driver/Options.td:1943 +def gno_inline_line_tables : Flag<["-"],

r373480 - Type - silence static analyzer getAs<> null dereference warnings. NFCI.

Author: rksimon Date: Wed Oct 2 09:03:36 2019 New Revision: 373480 URL: http://llvm.org/viewvc/llvm-project?rev=373480&view=rev Log: Type - silence static analyzer getAs<> null dereference warnings. NFCI. The static analyzer is warning about potential null dereferences, but in these cases we sh

[PATCH] D67723: [CodeView] Add option to disable inline line tables.

jmorse added a comment. Looks good, although I'm not familiar enough with frontend things to approve IMO. Using a function attribute seems fine and appropriate too -- although CU flags is another thing I'm unfamiliar with, so I can't really offer an opinion. Repository: rG LLVM Github Monor

Re: r372681 - Support for DWARF-5 C++ language tags.

Yeah, something about linkage - but that's not the part that's as likely to be a problem as the other part: the other test for C++ language was what causes LLVM to compute the fully qualified name of an entity in the accelerator table ("foo::bar" instead of just "bar" (eg: the bug was things like "

Re: r372681 - Support for DWARF-5 C++ language tags.

>> On Oct 1, 2019, at 6:40 PM, David Blaikie wrote: >> >> This broke gnu_pubnames and other forms of DWARF index of C++ code - fixed >> in r373420 (feel free to post-comimt review, etc, of course) >> > patch for reference: >case dwarf::DW_TAG_union_type: >case dwarf::DW_TAG_enumerat

Re: r372681 - Support for DWARF-5 C++ language tags.

Out of curiosity, should/would this've shown up for you Apple folks too? (as a failure in the apple/lldb accelerator tables - because the names would be similarly incorrect) had it just not got to the necessary testing yet? On Wed, Oct 2, 2019 at 8:29 AM Adrian Prantl wrote: > > > On Oct 1, 2019

Re: r372681 - Support for DWARF-5 C++ language tags.

> On Oct 1, 2019, at 6:40 PM, David Blaikie wrote: > > This broke gnu_pubnames and other forms of DWARF index of C++ code - fixed in > r373420 (feel free to post-comimt review, etc, of course) > Thanks! -- adrian > On Mon, Sep 23, 2019 at 5:36 PM Adrian Prantl via cfe-commits > mailto:cfe

r373478 - Silence static analyzer getAs null dereference warnings. NFCI.

Author: rksimon Date: Wed Oct 2 08:31:25 2019 New Revision: 373478 URL: http://llvm.org/viewvc/llvm-project?rev=373478&view=rev Log: Silence static analyzer getAs null dereference warnings. NFCI. The static analyzer is warning about potential null dereferences, but in these cases we should be a

[PATCH] D68315: [libTooling] Add various Stencil combinators for expressions.

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/Refactoring/Stencil.h:149 /// \returns the source corresponding to the selected range. StencilPart selection(RangeSelector

[PATCH] D68296: clang-format: Add ability to wrap braces after multi-line control statements

klimek added a comment. In D68296#1691393 , @mitchell-stellar wrote: > Thanks for the review. I have added documentation updates. > > I do not have a public style guide to reference. My company just switched to > auto-clang-formatting all of our code, an

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan created this revision. Herald added subscribers: cfe-commits, jsji, jfb, kbarton, mgorny, nemanjai. Herald added a project: clang. This patch adds AIX toolchain infrastructure into driver, and enables AIX system linker invocation with some basic functionality support Repository: rG LL

  1   2   >