[PATCH] D68682: Clang-tidy fixes should avoid creating new blank lines

Eugene.Zelenko added a comment. You may be iinterested to l Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68682/new/ https://reviews.llvm.org/D68682 ___ cfe-commits mailing list

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge added a comment. In D67536#1699221 , @ilya-biryukov wrote: > I have actually seen clients that just make the text gray and it looks pretty > nice (ReSharper for Visual Studio and IntelliJ IDEA definitely do that). I don't think there is a

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge planned changes to this revision. nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:152 + // Don't bother computing the offset for the end of the line, just use + //

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

rjmccall added inline comments. Comment at: clang/docs/UsersManual.rst:1330 + and ``fast``. + Details: + rjmccall wrote: > "provided by other, single-purpose floating point options." I don't know why you keep including "clang" as a modifier here; this is the

[PATCH] D68682: Clang-tidy fixes should avoid creating new blank lines

poelmanc created this revision. poelmanc added reviewers: jonathanmeier, alexfh. poelmanc added a project: clang-tools-extra. Herald added subscribers: cfe-commits, mgehre, ormris. Herald added a project: clang. Clang-tidy can ignore most formatting concerns as formatting is clang-format's job.

[PATCH] D68578: [HIP] Fix device stub name

t-tye added a comment. In D68578#1700652 , @tra wrote: > In D68578#1698864 , @t-tye wrote: > > > From a source language point of view, the device function comprises the > > code that is launched as a grid. We need

r374135 - [c++20] P1152R4: warn on any simple-assignment to a volatile lvalue

Author: rsmith Date: Tue Oct 8 19:04:54 2019 New Revision: 374135 URL: http://llvm.org/viewvc/llvm-project?rev=374135=rev Log: [c++20] P1152R4: warn on any simple-assignment to a volatile lvalue whose value is not ignored. We don't warn on all the cases that are deprecated: specifically, we

[PATCH] D68681: [libc++][test] Miscellaneous MSVC cleanups

CaseyCarter created this revision. CaseyCarter added reviewers: mclow.lists, EricWF, ldionne. Herald added a subscriber: dexonsmith. - Silence unused-local-typedef warnings: `map.cons/assign_initializer_list.pass.cpp` (and the `set.cons` variant) uses a local typedef only within

[PATCH] D68362: [libunwind][RISCV] Add 64-bit RISC-V support

mhorne marked 5 inline comments as done. mhorne added a comment. Thanks for the review! Comment at: libunwind/src/Registers.hpp:3585 + +inline uint64_t Registers_riscv::getRegister(int regNum) const { + if (regNum == UNW_REG_IP) lenary wrote: > Do you want to

[PATCH] D61365: [libcxx] [test] Suppress float->int narrowing warning in vector range-construction test.

CaseyCarter added inline comments. Comment at: test/std/containers/sequences/vector/vector.cons/construct_iter_iter.pass.cpp:159 float array[3] = {0.0f, 1.0f, 2.0f}; +#pragma warning(suppress: 4244) // narrowing float to int std::vector v(array, array + 3);

[PATCH] D68362: [libunwind][RISCV] Add 64-bit RISC-V support

mhorne updated this revision to Diff 223971. mhorne added a comment. Address lenary's comments. Add a check for __riscv_float_abi_double in getFloat/setFloat. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68362/new/ https://reviews.llvm.org/D68362 Files:

r374133 - [c++20] Implement most of P1152R4.

Author: rsmith Date: Tue Oct 8 17:49:40 2019 New Revision: 374133 URL: http://llvm.org/viewvc/llvm-project?rev=374133=rev Log: [c++20] Implement most of P1152R4. Diagnose some now-deprecated uses of volatile types: * as function parameter types and return types * as the type of a structured

[PATCH] D68055: Add -fgnuc-version= to control __GNUC__ and other GCC macros

xbolva00 added a comment. In D68055#1688747 , @programmerjake wrote: > Shouldn't `__GNUG__` match `__GNUC__`? +1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68055/new/ https://reviews.llvm.org/D68055

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

rsmith added a comment. Looks fine to me with some doc improvements. Comment at: clang/docs/ReleaseNotes.rst:64-66 + non-zero offset to ``nullptr`` (or making non-``nullptr`` a ``nullptr``, + by subtracting pointer's integral value from the pointer itself; in C, also, +

[PATCH] D68055: Add -fgnuc-version= to control __GNUC__ and other GCC macros

rnk added a comment. In D68055#1698653 , @rsmith wrote: > From a big-picture perspective, I would like us to move to treating MS and > GNU extensions in the same way (at the cc1 level) to the extent that we can. > I think this moves us in that

r374131 - [cxx_status] Note that Clang has supported std::source_location since

Author: rsmith Date: Tue Oct 8 16:39:56 2019 New Revision: 374131 URL: http://llvm.org/viewvc/llvm-project?rev=374131=rev Log: [cxx_status] Note that Clang has supported std::source_location since version 9. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html

[PATCH] D68578: [HIP] Fix device stub name

tra added a comment. In D68578#1698864 , @t-tye wrote: > From a source language point of view, the device function comprises the code > that is launched as a grid. We need this fact to be present in the symbols > used. Only the device function should

r374130 - Factor out some duplication. NFC.

Author: rsmith Date: Tue Oct 8 16:37:49 2019 New Revision: 374130 URL: http://llvm.org/viewvc/llvm-project?rev=374130=rev Log: Factor out some duplication. NFC. Modified: cfe/trunk/lib/AST/ExprConstant.cpp Modified: cfe/trunk/lib/AST/ExprConstant.cpp URL:

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX marked 2 inline comments as done. SouraVX added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-defaulted-out-of-class.cpp:25 + + //FIXME -- clang will not mark above member funtions, excluding constructors + // as out of class. If we did not mark

[PATCH] D68634: [ASTImporter] Imported FunctionDecls inherit attributes from existing functions

a_sidorin added a comment. Ouch! Sorry, Gabor -_\\ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68634/new/ https://reviews.llvm.org/D68634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX marked 3 inline comments as done. SouraVX added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1619 + else { +SPFlags |= llvm::DISubprogram::SPFlagNotDefaulted; + } Previously SPFlagNotDefaulted is setted to SPFlagZero

[PATCH] D68436: [clang-scan-deps] Improve string/character literal skipping

This revision was automatically updated to reflect the committed changes. arphaman marked 5 inline comments as done. Closed by commit rGa13f0da1d0bc: [clang-scan-deps] Improve string/character literal skipping (authored by arphaman). Changed prior to commit:

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX updated this revision to Diff 223954. SouraVX added a comment. Addressed comments, regarding flags. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68117/new/ https://reviews.llvm.org/D68117 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D68634: [ASTImporter] Imported FunctionDecls inherit attributes from existing functions

a_sidorin added a comment. Hello Balasz, In my opinion, importing and setting the attributes should be handled by the stuff used in InitializeImportedDecl(). Can we extend it or reuse the code? It will allow us not to miss the required actions while importing a new function too. Repository:

r374127 - [clang-scan-deps] Improve string/character literal skipping

Author: arphaman Date: Tue Oct 8 15:42:44 2019 New Revision: 374127 URL: http://llvm.org/viewvc/llvm-project?rev=374127=rev Log: [clang-scan-deps] Improve string/character literal skipping The existing string/character literal skipping code in the dependency directives source minimizer has two

[PATCH] D68665: [HIP] Fix -save-temps

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: lib/Driver/Driver.cpp:4400 + // HIP image for device compilation with -fno-gpu-rdc is per compilation + // unit. + bool IsHIPNoRDC =

[PATCH] D68611: [IRGen] Emit lifetime markers for temporary struct allocas

This revision was automatically updated to reflect the committed changes. thegameg marked an inline comment as done. Closed by commit rG143f6b837790: [IRGen] Emit lifetime markers for temporary struct allocas (authored by thegameg). Herald added a project: clang. Herald added a subscriber:

[PATCH] D68669: [llvm-objdump][WIP] Make llvm-objdump -h compatible with GNU objdump.

rupprecht planned changes to this revision. rupprecht added a comment. Note: herald added reviewers, but this patch is just to provide context. I'll send the real patches for review in the coming days. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D68669: [llvm-objdump][WIP] Make llvm-objdump -h compatible with GNU objdump.

rupprecht created this revision. Herald added subscribers: llvm-commits, cfe-commits, seiya, arphaman, jakehehrlich, aheejin, arichardson, sbc100, emaste. Herald added a reviewer: espindola. Herald added a reviewer: alexshap. Herald added a reviewer: jhenderson. Herald added projects: clang,

r374126 - [IRGen] Emit lifetime markers for temporary struct allocas

Author: thegameg Date: Tue Oct 8 15:10:38 2019 New Revision: 374126 URL: http://llvm.org/viewvc/llvm-project?rev=374126=rev Log: [IRGen] Emit lifetime markers for temporary struct allocas When passing arguments using temporary allocas, we need to add the appropriate lifetime markers so that the

[PATCH] D68665: [HIP] Fix -save-temps

yaxunl created this revision. yaxunl added reviewers: tra, ashi1. Currently clang does not save some of the intermediate file generated during device compilation for HIP when -save-temps is specified. This patch fixes that. https://reviews.llvm.org/D68665 Files: lib/Driver/Driver.cpp

r374119 - Fix crash or wrong code bug if a lifetime-extended temporary contains a

Author: rsmith Date: Tue Oct 8 14:26:03 2019 New Revision: 374119 URL: http://llvm.org/viewvc/llvm-project?rev=374119=rev Log: Fix crash or wrong code bug if a lifetime-extended temporary contains a "non-constant" value. If the constant evaluator evaluates part of a variable initializer,

[PATCH] D68652: [driver][hip] Skip bundler if host action is nothing.

tra added inline comments. Comment at: clang/test/Driver/hip-syntax-only.hip:7 + +// CHECK-DAG: clang{{.*}}" "-cc1" {{.*}} "-fcuda-is-device" +// CHECK-DAG: clang{{.*}}" "-cc1" "-triple" "x86_64" hliao wrote: > tra wrote: > > I'd include `-target ` and a comment

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 223940. mibintc added a comment. I added a test case to show the warning diagnostics when options conflicting with fp-model are provided. I fixed a couple bugs in RenderFloatingPointOptions when issueing diagnostics. still owe a test case showing how the

[PATCH] D68663: [clang-offload-bundler] Support `.cui` and `.d`.

tra added a comment. Maybe, add a TODO to eventually remove `.d` . `.cui` should probably remain as it's yet another variant of preprocessed output that we allow bundling for C/C++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68663/new/

[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

tra added a reviewer: klimek. tra added a comment. Added Manuel as someone familiar with tooling. Comment at: clang/lib/Tooling/Tooling.cpp:117 // The one job we find should be to invoke clang again. const auto = cast(*Jobs.begin()); if

[PATCH] D68640: Try to get readability-deleted-default.cpp to pass on Windows.

gribozavr added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68640/new/ https://reviews.llvm.org/D68640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68610: [clang] enable_trivial_var_init_zero should not be Joined<>

This revision was automatically updated to reflect the committed changes. Closed by commit rGc831ce8c0619: [clang] enable_trivial_var_init_zero should not be Joined (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68610/new/

r374113 - [clang] enable_trivial_var_init_zero should not be Joined<>

Author: vitalybuka Date: Tue Oct 8 13:34:53 2019 New Revision: 374113 URL: http://llvm.org/viewvc/llvm-project?rev=374113=rev Log: [clang] enable_trivial_var_init_zero should not be Joined<> Reviewers: rnk Subscribers: cfe-commits Tags: #clang Differential Revision:

[PATCH] D68663: [clang-offload-bundler] Support `.cui` and `.d`.

hliao added a comment. Adding this support is aimed to prevent crashing or failure, it's not intended to be final output for -M or -E. So, hip fails on these options due to the unsupported type of clang-offload-bundler. Before we nail down the details on the expected output of -M or -E,

[PATCH] D68610: [clang] enable_trivial_var_init_zero should not be Joined<>

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68610/new/ https://reviews.llvm.org/D68610 ___

[PATCH] D68663: [clang-offload-bundler] Support `.cui` and `.d`.

hliao created this revision. hliao added reviewers: tra, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68663 Files: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp Index:

r374110 - [clang] Add llvm-ifs in test deps

Author: vitalybuka Date: Tue Oct 8 13:23:24 2019 New Revision: 374110 URL: http://llvm.org/viewvc/llvm-project?rev=374110=rev Log: [clang] Add llvm-ifs in test deps Modified: cfe/trunk/test/CMakeLists.txt Modified: cfe/trunk/test/CMakeLists.txt URL:

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

aaronpuchert added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55326/new/ https://reviews.llvm.org/D55326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67112: [Sema] Add implicit cast for conversion of function references

aaronpuchert planned changes to this revision. aaronpuchert added a comment. In D67112#1655937 , @aaronpuchert wrote: > If anyone shares my feeling that the boolean output parameters of > `CompareReferenceRelationship` should rather move to the return

[PATCH] D68340: Add AIX toolchain and basic linker functionality

jasonliu added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:35 + // Only support 32 and 64 bit + if (!IsArch32Bit && !IsArch64Bit) +llvm_unreachable("Unsupported bit width value"); Xiangling_L wrote: > Is there any reason to use

[PATCH] D68340: Add AIX toolchain and basic linker functionality

Xiangling_L added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:38 + + if (!Args.hasArg(options::OPT_nostdlib)) { +CmdArgs.push_back("-e"); Test with Clangtana on terran, when no '-nostdlib' specified, since '-e' & '__start' are the

Re: r374098 - [NFC] Attempt to make ubsan-blacklist-vfs test pass on Windows

Thanks for the fix! > On Oct 8, 2019, at 12:06 PM, Nico Weber wrote: > > Almost: http://45.33.8.238/win/78/step_6.txt > > > C:\src\llvm-project\clang\test\CodeGen\ubsan-blacklist-vfs.c:11:25: error: > INVALID-MAPPED-FILE: expected string not found in

r374107 - [OPENMP50]Multiple vendors in vendor context must be treated as logical

Author: abataev Date: Tue Oct 8 12:44:16 2019 New Revision: 374107 URL: http://llvm.org/viewvc/llvm-project?rev=374107=rev Log: [OPENMP50]Multiple vendors in vendor context must be treated as logical and of vendors, not or. If several vendors are provided in the same vendor context trait, the

[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

hliao created this revision. hliao added reviewers: tra, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. - So far, we only recognize the compilation with offloading and skip the offloading part. Repository: rG LLVM Github Monorepo

Re: r373743 - [NFCI] Improve the -Wbool-operation's warning message

Yeah, I tried to fix even that case but is not so simple so not worth any extra time/complexivity. > Dňa 8. 10. 2019 o 19:09 užívateľ Arthur O'Dwyer > napísal: > >  > On Mon, Oct 7, 2019 at 6:58 PM Dávid Bolvanský > wrote: > >> FWIW I found the "always evaluates to 'true'" bit important

[PATCH] D68587: [hip] Assume host-only compilation if the final phase is ahead of `backend`.

hliao abandoned this revision. hliao added a comment. need to more clarification and re-design Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68587/new/ https://reviews.llvm.org/D68587 ___ cfe-commits

[PATCH] D68587: [hip] Assume host-only compilation if the final phase is ahead of `backend`.

hliao added a comment. In D68587#1700178 , @tra wrote: > TL; DR; > +1 to formalizing how we want -M*/-E/-S/-emit-llvm/-fsyntax-only to behave. > OK with -M/-E/-S defaulting to host, and erroring out if applied to multiple > sub-compilations. > I'm

r374105 - Try to get ubsan-blacklist-vfs.c pass more on Windows

Author: nico Date: Tue Oct 8 12:25:49 2019 New Revision: 374105 URL: http://llvm.org/viewvc/llvm-project?rev=374105=rev Log: Try to get ubsan-blacklist-vfs.c pass more on Windows Modified: cfe/trunk/test/CodeGen/ubsan-blacklist-vfs.c Modified: cfe/trunk/test/CodeGen/ubsan-blacklist-vfs.c

[PATCH] D68640: Try to get readability-deleted-default.cpp to pass on Windows.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8cb804a3c9ce: Try to get readability-deleted-default.cpp to pass on Windows. (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests.

arphaman requested changes to this revision. arphaman added a comment. This revision now requires changes to proceed. @kousikk Thanks, I understand your patch better now. It makes more sense for sure. When we're opening the file we shouldn't `stat` before calling `open`, as there's a race

[PATCH] D68634: [ASTImporter] Imported FunctionDecls inherit attributes from existing functions

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:7842 +// This implementation is inspired by Sema::mergeDeclAttributes. +void ASTNodeImporter::CopyInheritedAttributes(FunctionDecl *Old, + FunctionDecl *New) {

[PATCH] D68640: Try to get readability-deleted-default.cpp to pass on Windows.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68640/new/ https://reviews.llvm.org/D68640 ___

[clang-tools-extra] r374103 - Try to get readability-deleted-default.cpp to pass on Windows.

Author: nico Date: Tue Oct 8 12:14:34 2019 New Revision: 374103 URL: http://llvm.org/viewvc/llvm-project?rev=374103=rev Log: Try to get readability-deleted-default.cpp to pass on Windows. In MS compatibility mode, "extern inline void g()" is not a redundant declaration for "inline void g()",

Re: r374098 - [NFC] Attempt to make ubsan-blacklist-vfs test pass on Windows

Almost: http://45.33.8.238/win/78/step_6.txt C:\src\llvm-project\clang\test\CodeGen\ubsan-blacklist-vfs.c:11:25: error: INVALID-MAPPED-FILE: expected string not found in input // INVALID-MAPPED-FILE: invalid-virtual-file.blacklist': No such file or directory ^ :1:1: note:

[PATCH] D68640: Try to get readability-deleted-default.cpp to pass on Windows.

thakis updated this revision to Diff 223917. thakis edited the summary of this revision. thakis added a comment. make test more explicit CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68640/new/ https://reviews.llvm.org/D68640 Files:

[PATCH] D68587: [hip] Assume host-only compilation if the final phase is ahead of `backend`.

tra added a comment. TL; DR; +1 to formalizing how we want -M*/-E/-S/-emit-llvm/-fsyntax-only to behave. OK with -M/-E/-S defaulting to host, and erroring out if applied to multiple sub-compilations. I'm still convinced that the tooling issue with multiple subcompilations is orthogonal to

[PATCH] D68099: [MS ABI]: Fix mangling function arguments for template types to be compatible with MSVC

adamf added a comment. @thakis Yes please, I cannot commit this patch by myself, because I don't have commit access. Surely, next time I will add more context in diff. Thanks a lot for the effort. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68099/new/

[PATCH] D68640: Try to get readability-deleted-default.cpp to pass on Windows.

thakis added a comment. > Can you clarify what exactly the TODO is? As-is, the check suggests removing > the redeclaration where it's a no-op (non-ms) but not where it isn't (C, ms > compat). If I understand your reply correctly, this is desired behavior. Is > the TODO then to have test

[PATCH] D68099: [MS ABI]: Fix mangling function arguments for template types to be compatible with MSVC

thakis accepted this revision. thakis added a comment. lgtm. I finally got around to understanding the patch. Sorry for the delay, thanks for the fix! Next time you upload a patch, please upload it with more context (see

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 223911. mibintc added a comment. clean up some dead code Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 Files: clang/docs/UsersManual.rst

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc marked 2 inline comments as done. mibintc added inline comments. Comment at: clang/include/clang/Driver/Options.td:927 def fdenormal_fp_math_EQ : Joined<["-"], "fdenormal-fp-math=">, Group, Flags<[CC1Option]>; +def ffp_model_EQ : Joined<["-"], "ffp-model=">, Group,

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc marked 2 inline comments as done. mibintc added inline comments. Comment at: clang/docs/UsersManual.rst:1341 + has been selected, then the compiler will issue a diagnostic warning + that the override has occurred. + rjmccall wrote: > That's not

[PATCH] D68099: [MS ABI]: Fix mangling function arguments for template types to be compatible with MSVC

thakis added a comment. (It regressed in D62780 ; I had bisected that bit.) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68099/new/ https://reviews.llvm.org/D68099 ___ cfe-commits

[PATCH] D68640: Try to get readability-deleted-default.cpp to pass on Windows.

thakis added a comment. In D68640#1699628 , @aaron.ballman wrote: > In D68640#1699605 , @thakis wrote: > > > In D68640#1699563 , @gribozavr > > wrote: > > > > > It looks

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 223908. mibintc added a comment. I made a couple wording changes suggested by @rjmccall Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 Files: clang/docs/UsersManual.rst

r374099 - [BPF] do compile-once run-everywhere relocation for bitfields

Author: yhs Date: Tue Oct 8 11:23:17 2019 New Revision: 374099 URL: http://llvm.org/viewvc/llvm-project?rev=374099=rev Log: [BPF] do compile-once run-everywhere relocation for bitfields A bpf specific clang intrinsic is introduced: u32 __builtin_preserve_field_info(member_access, info_kind)

[PATCH] D68531: [WebAssembly] Add builtin and intrinsic for v8x16.swizzle

tlively marked an inline comment as done. tlively added a comment. In D68531#1699855 , @aheejin wrote: > > LLVM produces a poison value if the dynamic swizzle indices are greater > > than the vector size, but the WebAssembly instruction sets the > >

r374098 - [NFC] Attempt to make ubsan-blacklist-vfs test pass on Windows

Author: jkorous Date: Tue Oct 8 11:13:04 2019 New Revision: 374098 URL: http://llvm.org/viewvc/llvm-project?rev=374098=rev Log: [NFC] Attempt to make ubsan-blacklist-vfs test pass on Windows Previously disabled in d0c2d5daa3e Modified: cfe/trunk/test/CodeGen/ubsan-blacklist-vfs.c

[PATCH] D68652: [driver][hip] Skip bundler if host action is nothing.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6334a59454ef: [driver][hip] Skip bundler if host action is nothing. (authored by hliao). Changed prior to commit: https://reviews.llvm.org/D68652?vs=223890=223905#toc Repository: rG LLVM Github

r374097 - [driver][hip] Skip bundler if host action is nothing.

Author: hliao Date: Tue Oct 8 11:06:51 2019 New Revision: 374097 URL: http://llvm.org/viewvc/llvm-project?rev=374097=rev Log: [driver][hip] Skip bundler if host action is nothing. Reviewers: sfantao, tra, yaxunl Subscribers: cfe-commits Tags: #clang Differential Revision:

[PATCH] D68652: [driver][hip] Skip bundler if host action is nothing.

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/hip-syntax-only.hip:7 + +// CHECK-DAG: clang{{.*}}" "-cc1" {{.*}} "-fcuda-is-device" +// CHECK-DAG: clang{{.*}}" "-cc1" "-triple" "x86_64"

[PATCH] D33029: [clang-format] add option for dangling parenthesis

MyDeveloperDay added a comment. I tried the patch and rebased it locally (as there were conflicts with the current trunk) The change caused other tests to fail (which doesn't completely surprise me) most tests failures look associated with positioning of trailing brace for example @@ -1,4

r374093 - [OPENMP50]Do not allow multiple same context traits in the same context

Author: abataev Date: Tue Oct 8 10:47:52 2019 New Revision: 374093 URL: http://llvm.org/viewvc/llvm-project?rev=374093=rev Log: [OPENMP50]Do not allow multiple same context traits in the same context selector. According to OpenMP 5.0, 2.3.2 Context Selectors, Restrictions, each

[PATCH] D67980: [BPF] do compile-once run-everywhere relocation for bitfields

ast accepted this revision. ast added a comment. perfect. ship it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67980/new/ https://reviews.llvm.org/D67980 ___ cfe-commits mailing list

[PATCH] D68562: [clangd] Add RemoveUsingNamespace tweak.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:99 +return false; + if (!dyn_cast(TargetDirective->getDeclContext())) +return false; ilya-biryukov wrote: > I believe this check is redundant

[PATCH] D68562: [clangd] Add RemoveUsingNamespace tweak.

usaxena95 updated this revision to Diff 223898. usaxena95 marked 8 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68562/new/ https://reviews.llvm.org/D68562 Files:

Re: r373743 - [NFCI] Improve the -Wbool-operation's warning message

On Mon, Oct 7, 2019 at 6:58 PM Dávid Bolvanský wrote: >> FWIW I found the "always evaluates to 'true'" bit important to >> understand the warning. > > Yeah. I moved this check somewhere else, so we can print precise message: > r373973 should emit "bitwise negation of a boolean expression always >

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

rjmccall added a comment. Thank you, this looks very clean now. Comment at: clang/docs/UsersManual.rst:1318 + mode informs the compiler that it must not assume any particular + rounding mode. + "represent *the* corresponding IEEE rounding rules"

[PATCH] D68652: [driver][hip] Skip bundler if host action is nothing.

hliao created this revision. hliao added reviewers: sfantao, tra, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68652 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/hip-syntax-only.hip

[PATCH] D68627: [Sema][X86] Consider target attribute into the checks in validateOutputSize and validateInputSize.

erichkeane added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:947 - virtual bool validateOutputSize(StringRef /*Constraint*/, + virtual bool validateOutputSize(const llvm::StringMap , + StringRef /*Constraint*/,

[PATCH] D68340: Add AIX toolchain and basic linker functionality

Xiangling_L added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:35 + // Only support 32 and 64 bit + if (!IsArch32Bit && !IsArch64Bit) +llvm_unreachable("Unsupported bit width value"); Is there any reason to use llvm_unreachable here? I

[PATCH] D68531: [WebAssembly] Add builtin and intrinsic for v8x16.swizzle

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. > LLVM produces a poison value if the dynamic swizzle indices are greater than > the vector size, but the WebAssembly instruction sets the corresponding > output lane to zero. Where do we

[PATCH] D68578: [HIP] Fix device stub name

yaxunl added a comment. In D68578#1698864 , @t-tye wrote: > I am a little unclear what this patch is doing as it is mentioned that the > mangled name has a _stub in it. My understanding is that the intention was to > create a distinct unmangled name for

r374072 - [OPENMP50]Prohibit multiple context selector sets in context selectors.

Author: abataev Date: Tue Oct 8 08:56:43 2019 New Revision: 374072 URL: http://llvm.org/viewvc/llvm-project?rev=374072=rev Log: [OPENMP50]Prohibit multiple context selector sets in context selectors. According to OpenMP 5.0, 2.3.2 Context Selectors, Restrictions, each trait-set-selector-name

[PATCH] D58531: [clang] Specify type of pthread_create builtin

jrtc27 marked an inline comment as done. jrtc27 added a comment. In D58531#1662466 , @jdoerfert wrote: > I like the patch and I think it is fine. > > Small nits: > Could we have a test for " we can detect dodgy pthread_create declarations" > and maybe

[PATCH] D58531: [clang] Specify type of pthread_create builtin

jrtc27 updated this revision to Diff 223871. jrtc27 added a comment. Rebased, added explicit no-warning test, clang-format'ed, updated assertion message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58531/new/ https://reviews.llvm.org/D58531

r374061 - [clang][ifs] Clang Interface Stubs ToolChain plumbing.

Author: zer0 Date: Tue Oct 8 08:23:14 2019 New Revision: 374061 URL: http://llvm.org/viewvc/llvm-project?rev=374061=rev Log: [clang][ifs] Clang Interface Stubs ToolChain plumbing. Second Landing Attempt: This patch enables end to end support for generating ELF interface stubs directly from

r374057 - [OPENMP50]Allow functions in declare variant directive to have different

Author: abataev Date: Tue Oct 8 07:56:20 2019 New Revision: 374057 URL: http://llvm.org/viewvc/llvm-project?rev=374057=rev Log: [OPENMP50]Allow functions in declare variant directive to have different C linkage. After some discussion with OpenMP developers, it was decided that the functions

[PATCH] D68640: Try to get readability-deleted-default.cpp to pass on Windows.

aaron.ballman added a comment. In D68640#1699605 , @thakis wrote: > In D68640#1699563 , @gribozavr wrote: > > > It looks to me that a better fix is to fix the checker to not emit this > > warning in MS

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

lewis-revill updated this revision to Diff 223855. lewis-revill added a comment. Rebased to fix conflicts with recent split SP adjustments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62686/new/ https://reviews.llvm.org/D62686 Files:

[PATCH] D68637: [libTooling] Move Transformer files to their own directory/library.

ymandel updated this revision to Diff 223856. ymandel added a comment. update another cmakelists file (uncovered by linking for shared libs) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68637/new/ https://reviews.llvm.org/D68637 Files:

[PATCH] D68640: Try to get readability-deleted-default.cpp to pass on Windows.

gribozavr added a comment. > There's no shortage of possible implicit TODOs I don't see "-fno-ms-compatibility" as an implicit TODO. It is most commonly used as "this test does something that does not work in MS mode". When I read it, I can't tell why it is there. When other people write

[PATCH] D68640: Try to get readability-deleted-default.cpp to pass on Windows.

aaron.ballman added a comment. In D68640#1699563 , @gribozavr wrote: > It looks to me that a better fix is to fix the checker to not emit this > warning in MS compatibility mode. +1 > I'm OK with "fixing" the test like this, however, it should come

[PATCH] D68074: [clang-tidy] Add readability-make-member-function-const

gribozavr added a comment. I'm holding off on reviewing the code until we figure out what the rules are. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-make-member-function-const.rst:10 +The check conservatively tries to preserve logical costness in favor of

  1   2   >