Re: r374449 - Add -fgnuc-version= to control __GNUC__ and other GCC macros

I think _MSC_VER is controlled by -ms-compatiblity-version based on what I found when I was missing with the bmiintrin.h header yesterday. ~Craig On Fri, Oct 11, 2019 at 3:05 PM Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > I think overloading zero to mean "don't define

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:133 /// returned if there are no more bundles to be read. - virtual StringRef ReadBundleStart(MemoryBuffer ) = 0; + virtual Expected> + ReadBundleStart(MemoryBuffer ) =

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev updated this revision to Diff 224726. sdmitriev added a comment. Rebased patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 Files: clang/test/Driver/clang-offload-bundler.c

[PATCH] D68897: [clang][ifs] Avoid assumption of default visibility in InterfaceStubs tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGc0abc2e7f2f6: [clang][IFS] Updating tests to pass on -fvisibility=hidden builds (NFCi). (authored by plotfi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

r374632 - [clang][IFS] Updating tests to pass on -fvisibility=hidden builds (NFCi).

Author: zer0 Date: Fri Oct 11 19:46:57 2019 New Revision: 374632 URL: http://llvm.org/viewvc/llvm-project?rev=374632=rev Log: [clang][IFS] Updating tests to pass on -fvisibility=hidden builds (NFCi). Special thanks to JamesNagurne who got to the bottom of this; landing this on his behalf.

r374627 - Slightly relax restriction on exact order arguments must appear.

Author: dyung Date: Fri Oct 11 19:22:36 2019 New Revision: 374627 URL: http://llvm.org/viewvc/llvm-project?rev=374627=rev Log: Slightly relax restriction on exact order arguments must appear. Modified: cfe/trunk/test/Driver/openmp-offload.c Modified: cfe/trunk/test/Driver/openmp-offload.c

[PATCH] D68896: PR43080: Do not build context-sensitive expressions during name classification.

rsmith marked an inline comment as done. rsmith added a comment. In D68896#1706870 , @efriedma wrote: > Would it make sense to always use ClassifyName from the parser, instead of > using ActOnIdExpression? I like that idea, at least in principle. We'd

[libunwind] r374624 - [libunwind] Fix issues introduced in r374606

Author: phosek Date: Fri Oct 11 18:50:57 2019 New Revision: 374624 URL: http://llvm.org/viewvc/llvm-project?rev=374624=rev Log: [libunwind] Fix issues introduced in r374606 There are few differences in compile flags introduced in r374606 which are causing libcxx-libcxxabi-libunwind-armv8-linux

[PATCH] D68902: [WebAssembly] Trapping fptoint builtins and intrinsics

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. The WebAssembly backend lowers fptoint instructions to a code sequence that checks for

[PATCH] D68897: [clang][ifs] Avoid assumption of default visibility in InterfaceStubs tests

JamesNagurne added a comment. Sadly I'm home from the weekend, so I can't post more diffs for the renaming. Here's a link to a github search though! I think this would be all the places: https://github.com/llvm/llvm-project/search?q=iterface_q=iterface I nor the rest of my team have the ability

[PATCH] D68896: PR43080: Do not build context-sensitive expressions during name classification.

efriedma added a comment. Hmm, the ObjC changes were simpler than I expected. And you managed to avoid making changes to overload sets. The changes related to IsAddressOfOperand are a nice simplification. Would it make sense to always use ClassifyName from the parser, instead of using

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

akhuang updated this revision to Diff 224711. akhuang added a comment. - Set location to line 0 with getMergedLocation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67723/new/ https://reviews.llvm.org/D67723 Files:

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi added a comment. In D63978#1706764 , @JamesNagurne wrote: > In D63978#1706714 , @plotfi wrote: > > > In D63978#1706502 , @JamesNagurne > > wrote: > > > > > In

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

JamesNagurne added a comment. In D63978#1706714 , @plotfi wrote: > In D63978#1706502 , @JamesNagurne > wrote: > > > In D63978#1706448 , @plotfi wrote: > > > > > In

[PATCH] D68897: [clang][ifs] Avoid assumption of default visibility in InterfaceStubs tests

JamesNagurne created this revision. JamesNagurne added reviewers: plotfi, snidertm. Herald added a project: clang. Herald added a subscriber: cfe-commits. In D63978 , tests were added which expect that the default visibility is maintained without an explicit

[PATCH] D68849: [Parse] Don't speculatively parse an identifier in the wrong context.

rsmith added a comment. https://reviews.llvm.org/D68896 for the patch to defer forming the `Expr` until it's consumed. This is still not right for implicit member access, but I think that's feasible to fix too (if a little awkward). Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D68896: PR43080: Do not build context-sensitive expressions during name classification.

rsmith created this revision. rsmith added a reviewer: efriedma. Herald added a project: clang. We don't know what context to use until the classification result is consumed by the parser, which could happen in a different semantic context. This covers everything except C++ implicit class member

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

akhuang updated this revision to Diff 224697. akhuang marked an inline comment as done. akhuang added a comment. Fix code so that -gno-inline-line-tables works when not codeview Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67723/new/

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. I would still prefer no-inline-info or no-inline-debuginfo over no-inline-linetables and a line 0 location for the inlined instructions. Other than that the patch is now safe.

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi added a comment. In D63978#1706502 , @JamesNagurne wrote: > In D63978#1706448 , @plotfi wrote: > > > In D63978#1706420 , @JamesNagurne > > wrote: > > > > > Our team

[PATCH] D67723: [CodeView] Add option to disable inline line tables.

rnk added a comment. I guess the commit message shouldn't say "[CodeView] Add option to disable inline line tables." It's really an option for all debug info. You could put "[DebugInfo]" on there, or just drop the tag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[libunwind] r374606 - [libunwind] Refactor CMake flag checks to match libc++ and libc++abi

Author: phosek Date: Fri Oct 11 15:22:29 2019 New Revision: 374606 URL: http://llvm.org/viewvc/llvm-project?rev=374606=rev Log: [libunwind] Refactor CMake flag checks to match libc++ and libc++abi libunwind was using its own set of macros/functions for flag checking which was similar but

Re: r374449 - Add -fgnuc-version= to control __GNUC__ and other GCC macros

I think overloading zero to mean "don't define __GNUC__" was my way of side stepping the need to think of a good name for this. I don't like -fno-gnu-extensions as a name because clang still supports GCC asm, __attribute__, statement expressions, computed goto, etc, and that flag name seems like

[PATCH] D67723: [CodeView] Add option to disable inline line tables.

akhuang updated this revision to Diff 224687. akhuang added a comment. - Remove extra ifs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67723/new/ https://reviews.llvm.org/D67723 Files: clang/include/clang/Basic/CodeGenOptions.def

LLVM buildmaster could be unavailable today at 5:00 pm PST

Hello everyone, LLVM buildmaster could be unavailable for short time on Friday, October 11th at 5:00 pm PST due to Network maintenance. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67723: [CodeView] Add option to disable inline line tables.

rnk added inline comments. Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1427 +// Remove debug info intrinsics. +if (auto *DbgInst = dyn_cast(BI)) { + BI = --(DbgInst->eraseFromParent()); Each of these inherit from

[PATCH] D67723: [CodeView] Add option to disable inline line tables.

akhuang updated this revision to Diff 224681. akhuang marked 2 inline comments as done. akhuang added a comment. Herald added a subscriber: ormris. -Remove intrinsics debug info -Add inliner test -Add to function attribute description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D68891: Remove unnecessary triple from test

JohnTitor created this revision. JohnTitor added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. PR27098(https://bugs.llvm.org/show_bug.cgi?id=27098) has been fixed so the avoidance seems unnecessary. Repository: rC Clang

[PATCH] D68682: Clang-tidy fix removals removing all non-blank text from a line should remove the line

poelmanc added a comment. In D68682#1705866 , @gribozavr wrote: > > I guess here's the high-level question: should all removals that remove all > > non-blank text from a line also delete the line? > > I see your point, but as https://llvm.org/PR43583

r374596 - [ObjC] Remove default parameter no caller was providing. NFC intended.

Author: vsapsai Date: Fri Oct 11 14:21:02 2019 New Revision: 374596 URL: http://llvm.org/viewvc/llvm-project?rev=374596=rev Log: [ObjC] Remove default parameter no caller was providing. NFC intended. Currently there is no need to make ObjCTypeParamType have a canonical type different from the

[PATCH] D68682: Clang-tidy fix removals removing all non-blank text from a line should remove the line

poelmanc added a comment. In D68682#1705865 , @Eugene.Zelenko wrote: > In D68682#1705505 , @jonathanmeier > wrote: > > > In D68682#1702025 , @poelmanc > > wrote: > > > >

[PATCH] D67985: CFI: wrong type passed to llvm.type.test with multiple inheritance devirtualization

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67985/new/ https://reviews.llvm.org/D67985 ___ cfe-commits mailing list

[PATCH] D67985: CFI: wrong type passed to llvm.type.test with multiple inheritance devirtualization

dmikulin added a comment. @pcc : poke CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67985/new/ https://reviews.llvm.org/D67985 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68849: [Parse] Don't speculatively parse an identifier in the wrong context.

rsmith added a comment. It looks like it's not actually all that complex to defer building the expression until we're ready to consume the annotation. I've got a mostly-complete patch for that, and I'd like to try finishing that before we add workarounds. Repository: rC Clang CHANGES

[PATCH] D66733: [analyzer] Add a checker option to detect nested dead stores

sylvestre.ledru added a comment. I added it to the release notes here : https://reviews.llvm.org/rC374593 I am wondering if the option( WarnForDeadNestedAssignments ) to disable it is really necessary? I haven't seen any false positive while deadstore has some. Repository: rL LLVM CHANGES

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

JamesNagurne added a comment. In D63978#1706448 , @plotfi wrote: > In D63978#1706420 , @JamesNagurne > wrote: > > > Our team maintains a downstream embedded ARM clang distribution and some > > tests from this

r374593 - Release notes: Add the option WarnForDeadNestedAssignments

Author: sylvestre Date: Fri Oct 11 13:33:43 2019 New Revision: 374593 URL: http://llvm.org/viewvc/llvm-project?rev=374593=rev Log: Release notes: Add the option WarnForDeadNestedAssignments https://reviews.llvm.org/D66733 Modified: cfe/trunk/docs/ReleaseNotes.rst Modified:

[PATCH] D68887: Copy the Ranges field from the Diagnostic when creating the ClangTidyError

compositeprimes created this revision. compositeprimes added a reviewer: clang-tools-extra. compositeprimes added a project: clang-tools-extra. Herald added subscribers: cfe-commits, mgehre. Herald added a project: clang. Part 2 of the change: The goal is instead of dropping all the ranges

[PATCH] D68885: Add a Ranges field to Diagnostic struct

compositeprimes created this revision. compositeprimes added reviewers: clang, clang-tools-extra. compositeprimes added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Part 1 of the change: The goal is instead of dropping all the ranges associated with a Diagnostic

[PATCH] D68884: Add support to -Wa,-W in clang

jcai19 updated this revision to Diff 224664. jcai19 added a comment. Update test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68884/new/ https://reviews.llvm.org/D68884 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi marked an inline comment as done. plotfi added a comment. In D63978#1706420 , @JamesNagurne wrote: > Our team maintains a downstream embedded ARM clang distribution and some > tests from this commit have begun to fail for us. > For a number of

[PATCH] D68884: Add support to -Wa,-W in clang

jcai19 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. jcai19 added a reviewer: bcain. jcai19 added subscribers: nickdesaulniers, manojgupta, llozano. jcai19 updated this revision to Diff 224663. jcai19 added a comment. Fix typos. Currently clang

[PATCH] D68884: Add support to -Wa,-W in clang

jcai19 updated this revision to Diff 224663. jcai19 added a comment. Fix typos. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68884/new/ https://reviews.llvm.org/D68884 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

JamesNagurne added a comment. Our team maintains a downstream embedded ARM clang distribution and some tests from this commit have begun to fail for us. For a number of these tests, there was a REQUIRES: x86-registered-target at the top, which has now been removed. Specifically, externstatic.c,

[PATCH] D68882: [test] Fix test failure

ctetreau created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The version mismatch symbol is version 9 on 32 bit android. Since this test isn't actually testing any android specific functionality, we force the target triple to x86_64-unknown-unknown in

[PATCH] D68876: [libTooling] Put all Transformer declarations in a single namespace.

ymandel updated this revision to Diff 224653. ymandel added a comment. remove stray newline and include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68876/new/ https://reviews.llvm.org/D68876 Files:

[PATCH] D68876: [libTooling] Put all Transformer declarations in a single namespace.

ymandel updated this revision to Diff 224651. ymandel edited the summary of this revision. ymandel added a comment. fix using decl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68876/new/ https://reviews.llvm.org/D68876 Files:

Attention bot owners

Hello all bots owners, As all of you know we move to github monorepo very soon now. We are actively working on the buildbot to prepare a solution to switch from SVN to github when time comes. It would require some activity on your bots. At this point it is clear that you would need to * Make

[PATCH] D68876: [libTooling] Put all Transformer declarations in a single namespace.

ymandel updated this revision to Diff 224650. ymandel added a comment. moved all decls to clang::transformer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68876/new/ https://reviews.llvm.org/D68876 Files:

[PATCH] D68876: [libTooling] Group all Transformer combinators in a single namespace.

gribozavr added a comment. > What do you think of my just putting all of the Transformer types + combis in > the single clang::transformer namespace? That would make sense to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68876/new/

r374581 - [Stats] Convert some ad-hoc header search stats to ALWAYS_ENABLED_STATISTIC.

Author: vsapsai Date: Fri Oct 11 11:22:34 2019 New Revision: 374581 URL: http://llvm.org/viewvc/llvm-project?rev=374581=rev Log: [Stats] Convert some ad-hoc header search stats to ALWAYS_ENABLED_STATISTIC. rdar://problem/55715134 Reviewers: dsanders, bogner, rtereshin Reviewed By: dsanders

[PATCH] D68876: [libTooling] Group all Transformer combinators in a single namespace.

ymandel added a comment. I'm now starting to doubt the split into transformer (for combinators) and tooling (for the type decls). I checked and `ast_matchers` contains both. What do you think of my just putting all of the Transformer types + combis in the single `clang::transformer`

r374580 - Suppress false-positive -Wdeprecated-volatile warning from __is_*_assignable(volatile T&, U).

Author: rsmith Date: Fri Oct 11 10:59:09 2019 New Revision: 374580 URL: http://llvm.org/viewvc/llvm-project?rev=374580=rev Log: Suppress false-positive -Wdeprecated-volatile warning from __is_*_assignable(volatile T&, U). Modified: cfe/trunk/lib/Sema/SemaExprCXX.cpp

[PATCH] D47111: : Implement monotonic_buffer_resource.

strager added inline comments. Comment at: include/experimental/memory_resource:433 +char *__cur_; +size_t __align_; +size_t __allocation_size() { > Eric suggests replacing size_t __align_ with uint8_t __log2_align_. I'm > amenable to

[PATCH] D47111: : Implement monotonic_buffer_resource.

strager added inline comments. Comment at: include/experimental/memory_resource:427 +static _LIBCPP_CONSTEXPR const size_t __default_buffer_capacity = 1024; +static _LIBCPP_CONSTEXPR const size_t __default_buffer_alignment = 16; + Nit: Why isn't

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

JonasToth added a comment. > Do you know who is responsible for it? Because i haven't worked with > documentation before and don't know what i need to do to update it. The files reside in `clang-tools-extra/docs/ReleaseNotes.rst` and

[PATCH] D68859: Fixing crash in clang IFS for enum, record, and typedef decls.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe3388c42f39b: [clang][IFS] Fixing assert in clang interface stubs for enums, records, typedefs (authored by plotfi). Changed prior to commit: https://reviews.llvm.org/D68859?vs=224547=224629#toc

[PATCH] D68845: Don't emit unwanted constructor calls in co_return statements

Quuxplusone added a subscriber: lewissbaker. Quuxplusone added a comment. One more test to add: struct Widget { task foo() && { co_return *this; // IIUC this should call return_value(Widget&), not return_value(Widget&&) } }; Comment at:

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille updated this revision to Diff 224606. serge-sans-paille added a comment. Ensure the distance between two probes is at max PAGE_SIZE. Use Calls as free probes. Fix alignment for dynamic alloca This passes the llvm-test suite, and thanks to the use of calls, no inserted probe

r374573 - [clang][IFS] Fixing assert in clang interface stubs for enums, records, typedefs

Author: zer0 Date: Fri Oct 11 10:24:11 2019 New Revision: 374573 URL: http://llvm.org/viewvc/llvm-project?rev=374573=rev Log: [clang][IFS] Fixing assert in clang interface stubs for enums, records, typedefs The clang IFS ASTConsumer was asserting on enums, records (struct definitions in C), and

[PATCH] D68876: [libTooling] Group all Transformer combinators in a single namespace.

ymandel added a comment. In D68876#1706131 , @gribozavr wrote: > WDYT about `clang::transformer`? I don't see much point in the intermediate > namespace. However, LGTM either way. Thanks for the review. I prefer `clang::transformer` but wasn't sure

[PATCH] D68877: [AArch64][SVE] Implement masked load intrinsics

kmclaughlin created this revision. kmclaughlin added reviewers: huntergr, rovka, greened. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a project: LLVM. kmclaughlin added a parent revision: D47775: [AArch64][SVE] Add SPLAT_VECTOR ISD Node. Adds

[PATCH] D68746: [Clang][OpenMP Offload] Move offload registration code to the wrapper

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68746/new/ https://reviews.llvm.org/D68746 ___ cfe-commits mailing list

Re: r374449 - Add -fgnuc-version= to control __GNUC__ and other GCC macros

It's cool we finally have a flag for this, but overloading its meaning with the =0 behavior seems a bit strange to me. Maybe we should have a separate -fno-gnu-extensions for that part instead? On Thu, Oct 10, 2019 at 5:02 PM Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: >

r374571 - Update clang module map for new excluded .def file.

Author: rsmith Date: Fri Oct 11 10:00:34 2019 New Revision: 374571 URL: http://llvm.org/viewvc/llvm-project?rev=374571=rev Log: Update clang module map for new excluded .def file. Modified: cfe/trunk/include/clang/module.modulemap Modified: cfe/trunk/include/clang/module.modulemap URL:

[PATCH] D68876: [libTooling] Group all Transformer combinators in a single namespace.

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. WDYT about `clang::transformer`? I don't see much point in the intermediate namespace. However, LGTM either way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D68876: [libTooling] Group all Transformer combinators in a single namespace.

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a project: clang. This revision introduces a new namespace, `clang::tooling::transformer`, to hold the combinators that together compose the embedded "DSL" provided by Transformer. It moves all Transformer-related

r374569 - Fix test failure with 374562 on Hexagon

Author: erichkeane Date: Fri Oct 11 09:30:45 2019 New Revision: 374569 URL: http://llvm.org/viewvc/llvm-project?rev=374569=rev Log: Fix test failure with 374562 on Hexagon __builtin_assume_aligned takes a size_t which is a 32 bit int on hexagon. Thus, the constant gets converted to a 32 bit

[PATCH] D68746: [Clang][OpenMP Offload] Move offload registration code to the wrapper

ABataev added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:74 + IntegerType *getSizeTTy() { +switch (M.getDataLayout().getPointerTypeSize(Type::getInt8PtrTy(C))) { +case 4u: sdmitriev wrote: > grokos wrote: > >

[PATCH] D67551: [AArch64][SVE] Implement sdot and udot (lane) intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rGee0a0a34646f: [AArch64][SVE] Implement sdot and udot (lane) intrinsics (authored by kmclaughlin). Herald added a subscriber: hiraditya. Herald added a project: LLVM. Changed prior to commit:

[PATCH] D67706: [clang][analyzer] Using CallDescription in StreamChecker.

balazske marked 3 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:288-290 + SymbolRef Sym = RetVal.getAsSymbol(); + stateNotNull = stateNotNull->set(Sym, StreamState::getOpened()); + stateNull =

[PATCH] D68746: [Clang][OpenMP Offload] Move offload registration code to the wrapper

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:74 + IntegerType *getSizeTTy() { +switch (M.getDataLayout().getPointerTypeSize(Type::getInt8PtrTy(C))) { +case 4u:

[PATCH] D67156: [Analyzer] Debug Checkers for Container and Iterator Inspection

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. This is amazing, thanks!! LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67156/new/ https://reviews.llvm.org/D67156 ___

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

vladimir.plyashkun added a comment. In D68694#1705668 , @JonasToth wrote: > The new switch needs documentation as well, and maybe even a note in the > release notes (as it is publicly discussed as issue?). Do you know who is responsible for it? Because

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

vladimir.plyashkun updated this revision to Diff 224597. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68694/new/ https://reviews.llvm.org/D68694 Files: clang-tools-extra/clang-tidy/hicpp/SignedBitwiseCheck.cpp

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

vladimir.plyashkun marked 2 inline comments as done. vladimir.plyashkun added inline comments. Comment at: clang-tools-extra/clang-tidy/hicpp/SignedBitwiseCheck.cpp:23-24 +: ClangTidyCheck(Name, Context), + IgnorePositiveIntegerLiterals( +

[PATCH] D67551: [AArch64][SVE] Implement sdot and udot (lane) intrinsics

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67551/new/ https://reviews.llvm.org/D67551 ___ cfe-commits mailing list

[PATCH] D67706: [clang][analyzer] Using CallDescription in StreamChecker.

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:288-290 + SymbolRef Sym = RetVal.getAsSymbol(); + stateNotNull = stateNotNull->set(Sym, StreamState::getOpened()); + stateNull = stateNull->set(Sym, StreamState::getOpenFailed());

r374562 - Reland r374450 with Richard Smith's comments and test fixed.

Author: erichkeane Date: Fri Oct 11 07:59:44 2019 New Revision: 374562 URL: http://llvm.org/viewvc/llvm-project?rev=374562=rev Log: Reland r374450 with Richard Smith's comments and test fixed. The behavior from the original patch has changed, since we're no longer allowing LLVM to just ignore

[PATCH] D68795: [libTooling] Move `RewriteRule` abstraction into its own header and impl.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe38c36b7b0ab: [libTooling] Move `RewriteRule` abstraction into its own header and impl. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

r374558 - [libTooling] Move `RewriteRule` abstraction into its own header and impl.

Author: ymandel Date: Fri Oct 11 07:43:46 2019 New Revision: 374558 URL: http://llvm.org/viewvc/llvm-project?rev=374558=rev Log: [libTooling] Move `RewriteRule` abstraction into its own header and impl. Summary: Move the `RewriteRule` class and related declarations into its own set of files

[PATCH] D68162: [analyzer][MallocChecker][NFC] Communicate the allocation family to auxiliary functions with parameters

Szelethus added a comment. I forgot to emphasise that the entire point of the patch was to get rid of `getAllocationFamily`, at least the way it used to work, because it was a mess and prevented me from moving forward with changing things to a `CallDescriptionMap`. In D68162#1693110

[PATCH] D67706: [clang][analyzer] Using CallDescription in StreamChecker.

balazske added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67706/new/ https://reviews.llvm.org/D67706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker updated this revision to Diff 224588. Tyker added a comment. improve performance in a bad case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang/AST/Expr.h

[PATCH] D68795: [libTooling] Move `RewriteRule` abstraction into its own header and impl.

ymandel added a comment. updated title & description to match the changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68795/new/ https://reviews.llvm.org/D68795 ___ cfe-commits mailing list

[PATCH] D68825: [libTooling] Change Stencil equality to use `toString()`

This revision was automatically updated to reflect the committed changes. Closed by commit rGcf2438ec1309: [libTooling] Change Stencil equality to use `toString()` (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68825/new/

r374552 - [libTooling] Change Stencil equality to use `toString()`

Author: ymandel Date: Fri Oct 11 07:02:03 2019 New Revision: 374552 URL: http://llvm.org/viewvc/llvm-project?rev=374552=rev Log: [libTooling] Change Stencil equality to use `toString()` Summary: Removes the `isEqual` method from StencilPartInterface and modifies equality to use the string

[clang-tools-extra] r374551 - Updated add_new_check.py to create checker tests in the new directory

Author: gribozavr Date: Fri Oct 11 06:46:55 2019 New Revision: 374551 URL: http://llvm.org/viewvc/llvm-project?rev=374551=rev Log: Updated add_new_check.py to create checker tests in the new directory Modified: clang-tools-extra/trunk/clang-tidy/add_new_check.py Modified:

[PATCH] D68682: Clang-tidy fix removals removing all non-blank text from a line should remove the line

Eugene.Zelenko added a comment. In D68682#1705505 , @jonathanmeier wrote: > In D68682#1702025 , @poelmanc wrote: > > > In D68682#1700908 , > > @Eugene.Zelenko wrote: > > >

[PATCH] D68682: Clang-tidy fix removals removing all non-blank text from a line should remove the line

gribozavr added a comment. > I guess here's the high-level question: should all removals that remove all > non-blank text from a line also delete the line? I see your point, but as https://llvm.org/PR43583 shows, we have a much larger problem: textual replacements don't compose. So, whatever

[PATCH] D27377: clang-format: Support the Java 8 'default' method modifier

MyDeveloperDay added a comment. While reviewing old revisions either not landed or unreviewed I stumbled across this accepted review. Looking at the current code I think its not needed anymore. Perhaps if we merge your test in with the current trunk we can determine if this is still needed

[PATCH] D67216: [cfi] Add flag to always generate .debug_frame

dcandler updated this revision to Diff 224581. dcandler retitled this revision from "[cfi] Add flag to always generate call frame information" to "[cfi] Add flag to always generate .debug_frame". dcandler edited the summary of this revision. dcandler added reviewers: rengolin, joerg. dcandler

[PATCH] D67160: [clang, ARM] Default to -fno-lax-vector-conversions in ARM v8.1-M.

simon_tatham added a comment. Hmmm. I take your point, and so I backed out my local version of this patch in order to try to solve the problem a different way in overload resolution. But in fact overloading on different vector types already seems to work fine: my in-progress patch series still

[PATCH] D68862: [ARM] Allocatable Global Register Variables for ARM

SjoerdMeijer added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:902 + std::vector = getTargetOpts().Features; + std::string SearchFeature = "+reserve-" + RegName.str(); + for (std::string : Features) { chill wrote: > SjoerdMeijer wrote: > >

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

hliao added a comment. PING for review, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68818/new/ https://reviews.llvm.org/D68818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r374549 - [ClangTidy] Separate tests for infrastructure and checkers, fixup

Author: gribozavr Date: Fri Oct 11 06:16:49 2019 New Revision: 374549 URL: http://llvm.org/viewvc/llvm-project?rev=374549=rev Log: [ClangTidy] Separate tests for infrastructure and checkers, fixup Renamed a file that I missed in r374540. Added:

[PATCH] D56345: [clang-format] Assert that filenames are not empty

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Thanks for the patch, I'm sorry it's taken so long sometimes items get lost...This looks to still be relevant, I think you'll need to rebase but it LGTM $ clang-format

[PATCH] D68824: Fix __builtin_assume_aligned with too large values.

erichkeane marked 5 inline comments as done. erichkeane added subscribers: majnemer, aaron.ballman. erichkeane added a comment. In D68824#1704942 , @rsmith wrote: > This seems to be missing a CodeGen test for what IR we generate on an > overly-large

[PATCH] D68862: [ARM] Allocatable Global Register Variables for ARM

chill added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:902 + std::vector = getTargetOpts().Features; + std::string SearchFeature = "+reserve-" + RegName.str(); + for (std::string : Features) { SjoerdMeijer wrote: > I was pointed at

[PATCH] D68862: [ARM] Allocatable Global Register Variables for ARM

chill added a comment. TBH, I quite dislike the creeping abuse of `SubtargetFeature`s as code generation options. cf. Target.td:1477 //===--===// // SubtargetFeature - A characteristic of the chip set. // IMHO, since

  1   2   >