[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge updated this revision to Diff 224767. nridge added a comment. Address final comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67901/new/ https://reviews.llvm.org/D67901 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp clang

[PATCH] D68896: PR43080: Do not build context-sensitive expressions during name classification.

rsmith updated this revision to Diff 224765. rsmith added a comment. Add comments for various NC_ classifications. Remove the unused and broken NC_NestedNameSpecifier classification and the code in ClassifyName that tries to classify names as nested name specifiers. Repository: rC Clang CHANG

[PATCH] D68914: [clang-format] Remove duplciate code from Invalid BOM detection

owenpan added inline comments. Comment at: clang/include/clang/Basic/SourceManager.h:232 +// nullptr +static const char *getInvalidBOM(StringRef BufStr); }; Can you make the parameter `const`? Comment at: clang/lib/Basic/SourceManage

[PATCH] D68914: [clang-format] Remove duplciate code from Invalid BOM detection

owenpan added a comment. Thank you for taking care of this! When I fixed a bug in this part of the code last time, I had to do it in both files. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68914/new/ https://reviews.llvm.org/D68914 _

[PATCH] D68923: Don't warn about missing declarations for partial template specializations

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Just like templates, they are excepted from the ODR rule. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68923 Files:

[PATCH] D68845: Don't emit unwanted constructor calls in co_return statements

aaronpuchert added a comment. @GorNishanov Do I read the standard correctly that there are no constraints on what `return_value` is? That is, could it also be a function pointer or function object? struct promise_function_pointer { // ... void (*return_value)(T&& value); }; struct

Re: [PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

Thank you for handling that I will look into your suggestions MyDeveloperDay On Sat, 12 Oct 2019 at 23:55, Nico Weber via Phabricator < revi...@reviews.llvm.org> wrote: > thakis added a comment. > > This fails on macOS: > > : 'RUN: at line 2'; grep -E "*code should be clang-formatted*" > /U

r374688 - Revert r374663 "[clang-format] Proposal for clang-format to give compiler style warnings"

Author: nico Date: Sat Oct 12 15:58:34 2019 New Revision: 374688 URL: http://llvm.org/viewvc/llvm-project?rev=374688&view=rev Log: Revert r374663 "[clang-format] Proposal for clang-format to give compiler style warnings" The test fails on macOS and looks a bit wrong, see comments on the review.

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

thakis added a comment. This fails on macOS: : 'RUN: at line 2'; grep -E "*code should be clang-formatted*" /Users/thakis/src/llvm-project/out/gn/obj/clang/test/Format/Output/dry-run.cpp.tmp.stderr -- Exit Code: 2 Command Output (stderr): -- grep: repetition-operator operand inv

[PATCH] D68767: [clang-format] NFC - Move functionality into functions to help code structure

MyDeveloperDay abandoned this revision. MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added a comment. Review comments regarding movign getInvalidBOM are addressed in D68914: [clang-format] Remove duplciate code from Invalid BOM detection Rep

[PATCH] D68915: [clang][IFS] Escape mangled name in-order to not break llvm-ifs with names mangled using MS ABI

plotfi created this revision. plotfi added reviewers: compnerd, cishida. Herald added a project: clang. Herald added a subscriber: cfe-commits. plotfi updated this revision to Diff 224756. Microsoft's ABI mangles names differently than Itanium and this breaks the LLVM yaml parser unless the name

[PATCH] D68915: [clang][IFS] Escape mangled name in-order to not break llvm-ifs with names mangled using MS ABI

plotfi updated this revision to Diff 224756. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68915/new/ https://reviews.llvm.org/D68915 Files: lib/Frontend/InterfaceStubFunctionsConsumer.cpp test/InterfaceStubs/inline.c test/InterfaceStubs/object.c test/Inte

[PATCH] D64874: [Sema] Improve handling of function pointer conversions

Mordante updated this revision to Diff 224753. Mordante added a comment. Removed the language version test. I also added `clang/test/CXX/conv/conv.fctptr/template-noreturn.cpp` to show this is not enough to allow `noreturn` to all language versions, so this file should not be committed. Do you

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

Daniel599 marked an inline comment as done. Daniel599 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:868 + if (CheckNewIdentifier != Idents.end() && + CheckNewIdentifier->second->isKeyword(getLangOpts())) { +

[PATCH] D68340: Add AIX toolchain and basic linker functionality

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:1 +//===--- AIX.cpp - AIX ToolChain Implementations *- C++ -*-===// +// See Jason's comment about the line length. Comment at: clang/lib/Drive

[PATCH] D68914: [clang-format] Remove duplciate code from Invalid BOM detection

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: bruno, arphaman, klimek, owenpan, mitchell-stellar, dexonsmith. MyDeveloperDay added projects: clang, clang-format, clang-tools-extra. Review comments on D68767: [clang-format] NFC - Move functionality into functions to help c

[PATCH] D68913: Adds fixit hints to the Wrange-loop-analysis

Mordante created this revision. Mordante added reviewers: rsmith, rtrieu, xbolva00. Mordante added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68913 Files: clang/include/clang/AST/Decl.h clang/lib/AST/Decl.cpp clang/lib/Sema/SemaStmt.cpp clang/test/S

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

Mordante created this revision. Mordante added reviewers: rsmith, rtrieu, xbolva00. Mordante added a project: clang. This makes the range loop warnings part of -Wall. This 'fixes' https://bugs.llvm.org/show_bug.cgi?id=32823 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68912

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f20bc17d005: [clang-format] Proposal for clang-format to give compiler style warnings (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

r374663 - [clang-format] Proposal for clang-format to give compiler style warnings

Author: paulhoad Date: Sat Oct 12 08:36:05 2019 New Revision: 374663 URL: http://llvm.org/viewvc/llvm-project?rev=374663&view=rev Log: [clang-format] Proposal for clang-format to give compiler style warnings Summary: Related somewhat to {D29039} On seeing a quote on twitter by @invalidop > If i

r374659 - remove an useless allocation found by scan-build - the new Dead nested assignment check

Author: sylvestre Date: Sat Oct 12 08:24:00 2019 New Revision: 374659 URL: http://llvm.org/viewvc/llvm-project?rev=374659&view=rev Log: remove an useless allocation found by scan-build - the new Dead nested assignment check Modified: cfe/trunk/lib/CodeGen/CGExprScalar.cpp Modified: cfe/trun

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

MyDeveloperDay updated this revision to Diff 224743. MyDeveloperDay added a comment. Incorporate feedback from @owenpan on D68767: [clang-format] NFC - Move functionality into functions to help code structure which this revision is reliant upon. CHANGES SINCE

[PATCH] D68767: [clang-format] NFC - Move functionality into functions to help code structure

MyDeveloperDay marked 6 inline comments as done. MyDeveloperDay added a comment. I'll likely abandon this review when D68554: [clang-format] Proposal for clang-format to give compiler style warnings lands Comment at: clang/tools/clang-format/

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

MyDeveloperDay updated this revision to Diff 224742. MyDeveloperDay added a comment. I'm going to commit this as it was approved, but I've added some simple lit tests, which exposed a double free, I fixed that up, and for the lit tests not to fail with an exit code I now return WarningAsError fr

[PATCH] D68845: Don't emit unwanted constructor calls in co_return statements

aaronpuchert added a comment. I'll add your test case, but I'll probably reuse the existing data structures. In D68845#1705430 , @Quuxplusone wrote: > Oh, and can you please make sure there are test cases for all the various > cases covered in P1155 > <