[PATCH] D68969: [clang-format] Remove the dependency on frontend

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: thakis, klimek, mitchell-stellar. MyDeveloperDay added projects: clang, clang-format. Herald added a subscriber: mgorny. Address review comments from D68554: [clang-format] Proposal for clang-format to give compiler style

Zorg migration to GitHub/monorepo

Hello everyone, We are in the middle of porting the majority of zorg to GitHub/monorepo. The following build factories will be ported and if you use one of those for your bots, you are all covered: * ClangBuilder.getClangCMakeBuildFactory (31 bots) *

[PATCH] D68902: [WebAssembly] Trapping fptoint builtins and intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG232fd99d9ee6: [WebAssembly] Trapping fptoint builtins and intrinsics (authored by tlively). Changed prior to commit: https://reviews.llvm.org/D68902?vs=224718=224945#toc Repository: rG LLVM Github

r374856 - [WebAssembly] Trapping fptoint builtins and intrinsics

Author: tlively Date: Mon Oct 14 18:11:51 2019 New Revision: 374856 URL: http://llvm.org/viewvc/llvm-project?rev=374856=rev Log: [WebAssembly] Trapping fptoint builtins and intrinsics Summary: The WebAssembly backend lowers fptoint instructions to a code sequence that checks for overflow to

LLVM buildmaster will be updated tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7PM Pacific time today. Thank Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [llvm-dev] Attention bot owners

Hi Diana, git 2.7.4 should be fine. Thanks Galina On Mon, Oct 14, 2019 at 12:57 AM Diana Picus wrote: > Hi Galina, > > Thanks for the heads up. > > On Fri, 11 Oct 2019 at 21:09, Galina Kistanova via llvm-dev > wrote: > > > > Hello all bots owners, > > > > As all of you know we move to

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

apazos added a comment. Yes Eli thanks for pointing out there are more scenarios that can fail. It looks like the best solution is to permit both flags on, but then bail out from doing this transformation if there is any type of tail call already in the function. This way we avoid messing with

[PATCH] D50360: [Concepts] Requires Expressions

saar.raz added inline comments. Comment at: lib/AST/StmtProfile.cpp:1325 + //expression. It is equivalent to the simple-requirement x++; [...] + // We therefore do not profile isSimple() here. + ID.AddBoolean(ExprReq->getNoexceptLoc().isValid());

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

rnk added a comment. In D67723#1708671 , @aprantl wrote: > Who is "we" in this context? The CodeView backend? Yes, the CodeView backend, sorry for the ambiguity. > As far as DWARF is concerned (and LLVM mostly inherits the DWARF semantics) > line 0 is

Re: r374844 - Revert "Dead Virtual Function Elimination"

Hi Jorge, Please mention the reason for a revert in revert commit messages. Also, until SVN stops being our system of record, please use SVN revision numbers to reference prior commits in reverts. On Mon, 14 Oct 2019 at 16:22, Jorge Gorbe Moya via cfe-commits < cfe-commits@lists.llvm.org> wrote:

r374844 - Revert "Dead Virtual Function Elimination"

Author: jgorbe Date: Mon Oct 14 16:25:25 2019 New Revision: 374844 URL: http://llvm.org/viewvc/llvm-project?rev=374844=rev Log: Revert "Dead Virtual Function Elimination" This reverts commit 9f6a873268e1ad9855873d9d8007086c0d01cf4f. Removed:

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

efriedma added a comment. > Bug2: test case provided above. Please Lewis take a look at how this case can > be fixed. Isn't the issue just that the code is checking for PseudoTAIL, and not PseudoTAILIndirect? What happens if a tail call has more than 8 arguments? What happens for a

Re: r374841 - [Modules][PCH] Hash input files content

Thanks Eric! On Mon, Oct 14, 2019 at 8:12 PM Eric Christopher wrote: > > This was breaking a few bots and I couldn't find you on irc so I've > reverted it thusly: > > echristo@jhereg ~/s/llvm-project> git llvm push > Pushing 1 commit: > 175b1b856ea Temporarily Revert [Modules][PCH] Hash input

Re: r374841 - [Modules][PCH] Hash input files content

This was breaking a few bots and I couldn't find you on irc so I've reverted it thusly: echristo@jhereg ~/s/llvm-project> git llvm push Pushing 1 commit: 175b1b856ea Temporarily Revert [Modules][PCH] Hash input files content as it's breaking a few bots. Sending

r374842 - Temporarily Revert [Modules][PCH] Hash input files content

Author: echristo Date: Mon Oct 14 16:14:24 2019 New Revision: 374842 URL: http://llvm.org/viewvc/llvm-project?rev=374842=rev Log: Temporarily Revert [Modules][PCH] Hash input files content as it's breaking a few bots. This reverts r374841 (git commit 2a1386c81de504b5bda44fbecf3f7b4cdfd748fc)

[PATCH] D67249: [Modules][PCH] Hash input files content

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a1386c81de5: [Modules][PCH] Hash input files content (authored by bruno). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67249/new/

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

apazos added a comment. Here is the bugpoint-reduced test case for the SPEC failure when enabling -msave-restore and allowing tail calls: Run the command llc test.ll -mattr=+save-restore -o out.s You will see the code generated is wrong: tail__riscv_restore_2 jr a5 target

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

dblaikie added a comment. In D67723#1708671 , @aprantl wrote: > > Since that change, we treat line zero the same as "no location". If there > > are no locations in a basic block, then the whole block inherits the line > > number from the block layout

r374840 - Add -fno-experimental-pass-manager to make clear which pass manager

Author: echristo Date: Mon Oct 14 16:01:48 2019 New Revision: 374840 URL: http://llvm.org/viewvc/llvm-project?rev=374840=rev Log: Add -fno-experimental-pass-manager to make clear which pass manager we're running and to make flipping the default not regress testing. Modified:

r374841 - [Modules][PCH] Hash input files content

Author: bruno Date: Mon Oct 14 16:02:03 2019 New Revision: 374841 URL: http://llvm.org/viewvc/llvm-project?rev=374841=rev Log: [Modules][PCH] Hash input files content Summary: When files often get touched during builds, the mtime based validation leads to different problems in implicit modules

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

aprantl added a comment. > Since that change, we treat line zero the same as "no location". If there are > no locations in a basic block, then the whole block inherits the line number > from the block layout predecessor, which could be unrelated. Keeping the > inlined call site location gives

Re: [PATCH] D68535: Fix loop unrolling initialization in the new pass manager

Thanks for the text - I didn't have anything to add or change so I just used it verbatim :) Committed thusly: Committed revision 374838. Committed f64329154c3 to svn. On Mon, Oct 7, 2019 at 9:36 AM Alina Sbirlea via Phabricator wrote: > > asbirlea added a comment. > > Maybe elaborate in the

Re: r374837 - [clang] add requirements to -Wa,-W test cases.

Hm, this means the test can't run on non-linux, so if someone breaks it on e.g. win they won't see the failure. Maybe add a --target=i386-unknown-linux instead? Then it might pass on all platforms. On Mon, Oct 14, 2019 at 6:48 PM Jian Cai via cfe-commits < cfe-commits@lists.llvm.org> wrote: >

r374838 - In the new pass manager use PTO.LoopUnrolling to determine when and how

Author: echristo Date: Mon Oct 14 15:56:07 2019 New Revision: 374838 URL: http://llvm.org/viewvc/llvm-project?rev=374838=rev Log: In the new pass manager use PTO.LoopUnrolling to determine when and how we will unroll loops. Also comment a few occasions where we need to know whether or not we're

r374837 - [clang] add requirements to -Wa,-W test cases.

Author: jcai19 Date: Mon Oct 14 15:51:12 2019 New Revision: 374837 URL: http://llvm.org/viewvc/llvm-project?rev=374837=rev Log: [clang] add requirements to -Wa,-W test cases. Include linux as a test requirement. Modified: cfe/trunk/test/Driver/as-w-option.c Modified:

[PATCH] D68882: [test] Fix test failure

This revision was automatically updated to reflect the committed changes. Closed by commit rG4498d41932c6: [test] Fix test failure (authored by efriedma). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68882/new/ https://reviews.llvm.org/D68882

[PATCH] D41284: [Concepts] Associated constraints infrastructure.

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Sema/Sema.h:5950 + /// associated constraints of an older declaration of which it is a + /// redeclaration + bool

r374836 - [test] Fix test failure

Author: efriedma Date: Mon Oct 14 15:44:42 2019 New Revision: 374836 URL: http://llvm.org/viewvc/llvm-project?rev=374836=rev Log: [test] Fix test failure The version mismatch symbol is version 9 on 32 bit android. Since this test isn't actually testing any android specific functionality, we

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

rnk added inline comments. Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1428 +if (isa(BI)) { + BI = --(BI->eraseFromParent()); + continue; Will this work if the dbg.value is the first instruction of a basic block? I'd

Re: r374834 - Add support to -Wa,-W in clang

This fails on both win and mac: http://45.33.8.238/mac/1678/step_6.txt http://45.33.8.238/win/485/step_6.txt On Mon, Oct 14, 2019 at 6:25 PM Jian Cai via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: jcai19 > Date: Mon Oct 14 15:28:03 2019 > New Revision: 374834 > > URL:

[PATCH] D68884: Add support to -Wa,-W in clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG4ec5205da701: Add support to -Wa,-W in clang (authored by jcai19). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68884/new/ https://reviews.llvm.org/D68884

[PATCH] D41217: [Concepts] Concept Specialization Expressions

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Only minor comments, let me know if you'd like me to take another look after addressing these, or just go ahead and commit. Thanks! Comment at:

[PATCH] D68720: Support -fstack-clash-protection for x86

rnk added a comment. For maintenance reasons, I'd really prefer it if we could find a way to reuse the existing code that calls an external stack probe function. What do you think about taking a look at X86RetpolineThunks.cpp and doing something similar to that? Basically, when the user sets

r374834 - Add support to -Wa,-W in clang

Author: jcai19 Date: Mon Oct 14 15:28:03 2019 New Revision: 374834 URL: http://llvm.org/viewvc/llvm-project?rev=374834=rev Log: Add support to -Wa,-W in clang Summary: Currently clang does not support -Wa,-W, which suppresses warning messages in GNU assembler. Add this option for gcc

r374833 - Revert "Add support to -Wa,-W in clang"

Author: jcai19 Date: Mon Oct 14 15:28:01 2019 New Revision: 374833 URL: http://llvm.org/viewvc/llvm-project?rev=374833=rev Log: Revert "Add support to -Wa,-W in clang" This reverts commit e72eeca43b9577be2aae55f7603febbf223a6ab3. Removed: cfe/trunk/test/Driver/as-w-option.c Modified:

[PATCH] D61675: [WIP] Update IRBuilder::CreateFNeg(...) to return a UnaryOperator

cameron.mcinally added a comment. Both the ASan build: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/35926 and the OCaml build: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/19255 have completed successfully with the latest patches. Will

[PATCH] D68896: PR43080: Do not build context-sensitive expressions during name classification.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7e8fe67f0e26: PR43080: Do not build context-sensitive expressions during name classification. (authored by Richard Smith richard-l...@metafoo.co.uk). Changed prior to commit:

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

akhuang updated this revision to Diff 224909. akhuang added a comment. - Fixes for DbgInfoIntrinsic type and change test cmd Reverted the line 0 change - I wasn't sure if it would be an issue since the debugger doesn't step through those lines. Repository: rG LLVM Github Monorepo CHANGES

r374826 - PR43080: Do not build context-sensitive expressions during name classification.

Author: rsmith Date: Mon Oct 14 14:53:03 2019 New Revision: 374826 URL: http://llvm.org/viewvc/llvm-project?rev=374826=rev Log: PR43080: Do not build context-sensitive expressions during name classification. Summary: We don't know what context to use until the classification result is consumed

[PATCH] D68884: Add support to -Wa,-W in clang

jcai19 updated this revision to Diff 224908. jcai19 added a comment. For autogenerated comment log. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68884/new/ https://reviews.llvm.org/D68884 Files: clang/lib/Driver/ToolChains/Clang.cpp

r374822 - Add support to -Wa,-W in clang

Author: jcai19 Date: Mon Oct 14 14:21:39 2019 New Revision: 374822 URL: http://llvm.org/viewvc/llvm-project?rev=374822=rev Log: Add support to -Wa,-W in clang Currently clang does not support -Wa,-W, which suppresses warning messages in GNU assembler. Add this option for gcc compatibility.

[PATCH] D68953: Enable most VFS tests on Windows

rnk added subscribers: arphaman, vsapsai, Bigcheese. rnk added a comment. +VFS people, mostly just to let them know @arphaman @Bigcheese @vsapsai Code changes all look good to me, but I had a bunch of questions. Comment at: clang/lib/Lex/HeaderSearch.cpp:782-783 //

r374821 - [NFC] Fix ClangScanDeps/static-analyzer.c test on Windows

Author: jkorous Date: Mon Oct 14 14:06:11 2019 New Revision: 374821 URL: http://llvm.org/viewvc/llvm-project?rev=374821=rev Log: [NFC] Fix ClangScanDeps/static-analyzer.c test on Windows Follow-up to c5d14b5c6fa Modified: cfe/trunk/test/ClangScanDeps/static-analyzer.c Modified:

[PATCH] D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics.

Bigcheese marked an inline comment as done. Bigcheese added inline comments. Comment at: include/clang/Lex/HeaderSearchOptions.h:209 + /// + /// This includes things like the full header search path. + unsigned ModulesStrictHash : 1; bruno wrote: > What else

r374819 - [OPNEMP]Allow num_tasks clause in combined task-based directives.

Author: abataev Date: Mon Oct 14 13:44:34 2019 New Revision: 374819 URL: http://llvm.org/viewvc/llvm-project?rev=374819=rev Log: [OPNEMP]Allow num_tasks clause in combined task-based directives. The expression of the num_tasks clause must be captured in the combined task-based directives, like

[PATCH] D41284: [Concepts] Associated constraints infrastructure.

saar.raz updated this revision to Diff 224898. saar.raz marked 15 inline comments as done. saar.raz added a comment. Remove unrelated cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41284/new/ https://reviews.llvm.org/D41284 Files:

[PATCH] D68093: [clang-scan-deps][static analyzer] Support for clang --analyze in scan-deps

This revision was automatically updated to reflect the committed changes. Closed by commit rGc5d14b5c6fa9: [clang-scan-deps] Support for clang --analyze in clang-scan-deps (authored by jkorous). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

rnk added a comment. Based on what we learned in https://llvm.org/PR43530, I think we still want to use the location of the call site and not line zero. :( Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1431 +} +BI->setDebugLoc(TheCallDL); +

r374815 - [clang-scan-deps] Support for clang --analyze in clang-scan-deps

Author: jkorous Date: Mon Oct 14 13:15:01 2019 New Revision: 374815 URL: http://llvm.org/viewvc/llvm-project?rev=374815=rev Log: [clang-scan-deps] Support for clang --analyze in clang-scan-deps The goal is to have 100% fidelity in clang-scan-deps behavior when --analyze is present in compilation

[clang-tools-extra] r374815 - [clang-scan-deps] Support for clang --analyze in clang-scan-deps

Author: jkorous Date: Mon Oct 14 13:15:01 2019 New Revision: 374815 URL: http://llvm.org/viewvc/llvm-project?rev=374815=rev Log: [clang-scan-deps] Support for clang --analyze in clang-scan-deps The goal is to have 100% fidelity in clang-scan-deps behavior when --analyze is present in compilation

r374810 - [OPNEMP]Allow grainsize clause in combined task-based directives.

Author: abataev Date: Mon Oct 14 12:29:52 2019 New Revision: 374810 URL: http://llvm.org/viewvc/llvm-project?rev=374810=rev Log: [OPNEMP]Allow grainsize clause in combined task-based directives. The expression of the grainsize clause must be captured in the combined task-based directives, like

[PATCH] D68896: PR43080: Do not build context-sensitive expressions during name classification.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM > I'm inclined to defer doing that for now, if that's OK :) Sure. Comment at: lib/Sema/SemaDecl.cpp:1191 + return NameClassification::ContextIndependentExpr( +

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

timwoj added a comment. In D68346#1708384 , @timwoj wrote: > Changed option name to SpacesInConditionalStatement, added > isKeywordWithCondition method, added some extra tests Sorry for the delay on getting back to this. I'm not the original author and

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

timwoj updated this revision to Diff 224890. timwoj added a comment. Changed option name to SpacesInConditionalStatement, added isKeywordWithCondition method, added some extra tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68346/new/

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

akhuang updated this revision to Diff 224888. akhuang added a comment. - Set inlined locations to line 0 - Fix to remove all debug info intrinsics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67723/new/ https://reviews.llvm.org/D67723 Files:

[PATCH] D68953: Enable most VFS tests on Windows

amccarth created this revision. amccarth added a reviewer: rnk. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Inconsistencies in when/if paths are cannoicalized prevented VFS tests from working on Windows. This fixes the primary cause and enables most of the

r374805 - [clang][IFS][test] Fixing lit test breakages on macOS due to r374798

Author: zer0 Date: Mon Oct 14 11:57:29 2019 New Revision: 374805 URL: http://llvm.org/viewvc/llvm-project?rev=374805=rev Log: [clang][IFS][test] Fixing lit test breakages on macOS due to r374798 Adding the quotes breaks tests because on Darwin the name mangling is prefixed with an underscore.

[PATCH] D68884: Add support to -Wa,-W in clang

bcain accepted this revision. bcain added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68884/new/ https://reviews.llvm.org/D68884 ___

[PATCH] D66827: Add support for MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

DarkShadow44 added a comment. @akhuang Any update on this? I'd love to see this upstreamed. I'd offer to help, but I'm not well versed in clang. FWIW, I also found a small bug when using this patchset: void func1(void * __ptr32 test) { } int main() { func1(0); return 0;

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

This revision was automatically updated to reflect the committed changes. Closed by commit rG37e31e629dc1: [clangd] Improve semantic highlighting in dependent contexts (fixes #154) (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] r374799 - [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

Author: nridge Date: Mon Oct 14 11:26:13 2019 New Revision: 374799 URL: http://llvm.org/viewvc/llvm-project?rev=374799=rev Log: [clangd] Improve semantic highlighting in dependent contexts (fixes #154) Reviewers: hokein Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet,

[PATCH] D68915: [clang][IFS] Escape mangled name in-order to not break llvm-ifs with names mangled using MS ABI

plotfi added a comment. I see what went wrong. Will post a fix shortly. In D68915#1708297 , @thakis wrote: > On macOS symbols are prefixed with an underscore: > > Command Output (stderr): > -- >

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge updated this revision to Diff 224880. nridge marked 2 inline comments as done. nridge added a comment. Address last review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67901/new/ https://reviews.llvm.org/D67901 Files:

[PATCH] D68915: [clang][IFS] Escape mangled name in-order to not break llvm-ifs with names mangled using MS ABI

thakis added a comment. On macOS symbols are prefixed with an underscore: Command Output (stderr): -- /Users/thakis/src/llvm-project/clang/test/InterfaceStubs/object.c:5:16: error: CHECK-TAPI: expected string not found in input // CHECK-TAPI: "data" : { Type: Object, Size: 4 }

[PATCH] D61675: [WIP] Update IRBuilder::CreateFNeg(...) to return a UnaryOperator

cameron.mcinally added a comment. Fix incoming. Sorry for not running the ASan tests... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61675/new/ https://reviews.llvm.org/D61675 ___ cfe-commits mailing

[PATCH] D68947: [libc++][test] Add license headers to test/support/archetypes.*

This revision was automatically updated to reflect the committed changes. Closed by commit rGc86ba5818833: [libc++][test] Add license headers to test/support/archetypes.* (authored by CaseyCarter). Herald added subscribers: libcxx-commits, christof. Herald added a project: libc++. Changed prior

[PATCH] D68915: [clang][IFS] Escape mangled name in-order to not break llvm-ifs with names mangled using MS ABI

This revision was automatically updated to reflect the committed changes. Closed by commit rG76f9869bf200: [clang][IFS] Escape mangled names so MS ABI doesnt break YAML parsing. (authored by plotfi). Changed prior to commit: https://reviews.llvm.org/D68915?vs=224756=224879#toc Repository:

r374798 - [clang][IFS] Escape mangled names so MS ABI doesn't break YAML parsing.

Author: zer0 Date: Mon Oct 14 11:03:03 2019 New Revision: 374798 URL: http://llvm.org/viewvc/llvm-project?rev=374798=rev Log: [clang][IFS] Escape mangled names so MS ABI doesn't break YAML parsing. Microsoft's ABI mangles names differently than Itanium and this breaks the LLVM yaml parser

[PATCH] D61675: [WIP] Update IRBuilder::CreateFNeg(...) to return a UnaryOperator

cameron.mcinally added a comment. Apologies, @pcc. Looking now. Will revert if it's not obvious... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61675/new/ https://reviews.llvm.org/D61675 ___

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

lenary added a comment. Please can you rebase these changes? Something has changed in RISCVToolchain.cpp and they are failing to build. Q: Is there a plan to support multilib aliases (`MULTILIB_REUSE`)? I'm happy for this to be in a follow-up patch, would just like to know the plan.

[PATCH] D61675: [WIP] Update IRBuilder::CreateFNeg(...) to return a UnaryOperator

pcc added a comment. Hi, it looks like this patch has caused a test failure under asan: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/35922/steps/check-llvm%20asan/logs/stdio Can you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics.

bruno added a comment. Hi Michael, thanks for working on this! Comment at: include/clang/Lex/HeaderSearchOptions.h:206 + /// Weather we should include all things that could impact the module in the + /// hash. *whether Comment at:

r374787 - [OPENMP]Fix codegen for private variably length vars in combined

Author: abataev Date: Mon Oct 14 09:44:01 2019 New Revision: 374787 URL: http://llvm.org/viewvc/llvm-project?rev=374787=rev Log: [OPENMP]Fix codegen for private variably length vars in combined constructs. If OpenMP construct includes several capturing regions and the variable is declared as

[PATCH] D67185: [RISCV] Add support for -ffixed-xX flags

asb added a comment. In D67185#1707849 , @lenary wrote: > Note, D68862 is in-progress at the moment, > which is related to this patch. Indeed - Simon, could you please go through that patch and ensure that the

[PATCH] D67608: [ARM] Preserve fpu behaviour for '-crypto'

This revision was automatically updated to reflect the committed changes. Closed by commit rG2cb43b45713d: [ARM] Preserve fpu behaviour for -crypto (authored by dnsampaio). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67608/new/

r374785 - [ARM] Preserve fpu behaviour for '-crypto'

Author: dnsampaio Date: Mon Oct 14 09:29:26 2019 New Revision: 374785 URL: http://llvm.org/viewvc/llvm-project?rev=374785=rev Log: [ARM] Preserve fpu behaviour for '-crypto' Summary: This patch restores the behaviour that -fpu overwrites the architecture obtained from -march or -mcpu flags, not

[PATCH] D68947: [libc++][test] Add license headers to test/support/archetypes.*

CaseyCarter created this revision. CaseyCarter added reviewers: mclow.lists, EricWF, ldionne. Herald added a subscriber: dexonsmith. These two files (`archetypes.h` and `archetypes.ipp`) are missing license headers. https://reviews.llvm.org/D68947 Files: test/support/archetypes.h

[PATCH] D68862: [ARM] Allocatable Global Register Variables for ARM

chill added a comment. In D68862#1708079 , @carwil wrote: > > IMHO, since reserved registes are per-function, this strongly suggests > > implementation as function attribute(s), rather than subtarget features > > (also for the pre-existing r9). > > What

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

dblaikie added a comment. In D68117#1708114 , @SouraVX wrote: > In D68117#1707680 , @dblaikie wrote: > > > In D68117#1707578 , @SouraVX wrote: > > > > > In D68117#1702595

[PATCH] D61675: [WIP] Update IRBuilder::CreateFNeg(...) to return a UnaryOperator

cameron.mcinally added a comment. Recommitted this patch with Ocaml test fix. I was not able to find quick-start documentation for the Ocaml bindings, so the Ocaml failure has not been tested. That said, the failure mode seems extremely low risk. Will monitor the buildbots for problems...

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX added a comment. In D68117#1707680 , @dblaikie wrote: > In D68117#1707578 , @SouraVX wrote: > > > In D68117#1702595 , @probinson > > wrote: > > > > > We really do

[PATCH] D68862: [ARM] Allocatable Global Register Variables for ARM

anwel updated this revision to Diff 224862. anwel added a comment. Applied some minor changes suggested in the comments, including renaming the array of reserved registers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68862/new/ https://reviews.llvm.org/D68862 Files:

[PATCH] D68862: [ARM] Allocatable Global Register Variables for ARM

carwil added a comment. > IMHO, since reserved registes are per-function, this strongly suggests > implementation as function attribute(s), rather than subtarget features (also > for the pre-existing r9). What do you mean reserved registers are per-function? That sounds like you're describing

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

ABataev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:133 /// returned if there are no more bundles to be read. - virtual StringRef ReadBundleStart(MemoryBuffer ) = 0; + virtual Expected> + ReadBundleStart(MemoryBuffer ) = 0;

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

lenary added a comment. @khchen Thanks for your patch! It is now landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67409/new/ https://reviews.llvm.org/D67409 ___ cfe-commits mailing list

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcdcf58e5af02: [RISCV] enable LTO support, pass some options to linker. (authored by lenary). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67409/new/

r374774 - [RISCV] enable LTO support, pass some options to linker.

Author: lenary Date: Mon Oct 14 07:00:13 2019 New Revision: 374774 URL: http://llvm.org/viewvc/llvm-project?rev=374774=rev Log: [RISCV] enable LTO support, pass some options to linker. Summary: 1. enable LTO need to pass target feature and abi to LTO code generation RISCV backend need the

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

khchen added a comment. In D67409#1707940 , @lenary wrote: > @khchen do you need me to commit this for you? Yes, please help me, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67409/new/ https://reviews.llvm.org/D67409

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

lenary added a comment. @khchen do you need me to commit this for you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67409/new/ https://reviews.llvm.org/D67409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet added a comment. A gentle ping @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68028/new/ https://reviews.llvm.org/D68028 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66733: [analyzer] Add a checker option to detect nested dead stores

Szelethus added a comment. In D66733#1706521 , @sylvestre.ledru wrote: > I added it to the release notes here : https://reviews.llvm.org/rC374593 > I am wondering if the option( WarnForDeadNestedAssignments ) to disable it > is really necessary? > I

[PATCH] D67185: [RISCV] Add support for -ffixed-xX flags

simoncook marked 2 inline comments as done. simoncook added inline comments. Comment at: clang/include/clang/Driver/Options.td:2224 HelpText<"Don't workaround Cortex-A53 erratum 835769 (AArch64 only)">; -foreach i = {1-7,9-15,18,20-28} in - def ffixed_x#i : Flag<["-"],

[PATCH] D67185: [RISCV] Add support for -ffixed-xX flags

lenary added a comment. Note, D68862 is in-progress at the moment, which is related to this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67185/new/ https://reviews.llvm.org/D67185

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. When moving a function definition to declaration location we also need to handle renaming of the both function and

[PATCH] D66647: [clangd] DefineInline action apply logic with fully qualified names

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:226 +llvm::Expected +renameParameters(const FunctionDecl *Dest, const FunctionDecl *Source) { + const SourceManager = Dest->getASTContext().getSourceManager();

[PATCH] D66647: [clangd] DefineInline action apply logic with fully qualified names

kadircet updated this revision to Diff 224824. kadircet added a comment. - Move parameter renaming logic to a separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66647/new/ https://reviews.llvm.org/D66647 Files:

[PATCH] D68581: Include leading attributes in DeclStmt's SourceRange

sberg updated this revision to Diff 224823. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68581/new/ https://reviews.llvm.org/D68581 Files: clang/lib/Parse/ParseStmt.cpp clang/test/AST/sourceranges.cpp Index: clang/test/AST/sourceranges.cpp

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

khchen updated this revision to Diff 224821. khchen added a comment. rebase master, https://reviews.llvm.org/D66003 changed the `riscv::getRISCVTargetFeatures` interface. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67409/new/ https://reviews.llvm.org/D67409 Files:

[PATCH] D68914: [clang-format] Remove duplciate code from Invalid BOM detection

MyDeveloperDay added a comment. I tend to agree mainly given that StringRef is used without const elsewhere. I'll bow to better judgement. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68914/new/ https://reviews.llvm.org/D68914 ___

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

klimek added a comment. In D68554#1707540 , @thakis wrote: > > Could you or anyone else point me to a good example, I'd definitely like > > to take a look. > > http://llvm-cs.pcc.me.uk/include/llvm/Support/SourceMgr.h/rSMDiagnostic -- > > > `via

  1   2   >