[PATCH] D69213: Avoid appending the source directory to an absolute path

aprantl created this revision. aprantl added reviewers: JDevlieghere, davide. aprantl added a project: debug-info. When building a precompiled header in `-fmodule-format=obj` (i.e., `-gmodules) in an absolute path, the locig in CGDebugInfo::createCompileUnit would unconditionally append the sour

[PATCH] D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics.

thakis added a comment. Looks like this fails on win: http://45.33.8.238/win/841/step_6.txt Ptal! Maybe just cat'ing all files instead of echoing the first and piping into cat works? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68528/new/ https

[PATCH] D68591: [analyzer] PR43551: Do not dereferce void* in UndefOrNullArgVisitor

NoQ added a comment. Decided to commit myself in order to hurry things up^^ Also rC375328 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68591/new/ https://reviews.llvm.org/D68591 _

[PATCH] D68591: [analyzer] PR43551: Do not dereferce void* in UndefOrNullArgVisitor

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a5df7312ec2: [analyzer] PR43551: Do not dereferce void* in UndefOrNullArgVisitor. (authored by dergachev.a). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[PATCH] D66043: Add to -Wparentheses case of bitwise-and ("&") and bitwise-or ("|") verses conditional operator ("?:")

This revision was automatically updated to reflect the committed changes. Closed by commit rG637af4cc3780: Add -Wbitwise-conditional-parentheses to warn on mixing '|' and '&' with "?:" (authored by rtrieu). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D66043

r375329 - [analyzer] PR43551: Do not dereferce void* in UndefOrNullArgVisitor.

Author: dergachev Date: Fri Oct 18 18:50:46 2019 New Revision: 375329 URL: http://llvm.org/viewvc/llvm-project?rev=375329&view=rev Log: [analyzer] PR43551: Do not dereferce void* in UndefOrNullArgVisitor. Patch by Kristóf Umann! Differential Revision: https://reviews.llvm.org/D68591 Modified:

r375328 - [analyzer] Fix a crash on tracking Objective-C 'self' as a control dependency.

Author: dergachev Date: Fri Oct 18 18:50:43 2019 New Revision: 375328 URL: http://llvm.org/viewvc/llvm-project?rev=375328&view=rev Log: [analyzer] Fix a crash on tracking Objective-C 'self' as a control dependency. 'self' was previously never tracked, but now it can be tracked because it may be p

r375327 - [Docs] Fix header level.

Author: mspencer Date: Fri Oct 18 18:48:57 2019 New Revision: 375327 URL: http://llvm.org/viewvc/llvm-project?rev=375327&view=rev Log: [Docs] Fix header level. Modified: cfe/trunk/docs/Modules.rst Modified: cfe/trunk/docs/Modules.rst URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/M

r375326 - Add -Wbitwise-conditional-parentheses to warn on mixing '|' and '&' with "?:"

Author: rtrieu Date: Fri Oct 18 18:47:49 2019 New Revision: 375326 URL: http://llvm.org/viewvc/llvm-project?rev=375326&view=rev Log: Add -Wbitwise-conditional-parentheses to warn on mixing '|' and '&' with "?:" Extend -Wparentheses to cover mixing bitwise-and and bitwise-or with the conditional o

[PATCH] D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics.

This revision was automatically updated to reflect the committed changes. Closed by commit rG14a3f77ba103: [Implicit Modules] Add -cc1 option -fmodules-strict-context-hash which includes… (authored by Bigcheese). Changed prior to commit: https://reviews.llvm.org/D68528?vs=225326&id=225731#toc

[PATCH] D63164: [HIP] Add option to force lambda nameing following ODR in HIP/CUDA.

hliao abandoned this revision. hliao added a comment. revised change is already committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63164/new/ https://reviews.llvm.org/D63164 ___ cfe-commits maili

r375322 - [Implicit Modules] Add -cc1 option -fmodules-strict-context-hash which includes search paths and diagnostics.

Author: mspencer Date: Fri Oct 18 18:36:37 2019 New Revision: 375322 URL: http://llvm.org/viewvc/llvm-project?rev=375322&view=rev Log: [Implicit Modules] Add -cc1 option -fmodules-strict-context-hash which includes search paths and diagnostics. Differential Revision: https://reviews.llvm.org/D68

[PATCH] D68891: Remove unnecessary triple from test

JohnTitor added a comment. ping @rsmith Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68891/new/ https://reviews.llvm.org/D68891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

NoQ edited reviewers, added: NoQ; removed: dergachev.a. NoQ added inline comments. Comment at: clang/test/Analysis/Inputs/expected-plists/nullability-notes.m.plist:191 -10 14 It looks like the body farm for the property accessor has stopped working

[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

aprantl updated this revision to Diff 225729. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68108/new/ https://reviews.llvm.org/D68108 Files: clang/include/clang/AST/DeclObjC.h clang/lib/AST/DeclObjC.cpp clang/lib/Analysis/BodyFarm.cpp clang/lib/CodeGen/CGObjC.cpp clang/lib/Cod

[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

aprantl updated this revision to Diff 225727. aprantl added a comment. Addressed most of the feedback, explained the rest. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68108/new/ https://reviews.llvm.org/D68108 Files: clang/include/clang/AST/DeclObjC.h clang/lib/AST/DeclObjC.cpp

[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

aprantl marked 8 inline comments as done. aprantl added inline comments. Comment at: clang/lib/Analysis/BodyFarm.cpp:843 +return Val.getValue(); + Val = nullptr; + rjmccall wrote: > Why did this logic need to change? I don't have a satisfying answer for this

[PATCH] D66046: Add new tautological compare warning for bitwise-or with a non-zero constant

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b0d14a8f0cc: New tautological warning for bitwise-or with non-zero constant always true. (authored by rtrieu). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D66046?vs

r375318 - New tautological warning for bitwise-or with non-zero constant always true.

Author: rtrieu Date: Fri Oct 18 17:57:23 2019 New Revision: 375318 URL: http://llvm.org/viewvc/llvm-project?rev=375318&view=rev Log: New tautological warning for bitwise-or with non-zero constant always true. Taking a value and the bitwise-or it with a non-zero constant will always result in a no

[clang-tools-extra] r375316 - Move endian constant from Host.h to SwapByteOrder.h, prune include

Author: rnk Date: Fri Oct 18 17:48:11 2019 New Revision: 375316 URL: http://llvm.org/viewvc/llvm-project?rev=375316&view=rev Log: Move endian constant from Host.h to SwapByteOrder.h, prune include Works on this dependency chain: ArrayRef.h -> Hashing.h -> --CUT-- Host.h -> StringMap.h / S

r375316 - Move endian constant from Host.h to SwapByteOrder.h, prune include

Author: rnk Date: Fri Oct 18 17:48:11 2019 New Revision: 375316 URL: http://llvm.org/viewvc/llvm-project?rev=375316&view=rev Log: Move endian constant from Host.h to SwapByteOrder.h, prune include Works on this dependency chain: ArrayRef.h -> Hashing.h -> --CUT-- Host.h -> StringMap.h / S

[PATCH] D66437: Sema: Create a no-op implicit cast for lvalue function conversions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG766f15814a01: Sema: Create a no-op implicit cast for lvalue function conversions. (authored by pcc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66437/new/

r375313 - Sema: Create a no-op implicit cast for lvalue function conversions.

Author: pcc Date: Fri Oct 18 17:34:54 2019 New Revision: 375313 URL: http://llvm.org/viewvc/llvm-project?rev=375313&view=rev Log: Sema: Create a no-op implicit cast for lvalue function conversions. This fixes an assertion failure in the case where an implicit conversion for a function call involv

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

This revision was automatically updated to reflect the committed changes. Closed by commit rG243ebfba17da: [hip][cuda] Fix the extended lambda name mangling issue. (authored by hliao). Changed prior to commit: https://reviews.llvm.org/D68818?vs=225678&id=225720#toc Repository: rG LLVM Github

[PATCH] D69124: [clang][driver] Print compilation phases with indentation.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd7a487adfedb: [clang][driver] Print compilation phases with indentation. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69124/new/ https

r375310 - [clang][driver] Print compilation phases with indentation.

Author: hliao Date: Fri Oct 18 17:17:00 2019 New Revision: 375310 URL: http://llvm.org/viewvc/llvm-project?rev=375310&view=rev Log: [clang][driver] Print compilation phases with indentation. Reviewers: tra, sfantao, echristo Subscribers: cfe-commits Tags: #clang Differential Revision: https://

r375309 - [hip][cuda] Fix the extended lambda name mangling issue.

Author: hliao Date: Fri Oct 18 17:15:19 2019 New Revision: 375309 URL: http://llvm.org/viewvc/llvm-project?rev=375309&view=rev Log: [hip][cuda] Fix the extended lambda name mangling issue. Summary: - HIP/CUDA host side needs to use device kernel symbol name to match the device side binaries. Wi

r375308 - [analyzer] Specify the C++ standard in more tests.

Author: dergachev Date: Fri Oct 18 17:08:17 2019 New Revision: 375308 URL: http://llvm.org/viewvc/llvm-project?rev=375308&view=rev Log: [analyzer] Specify the C++ standard in more tests. Makes life easier for downstream developers with different default standard. Modified: cfe/trunk/test/Ana

r375306 - [c++20] Add rewriting from comparison operators to <=> / ==.

Author: rsmith Date: Fri Oct 18 17:04:43 2019 New Revision: 375306 URL: http://llvm.org/viewvc/llvm-project?rev=375306&view=rev Log: [c++20] Add rewriting from comparison operators to <=> / ==. This adds support for rewriting <, >, <=, and >= to a normal or reversed call to operator<=>, for rewri

r375305 - [c++20] Add CXXRewrittenBinaryOperator to represent a comparison

Author: rsmith Date: Fri Oct 18 17:04:38 2019 New Revision: 375305 URL: http://llvm.org/viewvc/llvm-project?rev=375305&view=rev Log: [c++20] Add CXXRewrittenBinaryOperator to represent a comparison operator that is rewritten as a call to multiple other operators. No functionality change yet: noth

[PATCH] D63031: DebugInfo: Render the canonical name of a class template specialization, even when nested in another class template specialization

This revision was automatically updated to reflect the committed changes. Closed by commit rG9fdd09a4ccd0: DebugInfo: Render the canonical name of a class template specialization, even… (authored by dblaikie). Changed prior to commit: https://reviews.llvm.org/D63031?vs=203639&id=225718#toc Rep

r375304 - DebugInfo: Render the canonical name of a class template specialization, even when nested in another class template specialization

Author: dblaikie Date: Fri Oct 18 16:58:34 2019 New Revision: 375304 URL: http://llvm.org/viewvc/llvm-project?rev=375304&view=rev Log: DebugInfo: Render the canonical name of a class template specialization, even when nested in another class template specialization Differential Revision: https:/

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

morehouse added inline comments. Comment at: tools/clang-fuzzer/ClangObjectiveCFuzzer.cpp:19 + +extern "C" int LLVMFuzzerInitialize(int *argc, char ***argv) { return 0; } + Nit: Since it does nothing, let's omit the `LLVMFuzzerInitialize` definition. =

[PATCH] D69137: [profile] Do not cache __llvm_profile_get_filename result

This revision was automatically updated to reflect the committed changes. Closed by commit rG937241b0d9e8: [profile] Do not cache __llvm_profile_get_filename result (authored by vsk). Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Repository: rG LLV

r375301 - [profile] Do not cache __llvm_profile_get_filename result

Author: vedantk Date: Fri Oct 18 16:33:40 2019 New Revision: 375301 URL: http://llvm.org/viewvc/llvm-project?rev=375301&view=rev Log: [profile] Do not cache __llvm_profile_get_filename result When the %m filename pattern is used, the filename is unique to each image, so the cached value is wrong.

[PATCH] D69124: [clang][driver] Print compilation phases with indentation.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Neat. I like the visual cues showing what gets passed on to the next processing stage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69124/new/ https

[PATCH] D66983: [WebAssembly] Add wasm-specific vector shuffle builtin and intrinsic

aheejin added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsWebAssembly.td:117 + llvm_i32_ty, llvm_i32_ty, llvm_i32_ty, llvm_i32_ty, llvm_i32_ty, + llvm_i32_ty, llvm_i32_ty, llvm_i32_ty, llvm_i32_ty], +[IntrNoMem, IntrSpeculatable

[PATCH] D69090: [Try 2] Include sanitize blacklist and other extra deps as part of scan-deps output

dexonsmith added a comment. In D69090#1713983 , @kousikk wrote: > Thanks for the comment @jkorous. > > > I think you could've just used CHECK-DAG to fix the tests. It *might* be a > > bit more robust. Although just reordering checks seems perfectly fine t

[PATCH] D66437: Sema: Create a no-op implicit cast for lvalue function conversions.

pcc added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66437/new/ https://reviews.llvm.org/D66437 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

dblaikie added a subscriber: rsmith. dblaikie added a comment. In D68117#1714091 , @SouraVX wrote: > Hi @probinson @dblaikie @aprantl , I've was investigating and working on > your inputs regarding the problem with DW_at_defaulted once. I think clang >

[PATCH] D69088: [Lex] #pragma clang transform

hsaito added a comment. In D69088#1715210 , @Meinersbur wrote: > I'd rather just enable them with a command-line switch, such as > `-fexperimental-transform`. This direction works for me. `-fexperimental-transform-pragma` might be better, though. Rep

[PATCH] D69184: [libTooling] Introduce general combinator for fixed-value `MatchConsumer`s.

gribozavr added a comment. What are the use cases for non-text values? I like the name `text` much better... If the name conflict is the issue, I think you could rename it to `toText` -- it would even read more fluently `change(toText("abc"))`, also making it obvious that we are not changing *t

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. In D69088#1715038 , @hsaito wrote: > If there is a precedence, just follow that. Else, how to spell an > experimental clang pragma would be a good discussion topic by itself. If I > need to provide a discussion starter, I'd sa

Re: Zorg migration to GitHub/monorepo

On Mon, Oct 14, 2019 at 6:16 PM Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hello everyone, > > > > We are in the middle of porting the majority of zorg to > GitHub/monorepo. The following build factories will be ported and if you > use one of those for your bots, you a

[PATCH] D69194: build: add clang-cl and clang++ symlinks in the build tree

smeenai added a comment. > Furthermore, the current build only installs the symbolic links in the > install tree, not the build tree This isn't right ... if I look at my LLVM build tree, I have clang, clang++ and clang-cl symlinks, all pointing to the actual clang-10 binary. Where are you seei

[PATCH] D69194: build: add clang-cl and clang++ symlinks in the build tree

compnerd created this revision. compnerd added reviewers: xiaobai, beanz, smeenai. Herald added a subscriber: mgorny. Herald added a project: clang. This adds the clang-cl and clang++ symlinks. Since there are no targets to depend on for this, we cannot force the creation of the symlinks. Furth

[PATCH] D67647: [Consumed] Refactor handleCall to take function argument list. NFC.

dblaikie added a comment. In D67647#1713974 , @comex wrote: > So, I landed this patch but had to revert it as it broke the build on MSVC > (and only MSVC). That was almost a month ago, but I haven't gotten back > around to this until now – sorry :| > >

r375286 - [analyzer] exploded-graph-rewriter: Unforget to censor stmt_ids in the test.

Author: dergachev Date: Fri Oct 18 13:48:21 2019 New Revision: 375286 URL: http://llvm.org/viewvc/llvm-project?rev=375286&view=rev Log: [analyzer] exploded-graph-rewriter: Unforget to censor stmt_ids in the test. They're not stable across machines. Fixes buildbots after r375278. Modified: c

[PATCH] D69150: [analyzer] Fix hidden node traversal in exploded graph dumps.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7a17f197093a: [analyzer] Fix hidden node traversal in exploded graph dumps. (authored by dergachev.a). Changed prior to commit: https://reviews.llvm.org/D69150?vs=225547&id=225685#toc Repository: rG

r375279 - [analyzer] exploded-graph-rewriter: Fix dump for state 0.

Author: dergachev Date: Fri Oct 18 13:15:32 2019 New Revision: 375279 URL: http://llvm.org/viewvc/llvm-project?rev=375279&view=rev Log: [analyzer] exploded-graph-rewriter: Fix dump for state 0. It shouldn't say "unspecified" when the state is specified to be empty. Modified: cfe/trunk/test/A

r375282 - [analyzer] exploded-graph-rewriter: Rename Environment to Expressions.

Author: dergachev Date: Fri Oct 18 13:15:41 2019 New Revision: 375282 URL: http://llvm.org/viewvc/llvm-project?rev=375282&view=rev Log: [analyzer] exploded-graph-rewriter: Rename Environment to Expressions. It's less confusing for newcomers. Modified: cfe/trunk/test/Analysis/exploded-graph-r

r375281 - [analyzer] Fix FieldRegion dumps.

Author: dergachev Date: Fri Oct 18 13:15:39 2019 New Revision: 375281 URL: http://llvm.org/viewvc/llvm-project?rev=375281&view=rev Log: [analyzer] Fix FieldRegion dumps. The '->' thing has always been confusing; the actual operation '->' translates to a pointer dereference together with adding a

r375280 - [analyzer] Drop the logic for collapsing the state if it's same as in preds.

Author: dergachev Date: Fri Oct 18 13:15:35 2019 New Revision: 375280 URL: http://llvm.org/viewvc/llvm-project?rev=375280&view=rev Log: [analyzer] Drop the logic for collapsing the state if it's same as in preds. One of the first attempts to reduce the size of the exploded graph dumps was to skip

r375278 - [analyzer] Fix hidden node traversal in exploded graph dumps.

Author: dergachev Date: Fri Oct 18 13:15:29 2019 New Revision: 375278 URL: http://llvm.org/viewvc/llvm-project?rev=375278&view=rev Log: [analyzer] Fix hidden node traversal in exploded graph dumps. The joined nodes now actually have the same state. That was intended from the start but the origina

[PATCH] D69150: [analyzer] Fix hidden node traversal in exploded graph dumps.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/test/Analysis/dump_egraph.c:46 // CHECK: \"pretty\": \"*x\", \"location\": \{ \"line\": 18, \"column\": 10, \"file\": \"{{(.+)}}dump_egraph.c\" \} Charusso wrote: > `\"file\"

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/AST/DeclCXX.h:1713 + /// mangling number. + bool hasKnownInternalLinkage() const { +assert(isLambda() && "Not a lambda closure type!

[libunwind] r375275 - [libunwind][Android] Fix findUnwindSections for ARM EHABI Bionic

Author: rprichard Date: Fri Oct 18 12:59:22 2019 New Revision: 375275 URL: http://llvm.org/viewvc/llvm-project?rev=375275&view=rev Log: [libunwind][Android] Fix findUnwindSections for ARM EHABI Bionic Summary: Fix the arm_section_length count. The meaning of the arm_section_length field changed f

[PATCH] D69088: [Lex] #pragma clang transform

hsaito added a comment. In D69088#1714575 , @Meinersbur wrote: > In D69088#1714020 , @hsaito wrote: > > > Personally, I like the intent. I don't foresee a clear (enough) path to get > > there. This leads to hesitat

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

hliao updated this revision to Diff 225678. hliao added a comment. minor test case revising. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68818/new/ https://reviews.llvm.org/D68818 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang/

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. In D69088#1713623 , @hsaito wrote: > @Meinersbur, if I remember correctly, there was an RFC discussion on this > topic, right? If yes, would you post the pointer to that? I need a refresher > on what has been discussed/settled

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/BadSignalToKillThreadCheck.cpp:28 + +namespace { +static Preprocessor *PP; static is enough, no need for anonymous namespace. Comment at: clang-tools-extra/clan

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

dgoldman added a comment. Not sure who is best to review, feel free to add someone else instead. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69171/new/ https://reviews.llvm.org/D69171 ___ cfe-commits mailing list c

[PATCH] D69164: [clang-format] fix regression recognizing casts in Obj-C calls

krasimir marked an inline comment as done. krasimir added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:1612 + Keywords.kw_final) || +isCpp11AttributeSpecifier(*Tok.Next)) return false; rdwampler wrote: > I thi

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

rjmccall added inline comments. Comment at: clang/docs/UsersManual.rst:1318 + mode informs the compiler that it must not assume any particular + rounding mode. + rjmccall wrote: > "represent *the* corresponding IEEE rounding rules" A few points about this doc

[PATCH] D69180: [Format] Add format check for coroutine keywords with negative numbers

jonathoma updated this revision to Diff 225671. jonathoma added a comment. Rebase onto master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69180/new/ https://reviews.llvm.org/D69180 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/F

[PATCH] D69180: [Format] Add format check for coroutine keywords with negative numbers

jonathoma updated this revision to Diff 225672. jonathoma added a comment. Rebase properly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69180/new/ https://reviews.llvm.org/D69180 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Form

[PATCH] D69186: Refactor DependencyScanningTool to its own file

kousikk created this revision. kousikk added reviewers: arphaman, jkorous, Bigcheese, dexonsmith. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. kousikk updated this revision to Diff 225667. kousikk added a comment. Lint fixes There's no behavior change - just movi

[PATCH] D69186: Refactor DependencyScanningTool to its own file

kousikk updated this revision to Diff 225667. kousikk added a comment. Lint fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69186/new/ https://reviews.llvm.org/D69186 Files: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTo

[PATCH] D69184: [libTooling] Introduce general combinator for fixed-value `MatchConsumer`s.

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a project: clang. This revision generalizes the (deprecated) `clang::tooling::text` combinator to a `value` combinator, which works for any type. Aside from being more general, it resolves the naming confict between `

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. Ping. Hoping for code review so I can move this forward. Affirmative or negative, please let me know. Thank you! --Melanie Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

abelkocsis created this revision. abelkocsis added reviewers: aaron.ballman, alexfh, JonasToth, steakhal, Charusso. abelkocsis added a project: clang-tools-extra. Herald added subscribers: cfe-commits, mgehre, jfb, dexonsmith, steven_wu, hiraditya, xazax.hun, mgorny, mehdi_amini. Herald added a r

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

dgoldman added a comment. In D69171#1714624 , @sammccall wrote: > Rather than adding a new fuzzer binary, can we make the language an option? > The whole implementation seems almost identical down to > handleobjc/handlecxx... It's similar at the moment

[PATCH] D69144: [Format] Add format check for throwing negative numbers

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f704320b058: [Format] Add format check for throwing negative numbers (authored by modocache). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69144/new/ http

r375258 - [Format] Add format check for throwing negative numbers

Author: modocache Date: Fri Oct 18 09:59:02 2019 New Revision: 375258 URL: http://llvm.org/viewvc/llvm-project?rev=375258&view=rev Log: [Format] Add format check for throwing negative numbers Summary: The code `throw -1;` is currently formatted by clang-format as `throw - 1;`. This diff adds a fi

LLVM buildmaster will be updated and restarted

Hello everyone, LLVM buildmaster will be updated and restarted in an hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r375257 - [DOCS]Update list of implemented constructs, NFC.

Author: abataev Date: Fri Oct 18 09:53:54 2019 New Revision: 375257 URL: http://llvm.org/viewvc/llvm-project?rev=375257&view=rev Log: [DOCS]Update list of implemented constructs, NFC. Modified: cfe/trunk/docs/OpenMPSupport.rst Modified: cfe/trunk/docs/OpenMPSupport.rst URL: http://llvm.org/

[PATCH] D69180: [Format] Add format check for coroutine keywords with negative numbers

jonathoma created this revision. jonathoma added reviewers: modocache, sammccall, Quuxplusone. Herald added a project: clang. Herald added a subscriber: cfe-commits. jonathoma planned changes to this revision. As a followup to D69144 , this diff fixes the coroutin

[PATCH] D69179: [Format] Add format check for coroutine keywords with negative numbers

jonathoma created this revision. Herald added subscribers: cfe-commits, modocache. Herald added a project: clang. jonathoma retitled this revision from "[Format] Add format check for throwing negative numbers" to "[Format] Add format check for coroutine keywords with negative numbers". jonathoma

r375224 - [ThinLTOCodeGenerator] Add support for index-based WPD

Author: evgeny777 Date: Fri Oct 18 04:58:21 2019 New Revision: 375224 URL: http://llvm.org/viewvc/llvm-project?rev=375224&view=rev Log: [ThinLTOCodeGenerator] Add support for index-based WPD This is clang part of the patch. It adds -flto-unit flag for thin LTO builds on Mac and PS4 Differential

Re: [PATCH] D55802: Change CGObjC to use objc intrinsics instead of runtime methods

I only got a chance to look more into this now. I can reproduce it with re-inserting the "static". The miscompile is not related to MemorySSA, i.e. disabling all uses of MemorySSA doesn't help. It appears to be a GVN bug, but I haven't tracked it further than this. To repro, see attached .ll file

[PATCH] D69177: [clangd] Propogate FS into Tweak::Selection

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. kadircet added a parent revision: D69165: [clangd] Store Index in Tweak::Selection. Incoming define out-of-line co

[PATCH] D56924: Special case ObjCPropertyDecl for printing

dgoldman added inline comments. Comment at: unittests/AST/NamedDeclPrinterTest.cpp:220 +"property", +"Obj::property")); +} dexonsmith wrote: > gribozavr wrote: > > I don't think that `Obj::property` is the preferred syntax. `Obj.property`? > > I'd want a

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

sammccall added a comment. Rather than adding a new fuzzer binary, can we make the language an option? The whole implementation seems almost identical down to handleobjc/handlecxx... Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69171/new/ https://reviews.llvm.or

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. In D69088#1714020 , @hsaito wrote: > Personally, I like the intent. I don't foresee a clear (enough) path to get > there. This leads to hesitation of adding a new non-experimental pragma and > present it to programmers. If you

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

dgoldman created this revision. Herald added subscribers: cfe-commits, jfb, mgorny. Herald added a project: clang. - Similar to that of `clang-fuzzer` itself but instead only targets Objective-C source files via cc1 - Also adds an example corpus directory containing some input for Objective-C

[PATCH] D69164: [clang-format] fix regression recognizing casts in Obj-C calls

This revision was automatically updated to reflect the committed changes. Closed by commit rGeff2a2ab2b51: [clang-format] fix regression recognizing casts in Obj-C calls (authored by krasimir). Changed prior to commit: https://reviews.llvm.org/D69164?vs=225604&id=225635#toc Repository: rG LL

r375247 - [clang-format] fix regression recognizing casts in Obj-C calls

Author: krasimir Date: Fri Oct 18 08:21:06 2019 New Revision: 375247 URL: http://llvm.org/viewvc/llvm-project?rev=375247&view=rev Log: [clang-format] fix regression recognizing casts in Obj-C calls Summary: r373922 added checks for a few tokens that, following an `)` make it unlikely that the `)`

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan updated this revision to Diff 225631. stevewan marked 25 inline comments as done. stevewan added reviewers: jasonliu, Xiangling_L. stevewan added a comment. Fix periods at the end of comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68

[PATCH] D56924: Special case ObjCPropertyDecl for printing

dexonsmith added subscribers: jkorous, benlangmuir. dexonsmith added inline comments. Comment at: unittests/AST/NamedDeclPrinterTest.cpp:220 +"property", +"Obj::property")); +} gribozavr wrote: > I don't think that `Obj::property` is the preferred syntax.

r375245 - [tooling] Relax an assert when multiple GPU targets are specified.

Author: hliao Date: Fri Oct 18 08:03:34 2019 New Revision: 375245 URL: http://llvm.org/viewvc/llvm-project?rev=375245&view=rev Log: [tooling] Relax an assert when multiple GPU targets are specified. Modified: cfe/trunk/lib/Tooling/Tooling.cpp Modified: cfe/trunk/lib/Tooling/Tooling.cpp URL:

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

balazske updated this revision to Diff 225625. balazske added a comment. - Fixes from review comments, added C++ version test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67545/new/ https://reviews.llvm.org/D67545 Files: clang-tools-extra/clan

[PATCH] D69124: [clang][driver] Print compilation phases with indentation.

hliao updated this revision to Diff 225620. hliao added a comment. revise the output by drawing tree lines. now, the output looks like $ clang -x cuda -ccc-print-phases --cuda-gpu-arch=sm_30 --cuda-gpu-arch=sm_60 -c dummy.cpp +- 0: input, "/home/michliao/dummy.cpp", cuda, (host-c

[PATCH] D69124: [clang][driver] Print compilation phases with indentation.

hliao added a comment. In D69124#1713427 , @tra wrote: > This is... rather oddly-structured output. My brain refuses to accept that > the most-indented phase is the input. > Perhaps we should do `llvm::errs().indent(MaxIdent-Ident)`. This should give >

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet updated this revision to Diff 225618. gchatelet added a comment. - Fix documentation and Warning category Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68028/new/ https://reviews.llvm.org/D68028 Files: clang/include/clang/AST/Decl.h

[PATCH] D68340: Add AIX toolchain and basic linker functionality

jasonliu added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.h:19 + +/// aix -- Directly call system default and linker. +// TODO: Enable direct call to system default assembler. remove "and". Comment at: clang/lib/Driver/ToolCha

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet marked 4 inline comments as done. gchatelet added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3609 + "'%0' is not a valid builtin name for %1">, + InGroup; // Which group should it be in? +def err_attribute_no_builtin_wildcard_or_buil

[PATCH] D69164: [clang-format] fix regression recognizing casts in Obj-C calls

rdwampler added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:1612 + Keywords.kw_final) || +isCpp11AttributeSpecifier(*Tok.Next)) return false; I think the issue r373922 was fixing is only related to the `delet

[PATCH] D68885: Add a Ranges field to Diagnostic struct

alexfh added inline comments. Comment at: include/clang/Tooling/Core/Diagnostic.h:93 + /// representation of the source code associated with the diagnostic. + ArrayRef Ranges; }; Please add YAML serialization/deserialization code for this. See include/clang/T

[PATCH] D69155: [analyzer] Fix off-by-one in operator call parameter binding.

Charusso accepted this revision. Charusso marked an inline comment as done. Charusso added a comment. This revision is now accepted and ready to land. I think it will be a great educational material how to touch the core. Good luck! Comment at: clang/lib/StaticAnalyzer/Core/Ca

[PATCH] D69155: [analyzer] Fix off-by-one in operator call parameter binding.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CallEvent.cpp:325 if (getKind() != CE_CXXAllocator) if (isArgumentConstructedDirectly(Idx)) if (auto AdjIdx = getAdjustedParameterIndex(Idx)) --

  1   2   >