[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

thakis added a comment. Reverted in c9276fbfdf0c7caf1576b2 for now. Please watch the bots after landing things, and revert if something breaks and it takes you a while to fix. Repository: rG LLVM Github Monorepo CHANGES

[clang] c9276fb - Revert "[NFC] Refactor representation of materialized temporaries"

Author: Nico Weber Date: 2019-11-17T02:09:25-05:00 New Revision: c9276fbfdf0c7caf1576b2db562286d7cec7e53b URL: https://github.com/llvm/llvm-project/commit/c9276fbfdf0c7caf1576b2db562286d7cec7e53b DIFF: https://github.com/llvm/llvm-project/commit/c9276fbfdf0c7caf1576b2db562286d7cec7e53b.diff

[PATCH] D67536: [clangd] Inactive regions support as an extension to semantic highlighting

nridge updated this revision to Diff 229707. nridge added a comment. Support preamble as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/ https://reviews.llvm.org/D67536 Files: clang-tools-extra/clangd/CollectMacros.h

[PATCH] D67536: [clangd] Inactive regions support as an extension to semantic highlighting

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.h:100 + const std::vector () const { +return SkippedRanges; hokein wrote: > hokein wrote: > > Instead of adding new member and methods in

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

compnerd added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3493 +llvm::SmallVector = PhaseList; +types::getCompilationPhases(types::TY_IFS_CPP, PL); +llvm::SmallVector CompilePhaseList; The reference binding is odd. Why not just pass

[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

JonasToth updated this revision to Diff 229705. JonasToth marked 2 inline comments as done. JonasToth removed a subscriber: mgehre. JonasToth added a comment. - [Misc] port patch to monorepo - add more test cases for the transformation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

JonasToth marked 5 inline comments as done. JonasToth added inline comments. Herald added a subscriber: mgehre. Comment at: clang-tidy/utils/FixItHintUtils.cpp:35 +static bool isValueType(QualType QT) { return isValueType(QT.getTypePtr()); } +static bool isArrayType(QualType QT)

[PATCH] D70144: clang-tidy: modernize-use-equals-default avoid adding redundant semicolons

JonasToth added a comment. Hmm. I think this is fine, even though its not perfect. @aaron.ballman wdyt? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70144/new/ https://reviews.llvm.org/D70144 ___

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

sammccall added subscribers: ilya-biryukov, sammccall. sammccall added a comment. This seems to have broken clangd tests e.g. http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/58189/steps/test-check-all/logs/stdio FindExplicitReferences now finds duplicate refs

[PATCH] D70359: [clangd] Show values of more expressions on hover

merge_guards_bot added a comment. Build result: fail - 60143 tests passed, 2 failed and 729 were skipped. failed: Clangd Unit Tests._/ClangdTests/FindExplicitReferencesTest.All failed: LLVM.Bindings/Go/go.test Log files: console-log.txt

[PATCH] D70359: [clangd] Show values of more expressions on hover

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70359 Files:

[PATCH] D70358: Add Cursor.get_reference_name_range to clang python binding.

arthurp added a comment. This is my first new revision here, and I guessed on the review based solely on resent reviews of related code. Please correct me as needed. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70358/new/

[PATCH] D70358: Add Cursor.get_reference_name_range to clang python binding.

arthurp created this revision. arthurp added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. arthurp added a comment. This is my first new revision here, and I guessed on the review based solely on resent reviews of related code. Please

[PATCH] D64874: [Sema] Improve handling of function pointer conversions

Mordante added a comment. @rsmith I now have commit access so I can commit the patch. Any suggestions regarding the previous remark? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64874/new/ https://reviews.llvm.org/D64874 ___ cfe-commits

[PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

arthurp commandeered this revision. arthurp added a reviewer: RedX2501. arthurp added a comment. I have been using this revision locally for 9 months in a system that uses libclang to parse C code and extract information. I'm commandeering this issue since the original author (@RedX2501) has

[PATCH] D70357: [clangd] Untangle Hover from XRefs, move into own file.

sammccall added a subscriber: kuhnel. sammccall added a comment. @kuhnel: I think the premerge guards bot is acting up here: the first snapshot was definitely broken (missing files). And even the second the ninja logs don't show building the new files. I think it might just be building the tree

[PATCH] D53250: [ToolChain] Use default linker if the toolchain uses a custom one

Hahnfeld added a comment. Herald added a project: clang. Going through my old revisions, is this still something that we want? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53250/new/ https://reviews.llvm.org/D53250

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

This revision was automatically updated to reflect the committed changes. Closed by commit rG08ea1ee2db5f: [NFC] Refactor representation of materialized temporaries (authored by Tyker). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69360/new/

[clang-tools-extra] 08ea1ee - [NFC] Refactor representation of materialized temporaries

Author: Tyker Date: 2019-11-16T17:56:09+01:00 New Revision: 08ea1ee2db5f9d6460fef1d79d0d1d1a5eb78982 URL: https://github.com/llvm/llvm-project/commit/08ea1ee2db5f9d6460fef1d79d0d1d1a5eb78982 DIFF: https://github.com/llvm/llvm-project/commit/08ea1ee2db5f9d6460fef1d79d0d1d1a5eb78982.diff LOG:

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/test/InterfaceStubs/driver-test2.c:6 +// RUN: %clang -emit-interface-stubs -emit-merged-ifs \ +// RUN: driver-test2.o object.o weak.o -S -o - | FileCheck %s + I would use

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi updated this revision to Diff 229698. plotfi added a comment. Adding test, and some additional features in the driver. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70274/new/ https://reviews.llvm.org/D70274 Files:

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

This revision was automatically updated to reflect the committed changes. Closed by commit rG423f541c1a32: [DWARF5]Addition of alignment atrribute in typedef DIE. (authored by SouraVX). Changed prior to commit: https://reviews.llvm.org/D70111?vs=229544=229697#toc Repository: rG LLVM Github

[PATCH] D70340: Add a key method to Sema to optimize debug info size

dblaikie added a comment. In D70340#1748712 , @thakis wrote: > I don't see any reason not to do this. What's there to discuss? I'm probably > missing something obvious. Eh, it's a bit quirky - adds production code (albeit a very small amount) only to

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

SouraVX added a comment. In D70111#1748765 , @awpandey wrote: > Hi @aprantl. I had made the changes and my team member will commit this. Thanks @awpandey for working on this! as requested, I've committed / closed this. Repository: rG LLVM Github

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi updated this revision to Diff 229699. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70274/new/ https://reviews.llvm.org/D70274 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/InterfaceStubs.cpp clang/lib/Driver/Types.cpp

[clang] 423f541 - [DWARF5]Addition of alignment atrribute in typedef DIE.

Author: Sourabh Singh Tomar Date: 2019-11-16T21:56:53+05:30 New Revision: 423f541c1a322963cf482683fe9777ef0692082d URL: https://github.com/llvm/llvm-project/commit/423f541c1a322963cf482683fe9777ef0692082d DIFF:

[PATCH] D70357: [clangd] Untangle Hover from XRefs, move into own file.

merge_guards_bot added a comment. Build result: pass - 60143 tests passed, 0 failed and 729 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70357: [clangd] Untangle Hover from XRefs, move into own file.

merge_guards_bot added a comment. Build result: pass - 60143 tests passed, 0 failed and 729 were skipped. Log files: console-log.txt , CMakeCache.txt

[clang-tools-extra] a7f97b0 - [clangd] Improve long and confusing preamble log message.

Author: Sam McCall Date: 2019-11-16T17:13:02+01:00 New Revision: a7f97b02b4fa8b4b1824a7c9b14deb798f55e76a URL: https://github.com/llvm/llvm-project/commit/a7f97b02b4fa8b4b1824a7c9b14deb798f55e76a DIFF: https://github.com/llvm/llvm-project/commit/a7f97b02b4fa8b4b1824a7c9b14deb798f55e76a.diff

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

Tyker updated this revision to Diff 229694. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69360/new/ https://reviews.llvm.org/D69360 Files: clang-tools-extra/clang-tidy/abseil/StrCatAppendCheck.cpp clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp

[clang] a4a7c12 - [clang-format] Add SpaceBeforeBrackets

Author: mydeveloperday Date: 2019-11-16T11:54:21Z New Revision: a4a7c1259e8a8f2d11fa29686a6c2834948c1358 URL: https://github.com/llvm/llvm-project/commit/a4a7c1259e8a8f2d11fa29686a6c2834948c1358 DIFF: https://github.com/llvm/llvm-project/commit/a4a7c1259e8a8f2d11fa29686a6c2834948c1358.diff

[PATCH] D70270: clang-tidy: modernize-use-using uses AST and now supports struct defintions and multiple types in a typedef

poelmanc added a comment. > If there's a way to match only `CXXRecordDecl`s that are immediately followed > by a `TypedefDecl`... Alternatively, within `check()` when we get the `TypedefDecl`, is there any way to navigate up the AST to find its immediately preceding sibling node in the AST

[PATCH] D70306: clang: Exherbo multiarch ajustments

Keruspe updated this revision to Diff 229682. Keruspe added a comment. Herald added subscribers: ormris, atanasyan. Mark some tests as XFAIL on exherbo because the filesystem layout is different CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70306/new/ https://reviews.llvm.org/D70306

[PATCH] D70355: [clang-format] [NFC] add recent changes to release notes

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, mitchell-stellar, sylvestre.ledru, sammccall. MyDeveloperDay added projects: clang-format, clang. MyDeveloperDay added a subscriber: Eugene.Zelenko. MyDeveloperDay added a comment. @Eugene.Zelenko I've noticed you are

[PATCH] D70355: [clang-format] [NFC] add recent changes to release notes

Eugene.Zelenko added a comment. General comments: - Isn't //Option(s) ... was/were added// or //Option(s) ... had been added// are more correct from from point of view of English grammar? Same for older entries. - It'll be great to nag developers to expand Release Notes when relevant code

[PATCH] D70355: [clang-format] [NFC] add recent changes to release notes

MyDeveloperDay added a subscriber: Eugene.Zelenko. MyDeveloperDay added a comment. @Eugene.Zelenko I've noticed you are always giving excellent review feedback in clang-tidy especially around the documentation, I'd appreciate your eyes on finding the right level of documentation here.

[clang] 42effc1 - Add support of the next Ubuntu (Ubuntu 20.04 - Focal Fossa)

Author: Sylvestre Ledru Date: 2019-11-16T12:21:54+01:00 New Revision: 42effc106966d45053abdd4e3d03ecfe256869b5 URL: https://github.com/llvm/llvm-project/commit/42effc106966d45053abdd4e3d03ecfe256869b5 DIFF:

[PATCH] D6920: [clang-format] Add SpaceBeforeBrackets

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4a7c1259e8a: [clang-format] Add SpaceBeforeBrackets (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D6920?vs=229612=229686#toc Repository: rG LLVM Github Monorepo

[PATCH] D70196: [clang-include-fixer] Skip .rc files when finding symbols

kimgr added a comment. I wonder if it would be better to look at the compile-command than the source file? It's not unthinkable that someone would use another extension for an rc file, or use a .rc extension for a C or C++ source file. But if the compiler is rc.exe, the source file must be in

[PATCH] D70340: Add a key method to Sema to optimize debug info size

thakis added a comment. PS: nice find! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70340/new/ https://reviews.llvm.org/D70340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D6920: [clang-format] Add SpaceBeforeBrackets

sylvestre.ledru added a comment. Would be nice to add this to the release notes too ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6920/new/ https://reviews.llvm.org/D6920 ___ cfe-commits mailing

[PATCH] D70340: Add a key method to Sema to optimize debug info size

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. I don't see any reason not to do this. What's there to discuss? I'm probably missing something obvious. dblaikie added anchor functions in many places a while ago (but iirc for vtables, not

[PATCH] D62953: [Syntax] Do not glue multiple empty PP expansions to a single mapping

ilya-biryukov marked 2 inline comments as done. ilya-biryukov added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:447 +tryConsumeSpelledUntil(File, EndOffset + 1, SpelledIndex).hasValue(); +(void)HitMapping; +assert(!HitMapping && "recursive

[PATCH] D70270: clang-tidy: modernize-use-using uses AST and now supports struct defintions and multiple types in a typedef

poelmanc marked 6 inline comments as done. poelmanc added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp:30 + // They appear in the AST just *prior* to the typedefs. + Finder->addMatcher(cxxRecordDecl().bind("struct"), this); }

[PATCH] D70355: [clang-format] [NFC] add recent changes to release notes

merge_guards_bot added a comment. Build result: pass - 60143 tests passed, 0 failed and 729 were skipped. Log files: console-log.txt , CMakeCache.txt

[clang] 9b40a7f - Remove +x permission on some files

Author: Sylvestre Ledru Date: 2019-11-16T14:47:20+01:00 New Revision: 9b40a7f3bf7198dd64403cbd83478087e72f994b URL: https://github.com/llvm/llvm-project/commit/9b40a7f3bf7198dd64403cbd83478087e72f994b DIFF:

[PATCH] D6920: [clang-format] Add SpaceBeforeBrackets

sylvestre.ledru added a comment. fyi, +x permissions was added to clang/lib/Format/Format.cpp I reverted the change in a4a7c1259e8a8f2d11fa29686a6c2834948c1358 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] 9b40a7f - Remove +x permission on some files

Author: Sylvestre Ledru Date: 2019-11-16T14:47:20+01:00 New Revision: 9b40a7f3bf7198dd64403cbd83478087e72f994b URL: https://github.com/llvm/llvm-project/commit/9b40a7f3bf7198dd64403cbd83478087e72f994b DIFF:

[PATCH] D70305: clang-format: fix regression in middle pointer alignment

This revision was automatically updated to reflect the committed changes. Closed by commit rG5987cc1bb5d5: [clang-format] fix regression in middle pointer alignment (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69145: Give readability-redundant-member-init an option IgnoreBaseInCopyConstructors to avoid breaking code with gcc -Werror=extra

poelmanc added a subscriber: mgehre. poelmanc added a comment. In D69145#1715611 , @mgehre wrote: > Exactly due to the issue you are fixing here, we ended up disabling the > complete check because we didn't want to live with the warnings it produced >

[clang] d4819fe - Remove +x permission on clang/lib/Format/Format.cpp

Author: Sylvestre Ledru Date: 2019-11-16T14:44:35+01:00 New Revision: d4819fe0ec1037e1a995dca911278fee46384922 URL: https://github.com/llvm/llvm-project/commit/d4819fe0ec1037e1a995dca911278fee46384922 DIFF:

[clang] 5987cc1 - [clang-format] fix regression in middle pointer alignment

Author: mydeveloperday Date: 2019-11-16T14:37:47Z New Revision: 5987cc1bb5d5eb624135e76a6b3ade1aef94caf7 URL: https://github.com/llvm/llvm-project/commit/5987cc1bb5d5eb624135e76a6b3ade1aef94caf7 DIFF: https://github.com/llvm/llvm-project/commit/5987cc1bb5d5eb624135e76a6b3ade1aef94caf7.diff

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

awpandey added a comment. Hi @aprantl. I had made the changes and my team member will commit this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70111/new/ https://reviews.llvm.org/D70111 ___ cfe-commits mailing list

[PATCH] D70355: [clang-format] [NFC] add recent changes to release notes

MyDeveloperDay updated this revision to Diff 229690. MyDeveloperDay added a comment. Address review comments Remove excessive newlines Remove trailing whitespace CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70355/new/ https://reviews.llvm.org/D70355 Files:

[PATCH] D69145: Give readability-redundant-member-init an option IgnoreBaseInCopyConstructors to avoid breaking code with gcc -Werror=extra

lebedev.ri added a comment. In D69145#1748716 , @poelmanc wrote: > In D69145#1715611 , @mgehre wrote: > > > Exactly due to the issue you are fixing here, we ended up disabling the > > complete check because we

[PATCH] D6920: [clang-format] Add SpaceBeforeBrackets

MyDeveloperDay added a comment. In D6920#1748764 , @sylvestre.ledru wrote: > Would be nice to add this to the release notes too ;) Addressing this and other missing release notes in D70355: [clang-format] [NFC] add recent changes to release notes

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

boga95 marked 2 inline comments as done. boga95 added a comment. I did the required changes and tried to commit it, but I couldn't. I heard the codebase was migrated to GitHub. Maybe it affected my commit access. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59516/new/

[PATCH] D6920: [clang-format] Add SpaceBeforeBrackets

MyDeveloperDay added a comment. @Anteru thanks for the patch this got landed today, I got burnt by the 100755 mode change on the file, but thanks to @sylvestre.ledru it got resolved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6920/new/

[PATCH] D70270: clang-tidy: modernize-use-using uses AST and now supports struct defintions and multiple types in a typedef

poelmanc updated this revision to Diff 229678. poelmanc edited the summary of this revision. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70270/new/ https://reviews.llvm.org/D70270 Files: clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp

[PATCH] D70245: [OPENMP50]Add device/kind context selector support.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: clang/test/OpenMP/declare_variant_device_kind_codegen.cpp:81 +#define SUBSET host, cpu +#define WRONG cpu, gpu +#endif // CPU jdoerfert wrote: > What is wrong about cpu, gpu

[PATCH] D65410: [PassManager] First Pass implementation at -O1 pass pipeline

mehdi_amini added a comment. LGTM to land this and iterate, but you likely want someone else to confirm :) Comment at: llvm/test/Other/new-pm-defaults.ll:253 +; CHECK-Os-NEXT: Finished llvm::Function pass manager run. +; CHECK-Oz-NEXT: Finished llvm::Function pass manager run.

[PATCH] D70245: [OPENMP50]Add device/kind context selector support.

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11247 +RHSIsSubsetOfLHS = true; + } else { +for (const OMPContextSelectorData : LHS) { Nit: `bool RHSIsSubsetOfLHS = isStrictSubset(RHS, LHS)` saves you a line later.

[PATCH] D70348: Add header guards for header files that should not be included on the PS4 platform

dyung added a comment. In D70348#1748580 , @craig.topper wrote: > You could probably just define add __ORBIS__ to every line and then rely on > the individual feature defines at the end of the line to re-enable the ones > that are really supported. I

[PATCH] D70351: [clang][WIP][clang-scan-deps] Add an experimental C API.

Bigcheese created this revision. Bigcheese added reviewers: arphaman, kousikk. Herald added subscribers: llvm-commits, cfe-commits, tschuett, dexonsmith, mgorny. Herald added projects: clang, LLVM. Bigcheese added a parent revision: D70268: [clang][clang-scan-deps] Aggregate the full dependency

[PATCH] D65410: [PassManager] First Pass implementation at -O1 pass pipeline

echristo added a comment. Ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65410/new/ https://reviews.llvm.org/D65410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D70348: Add header guards for header files that should not be included on the PS4 platform

craig.topper added a comment. You could probably just define add __ORBIS__ to every line and then rely on the individual feature defines at the end of the line to re-enable the ones that are really supported. I assume the target-cpu is set to btver for ps4? Comment at:

[PATCH] D69292: Proposal to add -Wtautological-compare to -Wall

rtrieu added a comment. In D69292#1747062 , @mclow.lists wrote: > Sorry I'm late to the party; I've been traveling for 3+ weeks. > I would like to be reassured that the following code will not warn: > > ` >long foo = ...; // some calculation >

[PATCH] D70342: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy

xbolva00 updated this revision to Diff 229660. xbolva00 added a comment. Newline fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70342/new/ https://reviews.llvm.org/D70342 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D70342: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy

xbolva00 added a comment. In D70342#1748555 , @rsmith wrote: > Generally OK, but I'm concerned about including this in `-Wextra`. In > particular, the deprecation of copy/move operations when a destructor is > explicitly declared has experimentally been

[PATCH] D70342: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy

xbolva00 updated this revision to Diff 229658. xbolva00 added a comment. Added -Wdeprecated-copy-dtor (not part of -Wextra). Now we should be fully compatible with GCC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70342/new/

[PATCH] D70342: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy

rsmith added a comment. Generally OK, but I'm concerned about including this in `-Wextra`. In particular, the deprecation of copy/move operations when a destructor is explicitly declared has experimentally been found to have a high false-positive rate. Does GCC include this in `-Wextra`? (Its

[PATCH] D70349: [Attr] Fix `-ast-print` for `asm` attribute

jdenny created this revision. jdenny added reviewers: erichkeane, aaron.ballman. Herald added a project: clang. Without this fix, the tests introduced here produce the following assert fail: clang: /home/jdenny/llvm/clang/include/clang/Basic/AttributeCommonInfo.h:163: unsigned int

[clang] 4516dc1 - Don't add optnone or noinline if the function is already marked as

Author: Akira Hatanaka Date: 2019-11-15T15:44:04-08:00 New Revision: 4516dc1c20d1e77f20a72e90be876506805b3978 URL: https://github.com/llvm/llvm-project/commit/4516dc1c20d1e77f20a72e90be876506805b3978 DIFF:

[PATCH] D70348: Add header guards for header files that should not be included on the PS4 platform

dyung created this revision. dyung added a reviewer: craig.topper. dyung added a project: clang. For the PS4 platform, we want to exclude certain headers from being included because we do not support the features they provide. So for the headers we want to exclude, this change adds a check

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

This revision was automatically updated to reflect the committed changes. Closed by commit rG06f3dabe4a2e: [clang-tidy] Fix readability-redundant-string-init for c++17/c++2a (authored by mitchell-stellar). Changed prior to commit: https://reviews.llvm.org/D69238?vs=228556=229651#toc

[clang-tools-extra] 06f3dab - [clang-tidy] Fix readability-redundant-string-init for c++17/c++2a

Author: Mitchell Balan Date: 2019-11-15T18:09:42-05:00 New Revision: 06f3dabe4a2e85a32ade27c0769b6084c828a206 URL: https://github.com/llvm/llvm-project/commit/06f3dabe4a2e85a32ade27c0769b6084c828a206 DIFF:

[PATCH] D70342: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy

xbolva00 created this revision. xbolva00 added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC 9 added -Wdeprecated-copy (as part of -Wextra). This diagnostic is already implemented in Clang too, just hidden under -Wdeprecated (not on by default).

[PATCH] D68185: [Diagnostics] Warn when class implements a copy constructor/copy assignment operator, but missing the copy assignment operator/copy constructor

xbolva00 abandoned this revision. xbolva00 added a comment. https://reviews.llvm.org/D70342 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68185/new/ https://reviews.llvm.org/D68185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 9053574 - Don't use end-of-line comments for the DebugInfoKind enum, NFC

Author: Reid Kleckner Date: 2019-11-15T14:06:23-08:00 New Revision: 905357440c98ae06aac692d7adbccc70f1ce9d28 URL: https://github.com/llvm/llvm-project/commit/905357440c98ae06aac692d7adbccc70f1ce9d28 DIFF: https://github.com/llvm/llvm-project/commit/905357440c98ae06aac692d7adbccc70f1ce9d28.diff

[PATCH] D70340: Add a key method to Sema to optimize debug info size

rnk created this revision. rnk added reviewers: dblaikie, hans, thakis, rsmith. Herald added a subscriber: aprantl. Herald added a project: clang. DONOTSUBMIT, this patch is just for the purpose of discussion. It turns out that the debug info describing the Sema class is an appreciable

[clang-tools-extra] 47bd7c5 - Revert "[clang-tidy] Give readability-redundant-string-init a customizable list of string types to fix"

Author: Mitchell Balan Date: 2019-11-15T16:46:58-05:00 New Revision: 47bd7c57e556e3a4db51566d59c2d796ce898c8f URL: https://github.com/llvm/llvm-project/commit/47bd7c57e556e3a4db51566d59c2d796ce898c8f DIFF:

[PATCH] D6920: [clang-format] Add SpaceBeforeBrackets

Anteru added a comment. Thanks a lot! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6920/new/ https://reviews.llvm.org/D6920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70280: Remove Support/Options.h, it is unused

This revision was automatically updated to reflect the committed changes. Closed by commit rG631be5c0d411: Remove Support/Options.h, it is unused (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70280/new/

[PATCH] D69548: Give clang-tidy readability-redundant-string-init a customizable list of string types to fix

This revision was automatically updated to reflect the committed changes. Closed by commit rG96fbc32cb9ea: [clang-tidy] Give readability-redundant-string-init a customizable list of… (authored by mitchell-stellar). Changed prior to commit: https://reviews.llvm.org/D69548?vs=228769=229637#toc

[clang-tools-extra] 96fbc32 - [clang-tidy] Give readability-redundant-string-init a customizable list of string types to fix

Author: Mitchell Balan Date: 2019-11-15T16:42:54-05:00 New Revision: 96fbc32cb9ea23b1e7e3ff6906ec3ccda9500982 URL: https://github.com/llvm/llvm-project/commit/96fbc32cb9ea23b1e7e3ff6906ec3ccda9500982 DIFF:

[PATCH] D70157: Align branches within 32-Byte boundary

jyknight added a comment. Overall comment: this whole change needs more comments, everywhere. Both for the added functions, and for the test cases. There is almost no description of what's happening, and it could really use it. Comment at: llvm/lib/MC/MCAssembler.cpp:1041 +

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

This revision was automatically updated to reflect the committed changes. Closed by commit rG50e99563fb04: [clang-tidy] modernize-use-override new option AllowOverrideAndFinal (authored by mitchell-stellar). Changed prior to commit: https://reviews.llvm.org/D70165?vs=229012=229632#toc

[clang] 631be5c - Remove Support/Options.h, it is unused

Author: Reid Kleckner Date: 2019-11-15T13:32:52-08:00 New Revision: 631be5c0d41161057d02fe08a7aeb4fbde1a91d6 URL: https://github.com/llvm/llvm-project/commit/631be5c0d41161057d02fe08a7aeb4fbde1a91d6 DIFF: https://github.com/llvm/llvm-project/commit/631be5c0d41161057d02fe08a7aeb4fbde1a91d6.diff

[clang] caf3166 - Revert "re-land [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial"

Author: Alexandre Ganea Date: 2019-11-15T16:21:17-05:00 New Revision: caf3166d40ffbb0d61b29f423318ce6cfbcf4a9f URL: https://github.com/llvm/llvm-project/commit/caf3166d40ffbb0d61b29f423318ce6cfbcf4a9f DIFF:

[PATCH] D70256: [FPEnv] clang support for constrained FP builtins

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:357 + + if (ConstrainedIntrinsicID != Intrinsic::not_intrinsic && + CGF.Builder.getIsFPConstrained()) { I don't see any situation where `not_intrinsic` is passed in here; why all

[clang-tools-extra] 50e9956 - [clang-tidy] modernize-use-override new option AllowOverrideAndFinal

Author: Mitchell Balan Date: 2019-11-15T16:16:07-05:00 New Revision: 50e99563fb0459f5160572eef3c4e6062b8ad3f2 URL: https://github.com/llvm/llvm-project/commit/50e99563fb0459f5160572eef3c4e6062b8ad3f2 DIFF:

[PATCH] D70285: Wrap C APIs with pragmas enforcing -Werror=strict-prototypes

dexonsmith updated this revision to Diff 229624. dexonsmith marked an inline comment as done. dexonsmith added a comment. s/C_STRING_PROTOTYPES_/C_STRICT_PROTOTYPES_/ to fix some typos. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70285/new/ https://reviews.llvm.org/D70285 Files:

[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay. This seems reasonable to me, then. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69991/new/ https://reviews.llvm.org/D69991

[PATCH] D70242: [OpenCL] Allow addr space qualifiers on lambda call expressions

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Well that was easy. Do we accept the address-space attribute in this position, or is that TBD? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70242/new/

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

This revision was automatically updated to reflect the committed changes. Closed by commit rG782392db8122: [clang-tidy] modernize-use-using work with multi-argument templates (authored by mitchell-stellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70285: Wrap C APIs with pragmas enforcing -Werror=strict-prototypes

dexonsmith marked 2 inline comments as done. dexonsmith added inline comments. Comment at: clang/include/clang-c/ExternC.h:18-19 +#define LLVM_CLANG_C_STRING_PROTOTYPES_BEGIN \ + _Pragma("clang diagnostic push")

[clang-tools-extra] 782392d - [clang-tidy] modernize-use-using work with multi-argument templates

Author: Mitchell Balan Date: 2019-11-15T16:09:10-05:00 New Revision: 782392db8122cafb5e0e4ad5fe0c24c46f11b2b7 URL: https://github.com/llvm/llvm-project/commit/782392db8122cafb5e0e4ad5fe0c24c46f11b2b7 DIFF:

[PATCH] D70285: Wrap C APIs with pragmas enforcing -Werror=strict-prototypes

dexonsmith updated this revision to Diff 229621. dexonsmith added a comment. Adding guards for `_MSC_VER`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70285/new/ https://reviews.llvm.org/D70285 Files: clang/include/clang-c/BuildSystem.h

[clang] 9c1baa2 - re-land [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial

Author: Alexandre Ganea Date: 2019-11-15T16:01:39-05:00 New Revision: 9c1baa23526c6d7d06eafefbf82d73bfe9bb3aaf URL: https://github.com/llvm/llvm-project/commit/9c1baa23526c6d7d06eafefbf82d73bfe9bb3aaf DIFF:

[PATCH] D69564: Include the mangled name in -ast-dump=json

arphaman added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69564/new/ https://reviews.llvm.org/D69564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   3   >