[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

2019-11-18 Thread Clement Courbet via Phabricator via cfe-commits
courbet abandoned this revision. courbet marked an inline comment as done. courbet added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/performance-no-automatic-move.rst:47 +std::vector&& obj = ...; +return std::move(obj); // calls

[PATCH] D69145: Give readability-redundant-member-init an option IgnoreBaseInCopyConstructors to avoid breaking code with gcc -Werror=extra

2019-11-18 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Thank you, looks good to me. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69145/new/ https://reviews.llvm.org/D69145

[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

2019-11-18 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/performance-no-automatic-move.rst:47 +std::vector&& obj = ...; +return std::move(obj); // calls StatusOr::StatusOr(std::vector&&) + } JonasToth wrote: > lebedev.ri

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

2019-11-18 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. In D70165#1750606 , @mitchell-stellar wrote: > Yes, there was a failing unit test that had to be fixed. I reverted the first > commit and then committed a version that fixed the failing test. I mean, the commit message

[clang] d044dcc - Revert "[clang][IFS] Driver pipeline: generate interface stubs after standard pipeline."

2019-11-18 Thread Puyan Lotfi via cfe-commits
Author: Puyan Lotfi Date: 2019-11-19T02:08:22-05:00 New Revision: d044dcc5e492181b1517347013a780d9eda6c3c3 URL: https://github.com/llvm/llvm-project/commit/d044dcc5e492181b1517347013a780d9eda6c3c3 DIFF: https://github.com/llvm/llvm-project/commit/d044dcc5e492181b1517347013a780d9eda6c3c3.diff

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

2019-11-18 Thread Puyan Lotfi via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG58ea00b51fe9: [clang][IFS] Driver pipeline: generate interface stubs after standard pipeline. (authored by plotfi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 58ea00b - [clang][IFS] Driver pipeline: generate interface stubs after standard pipeline.

2019-11-18 Thread Puyan Lotfi via cfe-commits
Author: Puyan Lotfi Date: 2019-11-19T01:18:02-05:00 New Revision: 58ea00b51fe9b011301484957556872fced7dd08 URL: https://github.com/llvm/llvm-project/commit/58ea00b51fe9b011301484957556872fced7dd08 DIFF: https://github.com/llvm/llvm-project/commit/58ea00b51fe9b011301484957556872fced7dd08.diff

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

2019-11-18 Thread Puyan Lotfi via Phabricator via cfe-commits
plotfi updated this revision to Diff 229973. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70274/new/ https://reviews.llvm.org/D70274 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/InterfaceStubs.cpp clang/lib/Driver/Types.cpp

[PATCH] D70416: [Driver] Make -static-libgcc imply static libunwind

2019-11-18 Thread Joerg Sonnenberger via Phabricator via cfe-commits
joerg added a comment. This is normally done by using `-Bstatic`/`-Bdynamic` around the library. See `tools::addOpenMPRuntime`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70416/new/ https://reviews.llvm.org/D70416

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-18 Thread Michele Scandale via Phabricator via cfe-commits
michele.scandale added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2408 +case options::OPT_frounding_math: + // The default setting for frounding-math is True and ffast-math + // sets fno-rounding-math, but we only want to use constrained

[PATCH] D64305: [clangd] Add path mappings functionality

2019-11-18 Thread William Wagner via Phabricator via cfe-commits
wwagner19 marked 2 inline comments as done. wwagner19 added inline comments. Comment at: clang-tools-extra/clangd/PathMapping.cpp:153 +// Converts \pPath to a posix-style absolute, i.e. if it's a windows path +// then the backward-slash notation will be converted to forward

[PATCH] D64305: [clangd] Add path mappings functionality

2019-11-18 Thread William Wagner via Phabricator via cfe-commits
wwagner19 updated this revision to Diff 229969. wwagner19 marked 2 inline comments as done. wwagner19 added a comment. Awesome! I am not an LLVM committer, so if you could commit on my behalf that'd be great- although I'm not sure how LLVM handles squashing/merging, continuous integration,

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

2019-11-18 Thread Kuan Hsu Chen (Zakk) via Phabricator via cfe-commits
khchen updated this revision to Diff 229966. khchen added a comment. rebase and fix failed testcases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67508/new/ https://reviews.llvm.org/D67508 Files: clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D70416: [Driver] Make -static-libgcc imply static libunwind

2019-11-18 Thread Josh Kunz via Phabricator via cfe-commits
jkz created this revision. jkz added reviewers: saugustine, sivachandra. Herald added a project: clang. In the GNU toolchain, `-static-libgcc` implies that the unwindlib will be linked statically. However, when `--unwindlib=libunwind`, this flag is ignored, and a bare `-lunwind` is added to the

[PATCH] D69618: NeonEmitter: clean up prototype modifiers

2019-11-18 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. LGTM with a couple nits. Comment at: clang/include/clang/Basic/arm_neon_incl.td:203 // // The modifier 'd' means "default" and does not modify the base type in any // way. The available modifiers are given below. 'd' is gone.

[PATCH] D68862: [ARM] Allocatable Global Register Variables for ARM

2019-11-18 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. Approval is not ever a time-based process; someone appropriate actually has to do the work of reviewing the patch. If a patch doesn't get reviewed, you "ping" it a couple times, to note that you're waiting for a review. If it still isn't reviewed at that point, and

Re: [clang] dd870f6 - Fix warning about unused std::unique result, erase shifted elements

2019-11-18 Thread David Blaikie via cfe-commits
OK - thanks for the context! On Mon, Nov 18, 2019 at 5:07 PM Ben Langmuir wrote: > Nice find. > > The change LGTM, and is clearly what I always intended it to do. I was > confused how this ever worked at all, but I see that (at least in libc++) > we move the values into place rather than swap

Re: [clang] dd870f6 - Fix warning about unused std::unique result, erase shifted elements

2019-11-18 Thread Ben Langmuir via cfe-commits
Nice find. The change LGTM, and is clearly what I always intended it to do. I was confused how this ever worked at all, but I see that (at least in libc++) we move the values into place rather than swap them, so the values at the end are still the largest values for types with a trivial move

Re: [clang] dd870f6 - Fix warning about unused std::unique result, erase shifted elements

2019-11-18 Thread David Blaikie via cfe-commits
Hey Ben - if you're still involved with this part of the project - could you check that this change (to code you committed back in 2014, r215810) is correct & add a test case if possible? On Thu, Nov 7, 2019 at 10:39 AM Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > >

Re: [clang] d0f3c82 - Fix uninitialized variable warnings. NFCI.

2019-11-18 Thread David Blaikie via cfe-commits
Which compiler/what sort of warning was this addressing? (it can be beneficial to leave variables uninitialized if their value isn't intended to be used - so things like asan can catch bugs where the read of uninitialized is unintended) On Sat, Nov 2, 2019 at 11:27 AM Simon Pilgrim via

[PATCH] D70340: Add a key method to Sema to optimize debug info size

2019-11-18 Thread Reid Kleckner via Phabricator via cfe-commits
rnk updated this revision to Diff 229943. rnk added a comment. - comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70340/new/ https://reviews.llvm.org/D70340 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/Sema.cpp Index:

[PATCH] D70340: Add a key method to Sema to optimize debug info size

2019-11-18 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. In D70340#1749073 , @thakis wrote: > With the overhead being the cost of a single vtable with one entry? Or is > there more? I guess I worry about the extra dead vtable pointer in Sema. But, I don't think it matters. I think we

[PATCH] D69934: [clangd] Implement rename by using SelectionTree and findExplicitReferences.

2019-11-18 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. The test fails on Windows: http://45.33.8.238/win/2544/step_7.txt Failing Tests (2): Clangd Unit Tests :: ./ClangdTests.exe/RenameTest.Renameable Clangd Unit Tests :: ./ClangdTests.exe/RenameTest.WithinFileRename I'm guessing this needs the

[clang-tools-extra] f805c60 - Revert "[clangd] Implement rename by using SelectionTree and findExplicitReferences."

2019-11-18 Thread Wolfgang Pieb via cfe-commits
Author: Wolfgang Pieb Date: 2019-11-18T15:39:05-08:00 New Revision: f805c60a093325c16ce4200d2615ef48555d9cb8 URL: https://github.com/llvm/llvm-project/commit/f805c60a093325c16ce4200d2615ef48555d9cb8 DIFF: https://github.com/llvm/llvm-project/commit/f805c60a093325c16ce4200d2615ef48555d9cb8.diff

[PATCH] D69813: [analyzer] CERTStrChecker: Model gets()

2019-11-18 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso abandoned this revision. Charusso added a comment. This patch moved to D70411 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69813/new/ https://reviews.llvm.org/D69813 ___ cfe-commits mailing list

[PATCH] D69145: Give readability-redundant-member-init an option IgnoreBaseInCopyConstructors to avoid breaking code with gcc -Werror=extra

2019-11-18 Thread Conrad Poelman via Phabricator via cfe-commits
poelmanc added a comment. Thanks @lebedev.ri for taking the time to think this through and reply. All that makes sense, so I've changed the default to `0`. In addition to adding it to the ReleaseNotes, once clang-tidy 10 is released I'll reply to a StackOverflow question about this error with

[PATCH] D69145: Give readability-redundant-member-init an option IgnoreBaseInCopyConstructors to avoid breaking code with gcc -Werror=extra

2019-11-18 Thread Conrad Poelman via Phabricator via cfe-commits
poelmanc updated this revision to Diff 229934. poelmanc edited the summary of this revision. poelmanc added a comment. Switch default to `0`. Add Release Note with some detail to increase the chances of someone finding this with an Internet search on the error message. Repository: rCTE

[PATCH] D70411: [analyzer][WIP] StrChecker: 31.c

2019-11-18 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso marked an inline comment as done. Charusso added a comment. Somehow the `MallocBugVisitor` is broken in the wild, and we need to support a lot more to call it non-alpha (see the `FIXME`s). I do not want to spend time on fixing the visitor, but rather I would make this checker alpha,

[PATCH] D70368: [clang-tidy] Rewrite modernize-avoid-bind check

2019-11-18 Thread Zachary Turner via Phabricator via cfe-commits
zturner marked 2 inline comments as done. zturner added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp:116 +static const Expr *ignoreTemporariesAndImplicitCasts(const Expr *E) { + if (const auto *T = dyn_cast(E)) +return

[clang] ea1db31 - [CodeGen] Assign locations to calls to special struct helpers

2019-11-18 Thread Vedant Kumar via cfe-commits
Author: Vedant Kumar Date: 2019-11-18T15:07:59-08:00 New Revision: ea1db31d20a74e5025a86b0df49163d5bfecb67b URL: https://github.com/llvm/llvm-project/commit/ea1db31d20a74e5025a86b0df49163d5bfecb67b DIFF: https://github.com/llvm/llvm-project/commit/ea1db31d20a74e5025a86b0df49163d5bfecb67b.diff

[PATCH] D70411: [analyzer][WIP] StrChecker: 31.c

2019-11-18 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, mgorny. This checker warns on most of the following rules:

[PATCH] D70052: [clang-tidy] Add misc-mutating-copy check

2019-11-18 Thread Gabor Bencze via Phabricator via cfe-commits
gbencze added a comment. In D70052#1749730 , @JonasToth wrote: > There is a `ExprMutAnalyzer` that is able to find mutation of expressions in > general (even though it is kinda experimental still). Maybe that should be > utilized somehow? I think the

[PATCH] D70052: [clang-tidy] Add misc-mutating-copy check

2019-11-18 Thread Gabor Bencze via Phabricator via cfe-commits
gbencze updated this revision to Diff 229925. gbencze added a comment. Formatting changes (curly braces, newline at EOF) Remove incorrect flag from test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70052/new/ https://reviews.llvm.org/D70052 Files:

[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

2019-11-18 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/performance-no-automatic-move.rst:47 +std::vector&& obj = ...; +return std::move(obj); // calls StatusOr::StatusOr(std::vector&&) + } lebedev.ri wrote: > courbet

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

2019-11-18 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd accepted this revision. compnerd added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/Driver.cpp:3491 + if (Arg *A = Args.getLastArg(options::OPT_emit_interface_stubs)) { + +llvm::SmallVector PhaseList;

[PATCH] D70306: clang: Exherbo multiarch ajustments

2019-11-18 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd requested changes to this revision. compnerd added a comment. This revision now requires changes to proceed. The test adjustments are incorrect. They should optionally accept the triple in the path. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:360 +

[PATCH] D69316: [OpenMP 5.0] target update list items need not be contiguous (Sema)

2019-11-18 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen updated this revision to Diff 229922. cchen added a comment. Add and fix test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69316/new/ https://reviews.llvm.org/D69316 Files: clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

2019-11-18 Thread Mitchell via Phabricator via cfe-commits
mitchell-stellar added a comment. Yes, there was a failing unit test that had to be fixed. I reverted the first commit and then committed a version that fixed the failing test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70165/new/

[PATCH] D69876: Allow output constraints on "asm goto"

2019-11-18 Thread Bill Wendling via Phabricator via cfe-commits
void marked 2 inline comments as done. void added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:831 + for (auto i = as->begin_outputs(), e = as->end_outputs(); i != e; ++i) +if (const VarDecl *VD = findVar(*i).getDecl()) + vals[VD] =

[PATCH] D70368: [clang-tidy] Rewrite modernize-avoid-bind check

2019-11-18 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. This is a great re-write, thank you for working on it! Comment at: clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp:105 + CallableInfo Callable; + + SmallVector BindArguments; You can remove some newlines here.

[PATCH] D69876: Allow output constraints on "asm goto"

2019-11-18 Thread Bill Wendling via Phabricator via cfe-commits
void updated this revision to Diff 229921. void added a comment. Adjust loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69876/new/ https://reviews.llvm.org/D69876 Files: clang/docs/LanguageExtensions.rst clang/include/clang/AST/Stmt.h

[PATCH] D69876: Allow output constraints on "asm goto"

2019-11-18 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:831 + for (auto i = as->begin_outputs(), e = as->end_outputs(); i != e; ++i) +if (const VarDecl *VD = findVar(*i).getDecl()) + vals[VD] = Initialized; this is

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

2019-11-18 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added subscribers: mitchell-stellar, lebedev.ri. lebedev.ri added a comment. @poelmanc @mitchell-stellar I'm confused by the diff - did this land? Was the correct patch committed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70165/new/

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

2019-11-18 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. Ah, so it *really* landed in rG06f3dabe4a2e85a32ade27c0769b6084c828a206 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70165/new/

[PATCH] D70052: [clang-tidy] Add misc-mutating-copy check

2019-11-18 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/MutatingCopyCheck.cpp:73-79 + if (const auto *MemberCall = + Result.Nodes.getNodeAs(MutatingCallName)) { +diag(MemberCall->getBeginLoc(), "call mutates copied object"); + } else if

[PATCH] D69145: Give readability-redundant-member-init an option IgnoreBaseInCopyConstructors to avoid breaking code with gcc -Werror=extra

2019-11-18 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. In D69145#1750529 , @aaron.ballman wrote: > In D69145#1748733 , @lebedev.ri > wrote: > > > In D69145#1748716 , @poelmanc > > wrote: > > > > >

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

2019-11-18 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a subscriber: lebedev.ri. aaron.ballman added a comment. In D67545#1749579 , @lebedev.ri wrote: > In D67545#1749561 , @balazske wrote: > > > Ping. It should be accepted before I can land it. > >

[PATCH] D70359: [clangd] Show values of more expressions on hover

2019-11-18 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:255 + // Show enums symbolically, not numerically like APValue::printPretty(). + if (E->getType()->isEnumeralType() && + Constant.Val.getInt().getMinSignedBits() <= 64) {

[clang] 0213add - [NFC] Fix 'target' condition in checkTargetFeatures

2019-11-18 Thread Erich Keane via cfe-commits
Author: Erich Keane Date: 2019-11-18T13:43:52-08:00 New Revision: 0213adde218530bc31e5c4e50b49704c6bb2f2e9 URL: https://github.com/llvm/llvm-project/commit/0213adde218530bc31e5c4e50b49704c6bb2f2e9 DIFF: https://github.com/llvm/llvm-project/commit/0213adde218530bc31e5c4e50b49704c6bb2f2e9.diff

[PATCH] D69628: [Clang] Pragma vectorize_width() implies vectorize(enable), take 3

2019-11-18 Thread Michael Kruse via Phabricator via cfe-commits
Meinersbur added inline comments. Comment at: clang/lib/CodeGen/CGLoopInfo.cpp:302-306 +// Imply vectorize.enable when it is not already disabled/enabled. +Args.push_back( +MDNode::get(Ctx, {MDString::get(Ctx, "llvm.loop.vectorize.enable"), +

[PATCH] D69145: Give readability-redundant-member-init an option IgnoreBaseInCopyConstructors to avoid breaking code with gcc -Werror=extra

2019-11-18 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D69145#1748733 , @lebedev.ri wrote: > In D69145#1748716 , @poelmanc wrote: > > > In D69145#1715611 , @mgehre wrote: > > > > > Exactly due

[PATCH] D70256: [FPEnv] clang support for constrained FP builtins

2019-11-18 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:357 + + if (ConstrainedIntrinsicID != Intrinsic::not_intrinsic && + CGF.Builder.getIsFPConstrained()) { kpn wrote: > rjmccall wrote: > > I don't see any situation where

[PATCH] D70317: [clangd] More sensible output for constructors/destructors in hover.

2019-11-18 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. Build result: pass - 60168 tests passed, 0 failed and 731 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70325: [clangd] Fix hover 'local scope' to include class template params

2019-11-18 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. In D70325#1749432 , @kadircet wrote: > LGTM, with a question. What about default template params? I believe we would > also like to print them, could you add a test case for that? They're not printed, as the type is "as

[PATCH] D70256: [FPEnv] clang support for constrained FP builtins

2019-11-18 Thread Kevin P. Neal via Phabricator via cfe-commits
kpn marked 2 inline comments as done. kpn added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:357 + + if (ConstrainedIntrinsicID != Intrinsic::not_intrinsic && + CGF.Builder.getIsFPConstrained()) { rjmccall wrote: > I don't see any situation

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-18 Thread Kevin P. Neal via Phabricator via cfe-commits
kpn added a comment. In D62731#1750427 , @mibintc wrote: > In D62731#1750412 , @kpn wrote: > > > Does anyone think a warning is appropriate because the new flags are > > exercising experimental, incomplete code in

[PATCH] D70325: [clangd] Fix hover 'local scope' to include class template params

2019-11-18 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 229910. sammccall added a comment. add fixme Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70325/new/ https://reviews.llvm.org/D70325 Files: clang-tools-extra/clangd/AST.cpp

[PATCH] D69876: Allow output constraints on "asm goto"

2019-11-18 Thread Bill Wendling via Phabricator via cfe-commits
void added a comment. Changes made. PTAL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69876/new/ https://reviews.llvm.org/D69876 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69586: [profile] Support online merging with continuous sync mode

2019-11-18 Thread Vedant Kumar via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG2492b5a12550: [profile] Support online merging with continuous sync mode (authored by vsk). Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Repository: rG

[PATCH] D70357: [clangd] Untangle Hover from XRefs, move into own file.

2019-11-18 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked 4 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:374 + } else { +auto Offset = positionToOffset(SM.getBufferData(SM.getMainFileID()), Pos); +if (!Offset) { kadircet wrote: >

[PATCH] D69990: Populate CUDA flags on FreeBSD too, as many other toolchains do.

2019-11-18 Thread Dimitry Andric via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGee31adb7fa42: Populate CUDA flags on FreeBSD too, as many other toolchains do. (authored by dim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69990/new/

[PATCH] D69990: Populate CUDA flags on FreeBSD too, as many other toolchains do.

2019-11-18 Thread Dimitry Andric via Phabricator via cfe-commits
dim added a comment. In D69990#1750348 , @tra wrote: > LGTM, though I'm curious if it's particularly useful. Last time I checked > NVIDIA didn't ship libcudart for FreeBSD and without it it's rather > cumbersome to use CUDA in practice. After

[PATCH] D69876: Allow output constraints on "asm goto"

2019-11-18 Thread Bill Wendling via Phabricator via cfe-commits
void updated this revision to Diff 229904. void marked 2 inline comments as done. void added a comment. Remove a "const_cast" and use iterators for output constraints. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69876/new/

[clang] 2492b5a - [profile] Support online merging with continuous sync mode

2019-11-18 Thread Vedant Kumar via cfe-commits
Author: Vedant Kumar Date: 2019-11-18T12:56:58-08:00 New Revision: 2492b5a12550f7c4bb428c3761392f2ce47fa269 URL: https://github.com/llvm/llvm-project/commit/2492b5a12550f7c4bb428c3761392f2ce47fa269 DIFF: https://github.com/llvm/llvm-project/commit/2492b5a12550f7c4bb428c3761392f2ce47fa269.diff

[clang] ee31adb - Populate CUDA flags on FreeBSD too, as many other toolchains do.

2019-11-18 Thread Dimitry Andric via cfe-commits
Author: Dimitry Andric Date: 2019-11-18T21:54:25+01:00 New Revision: ee31adb7fa42f5b601d9612f23755b4604f83cac URL: https://github.com/llvm/llvm-project/commit/ee31adb7fa42f5b601d9612f23755b4604f83cac DIFF:

[PATCH] D70317: [clangd] More sensible output for constructors/destructors in hover.

2019-11-18 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:598 +// Constructor's "return type" is the class type. +HI.ReturnType = declaredType(CCD->getParent()).getAsString(Policy); +// Don't provide

[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

2019-11-18 Thread dmajor via Phabricator via cfe-commits
dmajor added a comment. Hi, I filed https://bugs.llvm.org/show_bug.cgi?id=44049 for some strange crashes that we're seeing because the CFG code overwrites the lower byte of function pointers before jumping to them. (Commenting separately here because I was unable to CC @ajpaverd in Bugzilla)

[PATCH] D70317: [clangd] More sensible output for constructors/destructors in hover.

2019-11-18 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 229900. sammccall marked 2 inline comments as done. sammccall added a comment. Update tests and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70317/new/ https://reviews.llvm.org/D70317 Files:

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-18 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: llvm/include/llvm/IR/IRBuilder.h:262 Function *F = BB->getParent(); -if (!F->hasFnAttribute(Attribute::StrictFP)) { +if (F && !F->hasFnAttribute(Attribute::StrictFP)) { F->addFnAttr(Attribute::StrictFP);

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-18 Thread Melanie Blower via Phabricator via cfe-commits
mibintc added a comment. In D62731#1750412 , @kpn wrote: > Does anyone think a warning is appropriate because the new flags are > exercising experimental, incomplete code in both clang and llvm? The warning > would be removed when we believe the feature

[PATCH] D70256: [FPEnv] clang support for constrained FP builtins

2019-11-18 Thread Kevin P. Neal via Phabricator via cfe-commits
kpn added a comment. D62731 is required for testing this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70256/new/ https://reviews.llvm.org/D70256 ___

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-18 Thread Kevin P. Neal via Phabricator via cfe-commits
kpn added a comment. Does anyone think a warning is appropriate because the new flags are exercising experimental, incomplete code in both clang and llvm? The warning would be removed when we believe the feature is complete and ready to use. Comment at:

[clang] 8bfb353 - [Sema] Fix a -Wobjc-signed-char-bool false-positive

2019-11-18 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2019-11-18T12:15:20-08:00 New Revision: 8bfb353bb33cd2bcd2ef28e36eb8b90123b153c4 URL: https://github.com/llvm/llvm-project/commit/8bfb353bb33cd2bcd2ef28e36eb8b90123b153c4 DIFF:

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-18 Thread Melanie Blower via Phabricator via cfe-commits
mibintc added a comment. I added a nullptr check in IRBuilder.h and a test case to cover the segfault reported in https://bugs.llvm.org/show_bug.cgi?id=44048 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-18 Thread Melanie Blower via Phabricator via cfe-commits
mibintc updated this revision to Diff 229893. mibintc added a reviewer: kpn. Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 Files: clang/docs/UsersManual.rst

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-18 Thread Melanie Blower via Phabricator via cfe-commits
mibintc reopened this revision. mibintc added a comment. This revision is now accepted and ready to land. Reopening since patch was reverted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731

[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

2019-11-18 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith closed this revision. dexonsmith added a comment. Pushed as d4e1ba3fa9dfec2613bdcc7db0b58dea490c56b1 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69991/new/ https://reviews.llvm.org/D69991

[clang] d4e1ba3 - Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

2019-11-18 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Pierre Habouzit Date: 2019-11-18T11:48:40-08:00 New Revision: d4e1ba3fa9dfec2613bdcc7db0b58dea490c56b1 URL: https://github.com/llvm/llvm-project/commit/d4e1ba3fa9dfec2613bdcc7db0b58dea490c56b1 DIFF:

[PATCH] D69990: Populate CUDA flags on FreeBSD too, as many other toolchains do.

2019-11-18 Thread Artem Belevich via Phabricator via cfe-commits
tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM, though I'm curious if it's particularly useful. Last time I checked NVIDIA didn't ship libcudart for FreeBSD and without it it's rather cumbersome to use CUDA in practice. You can compile a

Re: [clang] b4e2b11 - [Remarks][Driver] Use different remark files when targeting multiple architectures

2019-11-18 Thread Francis Visoiu Mistrih via cfe-commits
Thanks. I restricted this to darwin and moved the test to a separate file. Re-landed here: e15b26fbbd90 Reland: [Remarks][Driver] Use different remark files when targeting multiple architectures > On Nov 18, 2019, at 10:53 AM, Reid Kleckner wrote: > > I reverted this, the test fails for me

[PATCH] D69876: Allow output constraints on "asm goto"

2019-11-18 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:830 + + for (unsigned i = 0, e = as->getNumOutputs(); i != e; ++i) { +FindVarResult Var = findVar(as->getOutputExpr(i)); `GCCAsmStmt` inherits from `AsmStmt` which

[clang] e15b26f - Reland: [Remarks][Driver] Use different remark files when targeting multiple architectures

2019-11-18 Thread Francis Visoiu Mistrih via cfe-commits
Author: Francis Visoiu Mistrih Date: 2019-11-18T11:17:38-08:00 New Revision: e15b26fbbd901315a1402f97e83abf29bdce9a9f URL: https://github.com/llvm/llvm-project/commit/e15b26fbbd901315a1402f97e83abf29bdce9a9f DIFF:

Re: [PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-18 Thread Eric Christopher via cfe-commits
No, it's just the bug that Jorge found. I understand it might have highlighted an existing bug, but reverting back to clean is the best bet here and then we can recommit when we get the latent bug fixed :) On Mon, Nov 18, 2019 at 11:08 AM Melanie Blower via Phabricator wrote: > > mibintc added a

[PATCH] D69990: Populate CUDA flags on FreeBSD too, as many other toolchains do.

2019-11-18 Thread Dimitry Andric via Phabricator via cfe-commits
dim added reviewers: tra, yaxunl, ABataev. dim added a comment. Adding a few people who might know a bit more about CUDA specific things. Please take a look if this review makes any sense, thanks. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69990: Populate CUDA flags on FreeBSD too, as many other toolchains do.

2019-11-18 Thread Dimitry Andric via Phabricator via cfe-commits
dim updated this revision to Diff 229883. dim added a comment. - Add cuda options test, copied from cuda-options.cu. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69990/new/ https://reviews.llvm.org/D69990 Files:

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-18 Thread Melanie Blower via Phabricator via cfe-commits
mibintc added a comment. In D62731#1750312 , @echristo wrote: > In D62731#1749916 , @mibintc wrote: > > > Thanks I see it, I'm working on a patch. Previously there was no support > > for frounding-math

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-18 Thread Melanie Blower via Phabricator via cfe-commits
mibintc added a comment. The incorrect code is actually in the IRBuilder which is part of a different patch... In D62731#1750312 , @echristo wrote: > In D62731#1749916 , @mibintc wrote: > > > Thanks I see it, I'm

Re: [clang] b4e2b11 - [Remarks][Driver] Use different remark files when targeting multiple architectures

2019-11-18 Thread Reid Kleckner via cfe-commits
I reverted this, the test fails for me locally. Does -arch work on non-Mac targets? On Mon, Nov 18, 2019 at 10:39 AM Francis Visoiu Mistrih via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Francis Visoiu Mistrih > Date: 2019-11-18T10:38:10-08:00 > New Revision:

[clang] 1ff5f0c - Revert "[Remarks][Driver] Use different remark files when targeting multiple architectures"

2019-11-18 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2019-11-18T10:52:41-08:00 New Revision: 1ff5f0ced3163e457c799bd3bd838153806d6320 URL: https://github.com/llvm/llvm-project/commit/1ff5f0ced3163e457c799bd3bd838153806d6320 DIFF: https://github.com/llvm/llvm-project/commit/1ff5f0ced3163e457c799bd3bd838153806d6320.diff

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-18 Thread Eric Christopher via Phabricator via cfe-commits
echristo added a comment. In D62731#1749916 , @mibintc wrote: > Thanks I see it, I'm working on a patch. Previously there was no support for > frounding-math (unimplemented). This patch enables the option. In the IR > builder, there's a call to a

Re: [PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-18 Thread Eric Christopher via cfe-commits
Hi All, I've gone ahead and temporarily reverted here: echristo@jhereg ~/s/llvm-project> git push To github.com:llvm/llvm-project.git a77b66a0562..30e7ee3c4ba master -> master and we can just reapply when the issues are fixed. Thanks :) -eric On Mon, Nov 18, 2019 at 6:58 AM Melanie Blower

[clang] 30e7ee3 - Temporarily Revert "Add support for options -frounding-math, ftrapping-math, -ffp-model=, and -ffp-exception-behavior="

2019-11-18 Thread Eric Christopher via cfe-commits
Author: Eric Christopher Date: 2019-11-18T10:46:48-08:00 New Revision: 30e7ee3c4bac4a12ea584a879aa320bd4e035cc2 URL: https://github.com/llvm/llvm-project/commit/30e7ee3c4bac4a12ea584a879aa320bd4e035cc2 DIFF:

[clang] a77b66a - Allocate builtins table earlier to fix bug found by ubsan

2019-11-18 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2019-11-18T10:41:30-08:00 New Revision: a77b66a05625ea4271c2d76f65428cce02e4699e URL: https://github.com/llvm/llvm-project/commit/a77b66a05625ea4271c2d76f65428cce02e4699e DIFF: https://github.com/llvm/llvm-project/commit/a77b66a05625ea4271c2d76f65428cce02e4699e.diff

[clang] b4e2b11 - [Remarks][Driver] Use different remark files when targeting multiple architectures

2019-11-18 Thread Francis Visoiu Mistrih via cfe-commits
Author: Francis Visoiu Mistrih Date: 2019-11-18T10:38:10-08:00 New Revision: b4e2b112b58154a89171df39dae80044865ff4ff URL: https://github.com/llvm/llvm-project/commit/b4e2b112b58154a89171df39dae80044865ff4ff DIFF:

[PATCH] D70355: [clang-format] [NFC] add recent changes to release notes

2019-11-18 Thread Mitchell via Phabricator via cfe-commits
mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70355/new/ https://reviews.llvm.org/D70355 ___ cfe-commits

[PATCH] D68155: [clang][NFC] Make various uses of Regex const

2019-11-18 Thread Thomas Preud'homme via Phabricator via cfe-commits
thopre accepted this revision. thopre added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68155/new/ https://reviews.llvm.org/D68155 ___ cfe-commits

[PATCH] D70349: [Attr] Fix `-ast-print` for `asm` attribute

2019-11-18 Thread Joel E. Denny via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc85fa79d3663: [Attr] Fix `-ast-print` for `asm` attribute (authored by jdenny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70349/new/

[clang] c85fa79 - [Attr] Fix `-ast-print` for `asm` attribute

2019-11-18 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2019-11-18T11:55:25-05:00 New Revision: c85fa79d3663ecb3117e178b2a79ffa721d18e32 URL: https://github.com/llvm/llvm-project/commit/c85fa79d3663ecb3117e178b2a79ffa721d18e32 DIFF: https://github.com/llvm/llvm-project/commit/c85fa79d3663ecb3117e178b2a79ffa721d18e32.diff

[clang] c3eded0 - [OPENMP50]Fix PR44024: runtime assert in distribute construct.

2019-11-18 Thread Alexey Bataev via cfe-commits
Author: Alexey Bataev Date: 2019-11-18T11:14:27-05:00 New Revision: c3eded068c64bfe614d25359927a2917ff8e4a35 URL: https://github.com/llvm/llvm-project/commit/c3eded068c64bfe614d25359927a2917ff8e4a35 DIFF: https://github.com/llvm/llvm-project/commit/c3eded068c64bfe614d25359927a2917ff8e4a35.diff

[clang-tools-extra] 2054ed0 - [clangd] Store xref for Macros in ParsedAST.

2019-11-18 Thread Utkarsh Saxena via cfe-commits
Author: Utkarsh Saxena Date: 2019-11-18T16:47:18+01:00 New Revision: 2054ed052f15b584e1bce57c8f765991eab2da7d URL: https://github.com/llvm/llvm-project/commit/2054ed052f15b584e1bce57c8f765991eab2da7d DIFF:

  1   2   >