[PATCH] D70571: [Coverage] Emit a gap region to cover switch bodies

hans added a comment. Thanks! I'm not that familiar with the coverage counters, but this seems good as far as I can tell. Maybe add the test case from PR44011? I didn't see any test cases with that kind of gaps between cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70571/new/

[PATCH] D70424: clang/AMDGPU: Fix default for frame-pointer attribute

arsenm added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70424/new/ https://reviews.llvm.org/D70424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

JonChesterfield added inline comments. Comment at: llvm/include/llvm/IR/OpenMPKinds.def:186 +///{ + +#ifndef OMP_IDENT_FLAG jdoerfert wrote: > JonChesterfield wrote: > > Meinersbur wrote: > > > JonChesterfield wrote: > > > > jdoerfert wrote: > > > > > Meinersbur

[PATCH] D66564: [clang-tidy] new altera struct pack align check

ffrankies updated this revision to Diff 230828. ffrankies edited the summary of this revision. ffrankies added a comment. Implemented changes requested by @aaron.ballman - Moved the check from the "performance" module into the new "altera" module - Split the diagnostic message into a warning and

[PATCH] D70575: [Clang] Define Fuchsia C++ABI

phosek added a comment. In D70575#1756072 , @leonardchan wrote: > Could you add a test to show that with a fuchsia target we end up returning > `this` from constructors + destructors and ensure that this ABI is used? Done Repository: rG LLVM Github

[PATCH] D70575: [Clang] Define Fuchsia C++ABI

phosek updated this revision to Diff 230827. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70575/new/ https://reviews.llvm.org/D70575 Files: clang/include/clang/Basic/TargetCXXABI.h clang/lib/AST/ASTContext.cpp

[PATCH] D69876: Allow output constraints on "asm goto"

void added a comment. Any further comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69876/new/ https://reviews.llvm.org/D69876 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70624: [Diagnostics] Warn for comparison with string literals expanded from macro (PR44064)

This revision was automatically updated to reflect the committed changes. Closed by commit rGba4017670e19: [Diagnostics] Warn for comparison with string literals expanded from macro… (authored by xbolva00). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70624: [Diagnostics] Warn for comparison with string literals expanded from macro (PR44064)

xbolva00 added a comment. Thank you for the review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70624/new/ https://reviews.llvm.org/D70624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70624: [Diagnostics] Warn for comparison with string literals expanded from macro (PR44064)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70624/new/ https://reviews.llvm.org/D70624

[PATCH] D70624: [Diagnostics] Warn for comparison with string literals expanded from macro (PR44064)

xbolva00 updated this revision to Diff 230797. xbolva00 added a comment. Added new tests. Improved recommendation how to fix warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70624/new/ https://reviews.llvm.org/D70624 Files:

[PATCH] D70624: [Diagnostics] Warn for comparison with string literals expanded from macro (PR44064)

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:10368 - if (Expr::isSameComparisonOperand(LHS, RHS)) { -unsigned Result; -switch (Opc) { -case BO_EQ: case BO_LE: case BO_GE: - Result = AlwaysTrue; - break; -case BO_NE:

[PATCH] D70071: [ConstExprPreter] Removed the flag forcing the use of the interpreter

nand updated this revision to Diff 230791. nand added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70071/new/ https://reviews.llvm.org/D70071 Files: clang/docs/ConstantInterpreter.rst

[PATCH] D70190: [clang][modules] Add support for merging lifetime-extended temporaries

xbolva00 added inline comments. Comment at: clang/test/Modules/Inputs/merge-lifetime-extended-temporary/module.modulemap:15 +} \ No newline at end of file Add newline here. Dtto in other tests above. CHANGES SINCE LAST ACTION

[PATCH] D70624: [Diagnostics] Warn for comparison with string literals expanded from macro (PR44064)

xbolva00 marked 2 inline comments as done. xbolva00 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8431 "result of comparison against %select{a string literal|@encode}0 is " - "unspecified (use strncmp instead)">, - InGroup; +

[PATCH] D70190: [clang][modules] Add support for merging lifetime-extended temporaries

Tyker updated this revision to Diff 230790. Tyker added a comment. rebased added new lines. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70190/new/ https://reviews.llvm.org/D70190 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang/AST/TextNodeDumper.h

[PATCH] D70624: [Diagnostics] Warn for comparison with string literals expanded from macro (PR44064)

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8431 "result of comparison against %select{a string literal|@encode}0 is " - "unspecified (use strncmp instead)">, - InGroup; + "unspecified">, InGroup; I

[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/FixItHintUtils.cpp:30-31 +static bool isValueType(const Type *T) { + return !(isa(T) || isa(T) || isa(T) || + isa(T)); } ObjC pointer types?

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

Mordante added a comment. In D68912#1757850 , @xbolva00 wrote: > In D68912#1754660 , @xbolva00 wrote: > > > I think you can commit it, you already fixed some warnings. > > > Oh, I hit this (-Werror bots) hard :D

[PATCH] D65410: [PassManager] First Pass implementation at -O1 pass pipeline

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. Minor nits around redundant predicates for SROA. With thouse fixed, LGTM. I'd really love to find a way to make TCO debuggable so that we don't lose that. I'm particularly worried about

[PATCH] D70157: Align branches within 32-Byte boundary

chandlerc added a comment. (Just a reminder that we need to have both performance and code size numbers for this patch. And given that there are a few options, may need a few examples.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70157/new/ https://reviews.llvm.org/D70157