[PATCH] D70839: [clang][IFS] Claiming -emit-merged-ifs in clang driver when -c is used.

plotfi created this revision. plotfi added a reviewer: compnerd. Herald added a project: clang. Herald added a subscriber: cfe-commits. Sometimes it is difficult to tell when you want your compile flags to be invoked with -emit-interface-stubs -c or with -emit-interface-stubs -emit-merged-ifs.

[PATCH] D70838: [clang][IFS] Ignoring -Xlinker/-Xclang arguments in InterfaceStubs pass for now.

plotfi created this revision. plotfi added reviewers: compnerd, cishida. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. I intend to add something like -Xifs, but for now if an InputArg is not a filename then I want to skip it. Repository: rG LLVM Github

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

bryanpkc added a comment. In D70804#1763289 , @ABataev wrote: > Tests are required The tests for this were added in D30644 , but they are currently failing on AArch64 due to D32035 .

[PATCH] D70836: [analysis] Fix value tracking for pointers to qualified types

vabridgers created this revision. vabridgers added reviewers: dcoughlin, dergachev.a. vabridgers added a project: clang. Herald added a subscriber: cfe-commits. This change fixes part 1 described by Artem in the Bugzilla report 43364. The comparison done was on a canonical, but should have been

[PATCH] D70579: [coroutines][PR41909] Generalize fix from D62550

junparser added a comment. This also fix same ice when build cppcoro with current trunk. FYI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70579/new/ https://reviews.llvm.org/D70579 ___ cfe-commits

[PATCH] D70467: [Distro] Bypass distro detection on non-Linux hosts

This revision was automatically updated to reflect the committed changes. aganea marked an inline comment as done. Closed by commit rG1abd4c94d757: [Clang] Bypass distro detection on non-Linux hosts (authored by aganea). Changed prior to commit:

[clang] 1abd4c9 - [Clang] Bypass distro detection on non-Linux hosts

Author: Alexandre Ganea Date: 2019-11-28T17:02:06-05:00 New Revision: 1abd4c94d7575e4cd288e0024c1ec79f17b048a9 URL: https://github.com/llvm/llvm-project/commit/1abd4c94d7575e4cd288e0024c1ec79f17b048a9 DIFF:

[PATCH] D70808: [mips] Check that features required by built-ins are enabled

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4d32ae75bf5: [mips] Check that features required by built-ins are enabled (authored by atanasyan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70808/new/

[clang] f4d32ae - [mips] Check that features required by built-ins are enabled

Author: Simon Atanasyan Date: 2019-11-29T00:23:00+03:00 New Revision: f4d32ae75bf515f443a2c99dce5c882f460c82bd URL: https://github.com/llvm/llvm-project/commit/f4d32ae75bf515f443a2c99dce5c882f460c82bd DIFF:

[PATCH] D70823: [clang-tidy] Adding cert-pos34-c check

zukatsinadze updated this revision to Diff 231465. zukatsinadze added a comment. changes after review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70823/new/ https://reviews.llvm.org/D70823 Files: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp

[PATCH] D70823: [clang-tidy] Adding cert-pos34-c check

zukatsinadze marked 5 inline comments as done. zukatsinadze added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/PutenvWithAutoCheck.cpp:28 + unless(hasDescendant(callExpr(callee(functionDecl(hasAnyName( + "::alloc",

[PATCH] D70605: [OpenCL] Fix address space for implicit conversion (PR43145)

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70605/new/ https://reviews.llvm.org/D70605 ___ cfe-commits mailing list

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

vchuravy marked an inline comment as done. vchuravy added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:113 +TT.isArch64Bit() ? "e-m:e-p:64:64-i64:64-n32:64-S128-ni:1" + :

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

vchuravy updated this revision to Diff 231462. vchuravy added a comment. restore previous changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66035/new/ https://reviews.llvm.org/D66035 Files: clang/lib/Basic/Targets/WebAssembly.h

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

vchuravy updated this revision to Diff 231460. vchuravy added a comment. support old DL modules Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66035/new/ https://reviews.llvm.org/D66035 Files:

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

rogfer01 added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMPKinds.def:165 + +__OMP_RTL(__kmpc_barrier, false, Void, IdentPtr, Int32) +__OMP_RTL(__kmpc_cancel_barrier, false, Int32, IdentPtr, Int32) jdoerfert wrote: > rogfer01 wrote: > > As we

[PATCH] D69938: [OpenCL] Use __generic addr space when generating internal representation of lambda

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, that looks great. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69938/new/ https://reviews.llvm.org/D69938 ___ cfe-commits

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert marked an inline comment as done. jdoerfert added a comment. In D69785#1762438 , @JonChesterfield wrote: > I'd very much like this to land soon. It's the prereq for a lot of other > patches and the code looks good. > > It's tricky to test the

[PATCH] D70832: [clangd] Log cc1 args at verbose level.

merge_guards_bot added a comment. Build result: FAILURE - Log files: console-log.txt , CMakeCache.txt Repository: rG

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

jdoerfert marked 3 inline comments as done. jdoerfert added a comment. In D69922#1742392 , @ABataev wrote: > In D69922#1741659 , @jdoerfert wrote: > > > Use IRBuilder for cancel barriers > > > In general, it would

[PATCH] D70832: [clangd] Log cc1 args at verbose level.

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. This will help debugging driver issues. Repository: rG LLVM Github

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

ABataev requested changes to this revision. ABataev added a comment. This revision now requires changes to proceed. Tests are required Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70804/new/ https://reviews.llvm.org/D70804

[PATCH] D70799: [OpenMP] Lower taskyield using OpenMP IR Builder

jdoerfert accepted this revision. jdoerfert added a subscriber: fghanim. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. @fghanim started a spreadsheet to coordinate our work:

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille added a comment. @Meinersbur I have a strange symbol issue when activating the GPu part: https://github.com/serge-sans-paille/llvm-project/pull/2/checks?check_run_id=324901896#step:5:4888 Any hint? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70804/new/ https://reviews.llvm.org/D70804

[PATCH] D70829: [ARM][MVE][Intrinsics] Add VMINQ/VMAXQ/VMINNMQ/VMAXNMQ intrinsics.

dmgreen added inline comments. Comment at: llvm/test/CodeGen/Thumb2/mve-intrinsics/vmaxnmq.ll:7 +; CHECK: @ %bb.0: @ %entry +; CHECK-NEXT:vcmp.f16 ge, q0, q1 +; CHECK-NEXT:vpsel q0, q0, q1 You may want to use llvm.minnum directly (providing the

[PATCH] D70828: [clangd] Correct the file path in Edit::replacements when generating the rename edit.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70828/new/ https://reviews.llvm.org/D70828

[PATCH] D70823: [clang-tidy] Adding cert-pos34-c check

Charusso added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/PutenvWithAutoCheck.cpp:28 + unless(hasDescendant(callExpr(callee(functionDecl(hasAnyName( + "::alloc", "::malloc", "::realloc", "::calloc"))) +

[PATCH] D70823: [clang-tidy] Adding cert-pos34-c check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:200 + + Finds calls of 'putenv' function with automatic variable as the argument. + Please use double back-ticks to highlight putenv. Repository: rCTE Clang Tools

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille added a comment. @Alouest thanks for the reproducer. I confirm your issue, and also confirm that if you pass `-fexperimental-new-pass-manager -O1` to clang (i.e. use the new pass manager) it works fine. As far as I can tell, the segfault happens because `RegisterPass` also

[PATCH] D70829: [ARM][MVE][Intrinsics] Add VMINQ/VMAXQ/VMINNMQ/VMAXNMQ intrinsics.

MarkMurrayARM created this revision. Herald added subscribers: llvm-commits, cfe-commits, dmgreen, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. Add VMINQ/VMAXQ/VMINNMQ/VMAXNMQ intrinsics and their predicated versions. Add unit tests. Repository: rG LLVM Github Monorepo

[PATCH] D68682: format::cleanupAroundReplacements removes whole line when Removals leave previously non-blank line blank

alexfh added inline comments. Comment at: clang/include/clang/Basic/CharInfo.h:94 +LLVM_READONLY inline bool isWhitespace(llvm::StringRef S) { + for (StringRef::const_iterator I = S.begin(), E = S.end(); I != E; ++I) { +if (!isWhitespace(*I)) I'd suggest to

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

xbolva00 reopened this revision. xbolva00 added a subscriber: tstellar. xbolva00 added a comment. This revision is now accepted and ready to land. @tstellar reverted this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70638/new/

[PATCH] D70244: [Analyzer] Iterator Checkers: Replace `UnknownVal` in comparison result by a conjured value

baloghadamsoftware added a comment. @NoQ, @Szelethus What about this patch? It is an essential bugfix. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70244/new/ https://reviews.llvm.org/D70244 ___ cfe-commits mailing

[PATCH] D70320: [Analyzer] [NFC] Iterator Checkers - Separate iterator modeling and the actual checkers

baloghadamsoftware marked 2 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:1308-1318 +ProgramStateRef removeIteratorPosition(ProgramStateRef State, const SVal ) { if (auto Reg =

[PATCH] D70828: [clangd] Correct the file path in Edit::replacements when generating the rename edit.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. The file path was set to the file content previously, and it isn't covered by normal clangd & unittest code path (as we

[PATCH] D69948: [Checkers] Added support for freopen to StreamChecker.

martong added inline comments. Comment at: clang/test/Analysis/stream.c:160 +} else { + // Open failed, f1 points now to an invalid stream but this condition is currently not checked. + rewind(f1); This comment is confusing for me. Maybe there are

[PATCH] D70820: [OpenMP][test] Fix test on MIPS-based buildbots

This revision was automatically updated to reflect the committed changes. Closed by commit rGed864745c97e: [OpenMP][test] Fix test on MIPS-based buildbots (authored by mstojanovic). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D70823: [clang-tidy] Adding cert-pos34-c check

zukatsinadze created this revision. zukatsinadze added reviewers: aaron.ballman, alexfh, hokein, Charusso. zukatsinadze added projects: clang-tools-extra, clang. Herald added subscribers: cfe-commits, mgehre, xazax.hun, mgorny. According to

[PATCH] D70605: [OpenCL] Fix address space for implicit conversion (PR43145)

svenvh updated this revision to Diff 231426. svenvh added a comment. Address comment from @rjmccall to preserve original `ToType` pointer type. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70605/new/ https://reviews.llvm.org/D70605 Files: clang/lib/Sema/SemaExprCXX.cpp

[PATCH] D70302: [CodeGen] Fix clang crash on aggregate initialization of array of labels

rnk added a comment. Fix looks good post commit, but we should enhance the test. Comment at: clang/test/CodeGen/label-array-aggregate-init.c:1 +// RUN: %clang -cc1 -emit-llvm %s -o /dev/null + It's best practice to filecheck for something, even if this used to

[PATCH] D70439: [Analyzer][Docs][NFC] Add CodeChecker to the command line tools

martong added a comment. @Szelethus, Kristof thanks for the review. @NoQ Ping. I'd like to have an approve from somebody who is outside the CodeChecker/E/// gang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70439/new/

[PATCH] D70808: [mips] Check that features required by built-ins are enabled

Petar.Avramovic accepted this revision. Petar.Avramovic added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70808/new/ https://reviews.llvm.org/D70808

[PATCH] D70819: [ASTImporter] Support functions with placeholder return types ...

martong created this revision. martong added reviewers: balazske, a_sidorin. Herald added subscribers: cfe-commits, teemperor, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. Support functions with

[PATCH] D70818: [Analyzer] Model STL Algoirthms to improve the iterator checkers

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus. baloghadamsoftware added a project: clang. Herald added subscribers: Charusso, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity, mgorny. baloghadamsoftware added a parent

[clang-tools-extra] 6623788 - [include-fixer] Python 3 support for clang-include-fixer.py

Author: Benjamin Kramer Date: 2019-11-28T14:22:21+01:00 New Revision: 66237889a79f728fffc96394740b975774de26bf URL: https://github.com/llvm/llvm-project/commit/66237889a79f728fffc96394740b975774de26bf DIFF:

[PATCH] D70811: [clangd] Don't perform rename when the refs result from index is incomplete.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c3aca245e67: [clangd] Dont perform rename when the refs result from index is incomplete. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 3c3aca2 - [clangd] Don't perform rename when the refs result from index is incomplete.

Author: Haojian Wu Date: 2019-11-28T13:56:19+01:00 New Revision: 3c3aca245e67fa70b6f49b9062983fbdf120ba04 URL: https://github.com/llvm/llvm-project/commit/3c3aca245e67fa70b6f49b9062983fbdf120ba04 DIFF: https://github.com/llvm/llvm-project/commit/3c3aca245e67fa70b6f49b9062983fbdf120ba04.diff

[PATCH] D69938: [OpenCL] Use __generic addr space when generating internal representation of lambda

Anastasia updated this revision to Diff 231409. Anastasia added a comment. Switched to using `getAddrSpaceQualType` in the entire code base. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69938/new/ https://reviews.llvm.org/D69938 Files: clang/include/clang/Sema/Sema.h

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

jhenderson added inline comments. Comment at: llvm/lib/Support/CommandLine.cpp:1069 + return llvm::createStringError( + std::make_error_code(std::errc::illegal_byte_sequence), + "Could not convert UTF16 To UTF8"); lh123 wrote: > jhenderson

[PATCH] D70807: [clangd] Prefer the left character if the character on the right of the cursor is semicolon.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2330cee82f0a: [clangd] Prefer the left character if the character on the right of the cursor… (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D70807?vs=231404=231405#toc

[PATCH] D70811: [clangd] Don't perform rename when the refs result from index is incomplete.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70811/new/ https://reviews.llvm.org/D70811

[clang-tools-extra] 2330cee - [clangd] Prefer the left character if the character on the right of the cursor is semicolon.

Author: Haojian Wu Date: 2019-11-28T13:15:10+01:00 New Revision: 2330cee82f0aa06e8063189fe7a68db3e51f3054 URL: https://github.com/llvm/llvm-project/commit/2330cee82f0aa06e8063189fe7a68db3e51f3054 DIFF: https://github.com/llvm/llvm-project/commit/2330cee82f0aa06e8063189fe7a68db3e51f3054.diff

[PATCH] D70807: [clangd] Prefer the left character if the character on the right of the cursor is semicolon.

hokein updated this revision to Diff 231404. hokein marked an inline comment as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70807/new/ https://reviews.llvm.org/D70807 Files:

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 marked an inline comment as done. lh123 added inline comments. Comment at: llvm/lib/Support/CommandLine.cpp:1069 + return llvm::createStringError( + std::make_error_code(std::errc::illegal_byte_sequence), + "Could not convert UTF16 To UTF8");

[PATCH] D70809: [clangd] Tweak the no-index error message for rename, NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG08cce03a6d95: [clangd] Tweak the no-index error message for rename, NFC. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70809/new/

[clang-tools-extra] 08cce03 - [clangd] Tweak the no-index error message for rename, NFC.

Author: Haojian Wu Date: 2019-11-28T13:03:28+01:00 New Revision: 08cce03a6d959c899e07398603c85168a96f549c URL: https://github.com/llvm/llvm-project/commit/08cce03a6d959c899e07398603c85168a96f549c DIFF: https://github.com/llvm/llvm-project/commit/08cce03a6d959c899e07398603c85168a96f549c.diff

[PATCH] D70811: [clangd] Don't perform rename when the refs result from index is incomplete.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Also do an early return if the number of affected files > limit to save some unnecessary FileURI computations.

[PATCH] D69948: [Checkers] Added support for freopen to StreamChecker.

baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:201 +std::tie(StateRetNotNull, StateRetNull) = +CM.assumeDual(StateStreamNull, RetVal); +if (StateRetNull) { balazske wrote: > NoQ wrote: >

[PATCH] D70809: [clangd] Tweak the no-index error message for rename, NFC.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70809/new/ https://reviews.llvm.org/D70809

[PATCH] D70723: [clangd] Store index::SymbolKind in HoverInfo

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Hover.cpp:363 HI.Name = Macro.Name; - HI.Kind = indexSymbolKindToSymbolKind( -

[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

bader added a comment. In D60455#1762804 , @Anastasia wrote: > Sorry, I don't have capacity currently to review this and I don't want to be > blocking it either. @Anastasia, thanks for finding time for reviewing previous revisions of the patch. I

[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

Anastasia resigned from this revision. Anastasia added a comment. This revision is now accepted and ready to land. Sorry, I don't have capacity currently to review this and I don't want to be blocking it either. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

jhenderson added inline comments. Comment at: llvm/lib/Support/CommandLine.cpp:1069 + return llvm::createStringError( + std::make_error_code(std::errc::illegal_byte_sequence), + "Could not convert UTF16 To UTF8"); jhenderson wrote: >

[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

bader updated this revision to Diff 231396. bader added a comment. Fixed typo in the commit message: complier -> compiler. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/ https://reviews.llvm.org/D60455 Files:

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231395. lh123 marked an inline comment as done. lh123 added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files:

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

jhenderson added inline comments. Comment at: llvm/lib/Support/CommandLine.cpp:1069 + return llvm::createStringError( + std::make_error_code(std::errc::illegal_byte_sequence), + "Could not convert UTF16 To UTF8");

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 231393. lh123 marked 5 inline comments as done. lh123 added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files:

[PATCH] D70535: [clangd] Define out-of-line qualify return value

kadircet updated this revision to Diff 231391. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70535/new/ https://reviews.llvm.org/D70535 Files: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp

[PATCH] D70807: [clangd] Prefer the left character if the character on the right of the cursor is semicolon.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Selection.cpp:517 + // But if that's whitespace/semicolon, we likely want the token on the left. + if

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231390. lh123 marked 6 inline comments as done. lh123 added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files:

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

kadircet added a comment. mostly LG, a few last nits. Comment at: clang/lib/Tooling/ExpandResponseFilesCompilationDatabase.cpp:51 + // FIXME: we should rather propagate the current directory into + // ExpandResponseFiles as well in addition to FS and someone can take

[PATCH] D70809: [clangd] Tweak the no-index error message for rename, NFC.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. The current error message doesn't fit well for cross-file rename. Repository: rG LLVM Github Monorepo

[PATCH] D70807: [clangd] Prefer the left character if the character on the right of the cursor is semicolon.

merge_guards_bot added a comment. Build result: pass - 60338 tests passed, 0 failed and 732 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

jhenderson added inline comments. Comment at: llvm/lib/Support/CommandLine.cpp:1071 + return llvm::make_error( + "Could not convert UTF16 To UTF8", llvm::inconvertibleErrorCode()); Str = StringRef(UTF8Buf); Not sure, but you might want to use

[PATCH] D70808: [mips] Check that features required by built-ins are enabled

atanasyan created this revision. atanasyan added a reviewer: Petar.Avramovic. Herald added subscribers: jrtc27, arichardson, sdardis. Herald added a project: clang. Now Clang does not check that features required by built-in functions are enabled. That causes errors in the backend reported in

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, please make sure you've clang-formatted the changes though Comment at: llvm/lib/Support/CommandLine.cpp:1054 + llvm::ErrorOr CurrDirOrErr =

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

bader updated this revision to Diff 231386. bader added a comment. Applied code review suggestions. - Split the patch into two parts. This patch contains only Sema part and LLVM IR generation part will be added separately. Updated commit message. - Replace `can't` with `cannot`. Repository:

[PATCH] D70807: [clangd] Prefer the left character if the character on the right of the cursor is semicolon.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This would make go-to-def works on the cases like int A = abc^; Repository: rG LLVM Github Monorepo

[PATCH] D69298: [clangd] Define out-of-line initial apply logic

merge_guards_bot added a comment. Build result: FAILURE - Could not check out parent git hash "6a2d56e54fa4a2009787a605607b0df7fe16dd98". It was not found in the repository. Did you configure the "Parent Revision" in Phabricator properly? Trying to apply the patch to the master branch

[PATCH] D69298: [clangd] Define out-of-line initial apply logic

kadircet updated this revision to Diff 231382. kadircet marked an inline comment as done. kadircet added a comment. - Address comments - Better handling for macros and tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69298/new/

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231384. lh123 added a comment. fixes no matching constructor for initialization of `llvm::StringError`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files:

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

merge_guards_bot added a comment. Build result: FAILURE - Log files: console-log.txt , CMakeCache.txt Repository: rG

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231381. lh123 added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files: llvm/include/llvm/Support/CommandLine.h

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

merge_guards_bot added a comment. Build result: FAILURE - Log files: console-log.txt , CMakeCache.txt Repository: rG

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231377. lh123 added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files: llvm/include/llvm/Support/CommandLine.h

[PATCH] D70779: AArch64: add support for newer Apple CPUs

fhahn added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:143 MtuneLowerCase = llvm::sys::getHostCPUName(); - if (MtuneLowerCase == "cyclone") { + if (MtuneLowerCase == "cyclone" || MtuneLowerCase.find("apple") == 0) {

[PATCH] D69266: [clangd] Define out-of-line availability checks

merge_guards_bot added a comment. Build result: pass - 60292 tests passed, 0 failed and 732 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70805: [analyzer] SValHasDescendant: Determine whether the SVal has an SVal descendant

Charusso added a comment. It suppresses stuff in `curl` like: char buf[4096]; size_t linelen = strlen(line); char *ptr = realloc(line, linelen + strlen(buf) + 1); strcpy([linelen], buf); char buffer[256]; char *string = NULL; size_t buflen = strlen(buffer); char *ptr =

[PATCH] D70805: [analyzer] SValHasDescendant: Determine whether the SVal has an SVal descendant

Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Charusso added a parent revision: D70411: [analyzer] CERT:

[PATCH] D69266: [clangd] Define out-of-line availability checks

kadircet updated this revision to Diff 231374. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments - Bail out on templated classes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69266/new/

[PATCH] D70779: AArch64: add support for newer Apple CPUs

kristof.beyls added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:143 MtuneLowerCase = llvm::sys::getHostCPUName(); - if (MtuneLowerCase == "cyclone") { + if (MtuneLowerCase == "cyclone" || MtuneLowerCase.find("apple") == 0) {

[PATCH] D70779: AArch64: add support for newer Apple CPUs

t.p.northover marked an inline comment as done. t.p.northover added a comment. Thanks Florian. I'll wait as you suggest. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:143 MtuneLowerCase = llvm::sys::getHostCPUName(); - if (MtuneLowerCase == "cyclone") { + if

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

bryanpkc created this revision. bryanpkc added reviewers: pawosm01, gtbercea. Herald added subscribers: cfe-commits, guansong, kristof.beyls. Herald added a reviewer: jdoerfert. Herald added a project: clang. D30644 added OpenMP offloading to AArch64 targets,

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

jhenderson added inline comments. Comment at: llvm/lib/Support/CommandLine.cpp:1148 + llvm::ErrorOr RHS = FS.status(RFile.File); + if (!LHS || !RHS) { +return false; kadircet wrote: > again you need to `consumeError`s before returning. I would

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231361. lh123 added a comment. Sorry, upload the wrong patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files: llvm/include/llvm/Support/CommandLine.h

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

merge_guards_bot added a comment. Build result: FAILURE - Log files: console-log.txt , CMakeCache.txt Repository: rG

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231359. Herald added a subscriber: mgorny. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files: clang/include/clang/Tooling/CompilationDatabase.h

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

merge_guards_bot added a comment. Build result: FAILURE - Log files: console-log.txt , CMakeCache.txt Repository: rG