[PATCH] D70746: [clangd] Highlighting dependent types in more contexts

nridge updated this revision to Diff 231609. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70746/new/ https://reviews.llvm.org/D70746 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp

[PATCH] D70727: [clangd] Keep go-to-definition working at the end of an identifier (fixes #194)

nridge added a comment. In D70727#1763781 , @hokein wrote: > In D70727#1760485 , @nridge wrote: > > > By the way, may I get permissions to assign issues to myself (and make > > other such metadata changes to

[PATCH] D70727: [clangd] Keep go-to-definition working at the end of an identifier (fixes #194)

nridge abandoned this revision. nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:153 + // allowing go-to-definition to work at the end of an identifier. + if (Result.empty() && Offset > 0) { +Result =

[PATCH] D70740: [clangd] Find reference to template parameter in 'sizeof...' expression

nridge updated this revision to Diff 231608. nridge added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70740/new/ https://reviews.llvm.org/D70740 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D70868: [libunwind] Emit dependent libraries only when detected by CMake

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM, thanks! Would it be possible to make the same change to libc++abi and libc++ as well (since they also use dependent library feature)? CHANGES SINCE LAST ACTION

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

nicolas updated this revision to Diff 231604. nicolas added a comment. Hi @mordante, thanks for the interest. Here's an updated patch that addresses @aaron.ballman's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ https://reviews.llvm.org/D63276 Files:

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

vchuravy updated this revision to Diff 231601. vchuravy added a comment. - fix AS in anyref testfile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66035/new/ https://reviews.llvm.org/D66035 Files: clang/lib/Basic/Targets/WebAssembly.h

[PATCH] D70872: [clangd] Implement "textDocument/documentLink" protocol support

MForster marked an inline comment as done. MForster added inline comments. Comment at: clang-tools-extra/clangd/test/document-link.test:21 +# CHECK-NEXT: }, +# CHECK-NEXT: "target": "file://{{.*}}/iostream" +# CHECK-NEXT:}, Originally I tried to

[PATCH] D70872: Advertise documentLink capability

MForster created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. Add "textDocument/documentLink" protocol support Implement "textDocument/documentLink" Repository: rG LLVM Github Monorepo

[PATCH] D69180: [Format] Add format check for coroutine keywords with negative numbers

modocache added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1761 + tok::kw_case, tok::at, tok::l_brace, tok::kw_throw, + tok::kw_co_return, tok_kw_co_yield)) return TT_UnaryOperator;

[PATCH] D69180: [Format] Add format check for coroutine keywords with negative numbers

This revision was automatically updated to reflect the committed changes. Closed by commit rG8682d29a2877: [Format] Add format check for coroutine keywords with negative numbers (authored by modocache). Changed prior to commit: https://reviews.llvm.org/D69180?vs=225672=231596#toc Repository:

[clang] 8682d29 - [Format] Add format check for coroutine keywords with negative numbers

Author: Brian Gesiak Date: 2019-11-30T15:47:58-05:00 New Revision: 8682d29a28772bab0283a141b8701bfaea8881a6 URL: https://github.com/llvm/llvm-project/commit/8682d29a28772bab0283a141b8701bfaea8881a6 DIFF: https://github.com/llvm/llvm-project/commit/8682d29a28772bab0283a141b8701bfaea8881a6.diff

[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

bader updated this revision to Diff 231595. bader marked 4 inline comments as done. bader added a comment. Applied comments from @Fznamznon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/ https://reviews.llvm.org/D60455 Files:

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

Mordante added a comment. I've been looking at a way to get the ellipsis location so I'd like this patch to move forward. @nicolas are you still working on this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ https://reviews.llvm.org/D63276

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

Mordante added a comment. I like this improvement. However I'm not a reviewer. Comment at: clang/lib/Sema/SemaChecking.cpp:12361 + /// \param RefsSeenPtr is used to avoid reference cycles. When such a cycle + /// is possible we check first if \param RefsSeenPtr is non-null.

[PATCH] D70869: [Analyzer] Use a reference in a range-based for

Mordante created this revision. Mordante added reviewers: dcoughlin, aaron.ballman, xbolva00, Szelethus. Mordante added a project: clang. Herald added subscribers: Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. This avoids unneeded copies when

[PATCH] D69223: WDocumentation: Implement the \anchor.

Mordante updated this revision to Diff 231592. Mordante added a comment. Addresses review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69223/new/ https://reviews.llvm.org/D69223 Files: clang/bindings/xml/comment-xml-schema.rng clang/include/clang-c/Documentation.h

[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

Fznamznon added a comment. A couple of minor comments. Comment at: clang/include/clang/Basic/AttrDocs.td:313 + +- Function template with at least two template parameters is expected. The compiler +generates OpenCL kernel and uses first template parameter as unique name to the

[PATCH] D69223: WDocumentation: Implement the \anchor.

Mordante marked 5 inline comments as done. Mordante added a comment. Thanks for the review. I'll address your comments and upload a new version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69223/new/ https://reviews.llvm.org/D69223

[clang] 3f4b70c - Revert "[clang][modules] Add support for merging lifetime-extended temporaries"

Author: Tyker Date: 2019-11-30T17:52:26+01:00 New Revision: 3f4b70c79e686117c2754d2c0a5a44c8b6829e79 URL: https://github.com/llvm/llvm-project/commit/3f4b70c79e686117c2754d2c0a5a44c8b6829e79 DIFF: https://github.com/llvm/llvm-project/commit/3f4b70c79e686117c2754d2c0a5a44c8b6829e79.diff LOG:

[PATCH] D70190: [clang][modules] Add support for merging lifetime-extended temporaries

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c7f6b439699: [clang][modules] Add support for merging lifetime-extended temporaries (authored by Tyker). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 3c7f6b4 - [clang][modules] Add support for merging lifetime-extended temporaries

Author: Tyker Date: 2019-11-30T16:42:33+01:00 New Revision: 3c7f6b439699a9cbbc0ac8d288cc70aff357446b URL: https://github.com/llvm/llvm-project/commit/3c7f6b439699a9cbbc0ac8d288cc70aff357446b DIFF: https://github.com/llvm/llvm-project/commit/3c7f6b439699a9cbbc0ac8d288cc70aff357446b.diff LOG:

[PATCH] D70190: [clang][modules] Add support for merging lifetime-extended temporaries

Tyker updated this revision to Diff 231589. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70190/new/ https://reviews.llvm.org/D70190 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang/AST/TextNodeDumper.h clang/include/clang/Serialization/ASTReader.h

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

SouraVX added a comment. In D70696#1764306 , @umesh.kalappa0 wrote: > @SouraVX and @yonghong-song > > cat extern.c > int global_var = 2; > > compile as an extern.c shared a library ,then final executable a.out doesn't > have debugInfo for global_var.

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

umesh.kalappa0 added a comment. @SouraVX and @yonghong-song cat extern.c int global_var = 2; compile as an extern.c shared a library ,then final executable a.out doesn't have debugInfo for global_var. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70868: [libunwind] Emit dependent libraries only when detected by CMake

mgorny created this revision. mgorny added reviewers: phosek, ldionne. Herald added subscribers: jfb, dexonsmith, christof, krytarowski, srhines. 996e62eef75 added Linux-specific dependent libraries to libunwind sources. As a result, building libunwind with modern LLD on *BSD started failing due

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70048/new/ https://reviews.llvm.org/D70048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

SouraVX added a comment. In D70696#1764043 , @yonghong-song wrote: > If I remove `!D->isUsed()`, I should be able to generate the debuginfo for > `global_var` and eventually in dwarf in your above case. > What exactly your use case here for these

[PATCH] D70829: [ARM][MVE][Intrinsics] Add VMINQ/VMAXQ/VMINNMQ/VMAXNMQ intrinsics.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks. I'm happy if simon does not have any extra comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70829/new/

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

xbolva00 added a comment. Looks better, thanks. Aaron ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70638/new/ https://reviews.llvm.org/D70638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Tyker updated this revision to Diff 231585. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70638/new/ https://reviews.llvm.org/D70638 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticParseKinds.td clang/include/clang/Lex/Preprocessor.h

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Tyker marked an inline comment as done. Tyker added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:1376 + +MIChecker.Check(ElseStmt.isUsable()); Tyker wrote: > xbolva00 wrote: > > What is wrong with code you used some rev ago? > > > > if

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay added a comment. gentle ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Tyker marked an inline comment as done. Tyker added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:1376 + +MIChecker.Check(ElseStmt.isUsable()); xbolva00 wrote: > What is wrong with code you used some rev ago? > > if (usable) check(); > > Now

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Tyker updated this revision to Diff 231584. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70638/new/ https://reviews.llvm.org/D70638 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticParseKinds.td clang/include/clang/Lex/Preprocessor.h

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Tyker updated this revision to Diff 231583. Tyker added a comment. Improve the warning for else if CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70638/new/ https://reviews.llvm.org/D70638 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D70302: [CodeGen] Fix clang crash on aggregate initialization of array of labels

johannes added a comment. In D70302#1763025 , @rnk wrote: > Fix looks good post commit, but we should enhance the test. I see, apologies for the premature commit. Comment at: clang/test/CodeGen/label-array-aggregate-init.c:1 +// RUN: