[PATCH] D70850: [Clang-Tidy] Quick fix for bug in bugprone-macro-parentheses 43804

2019-12-01 Thread Balogh, Ádám via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG497a754adeca: [Clang-Tidy] Quick fix for bug in bugprone-macro-parentheses 43804 (authored by baloghadamsoftware). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 497a754 - [Clang-Tidy] Quick fix for bug in bugprone-macro-parentheses 43804

2019-12-01 Thread Adam Balogh via cfe-commits
Author: Adam Balogh Date: 2019-12-02T08:50:51+01:00 New Revision: 497a754adeca67196c12a936d09c12d6803f99de URL: https://github.com/llvm/llvm-project/commit/497a754adeca67196c12a936d09c12d6803f99de DIFF: https://github.com/llvm/llvm-project/commit/497a754adeca67196c12a936d09c12d6803f99de.diff

[PATCH] D70850: [Clang-Tidy] Quick fix for bug in bugprone-macro-parentheses 43804

2019-12-01 Thread Balogh, Ádám via Phabricator via cfe-commits
baloghadamsoftware added a comment. In D70850#1764469 , @aaron.ballman wrote: > LGTM, but we may have other things to test (or bugs to fix) here. Oh yes, this check seems a bit incomplete, more statements are missing, but this particular issue was a

[PATCH] D69878: Consoldiate internal denormal flushing controls

2019-12-01 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm marked an inline comment as done. arsenm added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1775 -if (getLangOpts().OpenCL) - FuncAttrs.addAttribute("denorms-are-zero", - llvm::toStringRef(CodeGenOpts.FlushDenorm));

[Diffusion] rG825235c140e7: Revert "[Sema] Use the canonical type in function isVector"

2019-12-01 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added a comment. The test is failing because `float16x4_t` is defined as a vector of `__fp16` in arm_neon.h and Sema promotes vectors of `__fp16` to vectors of float since `__fp16` is a storage-only type. The test used to pass because of a bug in function `isVector`, which was fixed

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

2019-12-01 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. In D69785#1763317 , @jdoerfert wrote: > I'm confused. Was this a review? I'm waiting for a decision here so we can > move on and

[clang] ae54845 - Revert "[clang][modules] Add support for merging lifetime-extended temporaries"

2019-12-01 Thread via cfe-commits
Author: Tyker Date: 2019-12-01T22:38:31+01:00 New Revision: ae5484540f15bcbcb0de9558e66b0217ab8473ed URL: https://github.com/llvm/llvm-project/commit/ae5484540f15bcbcb0de9558e66b0217ab8473ed DIFF: https://github.com/llvm/llvm-project/commit/ae5484540f15bcbcb0de9558e66b0217ab8473ed.diff LOG:

[clang] a3cbe1a - [clang][modules] Add support for merging lifetime-extended temporaries

2019-12-01 Thread via cfe-commits
Author: Tyker Date: 2019-12-01T21:28:48+01:00 New Revision: a3cbe1a202df6ec8e23bd55e14db254e4bc33021 URL: https://github.com/llvm/llvm-project/commit/a3cbe1a202df6ec8e23bd55e14db254e4bc33021 DIFF: https://github.com/llvm/llvm-project/commit/a3cbe1a202df6ec8e23bd55e14db254e4bc33021.diff LOG:

[PATCH] D65694: Properly instantiate a decltype in argument's default initializer

2019-12-01 Thread Mark de Wever via Phabricator via cfe-commits
Mordante added a comment. Friendly ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65694/new/ https://reviews.llvm.org/D65694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

2019-12-01 Thread Mark de Wever via Phabricator via cfe-commits
Mordante added a comment. Thanks for updating the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ https://reviews.llvm.org/D63276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70878: [analyzer] Add support for namespaces to GenericTaintChecker

2019-12-01 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 created this revision. boga95 added reviewers: NoQ, Szelethus. boga95 added a project: clang. Herald added subscribers: cfe-commits, Charusso, donat.nagy, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. Now the user can define a `Scope` for every configured function: - Functions

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

2019-12-01 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. I don't think that //misc// module should be used when checks belong to //cert// Comment at: clang-tools-extra/clang-tidy/misc/SpuriouslyWakeUpFunctionsCheck.cpp:77 +const MatchFinder::MatchResult ) { + + const auto *MatchedWait =

[PATCH] D70520: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export names

2019-12-01 Thread Sam Clegg via Phabricator via cfe-commits
sbc100 updated this revision to Diff 231620. sbc100 added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70520/new/ https://reviews.llvm.org/D70520 Files: clang/include/clang/Basic/Attr.td

[PATCH] D70877: [WebAssebmly][MC] Support .import_name/.import_field asm directives

2019-12-01 Thread Sam Clegg via Phabricator via cfe-commits
sbc100 created this revision. Herald added subscribers: llvm-commits, cfe-commits, aheejin, hiraditya, jgravelle-google, dschuff. Herald added projects: clang, LLVM. Convert the MC test to use asm rather than bitcode. This is a precursor to https://reviews.llvm.org/D70520. Repository: rG

[PATCH] D70520: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export names

2019-12-01 Thread Sam Clegg via Phabricator via cfe-commits
sbc100 added a comment. In D70520#1754500 , @sunfish wrote: > It appears this doesn't handle exporting an imported function yet, which is > fine for now, but it would be good to issue a warning, because wasm itself is > capable of representing this: > >

[PATCH] D70520: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export names

2019-12-01 Thread Sam Clegg via Phabricator via cfe-commits
sbc100 updated this revision to Diff 231618. sbc100 marked an inline comment as done. sbc100 added a comment. - Add support for asm parsing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70520/new/ https://reviews.llvm.org/D70520 Files:

[PATCH] D70876: Add spuriously-wake-up-functions check

2019-12-01 Thread Kocsis Ábel via Phabricator via cfe-commits
abelkocsis created this revision. abelkocsis added reviewers: aaron.ballman, alexfh, hokein, jfb. abelkocsis added projects: clang-tools-extra, clang. Herald added subscribers: cfe-commits, mgehre, dexonsmith, mgorny. According to

[PATCH] D68923: Don't warn about missing declarations for partial template specializations

2019-12-01 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert added a comment. @rsmith, could you please have a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68923/new/ https://reviews.llvm.org/D68923 ___ cfe-commits mailing list

[PATCH] D69620: Add AIX assembler support

2019-12-01 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. LGTM with minor change request to a comment. Thanks. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:68 + if (Inputs.size() != 1) +llvm_unreachable("Invalid number of input files."); +

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

2019-12-01 Thread Nicolas Manichon via Phabricator via cfe-commits
nicolas updated this revision to Diff 231615. nicolas added a comment. Update the comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ https://reviews.llvm.org/D63276 Files: clang/include/clang/AST/Decl.h clang/include/clang/AST/Type.h clang/lib/AST/ASTContext.cpp

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

2019-12-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor commenting request. Comment at: clang/include/clang/AST/Decl.h:2400 + /// Attempt to compute an informative source range covering the

[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

2019-12-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM with some testing requests. Comment at: clang/test/SemaSYCL/kernel-attribute.cpp:4-5 + +__attribute((sycl_kernel)) void foo() { +} aaron.ballman wrote: > Missing some tests: > * test

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

2019-12-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:1369-1370 /*ShouldEnter=*/ConstexprCondition && *ConstexprCondition); -ElseStmt = ParseStatement(); +if (Tok.is(tok::kw_if)) + ElseStmt = ParseIfStatement(nullptr, ElseLoc); +

[PATCH] D70868: [libunwind] Emit dependent libraries only when detected by CMake

2019-12-01 Thread Michał Górny via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG35bc5276ca31: [libunwind] Emit dependent libraries only when detected by CMake (authored by mgorny). Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Repository: rG LLVM

[PATCH] D70823: [clang-tidy] Adding cert-pos34-c check

2019-12-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/PutenvWithAutoCheck.cpp:27 + hasAutomaticStorageDuration(), + unless(hasDescendant(callExpr(callee(functionDecl(hasAnyName( + "::alloc",

[PATCH] D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable

2019-12-01 Thread ben via Phabricator via cfe-commits
bd1976llvm added a comment. In D68101#1689622 , @SjoerdMeijer wrote: > Just to make sure I haven't missed anything, I would like to take this patch > and run some numbers, for which I need a little bit of time. Hi @SjoerdMeijer. Did you have a chance

[PATCH] D70868: [libunwind] Emit dependent libraries only when detected by CMake

2019-12-01 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. I'll look into it a bit later. I've focused on libunwind since it's breaking NetBSD buildbot. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70868/new/ https://reviews.llvm.org/D70868 ___ cfe-commits mailing list

[PATCH] D70850: [Clang-Tidy] Quick fix for bug in bugprone-macro-parentheses 43804

2019-12-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but we may have other things to test (or bugs to fix) here. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-macro-parentheses.cpp:46

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

2019-12-01 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru added a comment. @kristina can we land this patch ? Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69758/new/ https://reviews.llvm.org/D69758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 486d1a5 - Revert "[clang][modules] Add support for merging lifetime-extended temporaries"

2019-12-01 Thread via cfe-commits
Author: Tyker Date: 2019-12-01T11:58:14+01:00 New Revision: 486d1a535896aa4f48f0ecaf451ea35dbd4f137b URL: https://github.com/llvm/llvm-project/commit/486d1a535896aa4f48f0ecaf451ea35dbd4f137b DIFF: https://github.com/llvm/llvm-project/commit/486d1a535896aa4f48f0ecaf451ea35dbd4f137b.diff LOG:

[clang] 85c7438 - [clang][modules] Add support for merging lifetime-extended temporaries

2019-12-01 Thread via cfe-commits
Author: Tyker Date: 2019-11-30T23:09:11+01:00 New Revision: 85c74384778909789389b9012a75cfcca7964a28 URL: https://github.com/llvm/llvm-project/commit/85c74384778909789389b9012a75cfcca7964a28 DIFF: https://github.com/llvm/llvm-project/commit/85c74384778909789389b9012a75cfcca7964a28.diff LOG: