[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

2019-12-02 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. I can tell from https://zed0.co.uk/clang-format-configurator/ that it's not possible to get it to the form you suggested, I'm not opposed to accepting this, I'm just

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

2019-12-02 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. > `note()` Of course i mean something like this: std::string text = note(); if (!text.empty()) return text; (and return something like `""` on the other return path in the inner lambdas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

2019-12-02 Thread Sourabh Singh Tomar via Phabricator via cfe-commits
SouraVX added a comment. In D70111#1765223 , @dblaikie wrote: > Looks OK to me - please recommit when you're ready. Thank you @awpandey . As requested, I've recommited this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70111/new/

[PATCH] D70935: [CodeGen][ObjC] Emit a primitive store to store a __strong field in ExpandTypeFromArgs

2019-12-02 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1054 + "pointer to __strong expected"); + EmitStoreOfScalar(*AI++, LV); +} else This definitely deserves a comment. I don't think the assertion is right; the condition

[clang] f1e3988 - Recommit "[DWARF5]Addition of alignment atrribute in typedef DIE."

2019-12-02 Thread Sourabh Singh Tomar via cfe-commits
Author: Sourabh Singh Tomar Date: 2019-12-03T09:51:43+05:30 New Revision: f1e3988aa6016188c376b9bcca1afc7559f9fbc0 URL: https://github.com/llvm/llvm-project/commit/f1e3988aa6016188c376b9bcca1afc7559f9fbc0 DIFF:

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

2019-12-02 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In D70725#1765981 , @xazax.hun wrote: > the same call might both acquire and release handles (there are such calls in > Fuchsia), so we might end up adding more than one note for a call for which > we would need to add more than one

[PATCH] D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable

2019-12-02 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. I can't speak for the pragma authors, but I strongly doubt the pragma is intended to force all affected globals to go into a single section unit, since the division into section units is purely an object-file representation issue. Looks to me like

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-02 Thread Michele Scandale via Phabricator via cfe-commits
michele.scandale added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2345 +<< "-ffp-contract=fast"; +optID = options::OPT_ffp_contract; +FPModel = Val; mibintc wrote: > michele.scandale wrote: > > Here the state

[PATCH] D70936: [clang-scan-deps] do not skip empty #if/#elif in the minimize to avoid missing `__has_include` dependencies

2019-12-02 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. arphaman marked an inline comment as done. Closed by commit rG389530524be1: [clang-scan-deps] do not skip empty #if/#elif in the minimizer to avoid missing… (authored by arphaman). Changed prior to commit:

[clang] 3895305 - [clang-scan-deps] do not skip empty #if/#elif in the minimizer to avoid missing `__has_include` dependencies

2019-12-02 Thread Alex Lorenz via cfe-commits
Author: Alex Lorenz Date: 2019-12-02T18:47:22-08:00 New Revision: 389530524be1715e97947810514f3a75dfe73975 URL: https://github.com/llvm/llvm-project/commit/389530524be1715e97947810514f3a75dfe73975 DIFF: https://github.com/llvm/llvm-project/commit/389530524be1715e97947810514f3a75dfe73975.diff

[PATCH] D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable

2019-12-02 Thread ben via Phabricator via cfe-commits
bd1976llvm added a comment. In D68101#1766151 , @nickdesaulniers wrote: > In D68101#1765665 , @rjmccall wrote: > > > Given all that, this patch seems far too aggressive. While mergeable > > sections can be

[PATCH] D70936: [clang-scan-deps] do not skip empty #if/#elif in the minimize to avoid missing `__has_include` dependencies

2019-12-02 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, although I have a suggested change for one of the comments (and I'm still sad about this). Comment at:

[PATCH] D70935: [CodeGen][ObjC] Emit a primitive store to store a __strong field in ExpandTypeFromArgs

2019-12-02 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added a comment. Note that passing `isInit=true` to `EmitStoreThroughLValue` to make it emit `llvm.objc.retain` would be incorrect since the callee destructs the struct argument. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70935/new/

[PATCH] D70936: [clang-scan-deps] do not skip empty #if/#elif in the minimize to avoid missing `__has_include` dependencies

2019-12-02 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman created this revision. arphaman added reviewers: Bigcheese, dexonsmith, kousikk. Herald added subscribers: ributzka, tschuett, jkorous. Herald added a project: clang. This patch makes the minimizer more conservative to avoid missing dependency files that are brought in by

[PATCH] D70935: [CodeGen][ObjC] Emit a primitive store to store a __strong field in ExpandTypeFromArgs

2019-12-02 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak created this revision. ahatanak added a reviewer: rjmccall. ahatanak added a project: clang. Herald added subscribers: ributzka, dexonsmith, jkorous. This fixes a bug in IRGen where a call to `llvm.objc.storeStrong` was being emitted to initialize a __strong field of an uninitialized

[PATCH] D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable

2019-12-02 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. > So I don't think we should even be trying to mark sections as mergeable > unless we walk all elements in the section and make sure it's even safe to > apply these. That's the conservative fix, yes. You can either: 1. emit global objects with the same section name

[PATCH] D69543: [clangd] Add a tweak refactoring to wrap Objective-C string literals in `NSLocalizedString` macros

2019-12-02 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.h:80 + const LangOptions () const { +return getASTContext().getLangOpts(); kadircet wrote: > can we introduce this helper in a new patch, while changing other occurrences > in

[PATCH] D69543: [clangd] Add a tweak refactoring to wrap Objective-C string literals in `NSLocalizedString` macros

2019-12-02 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman updated this revision to Diff 231799. arphaman marked 6 inline comments as done. arphaman added a comment. Fixed nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69543/new/ https://reviews.llvm.org/D69543 Files:

[PATCH] D70931: [MS] Emit exported complete/vbase destructors

2019-12-02 Thread Reid Kleckner via Phabricator via cfe-commits
rnk created this revision. rnk added a reviewer: hans. Herald added a project: clang. Fixes PR44205 I checked, and deleting destructors are not affected. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70931 Files: clang/lib/CodeGen/MicrosoftCXXABI.cpp

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

2019-12-02 Thread Florin Iucha via Phabricator via cfe-commits
0x8000- added a comment. Thank you for rebasing on current master. I have ran it today on our code base and found three classes of false positives: 1. Writing to a bitfield of a struct. The struct still is suggested it should be const. 2. Using a variable with an ostream extraction; like

[PATCH] D70368: [clang-tidy] Rewrite modernize-avoid-bind check

2019-12-02 Thread Zachary Turner via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG64f74bf72eb4: [clang-tidy] Rewrite modernize-avoid-bind check. (authored by zturner). Changed prior to commit: https://reviews.llvm.org/D70368?vs=230661=231793#toc Repository: rG LLVM Github

[PATCH] D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable

2019-12-02 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. In D68101#1765665 , @rjmccall wrote: > Given all that, this patch seems far too aggressive. While mergeable > sections can be useful for optimizing arbitrary code that might not use a > section, they are also extremely

[clang-tools-extra] 64f74bf - [clang-tidy] Rewrite modernize-avoid-bind check.

2019-12-02 Thread Zachary Turner via cfe-commits
Author: Zachary Turner Date: 2019-12-02T15:36:26-08:00 New Revision: 64f74bf72eb484aa32e1104050cb54745116decf URL: https://github.com/llvm/llvm-project/commit/64f74bf72eb484aa32e1104050cb54745116decf DIFF:

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

2019-12-02 Thread Tyker via Phabricator via cfe-commits
Tyker updated this revision to Diff 231792. Tyker added a comment. improved based on aaron's comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70638/new/ https://reviews.llvm.org/D70638 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

2019-12-02 Thread Kanglei Fang via Phabricator via cfe-commits
ghvg1313 updated this revision to Diff 231790. ghvg1313 added a comment. - Update documents Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70926/new/ https://reviews.llvm.org/D70926 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

2019-12-02 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea added a comment. You're right indeed Russell, my bad, this gain is not as important as I initially claimed -- however there's a gain. Several factors came into play: 1. The latest ninja 1.9.0 doesn't use all cpu sockets on some Windows systems (see this

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

2019-12-02 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song updated this revision to Diff 231786. yonghong-song edited the summary of this revision. yonghong-song added a comment. clang-format change (from @aprantl) , add a little details into summary related to recent discussion, move tests from CodeGenCXX to CodeGen as they are all C

[PATCH] D70302: [CodeGen] Fix clang crash on aggregate initialization of array of labels

2019-12-02 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. In D70302#1764261 , @johannes wrote: > I see, apologies for the premature commit. No problem, LLVM's code review practices are somewhat opaque. Comment at: clang/test/CodeGen/label-array-aggregate-init.c:1 +//

[clang] 536ceda - FileCheck IR output for blockaddress in new test

2019-12-02 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2019-12-02T15:05:50-08:00 New Revision: 536cedaecbe586ec9cf86d5102872adc27e6ea23 URL: https://github.com/llvm/llvm-project/commit/536cedaecbe586ec9cf86d5102872adc27e6ea23 DIFF: https://github.com/llvm/llvm-project/commit/536cedaecbe586ec9cf86d5102872adc27e6ea23.diff

[PATCH] D70748: [clang test] Do not assume default target

2019-12-02 Thread Thomas Preud'homme via Phabricator via cfe-commits
thopre closed this revision. thopre added a comment. Committed as 717140a0dcc651ca2fec23248d1675fb2d388b9c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70748/new/

[PATCH] D69088: [Lex] #pragma clang transform

2019-12-02 Thread Michael Kruse via Phabricator via cfe-commits
Meinersbur added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69088/new/ https://reviews.llvm.org/D69088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 717140a - [clang test] Do not assume default target

2019-12-02 Thread Thomas Preud'homme via cfe-commits
Author: Thomas Preud'homme Date: 2019-12-02T22:57:30Z New Revision: 717140a0dcc651ca2fec23248d1675fb2d388b9c URL: https://github.com/llvm/llvm-project/commit/717140a0dcc651ca2fec23248d1675fb2d388b9c DIFF: https://github.com/llvm/llvm-project/commit/717140a0dcc651ca2fec23248d1675fb2d388b9c.diff

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

2019-12-02 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. @aaron.ballman Type attributes are definitely more flexible as in they can be applied in more contexts. These attributes, however, make no sense outside of a function declaration, or maybe a type alias. So I feel like we could argue on both sides. I made a minimal

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

2019-12-02 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun updated this revision to Diff 231784. xazax.hun added a comment. - Convert to type attributes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70469/new/ https://reviews.llvm.org/D70469 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

2019-12-02 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. Could you update the ClangStyleOption.rst (using the tool in docs/tools) and as you are adding a new option would you add a line or two in the docs/ReleaseNotes.rst in the clang-format section Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70923: Fix comment to more accurately describe C++ language requirements around tail padding.

2019-12-02 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG711c669ae926: Fix comment to more accurately describe C++ language requirements around tail… (authored by rsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 711c669 - Fix comment to more accurately describe C++ language requirements around tail padding.

2019-12-02 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2019-12-02T14:41:27-08:00 New Revision: 711c669ae92658aecc6fabccc583594924bac6d7 URL: https://github.com/llvm/llvm-project/commit/711c669ae92658aecc6fabccc583594924bac6d7 DIFF: https://github.com/llvm/llvm-project/commit/711c669ae92658aecc6fabccc583594924bac6d7.diff

[PATCH] D70923: Fix comment to more accurately describe C++ language requirements around tail padding.

2019-12-02 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70923/new/ https://reviews.llvm.org/D70923

[PATCH] D70926: Add option for not breaking line before ObjC params

2019-12-02 Thread Kanglei Fang via Phabricator via cfe-commits
ghvg1313 created this revision. ghvg1313 added a reviewer: klimek. Herald added a project: clang. Herald added a subscriber: cfe-commits. >From `clang-format` version 3.7.0 and up, , there is no way to keep following >format of ObjectiveC block: - (void)_aMethod { [self.test1 t:self

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

2019-12-02 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song added a comment. @dblaikie The concern for that users using -fstandalone-debug may suddenly see a bloat of external var debug info is totally valid. Let me just stick to BPF use case for now. If somebody else ever wants this information with `-fstandalone-debug`, the restriction

[clang-tools-extra] 936de1c - Remove extraneous semicolon.

2019-12-02 Thread Bill Wendling via cfe-commits
Author: Bill Wendling Date: 2019-12-02T14:09:21-08:00 New Revision: 936de1c5bc2dfbec25318985cddb7345d989a7ee URL: https://github.com/llvm/llvm-project/commit/936de1c5bc2dfbec25318985cddb7345d989a7ee DIFF: https://github.com/llvm/llvm-project/commit/936de1c5bc2dfbec25318985cddb7345d989a7ee.diff

[PATCH] D70923: Fix comment to more accurately describe C++ language requirements around tail padding.

2019-12-02 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith created this revision. rsmith added a reviewer: rjmccall. Herald added a project: clang. As of C++ core issue 43 (http://wg21.link/cwg43), which was voted into the C++ working draft in 1999, it is not permissible to memcpy a base class subobject, even if it's of POD type, so there is no

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

2019-12-02 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun marked 3 inline comments as done. xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp:261 + + // TODO: do we want to emit notes for escapes? + // do we want to emit notes for for error checks? I.e. on which

[PATCH] D70701: Fix more VFS tests on Windows

2019-12-02 Thread Adrian McCarthy via Phabricator via cfe-commits
amccarth marked 3 inline comments as done. amccarth added inline comments. Comment at: llvm/lib/Support/VirtualFileSystem.cpp:1077-1078 +std::error_code RedirectingFileSystem::makeAbsolute(SmallVectorImpl ) const { + if (llvm::sys::path::is_absolute(Path,

[PATCH] D70854: [Clang] In tests, do not always assume others permissions are set

2019-12-02 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added inline comments. Comment at: clang/test/Misc/permissions.cpp:8 // RUN: umask 002 // RUN: %clang_cc1 -emit-llvm-bc %s -o %t If you change this to `umask 022`, does that result in `rw-r-`? That would make the test meaningful on your system.

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

2019-12-02 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. Sorry, my previous comment might not be clear. The point is, the same call might both acquire and release handles (there are such calls in Fuchsia), so we might end up adding more than one note for a call for which we would need to add more than one transitions. If

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

2019-12-02 Thread Nicolas Manichon via Phabricator via cfe-commits
nicolas added a comment. Hi, if this patch still LGTY, could you commit it on my behalf? I don't have commit access. Thanks a lot! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ https://reviews.llvm.org/D63276 ___ cfe-commits

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

2019-12-02 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. I was thinking about note tags, but since we iterate on the argument/parameter pairs and might change the state in each iteration we would need to add a new transition after each change. I was wondering if using note tags would worth the cost (both in performance due

[PATCH] D70470: [analyzer] Add FuchsiaHandleCheck to catch handle leaks, use after frees and double frees

2019-12-02 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. > I feel like the 2. is a better solution. Of course, that change might have a > performance impact as well. Yes, i'm all for '2.'. There's no need to make this callback more complicated than it already is. As for performance, it's messy and suffers from a deeper problem:

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

2019-12-02 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl resigned from this revision. aprantl added a comment. @rsmith can you take a look at this to see if this is going into the right direction? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69840/new/ https://reviews.llvm.org/D69840

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

2019-12-02 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. > If we could get this patch merged, we could build and link the whole LLVM > with lld on NetBSD and it would increase the productivity of the bot (better > build times). Right now we need to maintain hacks to link at most with 2/3 > cores, while 5/6 ones are idling

[clang-tools-extra] 93f7761 - Revert "[clangd] repair mac tests for 88bccded8fa1"

2019-12-02 Thread Sam McCall via cfe-commits
Author: Sam McCall Date: 2019-12-02T22:13:29+01:00 New Revision: 93f77617abba512d2861e2fc50ce385883f587b6 URL: https://github.com/llvm/llvm-project/commit/93f77617abba512d2861e2fc50ce385883f587b6 DIFF: https://github.com/llvm/llvm-project/commit/93f77617abba512d2861e2fc50ce385883f587b6.diff

[PATCH] D70701: Fix more VFS tests on Windows

2019-12-02 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added inline comments. Comment at: llvm/lib/Support/VirtualFileSystem.cpp:1077-1078 +std::error_code RedirectingFileSystem::makeAbsolute(SmallVectorImpl ) const { + if (llvm::sys::path::is_absolute(Path, llvm::sys::path::Style::posix) || +

[PATCH] D70863: [clangd] Try harder to find a plausible `clang` as argv0, particularly on Mac.

2019-12-02 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. In D70863#1765668 , @arphaman wrote: > @sammccall Sam, it looks like the tests are failing on the darwin bots: > > http://lab.llvm.org:8080/green/job/clang-stage1-RA/4243/consoleFull Thanks, and sorry! Fingers crossed that

[clang-tools-extra] 82039cb - [clangd] repair mac tests for 88bccded8fa1

2019-12-02 Thread Sam McCall via cfe-commits
Author: Sam McCall Date: 2019-12-02T21:55:54+01:00 New Revision: 82039cbc8d2a0f6fb5995f54e0e4291bcfd0 URL: https://github.com/llvm/llvm-project/commit/82039cbc8d2a0f6fb5995f54e0e4291bcfd0 DIFF: https://github.com/llvm/llvm-project/commit/82039cbc8d2a0f6fb5995f54e0e4291bcfd0.diff

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-02 Thread Kevin P. Neal via Phabricator via cfe-commits
kpn added inline comments. Comment at: llvm/include/llvm/IR/IRBuilder.h:268 I->addAttribute(AttributeList::FunctionIndex, Attribute::StrictFP); -setConstrainedFPFunctionAttr(); } mibintc wrote: > @kpn I got rid of this line because the function

LLVM buildmaster will be updated and restarted tonight

2019-12-02 Thread Galina Kistanova via cfe-commits
Hello everyone, LLVM buildmaster will be updated and restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69223: WDocumentation: Implement the \anchor.

2019-12-02 Thread Mark de Wever via Phabricator via cfe-commits
Mordante updated this revision to Diff 231766. Mordante marked 2 inline comments as done. Mordante added a comment. Addresses review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69223/new/ https://reviews.llvm.org/D69223 Files: clang/bindings/xml/comment-xml-schema.rng

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

2019-12-02 Thread Sid Manning via Phabricator via cfe-commits
sidneym updated this revision to Diff 231765. sidneym added a comment. Update testcase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70919/new/ https://reviews.llvm.org/D70919 Files: clang/lib/Driver/ToolChains/Hexagon.cpp clang/test/Driver/hexagon-toolchain-elf.c Index:

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-02 Thread Melanie Blower via Phabricator via cfe-commits
mibintc marked 9 inline comments as done. mibintc added a comment. I added inline comments describing what I did in this version of the patch to address the bug https://bugs.llvm.org/show_bug.cgi?id=44048 Comment at: clang/include/clang/AST/DeclBase.h:1539 +/// Indicates

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

2019-12-02 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. So... note tags ? Comment at: clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp:261 + + // TODO: do we want to emit notes for escapes? + // do we want to emit notes for for error checks? I.e. on which

[PATCH] D53250: [ToolChain] Use default linker if the toolchain uses a custom one

2019-12-02 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. Sorry about the late response, I was mostly out last week. This recently came up again so I'd like to look into it but I'll have to rethink the change and come up with a better approach. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

2019-12-02 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D70696#1765823 , @SouraVX wrote: > @dblaikie , If you try switching to C compiler. then the DW_TAG_variable is > their. for C++ . It's not generated. Please check godbolt again. -- though > strange Hmm - I don't seem to

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

2019-12-02 Thread Sourabh Singh Tomar via Phabricator via cfe-commits
SouraVX added a comment. In D70696#1765843 , @dblaikie wrote: > In D70696#1765823 , @SouraVX wrote: > > > @dblaikie , If you try switching to C compiler. then the DW_TAG_variable > > is their. for C++ . It's not

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

2019-12-02 Thread Krzysztof Parzyszek via Phabricator via cfe-commits
kparzysz added inline comments. Comment at: clang/test/Driver/hexagon-toolchain-elf.c:560 +// CHECK082-NOT: "-march=hexagon" +// CHECK082-NOT: "-mcpu=hexagon" I don't think there will ever be `"-mcpu=hexagon"` (including the quotation marks). Maybe

[PATCH] D70535: [clangd] Define out-of-line qualify return value

2019-12-02 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:153 + // Get new begin and end positions for the qualified body. + auto OrigFuncRange =

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

2019-12-02 Thread Sourabh Singh Tomar via Phabricator via cfe-commits
SouraVX added a comment. @dblaikie , If you try switching to C compiler. then the DW_TAG_variable is their. for C++ . It's not generated. Please check godbolt again. -- though strange Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70696/new/

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-02 Thread Melanie Blower via Phabricator via cfe-commits
mibintc updated this revision to Diff 231758. mibintc added a comment. This commit was reverted in 30e7ee3c4bac because a null deref error occurred in IRBuilder.h when setting strictfp attribute, see

[PATCH] D70779: AArch64: add support for newer Apple CPUs

2019-12-02 Thread Ahmed Bougacha via Phabricator via cfe-commits
ab added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:587 +"Apple A10", [ +ProcAppleA7, +FeatureCRC, I'm not sure we want to reuse the

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

2019-12-02 Thread Sid Manning via Phabricator via cfe-commits
sidneym created this revision. sidneym added reviewers: kparzysz, bcain, ruiu. Herald added a project: clang. Herald added a subscriber: cfe-commits. sidneym added a subscriber: llvm-commits. Avoid passing unsupported options to lld when -fuse-ld=lld is used. Repository: rG LLVM Github

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

2019-12-02 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D70696#1765789 , @dblaikie wrote: > In D70696#1765784 , @probinson wrote: > > > In D70696#1765671 , @dblaikie > > wrote: > > > > > In

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

2019-12-02 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D70696#1765784 , @probinson wrote: > In D70696#1765671 , @dblaikie wrote: > > > In D70696#1765637 , @probinson > > wrote: > > > > > For the

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

2019-12-02 Thread Paul Robinson via Phabricator via cfe-commits
probinson added a comment. In D70696#1765671 , @dblaikie wrote: > In D70696#1765637 , @probinson wrote: > > > For the case: > > > > cat ref.c > > extern int global_var; > > int main() { return

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

2019-12-02 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D70696#1765675 , @yonghong-song wrote: > @probinson for the question, > > > Does bpf require debug info for the declaration of global_var in noref.c ? > > No, bpf only cares the referenced external global variables. So my

[PATCH] D69223: WDocumentation: Implement the \anchor.

2019-12-02 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 marked an inline comment as done. gribozavr2 added inline comments. Comment at: clang/test/Index/comment-xml-schema.c:38 +// RUN: xmllint --noout --relaxng %S/../../bindings/xml/comment-xml-schema.rng %S/Inputs/CommentXML/valid-inline-command-01.xml // RUN: not

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

2019-12-02 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D70696#1765714 , @yonghong-song wrote: > @dblaikie Good points. I will guard external variable debug info generation > under `-fstandalone-debug` flag. Oh, I figured given your needs this'd be guarded behind the target

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

2019-12-02 Thread Sourabh Singh Tomar via Phabricator via cfe-commits
SouraVX added a comment. In D70696#1765675 , @yonghong-song wrote: > @probinson for the question, > > > Does bpf require debug info for the declaration of global_var in noref.c ? > > No, bpf only cares the referenced external global variables. So my

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

2019-12-02 Thread Paul Robinson via Phabricator via cfe-commits
probinson added a comment. In D70696#1765675 , @yonghong-song wrote: > It is just strange that gcc 7.3.1 (did not test, but maybe later gcc versions > as well) emits the debuginfo (encoded in dwarf) > even if the external variable is not used in the

[PATCH] D70780: [WebAssembly] Find wasm-opt with GetProgramPath

2019-12-02 Thread sunfishcode via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8f1e2151b8e9: [WebAssembly] Find wasm-opt with GetProgramPath (authored by sunfishcode). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70780/new/

[clang] 8f1e215 - [WebAssembly] Find wasm-opt with GetProgramPath

2019-12-02 Thread Dan Gohman via cfe-commits
Author: Dan Gohman Date: 2019-12-02T11:48:36-08:00 New Revision: 8f1e2151b8e923345a18aa3025a7d074e134768b URL: https://github.com/llvm/llvm-project/commit/8f1e2151b8e923345a18aa3025a7d074e134768b DIFF: https://github.com/llvm/llvm-project/commit/8f1e2151b8e923345a18aa3025a7d074e134768b.diff

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

2019-12-02 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song added a comment. @dblaikie Good points. I will guard external variable debug info generation under `-fstandalone-debug` flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70696/new/ https://reviews.llvm.org/D70696

[PATCH] D69223: WDocumentation: Implement the \anchor.

2019-12-02 Thread Mark de Wever via Phabricator via cfe-commits
Mordante marked 6 inline comments as done. Mordante added inline comments. Comment at: clang/lib/Index/CommentToXML.cpp:650 +assert(C->getNumArgs() == 1); +Result << ""; +appendToResultWithXMLEscaping(Arg0); gribozavr2 wrote: > Sholudn't this code be

[clang] 1d45873 - [AArch64] Attempt to fixup test line. NFC

2019-12-02 Thread David Green via cfe-commits
Author: David Green Date: 2019-12-02T19:30:54Z New Revision: 1d4587346f51ca5cc5741337cadfaeb208ca59ad URL: https://github.com/llvm/llvm-project/commit/1d4587346f51ca5cc5741337cadfaeb208ca59ad DIFF: https://github.com/llvm/llvm-project/commit/1d4587346f51ca5cc5741337cadfaeb208ca59ad.diff LOG:

[PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

2019-12-02 Thread Jan Korous via Phabricator via cfe-commits
jkorous added a comment. Hi @arthurp, I can review the libclang part of the patch. Could you please remove the changes that are just code formatting? You can land those as a separate NFC commit. Comment at: clang/tools/libclang/CIndex.cpp:259 + + std::pair Begin =

[PATCH] D70041: register cuda language activation event and activate for .cuh files

2019-12-02 Thread Paul Taylor via Phabricator via cfe-commits
ptaylor updated this revision to Diff 231742. ptaylor added a comment. drop comment about vscode cuda syntax highlighting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70041/new/ https://reviews.llvm.org/D70041 Files:

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

2019-12-02 Thread Sanjay Patel via Phabricator via cfe-commits
spatel added a subscriber: andreadb. spatel added inline comments. Comment at: clang/include/clang/Driver/ToolChain.h:580 + /// This checks for presence of the -Ofast, -ffast-math or -funsafe-math flags. + virtual bool FastMathRuntimeIsAvailable( +const llvm::opt::ArgList

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

2019-12-02 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song added a comment. @probinson for the question, > Does bpf require debug info for the declaration of global_var in noref.c ? No, bpf only cares the referenced external global variables. So my current implementation does not emit debug info for external global_var in noref.c. It is

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

2019-12-02 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D70696#1765637 , @probinson wrote: > For the case: > > cat def.c > int global_var = 2; > > > def.o should have debug info for the definition of global_var. > For the case: > > cat noref.c > extern int

[PATCH] D70863: [clangd] Try harder to find a plausible `clang` as argv0, particularly on Mac.

2019-12-02 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. @sammccall Sam, it looks like the tests are failing on the darwin bots: http://lab.llvm.org:8080/green/job/clang-stage1-RA/4243/consoleFull Value of: CDB.getFallbackCommand(testPath("bar.cc")).CommandLine Expected: has 6 elements where element #0 ends with

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

2019-12-02 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song marked an inline comment as done. yonghong-song added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1140 + for (auto D: ExternalDeclarations) { +if (!D || D->isInvalidDecl() || D->getPreviousDecl() || !D->isUsed()) aprantl wrote: >

[PATCH] D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable

2019-12-02 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Let me try to restate what's happening here so that I can see if I understand it. There are two concepts of "section" in play here: - a unit in an object file with a particular section name, which need not be unique within the object file, and which can have

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

2019-12-02 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2925 +return C.getQualifiedType(T.getTypePtr(), Quals); + } case Type::DeducedTemplateSpecialization: { aprantl wrote: > You need to mark this `LLVM_FALLTHROUGH` now

[clang] f17a1d8 - [OPENMP]Use cast instead dyn_cast, NFC.

2019-12-02 Thread Alexey Bataev via cfe-commits
Author: Alexey Bataev Date: 2019-12-02T14:16:52-05:00 New Revision: f17a1d8b283d227dcbc88caf94acf55abc91c1f9 URL: https://github.com/llvm/llvm-project/commit/f17a1d8b283d227dcbc88caf94acf55abc91c1f9 DIFF: https://github.com/llvm/llvm-project/commit/f17a1d8b283d227dcbc88caf94acf55abc91c1f9.diff

[clang] 478541a - [OPENMP]Fix PR44133: Emit definitions of used constructors/functions.

2019-12-02 Thread Alexey Bataev via cfe-commits
Author: Alexey Bataev Date: 2019-12-02T14:07:29-05:00 New Revision: 478541a6da59fa3eadab98cabdcb0126fad3fdb5 URL: https://github.com/llvm/llvm-project/commit/478541a6da59fa3eadab98cabdcb0126fad3fdb5 DIFF: https://github.com/llvm/llvm-project/commit/478541a6da59fa3eadab98cabdcb0126fad3fdb5.diff

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

2019-12-02 Thread Paul Robinson via Phabricator via cfe-commits
probinson added a comment. For the case: cat def.c int global_var = 2; def.o should have debug info for the definition of global_var. For the case: cat noref.c extern int global_var; int main() {} I would not expect to see debug info for the declaration of global_var.

[clang] 9ec6d71 - [clang][modules] Add support for merging lifetime-extended temporaries

2019-12-02 Thread via cfe-commits
Author: Tyker Date: 2019-12-02T19:55:13+01:00 New Revision: 9ec6d7121132d30db68818e4f684910f76307fdf URL: https://github.com/llvm/llvm-project/commit/9ec6d7121132d30db68818e4f684910f76307fdf DIFF: https://github.com/llvm/llvm-project/commit/9ec6d7121132d30db68818e4f684910f76307fdf.diff LOG:

[PATCH] D70537: [clang] CGDebugInfo asserts `!DT.isNull()` when compiling with debug symbols

2019-12-02 Thread Paul Robinson via Phabricator via cfe-commits
probinson added a comment. I guess first I'm confused about why the type would be undeduced in the first place, given that it is actually instantiated. And if undeduced is correct, wouldn't we rather emit these with DW_TAG_unspecified_type? Comment at:

[PATCH] D70912: [Analyzer] Iterator Modeling: Print Container Data and Iterator Positions when printing the Program State

2019-12-02 Thread Balogh, Ádám via Phabricator via cfe-commits
baloghadamsoftware updated this revision to Diff 231738. baloghadamsoftware added a comment. Wrong diff uploaded. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70912/new/ https://reviews.llvm.org/D70912 Files: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp

[PATCH] D70911: [clangd] Switch Hover.All to structured tests

2019-12-02 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. Build result: FAILURE - Log files: console-log.txt , CMakeCache.txt Repository: rG

[PATCH] D70911: [clangd] Switch Hover.All to structured tests

2019-12-02 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70911 Files:

  1   2   >