[PATCH] D70935: [CodeGen][ObjC] Emit a primitive store to store a __strong field in ExpandTypeFromArgs

ahatanak closed this revision. ahatanak added a comment. Fixed in d8136f14f125fb27f2326f397df0964bf62078ca Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70935/new/

[clang] d8136f1 - [CodeGen][ObjC] Emit a primitive store to store a __strong field in

Author: Akira Hatanaka Date: 2019-12-03T23:44:30-08:00 New Revision: d8136f14f125fb27f2326f397df0964bf62078ca URL: https://github.com/llvm/llvm-project/commit/d8136f14f125fb27f2326f397df0964bf62078ca DIFF:

[PATCH] D70656: [clangd] Define out-of-line qualify function name

This revision was automatically updated to reflect the committed changes. Closed by commit rGddcce0f3d665: [clangd] Define out-of-line qualify function name (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D70656?vs=231513=232042#toc Repository: rG LLVM Github

[PATCH] D70535: [clangd] Define out-of-line qualify return value

This revision was automatically updated to reflect the committed changes. Closed by commit rGe4609ec0e8cf: [clangd] Define out-of-line qualify return value (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70535/new/

[PATCH] D69298: [clangd] Define out-of-line initial apply logic

This revision was automatically updated to reflect the committed changes. Closed by commit rGce2189202245: [clangd] Define out-of-line initial apply logic (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69298/new/

[PATCH] D69266: [clangd] Define out-of-line availability checks

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f251eece466: [clangd] Define out-of-line availability checks (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69266/new/

[PATCH] D70157: Align branches within 32-Byte boundary

annita.zhang added a comment. In D70157#1768319 , @chandlerc wrote: > I'm seeing lots of updates to fix bugs, but no movement for many days on both > my meta comments and (in some ways more importantly) James's meta comments. > (And thanks Philip for

[PATCH] D70535: [clangd] Define out-of-line qualify return value

merge_guards_bot added a comment. Build result: pass - 60447 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[clang-tools-extra] ce21892 - [clangd] Define out-of-line initial apply logic

Author: Kadir Cetinkaya Date: 2019-12-04T08:21:09+01:00 New Revision: ce2189202245953cbbfff100e6e5e9c1acb664ad URL: https://github.com/llvm/llvm-project/commit/ce2189202245953cbbfff100e6e5e9c1acb664ad DIFF:

[clang-tools-extra] 9f251ee - [clangd] Define out-of-line availability checks

Author: Kadir Cetinkaya Date: 2019-12-04T08:21:09+01:00 New Revision: 9f251eece46675ba0095baddebe90512abde6337 URL: https://github.com/llvm/llvm-project/commit/9f251eece46675ba0095baddebe90512abde6337 DIFF:

[PATCH] D70857: [llvm][Support] Take in CurrentDirectory as a parameter in ExpandResponseFiles

kadircet added inline comments. Comment at: llvm/lib/Support/CommandLine.cpp:1183 ExpandResponseFile(FName, Saver, Tokenizer, ExpandedArgv, MarkEOLs, - RelativeNames, FS)) { + RelativeNames, FS,

[PATCH] D70535: [clangd] Define out-of-line qualify return value

kadircet updated this revision to Diff 232036. kadircet added a comment. - Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70535/new/ https://reviews.llvm.org/D70535 Files: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp

[PATCH] D70157: Align branches within 32-Byte boundary

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/MCTargetDesc/X86BaseInfo.h:158 +case X86::AND16i16: +case X86::AND16mr: +case X86::AND16ri: None of the AND/ADD/SUB instructions ending in mr are eligible for macrofusion as far as

[PATCH] D70157: Align branches within 32-Byte boundary

chandlerc added a comment. I'm seeing lots of updates to fix bugs, but no movement for many days on both my meta comments and (in some ways more importantly) James's meta comments. (And thanks Philip for chiming in too!) Meanwhile, we really, really need to get this functionality in place. The

[PATCH] D70935: [CodeGen][ObjC] Emit a primitive store to store a __strong field in ExpandTypeFromArgs

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Yes, that's great, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70935/new/ https://reviews.llvm.org/D70935

[PATCH] D70973: [OPENMP50]Treat context selectors as expressions, not just strings.

jdoerfert added a comment. Thx for this patch. Only two minor comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1230 - "unknown '%0' device kind trait in the 'device' context selector set, expected" - " one of 'host', 'nohost', 'cpu', 'gpu' or

[PATCH] D70935: [CodeGen][ObjC] Emit a primitive store to store a __strong field in ExpandTypeFromArgs

ahatanak added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1054 + "pointer to __strong expected"); + EmitStoreOfScalar(*AI++, LV); +} else rjmccall wrote: > This definitely deserves a comment. > > I don't think the assertion

[PATCH] D70439: [Analyzer][Docs][NFC] Add CodeChecker to the command line tools

NoQ added a comment. Hey, thanks for waiting on me! I'm slow these days, just 50 more mails to go >.< This review strikes me as a wiki material. I wonder what's the community stance on making wikis. #showerthoughs Comment at: clang/www/analyzer/codechecker.html:13 + + +

[PATCH] D70935: [CodeGen][ObjC] Emit a primitive store to store a __strong field in ExpandTypeFromArgs

ahatanak updated this revision to Diff 232027. ahatanak marked 2 inline comments as done. ahatanak added a comment. Call `EmitStoreThroughLValue` and `EmitLoadOfLValue` only when the lvalue is a bitfield. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69876: Allow output constraints on "asm goto"

void marked an inline comment as done. void added inline comments. Comment at: clang/test/Analysis/uninit-asm-goto.cpp:10 +return -1; +} rnk wrote: > This could use a test for the case where an input is uninitialized, and where > an uninitialized value is

[PATCH] D70575: [Clang] Define Fuchsia C++ABI

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c3f9b9c12b0: [Clang] Define Fuchsia C++ABI (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D70575?vs=230827=232023#toc Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 9c3f9b9 - [Clang] Define Fuchsia C++ABI

Author: Petr Hosek Date: 2019-12-03T18:35:57-08:00 New Revision: 9c3f9b9c12b0f79b74d1d349bbac46cadaca7dbf URL: https://github.com/llvm/llvm-project/commit/9c3f9b9c12b0f79b74d1d349bbac46cadaca7dbf DIFF: https://github.com/llvm/llvm-project/commit/9c3f9b9c12b0f79b74d1d349bbac46cadaca7dbf.diff

[PATCH] D70958: [compiler-rt] [test] Disable ASLR on ASAN/MSAN/TSAN tests on NetBSD

krytarowski added a comment. In D70958#1767912 , @eugenis wrote: > Could this go into the common lit config in compiler-rt/test? Do you mean to run this for all tests in compiler-rt? We intend to disable it only when needed and prevent leaking

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

0x8000- added a comment. In D45444#1766852 , @JonasToth wrote: > > Thank you for testing, I would appreciate if you test later versions, too! > I will focus on landing the utility function for adding `const` first. I > noticed false positives in

[clang] 59312cb - Fix warning on unused variable. NFC.

Author: Michael Liao Date: 2019-12-03T21:16:10-05:00 New Revision: 59312cb0b81ca13f0674dde66b8e87a8d51d4dda URL: https://github.com/llvm/llvm-project/commit/59312cb0b81ca13f0674dde66b8e87a8d51d4dda DIFF: https://github.com/llvm/llvm-project/commit/59312cb0b81ca13f0674dde66b8e87a8d51d4dda.diff

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

yonghong-song added a comment. In D70696#1767616 , @dblaikie wrote: > Many of the test cases could be collapsed into one file - using different > variables that are used, unused, locally or globally declared, etc. Okay. Will try to consolidate into one

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

nathanchance added a comment. As an FYI, this appears to cause several false positive warnings with the Linux kernel: ../drivers/video/fbdev/core/fbmem.c:665:3: warning: misleading indentation; statement is not part of the previous 'else' [-Wmisleading-indentation] if

[PATCH] D69876: Allow output constraints on "asm goto"

rnk added a subscriber: rsmith. rnk added a comment. Changes seem fine to me, FWIW. +@rsmith Comment at: clang/test/Analysis/uninit-asm-goto.cpp:10 +return -1; +} This could use a test for the case where an input is uninitialized, and where an

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

apazos added a comment. Lewis, try rebasing it, not applying cleanly nor https://reviews.llvm.org/D62190 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62686/new/ https://reviews.llvm.org/D62686 ___

[clang] b0df904 - [Diagnostic][test] Remove an unneeded change to pragma_diagnostic_sections.cpp after D70638

Author: Fangrui Song Date: 2019-12-03T16:43:35-08:00 New Revision: b0df90488ce9c703d1bbc3d02c4b29e85d0f706b URL: https://github.com/llvm/llvm-project/commit/b0df90488ce9c703d1bbc3d02c4b29e85d0f706b DIFF: https://github.com/llvm/llvm-project/commit/b0df90488ce9c703d1bbc3d02c4b29e85d0f706b.diff

[PATCH] D70568: [Support] Possibly use exception handler in the Crash Recovery Context in the same way as global exceptions

dexonsmith added a comment. In D70568#1768129 , @dexonsmith wrote: > Can we make this configurable somehow? (E.g., leave behind an `-ffork-cc1` > `-fno-fork-cc1` and a CMake flag to pick? Or just the CMake flag?) (I'm not sure we'd want to expose

[PATCH] D70568: [Support] Possibly use exception handler in the Crash Recovery Context in the same way as global exceptions

dexonsmith added a comment. This is really cool; we've wanted this for a long time. One concern I have is that I think this will interfere (effectively disable) automatic OS handling of these crashes, which means they won't be collated and reported anymore. Can we make this configurable

[PATCH] D70746: [clangd] Highlighting dependent types in more contexts

nridge updated this revision to Diff 232012. nridge added a comment. Address nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70746/new/ https://reviews.llvm.org/D70746 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp

[PATCH] D70740: [clangd] Find reference to template parameter in 'sizeof...' expression

nridge updated this revision to Diff 232011. nridge added a comment. Add FindExplicitReferences test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70740/new/ https://reviews.llvm.org/D70740 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

arphaman added a comment. @aganea Please disable the new behavior for the Darwin platform. We rely on the fact that Clang `-cc1` processes crash to report crashes using system's crash reporting infrastructure. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69825/new/

[clang] 3278948 - Fix `sed -e s@FOO@%/S@` and similar when there's @'s in the working directory

Author: Daniel Sanders Date: 2019-12-03T15:44:01-08:00 New Revision: 327894859cc41c1730807f8a179aa880203262f5 URL: https://github.com/llvm/llvm-project/commit/327894859cc41c1730807f8a179aa880203262f5 DIFF:

[clang] 878a24e - Reapply "Fix crash on switch conditions of non-integer types in templates"

Author: Elizabeth Andrews Date: 2019-12-03T15:27:19-08:00 New Revision: 878a24ee244a24c39d1c57e9af2e88c621f7cce9 URL: https://github.com/llvm/llvm-project/commit/878a24ee244a24c39d1c57e9af2e88c621f7cce9 DIFF:

[PATCH] D70854: [Clang] In tests, do not always assume others permissions are set

aganea marked 3 inline comments as done. aganea added inline comments. Comment at: clang/test/Misc/permissions.cpp:8 // RUN: umask 002 // RUN: %clang_cc1 -emit-llvm-bc %s -o %t rnk wrote: > aganea wrote: > > rnk wrote: > > > If you change this to `umask

[PATCH] D70905: Actually delay processing DelayedDllExportClasses until the outermost class is finished (PR40006)

rnk added a comment. It occurs to me that this will cause some strange ordering in some cases. Consider: namespace pr40006 { // Delay emitting the method also past the instantiation of Tmpl, i.e. // until the top-level class Outer is completely finished. template struct Tmpl {};

[PATCH] D70905: Actually delay processing DelayedDllExportClasses until the outermost class is finished (PR40006)

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. I'll add, looks good with suggested fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70905/new/ https://reviews.llvm.org/D70905 ___

[PATCH] D70854: [Clang] In tests, do not always assume others permissions are set

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/test/Misc/permissions.cpp:8 // RUN: umask 002 // RUN: %clang_cc1 -emit-llvm-bc %s -o %t aganea wrote: > rnk wrote: > > If you change

[PATCH] D70931: [MS] Emit exported complete/vbase destructors

This revision was automatically updated to reflect the committed changes. Closed by commit rG705a6aef3502: [MS] Emit exported complete/vbase destructors (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D70931?vs=231796=231998#toc Repository: rG LLVM Github Monorepo

[PATCH] D70854: [Clang] In tests, do not always assume others permissions are set

aganea marked 3 inline comments as done. aganea added inline comments. Comment at: clang/test/Misc/permissions.cpp:8 // RUN: umask 002 // RUN: %clang_cc1 -emit-llvm-bc %s -o %t rnk wrote: > If you change this to `umask 022`, does that result in `rw-r-`?

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp:307 + std::vector> notes; SymbolRef ResultSymbol = nullptr; I will capitalize this name. CHANGES SINCE

[clang] 705a6ae - [MS] Emit exported complete/vbase destructors

Author: Reid Kleckner Date: 2019-12-03T14:46:32-08:00 New Revision: 705a6aef350246c790ff8e73864dd27a640c59c8 URL: https://github.com/llvm/llvm-project/commit/705a6aef350246c790ff8e73864dd27a640c59c8 DIFF: https://github.com/llvm/llvm-project/commit/705a6aef350246c790ff8e73864dd27a640c59c8.diff

[PATCH] D70931: [MS] Emit exported complete/vbase destructors

rnk marked an inline comment as done. rnk added inline comments. Comment at: clang/lib/CodeGen/MicrosoftCXXABI.cpp:1349 + // the base dtor is emitted. + // FIXME: To match MSVC, this should only be done when the class was + // dllexported inlines are being exported.

[PATCH] D69855: [clang-tidy] Fix llvm-namespace-comment for macro expansions

gribozavr2 added a comment. @twardakm: I'm not convinced this feature is worth implementing at all, because there's a good alternative to a macro here -- a namespace alias. What is the reason to use a macro instead of a namespace alias? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

xazax.hun updated this revision to Diff 231996. xazax.hun added a comment. - Only add note tag if we have actual notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70725/new/ https://reviews.llvm.org/D70725 Files: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

xazax.hun added a comment. In D70725#1767942 , @NoQ wrote: > Mmm, right, i guess you should also skip adding the tag if the notes array is > empty. > > There might be more complicated use-cases (especially in `ExprEngine` itself) > where you may end up

[PATCH] D70157: Align branches within 32-Byte boundary

fedor.sergeev requested changes to this revision. fedor.sergeev added a comment. This revision now requires changes to proceed. In D70157#1767212 , @fedor.sergeev wrote: > Working on getting upstream reproducer Hangs on a moderately small piece

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

NoQ added a comment. Mmm, right, i guess you should also skip adding the tag if the notes array is empty. There might be more complicated use-cases (especially in `ExprEngine` itself) where you may end up adding a tag even if the state doesn't change. For instance, when changing an

[PATCH] D70987: [HIP] Improve opt-level handling

scott.linder created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The HIP toolchain invokes `llc` without an explicit opt-level, meaning it always uses the default (-O2). This makes it impossible to use -O1, for example. The HIP toolchain also coerces

[PATCH] D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable

rjmccall added a comment. In D68101#1767732 , @nickdesaulniers wrote: > > But ELF allows object files to contain an arbitrary number of what I've > > been calling "section units" that will be assembled into a single section > > in the image. > > More

[PATCH] D67463: [MS] Warn when shadowing template parameters under -fms-compatibility

rnk added a comment. @hans, are we still accepting 9.0.1 patches? I thought we'd already made a release candidate. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67463/new/ https://reviews.llvm.org/D67463 ___

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

xazax.hun added a comment. In D70725#1767673 , @NoQ wrote: > In D70725#1767643 , @Charusso wrote: > > > In D70725#1767579 , @xazax.hun > > wrote: > > > > > Just a small

[PATCH] D70958: [compiler-rt] [test] Disable ASLR on ASAN/MSAN/TSAN tests on NetBSD

eugenis added a comment. Could this go into the common lit config in compiler-rt/test? What is the problem with ASLR in NetBSD? Is this about fixed shadow location conflicts with the binary & library mappings? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70958/new/

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

xazax.hun updated this revision to Diff 231989. xazax.hun marked 5 inline comments as done. xazax.hun added a comment. - Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70725/new/ https://reviews.llvm.org/D70725 Files:

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp:363-366 +if (() != && +() != && +() != ) + return ""; NoQ wrote: > Ugh, it sucks that we have to do this by hand. > > Why would

[PATCH] D70791: Workaround for MSVC 16.3.* pre-c++17 type trait linkage

erichkeane abandoned this revision. erichkeane added a comment. Microsoft recently released 16.4 and has ceased support for the 16.3 line, so it isn't really important to me anymore. I'd thought this was a 'hold our nose and do it' type fix, but I don't think that is justified any longer now

[libunwind] b3fdf33 - Enable `-funwind-tables` flag when building libunwind

Author: Sergej Jaskiewicz Date: 2019-12-04T00:52:19+03:00 New Revision: b3fdf33ba6aa7ef80621696f74aaf2f6f8e1d1de URL: https://github.com/llvm/llvm-project/commit/b3fdf33ba6aa7ef80621696f74aaf2f6f8e1d1de DIFF:

[PATCH] D70980: [HIP] Remove opencl.amdgcn.lib

ashi1 accepted this revision. ashi1 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70980/new/ https://reviews.llvm.org/D70980 ___ cfe-commits mailing list

[PATCH] D70726: [OpenMP50] Add parallel master construct

ABataev added inline comments. Comment at: clang/test/OpenMP/parallel_master_codegen.cpp:1 +// expected-no-diagnostics +#ifndef HEADER A codegen test for `if`, `proc_bind` and `allocate` clauses? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70489: [clangd] Add xref for macro to static index.

hokein added a comment. thanks, mostly good, my main concern is that the patch still relies on the `CollectMacro` and `CollectMainFileSymbols ` option, see my comments below. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:349

[PATCH] D70980: [HIP] Remove opencl.amdgcn.lib

yaxunl updated this revision to Diff 231978. yaxunl added a comment. fix test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70980/new/ https://reviews.llvm.org/D70980 Files: clang/lib/Driver/ToolChains/HIP.cpp clang/test/Driver/hip-device-libs.hip Index:

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

aprantl added a comment. @shafik Can you speak about whether this feature ("auto" return type in DWARF v5 section 5.2) would be useful for LLDB? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70524/new/ https://reviews.llvm.org/D70524 ___

[PATCH] D70974: [clang-tidy] Fix PR26274

aaron.ballman added a comment. Thank you for working on this! Comment at: clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp:55 - if (!locationsInSameFile(Sources, ND->getBeginLoc(), ND->getRBraceLoc())) + // Ignore namespaces inside macros and namespaces

[PATCH] D70981: [opencl] Fix address space deduction on array variables.

hliao created this revision. hliao added a reviewer: Anastasia. Herald added subscribers: cfe-commits, yaxunl. Herald added a project: clang. - The deduced address space needs applying to its element type as well. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70981 Files:

[PATCH] D70579: [coroutines][PR41909] Generalize fix from D62550

modocache added a comment. @GorNishanov, @rsmith, friendly ping! @rsmith this patch addresses your requests from https://reviews.llvm.org/D62550. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70579/new/ https://reviews.llvm.org/D70579

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 updated this revision to Diff 231971. ghvg1313 marked an inline comment as done. ghvg1313 added a comment. - rename option, remove handlers for nested block itself Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70926/new/

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 marked an inline comment as done. ghvg1313 added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:869 State.Stack[i].BreakBeforeParameter = true; if (PreviousNonComment && MyDeveloperDay wrote: > I'm a little confused

Re: [PATCH] D70512: [clangd] Rethink how SelectionTree deals with macros and #includes.

Right, should be fixed in 1374f7bd9f07115a7c69908bf50ba22e77b0e149 (Just like the last revert, libstdc++ is letting me get away with things that the others don't...) On Tue, Dec 3, 2019 at 9:53 PM Nico Weber via Phabricator < revi...@reviews.llvm.org> wrote: > thakis added a comment. > > Mac is

[clang-tools-extra] 1374f7b - [clangd] Fix comparator const after c9c714c7054d555398c767cb39d7d97600b3d9d1

Author: Sam McCall Date: 2019-12-03T22:13:45+01:00 New Revision: 1374f7bd9f07115a7c69908bf50ba22e77b0e149 URL: https://github.com/llvm/llvm-project/commit/1374f7bd9f07115a7c69908bf50ba22e77b0e149 DIFF: https://github.com/llvm/llvm-project/commit/1374f7bd9f07115a7c69908bf50ba22e77b0e149.diff

[PATCH] D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable

nickdesaulniers added a comment. > But ELF allows object files to contain an arbitrary number of what I've been > calling "section units" that will be assembled into a single section in the > image. More precisely, in assembler, you can specify sections dis-jointly, but they will be rejoined

[PATCH] D70980: [HIP] Remove opencl.amdgcn.lib

yaxunl created this revision. yaxunl added reviewers: ashi1, b-sumner. Herald added a subscriber: Anastasia. https://reviews.llvm.org/D70980 Files: clang/lib/Driver/ToolChains/HIP.cpp Index: clang/lib/Driver/ToolChains/HIP.cpp

[clang] 59e69fe - Fix warning on extra ';'. NFC.

Author: Michael Liao Date: 2019-12-03T16:02:55-05:00 New Revision: 59e69fefab883984e81c77aef58ba587060e87f2 URL: https://github.com/llvm/llvm-project/commit/59e69fefab883984e81c77aef58ba587060e87f2 DIFF: https://github.com/llvm/llvm-project/commit/59e69fefab883984e81c77aef58ba587060e87f2.diff

[PATCH] D70701: Fix more VFS tests on Windows

amccarth marked 2 inline comments as done. amccarth added a comment. A (hopefully) more cogent response than my last round. I'm still hoping to hear from VFS owners. Comment at: llvm/lib/Support/VirtualFileSystem.cpp:1077-1078 +std::error_code

[PATCH] D68578: [HIP] Fix device stub name

yaxunl updated this revision to Diff 231966. yaxunl added a comment. Herald added subscribers: nhaehnle, jvesely. clean up and fix assertions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68578/new/ https://reviews.llvm.org/D68578 Files: clang/include/clang/Basic/Specifiers.h

[PATCH] D70512: [clangd] Rethink how SelectionTree deals with macros and #includes.

thakis added a comment. Mac is happy now, but it fails to build on Windows: http://45.33.8.238/win/3327/step_4.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70512/new/ https://reviews.llvm.org/D70512

[PATCH] D70571: [Coverage] Emit a gap region to cover switch bodies

This revision was automatically updated to reflect the committed changes. Closed by commit rG859bf4d2bea2: [Coverage] Emit a gap region to cover switch bodies (authored by vsk). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D70571?vs=231724=231964#toc

Re: Github build status reporting

Hi Galina, Thanks for doing this! I'm curious as to how the buildbot CI communicates with Github, is the buildbot itself capable of performing the Github API requests, or do you have an external tool/script that does that? Thanks, Alex On Mon, 25 Nov 2019 at 12:59, Galina Kistanova via

[clang] 859bf4d - [Coverage] Emit a gap region to cover switch bodies

Author: Vedant Kumar Date: 2019-12-03T12:35:54-08:00 New Revision: 859bf4d2bea2404bd2eac92451f2db4371ec6eb4 URL: https://github.com/llvm/llvm-project/commit/859bf4d2bea2404bd2eac92451f2db4371ec6eb4 DIFF: https://github.com/llvm/llvm-project/commit/859bf4d2bea2404bd2eac92451f2db4371ec6eb4.diff

[PATCH] D70726: [OpenMP50] Add parallel master construct

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/test/OpenMP/nesting_of_regions.cpp:3024 + { +#pragma omp master // OK, though second 'master' is redundant +{ ABataev wrote: > Is this allowed by the standard? I didn't

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

NoQ added a comment. Yay, it actually works! I only have minor comments and ignorable hand-waving now. In D70725#1767643 , @Charusso wrote: > In D70725#1767579 , @xazax.hun wrote: > > > Just a small side note. If

[clang] bf830b0 - Switch to opening the temp file in binary mode

Author: Aaron Ballman Date: 2019-12-03T15:31:46-05:00 New Revision: bf830b01a21e6ff2f44c17be4ad4ee897465a677 URL: https://github.com/llvm/llvm-project/commit/bf830b01a21e6ff2f44c17be4ad4ee897465a677 DIFF: https://github.com/llvm/llvm-project/commit/bf830b01a21e6ff2f44c17be4ad4ee897465a677.diff

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc840b21e161: [Diagnostic] add a warning which warns about misleading indentation (authored by Tyker). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70861: [NFCI] update formating for misleading indentation warning

This revision was automatically updated to reflect the committed changes. Closed by commit rG2f9604727526: [NFCI] update formating for misleading indentation warning (authored by Tyker). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D70726: [OpenMP50] Add parallel master construct

cchen marked 2 inline comments as done. cchen added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2933 +OMPPrivateScope PrivateScope(CGF); +bool Copyins = CGF.EmitOMPCopyinClause(S); +(void)CGF.EmitOMPFirstprivateClause(S, PrivateScope);

[clang] 2f96047 - [NFCI] update formating for misleading indentation warning

Author: Tyker Date: 2019-12-03T21:21:27+01:00 New Revision: 2f9604727526dedcd20b776ace4adfc058641ab2 URL: https://github.com/llvm/llvm-project/commit/2f9604727526dedcd20b776ace4adfc058641ab2 DIFF: https://github.com/llvm/llvm-project/commit/2f9604727526dedcd20b776ace4adfc058641ab2.diff LOG:

[clang] bc840b2 - [Diagnostic] add a warning which warns about misleading indentation

Author: Tyker Date: 2019-12-03T21:21:27+01:00 New Revision: bc840b21e1612adb603b6c17be0329e3737bb943 URL: https://github.com/llvm/llvm-project/commit/bc840b21e1612adb603b6c17be0329e3737bb943 DIFF: https://github.com/llvm/llvm-project/commit/bc840b21e1612adb603b6c17be0329e3737bb943.diff LOG:

[PATCH] D70571: [Coverage] Emit a gap region to cover switch bodies

vsk marked an inline comment as done. vsk added inline comments. Comment at: clang/docs/SourceBasedCodeCoverage.rst:330 +last case ends). This gap region has a zero count: this causes "gap" areas in +between case statements, which contain no executable code, to appear uncovered.

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

Charusso added a comment. In D70725#1767579 , @xazax.hun wrote: > Just a small side note. If the state was same as the previous we do not end > up creating a new ExplodedNode right? Is this also the case when we add a > NoteTag? It only happens for

[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames added a comment. Ping. Still looking for someone to take a look. Happy to answer any questions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68997/new/ https://reviews.llvm.org/D68997 ___

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added a comment. @rnk up? the mozilla folks confirmed there's no significant regression (see https://bugzilla.mozilla.org/show_bug.cgi?id=1588710#c12). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

dblaikie added a comment. Many of the test cases could be collapsed into one file - using different variables that are used, unused, locally or globally declared, etc. Is this new code only active for C compilations? (does clang reject requests for the bpf target when the input is C++?) I ask

[PATCH] D70974: [clang-tidy] Fix PR26274

merge_guards_bot added a comment. Build result: pass - 60438 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

dblaikie added a comment. In D70524#1761514 , @awpandey wrote: > Hi @aprantl and @dblaikie. Currently, there is no test case for the > unspecified type, so I have added that in the regression test suite. It looks to me like there are a few tests for

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

xazax.hun added a comment. You were right, the new API looks cleaner even in this case :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70725/new/ https://reviews.llvm.org/D70725 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp:362 } - C.addTransition(State); + const NoteTag *T = C.getNoteTag([this, notes](BugReport ) -> std::string { +if (() !=

[PATCH] D70973: [OPENMP50]Treat context selectors as expressions, not just strings.

merge_guards_bot added a comment. Build result: pass - 60439 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

xazax.hun added a comment. Just a small side note. If the state was same as the previous we do not end up creating a new ExplodedNode right? Is this also the case when we add a NoteTag? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70725/new/ https://reviews.llvm.org/D70725

  1   2   >