[PATCH] D70537: [clang] CGDebugInfo asserts `!DT.isNull()` when compiling with debug symbols

kamleshbhalui updated this revision to Diff 233919. kamleshbhalui added a comment. added validation check in testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70537/new/ https://reviews.llvm.org/D70537 Files:

[PATCH] D69893: libunwind: Evaluating DWARF operation DW_OP_pick is broken

kamleshbhalui added a comment. ping? can someone commit this for me? Repository: rUNW libunwind CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69893/new/ https://reviews.llvm.org/D69893 ___ cfe-commits mailing list

[PATCH] D71491: [ubsan] Check implicit casts in ObjC for-in statements

delcypher added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:953 + SanitizerKind::ImplicitConversion | SanitizerKind::Nullability | + SanitizerKind::LocalBounds | SanitizerKind::ObjCCast; if (getTriple().getArch() == llvm::Triple::x86 ||

[clang] d14a569 - MSVC build fix: forget some unneeded and incorrect friends.

Author: John McCall Date: 2019-12-14T01:02:09-05:00 New Revision: d14a5693c07f0fb1b82c75ed72f77a495751dcf7 URL: https://github.com/llvm/llvm-project/commit/d14a5693c07f0fb1b82c75ed72f77a495751dcf7 DIFF: https://github.com/llvm/llvm-project/commit/d14a5693c07f0fb1b82c75ed72f77a495751dcf7.diff

[PATCH] D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO

tejohnson added a comment. In D69732#1784511 , @wristow wrote: > >> Given the performance improvements here, I'd like to develop this patch > >> further. > > > > In D69732#1784290 , @ormris wrote: > > //Ping//

[PATCH] D71508: [DebugInfo] Duplicate file names in debug info

kamleshbhalui created this revision. kamleshbhalui added reviewers: probinson, dblaikie, vsk, labath. kamleshbhalui added a project: debug-info. Herald added subscribers: cfe-commits, aprantl. Herald added a project: clang. strip/remove the dot slash before creating files for debug info. This

[PATCH] D71491: [ubsan] Check implicit casts in ObjC for-in statements

delcypher added inline comments. Comment at: compiler-rt/lib/ubsan/ubsan_value.cpp:29 +const char *__ubsan::getObjCClassName(ValueHandle Pointer) { +#if defined(__APPLE__) + // We need to query the ObjC runtime for some information, but do not want The

[clang] a7950ff - [NFC] Correct accidental use of tabs.

Author: John McCall Date: 2019-12-14T00:16:47-05:00 New Revision: a7950ffd12caa2fb7ed4704128011bceeacd35e9 URL: https://github.com/llvm/llvm-project/commit/a7950ffd12caa2fb7ed4704128011bceeacd35e9 DIFF: https://github.com/llvm/llvm-project/commit/a7950ffd12caa2fb7ed4704128011bceeacd35e9.diff

[clang] b6f03a5 - [NFC] Rename ClangASTEmitters.h -> ASTTableGen.h

Author: John McCall Date: 2019-12-14T00:16:47-05:00 New Revision: b6f03a5a6b57b7858098051e60c2ce2fd4058461 URL: https://github.com/llvm/llvm-project/commit/b6f03a5a6b57b7858098051e60c2ce2fd4058461 DIFF: https://github.com/llvm/llvm-project/commit/b6f03a5a6b57b7858098051e60c2ce2fd4058461.diff

[PATCH] D71507: [perf-training] Make training data location configurable

smeenai added a comment. I'm not sure where best to document this. We have https://llvm.org/docs/HowToBuildWithPGO.html, but that doesn't mention the build system's built-in PGO support as far as I can tell. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71507: [perf-training] Make training data location configurable

smeenai created this revision. smeenai added reviewers: beanz, compnerd, phosek, xiaobai. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. We may wish to keep the PGO training data outside the repository. Add a CMake variable to allow referencing an external lit

[PATCH] D71428: [clang] Move CLANG_BOOTSTRAP_CMAKE_ARGS above PASSTHROUGH_VARIABLES

This revision was automatically updated to reflect the committed changes. Closed by commit rG61c8ee6a2fa4: [clang] Move CLANG_BOOTSTRAP_CMAKE_ARGS above PASSTHROUGH_VARIABLES (authored by xinxinw1, committed by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 61c8ee6 - [clang] Move CLANG_BOOTSTRAP_CMAKE_ARGS above PASSTHROUGH_VARIABLES

Author: Xin-Xin Wang Date: 2019-12-13T19:05:04-08:00 New Revision: 61c8ee6a2fa490bc224d006cd03efd650f6561bb URL: https://github.com/llvm/llvm-project/commit/61c8ee6a2fa490bc224d006cd03efd650f6561bb DIFF: https://github.com/llvm/llvm-project/commit/61c8ee6a2fa490bc224d006cd03efd650f6561bb.diff

[PATCH] D71503: New warning on for-loops that never run because condition is false on the first iteration

rtrieu created this revision. This is a proposed warning to be added to -Wfor-loop-analysis, which is part of -Wall. This warning will catch instances where the condition will be false on the first iteration and the loop body will never be run. The warning will be emitted when: 1. The

[PATCH] D71155: [analyzer] CERT: STR30-C

Charusso marked 3 inline comments as done. Charusso added a comment. In order to bypass the `CK_LValueToRValue` `evalCast()` we have to create en `ElementRegion` as a return-value of the problematic function call. In that case for a mythical reason we miss the fact the pointer is nullable. I

[PATCH] D71033: [analyzer] CERT: STR32-C

Charusso added a comment. We need to add the interestingness to the `NoteTags` so that we only emit notes on initialization/function calls which leads to an error. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71033/new/ https://reviews.llvm.org/D71033

[PATCH] D71167: [Driver] Default to -momit-leaf-frame-pointer for AArch64

This revision was automatically updated to reflect the committed changes. Closed by commit rG074323c84658: [Driver] Default to -momit-leaf-frame-pointer for AArch64 (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D71167?vs=232714=233906#toc Repository: rG LLVM

[PATCH] D71155: [analyzer] CERT: StrChecker: 30.c

Charusso updated this revision to Diff 233905. Charusso marked 6 inline comments as done. Charusso added a comment. - Try to conjure the index of the 'ElementRegion'. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71155/new/ https://reviews.llvm.org/D71155 Files:

[PATCH] D71033: [analyzer] CERT: STR32-C

Charusso marked an inline comment as done. Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/StrChecker.cpp:479 +if (VD->getType()->getAsArrayTypeUnsafe()) { + VD->dumpColor(); + ProgramStateRef State = C.getState();

[clang] 074323c - [Driver] Default to -momit-leaf-frame-pointer for AArch64

Author: Fangrui Song Date: 2019-12-13T18:48:34-08:00 New Revision: 074323c84658e51522e7d8d3d0179e53004b219c URL: https://github.com/llvm/llvm-project/commit/074323c84658e51522e7d8d3d0179e53004b219c DIFF: https://github.com/llvm/llvm-project/commit/074323c84658e51522e7d8d3d0179e53004b219c.diff

[PATCH] D71033: [analyzer] CERT: STR32-C

Charusso updated this revision to Diff 233904. Charusso retitled this revision from "[analyzer] CERT: StrChecker: 32.c" to "[analyzer] CERT: STR32-C". Charusso added a comment. - Add notes to the initialization of char-arrays. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71033/new/

[PATCH] D70411: [analyzer] CERT: STR31-C

Charusso updated this revision to Diff 233903. Charusso retitled this revision from "[analyzer] CERT: StrChecker: Implementing most of the STR31-C" to "[analyzer] CERT: STR31-C". Charusso added a comment. - Iterate over parameters rather arguments for searching string-reading. - Better notes of

[clang] 38c3b5d - [c++20] Improve phrasing of diagnostic for missing #include .

Author: Richard Smith Date: 2019-12-13T18:41:54-08:00 New Revision: 38c3b5d562ac6a5ab0ef5503838aad362af866e0 URL: https://github.com/llvm/llvm-project/commit/38c3b5d562ac6a5ab0ef5503838aad362af866e0 DIFF: https://github.com/llvm/llvm-project/commit/38c3b5d562ac6a5ab0ef5503838aad362af866e0.diff

[clang] c5b890e - PR44268: Fix crash if __builtin_object_size is applied to a heap

Author: Richard Smith Date: 2019-12-13T18:41:54-08:00 New Revision: c5b890e922432bd80a5e3c6d82994ef4cdc41900 URL: https://github.com/llvm/llvm-project/commit/c5b890e922432bd80a5e3c6d82994ef4cdc41900 DIFF: https://github.com/llvm/llvm-project/commit/c5b890e922432bd80a5e3c6d82994ef4cdc41900.diff

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

craig.topper added a comment. In D62731#1784491 , @pengfei wrote: > >> It's good that people are looking at achieving better modeling for the x86 > >> backend, but we need to have a plan that doesn't require heroic effort > >> just to get basic

[PATCH] D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO

wristow added a comment. >> Given the performance improvements here, I'd like to develop this patch >> further. > > In D69732#1784290 , @ormris wrote: > //Ping// @tejohnson @ormris, I think that since @tejohnson originally suggested that someone with

[PATCH] D66049: [analyzer] PR41729: Fix some false positives and improve strlcat and strlcpy modeling

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:1710-1711 + // strlcat returns strlen(src) + strlen(dst) + SVal retSize = svalBuilder.evalBinOpNN( + state, BO_Add, *strLengthNL,

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

pengfei added a comment. >> It's good that people are looking at achieving better modeling for the x86 >> backend, but we need to have a plan that doesn't require heroic effort just >> to get basic correctness. > > Do you mean in the backend? If so, I don't think that's possible. The >

[PATCH] D67923: [TLI] Support for per-Function TLI that overrides available libfuncs

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. In D67923#1784015 , @tejohnson wrote: > Please take a look. This is now updated to reflect the commit of D71193 > ,

[clang] f450dd6 - [analyzer] CStringChecker: Fix a crash on unknown value passed to strlcat.

Author: Artem Dergachev Date: 2019-12-13T18:00:24-08:00 New Revision: f450dd63a14d6cb16418f6a6f4de26916502c13f URL: https://github.com/llvm/llvm-project/commit/f450dd63a14d6cb16418f6a6f4de26916502c13f DIFF:

[PATCH] D71167: [Driver] Default to -momit-leaf-frame-pointer for AArch64

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. Okay, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71167/new/ https://reviews.llvm.org/D71167

[PATCH] D71500: [WebAssembly] Replace SIMD int min/max builtins with patterns

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60871 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt

[PATCH] D71500: [WebAssembly] Replace SIMD int min/max builtins with patterns

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. The instructions were originally implemented via builtins and intrinsics so users

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski added a comment. Stating it from a different side. If you do not care about GNU ld drop-in replacement property for Linux it's not our business, but we do care about this in NetBSD and we restrict this to our project only (from ELF targets). If you do not care about NetBSD, you

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60874 tests passed, 1 failed and 726 were skipped. failed: Clang.SemaCXX/builtin-align-cxx.cpp {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D69770: [APFloat] Add recoverable string parsing errors to APFloat

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. If we really want to be confident that this is robust, we should probably fuzz-test it. Regardless, this seems like a definite improvement. LGTM. CHANGES SINCE LAST ACTION

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

arichardson created this revision. arichardson added reviewers: rsmith, aaron.ballman, theraven, fhahn. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change introduces three new builtins (which work on both pointers and integers) that can be used instead of common

[clang] 2a789dd - [OpenMP][Docs] Claim loop tiling.

Author: Michael Kruse Date: 2019-12-13T18:42:52-06:00 New Revision: 2a789dd0ad884cbd73b962b6b07cf48e2178d2c9 URL: https://github.com/llvm/llvm-project/commit/2a789dd0ad884cbd73b962b6b07cf48e2178d2c9 DIFF: https://github.com/llvm/llvm-project/commit/2a789dd0ad884cbd73b962b6b07cf48e2178d2c9.diff

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

andrew.w.kaylor added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:444 +def warn_drv_experimental_fp_control_incomplete_opt : Warning< + "Support for floating point control option %0 is incomplete and experimental">,

[PATCH] D69876: Allow output constraints on "asm goto"

void added a comment. Note to reviewers: I would *really* like to get this feature into the 10.0.0 release. That's coming up in January. Do you think you'll have your reviews finished by then? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

andrew.w.kaylor added a comment. In D62731#1784225 , @rjmccall wrote: > ... The big problem is that intrinsic calls are not arbitrary code: the vast > majority of intrinsics (e.g. all the ARM vector intrinsics, many of which can > be floating-point) are

[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

erichkeane added a comment. In D71467#1784338 , @craig.topper wrote: > In D71467#1784286 , @rjmccall wrote: > > > The bug with `__builtin_isless` should be a really easy fix; the builtin > > just needs to be

[PATCH] D71397: [clang] Improve LLVM-style RTTI support in ExternalASTSource/ExternalSemaSource

rjmccall added a comment. If we decide as a community that D39111 is better, we can go back and adopt it at any point; I don't see that as a reason to reject modest refinements, especially given that there is no sign whatsoever of movement on D39111

[PATCH] D71167: [Driver] Default to -momit-leaf-frame-pointer for AArch64

MaskRay added a comment. In D71167#1784272 , @efriedma wrote: > If I'm understanding correctly, this does nothing without D71168 > ? And together with D71168 > , the net change for clang

[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

craig.topper added a subscriber: erichkeane. craig.topper added a comment. In D71467#1784286 , @rjmccall wrote: > The bug with `__builtin_isless` should be a really easy fix; the builtin just > needs to be flagged as having custom type-checking, and then

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski added a comment. @joerg works on the ELF loader and we just need to wait for him. We wrote our temporary patch, but it was not ideal as the long term solution. compiler-rt is nicely maintained from our perspective and we have almost feature parity with Linux. We maintain and

[PATCH] D71475: [WIP][OPENMP] Try to fix linear clause crash by emitting alloca for step

ABataev added a comment. Here is the fix: diff --git a/clang/lib/Sema/SemaOpenMP.cpp b/clang/lib/Sema/SemaOpenMP.cpp index e02c1c5..5ce81b0 100644 --- a/clang/lib/Sema/SemaOpenMP.cpp +++ b/clang/lib/Sema/SemaOpenMP.cpp @@ -3830,6 +3830,9 @@ StmtResult

[PATCH] D71397: [clang] Improve LLVM-style RTTI support in ExternalASTSource/ExternalSemaSource

teemperor marked an inline comment as done. teemperor added a comment. In D71397#1782537 , @lhames wrote: > Side note: This https://reviews.llvm.org/D39111 seems related. The patch has > languished as I have been busy with other work, but if it would be

[PATCH] D71475: [WIP][OPENMP] Try to fix linear clause crash by emitting alloca for step

cchen marked an inline comment as done. cchen added a comment. In D71475#1784284 , @jdoerfert wrote: > What is the output when you run the example with `k` in `lastprivate` or > `reduction`? I actually got the same result (return value) changing from

[PATCH] D71493: [WebAssembly] Setting export_name implies no_dead_strip

sbc100 created this revision. Herald added subscribers: llvm-commits, cfe-commits, sunfish, aheejin, hiraditya, jgravelle-google, dschuff. Herald added projects: clang, LLVM. sbc100 added reviewers: dschuff, sunfish. This change updates the clang front end to add symbols to llvm.used when they

[PATCH] D71397: [clang] Improve LLVM-style RTTI support in ExternalASTSource/ExternalSemaSource

rjmccall added a comment. If this is commonly used, it would make sense to introduce those types into some common header in LLVM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71397/new/ https://reviews.llvm.org/D71397

[PATCH] D71201: [ObjC][DWARF] Emit DW_AT_APPLE_objc_direct for methods marked as __attribute__((objc_direct))

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks! It would be nice to further manually reduce the IR testcase by stripping out any metadata that isn't needed. Otherwise this LGTM CHANGES SINCE LAST ACTION

[PATCH] D71397: [clang] Improve LLVM-style RTTI support in ExternalASTSource/ExternalSemaSource

aprantl added inline comments. Comment at: clang/include/clang/AST/ExternalASTSource.h:69 - /// Whether this AST source also provides information for - /// semantic analysis. - bool SemaSource = false; + // LLVM-style RTTI. + static char ID; rjmccall

[PATCH] D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO

ormris added a comment. //Ping// @tejohnson Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69732/new/ https://reviews.llvm.org/D69732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

rjmccall added a comment. The bug with `__builtin_isless` should be a really easy fix; the builtin just needs to be flagged as having custom type-checking, and then we need to make sure we do appropriate promotions on the arguments (but we probably do). Repository: rG LLVM Github Monorepo

[PATCH] D71167: [Driver] Default to -momit-leaf-frame-pointer for AArch64

efriedma added a comment. If I'm understanding correctly, this does nothing without D71168 ? And together with D71168 , the net change for clang is that "-mno-omit-leaf-frame-pointer" works correctly, but everything else stays

[PATCH] D71475: [WIP][OPENMP] Try to fix linear clause crash by emitting alloca for step

jdoerfert added a comment. What is the output when you run the example with `k` in `lastprivate` or `reduction`? In D71475#1784173 , @cchen wrote: > Doing this still fail the assertion since we still don't have the variable > inside > CapturedStmt.

[PATCH] D71491: [ubsan] Check implicit casts in ObjC for-in statements

vsk created this revision. vsk added reviewers: rjmccall, jfb, arphaman, delcypher. Herald added subscribers: llvm-commits, dexonsmith. Herald added a project: LLVM. Check that the implicit cast from `id` used to construct the element variable in an ObjC for-in statement is valid. This check is

[PATCH] D71434: [Driver] Use .init_array for all gcc installations and simplify Generic_ELF -fno-use-init-array rules

This revision was automatically updated to reflect the committed changes. Closed by commit rGe4fce659a759: [Driver] Use .init_array for all gcc installations and simplify Generic_ELF… (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D71434?vs=233721=233882#toc

[clang] e4fce65 - [Driver] Use .init_array for all gcc installations and simplify Generic_ELF -fno-use-init-array rules

Author: Fangrui Song Date: 2019-12-13T14:06:51-08:00 New Revision: e4fce659a759ecdd59ceee750f1ff9b44f9de3f3 URL: https://github.com/llvm/llvm-project/commit/e4fce659a759ecdd59ceee750f1ff9b44f9de3f3 DIFF: https://github.com/llvm/llvm-project/commit/e4fce659a759ecdd59ceee750f1ff9b44f9de3f3.diff

[PATCH] D71433: [analyzer] CERT: POS34-C

NoQ added a comment. Thanks! This looks like a simple and efficient check. I have one overall suggestion. Currently the check may warn on non-bugs of the following kind: void foo() { char env[] = "NAME=value"; putenv(env); doStuff(); putenv("NAME=anothervalue"); } I.e.,

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

MaskRay added a comment. In D58892#1784119 , @mgorny wrote: > In D58892#1783042 , @MaskRay wrote: > > > In D58892#1783029 , @mgorny wrote: > > > > > I know I'm late to the

[PATCH] D71434: [Driver] Use .init_array for all gcc installations and simplify Generic_ELF -fno-use-init-array rules

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm shipit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

Re: [PATCH] D71486: [clang-tools-extra] Fix switch coverage warning

On Fri, Dec 13, 2019 at 1:18 PM Dávid Bolvanský via Phabricator < revi...@reviews.llvm.org> wrote: > xbolva00 added a comment. > > In D71486#1784079 , @sammccall > wrote: > > > It should be possible to test this by adapting a test case from the > original

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

rjmccall added a comment. I believe your analysis on the second point is unfortunately missing half the problem. Functions like `fesetround` will be treated as having arbitrary side-effects by default, which mean arbitrary code can't be reordered with calls to them. It'd be good to model

[clang] 8035bb4 - [OPENMP]Fix skipping of functions body.

Author: Alexey Bataev Date: 2019-12-13T16:51:46-05:00 New Revision: 8035bb4a6573f7d20f17044a68a1405691000525 URL: https://github.com/llvm/llvm-project/commit/8035bb4a6573f7d20f17044a68a1405691000525 DIFF: https://github.com/llvm/llvm-project/commit/8035bb4a6573f7d20f17044a68a1405691000525.diff

[PATCH] D71475: [WIP][OPENMP] Try to fix linear clause crash by emitting alloca for step

cchen updated this revision to Diff 233869. cchen added a comment. Remove debug code and some redundancy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71475/new/ https://reviews.llvm.org/D71475 Files: clang/lib/Sema/SemaOpenMP.cpp

Re: [clang] f978ea4 - [clang][clang-scan-deps] Aggregate the full dependency information.

On Thu, Dec 12, 2019 at 4:23 AM Nemanja Ivanovic wrote: > Hi Michael, > We are happy to help troubleshoot the issue this caused on our bot. > Unfortunately, this bot is not one where we can give you access so we'll > have to try and work together to debug this. > Can you provide the link to the

[PATCH] D71475: [WIP][OPENMP] Try to fix linear clause crash by emitting alloca for step

cchen updated this revision to Diff 233866. cchen added a comment. Add linear step var into Implicitfirstprivate Doing this still fail the assertion since we still don't have the variable inside CapturedStmt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71167: [Driver] Default to -momit-leaf-frame-pointer for AArch64

MaskRay added a comment. (I got confused over the last weekend.) @efriedma We still need this driver change, otherwise D71168 will cause a functional difference when neither -m(no-)omit-leaf-frame-pointer is specified. https://godbolt.org/z/653p3q

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

bcain added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70919/new/ https://reviews.llvm.org/D70919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

serge-sans-paille marked an inline comment as done. serge-sans-paille added inline comments. Comment at: clang/lib/AST/Decl.cpp:3019 +if (SL.isValid()) + return SM.isInSystemHeader(SL); + } efriedma wrote: > I'm a little concerned about this; we're

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

sidneym updated this revision to Diff 233864. sidneym added a comment. OK, Yes Fuchsia is a good example. Using that pattern Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70919/new/ https://reviews.llvm.org/D70919 Files:

[PATCH] D71400: [RFC] [MinGW] Implicitly add .exe suffix if not provided

mstorsjo updated this revision to Diff 233863. mstorsjo marked 2 inline comments as done. mstorsjo added a comment. Added a code comment, using `llvm::path::has_extension`, added testcases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71400/new/ https://reviews.llvm.org/D71400 Files:

[PATCH] D71431: Call objc_retainBlock before passing a block as a variadic argument

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0a670614a36: Call objc_retainBlock before passing a block as a variadic argument (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D71431?vs=233851=233862#toc Repository: rG

[PATCH] D71463: Implement VectorType conditional operator GNU extension.

erichkeane updated this revision to Diff 233861. erichkeane marked 2 inline comments as done. erichkeane added a comment. Rebase + @eli.friedman s comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71463/new/ https://reviews.llvm.org/D71463 Files:

[PATCH] D71486: [clang-tools-extra] Fix switch coverage warning

xbolva00 added a comment. In D71486#1784079 , @sammccall wrote: > It should be possible to test this by adapting a test case from the original > ed8dadb > , but > I'm not certain...

[PATCH] D71463: Implement VectorType conditional operator GNU extension.

erichkeane marked 5 inline comments as done. erichkeane added a comment. In D71463#1783953 , @efriedma wrote: > Can you update > https://clang.llvm.org/docs/LanguageExtensions.html#langext-vectors with a > description of the interaction between the

[clang] a0a6706 - Call objc_retainBlock before passing a block as a variadic argument

Author: Akira Hatanaka Date: 2019-12-13T13:10:07-08:00 New Revision: a0a670614a36f1686c5086033bef85800128cf66 URL: https://github.com/llvm/llvm-project/commit/a0a670614a36f1686c5086033bef85800128cf66 DIFF:

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

andrew.w.kaylor added a comment. In D62731#1782912 , @rjmccall wrote: > Hmm. The target-specific intrinsics thing does concern me, since I assume > many targets have a bunch of vector intrinsics that may be sensitive to > rounding. Do we have an idea

[PATCH] D71486: [clang-tools-extra] Fix switch coverage warning

merge_guards_bot added a comment. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt , diff.json

[PATCH] D71431: Call objc_retainBlock before passing a block as a variadic argument

ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: clang/docs/AutomaticReferenceCounting.rst:1866 +When a block pointer type is converted to type ``id``, ``Block_copy`` is called. +This is necessary because a block allocated on the stack

[PATCH] D71486: [clang-tools-extra] Fix switch coverage warning

echristo updated this revision to Diff 233857. echristo added a comment. Fix for some slightly better API uses. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71486/new/ https://reviews.llvm.org/D71486 Files:

[PATCH] D71486: [clang-tools-extra] Fix switch coverage warning

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG5623bd52acd3: Fix -Wswitch-coverage warning in clang-tidy after ak_addrspace introduction. (authored by echristo).

[clang-tools-extra] 5623bd5 - Fix -Wswitch-coverage warning in clang-tidy after ak_addrspace introduction.

Author: Eric Christopher Date: 2019-12-13T12:57:48-08:00 New Revision: 5623bd52acd34db2e9cfc11d1510407610a14db0 URL: https://github.com/llvm/llvm-project/commit/5623bd52acd34db2e9cfc11d1510407610a14db0 DIFF:

[PATCH] D71431: Call objc_retainBlock before passing a block as a variadic argument

rjmccall accepted this revision. rjmccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/AutomaticReferenceCounting.rst:1866 +When a block pointer type is converted to type ``id``, ``Block_copy`` is called. +This is necessary

[PATCH] D71431: Call objc_retainBlock before passing a block as a variadic argument

ahatanak updated this revision to Diff 233851. ahatanak added a comment. Explain why this change is needed in ARC documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71431/new/ https://reviews.llvm.org/D71431 Files:

[PATCH] D71486: [clang-tools-extra] Fix switch coverage warning

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60867 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt

[PATCH] D71486: [clang-tools-extra] Fix switch coverage warning

sammccall added a comment. It should be possible to test this by adapting a test case from the original ed8dadb , but I'm not certain... Comment at:

[clang] 348f22e - Correct gcc vector splat conversion from float to int-vector

Author: Erich Keane Date: 2019-12-13T12:27:31-08:00 New Revision: 348f22eac83d9a3ee946e41be43fe507f04a89b6 URL: https://github.com/llvm/llvm-project/commit/348f22eac83d9a3ee946e41be43fe507f04a89b6 DIFF: https://github.com/llvm/llvm-project/commit/348f22eac83d9a3ee946e41be43fe507f04a89b6.diff

[PATCH] D71486: [clang-tools-extra] Fix switch coverage warning

echristo created this revision. echristo added reviewers: Anastasia, sammccall. echristo added a project: clang-tools-extra. Herald added subscribers: cfe-commits, mcrosier. Herald added a project: clang. echristo added a subscriber: rdhindsa. ... I think this is right? Add support in the switch

[PATCH] D71026: Fix LLVM_ENABLE_MODULES=ON + BUILD_SHARED_LIBS=ON build

arichardson added a comment. In D71026#1769340 , @arphaman wrote: > Is the `Tooling/Transformer` library used by clang-format? The problem might > be solved if the `Tooling/Transformer` library was its own module (just like > Clang_ToolingInclusions).

[PATCH] D71485: [profile] Fix a crash when -fprofile-remapping-file= triggers an error

This revision was automatically updated to reflect the committed changes. Closed by commit rG193da743db63: [profile] Fix a crash when -fprofile-remapping-file= triggers an error (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71485: [profile] Fix a crash when -fprofile-remapping-file= triggers an error

MaskRay updated this revision to Diff 233843. MaskRay added a comment. Delete unused declaration Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71485/new/ https://reviews.llvm.org/D71485 Files:

[clang] 193da74 - [profile] Fix a crash when -fprofile-remapping-file= triggers an error

Author: Fangrui Song Date: 2019-12-13T11:38:20-08:00 New Revision: 193da743db63bc7299717f583a63e68d55408731 URL: https://github.com/llvm/llvm-project/commit/193da743db63bc7299717f583a63e68d55408731 DIFF: https://github.com/llvm/llvm-project/commit/193da743db63bc7299717f583a63e68d55408731.diff

[PATCH] D67923: [TLI] Support for per-Function TLI that overrides available libfuncs

tejohnson added a comment. Please take a look. This is now updated to reflect the commit of D71193 , which translated the options to the new attributes. I also removed some comments that I realized didn't make sense, as we need to keep a baseline availability

[PATCH] D67923: [TLI] Support for per-Function TLI that overrides available libfuncs

tejohnson updated this revision to Diff 233841. tejohnson added a comment. Herald added subscribers: cfe-commits, hiraditya. Herald added a project: clang. Update after D71193 committed, converting -fno-builtin* options to attributes. Repository: rG LLVM

[PATCH] D71485: [profile] Fix a crash when -fprofile-remapping-file= triggers an error

wmi accepted this revision. wmi added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71485/new/ https://reviews.llvm.org/D71485 ___

[PATCH] D70073: [ConstExprPreter] Implemented function calls and if statements

nand added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70073/new/ https://reviews.llvm.org/D70073 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71485: [profile] Fix a crash when -fprofile-remapping-file= triggers an error

MaskRay created this revision. MaskRay added reviewers: rsmith, wenlei, wmi. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D71485 Files:

  1   2   >