[PATCH] D71594: testing clang-tidy

goncharov added a comment. In D71594#1788194 , @Eugene.Zelenko wrote: > Where set of Clang-tidy checks come from? .clang-tidy? Could stricter set of > custom rules be used? Yes, clang-tidy uses the .clang-tidy. Do you want to enable additional rules

[PATCH] D71635: [clang] Rename -frounding-math to -fexperimental-rounding-math and add -frounding-math back as a gcc-compat arg.

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60990 tests passed, 1 failed and 727 were skipped. failed: lit.lit/shtest-format.py {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

khchen planned changes to this revision. khchen added a subscriber: eli.friedman. khchen added a comment. I asked @kito-cheng about the GCC LTO behavior, GCC LTO encodes the ABI info in elf and the behavior in above examples match to @efriedma 's responses. So I think maybe encode ABI in module

[PATCH] D71648: [WebAssembly] Add avgr_u intrinsics and require nuw in patterns

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60989 tests passed, 0 failed and 727 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

khchen added a comment. In D71387#1788472 , @efriedma wrote: > > Unfortunately on RISCV, the ABI info is only derived from -mabi option and > > the target triple does not encode ABI info (same to gcc). > > How does gcc decide the default ABI for a

[PATCH] D71648: [WebAssembly] Add avgr_u intrinsics and require nuw in patterns

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. The vector pattern `(a + b + 1) / 2` was previously selected to an avgr_u instruction

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

skan added a comment. In D70157#1788445 , @reames wrote: > Specifically on the revised patch, I remain confused by the need for multiple > subtypes. The need for fragments *between* the potentially fused > instructions doesn't make sense to me. What I

[PATCH] D71644: [clangd] Heuristically resolve dependent call through smart pointer type

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:116 + // smart pointer type. + ASTContext *Ctx = hackyFindASTContext(T); + if (!Ctx) I don't intend for this function to be in the final

[PATCH] D71644: [clangd] Heuristically resolve dependent call through smart pointer type

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/227 Repository: rG LLVM Github Monorepo

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

Meinersbur added a comment. Btw, this patch did not apply cleanly on trunk. I instead test the version from your repository . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71439: Allow redeclaration of __declspec(uuid)

zahen added a comment. @rnk Can you please submit on my behalf. I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71439/new/ https://reviews.llvm.org/D71439 ___ cfe-commits

[PATCH] D70615: Add an -fno-temp-file flag for compilation

zahen added a comment. Any additional changes required? If not could someone please submit on my behalf? @rnk, @hans, @thakis ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70615/new/ https://reviews.llvm.org/D70615 ___ cfe-commits

[PATCH] D71533: [clangd] Show template arguments in type hierarchy when possible

nridge marked an inline comment as done. nridge added a comment. In D71533#1785376 , @kadircet wrote: > I think this requires changes in other places too, for example when querying > index for the children we rather want to query using the symbolid of

[PATCH] D71533: [clangd] Show template arguments in type hierarchy when possible

nridge updated this revision to Diff 234446. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71533/new/ https://reviews.llvm.org/D71533 Files: clang-tools-extra/clangd/XRefs.cpp

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

rupprecht closed this revision. rupprecht added a comment. In D62731#1788902 , @andrew.w.kaylor wrote: > In D62731#1788838 , @rupprecht wrote: > > > It seems the discussion of whether or not this is incomplete

[Diffusion] rG825235c140e7: Revert "[Sema] Use the canonical type in function isVector"

ahatanak added a comment. I'm still not sure why `__fp16`, which is a storage-only type, is used for the element type of `float16x4_t` if we want to avoid promotion to a float vector type. https://clang.llvm.org/docs/LanguageExtensions.html#half-precision-floating-point Was there a discussion

[PATCH] D70836: [analysis] Fix value tracking for pointers to qualified types

xazax.hun added a comment. Great! I have one question though. Will this also work as intended with sugared types? (e.g. typedefs) I believe this might be one of the main reason why the original author used canonical types in the first place. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D71642: [CFG] Add an option to inline CXXDefaultInitExpr into aggregate initialization

xazax.hun updated this revision to Diff 234436. xazax.hun marked 2 inline comments as done. xazax.hun added a comment. - Use range based for. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71642/new/ https://reviews.llvm.org/D71642 Files: clang/include/clang/Analysis/CFG.h

[PATCH] D71642: [CFG] Add an option to inline CXXDefaultInitExpr into aggregate initialization

This revision was automatically updated to reflect the committed changes. Closed by commit rGea93d7d64216: [CFG] Add an option to expand CXXDefaultInitExpr into aggregate initialization (authored by xazax.hun). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ea93d7d - [CFG] Add an option to expand CXXDefaultInitExpr into aggregate initialization

Author: Gabor Horvath Date: 2019-12-17T17:56:06-08:00 New Revision: ea93d7d6421612e9ea51b321eaf97fbdd64fe39b URL: https://github.com/llvm/llvm-project/commit/ea93d7d6421612e9ea51b321eaf97fbdd64fe39b DIFF: https://github.com/llvm/llvm-project/commit/ea93d7d6421612e9ea51b321eaf97fbdd64fe39b.diff

[PATCH] D71642: [CFG] Add an option to inline CXXDefaultInitExpr into aggregate initialization

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. LGTM! Even though this is probably not the right solution for the static analyzer use-case (because we may end up having duplicate expressions in the CFG), it might actually make the static

[PATCH] D71642: [CFG] Add an option to inline CXXDefaultInitExpr into aggregate initialization

xazax.hun updated this revision to Diff 234435. xazax.hun added a comment. - Remove accidentally added files. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71642/new/ https://reviews.llvm.org/D71642 Files: clang/include/clang/Analysis/CFG.h

[PATCH] D71642: [CFG] Add an option to inline CXXDefaultInitExpr into aggregate initialization

xazax.hun updated this revision to Diff 234434. xazax.hun marked 2 inline comments as done. xazax.hun added a comment. - Fix review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71642/new/ https://reviews.llvm.org/D71642 Files: clang/include/clang/Analysis/CFG.h

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

reames added a comment. I've updated the draft assembler support in https://reviews.llvm.org/D71315 to match the proposal here. Again, this is very much WIP and mostly just to show proposed syntax/usage. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70157/new/

[PATCH] D70700: [WebAssembly] Mangle the argc/argv `main` as `__wasm_argc_argv`

sunfish updated this revision to Diff 234426. sunfish added reviewers: sbc100, dschuff, aheejin. sunfish added a comment. This updates the `main` vs `__main_argc_argv` patch so that it doesn't apply to Emscripten targets, following the discussion in

[PATCH] D71642: [CFG] Add an option to inline CXXDefaultInitExpr into aggregate initialization

xazax.hun updated this revision to Diff 234427. xazax.hun added a comment. - Add missing tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71642/new/ https://reviews.llvm.org/D71642 Files: clang/include/clang/Analysis/CFG.h

[PATCH] D71642: [CFG] Add an option to inline CXXDefaultInitExpr into aggregate initialization

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:115 +ANALYZER_OPTION(bool, ShouldIncludeDefaultInitForAggregates, "cfg-aggr-definit", +"Whether or not inline CXXDefaultInitializers for aggregat "

[libunwind] 547659a - [unwind] Don't link libpthread and libdl on Fuchsia

Author: Petr Hosek Date: 2019-12-17T17:21:43-08:00 New Revision: 547659ae56f5827055f71b495d7b08c10badadb5 URL: https://github.com/llvm/llvm-project/commit/547659ae56f5827055f71b495d7b08c10badadb5 DIFF: https://github.com/llvm/llvm-project/commit/547659ae56f5827055f71b495d7b08c10badadb5.diff

[PATCH] D71642: [CFG] Add on option to inline CXXDefaultInitExpr into aggregate initialization

xazax.hun created this revision. xazax.hun added reviewers: NoQ, Szelethus, mgehre. xazax.hun added a project: clang. Herald added subscribers: cfe-commits, Charusso, gamesh411, dkrupp, rnkovacs. This is useful for clients that are relying on linearized CFGs for evaluating subexpressions and

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

andrew.w.kaylor added a comment. In D62731#1788838 , @rupprecht wrote: > It seems the discussion of whether or not this is incomplete died out -- I'd > prefer to assume it is incomplete if there is no consensus. Mailed D71635 >

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

jdoerfert added a comment. In D70258#1788861 , @rjmccall wrote: > That's what I figured. Just to say this again: Current OpenMP code generation keeps a second stack for exactly the same purpose as the one introduced here. > The thing is that that

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

jdoerfert added a comment. In D70258#1788825 , @rjmccall wrote: > So it's never that OpenMP has things that need to be finalized before exiting > (e.g. if something in frontend-emitted code throws an exception), it's just > that OpenMP might need to

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

rjmccall added a comment. That's what I figured. The thing is that that necessarily interacts correctly with everything in Clang's IRGen in ways that making a second stack that Clang's IRGen doesn't directly know about doesn't. I think you either need to extract Clang's entire cleanup-stack

[PATCH] D71635: [clang] Rename -frounding-math to -fexperimental-rounding-math and add -frounding-math back as a gcc-compat arg.

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60990 tests passed, 1 failed and 727 were skipped. failed: lit.lit/shtest-format.py {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build

[PATCH] D71314: Emit a warning if a variable is uninitialized in indirect ASM goto destination.

void added a comment. In D71314#1788797 , @nickdesaulniers wrote: > strange, the below test isn't warning for me with this patch applied: > > $ clang -O2 foo.c -c > $ cat foo.c > int quux(void) { > int y; > asm volatile goto("ja %l1" :

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

ABataev added a comment. In D70258#1788825 , @rjmccall wrote: > So it's never that OpenMP has things that need to be finalized before exiting > (e.g. if something in frontend-emitted code throws an exception), it's just > that OpenMP might need to

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

rupprecht added a comment. It seems the discussion of whether or not this is incomplete died out -- I'd prefer to assume it is incomplete if there is no consensus. Mailed D71635 to rename `-frounding-math` to `-fexperimental-rounding-math`. Alternatively we

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

rjmccall added a comment. So it's never that OpenMP has things that need to be finalized before exiting (e.g. if something in frontend-emitted code throws an exception), it's just that OpenMP might need to generate its own control flow that breaks through arbitrary scopes in the frontend? I

[PATCH] D71635: [clang] Rename -frounding-math to -fexperimental-rounding-math and add -frounding-math back as a gcc-compat arg.

rupprecht created this revision. rupprecht added reviewers: mibintc, chandlerc, echristo, rjmccall, kpn, erichkeane, rsmith, andrew.w.kaylor. Herald added a project: clang. Herald added a subscriber: cfe-commits. D62731 implements an incomplete/experimental

[PATCH] D71625: [CMake] Added remote test execution support into CrossWinToARMLinux CMake cache file.

vvereschaka marked 2 inline comments as done. vvereschaka added a comment. I have updated the diff without using those options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71625/new/ https://reviews.llvm.org/D71625

[PATCH] D71314: Emit a warning if a variable is uninitialized in indirect ASM goto destination.

nickdesaulniers added a comment. strange, the below test isn't warning for me with this patch applied: $ clang -O2 foo.c -c $ cat foo.c int quux(void) { int y; asm volatile goto("ja %l1" : "=r"(y) ::: err); return y; err: return y; } Repository: rG LLVM Github

[PATCH] D71625: [CMake] Added remote test execution support into CrossWinToARMLinux CMake cache file.

vvereschaka updated this revision to Diff 234407. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71625/new/ https://reviews.llvm.org/D71625 Files: clang/cmake/caches/CrossWinToARMLinux.cmake Index: clang/cmake/caches/CrossWinToARMLinux.cmake

[PATCH] D71572: [ItaniumCXXABI] Make tls wrappers comdat on Windows

rnk added a comment. Looks like @rsmith did this here: https://github.com/llvm/llvm-project/commit/fbe2369f1a514423e4c25417ab3532502fde6f2a I see that it was replacing a CHECK for a specific comdat group with no comdat at all. I *think* that's not correct, we should be checking for the trivial

[PATCH] D70701: Fix more VFS tests on Windows

rnk accepted this revision. rnk added a subscriber: JDevlieghere. rnk added a comment. This revision is now accepted and ready to land. +@JDevlieghere, due to recent VFS test fixup. I think this looks good, and in the absence of input from other VFS stakeholders, let's land this soon. Thanks!

[PATCH] D69868: Allow "callbr" to return non-void values

void updated this revision to Diff 234403. void added a comment. Fix bad update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69868/new/ https://reviews.llvm.org/D69868 Files: llvm/docs/LangRef.rst

[PATCH] D69868: Allow "callbr" to return non-void values

void added inline comments. Comment at: llvm/lib/CodeGen/MachineBasicBlock.cpp:1116 +if (auto *cbr = dyn_cast(getBasicBlock()->getTerminator())) + if (cbr->getDefaultDest() != bb) +for (unsigned i = 0, e = cbr->getNumIndirectDests(); i != e; ++i)

[PATCH] D69868: Allow "callbr" to return non-void values

void updated this revision to Diff 234402. void marked 3 inline comments as done. void added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69868/new/

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

jdoerfert added a comment. In D70258#1788427 , @rjmccall wrote: > In D70258#1788396 , @jdoerfert wrote: > > > In D70258#1788305 , @rjmccall > > wrote: > > > > > Introducing

[PATCH] D71625: [CMake] Added remote test execution support into CrossWinToARMLinux CMake cache file.

broadwaylamb added a comment. LGTM Comment at: clang/cmake/caches/CrossWinToARMLinux.cmake:88-91 +set(LIBCXXABI_LINK_TESTS_WITH_SHARED_LIBCXXABI OFF CACHE BOOL "") +set(LIBCXXABI_LINK_TESTS_WITH_SHARED_LIBCXX OFF CACHE BOOL "") +set(LIBCXX_LINK_TESTS_WITH_SHARED_LIBCXX

[clang] 6d3f43e - [analysis] Discard type qualifiers when casting values retrieved from the Store.

Author: Artem Dergachev Date: 2019-12-17T15:00:41-08:00 New Revision: 6d3f43ec61a60c37963ee5f54289cf0759fb5d61 URL: https://github.com/llvm/llvm-project/commit/6d3f43ec61a60c37963ee5f54289cf0759fb5d61 DIFF:

[PATCH] D70836: [analysis] Fix value tracking for pointers to qualified types

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d3f43ec61a6: [analysis] Discard type qualifiers when casting values retrieved from the Store. (authored by dergachev.a). Changed prior to commit: https://reviews.llvm.org/D70836?vs=231473=234397#toc

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

dblaikie added a comment. In D71451#1787729 , @Jac1494 wrote: > In D71451#1786517 , @dblaikie wrote: > > > Do you have any particular users/use case for this? > > > A case when shared library built without debug

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

dblaikie added a comment. In D70524#1787566 , @SouraVX wrote: > > It looks like this implementation is a bit buggy in one way and incomplete > > in another: > > > > 1. even if the auto-returning function is defined, that function definition > > doesn't

[PATCH] D70537: [clang] CGDebugInfo asserts `!DT.isNull()` when compiling with debug symbols

dblaikie added a comment. In D70537#1788252 , @probinson wrote: > @dblaikie let me reflect this back to make sure I get it: > Template members (methods or variables) would never appear in the *metadata* > description of the struct; but metadata

[PATCH] D71572: [ItaniumCXXABI] Make tls wrappers comdat on Windows

mstorsjo marked an inline comment as done. mstorsjo added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2551 + // actually handle multiple TUs defining the same wrapper. + if (CGM.getTriple().isOSWindows() && CGM.supportsCOMDAT() && +

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

arphaman added a comment. @phosek I fixed the tests in be88a20c900463c4919433109e4c17cd001da580 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71579/new/

[PATCH] D71572: [ItaniumCXXABI] Make tls wrappers comdat on Windows

mstorsjo marked an inline comment as done. mstorsjo added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2551 + // actually handle multiple TUs defining the same wrapper. + if (CGM.getTriple().isOSWindows() && CGM.supportsCOMDAT() && +

[clang] be88a20 - [driver][darwin] Use explicit -mlinker-version in the -platform_version tests

Author: Alex Lorenz Date: 2019-12-17T14:25:22-08:00 New Revision: be88a20c900463c4919433109e4c17cd001da580 URL: https://github.com/llvm/llvm-project/commit/be88a20c900463c4919433109e4c17cd001da580 DIFF: https://github.com/llvm/llvm-project/commit/be88a20c900463c4919433109e4c17cd001da580.diff

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

arphaman added a comment. Looks like `HOST_LINK_VERSION` is influencing the decision. I should specify the version manually in the tests then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71579/new/ https://reviews.llvm.org/D71579

[PATCH] D71408: [lit] Remove lit's REQUIRES-ANY directive

thopre added a subscriber: nemanjai. thopre added a comment. Herald added a subscriber: wuzish. In D71408#1787959 , @jdenny wrote: > This breaks the lit test suite. `llvm/utils/lit/tests/shtest-format.py` > needs to be updated for the removed tests.

[PATCH] D71408: [lit] Remove lit's REQUIRES-ANY directive

jdenny added a comment. In D71408#1788582 , @thopre wrote: > This is embarrassing. It happens. > I presume ninja check-all includes those 2 tests so I'm not sure how I missed > it. It should. > On a related note, I used to receive mail notification

[PATCH] D71572: [ItaniumCXXABI] Make tls wrappers comdat on Windows

rnk added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2551 + // actually handle multiple TUs defining the same wrapper. + if (CGM.getTriple().isOSWindows() && CGM.supportsCOMDAT() && + Wrapper->isWeakForLinker()) IMO we should be

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

arphaman added a comment. @phosek Thanks, I think it reproduces on our macOS bots. I'll start fixing it right now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71579/new/ https://reviews.llvm.org/D71579

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

phosek added a comment. I'm not sure if the detection is working correctly, this is failing on our macOS toolchain bots: FAIL: Clang :: Driver/darwin-ld-platform-version-ios.c (5284 of 16450) TEST 'Clang :: Driver/darwin-ld-platform-version-ios.c' FAILED

[PATCH] D71612: [analyzer] Add PlacementNewChecker

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CheckPlacementNew.cpp:40 +if (const auto *ERegion = dyn_cast(TVRegion)) { + const auto *SRegion = cast(ERegion->getSuperRegion()); + DefinedOrUnknownSVal Extent =

[PATCH] D68913: Adds fixit hints to the Wrange-loop-analysis

Mordante added a comment. In D68913#1787784 , @thakis wrote: > Mordante, do you need someone to land this for you? Thanks for the offer, but it's not required. I want to commit it once I fixed all issues that would be introduced by D68912

[PATCH] D71556: [AArch64][SVE] Implement intrinsic for non-faulting loads

efriedma added a comment. > Perhaps we can clarify the intent that the non-faulting mode may have > side-effects by renaming the flag to something like > NonFaultingWithSideEffects? We could specify something like that... but that probably requires some changes to target-independent

[PATCH] D71436: [X86][AsmParser] re-introduce 'offset' operator

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60854 tests passed, 0 failed and 726 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

jyknight added a comment. In D70157#1788418 , @reames wrote: > In D70157#1788025 , @jyknight wrote: > > > > .push_align_branch_boundary [N,] [instruction,]* > > > > I'd like to raise again the possibility of using

[PATCH] D71625: [CMake] Added remote test execution support into CrossWinToARMLinux CMake cache file.

vvereschaka created this revision. vvereschaka added reviewers: aorlov, andreil99, broadwaylamb. Herald added subscribers: cfe-commits, kristof.beyls, mgorny. Herald added a project: clang. Added two confguration argument to provide a host name and SSH user name to run the tests on the remote

[PATCH] D71436: [X86][AsmParser] re-introduce 'offset' operator

epastor added a comment. Thanks for feedback! Comment at: clang/test/CodeGen/ms-inline-asm-64.c:18 // CHECK: call void asm sideeffect inteldialect -// CHECK-SAME: mov [eax], $0 +// CHECK-SAME: mov qword ptr [eax], $0 // CHECK-SAME: "r,~{dirflag},~{fpsr},~{flags}"(i32*

[PATCH] D71436: [X86][AsmParser] re-introduce 'offset' operator

epastor updated this revision to Diff 234371. epastor marked 6 inline comments as done. epastor added a comment. - Address refactoring comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71436/new/ https://reviews.llvm.org/D71436 Files:

[PATCH] D71529: [Sema] Fixes -Wrange-loop-analysis warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ec6128daeea: [Sema] Fixes -Wrange-loop-analysis warnings (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71529/new/

[PATCH] D71527: [Driver] Avoid copies in range-based for loops

This revision was automatically updated to reflect the committed changes. Closed by commit rGb750486c5d96: [Driver] Avoid copies in range-based for loops (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71527/new/

[clang] b750486 - [Driver] Avoid copies in range-based for loops

Author: Mark de Wever Date: 2019-12-17T21:56:04+01:00 New Revision: b750486c5d96320daf77a9760166f78b4a0c942e URL: https://github.com/llvm/llvm-project/commit/b750486c5d96320daf77a9760166f78b4a0c942e DIFF: https://github.com/llvm/llvm-project/commit/b750486c5d96320daf77a9760166f78b4a0c942e.diff

[clang] 3ec6128 - [Sema] Fixes -Wrange-loop-analysis warnings

Author: Mark de Wever Date: 2019-12-17T21:54:32+01:00 New Revision: 3ec6128daeeaadde7dd2eca8b343a56f60a8364d URL: https://github.com/llvm/llvm-project/commit/3ec6128daeeaadde7dd2eca8b343a56f60a8364d DIFF: https://github.com/llvm/llvm-project/commit/3ec6128daeeaadde7dd2eca8b343a56f60a8364d.diff

[PATCH] D71623: [compiler-rt] [test] Add missing %run to fread_fwrite MSAN test

mgorny created this revision. mgorny added reviewers: krytarowski, m.ostapenko, eugenis. Herald added subscribers: llvm-commits, Sanitizers, dberris. Herald added projects: LLVM, Sanitizers. Add a missing %run substitution to fread_fwrite test. This fixes the test on NetBSD where %run disables

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

efriedma added a comment. > Unfortunately on RISCV, the ABI info is only derived from -mabi option and > the target triple does not encode ABI info (same to gcc). How does gcc decide the default ABI for a target? Do you explicitly specify it at configure time? > example 1: > What's expected

[PATCH] D71530: [Frontend] Fixes -Wrange-loop-analysis warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rG385339034f08: [Frontend] Fixes -Wrange-loop-analysis warnings (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71530/new/

[clang] 3853390 - [Frontend] Fixes -Wrange-loop-analysis warnings

Author: Mark de Wever Date: 2019-12-17T21:52:47+01:00 New Revision: 385339034f08212d95ade89fdbacb014d86be1e2 URL: https://github.com/llvm/llvm-project/commit/385339034f08212d95ade89fdbacb014d86be1e2 DIFF: https://github.com/llvm/llvm-project/commit/385339034f08212d95ade89fdbacb014d86be1e2.diff

[PATCH] D71585: [perf-training] Change profile file pattern string to use %4m instead of %p

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3f789e037cb: [perf-training] Change profile file pattern string to use %4m instead of %p (authored by xinxinw1, committed by xiaobai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. I tested the configurations mentioned at https://groups.google.com/d/topic/polly-dev/vxumPMhrSEs/discussion again and did not find any issues that were not there before. Therefore

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

reames added a comment. Specifically on the revised patch, I remain confused by the need for multiple subtypes. The need for fragments *between* the potentially fused instructions doesn't make sense to me. What I was expecting to see was the following: BoundaryAlign w/target=the branch

[clang] b3f789e - [perf-training] Change profile file pattern string to use %4m instead of %p

Author: Xin-Xin Wang Date: 2019-12-17T12:12:21-08:00 New Revision: b3f789e037cbfdb1439c01a4eefc9ab9bb0d2c64 URL: https://github.com/llvm/llvm-project/commit/b3f789e037cbfdb1439c01a4eefc9ab9bb0d2c64 DIFF: https://github.com/llvm/llvm-project/commit/b3f789e037cbfdb1439c01a4eefc9ab9bb0d2c64.diff

[PATCH] D64573: [Syntax] Allow to mutate syntax trees

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60958 tests passed, 0 failed and 726 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

rjmccall added a comment. In D70258#1788396 , @jdoerfert wrote: > In D70258#1788305 , @rjmccall wrote: > > > Introducing an IRBuilder-level finalization stack sounds like it's going to > > be a huge mess if your

[PATCH] D64573: [Syntax] Allow to mutate syntax trees

ilya-biryukov added inline comments. Comment at: clang/include/clang/Tooling/Syntax/BuildTree.h:25 +/// Allows to create syntax trees from subtrees not backed by the source code. +class Factory { +public: gribozavr2 wrote: > Why a class to contain static

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

reames added a comment. In D70157#1788025 , @jyknight wrote: > > .push_align_branch_boundary [N,] [instruction,]* > > I'd like to raise again the possibility of using a more general region > directive to denote "It is allowable to add prefixes/nops

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

reames added a comment. In D70157#1787403 , @annita.zhang wrote: > In D70157#1787160 , @MaskRay wrote: > > > > > > > > > There is a precedant: .pushsection/.popsection (MCStreamer::SectionStack). > > With

[PATCH] D64573: [Syntax] Allow to mutate syntax trees

ilya-biryukov updated this revision to Diff 234359. ilya-biryukov marked 24 inline comments as done. ilya-biryukov added a comment. - Addressed most comments - Rebased onto HEAD Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64573/new/

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

jdoerfert added a subscriber: rjmccall. jdoerfert added a comment. In D70258#1788305 , @rjmccall wrote: > I opposed the creation of this library on these terms in the first place, so > I'm pretty sure I'm not on the hook to review it. That's fine with

[PATCH] D71612: [analyzer] Add PlacementNewChecker

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CheckPlacementNew.cpp:22 +ProgramStateRef State) const; + mutable std::unique_ptr BT_Placement; +}; I think now it is safe to have the bugtype by value

[PATCH] D71585: [perf-training] Change profile file pattern string to use %4m instead of %p

xinxinw1 added a comment. @vsk Thanks! The %c mode looks pretty cool but yeah, I don't really have the bandwidth to test it right now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71585/new/ https://reviews.llvm.org/D71585

[PATCH] D71513: [compiler-rt] [test] Disable MPROTECT on two builtin tests

mgorny updated this revision to Diff 234351. mgorny edited the summary of this revision. mgorny added a comment. Switch to using `%run_nomprotect` instead of extra `%paxctl`. This should be more consistent and should avoid potential issues with `:` on Windows. CHANGES SINCE LAST ACTION

[clang] 599d1cc - [Clang FE, SystemZ] Recognize -mpacked-stack CL option

Author: Jonas Paulsson Date: 2019-12-17T11:26:17-08:00 New Revision: 599d1cc07a51e9a556afa2a995930f7ffe0e42cd URL: https://github.com/llvm/llvm-project/commit/599d1cc07a51e9a556afa2a995930f7ffe0e42cd DIFF:

[PATCH] D71491: [ubsan] Check implicit casts in ObjC for-in statements

vsk added inline comments. Comment at: compiler-rt/lib/ubsan/ubsan_value.cpp:29 +const char *__ubsan::getObjCClassName(ValueHandle Pointer) { +#if defined(__APPLE__) + // We need to query the ObjC runtime for some information, but do not want delcypher wrote: >

[PATCH] D71588: [objc_direct] fix uniquing when re-declaring a readwrite-direct property

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4e1819c1683: [objc_direct] fix uniquing when re-declaring a readwrite-direct property (authored by MadCoder, committed by arphaman). Changed prior to commit:

[clang] a4e1819 - [objc_direct] fix uniquing when re-declaring a readwrite-direct property

Author: Pierre Habouzit Date: 2019-12-17T11:07:48-08:00 New Revision: a4e1819c16836dba928e646024a2406bb2eb3f94 URL: https://github.com/llvm/llvm-project/commit/a4e1819c16836dba928e646024a2406bb2eb3f94 DIFF:

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

rjmccall resigned from this revision. rjmccall added a comment. I opposed the creation of this library on these terms in the first place, so I'm pretty sure I'm not on the hook to review it. Introducing an IRBuilder-level finalization stack sounds like it's going to be a huge mess if your

[PATCH] D71588: [objc_direct] fix uniquing when re-declaring a readwrite-direct property

arphaman added a comment. I couldn't come up with a reasonable Sema-based test, so I'm going to commit this as it is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71588/new/ https://reviews.llvm.org/D71588

  1   2   3   >