[PATCH] D70270: clang-tidy: modernize-use-using uses AST and now supports struct defintions and multiple types in a typedef

poelmanc updated this revision to Diff 235039. poelmanc added a subscriber: sammccall. poelmanc added a comment. Update patch to rebase on latest: Changed `SourceLocation::contains` to `SourceLocation::fullyContains`, and removed new `SourceLocation` comparison operators since coincidentally

[PATCH] D71802: [NFC] Move OptionUtils from Basic to Driver

yaxunl created this revision. yaxunl added reviewers: thakis, tra. Herald added a subscriber: mgorny. https://reviews.llvm.org/D71802 Files: clang/include/clang/Basic/OptionUtils.h clang/include/clang/Driver/OptionUtils.h clang/include/clang/Frontend/Utils.h

[PATCH] D71677: [ms] [X86] Use "P" modifier on operands to call instructions in inline X86 assembly.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61087 tests passed, 0 failed and 728 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D71080: [NFC] Separate getLastArgIntValue to Basic

yaxunl added a comment. In D71080#1794066 , @thakis wrote: > Why move this to Basic instead of to Driver if you want to use it in Driver? > (Frontend depends on Driver so it could then still use it.) You are right. Driver is a better place. I will

[PATCH] D71677: [ms] [X86] Use "P" modifier on operands to call instructions in inline X86 assembly.

epastor updated this revision to Diff 235035. epastor marked an inline comment as done. epastor added a comment. Fix test; missing anchor meant the previous version would not catch a regression. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71677: [ms] [X86] Use "P" modifier on operands to call instructions in inline X86 assembly.

epastor marked 2 inline comments as done. epastor added inline comments. Comment at: llvm/test/CodeGen/X86/ms-inline-asm-PR44272.ll:15 +; CHECK: {{## InlineAsm Start|#APP}} +; CHECK: call{{l|q}} func +; CHECK: {{## InlineAsm End|#NO_APP}} rnk wrote: > I'd

[PATCH] D71791: [CFG] Fix an assertion failure with static initializers

NoQ added a comment. > I am not sure what would be the best way to test this change here. A unittest, if you're brave :) Comment at: clang/lib/Analysis/CFG.cpp:5923 + if (isa(Cond) || isa(Cond)) return nullptr; Charusso wrote: > What about the

[PATCH] D71080: [NFC] Separate getLastArgIntValue to Basic

thakis added a comment. Why move this to Basic instead of to Driver if you want to use it in Driver? (Frontend depends on Driver so it could then still use it.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71080/new/

[PATCH] D71080: [NFC] Separate getLastArgIntValue to Basic

This revision was automatically updated to reflect the committed changes. Closed by commit rG7376d9eb3891: [NFC] Separate getLastArgIntValue to Basic (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 7376d9e - [NFC] Separate getLastArgIntValue to Basic

Author: Yaxun (Sam) Liu Date: 2019-12-21T20:39:31-05:00 New Revision: 7376d9eb38914ff7b6b5f5901d32743f0ee76b5a URL: https://github.com/llvm/llvm-project/commit/7376d9eb38914ff7b6b5f5901d32743f0ee76b5a DIFF:

[PATCH] D71686: Fix false positive in magic number checker

0x8000- added a comment. My take: this change fixes a user-reported bug, and does not cause any known regressions. I think we should integrate this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71686/new/ https://reviews.llvm.org/D71686

[PATCH] D71791: [CFG] Fix an assertion failure with static initializers

Szelethus added a comment. > I am not sure what would be the best way to test this change here. I'll admit, I'm a bit out of touch with Clang and will unfortunately be for a while, but the short answer is that the unit tests we have for the CFG are kinda bad. The constructed CFG has a longer

[PATCH] D71677: [ms] [X86] Use "P" modifier on operands to call instructions in inline X86 assembly.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:2871 + // differently when referenced in MS-style inline assembly. + if (Name.startswith("call") ||

[PATCH] D71221: [HIP] Add option --gpu-max-threads-per-block=n

yaxunl updated this revision to Diff 235025. yaxunl added a comment. revised by Artem's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71221/new/ https://reviews.llvm.org/D71221 Files: clang/include/clang/Basic/LangOptions.def clang/include/clang/Driver/Options.td

[PATCH] D71746: Fix the "TypeError: a bytes-like object is required, not 'str'" in exploded-graph-rewriter.py on Python 3.5+

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG2203089a60d8: [analyzer] exploded-graph-rewriter: Fix string encodings in python3. (authored by dergachev.a).

[clang] 2203089 - [analyzer] exploded-graph-rewriter: Fix string encodings in python3.

Author: Artem Dergachev Date: 2019-12-21T10:59:38-08:00 New Revision: 2203089a60d826e882e2ccfc5cc5d361b4f91078 URL: https://github.com/llvm/llvm-project/commit/2203089a60d826e882e2ccfc5cc5d361b4f91078 DIFF:

[PATCH] D45677: [libcxx] [test] Fix typo in filesystem test

jloser added a comment. Jim, thanks for accepting the review. Do you mind landing this on my behalf? I don't have commit rights. Thanks! Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45677/new/ https://reviews.llvm.org/D45677

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

dblaikie added a subscriber: JDevlieghere. dblaikie added a comment. In D71451#1793828 , @Jac1494 wrote: > > Am I reading this right that the data would suggest that enabling this > > feature /reduces/ the size of debug info sections? That doesn't sound

[clang] fc5102f - [NFC] test commit reverted

Author: Stepan Dyatkovskiy Date: 2019-12-21T22:12:07+04:00 New Revision: fc5102fb6e3d4744c2bb9f0230d088a9777e69cb URL: https://github.com/llvm/llvm-project/commit/fc5102fb6e3d4744c2bb9f0230d088a9777e69cb DIFF:

[clang] 452ca8e - [NFC] test commit

Author: Stepan Dyatkovskiy Date: 2019-12-21T22:11:34+04:00 New Revision: 452ca8e73f26835f94bb3e274adb210d3c3ed5ea URL: https://github.com/llvm/llvm-project/commit/452ca8e73f26835f94bb3e274adb210d3c3ed5ea DIFF:

[PATCH] D71512: [clang-format] Fix short block when braking after control statement

Bouska added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:586 verifyFormat("if (true) {\n" - " ff();\n" "}", MyDeveloperDay wrote: > any reason you are

[PATCH] D71775: [ThreadPool] On Windows, extend usage to all CPU sockets and all NUMA groups

aganea added a comment. In D71775#1793767 , @mehdi_amini wrote: > > Will it make sense to say "I don't want hyper-threads" ? > > Not sure I remember correctly, but I believe one motivation behind avoiding > "hyper-threads" and other virtual cores was

[clang] 7cee288 - Fix `-Wunused-variable` warning. NFC.

Author: Michael Liao Date: 2019-12-21T11:10:35-05:00 New Revision: 7cee28858674d233903e92b7a0c49b07b05ed3d3 URL: https://github.com/llvm/llvm-project/commit/7cee28858674d233903e92b7a0c49b07b05ed3d3 DIFF: https://github.com/llvm/llvm-project/commit/7cee28858674d233903e92b7a0c49b07b05ed3d3.diff

[PATCH] D69223: WDocumentation: Implement the \anchor.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe1a9b3863b6: [Wdocumentation] Implement \anchor (authored by Mordante). Changed prior to commit: https://reviews.llvm.org/D69223?vs=231766=235016#toc Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D70869: [Analyzer] Use a reference in a range-based for

This revision was automatically updated to reflect the committed changes. Closed by commit rG70d592d68c7a: [Analyzer] Use a reference in a range-based for (authored by Mordante). Changed prior to commit: https://reviews.llvm.org/D70869?vs=231593=235015#toc Repository: rG LLVM Github

[clang] 70d592d - [Analyzer] Use a reference in a range-based for

Author: Mark de Wever Date: 2019-12-21T14:52:29+01:00 New Revision: 70d592d68c7a8666183308d1daa2322ede87df09 URL: https://github.com/llvm/llvm-project/commit/70d592d68c7a8666183308d1daa2322ede87df09 DIFF: https://github.com/llvm/llvm-project/commit/70d592d68c7a8666183308d1daa2322ede87df09.diff

[clang] be1a9b3 - [Wdocumentation] Implement \anchor

Author: Mark de Wever Date: 2019-12-21T14:52:21+01:00 New Revision: be1a9b3863b6649ef64f25c22394335c47f2ef31 URL: https://github.com/llvm/llvm-project/commit/be1a9b3863b6649ef64f25c22394335c47f2ef31 DIFF: https://github.com/llvm/llvm-project/commit/be1a9b3863b6649ef64f25c22394335c47f2ef31.diff

[clang] 75e500d - Add missing `REQUIRES: hexagon-registered-target`

Author: David Zarzycki Date: 2019-12-21T06:45:30-05:00 New Revision: 75e500dd4713e785f0ca7afc37e7ba206a4391b0 URL: https://github.com/llvm/llvm-project/commit/75e500dd4713e785f0ca7afc37e7ba206a4391b0 DIFF:

[PATCH] D70265: [clang-tidy] Add clang tidy check I.2 to cppcoreguidelines

JonasToth added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidNonConstGlobalVariablesCheck.cpp:26 + hasType(isConstQualified()), + hasType(referenceType()), // References can't be changed, only data +

[clang] 5a79cfa - Customize simplified dumping and matching of LambdaExpr

Author: Stephen Kelly Date: 2019-12-21T11:02:11Z New Revision: 5a79cfa32d62f018607438a30b7acb49c2ab97f3 URL: https://github.com/llvm/llvm-project/commit/5a79cfa32d62f018607438a30b7acb49c2ab97f3 DIFF: https://github.com/llvm/llvm-project/commit/5a79cfa32d62f018607438a30b7acb49c2ab97f3.diff

[clang] a0ce615 - clang is now under the apache2 license

Author: Sylvestre Ledru Date: 2019-12-21T10:52:30+01:00 New Revision: a0ce6155734eaaea315dc82579b230b172fb8ccc URL: https://github.com/llvm/llvm-project/commit/a0ce6155734eaaea315dc82579b230b172fb8ccc DIFF:

[clang] 384a287 - Remove a gcc 4.9 comparison as it doesn't make sense

Author: Sylvestre Ledru Date: 2019-12-21T10:46:45+01:00 New Revision: 384a287a87ad0989624eb785293d38f9b710 URL: https://github.com/llvm/llvm-project/commit/384a287a87ad0989624eb785293d38f9b710 DIFF:

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

Jac1494 added a comment. > Am I reading this right that the data would suggest that enabling this > feature /reduces/ the size of debug info sections? That doesn't sound right - > can you explain why that would be the case? (perhaps the data is incorrect/it > wasn't built with

[PATCH] D59520: [WebAssembly] Address review comments on r352930

sunfish marked 10 inline comments as done. sunfish added a comment. I apologize for the extraordinary delays here; at long last, I've now addressed your feedback. Comment at: lib/Sema/SemaDeclAttr.cpp:5781-5783 +Sema::mergeImportNameAttr(Decl *D, SourceRange Range, +

[PATCH] D59520: [WebAssembly] Address review comments on r352930

sunfish updated this revision to Diff 235005. sunfish added a comment. Address review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59520/new/ https://reviews.llvm.org/D59520 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td