[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

2019-12-25 Thread Djordje Todorovic via Phabricator via cfe-commits
djtodoro added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:169 +* C DebugInfo API ``LLVMDIBuilderCreateTypedef`` is updated to include an extra +argument ``AlignInBits``, to facilitate / propagate specified Alignment information

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

2019-12-25 Thread Sourabh Singh Tomar via Phabricator via cfe-commits
SouraVX added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:169 +* C DebugInfo API ``LLVMDIBuilderCreateTypedef`` is updated to include an extra +argument ``AlignInBits``, to facilitate / propagate specified Alignment information

[PATCH] D71884: [OpenMP] Fix formatting of OpenMP error message.

2019-12-25 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. I would have just stripped the last chars of ` Out.str()` but if this passes all the tests I'm fine with it. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71884: [OpenMP] Fix formatting of OpenMP error message.

2019-12-25 Thread Wang Tianqing via Phabricator via cfe-commits
tianqing created this revision. Herald added subscribers: cfe-commits, guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. tianqing added a reviewer: ABataev. `getListOfPossibleValues()` formatted incorrectly when there is only one value, emitting something like

[PATCH] D71846: [ASTMatchers] Fix for https://bugs.llvm.org/show_bug.cgi?id=44364

2019-12-25 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 235301. njames93 edited the summary of this revision. njames93 added a comment. fixed a spelling mistake in unit tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71846/new/ https://reviews.llvm.org/D71846 Files:

[PATCH] D69868: Allow "callbr" to return non-void values

2019-12-25 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added subscribers: aaron.ballman, xbolva00. xbolva00 added inline comments. Comment at: llvm/lib/CodeGen/MachineBasicBlock.cpp:1116 +if (auto *cbr = dyn_cast(getBasicBlock()->getTerminator())) + if (cbr->getDefaultDest() != bb) +for (unsigned i = 0, e =

[PATCH] D71846: [ASTMatchers] Fix for https://bugs.llvm.org/show_bug.cgi?id=44364

2019-12-25 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 235300. njames93 marked an inline comment as done. njames93 added a comment. Renamed 'hasInitStorage' to 'hasInitStatement'. Added support for range for loops in 'hasInitStatement'. 'hasInitStatement' now has a match predicate on the init statement.

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

2019-12-25 Thread Johannes Doerfert via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf9c3c5da19ab: [OpenMP][IR-Builder] Introduce the finalization stack (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70258/new/

[clang] f9c3c5d - [OpenMP][IR-Builder] Introduce the finalization stack

2019-12-25 Thread Johannes Doerfert via cfe-commits
Author: Johannes Doerfert Date: 2019-12-25T16:57:08-06:00 New Revision: f9c3c5da19ab6d8cbbd4611fbb24e97fe7a85078 URL: https://github.com/llvm/llvm-project/commit/f9c3c5da19ab6d8cbbd4611fbb24e97fe7a85078 DIFF:

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

2019-12-25 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61107 tests passed, 0 failed and 728 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

2019-12-25 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev planned changes to this revision. kbobyrev added a comment. This is a WIP draft. Few items to address before pushing for a review - More tests: renaming is a complex feature and I want to make sure there are no regressions/corner-cases I did not handle. It might make sense to adopt a

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

2019-12-25 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This patch introduces new canonicalization rules which are used for AST-based rename in Clangd. By comparing two canonical

[PATCH] D71846: [ASTMatchers] Fix for https://bugs.llvm.org/show_bug.cgi?id=44364

2019-12-25 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 235278. njames93 added a comment. I added test cases for the matchers and the check, wasn't able to add the CXXRangeFor to the matcher as that class uses a different dialect for the initializer statement handling. I also couldn't generate the new

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

2019-12-25 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:75 `bugprone-sizeof-expression `_, , "high" + `bugprone-spuriously-wake-up-functions `_, , "" `bugprone-string-constructor `_, "Yes", "high" Could