[PATCH] D71980: [clang-tidy] Disable Checks on If constexpr statements in template Instantiations for BugproneBranchClone and ReadabilityBracesAroundStatements

JonasToth added a comment. In D71980#1810086 , @njames93 wrote: > Is this good to land and if so anyone able to commit? I marked this patch for porting into the release. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72793: [clang-format] Expand the SpacesAroundConditions option to include catch statements

MyDeveloperDay added a subscriber: hans. MyDeveloperDay added a comment. In D72793#1828625 , @timwoj wrote: > I know that 10.0 was branch recently. Any chance this can make it over? I don't personally ever do this because I only use the snapshot builds.

[PATCH] D69282: [RFC] Add a VCS conflict marker format printing on tooling::ReplacementError

jdemeule added a comment. Kindly ping reviewers. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69282/new/ https://reviews.llvm.org/D69282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69475: [clang] Provide better fix-it on exception spec error

jdemeule added a comment. Kindly ping reviewer. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69475/new/ https://reviews.llvm.org/D69475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69868: Allow "callbr" to return non-void values

void updated this revision to Diff 239026. void added a comment. Update so that each MBB has a list of indirect dests of INLINEASM_BR instructions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69868/new/ https://reviews.llvm.org/D69868 Files: llvm/docs/LangRef.rst

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

Jac1494 added a comment. > that still seems very surprising - this change is specifically intended to > add more debug info, is it not? So do you have any ideas/theories as to why > that's not showing up in the data? Yes, In clang and llvm extern variable are there inside header file ,So

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

dblaikie added a comment. In D71451#1828647 , @Jac1494 wrote: > > Do you have any reason to believe these patches would reduce the size of > > the debug info? It seems like they only add more debug info, and don't > > remove anything - so we'd expect an

[PATCH] D72897: List implicit operator== after implicit destructors in a vtable.

This revision was automatically updated to reflect the committed changes. Closed by commit rGadd2b7e44ada: List implicit operator== after implicit destructors in a vtable. (authored by rsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 7a9fa76 - Undo changes to release notes intended for the Clang 10 branch, not master.

Author: Richard Smith Date: 2020-01-19T18:33:42-08:00 New Revision: 7a9fa76be7425b5a6fb3dfe7fc4f9e16892628cb URL: https://github.com/llvm/llvm-project/commit/7a9fa76be7425b5a6fb3dfe7fc4f9e16892628cb DIFF: https://github.com/llvm/llvm-project/commit/7a9fa76be7425b5a6fb3dfe7fc4f9e16892628cb.diff

[clang] add2b7e - List implicit operator== after implicit destructors in a vtable.

Author: Richard Smith Date: 2020-01-19T18:31:36-08:00 New Revision: add2b7e44ada46f30715b5c48823a9e9e317e0c3 URL: https://github.com/llvm/llvm-project/commit/add2b7e44ada46f30715b5c48823a9e9e317e0c3 DIFF: https://github.com/llvm/llvm-project/commit/add2b7e44ada46f30715b5c48823a9e9e317e0c3.diff

[clang] 13fa4e2 - PR42108 Consistently diagnose binding a reference template parameter to

Author: Richard Smith Date: 2020-01-19T18:16:36-08:00 New Revision: 13fa4e2e5ae6ab5403be19e24415e0c7a5569681 URL: https://github.com/llvm/llvm-project/commit/13fa4e2e5ae6ab5403be19e24415e0c7a5569681 DIFF: https://github.com/llvm/llvm-project/commit/13fa4e2e5ae6ab5403be19e24415e0c7a5569681.diff

[clang] a7818e6 - fix doc typos to cycle bots

Author: Nico Weber Date: 2020-01-19T18:13:08-05:00 New Revision: a7818e6f29c136bfe60ce7af0ac3c35b5d9da7d6 URL: https://github.com/llvm/llvm-project/commit/a7818e6f29c136bfe60ce7af0ac3c35b5d9da7d6 DIFF: https://github.com/llvm/llvm-project/commit/a7818e6f29c136bfe60ce7af0ac3c35b5d9da7d6.diff

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

Jac1494 added a comment. > Do you have any reason to believe these patches would reduce the size of the > debug info? It seems like they only add more debug info, and don't remove > anything - so we'd expect an increase in the size, certainly not a decrease. > That means, to me, there's

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62002 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

Mordante added a comment. I proposed D73007 as fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68912/new/ https://reviews.llvm.org/D68912 ___ cfe-commits mailing

[PATCH] D50360: [Concepts] Requires Expressions

thakis added a comment. In D50360#1828329 , @thakis wrote: > Doesn't this still break check-clang everywhere? See e.g. > http://45.33.8.238/linux/7860/step_7.txt It looks like this is some incremental build issue; after a clean build everything's

[PATCH] D72793: [clang-format] Expand the SpacesAroundConditions option to include catch statements

timwoj added a comment. I know that 10.0 was branch recently. Any chance this can make it over? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72793/new/ https://reviews.llvm.org/D72793 ___ cfe-commits

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

Mordante created this revision. Mordante added reviewers: rsmith, rtrieu, aaron.ballman, xbolva00. Mordante added a project: clang. When Wrange-loop-analysis issues a diagnostic on a dependent type in a template the diagnostic may not be valid for all instantiations. Therefore the diagnostic is

[PATCH] D73006: [Codegen] If reasonable, materialize clang's `AllocAlignAttr` as llvm's Alignment Attribute on call-site function return value

lebedev.ri created this revision. lebedev.ri added reviewers: erichkeane, jdoerfert, hfinkel, aaron.ballman, rsmith. lebedev.ri added a project: clang. lebedev.ri added a parent revision: D73005: [Codegen] If reasonable, materialize clang's `AssumeAlignedAttr` as llvm's Alignment Attribute on

[PATCH] D73005: [Codegen] If reasonable, materialize clang's `AssumeAlignedAttr` as llvm's Alignment Attribute on call-site function return value

lebedev.ri created this revision. lebedev.ri added reviewers: erichkeane, jdoerfert, hfinkel, aaron.ballman, rsmith. lebedev.ri added a project: clang. lebedev.ri added a child revision: D73006: [Codegen] If reasonable, materialize clang's `AllocAlignAttr` as llvm's Alignment Attribute on

[PATCH] D71018: [ASTImporter] Improved import of TypeSourceInfo (TypeLoc)

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. The patch looks good. Thanks! I would prefer to see more tests for other TypeLoc cases, but I think they could be added in the following patches. @shafik Shafik, do you have any

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72982/new/ https://reviews.llvm.org/D72982

[clang] 70b53a3 - Fix gcc `-Wunused-variable` warning. NFC.

Author: Michael Liao Date: 2020-01-19T12:24:21-05:00 New Revision: 70b53a301888fe2be36996b41a7dd5aa7c256dc9 URL: https://github.com/llvm/llvm-project/commit/70b53a301888fe2be36996b41a7dd5aa7c256dc9 DIFF: https://github.com/llvm/llvm-project/commit/70b53a301888fe2be36996b41a7dd5aa7c256dc9.diff

[PATCH] D72998: [IR] Attribute/AttrBuilder: use Value::MaximumAlignment magic constant

lebedev.ri added a comment. In D72998#1828559 , @hfinkel wrote: > Can we, at least, put this constant in a header file so we don't repeat it in > several places? Remember, we can't use `llvm::Value::MaximumAlignment` itself in clang sema. Which header

[PATCH] D72998: [IR] Attribute/AttrBuilder: use Value::MaximumAlignment magic constant

hfinkel added a comment. Can we, at least, put this constant in a header file so we don't repeat it in several places? Also, can we write it as 0x2000 so that it's more obvious what the value is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. I need you to rebase this fix, also you need to clang-format it as well. Format.h/ContinuationIndenter.cpp and FormatTestObjC.cpp all failed clang-format check

[PATCH] D72793: [clang-format] Expand the SpacesAroundConditions option to include catch statements

This revision was automatically updated to reflect the committed changes. Closed by commit rGea2be452542c: [clang-format] Expand the SpacesAroundConditions option to include catch… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ea2be45 - [clang-format] Expand the SpacesAroundConditions option to include catch statements

Author: mydeveloperday Date: 2020-01-19T15:56:04Z New Revision: ea2be452542c81b04621e26c0d5e83be565f07e2 URL: https://github.com/llvm/llvm-project/commit/ea2be452542c81b04621e26c0d5e83be565f07e2 DIFF: https://github.com/llvm/llvm-project/commit/ea2be452542c81b04621e26c0d5e83be565f07e2.diff

[PATCH] D72276: [clang-format] Add IndentCaseBlocks option

This revision was automatically updated to reflect the committed changes. Closed by commit rG14c044756e77: [clang-format] Add IndentCaseBlocks option (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D72276?vs=236740=238992#toc Repository: rG LLVM Github

[clang] 14c0447 - [clang-format] Add IndentCaseBlocks option

Author: mydeveloperday Date: 2020-01-19T15:52:26Z New Revision: 14c044756e771eb9160d5809b4381bdeb0fc210c URL: https://github.com/llvm/llvm-project/commit/14c044756e771eb9160d5809b4381bdeb0fc210c DIFF: https://github.com/llvm/llvm-project/commit/14c044756e771eb9160d5809b4381bdeb0fc210c.diff

[PATCH] D72150: Allow space after C-style cast in C# code

This revision was automatically updated to reflect the committed changes. Closed by commit rGd82adf328fb5: Allow space after C-style cast in C# code (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D72150?vs=236048=238991#toc Repository: rG LLVM Github

[clang] d82adf3 - Allow space after C-style cast in C# code

Author: mydeveloperday Date: 2020-01-19T15:41:40Z New Revision: d82adf328fb556e1e6d318608b683824c8badf22 URL: https://github.com/llvm/llvm-project/commit/d82adf328fb556e1e6d318608b683824c8badf22 DIFF: https://github.com/llvm/llvm-project/commit/d82adf328fb556e1e6d318608b683824c8badf22.diff

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

aganea added a comment. @wenlei Taking a look now. @hans I remember now why I was re-entering main() in the first iteration of this path. Response files were one reason. And handling /MP was another, which triggers the re-entrance twice (once for CL driver, and once for cc1). Repository: rG

[clang] 46be168 - fix doc typos to cycle bots

Author: Nico Weber Date: 2020-01-19T09:51:25-05:00 New Revision: 46be16897706fa21ac0868746291444ca2461ce7 URL: https://github.com/llvm/llvm-project/commit/46be16897706fa21ac0868746291444ca2461ce7 DIFF: https://github.com/llvm/llvm-project/commit/46be16897706fa21ac0868746291444ca2461ce7.diff

[PATCH] D72998: [IR] Attribute/AttrBuilder: use Value::MaximumAlignment magic constant

lebedev.ri created this revision. lebedev.ri added reviewers: erichkeane, hfinkel, jdoerfert, gchatelet, courbet. lebedev.ri added a project: LLVM. Herald added subscribers: cfe-commits, hiraditya. Herald added a project: clang. lebedev.ri added a parent revision: D72996: [Sema] Attempt to perform

[PATCH] D72793: [clang-format] Expand the SpacesAroundConditions option to include catch statements

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72793/new/ https://reviews.llvm.org/D72793

[PATCH] D72996: [Sema] Attempt to perform call-size-specific `__attribute__((alloc_align(param_idx)))` validation

lebedev.ri created this revision. lebedev.ri added reviewers: erichkeane, aaron.ballman, hfinkel, rsmith, jdoerfert. lebedev.ri added a project: LLVM. Herald added a project: clang. Herald added a subscriber: cfe-commits. lebedev.ri added a parent revision: D72994: [Sema] Sanity-check alignment

[PATCH] D72994: [Sema] Sanitize alignment requested via `__attribute__((assume_aligned(imm)))`

lebedev.ri created this revision. lebedev.ri added reviewers: erichkeane, aaron.ballman, hfinkel, rsmith, jdoerfert. lebedev.ri added a project: LLVM. Herald added a project: clang. Herald added a subscriber: cfe-commits. lebedev.ri added a parent revision: D72993: [NFC][Codegen] Use MaybeAlign +

[PATCH] D72993: [NFC][Codegen] Use MaybeAlign + APInt::getLimitedValue() when creating Alignment attr

lebedev.ri created this revision. lebedev.ri added reviewers: erichkeane, gchatelet, courbet, jdoerfert. lebedev.ri added a project: clang. lebedev.ri added a parent revision: D72979: [Codegen] Emit both AssumeAlignedAttr and AllocAlignAttr assumptions if they exist. Just an NFC code cleanup i