[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

2020-01-21 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff added a comment. I don't see tests for correctness of the pragma stack (`pragma float_control(... push)`, `pragma float_control(pop)`). Can you add them? Comment at: clang/lib/Parse/ParsePragma.cpp:2537 +if (!Actions.CurContext->isTranslationUnit()) { +//FIXME

[PATCH] D72829: Implement -fsemantic-interposition

2020-01-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D72829#1831017 , @serge-sans-paille wrote: > > Linkages which were not interposable before and can be interposable now: > > available_externally, linkonce_odr, weak_odr, external, and appending. > > @MaskRay I understand the

[PATCH] D72703: Add a warning, flags and pragmas to limit the number of pre-processor tokens in a translation unit

2020-01-21 Thread Kim Gräsman via Phabricator via cfe-commits
kimgr added a comment. I just want to say that finding the correlation between token count and compile time is a bit of a breakthrough! Could you expose a flag for printing token count so users can run their own analysis? Or does that already exist in baseline clang? It's easier to set a

[PATCH] D73090: [clang-tidy] Fix PR#44528 'modernize-use-using and enums'

2020-01-21 Thread Karasev Nikita via Phabricator via cfe-commits
f00kat updated this revision to Diff 239491. f00kat added a comment. Add new line in the end of file checkers/modernize-use-using.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73090/new/ https://reviews.llvm.org/D73090 Files:

[clang] b54aa05 - Update clang-interpreter example to incorporate changes in ce2207abaf9.

2020-01-21 Thread Lang Hames via cfe-commits
Author: Lang Hames Date: 2020-01-21T22:00:50-08:00 New Revision: b54aa053d3aeeab0cdaecb6286419138b7da5ef4 URL: https://github.com/llvm/llvm-project/commit/b54aa053d3aeeab0cdaecb6286419138b7da5ef4 DIFF: https://github.com/llvm/llvm-project/commit/b54aa053d3aeeab0cdaecb6286419138b7da5ef4.diff

[PATCH] D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

2020-01-21 Thread Michał Górny via Phabricator via cfe-commits
mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Well, it looks correct to me. Not sure if it's the best approach but it can be refined in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

2020-01-21 Thread Tom Stellard via Phabricator via cfe-commits
tstellar added a comment. Ping. This bug is preventing upstream projects from using libclang-cpp.so, since building with -DENABLE_SHARED=ON is still common. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68520/new/ https://reviews.llvm.org/D68520

[clang] c38e425 - [clang][IFS][test] Temporary work around for in-process cc1 ASAN issues.

2020-01-21 Thread Puyan Lotfi via cfe-commits
Author: Puyan Lotfi Date: 2020-01-21T22:56:20-05:00 New Revision: c38e42527b21acee8d01a016d5bfa2fb83202e29 URL: https://github.com/llvm/llvm-project/commit/c38e42527b21acee8d01a016d5bfa2fb83202e29 DIFF: https://github.com/llvm/llvm-project/commit/c38e42527b21acee8d01a016d5bfa2fb83202e29.diff

[PATCH] D73156: [clang] Build clang-shlib on mingw

2020-01-21 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62088 tests passed, 0 failed and 784 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73156: [clang] Build clang-shlib on mingw

2020-01-21 Thread Valentin Churavy via Phabricator via cfe-commits
vchuravy added a comment. Some additional context. We [Julia] is cross-compiling LLVM from Linux to mingw32 as part of an automatic buildsystem for our binary dependencies. The corresponding PR is https://github.com/JuliaPackaging/Yggdrasil/pull/417 Repository: rG LLVM Github Monorepo

[PATCH] D65042: [Concept] Placeholder constraints and abbreviated templates

2020-01-21 Thread Jonas Devlieghere via Phabricator via cfe-commits
JDevlieghere added a comment. Hey Saar, I have temporarily reverted this because it broke the LLDB bots. Please run the LLDB test suite when you make changes to the AST importer & keep an eye on the bots when you re-land this. Thanks! commit 62e4b501ab3bc4c5815a179fdd2c4b49574506c1 (HEAD ->

[PATCH] D72747: [objc_direct] Allow for direct messages be sent to `self` when it is a Class

2020-01-21 Thread Pierre Habouzit via Phabricator via cfe-commits
MadCoder updated this revision to Diff 239477. MadCoder added a comment. fixed @ahatanak feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72747/new/ https://reviews.llvm.org/D72747 Files: clang/lib/Sema/SemaExprObjC.cpp clang/test/SemaObjC/method-direct-arc.m Index:

[PATCH] D73156: [clang] Build clang-shlib on mingw

2020-01-21 Thread Valentin Churavy via Phabricator via cfe-commits
vchuravy created this revision. Herald added subscribers: cfe-commits, mstorsjo, mgorny. Herald added a project: clang. vchuravy added a reviewer: tstellar. vchuravy added a comment. Some additional context. We [Julia] is cross-compiling LLVM from Linux to mingw32 as part of an automatic

[PATCH] D72552: [Concepts] Constraint Satisfaction Caching

2020-01-21 Thread Jonas Devlieghere via Phabricator via cfe-commits
JDevlieghere added a comment. In D72552#1832875 , @JDevlieghere wrote: > It looks like the concept changes broke the debugger (quite spectacularly > actually): > > http://lab.llvm.org:8011/builders/lldb-x86_64-debian/builds/3356 >

[PATCH] D72552: [Concepts] Constraint Satisfaction Caching

2020-01-21 Thread Jonas Devlieghere via Phabricator via cfe-commits
JDevlieghere added a comment. It looks like the concept changes broke the debugger (quite spectacularly actually): http://lab.llvm.org:8011/builders/lldb-x86_64-debian/builds/3356 http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/12872

[PATCH] D72996: [Sema] Attempt to perform call-size-specific `__attribute__((alloc_align(param_idx)))` validation

2020-01-21 Thread Hal Finkel via Phabricator via cfe-commits
hfinkel added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4489 +// Alignment calculations can wrap around if it's greater than 2**29. +unsigned MaximumAlignment = 536870912; +if (I > MaximumAlignment) jdoerfert wrote: >

[PATCH] D73155: [Concepts] Implement P1616R1 - Using unconstrained template template parameters with constrained templates

2020-01-21 Thread Saar Raz via Phabricator via cfe-commits
saar.raz created this revision. saar.raz added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Allow unconstrained template template parameters to accept constrainted templates as arguments. Repository: rG LLVM Github Monorepo

[PATCH] D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`.

2020-01-21 Thread Jan Korous via Phabricator via cfe-commits
jkorous added inline comments. Comment at: clang/test/Frontend/verify-any-file.c:1 +// RUN: %clang_cc1 -verify %s 2>&1 + I feel that we should test the output with FileCheck to make it more robust. Seems like other tests for `-verify` do that. For example here:

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

2020-01-21 Thread Francis Visoiu Mistrih via Phabricator via cfe-commits
thegameg added a comment. In D71301#1832801 , @plotfi wrote: > So, the culprit appears to be D69825 . The > way InterfaceStubs assembles the pipeline appears to trigger an asan bug. For > now I will alter the tests to

[clang] bb9b964 - [Concepts] Fix circular AST->Sema dependency in ASTConcept.cpp

2020-01-21 Thread Saar Raz via cfe-commits
Author: Saar Raz Date: 2020-01-22T04:08:59+02:00 New Revision: bb9b964072eb42a09e76fe148b36eefcfff077b2 URL: https://github.com/llvm/llvm-project/commit/bb9b964072eb42a09e76fe148b36eefcfff077b2 DIFF: https://github.com/llvm/llvm-project/commit/bb9b964072eb42a09e76fe148b36eefcfff077b2.diff

[PATCH] D72972: [WebAssembly] Add experimental multivalue calling ABI

2020-01-21 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:741 + explicit WebAssemblyABIInfo(CodeGen::CodeGenTypes , ABIKind _Kind) + : SwiftABIInfo(CGT), defaultInfo(CGT), Kind(_Kind) {} Nit: Do we need `_`? Comment

[PATCH] D73150: [Concepts] Remove -fconcepts-ts, enable concepts support under -std=c++2a

2020-01-21 Thread Saar Raz via Phabricator via cfe-commits
saar.raz updated this revision to Diff 239472. saar.raz added a comment. Readd -fconcepts-ts for deprecation diagnostic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73150/new/ https://reviews.llvm.org/D73150 Files:

[PATCH] D72552: [Concepts] Constraint Satisfaction Caching

2020-01-21 Thread Richard Trieu via Phabricator via cfe-commits
rtrieu added inline comments. Comment at: clang/lib/AST/ASTConcept.cpp:17 #include "clang/AST/ASTContext.h" +#include "clang/Sema/SemaConcept.h" using namespace clang; This causes a circular dependency between AST and Sema. It looks like you are including

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

2020-01-21 Thread Puyan Lotfi via Phabricator via cfe-commits
plotfi added a comment. So, the culprit appears to be D69825 . The way InterfaceStubs assembles the pipeline appears to trigger an asan bug. For now I will alter the tests to get the bots green, but once I get my bugzilla access sorted I intend to file a bug.

[PATCH] D73151: [analyzer] Fix handle leak false positive when the handle dies too early

2020-01-21 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun updated this revision to Diff 239469. xazax.hun added a comment. - Minor refactoring. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73151/new/ https://reviews.llvm.org/D73151 Files: clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp

[PATCH] D73153: [Concepts] Update ReleaseNotes with Concepts support

2020-01-21 Thread Saar Raz via Phabricator via cfe-commits
saar.raz created this revision. saar.raz added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update Clang 10 release notes with news of Concepts support. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73153 Files:

[PATCH] D73151: [analyzer] Fix handle leak false positive when the handle dies too early

2020-01-21 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun created this revision. xazax.hun added reviewers: NoQ, haowei. xazax.hun added a project: clang. Herald added subscribers: Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. In case the handle symbol dies too early,

[PATCH] D72996: [Sema] Attempt to perform call-size-specific `__attribute__((alloc_align(param_idx)))` validation

2020-01-21 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4489 +// Alignment calculations can wrap around if it's greater than 2**29. +unsigned MaximumAlignment = 536870912; +if (I > MaximumAlignment) hfinkel wrote: >

[PATCH] D73150: [Concepts] Remove -fconcepts-ts, enable concepts support under -std=c++2a

2020-01-21 Thread Saar Raz via Phabricator via cfe-commits
saar.raz created this revision. saar.raz added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Enable concepts support under normal -std=c++2a and not under -fconcepts-ts, which is now deprecated. Repository: rG LLVM Github Monorepo

[PATCH] D72552: [Concepts] Constraint Satisfaction Caching

2020-01-21 Thread Saar Raz via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb933d37cd377: [Concepts] Constraint Satisfaction Caching (authored by saar.raz). Changed prior to commit: https://reviews.llvm.org/D72552?vs=237474=239464#toc Repository: rG LLVM Github Monorepo

[PATCH] D69933: [ASTImporter] Limit imports of structs

2020-01-21 Thread Greg Clayton via Phabricator via cfe-commits
clayborg added a comment. Clang AST contexts know how to complete types and is done via the external AST source code that will ask a type to complete itself. Each object file has an AST that knows how to lazily complete a type when and only when it is needed. Each object file also only knows

[clang] b933d37 - [Concepts] Constraint Satisfaction Caching

2020-01-21 Thread Saar Raz via cfe-commits
Author: Saar Raz Date: 2020-01-22T03:09:53+02:00 New Revision: b933d37cd3774e5431b35e82187eebb59b1ff59e URL: https://github.com/llvm/llvm-project/commit/b933d37cd3774e5431b35e82187eebb59b1ff59e DIFF: https://github.com/llvm/llvm-project/commit/b933d37cd3774e5431b35e82187eebb59b1ff59e.diff

[PATCH] D69868: Allow "callbr" to return non-void values

2020-01-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D69868#1832559 , @void wrote: > @jyknight Do you think you'll have time to review this patch this week? I'd > like to get it into the 10.0 release if possible. :-) I volunteer as a reviewer:) Repository: rG LLVM Github

[clang] a156da5 - [clang/Darwin] Remove __llvm_profile_counter_bias from export list for profiling

2020-01-21 Thread Vedant Kumar via cfe-commits
Author: Vedant Kumar Date: 2020-01-21T16:52:01-08:00 New Revision: a156da5fb361fd38ba379ec20856626c9e35f829 URL: https://github.com/llvm/llvm-project/commit/a156da5fb361fd38ba379ec20856626c9e35f829 DIFF: https://github.com/llvm/llvm-project/commit/a156da5fb361fd38ba379ec20856626c9e35f829.diff

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

2020-01-21 Thread Kanglei Fang via Phabricator via cfe-commits
ghvg1313 updated this revision to Diff 239458. ghvg1313 added a comment. - rebase master - formatting code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70926/new/ https://reviews.llvm.org/D70926 Files: clang/docs/ClangFormatStyleOptions.rst

[clang-tools-extra] 5fdad8e - [clang-tidy] Fix check for generic lambda invented template parameters

2020-01-21 Thread Saar Raz via cfe-commits
Author: Saar Raz Date: 2020-01-22T02:46:39+02:00 New Revision: 5fdad8e3f803adce501ca25118f325184e54018d URL: https://github.com/llvm/llvm-project/commit/5fdad8e3f803adce501ca25118f325184e54018d DIFF: https://github.com/llvm/llvm-project/commit/5fdad8e3f803adce501ca25118f325184e54018d.diff

[PATCH] D72552: [Concepts] Constraint Satisfaction Caching

2020-01-21 Thread David Stone via Phabricator via cfe-commits
david_stone added a comment. In D72552#1832293 , @rsmith wrote: > Mechanically, this looks fine. > > There's an ongoing discussion in the committee as to whether this kind of > caching is permissible. But if this is necessary for acceptable performance,

[PATCH] D72703: Add a warning, flags and pragmas to limit the number of pre-processor tokens in a translation unit

2020-01-21 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. I waited to see if there was any other feedback, but I'm in favor of this. Should we try to come up with better pragma names? `clang max_tokens` doesn't seem to call to mind what it does: warn if there have been more than this many tokens so far in the translation unit.

[PATCH] D72996: [Sema] Attempt to perform call-size-specific `__attribute__((alloc_align(param_idx)))` validation

2020-01-21 Thread Hal Finkel via Phabricator via cfe-commits
hfinkel added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4489 +// Alignment calculations can wrap around if it's greater than 2**29. +unsigned MaximumAlignment = 536870912; +if (I > MaximumAlignment) jdoerfert wrote: >

[clang] 6e73fee - List implicit operator== after implicit destructors in a vtable.

2020-01-21 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-01-21T15:54:40-08:00 New Revision: 6e73fee780839bfa95aff492864e93e79910380b URL: https://github.com/llvm/llvm-project/commit/6e73fee780839bfa95aff492864e93e79910380b DIFF: https://github.com/llvm/llvm-project/commit/6e73fee780839bfa95aff492864e93e79910380b.diff

[PATCH] D72897: List implicit operator== after implicit destructors in a vtable.

2020-01-21 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In D72897#1832234 , @vvereschaka wrote: > Hi Richard, > > http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l builder has been > broken by this patch during few days (failed "Clang::virtual-compare.cpp" > test). > Sorry,

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

2020-01-21 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. @kkwli0 I propose you can merge the parts where discussion has reached a consensus while the other parts are resolved. I'm generally fine with this, we can always improve on it further. Comment at: clang/docs/OpenMPSupport.rst:194

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

2020-01-21 Thread Mitch Phillips via Phabricator via cfe-commits
hctim added a comment. In D69825#1831691 , @plotfi wrote: > In the meantime I could -fno-integrated-cc1 the driver.c InterfaceStubs > tests to quite the bots if that is what people want (and file a bug on > bugzilla). Yes, please. A temporary

[PATCH] D72996: [Sema] Attempt to perform call-size-specific `__attribute__((alloc_align(param_idx)))` validation

2020-01-21 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4489 +// Alignment calculations can wrap around if it's greater than 2**29. +unsigned MaximumAlignment = 536870912; +if (I > MaximumAlignment) erichkeane wrote:

[PATCH] D69868: Allow "callbr" to return non-void values

2020-01-21 Thread Bill Wendling via Phabricator via cfe-commits
void added a comment. @jyknight Do you think you'll have time to review this patch this week? I'd like to get it into the 10.0 release if possible. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69868/new/ https://reviews.llvm.org/D69868

[PATCH] D73005: [Codegen] If reasonable, materialize clang's `AssumeAlignedAttr` as llvm's Alignment Attribute on call-site function return value

2020-01-21 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri marked 2 inline comments as done. lebedev.ri added inline comments. Comment at: clang/test/CodeGen/assume-aligned-and-alloc-align-attributes.c:12 // CHECK-NEXT:[[MASKCOND:%.*]] = icmp eq i64 [[MASKEDPTR]], 0 // CHECK-NEXT:call void @llvm.assume(i1

[PATCH] D73005: [Codegen] If reasonable, materialize clang's `AssumeAlignedAttr` as llvm's Alignment Attribute on call-site function return value

2020-01-21 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added inline comments. Comment at: clang/test/CodeGen/assume-aligned-and-alloc-align-attributes.c:12 // CHECK-NEXT:[[MASKCOND:%.*]] = icmp eq i64 [[MASKEDPTR]], 0 // CHECK-NEXT:call void @llvm.assume(i1 [[MASKCOND]]) // CHECK-NEXT:ret i8* [[CALL]]

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

2020-01-21 Thread Brian Gesiak via Phabricator via cfe-commits
modocache updated this revision to Diff 239437. modocache added a comment. Rebase past D72547 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71903/new/ https://reviews.llvm.org/D71903 Files:

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

2020-01-21 Thread Nathan James via Phabricator via cfe-commits
njames93 marked an inline comment as done. njames93 added a comment. In D73098#1832131 , @Mordante wrote: > Would it make sense to also allow wmain with wchar_t? > https://docs.microsoft.com/en-us/cpp/cpp/main-function-command-line-args?view=vs-2019

[PATCH] D73140: [clangd] Add C++20 concepts support to TargetFinder

2020-01-21 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62082 tests passed, 0 failed and 784 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

2020-01-21 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea added a comment. In D72982#1832233 , @aganea wrote: > In D72982#1832209 , @phosek wrote: > > > We're seeing `Driver/cc-print-options.c` test failures after this change: > > > Yes, seeing it too, I will

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

2020-01-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:2703-2704 // suggest the const reference type that would do so. // For instance, given "for (const : Range)", suggest // "for (const Foo : Range)" to denote a copy is made for the loop. If //

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

2020-01-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:474 if (const auto *Decl = dyn_cast(D)) { +if (isParamInMainLikeFunction(*Decl)) + return SK_Invalid; I think a better approach may

[PATCH] D73140: [clangd] Add C++20 concepts support to TargetFinder

2020-01-21 Thread Nathan Ridge via Phabricator via cfe-commits
nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73140 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D72434: Support offset of member designator with the arrow for __builtin_offsetof

2020-01-21 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. Testcase? I assume we give appropriate errors if you try to use "->" on a member that's not an array? Comment at: clang/lib/Parse/ParseExpr.cpp:2168 -// FIXME: This loop leaks the index expressions on error. while (1) {

[clang] 133a7e6 - [PATCH] Reland [Clang] Un-break scan-build after integrated-cc1 change

2020-01-21 Thread Alexandre Ganea via cfe-commits
Author: Alexandre Ganea Date: 2020-01-21T17:03:00-05:00 New Revision: 133a7e631cee97965e310f0d110739217427fd3d URL: https://github.com/llvm/llvm-project/commit/133a7e631cee97965e310f0d110739217427fd3d DIFF:

[PATCH] D71566: New checks for fortified sprintf

2020-01-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. (There are still some minor whitespace nits to resolve as well.) Comment at: clang/lib/Sema/SemaChecking.cpp:743 + } + assert(UsedSize && "Found a size estimate"); + if (UsedSize.getValue().ule(ObjectSize)) I think this

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

2020-01-21 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson marked 5 inline comments as done. tejohnson added inline comments. Comment at: clang/test/CodeGenCXX/lto-visibility-inference.cpp:73 c1->f(); - // ITANIUM-NOT: type.test{{.*}}!"_ZTS2C2" + // ITANIUM: type.test{{.*}}!"_ZTS2C2" // MS: type.test{{.*}}!"?AUC2@@"

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

2020-01-21 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson updated this revision to Diff 239428. tejohnson marked 2 inline comments as done. tejohnson added a comment. Address comments and rebase. Also apply modified change to ItaniumCXXABI.cpp and a change to an associated test (cfi-mfcall.cpp) here as discussed in child revision D71907

[PATCH] D72747: [objc_direct] Allow for direct messages be sent to `self` when it is a Class

2020-01-21 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. Please add a test that exercises path without ARC enabled. Comment at: clang/lib/Sema/SemaExprObjC.cpp:3019 +if (ReceiverType->isObjCClassType() && !isImplicit && +(!Receiver->isObjCSelfExpr() || !getLangOpts().ObjCAutoRefCount)) {

[PATCH] D61365: [libcxx] [test] Suppress float->int narrowing warning in vector range-construction test.

2020-01-21 Thread Billy Robert O'Neal III via Phabricator via cfe-commits
BillyONeal abandoned this revision. BillyONeal added a comment. It looks like someone already fixed this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61365/new/ https://reviews.llvm.org/D61365 ___ cfe-commits mailing list

[PATCH] D72717: [CMake] Disable libc++ filesystem tests in CrossWinToARMLinux cache file

2020-01-21 Thread Vlad Vereschaka via Phabricator via cfe-commits
vvereschaka added a comment. > You mean, instead of ninja check-cxx just invoke LIT directly and pass this > argument? No, a little bit different. Probably we need something like 'LIBCXX_LLVM_LIT_ARGS` and pass the LIT arguments into the libc++ tests through that kind of parameter (and most

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

2020-01-21 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15442-15443 + CurComponents.emplace_back(CurE, nullptr); +} else if (auto *CurE = dyn_cast(E)) { + E = CurE->getLHS()->IgnoreParenImpCasts(); } else { cchen wrote: >

[PATCH] D73138: [libcxx] [test] Correct asserted type in subspan test; subspan with count should never produce dynamic_extent

2020-01-21 Thread Billy Robert O'Neal III via Phabricator via cfe-commits
BillyONeal created this revision. BillyONeal added reviewers: ldionne, EricWF, mclow.lists. Herald added subscribers: dexonsmith, christof. I'm not sure if this was a change in the standard behavior or if it was a typo in libcxx from the beginning. http://eel.is/c++draft/span.sub#10 says that if

[PATCH] D72998: [IR] Attribute/AttrBuilder: use Value::MaximumAlignment magic constant

2020-01-21 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri updated this revision to Diff 239421. lebedev.ri added a comment. Add constants to `Sema` class. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72998/new/ https://reviews.llvm.org/D72998 Files: clang/include/clang/Sema/Sema.h

[PATCH] D73120: [Clang] Alternate fix for "expansion of response files in -Wp after integrated-cc1 change"

2020-01-21 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea updated this revision to Diff 239420. aganea added a comment. Remove `Reenter` flag as requested by @hans here . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73120/new/ https://reviews.llvm.org/D73120 Files:

[PATCH] D72996: [Sema] Attempt to perform call-size-specific `__attribute__((alloc_align(param_idx)))` validation

2020-01-21 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri marked an inline comment as done. lebedev.ri added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4479 +const Expr *Arg = Args[AA->getParamIndex().getASTIndex()]; +if (!Arg->isTypeDependent() && !Arg->isValueDependent()) { + llvm::APSInt

[PATCH] D72996: [Sema] Attempt to perform call-size-specific `__attribute__((alloc_align(param_idx)))` validation

2020-01-21 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4489 +// Alignment calculations can wrap around if it's greater than 2**29. +unsigned MaximumAlignment = 536870912; +if (I > MaximumAlignment) jdoerfert wrote:

[PATCH] D73060: [Clang] Fix expansion of response files in -Wp after integrated-cc1 change

2020-01-21 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea abandoned this revision. aganea added a comment. Abandoning this in favor of D73120 . Please take a look at the other patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73060/new/

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

2020-01-21 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15442-15443 + CurComponents.emplace_back(CurE, nullptr); +} else if (auto *CurE = dyn_cast(E)) { + E = CurE->getLHS()->IgnoreParenImpCasts(); } else

[PATCH] D72552: [Concepts] Constraint Satisfaction Caching

2020-01-21 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Mechanically, this looks fine. There's an ongoing discussion in the committee as to whether this kind of caching is permissible. But if this is necessary for acceptable performance, let's

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

2020-01-21 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15442-15443 + CurComponents.emplace_back(CurE, nullptr); +} else if (auto *CurE = dyn_cast(E)) { + E = CurE->getLHS()->IgnoreParenImpCasts(); } else

[clang] 89e43f0 - Revert "List implicit operator== after implicit destructors in a vtable."

2020-01-21 Thread Vladimir Vereschaka via cfe-commits
Author: Vladimir Vereschaka Date: 2020-01-21T13:07:56-08:00 New Revision: 89e43f04ba87a0da6e94863db149669c7536486b URL: https://github.com/llvm/llvm-project/commit/89e43f04ba87a0da6e94863db149669c7536486b DIFF:

[clang] b0b2b7e - Revert "[Clang] Un-break scan-build after integrated-cc1 change"

2020-01-21 Thread Alexandre Ganea via cfe-commits
Author: Alexandre Ganea Date: 2020-01-21T16:06:36-05:00 New Revision: b0b2b7e09926cdde4d82978a7c14b5e2d38db35c URL: https://github.com/llvm/llvm-project/commit/b0b2b7e09926cdde4d82978a7c14b5e2d38db35c DIFF:

[clang] a8c2f76 - Removing an accidentally duplicated line of test code to fix bots.

2020-01-21 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2020-01-21T16:03:22-05:00 New Revision: a8c2f76cd258ea03f82a1fc12953ca8af6b7832b URL: https://github.com/llvm/llvm-project/commit/a8c2f76cd258ea03f82a1fc12953ca8af6b7832b DIFF: https://github.com/llvm/llvm-project/commit/a8c2f76cd258ea03f82a1fc12953ca8af6b7832b.diff

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

2020-01-21 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15442-15443 + CurComponents.emplace_back(CurE, nullptr); +} else if (auto *CurE = dyn_cast(E)) { + E = CurE->getLHS()->IgnoreParenImpCasts(); } else { cchen wrote: >

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

2020-01-21 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea added a comment. In D72982#1832209 , @phosek wrote: > We're seeing `Driver/cc-print-options.c` test failures after this change: Yes, seeing it too, I will commit a fix in a minute! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D72897: List implicit operator== after implicit destructors in a vtable.

2020-01-21 Thread Vlad Vereschaka via Phabricator via cfe-commits
vvereschaka added a comment. Hi Richard, http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l builder has been broken by this patch during few days (failed "Clang::virtual-compare.cpp" test). Sorry, but I'm going to revert these changes. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D71911: [ThinLTO] Summarize vcall_visibility metadata

2020-01-21 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson updated this revision to Diff 239412. tejohnson added a comment. Address comment and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71911/new/ https://reviews.llvm.org/D71911 Files:

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

2020-01-21 Thread Melanie Blower via Phabricator via cfe-commits
mibintc marked 5 inline comments as done. mibintc added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:13129 if (FunctionDecl *F = dyn_cast(CurContext)) { + // If the expression occurs inside an internal global_var_init_function + // then the

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

2020-01-21 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. We're seeing `Driver/cc-print-options.c` test failures after this change: TEST 'Clang :: Driver/cc-print-options.c' FAILED Script: -- : 'RUN: at line 1'; env CC_PRINT_OPTIONS=1

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

2020-01-21 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15442-15443 + CurComponents.emplace_back(CurE, nullptr); +} else if (auto *CurE = dyn_cast(E)) { + E = CurE->getLHS()->IgnoreParenImpCasts(); } else

[PATCH] D72635: Allow arbitrary capability name in Thread Safety Analysis

2020-01-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. In D72635#1831782 , @eti-p-doray wrote: > Thanks! > I don't I have commit access. Can you commit on my behalf? Happy to do so! I've commit on your behalf in

[clang] 5260bc2 - Allow arbitrary capability name in Thread Safety Analysis

2020-01-21 Thread Aaron Ballman via cfe-commits
Author: Etienne Pierre-Doray Date: 2020-01-21T15:43:17-05:00 New Revision: 5260bc2497bb593ed4a01de5cfe84ed6f7b529b1 URL: https://github.com/llvm/llvm-project/commit/5260bc2497bb593ed4a01de5cfe84ed6f7b529b1 DIFF:

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

2020-01-21 Thread Melanie Blower via Phabricator via cfe-commits
mibintc updated this revision to Diff 239409. mibintc added a comment. Respond to review from @sepavloff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72841/new/ https://reviews.llvm.org/D72841 Files: clang/docs/LanguageExtensions.rst

[PATCH] D73072: [Driver][CodeGen] Support -fpatchable-function-entry=N,M where M>0

2020-01-21 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62081 tests passed, 2 failed and 784 were skipped. failed: Clang.Driver/cc-print-options.c failed: Clang.Driver/fpatchable-function-entry.c {icon question-circle color=gray} clang-tidy: unknown. {icon

[PATCH] D72874: [clangd] Add a textual fallback for go-to-definition

2020-01-21 Thread Nathan Ridge via Phabricator via cfe-commits
nridge planned changes to this revision. nridge added a comment. Thanks for taking a look! In D72874#1831977 , @sammccall wrote: > - it triggers on almost every word, even words that plainly don't refer to > any decl like `format [[lazily]], in case

[PATCH] D71907: [WPD/VFE] Always emit vcall_visibility metadata for -fwhole-program-vtables

2020-01-21 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson updated this revision to Diff 239406. tejohnson added a comment. Remove stale change that didn't belong here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71907/new/ https://reviews.llvm.org/D71907 Files:

[PATCH] D71907: [WPD/VFE] Always emit vcall_visibility metadata for -fwhole-program-vtables

2020-01-21 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson marked an inline comment as done. tejohnson added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:676 + bool ShouldEmitWPDInfo = CGM.getCodeGenOpts().WholeProgramVTables && + CGM.HasHiddenLTOVisibility(RD); llvm::Value

[PATCH] D72484: [clang-tidy] Fix check for Abseil internal namespace access

2020-01-21 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF closed this revision. EricWF added a comment. Committed in 020ed6713d889a95f8c98d7725c87b458d99f6b3 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72484/new/ https://reviews.llvm.org/D72484

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

2020-01-21 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert added a comment. I also still think that `warn_for_range_copy` //should be// emitted even in templates. These aren't false positives in my opinion, especially since we're now pretty conservative about that warning. Comment at:

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

2020-01-21 Thread Mark de Wever via Phabricator via cfe-commits
Mordante added a comment. Would it make sense to also allow wmain with wchar_t? https://docs.microsoft.com/en-us/cpp/cpp/main-function-command-line-args?view=vs-2019 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73098/new/

[clang-tools-extra] 020ed67 - [clang-tidy] Fix check for Abseil internal namespace access

2020-01-21 Thread Eric Fiselier via cfe-commits
Author: Eric Fiselier Date: 2020-01-21T15:21:53-05:00 New Revision: 020ed6713d889a95f8c98d7725c87b458d99f6b3 URL: https://github.com/llvm/llvm-project/commit/020ed6713d889a95f8c98d7725c87b458d99f6b3 DIFF: https://github.com/llvm/llvm-project/commit/020ed6713d889a95f8c98d7725c87b458d99f6b3.diff

[PATCH] D72996: [Sema] Attempt to perform call-size-specific `__attribute__((alloc_align(param_idx)))` validation

2020-01-21 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4489 +// Alignment calculations can wrap around if it's greater than 2**29. +unsigned MaximumAlignment = 536870912; +if (I > MaximumAlignment) erichkeane wrote:

[PATCH] D73128: [OPENMP][NVPTX]Add NVPTX specific definitions for new/delete operators.

2020-01-21 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62080 tests passed, 1 failed and 784 were skipped. failed: Clang.Driver/cc-print-options.c {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build

[PATCH] D73072: [Driver][CodeGen] Support -fpatchable-function-entry=N,M where M>0

2020-01-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 239400. MaskRay added a comment. Improve tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73072/new/ https://reviews.llvm.org/D73072 Files: clang/include/clang/Basic/AttrDocs.td

[clang] 41fcd17 - [Sema] Avoid Wrange-loop-analysis false positives

2020-01-21 Thread Mark de Wever via cfe-commits
Author: Mark de Wever Date: 2020-01-21T21:14:10+01:00 New Revision: 41fcd17250fa0526e4b7fd2c7df7721b0f79b683 URL: https://github.com/llvm/llvm-project/commit/41fcd17250fa0526e4b7fd2c7df7721b0f79b683 DIFF: https://github.com/llvm/llvm-project/commit/41fcd17250fa0526e4b7fd2c7df7721b0f79b683.diff

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

2020-01-21 Thread Mark de Wever via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Mordante marked an inline comment as done. Closed by commit rG41fcd17250fa: [Sema] Avoid Wrange-loop-analysis false positives (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72829: Implement -fsemantic-interposition

2020-01-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: llvm/lib/IR/Globals.cpp:101 +return true; + return isInterposableLinkage(getLinkage()); +} MaskRay wrote: > MaskRay wrote: > > Checking `isInterposableLinkage(getLinkage())` first may be more efficient. > `if

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

2020-01-21 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In D72982#1832058 , @xazax.hun wrote: > In D72982#1832029 , @aganea wrote: > > > In D72982#1832000 , @xazax.hun > > wrote: > > > > > Thanks!

  1   2   3   >