[PATCH] D73307: Unique Names for Functions with Internal Linkage

MaskRay added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp: + this->getFunctionLinkage(GD) == llvm::GlobalValue::InternalLinkage) { +std::string UniqueSuffix = getUniqueModuleId(&getModule(), true); +if (!UniqueSuffix.empty()) { --

[PATCH] D73219: [objc_direct] do not add direct properties to the serialization array

This revision was automatically updated to reflect the committed changes. MadCoder marked an inline comment as done. Closed by commit rG52311d0483ee: [objc_direct] do not add direct properties to the serialization array (authored by MadCoder). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D72747: [objc_direct] Allow for direct messages be sent to `self` when it is a Class

This revision was automatically updated to reflect the committed changes. Closed by commit rG7596d3c50c4b: [objc_direct] Allow for direct messages be sent to `self` when it is a Class (authored by MadCoder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] 52311d0 - [objc_direct] do not add direct properties to the serialization array

Author: Pierre Habouzit Date: 2020-01-23T22:39:47-08:00 New Revision: 52311d0483eecd60bdcc39dd3fb134f2412370f6 URL: https://github.com/llvm/llvm-project/commit/52311d0483eecd60bdcc39dd3fb134f2412370f6 DIFF: https://github.com/llvm/llvm-project/commit/52311d0483eecd60bdcc39dd3fb134f2412370f6.dif

[clang] 7596d3c - [objc_direct] Allow for direct messages be sent to `self` when it is a Class

Author: Pierre Habouzit Date: 2020-01-23T22:39:28-08:00 New Revision: 7596d3c50c4b265612d326369e2a015cf8c60801 URL: https://github.com/llvm/llvm-project/commit/7596d3c50c4b265612d326369e2a015cf8c60801 DIFF: https://github.com/llvm/llvm-project/commit/7596d3c50c4b265612d326369e2a015cf8c60801.dif

[PATCH] D72703: Add a warning, flags and pragmas to limit the number of pre-processor tokens in a translation unit

kimgr added a comment. In D72703#1834177 , @hans wrote: > I assume the same correlation could also be found with lines of code, but I > think tokens is a better dimension to measure since it's less likely to be > gamed, and it also is also kind of the ba

[PATCH] D73290: [PowerPC] Add clang -msvr4-struct-return for 32-bit ELF

markmi added a comment. Herald added a subscriber: wuzish. Summary: My preliminary testing looks good. FreeBSD does not have clang/test/ and clang/doc/ in its contrib/llvm-project/ so I applied just the other patches to my context and rebuilt my FreeBSD head -r356426 based context's clang/clang

[PATCH] D73208: [objc_direct] fix codegen for mismatched Decl/Impl return types

MadCoder added a comment. In D73208#1836789 , @dexonsmith wrote: > In D73208#1836722 , @MadCoder wrote: > > > In D73208#1836704 , @dexonsmith > > wrote: > > > > > In D73208#

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3381 + "constrained mode"); +FMulAdd = Builder.CreateCall( +CGF.CGM.getIntrinsic(llvm::Intrinsic::experimental_constrained_fmuladd, Doesn't this need to be Cr

[PATCH] D72906: [X86] Improve X86 cmpps/cmppd/cmpss/cmpsd intrinsics with strictfp

craig.topper added a comment. In D72906#1826849 , @uweigand wrote: > In D72906#1826122 , @craig.topper > wrote: > > > In D72906#1826061 , @uweigand > > wrote: > > > > > > T

[clang] d600ab3 - [Frontend] Delete some unneeded CC1 options

Author: Fangrui Song Date: 2020-01-23T22:01:04-08:00 New Revision: d600ab3bb51268b660e1ed62478d4bfa41294f54 URL: https://github.com/llvm/llvm-project/commit/d600ab3bb51268b660e1ed62478d4bfa41294f54 DIFF: https://github.com/llvm/llvm-project/commit/d600ab3bb51268b660e1ed62478d4bfa41294f54.diff

[PATCH] D72824: [X86] Add combination for fma and fneg on X86 under strict FP.

craig.topper added a comment. Are we missing tests for the vector instructions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72824/new/ https://reviews.llvm.org/D72824 ___ cfe-commits mailing list cfe

[clang] a2137d6 - [X86] Add -flax-vector-conversions=none to all of the x86 vector intrinsic header tests.

Author: Craig Topper Date: 2020-01-23T20:43:50-08:00 New Revision: a2137d6e097c9122c3bb08c4ef70636761aa10b9 URL: https://github.com/llvm/llvm-project/commit/a2137d6e097c9122c3bb08c4ef70636761aa10b9 DIFF: https://github.com/llvm/llvm-project/commit/a2137d6e097c9122c3bb08c4ef70636761aa10b9.diff

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson added a comment. FYI I reverted this in rG90e630a95ecc due to a cfi test failure in a windows sanitizer bot. Not sure what is happening, I'll need to try to debug it somehow tomorrow. Repository: rG LLVM Github

[PATCH] D73322: [WebAssembly] Update bleeding-edge CPU features

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62150 tests passed, 5 failed and 811 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp failed:

[PATCH] D73320: [WebAssembly] Add reference types target feature

sbc100 accepted this revision. sbc100 added inline comments. This revision is now accepted and ready to land. Comment at: llvm/test/CodeGen/WebAssembly/reference-types.ll:4 +; This currently only tests if the command line argument for reference types +; feature is accepted by llc

[PATCH] D73320: [WebAssembly] Add reference types target feature

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62151 tests passed, 5 failed and 811 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp failed:

[PATCH] D73322: [WebAssembly] Update bleeding-edge CPU features

aheejin created this revision. aheejin added a reviewer: tlively. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: clang. aheejin added a comment. I think their implemention is mostly complete, but please let me know if not. This adds bu

[PATCH] D73322: [WebAssembly] Update bleeding-edge CPU features

aheejin added a comment. I think their implemention is mostly complete, but please let me know if not. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73322/new/ https://reviews.llvm.org/D73322 ___ cfe-c

[PATCH] D73320: [WebAssembly] Add reference types target feature

aheejin created this revision. aheejin added a reviewer: tlively. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. This adds the reference types target feature. This does not enable any more functionali

[PATCH] D72242: Fix crash on value dependent bitfields in if conditions in templates

rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. This is not an appropriate fix; the code is locally correct. The right way to handle this is exactly what Clang currently does: if the expression is not type-dependent, then contextu

[PATCH] D73186: [AST] Add fixed-point multiplication constant evaluation.

rjmccall added inline comments. Comment at: clang/lib/Basic/FixedPoint.cpp:242 + } else +Overflowed = Result < Min || Result > Max; + leonardchan wrote: > ebevhan wrote: > > rjmccall wrote: > > > ebevhan wrote: > > > > ebevhan wrote: > > > > > rjmccall wrote

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

void created this revision. void added a reviewer: nickdesaulniers. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang now supports GNU's asm goto with outputs. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73319 Files: clang/include/clang/Basic/Fe

[PATCH] D73299: [HIP] Fix environment variable HIP_DEVICE_LIB_PATH

yaxunl updated this revision to Diff 240074. yaxunl edited the summary of this revision. yaxunl added a comment. Revised by Artem's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73299/new/ https://reviews.llvm.org/D73299 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp c

[PATCH] D73186: [AST] Add fixed-point multiplication constant evaluation.

leonardchan added inline comments. Comment at: clang/lib/Basic/FixedPoint.cpp:242 + } else +Overflowed = Result < Min || Result > Max; + ebevhan wrote: > rjmccall wrote: > > ebevhan wrote: > > > ebevhan wrote: > > > > rjmccall wrote: > > > > > If the maximum

[clang] 90e630a - Revert "[LTO/WPD] Enable aggressive WPD under LTO option"

Author: Teresa Johnson Date: 2020-01-23T17:29:24-08:00 New Revision: 90e630a95ecc2cd615d631f684d61acc872ce37e URL: https://github.com/llvm/llvm-project/commit/90e630a95ecc2cd615d631f684d61acc872ce37e DIFF: https://github.com/llvm/llvm-project/commit/90e630a95ecc2cd615d631f684d61acc872ce37e.diff

[PATCH] D72467: Remove "mask" operand from shufflevector.

efriedma updated this revision to Diff 240071. efriedma added a comment. Addressed review comments. Rebased. Chris Tetreault mentioned offline that we might want to change the return value of `getShuffleMask()` now, to try to save some work later when we add more forms of scalable vector shuff

[PATCH] D73072: [Driver][CodeGen] Support -fpatchable-function-entry=N,M and __attribute__((patchable_function_entry(N,M))) where M>0

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff

[PATCH] D70351: [clang][WIP][clang-scan-deps] Add an experimental C API.

Bigcheese added a comment. I was finally able to land the patch this depended on. Still waiting on review for this. In the meantime I've tested this ABI out by building a simple program that outputs a ninja file given a command line. It depends on a bunch of changes to the Clang side of things

[PATCH] D73072: [Driver][CodeGen] Support -fpatchable-function-entry=N,M and __attribute__((patchable_function_entry(N,M))) where M>0

This revision was automatically updated to reflect the committed changes. Closed by commit rG69bf40c45fd7: [Driver][CodeGen] Support -fpatchable-function-entry=N,M and __attribute__… (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D73072: [Driver][CodeGen] Support -fpatchable-function-entry=N,M and __attribute__((patchable_function_entry(N,M))) where M>0

MaskRay updated this revision to Diff 240064. MaskRay retitled this revision from "[Driver][CodeGen] Support -fpatchable-function-entry=N,M where M>0" to "[Driver][CodeGen] Support -fpatchable-function-entry=N,M and __attribute__((patchable_function_entry(N,M))) where M>0". MaskRay added a comme

[clang] f394d22 - [Concepts] Update cxx_status.html with Concepts support status

Author: Saar Raz Date: 2020-01-24T03:00:38+02:00 New Revision: f394d22fa82df03eaf72bf1876e2d63bbe6cd00f URL: https://github.com/llvm/llvm-project/commit/f394d22fa82df03eaf72bf1876e2d63bbe6cd00f DIFF: https://github.com/llvm/llvm-project/commit/f394d22fa82df03eaf72bf1876e2d63bbe6cd00f.diff LOG:

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

rtrieu added a comment. I'm in favor of splitting the warning into subgroups, then deciding which ones should be in -Wall. We've done this with other warnings such as the conversion warnings and tautological compare warnings, with only a subset of them in -Wall. Repository: rG LLVM Github M

[PATCH] D72867: [clangd] Support renaming designated initializers

kbobyrev planned changes to this revision. kbobyrev marked an inline comment as done. kbobyrev added a comment. Going to deal with nested designated inits soon and update the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72867/new/ https://r

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

MaskRay added a comment. In D7#1837358 , @nickdesaulniers wrote: > In D7#1837184 , @MaskRay wrote: > > > @peter.smith The build was smooth. Do I need other options to reproduce? > > > I was able to reproduc

[PATCH] D71313: [AST] Split parent map traversal logic into ParentMapContext.h

rnk added a comment. I think I can land this version, but I'll wait until tomorrow so I'll be around to debug fallout. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71313/new/ https://reviews.llvm.org/D71313

[PATCH] D73307: Unique Names for Functions with Internal Linkage

tmsriram created this revision. tmsriram added reviewers: MaskRay, mehdi_amini, davidxl, pcc, rnk. tmsriram added a parent revision: D68049: Propeller: Clang options for basic block sections . This is a subset of the functionality in Propeller patches. This patch adds a new clang option, -funiq

[PATCH] D71313: [AST] Split parent map traversal logic into ParentMapContext.h

rnk updated this revision to Diff 240050. rnk added a comment. This revision is now accepted and ready to land. - Move things around while retaining API compatibility for getParents Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71313/new/ https://r

[clang] 19c7698 - Fix bot failure from 59733525d37cf9ad88b5021b33ecdbaf2e18911c

Author: Teresa Johnson Date: 2020-01-23T16:34:34-08:00 New Revision: 19c76989bb505c3117730c47df85fd3800ea2767 URL: https://github.com/llvm/llvm-project/commit/19c76989bb505c3117730c47df85fd3800ea2767 DIFF: https://github.com/llvm/llvm-project/commit/19c76989bb505c3117730c47df85fd3800ea2767.diff

[PATCH] D73236: [clang-tidy] Add clang-tidy headers to clang distribution

This revision was automatically updated to reflect the committed changes. Closed by commit rG301a437250b0: [clang-tidy] Add clang-tidy headers to clang distribution (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73236/new

[clang-tools-extra] 301a437 - [clang-tidy] Add clang-tidy headers to clang distribution

Author: Dmitry Polukhin Date: 2020-01-23T16:29:08-08:00 New Revision: 301a437250b03de021e6da12a8e4a927ef48881e URL: https://github.com/llvm/llvm-project/commit/301a437250b03de021e6da12a8e4a927ef48881e DIFF: https://github.com/llvm/llvm-project/commit/301a437250b03de021e6da12a8e4a927ef48881e.dif

[clang] 73eaf62 - [Concepts] Make constraint expressions unevaluated until satisfaction checking

Author: Saar Raz Date: 2020-01-24T02:24:21+02:00 New Revision: 73eaf62463b4a29adf4194685af12d1a5d172987 URL: https://github.com/llvm/llvm-project/commit/73eaf62463b4a29adf4194685af12d1a5d172987 DIFF: https://github.com/llvm/llvm-project/commit/73eaf62463b4a29adf4194685af12d1a5d172987.diff LOG:

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

This revision was automatically updated to reflect the committed changes. Closed by commit rG59733525d37c: [LTO/WPD] Enable aggressive WPD under LTO option (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71913/new/ https://rev

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

This revision was automatically updated to reflect the committed changes. Closed by commit rG2af74e27ed7d: [MS] Overhaul how clang passes overaligned args on x86_32 (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72114/new/ https://

[clang] 2af74e2 - [MS] Overhaul how clang passes overaligned args on x86_32

Author: Reid Kleckner Date: 2020-01-23T16:04:00-08:00 New Revision: 2af74e27ed7d0832cbdde9cb969aaca7a42e99f9 URL: https://github.com/llvm/llvm-project/commit/2af74e27ed7d0832cbdde9cb969aaca7a42e99f9 DIFF: https://github.com/llvm/llvm-project/commit/2af74e27ed7d0832cbdde9cb969aaca7a42e99f9.diff

[PATCH] D73236: [clang-tidy] Add clang-tidy headers to clang distribution

DmitryPolukhin updated this revision to Diff 240037. DmitryPolukhin added a comment. remove `PATTERN ".svn" EXCLUDE` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73236/new/ https://reviews.llvm.org/D73236 Files: clang-tools-extra/clang-tidy/CMa

[PATCH] D73236: [clang-tidy] Add clang-tidy headers to clang distribution

DmitryPolukhin marked an inline comment as done. DmitryPolukhin added inline comments. Comment at: clang-tools-extra/clang-tidy/CMakeLists.txt:104 +PATTERN "*.h" +PATTERN ".svn" EXCLUDE +) alexfh wrote: > Is this still relevant? Perhaps no, but I stil

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

aaronpuchert added a comment. In D73007#1837271 , @aaronpuchert wrote: > one could also argue that this is a bit harder to follow in a range-based for > loop. This seems to be the argumentation of https://bugs.llvm.org/show_bug.cgi?id=32823#c0, so I g

[PATCH] D67537: [clangd] Client-side support for inactive regions

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62144 tests passed, 5 failed and 811 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp failed:

[PATCH] D73236: [clang-tidy] Add clang-tidy headers to clang distribution

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with an outstanding comment. Comment at: clang-tools-extra/clang-tidy/CMakeLists.txt:104 +PATTERN "*.h" +PATTERN ".svn" EXCLUDE +) Is this sti

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

jdoerfert added a comment. Thanks for working on this! While you are at it, `*this` is probably one of the most important ones to test and support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72811/new/ https://reviews.llvm.org/D72811 ___

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

cchen updated this revision to Diff 240029. cchen added a comment. Add a checker for locator (test is not complete yet). The logic of finding basic decl in LocatorChecker: - `int *B; omp target map(*B)` - B - pointer count (* in type): 1 - deref count: 1 - B is basic decl since poi

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

nickdesaulniers added a comment. In D7#1837116 , @MaskRay wrote: > along with -mfentry, -mhotpatch (SystemZ specific), -mnop-mcount (x86, > SystemZ, -fno-pie specific), -mrecord-mcount (used to retire > `scripts/recordmcount.{pl,c}`). This is a use

[PATCH] D69868: Allow "callbr" to return non-void values

void added a comment. In D69868#1836777 , @jyknight wrote: > The idea of moving the copies to a new MachineBasicBlock seems a reasonable > solution. That said, it does mean there will be allocatable physical > registers which are live-in to the following

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

nickdesaulniers added a comment. In D7#1837184 , @MaskRay wrote: > @peter.smith The build was smooth. Do I need other options to reproduce? I was able to reproduce: $ git clone --depth 1 git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-ne

[PATCH] D73300: [clang-tidy] Add library for clang-tidy main function

DmitryPolukhin marked 2 inline comments as done. DmitryPolukhin added a comment. @Eugene.Zelenko thank you for the catch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73300/new/ https://reviews.llvm.org/D73300 ___

[PATCH] D73300: [clang-tidy] Add library for clang-tidy main function

DmitryPolukhin updated this revision to Diff 240025. DmitryPolukhin added a comment. Fix license text Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73300/new/ https://reviews.llvm.org/D73300 Files: clang-tools-extra/clang-tidy/tool/CMakeLists.tx

[PATCH] D67537: [clangd] Client-side support for inactive regions

nridge updated this revision to Diff 240026. nridge marked an inline comment as done. nridge added a comment. Inject the inactive code decoration type into Highligher.decorationTypes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67537/new/ https://

[PATCH] D73299: [HIP] Fix environment variable HIP_DEVICE_LIB_PATH

tra added a comment. > If user sets HIP_DEVICE_LIB_PATH, this line in HIP.cpp > addDirectoryList(DriverArgs, LibraryPaths, "-L", "HIP_DEVICE_LIB_PATH"); > adds -L to LibraryPaths. -L is > needed since otherwise addDirectoryList will insert an extra empty string. > However, the -L must be strip

[PATCH] D72467: Remove "mask" operand from shufflevector.

efriedma marked 5 inline comments as done. efriedma added inline comments. Comment at: llvm/include/llvm/IR/IRBuilder.h:2551 +SmallVector IntMask; +IntMask.assign(Mask.begin(), Mask.end()); +return CreateShuffleVector(V1, V2, IntMask, Name); ctetreau

[PATCH] D73300: [clang-tidy] Add library for clang-tidy main function

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.h:5 +// +// This file is distributed under the University of Illinois Open Source +// License. See LICENSE.TXT for details. License seems to be old. ==

[PATCH] D72703: Add a warning, flags and pragmas to limit the number of pre-processor tokens in a translation unit

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72703/new/ https://reviews.llvm.org/D72703 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D73300: [clang-tidy] Add library for clang-tidy main function

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: smeenai, gribozavr, stephanemoore. DmitryPolukhin added projects: clang-tools-extra, clang. Herald added subscribers: xazax.hun, mgorny. This library allows to create clang-tidy tools with custom checks outside of llvm repo usi

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

hans added a comment. > @hans To address the CI problem (https://reviews.llvm.org/D7#1836728) > reported by @peter.smith, we just need to delete the driver option in the > release/10.x branch. (I need a -E preproccessed file to investigate.) > I think we don't need to hurry. We can simply r

[clang] 67c608a - [Concepts] Deprecate -fconcepts-ts, enable Concepts under -std=c++2a

Author: Saar Raz Date: 2020-01-24T00:48:59+02:00 New Revision: 67c608a9695496cfc9d3fdf9d0b12b554ac6b4df URL: https://github.com/llvm/llvm-project/commit/67c608a9695496cfc9d3fdf9d0b12b554ac6b4df DIFF: https://github.com/llvm/llvm-project/commit/67c608a9695496cfc9d3fdf9d0b12b554ac6b4df.diff LOG:

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

aaronpuchert added a comment. I think we can actually view this in more general terms, unrelated to range-based for loops. // X is non-trivially copyable. struct X { X(const X&); }; struct Y { Y(const X&); }; X retVal(); const X& retRef(); // In function scope ... const X &x1

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

njames93 added a comment. Gonna throw it out there, those pre merge fails aren't anything to do with this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 ___

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

hans added a comment. In D69825#1837243 , @hctim wrote: > For tracking purposes. > > The ASan leaks have been worked around in two separate patches in order to > make the bots green again: > > - c38e42527b21acee8d01a016d5bfa2fb83202e29 >

[PATCH] D73299: [HIP] Fix environment variable HIP_DEVICE_LIB_PATH

yaxunl created this revision. yaxunl added a reviewer: tra. If user sets HIP_DEVICE_LIB_PATH, this line in HIP.cpp addDirectoryList(DriverArgs, LibraryPaths, "-L", "HIP_DEVICE_LIB_PATH"); adds `-L` to LibraryPaths. `-L` is needed since otherwise addDirectoryList will insert an extra empty string.

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

hctim added a comment. For tracking purposes. The ASan leaks have been worked around in two separate patches in order to make the bots green again: - c38e42527b21acee8d01a016d5bfa2fb83202e29 - e174da447c180b586719cb28f7bd556

[clang] e174da4 - [Clang][IFS][Test] Work around in-process cc1 ASAN issues #2.

Author: Mitch Phillips Date: 2020-01-23T14:25:53-08:00 New Revision: e174da447c180b586719cb28f7bd556e30625762 URL: https://github.com/llvm/llvm-project/commit/e174da447c180b586719cb28f7bd556e30625762 DIFF: https://github.com/llvm/llvm-project/commit/e174da447c180b586719cb28f7bd556e30625762.diff

[PATCH] D67537: [clangd] Client-side support for inactive regions

nridge added a comment. In D67537#1833987 , @hokein wrote: > there is some significant progress about semantic highlighting on VSCode, > VSCode now provides an experimental semantic token API >

[PATCH] D65625: [clangd] Allow the client to specify multiple compilation databases in the 'initialize' request

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62144 tests passed, 5 failed and 811 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp failed:

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

MaskRay added a comment. In D7#1836409 , @peter.smith wrote: > Although this particular commit will not be at fault, it is the option that > enables the feature which is the earliest I can bisect the fault to. There > are 3 files in linux that assert

[PATCH] D72829: Implement -fsemantic-interposition

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62147 tests passed, 5 failed and 811 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp failed:

[PATCH] D73155: [Concepts] Implement P1616R1 - Using unconstrained template template parameters with constrained templates

This revision was automatically updated to reflect the committed changes. Closed by commit rGd42d5eb8ea77: [Concepts] Implement P1616R1 - Using unconstrained template template parameters… (authored by saar.raz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D65625: [clangd] Allow the client to specify multiple compilation databases in the 'initialize' request

nridge added a comment. Ilya / others if interested, I would like to revive this patch. We left off with a discussion in the corresponding issue , where I made a suggestion for an

[PATCH] D72829: Implement -fsemantic-interposition

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:488 + if (Context.getLangOpts().SemanticInterposition && + (Context.getLangOpts().PICLevel && !Context.getLangOpts().PIE)) +// Require various optimization to

[PATCH] D65625: [clangd] Allow the client to specify multiple compilation databases in the 'initialize' request

nridge updated this revision to Diff 24. nridge added a comment. Herald added a subscriber: usaxena95. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65625/new/ https://reviews.llvm.org/D65625 Files: clang-tools-extra/clangd/ClangdLSPS

[clang] d42d5eb - [Concepts] Implement P1616R1 - Using unconstrained template template parameters with constrained templates

Author: Saar Raz Date: 2020-01-23T23:32:03+02:00 New Revision: d42d5eb8ea77b3a3a502a60ba3f053fb81a897f3 URL: https://github.com/llvm/llvm-project/commit/d42d5eb8ea77b3a3a502a60ba3f053fb81a897f3 DIFF: https://github.com/llvm/llvm-project/commit/d42d5eb8ea77b3a3a502a60ba3f053fb81a897f3.diff LOG:

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

MaskRay added a comment. In D7#1836942 , @nickdesaulniers wrote: > In D7#1836687 , @MaskRay wrote: > > > (I really dislike how the feature was developed on the GCC side. Yet > > another Linux-kernel specif

[PATCH] D73237: [CUDA] Fix order of memcpy arguments in __shfl_*(<64-bit type>).

tra added a comment. In D73237#1836978 , @timshen wrote: > What's the test situation for these headers? They are not testable in clang/llvm tree as they need CUDA SDK headers. I should be able to add some tests in the test-suite. Repository: rG LLVM

[clang] 4d33a8d - [Concepts] Add ExpressionEvaluationContexts to instantiation of constraints

Author: Saar Raz Date: 2020-01-23T23:24:56+02:00 New Revision: 4d33a8dfcf67e970ea4d150d514b27de02e79aee URL: https://github.com/llvm/llvm-project/commit/4d33a8dfcf67e970ea4d150d514b27de02e79aee DIFF: https://github.com/llvm/llvm-project/commit/4d33a8dfcf67e970ea4d150d514b27de02e79aee.diff LOG:

[PATCH] D71911: [ThinLTO] Summarize vcall_visibility metadata

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c2eb220edd5: [ThinLTO] Summarize vcall_visibility metadata (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71911/new/ https://review

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 239996. serge-sans-paille added a comment. Take into account pie/pic interaction with semantic-interposition More test case Remove premature release note entry Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D73290: [PowerPC] Add clang -msvr4-struct-return for 32-bit ELF

kernigh created this revision. kernigh added reviewers: brad, markmi, chmeee. kernigh added a project: clang. Herald added subscribers: cfe-commits, steven.zhang, shchenz, jsji, kbarton, krytarowski, arichardson, nemanjai, emaste. This is a patch for https://bugs.llvm.org/show_bug.cgi?id=40736 *

[PATCH] D73237: [CUDA] Fix order of memcpy arguments in __shfl_*(<64-bit type>).

tra closed this revision. tra added a subscriber: hans. tra added a comment. Landed in https://github.com/llvm/llvm-project/commit/cc14de88da27a8178976972bdc8211c31f7ca9ae @hans -- can we cherry-pick it into 10? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[clang] 9c2eb22 - [ThinLTO] Summarize vcall_visibility metadata

Author: Teresa Johnson Date: 2020-01-23T13:19:56-08:00 New Revision: 9c2eb220edd5e831a17bfbde65dcc49e402d7540 URL: https://github.com/llvm/llvm-project/commit/9c2eb220edd5e831a17bfbde65dcc49e402d7540 DIFF: https://github.com/llvm/llvm-project/commit/9c2eb220edd5e831a17bfbde65dcc49e402d7540.diff

[clang] cc14de8 - [CUDA] Fix order of memcpy arguments in __shfl_*(<64-bit type>).

Author: Artem Belevich Date: 2020-01-23T13:17:52-08:00 New Revision: cc14de88da27a8178976972bdc8211c31f7ca9ae URL: https://github.com/llvm/llvm-project/commit/cc14de88da27a8178976972bdc8211c31f7ca9ae DIFF: https://github.com/llvm/llvm-project/commit/cc14de88da27a8178976972bdc8211c31f7ca9ae.diff

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62129 tests passed, 5 failed and 807 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp failed:

[PATCH] D73285: [OpenMP][OMPIRBuilder][BugFix] Handle Unreachable Finalization blocks in `parallel` generation

fghanim updated this revision to Diff 239991. fghanim added a comment. - Cleaning up some leftover code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73285/new/ https://reviews.llvm.org/D73285 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp llvm/li

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

njames93 updated this revision to Diff 239988. njames93 added a comment. - Rebase trunk and fix a few nits with test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 Files: clang-tools-extra/clang-tid

[PATCH] D73261: [dwarf5] Support DebugInfo for constexpr for C++ variables and functions

probinson added a comment. I put in a lot of comments about spelling for the new parameter (constExpr, isConstexpr, isConstExpr) which should be named consistently throughout. Please do not use Constant or any variant, as that tends to mean something else. But, what I would rather see instead

[PATCH] D73237: [CUDA] Fix order of memcpy arguments in __shfl_*(<64-bit type>).

timshen accepted this revision. timshen added a comment. This revision is now accepted and ready to land. What's the test situation for these headers? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73237/new/ https://reviews.llvm.org/D73237 _

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

dexonsmith added a comment. In D67678#1836922 , @rsmith wrote: > In D67678#1836668 , @dexonsmith > wrote: > > > In D67678#1836628 , @steven_wu > > wrote: > > > > > In D6767

[clang] 1624cba - Partially revert "[IR] Attribute/AttrBuilder: use Value::MaximumAlignment magic constant"

Author: Roman Lebedev Date: 2020-01-23T23:30:42+03:00 New Revision: 1624cba7824967c15ac36d9fdd41bb9878463dbe URL: https://github.com/llvm/llvm-project/commit/1624cba7824967c15ac36d9fdd41bb9878463dbe DIFF: https://github.com/llvm/llvm-project/commit/1624cba7824967c15ac36d9fdd41bb9878463dbe.diff

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

nickdesaulniers added a comment. In D7#1836687 , @MaskRay wrote: > (I really dislike how the feature was developed on the GCC side. Yet another > Linux-kernel specific GCC option when there are already 4 existing options > for the same feature) May

[clang] fa2fc81 - Re-add documentation for -flax-vector-conversions= removed in

Author: Richard Smith Date: 2020-01-23T12:28:03-08:00 New Revision: fa2fc81d3464aa9b6e5e9d2ad8f512904712d2b7 URL: https://github.com/llvm/llvm-project/commit/fa2fc81d3464aa9b6e5e9d2ad8f512904712d2b7 DIFF: https://github.com/llvm/llvm-project/commit/fa2fc81d3464aa9b6e5e9d2ad8f512904712d2b7.diff

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61939 tests passed, 5 failed and 782 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp failed:

[PATCH] D73140: [clangd] Add C++20 concepts support to TargetFinder

This revision was automatically updated to reflect the committed changes. Closed by commit rGcbcd07a4815f: [clangd] Add C++20 concepts support to TargetFinder (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73140/new/ https://rev

  1   2   3   >