[PATCH] D73397: [Clang] Enable -fsanitize=leak on Fuchsia targets

2020-01-24 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73397/new/ https://reviews.llvm.org/D73397

[PATCH] D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name

2020-01-24 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3659 // Use llvm function name. -Name = Fn->getName(); +if (Fn->getName().startswith("___Z")) + LinkageName = Fn->getName(); aprantl wrote: > aprantl wrote: > > Could

[PATCH] D73290: [PowerPC] Add clang -msvr4-struct-return for 32-bit ELF

2020-01-24 Thread Mark Millard via Phabricator via cfe-commits
markmi added a comment. I built and installed ports, what built vs. did-not was the same as before applying the update, with the same failure details having nothing to do with this change. I then ran the FreeBSD kyua tests and the result match what I got prior to the update. These tests are

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

2020-01-24 Thread Warren Ristow via Phabricator via cfe-commits
wristow marked 4 inline comments as done. wristow added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2792 if (!MathErrno && AssociativeMath && ReciprocalMath && !SignedZeros && - !TrappingMath) + !TrappingMath && !(FPContract.equals("off") ||

[libunwind] c48974f - [libunwind] Set LIBUNWIND_ASM_SOURCES to the ASM source language from C

2020-01-24 Thread Petr Hosek via cfe-commits
Author: James Nagurne Date: 2020-01-24T19:16:47-08:00 New Revision: c48974ffd7d1676f79d39d3b1e70f07d3a5e2e44 URL: https://github.com/llvm/llvm-project/commit/c48974ffd7d1676f79d39d3b1e70f07d3a5e2e44 DIFF: https://github.com/llvm/llvm-project/commit/c48974ffd7d1676f79d39d3b1e70f07d3a5e2e44.diff

[PATCH] D73380: [clang] Annotating C++'s `operator new` with more attributes

2020-01-24 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14361 +/// attributes are applied to declarations. +void Sema::AddKnownFunctionAttributesForReplaceableGlobalAllocationFunction( +FunctionDecl *FD) { This should all be done by CodeGen,

[PATCH] D73388: NFC: Implement AST node skipping in ParentMapContext

2020-01-24 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. This seems reasonable to me. If you want to unify something about this and the `Ignore*` functions in `Expr`, maybe we could add a "classify" mechanism, so you could ask "what kind of node

[clang] 04f131d - DR1753: Don't permit x.NS::~T() as a pseudo-destructor name.

2020-01-24 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-01-24T18:53:50-08:00 New Revision: 04f131da0b19abff611773c03be9bafb53c753ce URL: https://github.com/llvm/llvm-project/commit/04f131da0b19abff611773c03be9bafb53c753ce DIFF: https://github.com/llvm/llvm-project/commit/04f131da0b19abff611773c03be9bafb53c753ce.diff

[PATCH] D73397: [Clang] Enable -fsanitize=leak on Fuchsia targets

2020-01-24 Thread Roland McGrath via Phabricator via cfe-commits
mcgrathr updated this revision to Diff 240346. mcgrathr added a comment. Fixed Android SafeStack case, now passing check-clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73397/new/ https://reviews.llvm.org/D73397 Files:

[PATCH] D73397: [Clang] Enable -fsanitize=leak on Fuchsia targets

2020-01-24 Thread Roland McGrath via Phabricator via cfe-commits
mcgrathr created this revision. mcgrathr added reviewers: phosek, aarongreen, cryptoad, vitalybuka. Herald added a project: clang. Herald added a subscriber: cfe-commits. This required some fixes to the generic code for two issues: 1. -fsanitize=safe-stack is default on x86_64-fuchsia and is

[clang] 0ebc8e6 - [Sema] Remove unneeded TreeTransform.h includes, NFC

2020-01-24 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-01-24T17:48:38-08:00 New Revision: 0ebc8e6c42167ba049aef8d73cae7eb7a316c8a1 URL: https://github.com/llvm/llvm-project/commit/0ebc8e6c42167ba049aef8d73cae7eb7a316c8a1 DIFF: https://github.com/llvm/llvm-project/commit/0ebc8e6c42167ba049aef8d73cae7eb7a316c8a1.diff

[PATCH] D73385: [Sema] Split availability processing into SemaAvailability.cpp

2020-01-24 Thread Reid Kleckner via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGdd8e0a0a23ba: [Sema] Split availability processing into SemaAvailability.cpp (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73385/new/

[clang] dd8e0a0 - [Sema] Split availability processing into SemaAvailability.cpp

2020-01-24 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-01-24T17:35:39-08:00 New Revision: dd8e0a0a23bab23fee283145c599014bf4b450d3 URL: https://github.com/llvm/llvm-project/commit/dd8e0a0a23bab23fee283145c599014bf4b450d3 DIFF: https://github.com/llvm/llvm-project/commit/dd8e0a0a23bab23fee283145c599014bf4b450d3.diff

[PATCH] D73151: [analyzer] Fix handle leak false positive when the handle dies too early

2020-01-24 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun updated this revision to Diff 240337. xazax.hun added a comment. - Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73151/new/ https://reviews.llvm.org/D73151 Files: clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp

[PATCH] D73151: [analyzer] Fix handle leak false positive when the handle dies too early

2020-01-24 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun marked 4 inline comments as done. xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp:133-135 + static HandleState getWithoutError(HandleState S) { +return HandleState(S.K, nullptr); + }

[PATCH] D72810: [LifetimeAnalysis] Add support for lifetime annotations on functions

2020-01-24 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun updated this revision to Diff 240335. xazax.hun added a comment. - Address some review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72810/new/ https://reviews.llvm.org/D72810 Files: clang/include/clang/AST/Attr.h clang/include/clang/AST/LifetimeAttr.h

[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

2020-01-24 Thread Stephane Moore via Phabricator via cfe-commits
stephanemoore added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/DeallocInCategoriesCheck.cpp:19 + +void DeallocInCategoriesCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher( Early return if the language is not an Objective-C

[PATCH] D73307: Unique Names for Functions with Internal Linkage

2020-01-24 Thread Mircea Trofin via Phabricator via cfe-commits
mtrofin added a comment. In D73307#1839984 , @MaskRay wrote: > In D73307#1839880 , @mtrofin wrote: > > > In D73307#1839829 , @MaskRay wrote: > > > > > The code change seems

[PATCH] D72810: [LifetimeAnalysis] Add support for lifetime annotations on functions

2020-01-24 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun marked 14 inline comments as done. xazax.hun added inline comments. Comment at: clang/include/clang/AST/LifetimeAttr.h:163 +// Maps each annotated entity to a lifetime set. +using LifetimeContracts = std::map; + gribozavr2 wrote: > Generally, DenseMap

[PATCH] D73307: Unique Names for Functions with Internal Linkage

2020-01-24 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D73307#1839880 , @mtrofin wrote: > In D73307#1839829 , @MaskRay wrote: > > > The code change seems fine, but the test requires some changes. I haven't > > followed Propeller

[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

2020-01-24 Thread Stephane Moore via Phabricator via cfe-commits
stephanemoore requested changes to this revision. stephanemoore added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clang-tidy/objc/DeallocInCategoriesCheck.cpp:21 + Finder->addMatcher( + objcMethodDecl(hasName("dealloc"),

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

2020-01-24 Thread Andy Kaylor via Phabricator via cfe-commits
andrew.w.kaylor added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2792 if (!MathErrno && AssociativeMath && ReciprocalMath && !SignedZeros && - !TrappingMath) + !TrappingMath && !(FPContract.equals("off") || FPContract.equals("on")))

[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

2020-01-24 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/test/Analysis/c11lock.c:1 +// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.unix.C11Lock -verify %s + NoQ wrote: > NoQ wrote: > > I wouldn't mind `alpha.core` given

[PATCH] D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name

2020-01-24 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3659 // Use llvm function name. -Name = Fn->getName(); +if (Fn->getName().startswith("___Z")) + LinkageName = Fn->getName(); Could you please add a comment that Clang

[PATCH] D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name

2020-01-24 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3659 // Use llvm function name. -Name = Fn->getName(); +if (Fn->getName().startswith("___Z")) + LinkageName = Fn->getName(); aprantl wrote: > Could you please add a

[PATCH] D73307: Unique Names for Functions with Internal Linkage

2020-01-24 Thread Mircea Trofin via Phabricator via cfe-commits
mtrofin added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp: + !getModule().getSourceFileName().empty()) { +llvm::MD5 Md5; +Md5.update(getModule().getSourceFileName()); Just a thought: md5 is a non-bijective transformation,

[PATCH] D73307: Unique Names for Functions with Internal Linkage

2020-01-24 Thread Mircea Trofin via Phabricator via cfe-commits
mtrofin added a comment. In D73307#1839829 , @MaskRay wrote: > The code change seems fine, but the test requires some changes. I haven't > followed Propeller development, but hope someone with profile experience can > confirm InternalLinkage is the only

[PATCH] D73028: Extract ExprTraversal class from Expr

2020-01-24 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added a comment. In D73028#1839644 , @steveire wrote: > In D73028#1839572 , @rsmith wrote: > > > In D73028#1839494 , @steveire > > wrote: > > > > > In

[PATCH] D73388: Implement AST node skipping in ParentMapContext

2020-01-24 Thread Stephen Kelly via Phabricator via cfe-commits
steveire updated this revision to Diff 240318. steveire added a comment. constness Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73388/new/ https://reviews.llvm.org/D73388 Files: clang/include/clang/AST/ParentMapContext.h

[PATCH] D73388: Implement AST node skipping in ParentMapContext

2020-01-24 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. steveire added reviewers: aaron.ballman, rsmith, rnk. Herald added a project: clang. Herald added a subscriber: cfe-commits. steveire updated this revision to Diff 240318. steveire added a comment. constness This allows ASTContext to store only one parent map,

[PATCH] D71313: [AST] Split parent map traversal logic into ParentMapContext.h

2020-01-24 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added a comment. Should this new class have some tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71313/new/ https://reviews.llvm.org/D71313 ___ cfe-commits mailing list

[PATCH] D73307: Unique Names for Functions with Internal Linkage

2020-01-24 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. The code change seems fine, but the test requires some changes. I haven't followed Propeller development, but hope someone with profile experience can confirm InternalLinkage is the only linkage we need to care about (otherwise the option will be a misnomer if we ever

[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

2020-01-24 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/test/Analysis/c11lock.c:1 +// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.unix.C11Lock -verify %s + NoQ wrote: > I wouldn't mind `alpha.core` given that these functions belong to the > standard library. (i.e., i

[PATCH] D73385: [Sema] Split availability processing into SemaAvailability.cpp

2020-01-24 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62189 tests passed, 1 failed and 815 were skipped. failed: libc++.std/thread/thread_mutex/thread_mutex_requirements/thread_mutex_requirements_mutex/thread_mutex_class/try_lock.pass.cpp {icon times-circle

[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

2020-01-24 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Yay, C11 as well!! > If you have any idea how to reduce this boilerplate I'd like to know :) I don't see any immediate solutions to the boilerplate that don't consist in introducing better checker APIs. Eg., we could have introduced a `LazyBugType` - a wrapper around

[PATCH] D73307: Unique Names for Functions with Internal Linkage

2020-01-24 Thread Sriraman Tallam via Phabricator via cfe-commits
tmsriram updated this revision to Diff 240312. tmsriram added a comment. Minor changes. Remove CC1option on "-fno", Remove "$" from unique suffix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73307/new/ https://reviews.llvm.org/D73307 Files:

[PATCH] D73151: [analyzer] Fix handle leak false positive when the handle dies too early

2020-01-24 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun marked 2 inline comments as done. xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp:133-135 + static HandleState getWithoutError(HandleState S) { +return HandleState(S.K, nullptr); + } NoQ

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

2020-01-24 Thread Warren Ristow via Phabricator via cfe-commits
wristow updated this revision to Diff 240305. wristow added a comment. Update a comment to remove the discussion about enabling the `__FAST_MATH__` preprocessor macro. The handling of the setting of `__FAST_MATH__` is done in "clang/lib/Frontend/InitPreprocessor.cpp", and once we decide on the

[PATCH] D73385: [Sema] Split availability processing into SemaAvailability.cpp

2020-01-24 Thread Reid Kleckner via Phabricator via cfe-commits
rnk created this revision. rnk added reviewers: arphaman, aaron.ballman, rsmith. Herald added subscribers: dexonsmith, mgorny. Herald added a project: clang. Reduces compile time of SemaDeclAttr.cpp down to 28s from 50s. The new TU does a few RecursiveASTVisitor instantiations, so it takes 30s.

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

2020-01-24 Thread Warren Ristow via Phabricator via cfe-commits
wristow added a comment. In D72675#1839662 , @andrew.w.kaylor wrote: > In D72675#1839492 , @wristow wrote: > > > 1. Should we enable FMA "by default" at (for example) '-O2'? > > > We recently introduced a new

[PATCH] D73151: [analyzer] Fix handle leak false positive when the handle dies too early

2020-01-24 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp:133-135 + static HandleState getWithoutError(HandleState S) { +return HandleState(S.K, nullptr); + } It already makes me mildly uncomfortable that our data is

[PATCH] D73237: [CUDA] Fix order of memcpy arguments in __shfl_*(<64-bit type>).

2020-01-24 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. In D73237#1839216 , @hans wrote: > In D73237#1837077 , @tra wrote: > > > Landed in > > https://github.com/llvm/llvm-project/commit/cc14de88da27a8178976972bdc8211c31f7ca9ae > > @hans -- can we

[clang] 1e487e4 - clang: Only define OBJC_NEW_PROPERTIES when -x objective-c

2020-01-24 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-01-24T14:55:12-08:00 New Revision: 1e487e4c16821b6de3d651f618274df90bd3fad9 URL: https://github.com/llvm/llvm-project/commit/1e487e4c16821b6de3d651f618274df90bd3fad9 DIFF:

[PATCH] D73307: Unique Names for Functions with Internal Linkage

2020-01-24 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:1959 +def fno_unique_internal_funcnames : Flag <["-"], "fno-unique-internal-funcnames">, + Group, Flags<[CC1Option]>; + `, Flags<[CC1Option]>` can be deleted.

[PATCH] D72970: clang: Only define OBJC_NEW_PROPERTIES when -x objective-c

2020-01-24 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith closed this revision. dexonsmith added a comment. Thanks, committed in 1e487e4c16821b6de3d651f618274df90bd3fad9 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72970/new/ https://reviews.llvm.org/D72970

[PATCH] D73307: Unique Names for Functions with Internal Linkage

2020-01-24 Thread Sriraman Tallam via Phabricator via cfe-commits
tmsriram marked an inline comment as done. tmsriram added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1117 +llvm::MD5::stringifyResult(R, Str); +std::string UniqueSuffix = (".$" + Str).str(); +MangledName = MangledName + UniqueSuffix;

[PATCH] D73307: Unique Names for Functions with Internal Linkage

2020-01-24 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1117 +llvm::MD5::stringifyResult(R, Str); +std::string UniqueSuffix = (".$" + Str).str(); +MangledName = MangledName + UniqueSuffix; Why `".$"` and not just `"."`? CHANGES

[PATCH] D73322: [WebAssembly] Update bleeding-edge CPU features

2020-01-24 Thread Heejin Ahn via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG65eb11306e92: [WebAssembly] Update bleeding-edge CPU features (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73322/new/

[clang] 65eb113 - [WebAssembly] Update bleeding-edge CPU features

2020-01-24 Thread Heejin Ahn via cfe-commits
Author: Heejin Ahn Date: 2020-01-24T14:27:35-08:00 New Revision: 65eb11306e921bb0299100dfc61e79858f903c1b URL: https://github.com/llvm/llvm-project/commit/65eb11306e921bb0299100dfc61e79858f903c1b DIFF: https://github.com/llvm/llvm-project/commit/65eb11306e921bb0299100dfc61e79858f903c1b.diff

[PATCH] D73320: [WebAssembly] Add reference types target feature

2020-01-24 Thread Heejin Ahn via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG764f4089e89e: [WebAssembly] Add reference types target feature (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73320/new/

[clang] 764f408 - [WebAssembly] Add reference types target feature

2020-01-24 Thread Heejin Ahn via cfe-commits
Author: Heejin Ahn Date: 2020-01-24T14:26:27-08:00 New Revision: 764f4089e89e4693b7bb8f1ee18080703ce760dd URL: https://github.com/llvm/llvm-project/commit/764f4089e89e4693b7bb8f1ee18080703ce760dd DIFF: https://github.com/llvm/llvm-project/commit/764f4089e89e4693b7bb8f1ee18080703ce760dd.diff

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

2020-01-24 Thread Andy Kaylor via Phabricator via cfe-commits
andrew.w.kaylor added a comment. In D72675#1839492 , @wristow wrote: > 1. Should we enable FMA "by default" at (for example) '-O2'? We recently introduced a new option "-ffp-model=[precise|fast|strict], which is supposed to serve as an umbrella option

[PATCH] D71973: [clang-tidy] Add bugprone-suspicious-memory-comparison check

2020-01-24 Thread Gabor Bencze via Phabricator via cfe-commits
gbencze added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71973/new/ https://reviews.llvm.org/D71973 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D71566: New checks for fortified sprintf

2020-01-24 Thread serge via Phabricator via cfe-commits
serge-sans-paille added a comment. In D71566#1839462 , @aaron.ballman wrote: > Continues to LG, do you need me to commit on your behalf? I was waiting for a last LG as I did some changes, thanks for all the quick iteration, I **really** enjoyed

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

2020-01-24 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert added a comment. Here is a proposal: we add two children to `-Wrange-loop-analysis`. - `-Wrange-loop-construct` warns about possibly unintended constructor calls. This might be in `-Wall`. It contains - `warn_for_range_copy`: loop variable A of type B creates a copy from type C

[PATCH] D73028: Extract ExprTraversal class from Expr

2020-01-24 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added a comment. In D73028#1839572 , @rsmith wrote: > In D73028#1839494 , @steveire wrote: > > > In D73028#1839383 , @rsmith wrote: > > > > > > > > > > > The

[PATCH] D73380: [clang] Annotating C++'s `operator new` with more attributes

2020-01-24 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri marked 2 inline comments as done. lebedev.ri added a comment. In D73380#1839603 , @xbolva00 wrote: > LLVM already infers noalias nonnull for eg. _Znwm so noalias and nonnull info > added by clang will not increase power of LLVM. Or? To be

[PATCH] D71313: [AST] Split parent map traversal logic into ParentMapContext.h

2020-01-24 Thread Reid Kleckner via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8a81daaa8b58: [AST] Split parent map traversal logic into ParentMapContext.h (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D71313?vs=240050=240283#toc Repository: rG LLVM

[clang] 8a81daa - [AST] Split parent map traversal logic into ParentMapContext.h

2020-01-24 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-01-24T13:42:28-08:00 New Revision: 8a81daaa8b58aeaa192a47c4ce7f94b4d59ce082 URL: https://github.com/llvm/llvm-project/commit/8a81daaa8b58aeaa192a47c4ce7f94b4d59ce082 DIFF: https://github.com/llvm/llvm-project/commit/8a81daaa8b58aeaa192a47c4ce7f94b4d59ce082.diff

[PATCH] D73380: [clang] Annotating C++'s `operator new` with more attributes

2020-01-24 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added a comment. LLVM already infers noalias nonnull for eg. _Znwm so noalias and nonnull info added by clang will not increase power of LLVM. Or? Alignment info is useful I think. Comment at: clang/test/CodeGenCXX/builtin-operator-new-delete.cpp:54 } -// CHECK:

[PATCH] D73028: Extract ExprTraversal class from Expr

2020-01-24 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D73028#1839572 , @rsmith wrote: > In D73028#1839494 , @steveire wrote: > > > In D73028#1839383 , @rsmith wrote: > > > > > > > > > > > The

[PATCH] D73380: [clang] Annotating C++'s `operator new` with more attributes

2020-01-24 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri created this revision. lebedev.ri added reviewers: rsandifo, erichkeane, rjmccall, jdoerfert, eugenis. lebedev.ri added a project: LLVM. Herald added subscribers: atanasyan, jrtc27. Herald added a project: clang. lebedev.ri added a parent revision: D73020: [Sema] Perform call checking

[PATCH] D73029: Extend ExprTraversal class with acending traversal

2020-01-24 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. We're working on moving the parent map out of `ASTContext` and into something specific to tooling; please don't add more dependencies onto it in the AST library. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73029/new/

[PATCH] D73028: Extract ExprTraversal class from Expr

2020-01-24 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In D73028#1839494 , @steveire wrote: > In D73028#1839383 , @rsmith wrote: > > > > > > The follow-up is here: https://reviews.llvm.org/D73029 . > > I have the need to change the ascending

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

2020-01-24 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15235 + bool VisitUnaryOperator(UnaryOperator *UO) { +DerefCnt++; +CurComponents.emplace_back(UO, nullptr); ABataev wrote: > cchen wrote: > >

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

2020-01-24 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In D72811#1839538 , @cchen wrote: > In D72811#1837392 , @jdoerfert wrote: > > > Thanks for working on this! While you are at it, `*this` is probably one of > > the most important ones to

[PATCH] D73300: [clang-tidy] Add library for clang-tidy main function

2020-01-24 Thread Dmitry Polukhin via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3f8b100e94b5: [clang-tidy] Add library for clang-tidy main function (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73300/new/

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

2020-01-24 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15235 + bool VisitUnaryOperator(UnaryOperator *UO) { +DerefCnt++; +CurComponents.emplace_back(UO, nullptr); cchen wrote: > ABataev wrote: > >

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

2020-01-24 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen marked an inline comment as done. cchen added a comment. In D72811#1837392 , @jdoerfert wrote: > Thanks for working on this! While you are at it, `*this` is probably one of > the most important ones to test and support. Can anyone tell me how to

[clang-tools-extra] 3f8b100 - [clang-tidy] Add library for clang-tidy main function

2020-01-24 Thread Dmitry Polukhin via cfe-commits
Author: Dmitry Polukhin Date: 2020-01-24T13:00:45-08:00 New Revision: 3f8b100e94b5c848843fa91c9782d9d4df4bb026 URL: https://github.com/llvm/llvm-project/commit/3f8b100e94b5c848843fa91c9782d9d4df4bb026 DIFF:

[PATCH] D71600: PowerPC 32-bit - forces 8 byte lock/lock_free decisions at compiled time

2020-01-24 Thread Dimitry Andric via Phabricator via cfe-commits
dim added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:11180 +// Avoid emiting call for runtime decision on PowerPC 32-bit +// The lock free possibilities on this platform are covered by the lines `s/emiting/emitting/` Repository:

[PATCH] D73028: Extract ExprTraversal class from Expr

2020-01-24 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added a comment. In D73028#1839383 , @rsmith wrote: > > An addition to the API will be concerned with ascending through the AST in > > different traversal modes. > > Ascending through the AST is not possibly by design. (For example, we share >

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

2020-01-24 Thread Warren Ristow via Phabricator via cfe-commits
wristow added a comment. > A separate question is the interaction of `-ffast-math` with > `-ffp-contract=`. Currently, there is no such interaction whatsoever in GCC: > `-ffast-math` does not imply any particular `-ffp-contract=` setting, and > vice versa the `-ffp-contract=` setting is not

[PATCH] D73028: Extract ExprTraversal class from Expr

2020-01-24 Thread Stephen Kelly via Phabricator via cfe-commits
steveire updated this revision to Diff 240269. steveire marked an inline comment as done. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73028/new/ https://reviews.llvm.org/D73028 Files:

[PATCH] D73028: Extract ExprTraversal class from Expr

2020-01-24 Thread Stephen Kelly via Phabricator via cfe-commits
steveire updated this revision to Diff 240267. steveire added a comment. Update for review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73028/new/ https://reviews.llvm.org/D73028 Files: clang/include/clang/AST/Expr.h

[PATCH] D71566: New checks for fortified sprintf

2020-01-24 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Continues to LG, do you need me to commit on your behalf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71566/new/ https://reviews.llvm.org/D71566 ___ cfe-commits

[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

2020-01-24 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun created this revision. xazax.hun added reviewers: NoQ, haowei. xazax.hun added a project: clang. Herald added subscribers: Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, jfb, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Basically, the semantics of C11 and

[PATCH] D73037: Add a way to set traversal mode in clang-query

2020-01-24 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. There should also be a mention of this in the release notes (especially if the default behavior winds up changing). Comment at: clang-tools-extra/clang-query/Query.cpp:51 +"IgnoreImplicitCastsAndParentheses" +" Omit implicit

[clang-tools-extra] 58592f6 - Include for std::abort() in clangd

2020-01-24 Thread Dimitry Andric via cfe-commits
Author: Dimitry Andric Date: 2020-01-24T20:52:37+01:00 New Revision: 58592f6c49249293f79698cfcb31dba532e12603 URL: https://github.com/llvm/llvm-project/commit/58592f6c49249293f79698cfcb31dba532e12603 DIFF:

[PATCH] D73028: Extract ExprTraversal class from Expr

2020-01-24 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. > An addition to the API will be concerned with ascending through the AST in > different traversal modes. Ascending through the AST is not possibly by design. (For example, we share AST nodes between template instantiations, and statement nodes don't contain parent

[PATCH] D73029: Extend ExprTraversal class with acending traversal

2020-01-24 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Test cases? Comment at: clang/lib/AST/ASTContext.cpp:1066 +if (Node.getNodeKind().hasPointerIdentity()) { + auto ParentList = + getDynNodeFromMap(Node.getMemoizationData(), PointerParents); Please spell the type

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

2020-01-24 Thread Kanglei Fang via Phabricator via cfe-commits
ghvg1313 updated this revision to Diff 240260. ghvg1313 marked an inline comment as done. ghvg1313 added a comment. - rebase master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70926/new/ https://reviews.llvm.org/D70926 Files:

[PATCH] D73028: Extract ExprTraversal class from Expr

2020-01-24 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. This looks like it's an NFC patch where the only change is to hoist this functionality out into its own interface. Is that correct? If so, can you please be sure to add NFC to the commit log? Comment at:

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

2020-01-24 Thread Kanglei Fang via Phabricator via cfe-commits
ghvg1313 marked 2 inline comments as done. ghvg1313 added inline comments. Comment at: clang/docs/ReleaseNotes.rst:164 + +- Clang-format now supports JavaScript null operators. + MyDeveloperDay wrote: > is this line part of this patch? No, rebased again and got

[clang] 698d1cd - Make address-space-lambda.cl pass on 32-bit Windows

2020-01-24 Thread Hans Wennborg via cfe-commits
Author: Hans Wennborg Date: 2020-01-24T20:35:25+01:00 New Revision: 698d1cd3b8154b3b74423386d3e111e6b756e87a URL: https://github.com/llvm/llvm-project/commit/698d1cd3b8154b3b74423386d3e111e6b756e87a DIFF: https://github.com/llvm/llvm-project/commit/698d1cd3b8154b3b74423386d3e111e6b756e87a.diff

[PATCH] D73307: Unique Names for Functions with Internal Linkage

2020-01-24 Thread Sriraman Tallam via Phabricator via cfe-commits
tmsriram updated this revision to Diff 240253. tmsriram added a comment. Remove an unnecessary header file inclusion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73307/new/ https://reviews.llvm.org/D73307 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D73307: Unique Names for Functions with Internal Linkage

2020-01-24 Thread Sriraman Tallam via Phabricator via cfe-commits
tmsriram updated this revision to Diff 240249. tmsriram added a comment. Use Hash of Module's source file name directly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73307/new/ https://reviews.llvm.org/D73307 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

2020-01-24 Thread Melanie Blower via Phabricator via cfe-commits
mibintc marked 3 inline comments as done. mibintc added a comment. In D72841#1833022 , @sepavloff wrote: > I don't see tests for correctness of the pragma stack (`pragma > float_control(... push)`, `pragma float_control(pop)`). Can you add them? I

[PATCH] D72906: [X86] Improve X86 cmpps/cmppd/cmpss/cmpsd intrinsics with strictfp

2020-01-24 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. In D72906#1838532 , @uweigand wrote: > In D72906#1837905 , @craig.topper > wrote: > > > In D72906#1826849 , @uweigand > > wrote: > > > > > In

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

2020-01-24 Thread Melanie Blower via Phabricator via cfe-commits
mibintc updated this revision to Diff 240245. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72841/new/ https://reviews.llvm.org/D72841 Files: clang/docs/LanguageExtensions.rst clang/include/clang/AST/Stmt.h

[PATCH] D72467: Remove "mask" operand from shufflevector.

2020-01-24 Thread Sanjay Patel via Phabricator via cfe-commits
spatel added a comment. In D72467#1839172 , @efriedma wrote: > In D72467#1838591 , @spatel wrote: > > > LGTM, but should get a 2nd opinion since I'm not familiar with some of the > > parts. > > > Any specific part

[PATCH] D71823: Support Swift calling convention for WebAssembly targets

2020-01-24 Thread Derek Schuff via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc5bd3d07262f: Support Swift calling convention for WebAssembly targets (authored by kateinoigakukun, committed by dschuff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c5bd3d0 - Support Swift calling convention for WebAssembly targets

2020-01-24 Thread Derek Schuff via cfe-commits
Author: Yuta Saito Date: 2020-01-24T10:30:46-08:00 New Revision: c5bd3d07262ffda5b21576b9e1e2d2dd2e51fb4b URL: https://github.com/llvm/llvm-project/commit/c5bd3d07262ffda5b21576b9e1e2d2dd2e51fb4b DIFF: https://github.com/llvm/llvm-project/commit/c5bd3d07262ffda5b21576b9e1e2d2dd2e51fb4b.diff

[PATCH] D73237: [CUDA] Fix order of memcpy arguments in __shfl_*(<64-bit type>).

2020-01-24 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. In D73237#1837077 , @tra wrote: > Landed in > https://github.com/llvm/llvm-project/commit/cc14de88da27a8178976972bdc8211c31f7ca9ae > @hans -- can we cherry-pick it into 10? Yes, go ahead and "git cherry-pick -x" it and push to

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

2020-01-24 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. In D73007#1837621 , @rtrieu wrote: > I'm in favor of splitting the warning into subgroups, then deciding which > ones should be in -Wall. We've done this with other warnings such as the > conversion warnings and tautological

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

2020-01-24 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D7#1838988 , @mrutland wrote: > In D7#1837536 , @MaskRay wrote: > > > > > > > > > For `BTI c` issue, GCC has several releases that do not work with > > -mbranch-protection=bti.

[PATCH] D73300: [clang-tidy] Add library for clang-tidy main function

2020-01-24 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin updated this revision to Diff 240241. DmitryPolukhin added a comment. Added #include "ClangTidyMain.h" in ClangTidyMain.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73300/new/ https://reviews.llvm.org/D73300 Files:

[PATCH] D73307: Unique Names for Functions with Internal Linkage

2020-01-24 Thread Sriraman Tallam via Phabricator via cfe-commits
tmsriram marked an inline comment as done. tmsriram added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:966 OPT_fno_unique_section_names, true); + Opts.UniqueInternalFuncNames = Args.hasFlag( +

[PATCH] D71092: [VFS] More consistent support for Windows

2020-01-24 Thread Adrian McCarthy via Phabricator via cfe-commits
amccarth added a comment. cc: +thakis, who expressed interest in seeing a fix for the text exempted on Windows. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71092/new/ https://reviews.llvm.org/D71092 ___ cfe-commits mailing list

[PATCH] D72467: Remove "mask" operand from shufflevector.

2020-01-24 Thread Eli Friedman via Phabricator via cfe-commits
efriedma marked 5 inline comments as done. efriedma added a comment. In D72467#1838591 , @spatel wrote: > LGTM, but should get a 2nd opinion since I'm not familiar with some of the > parts. Any specific part you're worried about?

  1   2   3   >