[PATCH] D73441: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator

2020-01-26 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp:387 + unless(inDecltypeOrTemplateArg()), + unless(hasAncestor(cxxNoexceptExpr( .bind("call-move"); Quuxplusone

[PATCH] D72508: [clangd] Support pseudo-obj expr, opaque values, and property references in findExplicitReferences()

2020-01-26 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:794 +// Not clear why the source expression is skipped by default... +return RecursiveASTVisitor::TraverseStmt(OVE->getSourceExpr()); + } Should this be done by

[PATCH] D69868: Allow "callbr" to return non-void values

2020-01-26 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. It seems that callbr (with output) will now be similar to a catchpad. It can set live-in physical register information. (See `test/CodeGen/X86/{seh-catch-all.ll,seh-exception-code.ll,wineh-coreclr.ll,wineh-exceptionpointer.ll}`) Is there any caveat doing this? Add @rnk

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

2020-01-26 Thread Pengfei Wang via Phabricator via cfe-commits
pengfei marked an inline comment as done. pengfei added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3381 + "constrained mode"); +FMulAdd = Builder.CreateCall( +CGF.CGM.getIntrinsic(llvm::Intrinsic::experimental_constrained_fmuladd,

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

2020-01-26 Thread Pengfei Wang via Phabricator via cfe-commits
pengfei updated this revision to Diff 240474. pengfei added a comment. Address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72820/new/ https://reviews.llvm.org/D72820 Files: clang/lib/CodeGen/CGExprScalar.cpp

[PATCH] D72824: [X86] Add combination for fma and fneg on X86 under strict FP.

2020-01-26 Thread Pengfei Wang via Phabricator via cfe-commits
pengfei updated this revision to Diff 240472. pengfei added a comment. Rebase and add vector instructions test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72824/new/ https://reviews.llvm.org/D72824 Files:

[clang] 59d6908 - [NFC] Fix typo in Clang docs

2020-01-26 Thread Qiu Chaofan via cfe-commits
Author: Qiu Chaofan Date: 2020-01-27T11:37:43+08:00 New Revision: 59d690850eebcd0e37f205bde16edbd4f2a54053 URL: https://github.com/llvm/llvm-project/commit/59d690850eebcd0e37f205bde16edbd4f2a54053 DIFF: https://github.com/llvm/llvm-project/commit/59d690850eebcd0e37f205bde16edbd4f2a54053.diff

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

2020-01-26 Thread Warren Ristow via Phabricator via cfe-commits
wristow added a comment. About: >> This is a bit of an oddity in our handling. > > Yes it is! > > This is certainly getting more complicated than I had originally expected. I > feel there isn't a clear spec on what we want in terms of whether FMA should > be enabled "automatically" at (for

[PATCH] D73439: [ASTMatchers] Add cxxNoexceptExpr AST matcher

2020-01-26 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62196 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73441: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator

2020-01-26 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62199 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73441: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator

2020-01-26 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp:387 + unless(inDecltypeOrTemplateArg()), + unless(hasAncestor(cxxNoexceptExpr( .bind("call-move"); What about

[PATCH] D73439: [ASTMatchers] Add cxxNoexceptExpr AST matcher

2020-01-26 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 240461. njames93 added a comment. - Fix typo in documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73439/new/ https://reviews.llvm.org/D73439 Files: clang/docs/LibASTMatchersReference.html

[PATCH] D73439: [ASTMatchers] Add cxxNoexceptExpr AST matcher

2020-01-26 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62196 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73441: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator

2020-01-26 Thread Nathan James via Phabricator via cfe-commits
njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, JonasToth, hokein, gribozavr2. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Fixes noexcept operator misinterpreted as being evaluated

[PATCH] D73439: [ASTMatchers] Add cxxNoexceptExpr AST matcher

2020-01-26 Thread Nathan James via Phabricator via cfe-commits
njames93 created this revision. njames93 added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds a cxxNoexceptExpr matcher that matches the noexcept operator . Repository: rG LLVM Github

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

2020-01-26 Thread Alexander Lanin via Phabricator via cfe-commits
AlexanderLanin added a comment. In D54943#1815772 , @0x8000- wrote: > This generated 56 "const const" declarations, of which 25 were triple const! I've tried this on ccache (326 fixes, nice!), but some came out as 'const const'. At least in my case

[PATCH] D73434: [Sema] Remove a -Wrange warning from -Wall

2020-01-26 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert added a comment. Looks right to me, but someone else should approve. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73434/new/ https://reviews.llvm.org/D73434 ___ cfe-commits mailing list

[clang] 9c24fca - [Concepts] Fix incorrect TemplateArgs for introduction of local parameters

2020-01-26 Thread Saar Raz via cfe-commits
Author: Saar Raz Date: 2020-01-27T00:59:37+02:00 New Revision: 9c24fca2a33fc0fd059e278bb95c84803dfff9ae URL: https://github.com/llvm/llvm-project/commit/9c24fca2a33fc0fd059e278bb95c84803dfff9ae DIFF: https://github.com/llvm/llvm-project/commit/9c24fca2a33fc0fd059e278bb95c84803dfff9ae.diff

[clang] a8d096a - [Concepts] Add missing null check to transformConstructor

2020-01-26 Thread Saar Raz via cfe-commits
Author: Saar Raz Date: 2020-01-27T00:15:42+02:00 New Revision: a8d096aff6b1930ad57bd0c30077d2b4920b5025 URL: https://github.com/llvm/llvm-project/commit/a8d096aff6b1930ad57bd0c30077d2b4920b5025 DIFF: https://github.com/llvm/llvm-project/commit/a8d096aff6b1930ad57bd0c30077d2b4920b5025.diff

[PATCH] D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers

2020-01-26 Thread Nathan James via Phabricator via cfe-commits
njames93 marked 2 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringInitCheck.cpp:58 + } + if (B.isInvalid() || E.isInvalid()) +return llvm::None; aaron.ballman wrote: > Should we

[PATCH] D73380: [clang] Annotating C++'s `operator new` with more attributes

2020-01-26 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri marked 3 inline comments as done. lebedev.ri added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14361 +/// attributes are applied to declarations. +void Sema::AddKnownFunctionAttributesForReplaceableGlobalAllocationFunction( +FunctionDecl *FD) {

[PATCH] D73380: [clang] Annotating C++'s `operator new` with more attributes

2020-01-26 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14361 +/// attributes are applied to declarations. +void Sema::AddKnownFunctionAttributesForReplaceableGlobalAllocationFunction( +FunctionDecl *FD) { lebedev.ri wrote: > rsmith wrote: > >

[PATCH] D73285: [OpenMP][OMPIRBuilder][BugFix] Handle Unreachable Finalization blocks in `parallel` generation

2020-01-26 Thread Fady Ghanim via Phabricator via cfe-commits
fghanim updated this revision to Diff 240451. fghanim added a comment. Adding a new unittest for the this fix. Thanks to JDoerfert for Writing and providing me with this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73285/new/

[clang] 5043962 - [Concepts] Fix parsing of scope specifier in compound-requirements, add more tests for scope specifiers in type-constraints

2020-01-26 Thread Saar Raz via cfe-commits
Author: Saar Raz Date: 2020-01-26T20:46:53+02:00 New Revision: 5043962dd3150c6ac72b75174b9460a510d1b5c3 URL: https://github.com/llvm/llvm-project/commit/5043962dd3150c6ac72b75174b9460a510d1b5c3 DIFF: https://github.com/llvm/llvm-project/commit/5043962dd3150c6ac72b75174b9460a510d1b5c3.diff

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

2020-01-26 Thread Noel Grandin via Phabricator via cfe-commits
grandinj added a comment. You might want to look at the equivalent LibreOffice checkers, which we have been using for some time https://cgit.freedesktop.org/libreoffice/core/tree/compilerplugins/clang/external.cxx

[PATCH] D73388: NFC: Implement AST node skipping in ParentMapContext

2020-01-26 Thread Stephen Kelly via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf29204d3: NFC: Implement AST node skipping in ParentMapContext (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73388/new/

[clang] f29204d - NFC: Implement AST node skipping in ParentMapContext

2020-01-26 Thread Stephen Kelly via cfe-commits
Author: Stephen Kelly Date: 2020-01-26T18:35:44Z New Revision: f29204d397dc5b6fec83df5f2a77aff17173 URL: https://github.com/llvm/llvm-project/commit/f29204d397dc5b6fec83df5f2a77aff17173 DIFF: https://github.com/llvm/llvm-project/commit/f29204d397dc5b6fec83df5f2a77aff17173.diff

[PATCH] D73434: [Sema] Remove a -Wrange warning from -Wall

2020-01-26 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62197 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running

[PATCH] D73434: [Sema] Remove a -Wrange warning from -Wall

2020-01-26 Thread Mark de Wever via Phabricator via cfe-commits
Mordante created this revision. Mordante added reviewers: aaron.ballman, aaronpuchert, rtrieu, xbolva00. Mordante added a project: clang. During the review of D73007 Aaron Puchert mentioned `warn_for_range_variable_always_copy` shouldn't be part of `-Wall`

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

2020-01-26 Thread Mark de Wever via Phabricator via cfe-commits
Mordante added a comment. Created D73434 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73007/new/ https://reviews.llvm.org/D73007 ___ cfe-commits mailing list

[PATCH] D72331: OpaquePtr: add type to inalloca attribute.

2020-01-26 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. lgtm, thanks! I remember reading through this last week, but apparently I did not hit send. This patch actually prompted me to start working on the replacement for this thing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72331/new/

[PATCH] D71966: [Wdocumentation][RFC] Improve identifier's of \param

2020-01-26 Thread Mark de Wever via Phabricator via cfe-commits
Mordante marked 2 inline comments as done. Mordante added a comment. So if I understand correctly: - `getParamNameAsWritten` will become `getArgText` - The `getParamName` will do the translation from the name in the documentation to the name in the current function declaration. If the parameter

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

2020-01-26 Thread Mark de Wever via Phabricator via cfe-commits
Mordante added a comment. @aaronpuchert, @aaron.ballman I agree with the proposal, I'll work on a patch. @hans Once the patch is accepted I'll send you a pull request and an update for the release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73108: [docs][mips] 10.0 Release notes

2020-01-26 Thread Simon Atanasyan via Phabricator via cfe-commits
atanasyan closed this revision. atanasyan added a comment. Closed by commit rG27f93515 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73108/new/ https://reviews.llvm.org/D73108

[PATCH] D65994: Extended FPOptions with new attributes

2020-01-26 Thread Serge Pavlov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4aea70ed3292: [FPEnv] Extended FPOptions with new attributes (authored by sepavloff). Changed prior to commit: https://reviews.llvm.org/D65994?vs=239893=240432#toc Repository: rG LLVM Github

[clang] 4aea70e - [FPEnv] Extended FPOptions with new attributes

2020-01-26 Thread Serge Pavlov via cfe-commits
Author: Serge Pavlov Date: 2020-01-26T21:03:53+07:00 New Revision: 4aea70ed3292f02aa111ff6894805e2613dd81e8 URL: https://github.com/llvm/llvm-project/commit/4aea70ed3292f02aa111ff6894805e2613dd81e8 DIFF: https://github.com/llvm/llvm-project/commit/4aea70ed3292f02aa111ff6894805e2613dd81e8.diff