[clang] 6bfc45c - Fix build after D72746

Author: Kirill Bobyrev Date: 2020-02-06T08:55:19+01:00 New Revision: 6bfc45cf60d2a82e659d3911c26169ad02cf78c0 URL: https://github.com/llvm/llvm-project/commit/6bfc45cf60d2a82e659d3911c26169ad02cf78c0 DIFF:

[PATCH] D72746: [clangd] Add a flag for spelled references in the Index

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61852 tests passed, 5 failed and 780 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp

[PATCH] D72746: [clangd] Add a flag for spelled references in the Index

This revision was automatically updated to reflect the committed changes. Closed by commit rGa6860c1af457: [clangd] Add a flag for spelled references in the Index (authored by kbobyrev). Changed prior to commit: https://reviews.llvm.org/D72746?vs=242809=242811#toc Repository: rG LLVM Github

[clang-tools-extra] a6860c1 - [clangd] Add a flag for spelled references in the Index

Author: Kirill Bobyrev Date: 2020-02-06T08:18:14+01:00 New Revision: a6860c1af45776e349eaed3e8f0bb7e97abccd89 URL: https://github.com/llvm/llvm-project/commit/a6860c1af45776e349eaed3e8f0bb7e97abccd89 DIFF:

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kbobyrev updated this revision to Diff 242809. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Address another round of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72746/new/ https://reviews.llvm.org/D72746 Files:

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

tejohnson added a comment. In D73242#186 , @thakis wrote: > This makes lld crash when linking chromium's base_unittests and probably does > the same for most other binaries that use both thinlto and cfi: >

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

thakis added a comment. This makes lld crash when linking chromium's base_unittests and probably does the same for most other binaries that use both thinlto and cfi: https://bugs.chromium.org/p/chromium/issues/detail?id=1049434 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73842: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs

ianlevesque updated this revision to Diff 242800. ianlevesque added a comment. Address code review nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73842/new/ https://reviews.llvm.org/D73842 Files: clang/include/clang/Driver/XRayArgs.h

[PATCH] D74104: Remove test dependency on the presence of an assembler

dyung created this revision. dyung added a reviewer: NoQ. dyung added a project: clang. Herald added a subscriber: Charusso. These tests currently call -c which requires an assembler, and will fail if your target defaults to an external assembler that is not present in the test environment. It

[PATCH] D74103: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes.

rsmith created this revision. rsmith added a reviewer: rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. Due to a recent (but retroactive) C++ rule change, only sufficiently C-compatible classes are permitted to be given a typedef name for linkage purposes. Add an

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

rsmith added a comment. Have you considered how this would interact with our other language extensions? Can we form a vector of `_ExtInt(N)`? A `_Complex _ExtInt(N)`? I expect for some of that to just fall out of the implementation, but we should have documentation and test coverage either

[PATCH] D68896: PR43080: Do not build context-sensitive expressions during name classification.

rsmith added a comment. In D68896#1861040 , @rsmith wrote: > In D68896#1778193 , @kianm wrote: > > > Hi, I am still seeing problems with this assertion. Could we please get a > > fix? I've posted the reduced test

[PATCH] D68896: PR43080: Do not build context-sensitive expressions during name classification.

rsmith added a comment. In D68896#1778193 , @kianm wrote: > Hi, I am still seeing problems with this assertion. Could we please get a > fix? I've posted the reduced test case and reproducible command on this > Phabricator patch. Are you still seeing

[PATCH] D69763: [Clang][Test]: Remaining "lld-link2" -> "lld-link"

rnk added a comment. Oh, here's the linker it has found: $ find ../clang/ -iname '*lld-link2' ../clang/test/Driver/Inputs/Windows/ARM/8.1/usr/bin/ld.lld-link2 So this is truly a test of the `ld.otherlinker` feature pattern, not some special case driver feature. I guess we should leave the

[PATCH] D69763: [Clang][Test]: Remaining "lld-link2" -> "lld-link"

rnk added a comment. I applied this locally, but the test doesn't pass. I can look into it tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69763/new/ https://reviews.llvm.org/D69763 ___

[PATCH] D73675: Avoid many std::tie/tuple instantiations in ASTImporter

rnk added a comment. In D73675#1858688 , @shafik wrote: > I forgot to mention this earlier but LLDB is a major user of the > `ASTImporter` and so in general it is a good idea to run `check-lldb` as well. I ran the LLDB tests on Linux, but I get 42

[PATCH] D73966: [analyzer] Add 10.0.0 release notes.

xazax.hun added inline comments. Comment at: clang/docs/ReleaseNotes.rst:405 +- New checker: ``fuchsia.HandleChecker`` to detect leaks related to Fuchsia + handles. NoQ wrote: > D74004 > > 1) The checker is now in alpha. > 2) This checker wasn't enabled in

[PATCH] D74009: [clang] Improve diagnostic note for implicit conversions that are disallowed because they involve more than one user-defined conversion.

logan-5 added a comment. In D74009#1858353 , @rsmith wrote: > Have you looked into whether you can defer the check for conversion via > multiple user-defined conversions until we come to call > `CompleteNonViableCandidate` after finding no viable

[PATCH] D74081: [clang][Analysis] CallGraph: store the actual call `Expr*` in the CallGraphNode::CallRecord

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74081/new/ https://reviews.llvm.org/D74081

[PATCH] D73966: [analyzer] Add 10.0.0 release notes.

NoQ added inline comments. Comment at: clang/docs/ReleaseNotes.rst:405 +- New checker: ``fuchsia.HandleChecker`` to detect leaks related to Fuchsia + handles. D74004 1) The checker is now in alpha. 2) This checker wasn't enabled in the release either, as far

[PATCH] D74004: [analyzer] Move fuchsia.Lock checker to alpha

This revision was automatically updated to reflect the committed changes. Closed by commit rG643dee903ceb: [analyzer] Move fuchsia.Lock checker to alpha (authored by xazax.hun). Changed prior to commit: https://reviews.llvm.org/D74004?vs=242452=242781#toc Repository: rG LLVM Github Monorepo

[clang] 643dee9 - [analyzer] Move fuchsia.Lock checker to alpha

Author: Gabor Horvath Date: 2020-02-05T16:11:06-08:00 New Revision: 643dee903cebdfc5e0101d305add6a5235211465 URL: https://github.com/llvm/llvm-project/commit/643dee903cebdfc5e0101d305add6a5235211465 DIFF: https://github.com/llvm/llvm-project/commit/643dee903cebdfc5e0101d305add6a5235211465.diff

[PATCH] D74004: [analyzer] Move fuchsia.Lock checker to alpha

xazax.hun added a comment. In D74004#1858185 , @NoQ wrote: > Also you'll need to update release notes (D73966 > ) :) I think this was merged after the release branch was created

[PATCH] D74003: [analyzer] Prevent assertion failure in PThreadLockChecker when the implementations of the locking functions are available

This revision was automatically updated to reflect the committed changes. Closed by commit rGe4f4a6c0f5bb: [analyzer] Prevent an assertion failure in PThreadLockChecker (authored by xazax.hun). Changed prior to commit: https://reviews.llvm.org/D74003?vs=242447=242778#toc Repository: rG LLVM

[clang] e4f4a6c - [analyzer] Prevent an assertion failure in PThreadLockChecker

Author: Gabor Horvath Date: 2020-02-05T15:56:56-08:00 New Revision: e4f4a6c0f5bbda5dc0b922816b3fdfce4b75f404 URL: https://github.com/llvm/llvm-project/commit/e4f4a6c0f5bbda5dc0b922816b3fdfce4b75f404 DIFF: https://github.com/llvm/llvm-project/commit/e4f4a6c0f5bbda5dc0b922816b3fdfce4b75f404.diff

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, thegameg, rsmith. Herald added subscribers: ributzka, dexonsmith, jkorous. These temporaries are only used in the callee, and their memory can be reused after the call is complete. rdar://58552124

[PATCH] D69868: Allow "callbr" to return non-void values

void updated this revision to Diff 242752. void added a comment. Use iterator for machine operands. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69868/new/ https://reviews.llvm.org/D69868 Files: llvm/docs/LangRef.rst

[PATCH] D74087: [Sema] Fix Sema checkArgCount function

bsaleil created this revision. bsaleil added a reviewer: rsmith. bsaleil added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes the checkArgCount function in Sema that is used to check the number of arguments of a call when doing custom type-checking. The patch fixes

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

NoQ added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-no-recursion.cpp:153 +// CHECK-NOTES: :[[@LINE-7]]:3: note: Frame #1: function 'boo' calls function 'bar' here: +// CHECK-NOTES: :[[@LINE-14]]:18: note: Frame #2: function 'bar' calls

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

lebedev.ri marked an inline comment as not done. lebedev.ri added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-no-recursion.cpp:153 +// CHECK-NOTES: :[[@LINE-7]]:3: note: Frame #1: function 'boo' calls function 'bar' here: +// CHECK-NOTES:

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

lebedev.ri added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-no-recursion.cpp:153 +// CHECK-NOTES: :[[@LINE-7]]:3: note: Frame #1: function 'boo' calls function 'bar' here: +// CHECK-NOTES: :[[@LINE-14]]:18: note: Frame #2: function 'bar' calls

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

lebedev.ri updated this revision to Diff 242725. lebedev.ri marked an inline comment as done. lebedev.ri added a comment. Fixup disclaimer printing, NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72362/new/ https://reviews.llvm.org/D72362

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. In the absence of any other comments, This LGTM, this may help to resolve D68569: [clang-format] Also look for .{ext}.clang-format file , I

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

lewis-revill updated this revision to Diff 242723. lewis-revill added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62686/new/ https://reviews.llvm.org/D62686 Files: clang/lib/Driver/ToolChains/Arch/RISCV.cpp

[PATCH] D74043: [clang-format] Do not treat C# attribute targets as labels

MyDeveloperDay added a comment. LGTM, thanks for the patch (I've seen this in the wild where the AssemblyInfo.cs gets a bit messed up. Comment at: clang/lib/Format/FormatTokenLexer.cpp:287 + auto = *(Tokens.end() - 2); + auto = *(Tokens.end() - 1); + +1

[PATCH] D69868: Allow "callbr" to return non-void values

MaskRay accepted this revision. MaskRay added a comment. I think this is fine, but want to hear from @jyknight and @rnk. Comment at: llvm/lib/CodeGen/SelectionDAG/ScheduleDAGSDNodes.cpp:1039 + auto = BB->back(); + for (unsigned i = 0; i < Last.getNumOperands(); ++i)

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

NoQ added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-no-recursion.cpp:153 +// CHECK-NOTES: :[[@LINE-7]]:3: note: Frame #1: function 'boo' calls function 'bar' here: +// CHECK-NOTES: :[[@LINE-14]]:18: note: Frame #2: function 'bar' calls

[PATCH] D69868: Allow "callbr" to return non-void values

void added a comment. My apologies for being a pest, but I wanted to know the status of reviews for this bug. @jyknight & @rnk, do you have further comments or need more time? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69868/new/

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/NoRecursionCheck.cpp:21 + +inline bool operator==(const CallGraphNode::CallRecord , + const CallGraphNode::CallRecord ) { NoQ wrote: > lebedev.ri wrote: > >

[PATCH] D74081: [clang][Analysis] CallGraph: store the actual call `Expr*` in the CallGraphNode::CallRecord

lebedev.ri created this revision. lebedev.ri added reviewers: NoQ, erichkeane. lebedev.ri added a project: clang. Herald added a subscriber: Charusso. Storing not just the callee, but the actual call may be interesting for some use-cases. In particular, D72362

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

lebedev.ri updated this revision to Diff 242713. lebedev.ri marked 11 inline comments as done. lebedev.ri added a comment. @NoQ Thank you for taking a look! Rebased, addressed most of the review notes (some tests could be added), split callgraph changes into a separate review. Repository:

[clang] da45bd2 - [VFS] More consistent support for Windows

Author: Adrian McCarthy Date: 2020-02-05T11:38:20-08:00 New Revision: da45bd232165eab5d6ec4f1f4f18db8644289142 URL: https://github.com/llvm/llvm-project/commit/da45bd232165eab5d6ec4f1f4f18db8644289142 DIFF:

[PATCH] D74028: [clang] Add release notes for the 10.x branch for things I've done

mstorsjo closed this revision. mstorsjo added a comment. Committed in https://reviews.llvm.org/rG7e518f3159bd. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74028/new/ https://reviews.llvm.org/D74028

[PATCH] D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name

This revision was automatically updated to reflect the committed changes. Closed by commit rG428583dd22fd: [DebugInfo] Fix debug-info generation for block invocations so that we set the… (authored by shafik). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D73742: [Clang][Driver] After default -fintegrated-cc1, fix report_fatal_error no longer generates preprocessed source + reproducer.sh

aganea added a comment. In D73742#1854810 , @hans wrote: > I think so, but I need to look closer at the CrashRecoveryContext changes, > and it would help to do that separately. I split this into smaller pieces. Please take a look at D74063

[clang] 428583d - [DebugInfo] Fix debug-info generation for block invocations so that we set the LinkageName

Author: shafik Date: 2020-02-05T11:07:30-08:00 New Revision: 428583dd22fdc8f789390822e7b8ef4a5534721d URL: https://github.com/llvm/llvm-project/commit/428583dd22fdc8f789390822e7b8ef4a5534721d DIFF: https://github.com/llvm/llvm-project/commit/428583dd22fdc8f789390822e7b8ef4a5534721d.diff LOG:

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:731 + } + return C.getNoteTag([Text, Name](BugReport ) -> std::string { + SmallString<256> Msg;

[PATCH] D70818: [Analyzer] Model STL Algoirthms to improve the iterator checkers

baloghadamsoftware marked 5 inline comments as done. baloghadamsoftware added a comment. In D70818#1860115 , @Szelethus wrote: > I dont think any of my comments were addressed -- could you follow up? I addressed two, added fixme for another one. Now I

[PATCH] D73636: [AArch64][SVE] SVE2 intrinsics for complex integer arithmetic

kmclaughlin updated this revision to Diff 242683. kmclaughlin edited the summary of this revision. kmclaughlin added a comment. Changed misleading intrinsic class names used with cadd, sqcadd, cmla & sqrdcmlah CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73636/new/

[PATCH] D74076: [Clang][Driver] Remove -M group options before generating crash diagnostics

aganea created this revision. aganea added reviewers: hans, rnk. Herald added a project: clang. Herald added a subscriber: cfe-commits. aganea edited the summary of this revision. When using `-MF file.d` on the command line, `file.d` would not be deleted after a compiler crash. Previously, the

[PATCH] D31343: Add an attribute plugin example

sorawee added inline comments. Comment at: clang/test/Frontend/plugin-attribute.cpp:16 +void fn3() { + // BADATTRIBUTE: error: 'example' attribute only allowed at file scop + int var2 __attribute__((example)); Typo: scope Repository: rG LLVM Github

[PATCH] D70818: [Analyzer] Model STL Algoirthms to improve the iterator checkers

Szelethus added a comment. I dont think any of my comments were addressed -- could you follow up? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70818/new/ https://reviews.llvm.org/D70818 ___

[PATCH] D69763: [Clang][Test]: Remaining "lld-link2" -> "lld-link"

Ericson2314 added a comment. Do I need to do anything more with this, or will somebody else just merge this at come point? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69763/new/ https://reviews.llvm.org/D69763

[PATCH] D74070: [Clang] Don't let gen crash diagnostics fail when '#pragma clang __debug crash' is used

aganea created this revision. aganea added reviewers: hans, rnk. Herald added a project: clang. Herald added a subscriber: cfe-commits. When `#pragma clang __debug crash` is used, currently `Driver::generateCompilationDiagnostics()` doesn't work. The `clang -E` created for diagnostics would

[PATCH] D74071: [Profile] Avoid deadlock in multithreaded context when forking with coverage enabled

calixte created this revision. calixte added a reviewer: marco-c. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, jfb, hiraditya. Herald added projects: clang, Sanitizers, LLVM. When a program is forked with code coverage enabled, all the counters are flushed. To avoid data

[PATCH] D74050: [clang-format] Do not merge short C# class definitions into one line

This revision was automatically updated to reflect the committed changes. Closed by commit rGf40a7972cb42: [clang-format] Do not merge short C# class definitions into one line (authored by Jonathan Coe jb...@google.com). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D73903: [AArch64][SVE] Add remaining SVE2 intrinsics for widening DSP operations

kmclaughlin marked an inline comment as done. kmclaughlin added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:1852 -// SVE2 MLA LANE. -def int_aarch64_sve_smlalb_lane : SVE2_3VectorArg_Indexed_Intrinsic; sdesmalen wrote: > nit: why

[clang] f40a797 - [clang-format] Do not merge short C# class definitions into one line

Author: Jonathan Coe Date: 2020-02-05T17:38:33Z New Revision: f40a7972cb42e130c6e954f21acf9b66bf5bcad7 URL: https://github.com/llvm/llvm-project/commit/f40a7972cb42e130c6e954f21acf9b66bf5bcad7 DIFF: https://github.com/llvm/llvm-project/commit/f40a7972cb42e130c6e954f21acf9b66bf5bcad7.diff LOG:

[PATCH] D74043: [clang-format] Do not treat C# attribute targets as labels

This revision was automatically updated to reflect the committed changes. Closed by commit rGca1fd460f1f5: [clang-format] Do not treat C# attribute targets as labels (authored by Jonathan Coe jb...@google.com). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[clang] ca1fd46 - [clang-format] Do not treat C# attribute targets as labels

Author: Jonathan Coe Date: 2020-02-05T17:30:24Z New Revision: ca1fd460f1f5bc4c200f557b63d69a93e3722175 URL: https://github.com/llvm/llvm-project/commit/ca1fd460f1f5bc4c200f557b63d69a93e3722175 DIFF: https://github.com/llvm/llvm-project/commit/ca1fd460f1f5bc4c200f557b63d69a93e3722175.diff LOG:

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

This revision was automatically updated to reflect the committed changes. Closed by commit rG748bb5a0f196: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70818: [Analyzer] Model STL Algoirthms to improve the iterator checkers

This revision was automatically updated to reflect the committed changes. Closed by commit rGb198f16e1e1c: [Analyzer] Model STL Algoirthms to improve the iterator checkers (authored by baloghadamsoftware). Changed prior to commit: https://reviews.llvm.org/D70818?vs=242607=242647#toc

[PATCH] D74063: [Clang] Remove #pragma clang __debug handle_crash

aganea created this revision. aganea added a reviewer: hans. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. As discussed in D70568 , remove this because it isn't used anywhere, and I think it's better to go

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or applying this patch

[clang] b198f16 - [Analyzer] Model STL Algoirthms to improve the iterator checkers

Author: Adam Balogh Date: 2020-02-05T17:59:08+01:00 New Revision: b198f16e1e1c8ee849008c1b886199eae5bc2e01 URL: https://github.com/llvm/llvm-project/commit/b198f16e1e1c8ee849008c1b886199eae5bc2e01 DIFF: https://github.com/llvm/llvm-project/commit/b198f16e1e1c8ee849008c1b886199eae5bc2e01.diff

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

dblaikie added a comment. If this feature treats a declaration in a header different from one in a primary source file - I think that's problematic from a debug info/debugging perspective (& perhaps a quirk of how this functionality was originally implemented for the kernel feature thingy (the

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74048/new/ https://reviews.llvm.org/D74048

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts :

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

bader updated this revision to Diff 242640. bader added a comment. Applied clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74048/new/ https://reviews.llvm.org/D74048 Files: clang/include/clang/Driver/Options.td

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

aprantl added a comment. If I'm reading the data correctly this means a < 1% increase in .debug_info size? If this is correct, I'm fine with the change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71451/new/ https://reviews.llvm.org/D71451

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

balazske added a comment. Generally, is it a problem if there are multiple checkers that may detect same defects but with different approach? Or should the code of this checker (for example) made more complicated only to filter out cases that may be detected by other checkers too?

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

bader updated this revision to Diff 242639. bader added a comment. Refactor clang/lib/Driver/ToolChains/Clang.cpp in accordance with Alexey's suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74048/new/ https://reviews.llvm.org/D74048

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

balazske added a comment. In D72705#1859157 , @Szelethus wrote: > In D72705#1838324 , @balazske wrote: > > > I am still unsure about how this checker works if the function to check is > > "modeled" or evaluated by

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

NoQ added a comment. `CallGraph` changes look nice, i don't see any immediate problems and it's a nice-to-have thing that other users may benefit from (the static analyzer wouldn't though, it's only interested in topological sorting order on the graph). I guess you could have as well stored a

[PATCH] D74054: [clangd] Include the underlying decls in go-to-definition.

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts :

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

ABataev added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4028-4030 + Arg *SYCLArg = Args.getLastArg(options::OPT_fsycl, options::OPT_fno_sycl); + if (SYCLArg) +IsSYCL = SYCLArg->getOption().matches(options::OPT_fsycl); I suggest to

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or applying this patch

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

bader marked 3 inline comments as done. bader added a comment. Thanks for the prompt review. I've applied your suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74048/new/ https://reviews.llvm.org/D74048

[PATCH] D72762: [ARM][TargetParser] Improve handling of dependencies between target features

This revision was automatically updated to reflect the committed changes. Closed by commit rG3627c91ead93: [ARM][TargetParser] Improve handling of dependencies between target features (authored by chill). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

svenvh added a comment. I have updated the TableGen OpenCL builtin definitions accordingly in 91b3083aecd ("[OpenCL] Fix tblgen support for cl_khr_mipmap_image_writes", 2020-02-05). Repository: rG LLVM Github Monorepo

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

bader updated this revision to Diff 242627. bader added a comment. Applied suggestions from Alexey Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74048/new/ https://reviews.llvm.org/D74048 Files: clang/include/clang/Driver/Options.td

[PATCH] D74054: [clangd] Include the underlying decls in go-to-definition.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/277 Repository: rG LLVM Github Monorepo

[clang] 3627c91 - [ARM][TargetParser] Improve handling of dependencies between target features

Author: Momchil Velikov Date: 2020-02-05T16:07:51Z New Revision: 3627c91ead934486fdb3986b911482a78f101309 URL: https://github.com/llvm/llvm-project/commit/3627c91ead934486fdb3986b911482a78f101309 DIFF: https://github.com/llvm/llvm-project/commit/3627c91ead934486fdb3986b911482a78f101309.diff

[PATCH] D73996: [Sema] Demote call-site-based 'alignment is a power of two' check for AllocAlignAttr into a warning

lebedev.ri updated this revision to Diff 242622. lebedev.ri retitled this revision from "[Sema] Demote 'alignment is not a power of two' error into a warning" to "[Sema] Demote call-site-based 'alignment is a power of two' check for AllocAlignAttr into a warning". lebedev.ri added a comment.

[clang] 91b3083 - [OpenCL] Fix tblgen support for cl_khr_mipmap_image_writes

Author: Sven van Haastregt Date: 2020-02-05T16:05:20Z New Revision: 91b3083aecdcb7beb33d497a94f4467f110b4f6d URL: https://github.com/llvm/llvm-project/commit/91b3083aecdcb7beb33d497a94f4467f110b4f6d DIFF: https://github.com/llvm/llvm-project/commit/91b3083aecdcb7beb33d497a94f4467f110b4f6d.diff

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

thakis added a comment. In D69825#1837243 , @hctim wrote: > For tracking purposes. > > The ASan leaks have been worked around in two separate patches in order to > make the bots green again: > > - c38e42527b21acee8d01a016d5bfa2fb83202e29 >

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks, looks good, a few nits. before landing the patch, could you please run the clangd-indexer on the llvm project and measure the before/after indexing time? to make sure we don't

[PATCH] D74046: [clang][driver] Fix null pointer dereference warning inside PrintActions1 (PR43462)

This revision was automatically updated to reflect the committed changes. Closed by commit rGe63abde39f53: [clang][driver] Fix null pointer dereference warning inside PrintActions1… (authored by RKSimon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e63abde - [clang][driver] Fix null pointer dereference warning inside PrintActions1 (PR43462)

Author: Simon Pilgrim Date: 2020-02-05T15:32:18Z New Revision: e63abde39f530028b0089ea477446c1b671a28f1 URL: https://github.com/llvm/llvm-project/commit/e63abde39f530028b0089ea477446c1b671a28f1 DIFF: https://github.com/llvm/llvm-project/commit/e63abde39f530028b0089ea477446c1b671a28f1.diff

[PATCH] D69582: Let clang driver support parallel jobs

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/Compilation.cpp:332 +if (!Next) { + std::this_thread::yield(); continue; aganea wrote: > yaxunl wrote: > > aganea wrote: > > > In addition to what

[PATCH] D70818: [Analyzer] Model STL Algoirthms to improve the iterator checkers

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks! Tests for the other value of the option are welcome (: CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70818/new/ https://reviews.llvm.org/D70818

[PATCH] D70818: [Analyzer] Model STL Algoirthms to improve the iterator checkers

baloghadamsoftware marked 3 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/STLAlgorithmModeling.cpp:138-139 + SVB.getConditionType()); +assert(Less.getAs() && + "Symbol

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:731 + } + return C.getNoteTag([Text, Name](BugReport ) -> std::string { + SmallString<256> Msg; Szelethus wrote: > NoQ wrote: > > baloghadamsoftware wrote: > >

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

Szelethus added a comment. I strongly agree with this comment: D70878#1780513 , maybe the placement of functions like `getArg` and `getNumArgs` would be most appropriate in `CallDescription`. How about we try to cut down on duplicating functionalities?

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

evgeny777 accepted this revision. evgeny777 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73242/new/ https://reviews.llvm.org/D73242

[PATCH] D70818: [Analyzer] Model STL Algoirthms to improve the iterator checkers

baloghadamsoftware updated this revision to Diff 242607. baloghadamsoftware added a comment. Updated: checker moved to alpha.cplusplus (until at least one of the iterator-related checkers gets out of alpha state or a new non-alpha container checker is created). Error-branch is protected by an

[clang] 569dc65 - [OPNEMP50][DOCS]Mark array shaping expression as claimed, NFC.

Author: Alexey Bataev Date: 2020-02-05T10:02:39-05:00 New Revision: 569dc65c63802e2313aebe702d0233ae101c09cf URL: https://github.com/llvm/llvm-project/commit/569dc65c63802e2313aebe702d0233ae101c09cf DIFF: https://github.com/llvm/llvm-project/commit/569dc65c63802e2313aebe702d0233ae101c09cf.diff

[PATCH] D73128: [OPENMP][NVPTX]Add NVPTX specific definitions for new/delete operators.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd3437a4f791: [OPENMP][NVPTX]Add NVPTX specific definitions for new/delete operators. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] fd3437a - [OPENMP][NVPTX]Add NVPTX specific definitions for new/delete operators.

Author: Alexey Bataev Date: 2020-02-05T09:57:53-05:00 New Revision: fd3437a4f791cb0520e19b87953141fc68543377 URL: https://github.com/llvm/llvm-project/commit/fd3437a4f791cb0520e19b87953141fc68543377 DIFF: https://github.com/llvm/llvm-project/commit/fd3437a4f791cb0520e19b87953141fc68543377.diff

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

richard.barton.arm added inline comments. Comment at: clang/include/clang/Driver/Options.td:264 MetaVarName<"">; +def fcc_fortran_name : Separate<["-"], "ffc-fortran-name">, InternalDriverOpt, + HelpText<"Name for native Fortran compiler">; CarolineConcatto

  1   2   >