[PATCH] D74116: [Sema][C++] Strawman patch to propagate conversion type in order to specialize the diagnostics

2020-02-06 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Hmm. The alternative approach, I suppose, would be to recognize that we're about to emit a generic error and just recheck assignment constraints to recompute the AssignConvertType. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74116/new/

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

2020-02-06 Thread Awanish Pandey via Phabricator via cfe-commits
awpandey added a comment. Thanks @dblaikie for all of your suggestions. I will commit this in 3 patches after getting the green signal from @aprantl. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73462/new/ https://reviews.llvm.org/D73462

[PATCH] D74183: [IRGen] Add an alignment attribute to underaligned sret parameters

2020-02-06 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2077 +getDataLayout().getABITypeAlignment(getTypes().ConvertType(RetTy))) + SRETAttrs.addAlignmentAttr(Align); ArgAttrs[IRFunctionArgs.getSRetArgNo()] = Why only when

[clang] 02fffbb - Fix test after test changes added in da3dc00 caused the test to break

2020-02-06 Thread Douglas Yung via cfe-commits
Author: Douglas Yung Date: 2020-02-06T18:19:01-08:00 New Revision: 02fffbb5fa9f34a16f2c7959364d0668364332a2 URL: https://github.com/llvm/llvm-project/commit/02fffbb5fa9f34a16f2c7959364d0668364332a2 DIFF: https://github.com/llvm/llvm-project/commit/02fffbb5fa9f34a16f2c7959364d0668364332a2.diff

[PATCH] D74070: [Clang] Don't let gen crash diagnostics fail when '#pragma clang __debug crash' is used

2020-02-06 Thread Jordan Rupprecht via Phabricator via cfe-commits
rupprecht added a comment. FYI, temporarily reverted this in fafddbd956dbe439787f6d717c247e648bb07ff5 since it was causing failures in `Clang :: Driver/crash-report.c`. I didn't see the failure on all buildbots (otherwise I

[PATCH] D74076: [Clang][Driver] Remove -M group options before generating crash diagnostics

2020-02-06 Thread Jordan Rupprecht via Phabricator via cfe-commits
rupprecht added a comment. FYI - reverted this too since I had conflicts when also reverting D74070 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74076/new/ https://reviews.llvm.org/D74076

[clang] fafddbd - Revert "[Clang][Driver] Remove -M group options ..." and "[Clang] Avoid crashing when generating crash diagnostics when '#pragma clang __debug ..."

2020-02-06 Thread Jordan Rupprecht via cfe-commits
Author: Jordan Rupprecht Date: 2020-02-06T17:59:15-08:00 New Revision: fafddbd956dbe439787f6d717c247e648bb07ff5 URL: https://github.com/llvm/llvm-project/commit/fafddbd956dbe439787f6d717c247e648bb07ff5 DIFF:

[PATCH] D74150: Update hwasan docs to cover outlined checks and globals.

2020-02-06 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc marked 5 inline comments as done. pcc added inline comments. Comment at: clang/docs/HardwareAssistedAddressSanitizerDesign.rst:87 + bl __hwasan_check_x0_2_short // call outlined tag check +//

[PATCH] D74150: Update hwasan docs to cover outlined checks and globals.

2020-02-06 Thread Peter Collingbourne via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. pcc marked an inline comment as done. Closed by commit rG7931e8eee3da: Update hwasan docs to cover outlined checks and globals. (authored by pcc). Changed prior to commit:

[clang] 7931e8e - Update hwasan docs to cover outlined checks and globals.

2020-02-06 Thread Peter Collingbourne via cfe-commits
Author: Peter Collingbourne Date: 2020-02-06T17:44:43-08:00 New Revision: 7931e8eee3dafe64101dcc1e88276ba81071 URL: https://github.com/llvm/llvm-project/commit/7931e8eee3dafe64101dcc1e88276ba81071 DIFF:

[PATCH] D74103: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes.

2020-02-06 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Okay, if the basic idea is to avoid anything that would need the linkage to be computed, that seems like exactly the right goal. I know one of the awful ways to get an early reference to the anonymous type is to define a typedef of like a pointer to it, then use that

[PATCH] D67983: [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object pointer types.

2020-02-06 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. @jyknight @rjmccall I'm not sure this change is 100% fine. For example, the following code no longer compiles with ARC: @protocol Delegate @end @interface X @end @interface Y @property id d; @end @implementation X + (void)foo:(Y *)y

[PATCH] D74103: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes.

2020-02-06 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. Ugh, you mentioned template argument lists and made me realize we can still reach problem cases that way. And with array bounds. :( I've added back in a diagnostic for the case where we compute the linkage too early for a "C-like" struct. Hopefully people won't hit it

[PATCH] D74103: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes.

2020-02-06 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith updated this revision to Diff 243057. rsmith marked an inline comment as done. rsmith added a comment. Add back a diagnostic for remaining cases that the new langauge rule doesn't handle. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74103: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes.

2020-02-06 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM, assuming that we do indeed want to ban friends. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74103/new/

Re: [clang] ad0e03f - Revert "[FPEnv][X86] Platform-specific builtin constrained FP enablement"

2020-02-06 Thread Craig Topper via cfe-commits
Recommitted at 96400ae2a45c5038ebb4f012f90ffc6dfb30369f ~Craig On Thu, Feb 6, 2020 at 4:23 PM Craig Topper wrote: > You can't generate assembly from a frontend test unless you also put > "REQUIRES: x86-registered-target" in the test > > ~Craig > > > On Thu, Feb 6, 2020 at 4:17 PM Kevin P.

[clang] 96400ae - Recommit "[FPEnv][X86] Platform-specific builtin constrained FP enablement"

2020-02-06 Thread Craig Topper via cfe-commits
Author: Craig Topper Date: 2020-02-06T16:54:35-08:00 New Revision: 96400ae2a45c5038ebb4f012f90ffc6dfb30369f URL: https://github.com/llvm/llvm-project/commit/96400ae2a45c5038ebb4f012f90ffc6dfb30369f DIFF: https://github.com/llvm/llvm-project/commit/96400ae2a45c5038ebb4f012f90ffc6dfb30369f.diff

[PATCH] D74183: [IRGen] Add an alignment attribute to underaligned sret parameters

2020-02-06 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, scanon. Herald added subscribers: ributzka, dexonsmith, jkorous. Without this, LLVM will assume the pointer has the type's alignment, which is undefined if the value is actually underaligned. rdar://58316406

[PATCH] D72242: Fix crash on value dependent bitfields in if conditions in templates

2020-02-06 Thread Elizabeth Andrews via Phabricator via cfe-commits
eandrews updated this revision to Diff 243049. eandrews edited the summary of this revision. eandrews added a comment. Thanks for taking a look Richard. This patch adds the required value-dependency check and sets type-dependency accordingly. CHANGES SINCE LAST ACTION

[PATCH] D74103: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes.

2020-02-06 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith updated this revision to Diff 243048. rsmith marked 3 inline comments as done. rsmith added a comment. Extend assert comment to suggest likely remediations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74103/new/

[clang] 96c8994 - C++ DR2026: static storage duration variables are not zeroed before

2020-02-06 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-02-06T16:37:22-08:00 New Revision: 96c899449b61b866b583560a49c4627f561336fc URL: https://github.com/llvm/llvm-project/commit/96c899449b61b866b583560a49c4627f561336fc DIFF: https://github.com/llvm/llvm-project/commit/96c899449b61b866b583560a49c4627f561336fc.diff

Re: [clang] ad0e03f - Revert "[FPEnv][X86] Platform-specific builtin constrained FP enablement"

2020-02-06 Thread Craig Topper via cfe-commits
You can't generate assembly from a frontend test unless you also put "REQUIRES: x86-registered-target" in the test ~Craig On Thu, Feb 6, 2020 at 4:17 PM Kevin P. Neal via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Kevin P. Neal > Date: 2020-02-06T19:17:14-05:00 > New

[clang] ad0e03f - Revert "[FPEnv][X86] Platform-specific builtin constrained FP enablement"

2020-02-06 Thread Kevin P. Neal via cfe-commits
Author: Kevin P. Neal Date: 2020-02-06T19:17:14-05:00 New Revision: ad0e03fd4c8066843f4138e44661ee0287ceb631 URL: https://github.com/llvm/llvm-project/commit/ad0e03fd4c8066843f4138e44661ee0287ceb631 DIFF: https://github.com/llvm/llvm-project/commit/ad0e03fd4c8066843f4138e44661ee0287ceb631.diff

[PATCH] D74103: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes.

2020-02-06 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:4394 +isa(D)) + continue; + rsmith wrote: > rjmccall wrote: > > This is essentially part of the next paragraph. > > > > I believe `friend` declarations also do not declare

[PATCH] D73536: [analyzer][taint] Remove taint from symbolic expressions if used in comparisons

2020-02-06 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. I think a crucial part of the design is what would we do for the following case: if (x < y || x > z) return; // Here we might not have ranges for x when y and z were symbolic. mySink(x); // requires x to be in [0, 255] So would we warn for the code above? X

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

2020-02-06 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:268 CheckerContext ) { - if (isTainted(State, E, C.getLocationContext()) || isStdin(E, C)) + if (isTainted(State, E,

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

2020-02-06 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:401 +return; + case nonloc::ConcreteIntKind: { +const llvm::APSInt = V.castAs().getValue(); Dealing with only concrete ints might be a good

[PATCH] D74168: [CMake] Make EXCLUDE_FROM_ALL an argument to add_lit_testsuite

2020-02-06 Thread Jonas Devlieghere via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4fe839ef3a51: [CMake] Rename EXCLUDE_FROM_ALL and make it an argument to add_lit_testsuite (authored by JDevlieghere). Herald added projects: clang, Sanitizers, OpenMP. Herald added subscribers:

[PATCH] D74131: [analyzer][taint] Add isTainted debug expression inspection check

2020-02-06 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. Please add a test as well. Otherwise looks good. Comment at: clang/lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp:97 .Case("clang_analyzer_express", ::analyzerExpress) +.StartsWith("clang_analyzer_isTainted", ::analyzerIsTainted)

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

2020-02-06 Thread Alexey Bader via Phabricator via cfe-commits
bader updated this revision to Diff 243029. bader added a comment. Ignore `-sycl-std` if it used in non-SYCL mode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 Files:

[PATCH] D72954: [clang-doc] Improving Markdown Output

2020-02-06 Thread Clayton Wilkinson via Phabricator via cfe-commits
Clayton updated this revision to Diff 243027. Clayton added a comment. Updating tests affected by this change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72954/new/ https://reviews.llvm.org/D72954 Files: clang-tools-extra/clang-doc/HTMLGenerator.cpp

[PATCH] D72954: [clang-doc] Improving Markdown Output

2020-02-06 Thread Clayton Wilkinson via Phabricator via cfe-commits
Clayton reopened this revision. Clayton added a comment. This revision is now accepted and ready to land. Fixing unit tests affected by this change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72954/new/ https://reviews.llvm.org/D72954

[PATCH] D74103: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes.

2020-02-06 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:4394 +isa(D)) + continue; + rjmccall wrote: > This is essentially part of the next paragraph. > > I believe `friend` declarations also do not declare "members", under the same >

[PATCH] D74103: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes.

2020-02-06 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith updated this revision to Diff 243022. rsmith marked 4 inline comments as done. rsmith added a comment. Updates based on review comments from @rjmccall. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74103/new/ https://reviews.llvm.org/D74103

[PATCH] D74103: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes.

2020-02-06 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith updated this revision to Diff 243023. rsmith added a comment. Add test coverage for the 'friend' case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74103/new/ https://reviews.llvm.org/D74103 Files: clang/docs/ReleaseNotes.rst

[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

2020-02-06 Thread Stephane Moore via Phabricator via cfe-commits
stephanemoore accepted this revision. stephanemoore added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72876/new/ https://reviews.llvm.org/D72876

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

2020-02-06 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L created this revision. Xiangling_L added reviewers: hubert.reinterpretcast, cebowleratibm, yusra.syeda, sfertile, jasonliu, xingxue, hfinkel. Xiangling_L added a project: LLVM. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith. Herald added a project: clang. Xiangling_L

[PATCH] D69272: Enable '#pragma STDC FENV_ACCESS' in frontend

2020-02-06 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:386 + if (FPFeatures.allowFEnvAccess()) { +FunctionDecl *F = getCurFunctionDecl(); +F->setUsesFPIntrin(true); There isn't necessarily a current function declaration; this is usable

[PATCH] D74076: [Clang][Driver] Remove -M group options before generating crash diagnostics

2020-02-06 Thread Alexandre Ganea via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf41ec709d9d3: [Clang][Driver] Remove -M group options before generating crash diagnostics (authored by aganea). Changed prior to commit: https://reviews.llvm.org/D74076?vs=242676=242992#toc

[clang] 38fd699 - [Concepts] Fix incorrect check when instantiating abbreviated template type-constraints

2020-02-06 Thread Saar Raz via cfe-commits
Author: Saar Raz Date: 2020-02-06T23:29:07+02:00 New Revision: 38fd69995fc5a6f16e0aa132a46e5ccdbc2eebb3 URL: https://github.com/llvm/llvm-project/commit/38fd69995fc5a6f16e0aa132a46e5ccdbc2eebb3 DIFF: https://github.com/llvm/llvm-project/commit/38fd69995fc5a6f16e0aa132a46e5ccdbc2eebb3.diff

[clang] f41ec70 - [Clang][Driver] Remove -M group options before generating crash diagnostics

2020-02-06 Thread Alexandre Ganea via cfe-commits
Author: Alexandre Ganea Date: 2020-02-06T16:23:25-05:00 New Revision: f41ec709d9d388dc43469e6ac7f51b6313f7e4af URL: https://github.com/llvm/llvm-project/commit/f41ec709d9d388dc43469e6ac7f51b6313f7e4af DIFF:

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

2020-02-06 Thread Erich Keane via Phabricator via cfe-commits
erichkeane updated this revision to Diff 242984. erichkeane added a comment. Fixed test that expected _Complex _ExtInt to fail. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73967/new/ https://reviews.llvm.org/D73967 Files: clang/docs/LanguageExtensions.rst

[PATCH] D74070: [Clang] Don't let gen crash diagnostics fail when '#pragma clang __debug crash' is used

2020-02-06 Thread Alexandre Ganea via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. aganea marked 2 inline comments as done. Closed by commit rG5fedc2b41085: [Clang] Avoid crashing when generating crash diagnostics when #pragma clang… (authored by aganea). Changed prior to commit:

[clang] 5fedc2b - [Clang] Avoid crashing when generating crash diagnostics when '#pragma clang __debug [assert|crash|parser_crash|llvm_fatal_error|llvm_unreachable|overflow_stack]' are used

2020-02-06 Thread Alexandre Ganea via cfe-commits
Author: Alexandre Ganea Date: 2020-02-06T15:48:51-05:00 New Revision: 5fedc2b410853a6aef05e8edf19ebfc4e071e28f URL: https://github.com/llvm/llvm-project/commit/5fedc2b410853a6aef05e8edf19ebfc4e071e28f DIFF:

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

2020-02-06 Thread Erich Keane via Phabricator via cfe-commits
erichkeane updated this revision to Diff 242982. erichkeane added a comment. Herald added a subscriber: jfb. Add _Complex support for these types. As it turns out, they 'just work'! I added a check to the same place we check 'int' in the declaration specifiers, and the IR that gets generated

[PATCH] D74063: [Clang] Remove #pragma clang __debug handle_crash

2020-02-06 Thread Alexandre Ganea via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8ecde3ac34bb: [Clang] Remove unused #pragma clang __debug handle_crash (authored by aganea). Changed prior to commit: https://reviews.llvm.org/D74063?vs=242644=242980#toc Repository: rG LLVM Github

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

2020-02-06 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:3697 + + args.add(EmitAnyExpr(E, ArgSlot), type); } erik.pilkington wrote: > rjmccall wrote: > > If the argument type has a C++ destructor, will we end its lifetime before > > we call

[clang] 80e17e5 - [FPEnv][X86] Speculative fix for failures introduced by eda495426.

2020-02-06 Thread Kevin P. Neal via cfe-commits
Author: Kevin P. Neal Date: 2020-02-06T15:28:36-05:00 New Revision: 80e17e5fcc09dc5baa940022e6988fcb08c5d92d URL: https://github.com/llvm/llvm-project/commit/80e17e5fcc09dc5baa940022e6988fcb08c5d92d DIFF: https://github.com/llvm/llvm-project/commit/80e17e5fcc09dc5baa940022e6988fcb08c5d92d.diff

[clang] 8ecde3a - [Clang] Remove unused #pragma clang __debug handle_crash

2020-02-06 Thread Alexandre Ganea via cfe-commits
Author: Alexandre Ganea Date: 2020-02-06T15:27:04-05:00 New Revision: 8ecde3ac34bbb5a8d53d8ec5cd32867658646df1 URL: https://github.com/llvm/llvm-project/commit/8ecde3ac34bbb5a8d53d8ec5cd32867658646df1 DIFF:

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

2020-02-06 Thread Ronan Keryell via Phabricator via cfe-commits
keryell added a comment. In D73967#1862273 , @erichkeane wrote: > At the moment it doesn't work because of parsing. I'm unaware of there is a > deeper limitation, but I'll look at it. I was unaware that we allow integral > types for _Complex, I'd

[clang-tools-extra] da3dc00 - PR44684: Look through parens and similar constructs when determining

2020-02-06 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-02-06T12:21:54-08:00 New Revision: da3dc0011e06c9f1aebe71d76eae92dc76e3db2e URL: https://github.com/llvm/llvm-project/commit/da3dc0011e06c9f1aebe71d76eae92dc76e3db2e DIFF: https://github.com/llvm/llvm-project/commit/da3dc0011e06c9f1aebe71d76eae92dc76e3db2e.diff

[clang] 6f5a159 - [clang][driver] Clean up unnecessary reference to TC. NFC.

2020-02-06 Thread Michael Liao via cfe-commits
Author: Michael Liao Date: 2020-02-06T15:14:21-05:00 New Revision: 6f5a159eab8d3fecdbbc741a38c970c0149b3c96 URL: https://github.com/llvm/llvm-project/commit/6f5a159eab8d3fecdbbc741a38c970c0149b3c96 DIFF: https://github.com/llvm/llvm-project/commit/6f5a159eab8d3fecdbbc741a38c970c0149b3c96.diff

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

2020-02-06 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington planned changes to this revision. erik.pilkington marked an inline comment as done. erik.pilkington added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:3697 + + args.add(EmitAnyExpr(E, ArgSlot), type); } rjmccall wrote: > If the

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

2020-02-06 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D73967#1862268 , @rsmith wrote: > We allow _Complex T for integral types T in general, so this seems > inconsistent. Are there problems supporting this? Is it just a parser > limitation or something deeper? If there's some

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

2020-02-06 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In D73967#1861757 , @erichkeane wrote: > Extended-vector types don't really make sense for non-powers-of-two (plus > have some odd gotchas when it comes to vectors of i1 for example), so I've > added a test that shows that this

[PATCH] D74150: Update hwasan docs to cover outlined checks and globals.

2020-02-06 Thread Kostya Serebryany via Phabricator via cfe-commits
kcc accepted this revision. kcc added a comment. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74150/new/ https://reviews.llvm.org/D74150 ___ cfe-commits mailing list

[PATCH] D74150: Update hwasan docs to cover outlined checks and globals.

2020-02-06 Thread Mitch Phillips via Phabricator via cfe-commits
hctim added inline comments. Comment at: clang/docs/HardwareAssistedAddressSanitizerDesign.rst:73 +and performance overhead of the call is reduced by using a custom calling +convention that preserves most registers and is specialized to the register +containing the address and

[PATCH] D74150: Update hwasan docs to cover outlined checks and globals.

2020-02-06 Thread Evgenii Stepanov via Phabricator via cfe-commits
eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/docs/HardwareAssistedAddressSanitizerDesign.rst:87 + bl __hwasan_check_x0_2_short // call outlined tag check +

[PATCH] D73570: [FPEnv][X86] Platform-specific builtin constrained FP enablement

2020-02-06 Thread Kevin P. Neal via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG208470dd5d0a: [FPEnv][X86] Platform-specific builtin constrained FP enablement (authored by kpn). Repository: rG LLVM

[PATCH] D74087: [Sema] Fix Sema checkArgCount function

2020-02-06 Thread Baptiste Saleil via Phabricator via cfe-commits
bsaleil updated this revision to Diff 242963. bsaleil added a comment. Adding test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74087/new/ https://reviews.llvm.org/D74087 Files: clang/lib/Sema/SemaChecking.cpp clang/test/Sema/custom-checking.c Index:

[clang] 208470d - [FPEnv][X86] Platform-specific builtin constrained FP enablement

2020-02-06 Thread Kevin P. Neal via cfe-commits
Author: Kevin P. Neal Date: 2020-02-06T14:20:44-05:00 New Revision: 208470dd5d0a46bc3c24b66489b687eda4954262 URL: https://github.com/llvm/llvm-project/commit/208470dd5d0a46bc3c24b66489b687eda4954262 DIFF: https://github.com/llvm/llvm-project/commit/208470dd5d0a46bc3c24b66489b687eda4954262.diff

[PATCH] D74150: Update hwasan docs to cover outlined checks and globals.

2020-02-06 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc created this revision. pcc added reviewers: eugenis, hctim, kcc. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74150 Files: clang/docs/HardwareAssistedAddressSanitizerDesign.rst Index:

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

2020-02-06 Thread Erich Keane via Phabricator via cfe-commits
erichkeane updated this revision to Diff 242961. erichkeane added a comment. Deal with _Atomic. There isn't really a sensible way to do _Atomics on all platforms for these types, so this patch now limits to the LLVM atomic instruction limits, which is powers-of-2 >=8. CHANGES SINCE LAST

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

2020-02-06 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:3697 + + args.add(EmitAnyExpr(E, ArgSlot), type); } If the argument type has a C++ destructor, will we end its lifetime before we call destructors at the end of the full-expression?

[PATCH] D74103: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes.

2020-02-06 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Oh thank goodness, they finally fixed this. Comment at: clang/lib/Sema/SemaDecl.cpp:4365 + // C++ [dcl.typedef]p9: [P1766R1] + // An unnamed class with a typedef name for linkage purposes shall not + if (RD->isInvalidDecl())

[PATCH] D74146: [SytemZ] Disable vector ABI when using option -march=arch[8|9|10]

2020-02-06 Thread Kai Nacke via Phabricator via cfe-commits
Kai created this revision. Kai added a reviewer: uweigand. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. When specifying -march=arch[8|9|10], those CPU types do NOT support the vector extension. In this case the vector ABI must be disabled.

[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

2020-02-06 Thread Michael Wyman via Phabricator via cfe-commits
mwyman added a comment. Updated based on feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72876/new/ https://reviews.llvm.org/D72876 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

2020-02-06 Thread Michael Wyman via Phabricator via cfe-commits
mwyman updated this revision to Diff 242947. mwyman marked an inline comment as done. mwyman added a comment. Make check class `final`, based on feedback.` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72876/new/ https://reviews.llvm.org/D72876

[PATCH] D68720: Support -fstack-clash-protection for x86

2020-02-06 Thread serge via Phabricator via cfe-commits
serge-sans-paille added a subscriber: hans. serge-sans-paille added a comment. I would love too, @hans what do you think? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

2020-02-06 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev created this revision. ABataev added reviewers: rjmccall, rsmith. Herald added subscribers: arphaman, guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. Added basic representation and parsing/sema handling of array-shaping operations. Array shaping expression is

[clang-tools-extra] d5e6e0a - Fix build after D74112

2020-02-06 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2020-02-06T11:41:17+01:00 New Revision: d5e6e0a58b188627084d4714a4b2862c529870f8 URL: https://github.com/llvm/llvm-project/commit/d5e6e0a58b188627084d4714a4b2862c529870f8 DIFF:

[PATCH] D68720: Support -fstack-clash-protection for x86

2020-02-06 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru added a comment. In D68720#1862050 , @xbolva00 wrote: > Any plans to merge this feature to 10 release? I would love to have it in -10 for Firefox ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73842: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs

2020-02-06 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. I can commit this for you, but is it possible to write a test case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73842/new/ https://reviews.llvm.org/D73842 ___ cfe-commits

[clang] 65f0785 - [ubsan] Omit return value check when return block is unreachable

2020-02-06 Thread Vedant Kumar via cfe-commits
Author: Vedant Kumar Date: 2020-02-06T10:24:03-08:00 New Revision: 65f0785fff0e45f8cd1b9e90328597197beef899 URL: https://github.com/llvm/llvm-project/commit/65f0785fff0e45f8cd1b9e90328597197beef899 DIFF: https://github.com/llvm/llvm-project/commit/65f0785fff0e45f8cd1b9e90328597197beef899.diff

[PATCH] D68720: Support -fstack-clash-protection for x86

2020-02-06 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added a comment. Any plans to merge this feature to 10 release? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 ___ cfe-commits mailing list

[PATCH] D68720: Support -fstack-clash-protection for x86

2020-02-06 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720

[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

2020-02-06 Thread Ben Hamilton via Phabricator via cfe-commits
benhamilton accepted this revision. benhamilton added a comment. LGTM, just one nit-pick. Comment at: clang-tools-extra/clang-tidy/objc/DeallocInCategoryCheck.h:24 +/// http://clang.llvm.org/extra/clang-tidy/checks/objc-dealloc-in-category.html +class DeallocInCategoryCheck :

[clang] 318d0ed - Fix warning on unused variables. NFC.

2020-02-06 Thread Michael Liao via cfe-commits
Author: Michael Liao Date: 2020-02-06T12:21:20-05:00 New Revision: 318d0ede572080f18d0106dbc354e11c88329a84 URL: https://github.com/llvm/llvm-project/commit/318d0ede572080f18d0106dbc354e11c88329a84 DIFF: https://github.com/llvm/llvm-project/commit/318d0ede572080f18d0106dbc354e11c88329a84.diff

[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

2020-02-06 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/include/clang/Serialization/ASTRecordReader.h:272 + + template <> OpenMPTraitInfo *readUserType() { return readOpenMPTraitInfo(); } + kiranchandramohan wrote: >

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

2020-02-06 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4030-4031 + if (Arg *A = Args.getLastArg(options::OPT_sycl_std_EQ)) { +A->render(Args, CmdArgs); + } else if (IsSYCL) { bader wrote: > ABataev wrote: > > bader wrote: > > >

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

2020-02-06 Thread Alexey Bader via Phabricator via cfe-commits
bader marked an inline comment as done. bader added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4030-4031 + if (Arg *A = Args.getLastArg(options::OPT_sycl_std_EQ)) { +A->render(Args, CmdArgs); + } else if (IsSYCL) { ABataev wrote:

[PATCH] D74134: [ARM][MVE] Add fixed point vector conversion intrinsics

2020-02-06 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG2694cc3dca94: [ARM][MVE] Add fixed point vector conversion intrinsics (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74134/new/

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

2020-02-06 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4030-4031 + if (Arg *A = Args.getLastArg(options::OPT_sycl_std_EQ)) { +A->render(Args, CmdArgs); + } else if (IsSYCL) { bader wrote: > ABataev wrote: > > Should this option

[PATCH] D74134: [ARM][MVE] Add fixed point vector conversion intrinsics

2020-02-06 Thread Mark Murray via Phabricator via cfe-commits
MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. This looks familiar and reassuring. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74134/new/ https://reviews.llvm.org/D74134

[clang] 2694cc3 - [ARM][MVE] Add fixed point vector conversion intrinsics

2020-02-06 Thread Mikhail Maltsev via cfe-commits
Author: Mikhail Maltsev Date: 2020-02-06T16:49:45Z New Revision: 2694cc3dca94dbaec15eea40bf69872e0b0d8a5c URL: https://github.com/llvm/llvm-project/commit/2694cc3dca94dbaec15eea40bf69872e0b0d8a5c DIFF: https://github.com/llvm/llvm-project/commit/2694cc3dca94dbaec15eea40bf69872e0b0d8a5c.diff

[PATCH] D73644: [Mips] Add intrinsics for 4-byte and 8-byte MSA loads/stores.

2020-02-06 Thread Simon Atanasyan via Phabricator via cfe-commits
atanasyan added a comment. I see, thanks. Is there the same or similar functionality in GCC? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73644/new/ https://reviews.llvm.org/D73644 ___ cfe-commits

[PATCH] D74134: [ARM][MVE] Add fixed point vector conversion intrinsics

2020-02-06 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: simon_tatham, ostannard, MarkMurrayARM, dmgreen. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. This patch implements the following Arm ACLE MVE intrinsics: - vcvtq_n_* -

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

2020-02-06 Thread Alexey Bader via Phabricator via cfe-commits
bader marked 7 inline comments as done. bader added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4030-4031 + if (Arg *A = Args.getLastArg(options::OPT_sycl_std_EQ)) { +A->render(Args, CmdArgs); + } else if (IsSYCL) { ABataev wrote:

[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

2020-02-06 Thread Kiran Chandramohan via Phabricator via cfe-commits
kiranchandramohan added inline comments. Comment at: clang/include/clang/Serialization/ASTRecordReader.h:272 + + template <> OpenMPTraitInfo *readUserType() { return readOpenMPTraitInfo(); } + jdoerfert wrote: > kiranchandramohan wrote: > > Compiler throws up

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

2020-02-06 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4030-4031 + if (Arg *A = Args.getLastArg(options::OPT_sycl_std_EQ)) { +A->render(Args, CmdArgs); + } else if (IsSYCL) { Should this option also be controlled by `-fsycl`?

[PATCH] D74125: [clangd] Set "spelled" flag for constructor references.

2020-02-06 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGca9fd22adb5a: [clangd] Set spelled flag for constructor references. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D74125?vs=242890=242911#toc Repository: rG LLVM Github

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

2020-02-06 Thread Alexey Bader via Phabricator via cfe-commits
bader updated this revision to Diff 242909. bader marked 2 inline comments as done. bader added a comment. Applied Alexey's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 Files:

[PATCH] D74125: [clangd] Set "spelled" flag for constructor references.

2020-02-06 Thread Haojian Wu via Phabricator via cfe-commits
hokein marked 3 inline comments as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:597 +bool IsTargetKind = NameKind == DeclarationName::Identifier || + NameKind == DeclarationName::CXXConstructorName; +

[clang-tools-extra] ca9fd22 - [clangd] Set "spelled" flag for constructor references.

2020-02-06 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2020-02-06T16:59:45+01:00 New Revision: ca9fd22adb5a633429ea85d2d62e5414ca35ab11 URL: https://github.com/llvm/llvm-project/commit/ca9fd22adb5a633429ea85d2d62e5414ca35ab11 DIFF: https://github.com/llvm/llvm-project/commit/ca9fd22adb5a633429ea85d2d62e5414ca35ab11.diff

[PATCH] D74131: [analyzer][taint] Add isTainted debug expression inspection check

2020-02-06 Thread Balázs Benics via Phabricator via cfe-commits
steakhal created this revision. steakhal added reviewers: NoQ, Szelethus. steakhal added a project: clang. Herald added subscribers: cfe-commits, Charusso, donat.nagy, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, whisperity. This patch introduces the

[PATCH] D73637: Fix handling of OO_Spaceship in DecodeOperatorCall

2020-02-06 Thread Stephan Bergmann via Phabricator via cfe-commits
sberg added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73637/new/ https://reviews.llvm.org/D73637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74129: Prefer __vector over vector keyword for altivec use

2020-02-06 Thread serge via Phabricator via cfe-commits
serge-sans-paille created this revision. serge-sans-paille added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. serge-sans-paille added a subscriber: hans. serge-sans-paille added a comment. serge-sans-paille added a reviewer: hans. @hans : clang

[PATCH] D74129: Prefer __vector over vector keyword for altivec use

2020-02-06 Thread serge via Phabricator via cfe-commits
serge-sans-paille added a subscriber: hans. serge-sans-paille added a comment. @hans : clang 10.0.0rc1 doesn't build on ppc64le in Fedora without that patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74129/new/

[PATCH] D68720: Support -fstack-clash-protection for x86

2020-02-06 Thread serge via Phabricator via cfe-commits
serge-sans-paille added a comment. @craig.topper up :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

2020-02-06 Thread Erich Keane via Phabricator via cfe-commits
erichkeane marked an inline comment as done. erichkeane added a comment. In D73967#1861073 , @rsmith wrote: > Have you considered how this would interact with our other language > extensions? Can we form a vector of `_ExtInt(N)`? A `_Complex _ExtInt(N)`?

  1   2   >