[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

steakhal added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:300-301 + `cert-con36-c `_, `bugprone-spuriously-wake-up-functions `_, "Yes" + `cert-con54-cpp `_, `bugprone-spuriously-wake-up-functions `_, "Yes" `cert-dcl03-c `_,

[PATCH] D74463: Add new check avoid-adjacent-unrelated-parameters-of-the-same-type

vingeldal updated this revision to Diff 244072. vingeldal added a comment. Updating D74463 : Add new check avoid-adjacent-unrelated-parameters-of-the-same-type - Changed commit message to start with [clang-tidy] Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D74463: Add new check avoid-adjacent-unrelated-parameters-of-the-same-type

vingeldal created this revision. Herald added subscribers: cfe-commits, kbarton, mgorny, nemanjai. Herald added a project: clang. This check is part of the C++ Core Guidelines, rule I.24 https://github.com/vingeldal/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#Ri-unrelated Repository:

[PATCH] D74456: Reland "[Support] make report_fatal_error `abort` instead of `exit`"

MaskRay added a comment. `ninja check-llvm check-clang` passed on a powerpc64le machine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74456/new/ https://reviews.llvm.org/D74456 ___ cfe-commits

[PATCH] D74456: Reland "[Support] make report_fatal_error `abort` instead of `exit`"

ychen added a comment. In D74456#1871238 , @MaskRay wrote: > `ninja check-llvm check-clang` passed on a powerpc64le machine. Thanks for the review. Fingers crossed sanitizer bots not complain. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D72579: Evaluate __{c11_,}atomic_is_lock_free to 0 (avoid libcall) if larger than MaxAtomicPromoteWidth

MaskRay added a comment. From https://gcc.gnu.org/ml/gcc/2020-02/msg00116.html > We discussed this on IRC in #gcc. There was no motivation to change GCC. The > platform that wants to avoid the libatomic dependency doesn't use GCC anyway. > Relying on not getting the libatomic dependency seems

[PATCH] D74447: [Clang] After integrated-cc1, ignore -disable-free when there are more than one job in the queue

aganea updated this revision to Diff 244055. aganea marked 3 inline comments as done. aganea added a comment. As suggested by Reid. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74447/new/ https://reviews.llvm.org/D74447 Files: clang/include/clang/Driver/Job.h

[PATCH] D71775: [ThreadPool] On Windows, extend usage to all CPU sockets and all NUMA groups

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Herald added a reviewer: rriddle. Herald added a subscriber: Joonsoo. This revision now requires review to proceed. lgtm Comment at: llvm/lib/Support/Unix/Threading.inc:273 + +int

[PATCH] D74455: [MS] Pass aligned, non-trivially copyable things indirectly on x86

rnk created this revision. rnk added reviewers: craig.topper, erichkeane. Herald added a project: clang. This is a follow-up to case 1 in D72114 . The C++ argument classification logic supersedes the C rules, so we have to add a second check for overaligned

[PATCH] D74372: [OpenMP][IRBuilder] Perform finalization (incl. outlining) late

jdoerfert added a comment. I think this fixes the bug and allows loop optimizations later, let me know if there is anything else Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74372/new/ https://reviews.llvm.org/D74372

[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

jdoerfert marked 4 inline comments as done. jdoerfert added a comment. @kiranchandramohan @JonChesterfield I will address the comments just made, if you think this is otherwise fine it would be good if you accept the patch (it's been around for weeks so it's not really people didn't have a

[PATCH] D74452: [MS] Mark vectorcall FP and vector args inreg

rnk created this revision. rnk added reviewers: craig.topper, erichkeane. Herald added a project: clang. This has no effect on how LLVM passes the arguments, but it prevents rewriteWithInAlloca from thinking that these parameters should be part of the inalloca pack. Follow-up to D72114

[PATCH] D71037: [Diagnostic] Add ftabstop to -Wmisleading-indentation

efriedma added a comment. I just ran into this warning, and I think there's a bit of a discoverability problem related to the width of tabs and -ftabstop. If you have mixed tabs and spaces, and you've correctly specified the tab stop width with -ftabstop, everything works fine. If you

[clang] 2c6a389 - Re-land "[MS] Overhaul how clang passes overaligned args on x86_32"

Author: Reid Kleckner Date: 2020-02-11T16:49:28-08:00 New Revision: 2c6a3896ab1de706389f27c921cf58084650f439 URL: https://github.com/llvm/llvm-project/commit/2c6a3896ab1de706389f27c921cf58084650f439 DIFF: https://github.com/llvm/llvm-project/commit/2c6a3896ab1de706389f27c921cf58084650f439.diff

[PATCH] D74447: [Clang] After integrated-cc1, ignore -disable-free when there are more than one job in the queue

rnk added inline comments. Comment at: clang/include/clang/Driver/Job.h:59 /// Whether to print the input filenames when executing. bool PrintInputFilenames = false; Pack a new field after an existing bool for maximum micro optimization. :)

[PATCH] D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

Wawha added a comment. Thank you @MyDeveloperDay for the validation! I'm happy that my contribution (and my work to do it well) is accepted. And yes, I will be there to help to maintain that code and fix bugs if necessary. About the permission in order to land that patch, I'm not sure that I

[PATCH] D74447: [Clang] After integrated-cc1, ignore -disable-free when there are more than one job in the queue

aganea updated this revision to Diff 244028. aganea edited the summary of this revision. aganea added a comment. Wording. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74447/new/ https://reviews.llvm.org/D74447 Files: clang/include/clang/Driver/Job.h clang/lib/Driver/Driver.cpp

[PATCH] D73742: [Clang][Driver] After default -fintegrated-cc1, fix report_fatal_error no longer generates preprocessed source + reproducer.sh

smeenai added a comment. In D73742#1871012 , @aganea wrote: > In D73742#1870961 , @smeenai wrote: > > > I'm assuming this needs to be picked to 10.0? > > > Yes! Is it up to the authors to integrate their patches to

[PATCH] D73742: [Clang][Driver] After default -fintegrated-cc1, fix report_fatal_error no longer generates preprocessed source + reproducer.sh

aganea marked an inline comment as done. aganea added a comment. In D73742#1870961 , @smeenai wrote: > I'm assuming this needs to be picked to 10.0? Yes! Is it up to the authors to integrate their patches to the release branch? I'm seeing @hans is

[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

kiranchandramohan added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:6575 +template <> void ASTRecordWriter::writeUserType(OMPTraitInfo *TI) { + writeUInt32(TI->Sets.size()); Had to also move this up in the file to avoid an instantiation

[PATCH] D73742: [Clang][Driver] After default -fintegrated-cc1, fix report_fatal_error no longer generates preprocessed source + reproducer.sh

smeenai added a comment. I'm assuming this needs to be picked to 10.0? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73742/new/ https://reviews.llvm.org/D73742 ___ cfe-commits mailing list

[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

kiranchandramohan added a comment. Looks OK to me. Couple of comments inline. Comment at: clang/include/clang/Serialization/ASTRecordReader.h:272 + + template <> OpenMPTraitInfo *readUserType() { return readOpenMPTraitInfo(); } + jdoerfert wrote: > jdoerfert

[PATCH] D74423: Use C++14-style return type deduction in clang.

This revision was automatically updated to reflect the committed changes. Closed by commit rGac66c61bf946: Use C++14-style return type deduction in clang. (authored by jlebar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74423/new/

[clang] ac66c61 - Use C++14-style return type deduction in clang.

Author: Justin Lebar Date: 2020-02-11T14:41:22-08:00 New Revision: ac66c61bf9463bf419102ad8b6565dcbc495b0ab URL: https://github.com/llvm/llvm-project/commit/ac66c61bf9463bf419102ad8b6565dcbc495b0ab DIFF: https://github.com/llvm/llvm-project/commit/ac66c61bf9463bf419102ad8b6565dcbc495b0ab.diff

[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

jdoerfert added a comment. @kiranchandramohan Do you have more input on this one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71830/new/ https://reviews.llvm.org/D71830 ___ cfe-commits mailing list

[PATCH] D74447: [Clang] After integrated-cc1, ignore -disable-free when there are more than one job in the queue

aganea created this revision. aganea added reviewers: hans, thakis, rnk, erichkeane. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. A `CC1Command` was previously always burying pointers (ie. skipping object deletion). This lead to higher memory usage scenarios,

[PATCH] D74372: [OpenMP][IRBuilder] Perform finalization (incl. outlining) late

vsk added inline comments. Comment at: llvm/lib/Transforms/Utils/CodeExtractor.cpp:1408 - // See llvm.org/PR44560, OpenMP passes an invalid subprogram to CodeExtractor. - bool NeedWorkaroundForOpenMPIRBuilderBug = - OldSP && OldSP->getRetainedNodes()->isTemporary(); -

[PATCH] D74372: [OpenMP][IRBuilder] Perform finalization (incl. outlining) late

jdoerfert updated this revision to Diff 244005. jdoerfert added a comment. Improve comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74372/new/ https://reviews.llvm.org/D74372 Files: clang/lib/CodeGen/CodeGenFunction.cpp

[PATCH] D74386: [SVE] Update API ConstantVector::getSplat() to use ElementCount.

efriedma added a comment. This is sort of a large number of functional changes, but it's probably okay to skip test coverage for all the simple getNumElements->getElementCount changes; it's obvious it can't break anything. Comment at:

[PATCH] D74372: [OpenMP][IRBuilder] Perform finalization (incl. outlining) late

jdoerfert added a comment. In D74372#1870620 , @vsk wrote: > Thanks :). IIRC `check-clang` is enough to exercise the relevant code path, > as we get an assert in CodeExtractor without the workaround. (side note: > please don't take my comments here as

[PATCH] D74372: [OpenMP][IRBuilder] Perform finalization (incl. outlining) late

jdoerfert updated this revision to Diff 244002. jdoerfert marked 6 inline comments as done. jdoerfert added a comment. Removed OMPIRBuilder workaround in extractor and addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74372/new/

[clang] 99c5bcb - Revert "Change clang option -ffp-model=precise to select ffp-contract=on"

Author: Melanie Blower Date: 2020-02-11T14:20:00-08:00 New Revision: 99c5bcbce89f07e68ccd89891a0300346705d013 URL: https://github.com/llvm/llvm-project/commit/99c5bcbce89f07e68ccd89891a0300346705d013 DIFF:

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

andrew.w.kaylor added inline comments. Comment at: clang/docs/UsersManual.rst:1388 - * ``precise`` Disables optimizations that are not value-safe on floating-point data, although FP contraction (FMA) is enabled (``-ffp-contract=fast``). This is the default behavior. *

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

This revision was automatically updated to reflect the committed changes. mibintc marked 2 inline comments as done. Closed by commit rG3fcdf2fa945a: Change clang option -ffp-model=precise to select ffp-contract=on (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 3fcdf2f - Change clang option -ffp-model=precise to select ffp-contract=on

Author: Melanie Blower Date: 2020-02-11T14:07:10-08:00 New Revision: 3fcdf2fa945aca5849c5587c55de4186c7d81b8a URL: https://github.com/llvm/llvm-project/commit/3fcdf2fa945aca5849c5587c55de4186c7d81b8a DIFF:

[PATCH] D73842: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs

This revision was automatically updated to reflect the committed changes. Closed by commit rG14f870366a93: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs (authored by ianlevesque, committed by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74433: [llvm-objdump] Print file format in lowercase to match GNU output.

rupprecht updated this revision to Diff 243991. rupprecht marked an inline comment as done. rupprecht added a comment. - Use StringRef::lower() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74433/new/ https://reviews.llvm.org/D74433 Files:

[PATCH] D74433: [llvm-objdump] Print file format in lowercase to match GNU output.

rupprecht added a comment. In D74433#1870647 , @MaskRay wrote: > Wait. I wonder whether we can change llvm-readobj to use lower case names as > well. The following should be updated: > > StringRef ELFObjectFile::getFileFormatName() const { > bool

[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

MaskRay added a comment. A probably better approach is to use something like `TC.getCompilerRT(Args, "profile")`. The function returns a full path which can avoid `-L` problems. std::string ToolChain::getCompilerRT(const ArgList , StringRef Component,

[clang] 14f8703 - [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs

Author: Ian Levesque Date: 2020-02-11T14:00:41-08:00 New Revision: 14f870366a93ba0c6311883d900e24339681ba76 URL: https://github.com/llvm/llvm-project/commit/14f870366a93ba0c6311883d900e24339681ba76 DIFF: https://github.com/llvm/llvm-project/commit/14f870366a93ba0c6311883d900e24339681ba76.diff

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

rjmccall added a comment. I agree that the default mode should be standards-compliant, which I believe permits `fp-contract=on` (contraction within expressions) but not `fp-contract=fast` (arbitrary contraction). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74433: [llvm-objdump] Print file format in lowercase to match GNU output.

MaskRay added a comment. I think the patch is good to go on its own, after the `outs() << ":\tfile format " << O->getFileFormatName().lower() << "\n\n";` change. If the consensus is to also change llvm-readobj output, we can teach `getFileFormatName()` to use lower case names and remove

[PATCH] D73842: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs

smeenai accepted this revision. smeenai added a comment. LGTM. I'll commit this for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73842/new/ https://reviews.llvm.org/D73842 ___ cfe-commits

[PATCH] D73842: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs

ianlevesque added a comment. In D73842#1869890 , @smeenai wrote: > Is it worth adding a test that a function with an explicit xray-instrument > attribute also has these other attributes applied? The existing tests from when the feature was added

[PATCH] D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate

sfertile added inline comments. Comment at: clang/include/clang/Basic/TargetCXXABI.h:116 +/// - static initialization is adjusted to use sinit and sterm functions; +XL_Clang, + Xiangling_L wrote: > daltenty wrote: > > Why the underscore in the name?

[PATCH] D74372: [OpenMP][IRBuilder] Perform finalization (incl. outlining) late

fghanim added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:113 + if (llvm::OpenMPIRBuilder *OMPBuilder = CGM.getOpenMPIRBuilder()) +OMPBuilder->finalize(); } jdoerfert wrote: > fghanim wrote: > > jdoerfert wrote: > > > fghanim wrote:

[PATCH] D73842: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs

ianlevesque updated this revision to Diff 243981. ianlevesque added a comment. Address code review feedback on the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73842/new/ https://reviews.llvm.org/D73842 Files:

[PATCH] D74433: [llvm-objdump] Print file format in lowercase to match GNU output.

MaskRay added a subscriber: grimar. MaskRay added a comment. Wait. I wonder whether we can change llvm-readobj to use lower case names as well. The following should be updated: StringRef ELFObjectFile::getFileFormatName() const { bool IsLittleEndian = ELFT::TargetEndianness ==

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG07f7c00208b3: [RISCV] Add support for save/restore of callee-saved registers via libcalls (authored by lewis-revill).

[PATCH] D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate

Xiangling_L marked 4 inline comments as done. Xiangling_L added inline comments. Comment at: clang/include/clang/Basic/TargetCXXABI.h:116 +/// - static initialization is adjusted to use sinit and sterm functions; +XL_Clang, + daltenty wrote: > Why the

[PATCH] D74372: [OpenMP][IRBuilder] Perform finalization (incl. outlining) late

vsk added a comment. Thanks :). IIRC `check-clang` is enough to exercise the relevant code path, as we get an assert in CodeExtractor without the workaround. (side note: please don't take my comments here as blocking, I just wanted to see if we could delete some cruft) Repository: rG LLVM

[PATCH] D74433: [llvm-objdump] Print file format in lowercase to match GNU output.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Verified that coff, elf, and mach-o are printed as lower cases. I believe bpf is similar. Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:2176 +outs() <<

[clang] 07f7c00 - [RISCV] Add support for save/restore of callee-saved registers via libcalls

Author: lewis-revill Date: 2020-02-11T21:23:03Z New Revision: 07f7c00208b393296f8f27d6cd3cec2b11d86fd8 URL: https://github.com/llvm/llvm-project/commit/07f7c00208b393296f8f27d6cd3cec2b11d86fd8 DIFF: https://github.com/llvm/llvm-project/commit/07f7c00208b393296f8f27d6cd3cec2b11d86fd8.diff LOG:

[PATCH] D74372: [OpenMP][IRBuilder] Perform finalization (incl. outlining) late

jdoerfert added a comment. In D74372#1870547 , @vsk wrote: > Can this delete `NeedWorkaroundForOpenMPIRBuilderBug` from > llvm/lib/Transforms/Utils/CodeExtractor.cpp? I didn't know about the workaround but that was the plan. I'll verify and add it to

[PATCH] D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target

delcypher requested changes to this revision. delcypher added inline comments. This revision now requires changes to proceed. Comment at: clang/docs/CMakeLists.txt:93 +function (gen_rst_file output_file td_option source) + get_filename_component(TABLEGEN_INCLUDE_DIR

[PATCH] D74372: [OpenMP][IRBuilder] Perform finalization (incl. outlining) late

vsk added a comment. Can this delete `NeedWorkaroundForOpenMPIRBuilderBug` from llvm/lib/Transforms/Utils/CodeExtractor.cpp? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74372/new/ https://reviews.llvm.org/D74372

[clang] 5e37fb1 - [NFC] Delete extra white space in a test case.

Author: Steven Wan Date: 2020-02-11T16:00:59-05:00 New Revision: 5e37fb1776de2698c10db697e3c479d0e94234e0 URL: https://github.com/llvm/llvm-project/commit/5e37fb1776de2698c10db697e3c479d0e94234e0 DIFF: https://github.com/llvm/llvm-project/commit/5e37fb1776de2698c10db697e3c479d0e94234e0.diff

[PATCH] D74372: [OpenMP][IRBuilder] Perform finalization (incl. outlining) late

jdoerfert marked 2 inline comments as done. jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:113 + if (llvm::OpenMPIRBuilder *OMPBuilder = CGM.getOpenMPIRBuilder()) +OMPBuilder->finalize(); } fghanim wrote: > jdoerfert

[PATCH] D74436: Change clang default to -ffp-model=precise

lebedev.ri added inline comments. Herald added a subscriber: wuzish. Comment at: clang/docs/UsersManual.rst:1388 - * ``precise`` Disables optimizations that are not value-safe on floating-point data, although FP contraction (FMA) is enabled (``-ffp-contract=fast``). This

[clang] 2d4f80f - [OPENMP50]Full handling of atomic_default_mem_order in requires

Author: Alexey Bataev Date: 2020-02-11T15:42:34-05:00 New Revision: 2d4f80f78aa5c25f19c396bf85d022d009706936 URL: https://github.com/llvm/llvm-project/commit/2d4f80f78aa5c25f19c396bf85d022d009706936 DIFF: https://github.com/llvm/llvm-project/commit/2d4f80f78aa5c25f19c396bf85d022d009706936.diff

[PATCH] D74436: Change clang default to -ffp-model=precise

mibintc created this revision. mibintc added reviewers: andrew.w.kaylor, lebedev.ri, rjmccall, sepavloff. Herald added subscribers: kbarton, nemanjai. Herald added a project: clang. This patch establishes the default option for -ffp-model to select "precise". Further, -ffp-model=precise also

[PATCH] D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target

tstellar added a comment. Any other commits before I commit this? Comment at: llvm/cmake/modules/AddSphinxTarget.cmake:33 + if (NOT ARG_SOURCE_DIR) +set(ARG_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}) + endif() delcypher wrote: > @tstellar I'm not 100% sure

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15293 + // TypeDecorCnt for B: 0 + if (Depth <= TypeDecorCnt) { +RelevantExpr = cast(DRE); cchen wrote: > ABataev wrote: > > The check is really bad. If you want to

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. In D72841#1869931 , @lebedev.ri wrote: > I would think `contract` change can be separated from the rest of the > changes, and therefore should be a separate review (to reduce noise)? I split off that change to

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15293 + // TypeDecorCnt for B: 0 + if (Depth <= TypeDecorCnt) { +RelevantExpr = cast(DRE); ABataev wrote: > The check is really bad.

[PATCH] D73629: [analyzer] vfork checker: allow execve after vfork

NoQ added a comment. Let's still add the test. It'll make sure that you understand exactly what you're doing and that there aren't more aspects to this problem. More tests never hurt and it's a local culture to have at least some tests for every commit that changes the behavior. Our tests are

[PATCH] D68049: Propeller: Clang options for basic block sections

lebedev.ri added a comment. In D68049#1870401 , @tmsriram wrote: > In D68049#1870094 , @tmsriram wrote: > > > In D68049#1868623 , @MaskRay wrote: > > > > > > In

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

ABataev added a comment. I would suggest starting with the reworking of the existing implementation with StmtVisitor class and after that step-by-step extend the functionality of the visitor with handling other kinds а expressions. Comment at:

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

cchen marked an inline comment as done. cchen added a comment. > Quoted Text Comment at: clang/lib/Sema/SemaOpenMP.cpp:15554 +LocatorChecker Checker; +if (Checker.Visit(OrigExpr)) { + llvm::copy(Checker.getComponents(), ABataev

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

njames93 updated this revision to Diff 243953. njames93 added a comment. - Simplified member expr restrictions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73052/new/ https://reviews.llvm.org/D73052 Files:

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram added a comment. >>> I think the patch series should probably be structured this way: >>> >>> 1. LLVM CodeGen: enables basic block sections. >>> 2. clang Driver/Frontend/CodeGen: pass basic block sections options to LLVM. >>> 3. LLVM CodeGen: which enables the rest of Propeller options.

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

cchen updated this revision to Diff 243950. cchen added a comment. 1. Refactor based on feedback and use the visitor class to integrate the analysis in checkMapClauseExpressionBase. 2. Handle more lvalue cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

ffrankies updated this revision to Diff 243945. ffrankies marked 9 inline comments as done. ffrankies edited the summary of this revision. ffrankies added a comment. Implemented changes requested by @Eugene.Zelenko: - Added empty lines around namespace block - Fixed use of auto keyword - Fixed

[PATCH] D74372: [OpenMP][IRBuilder] Perform finalization (incl. outlining) late

fghanim added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:113 + if (llvm::OpenMPIRBuilder *OMPBuilder = CGM.getOpenMPIRBuilder()) +OMPBuilder->finalize(); } jdoerfert wrote: > fghanim wrote: > > Does this mean that `finalize()` is

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram added a comment. In D68049#1870094 , @tmsriram wrote: > In D68049#1868623 , @MaskRay wrote: > > > > In D68049#1865967 , @MaskRay > > > wrote: > > > If you don't

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram updated this revision to Diff 243947. tmsriram added a comment. Remove usage of "propeller". Fix header inclusion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68049/new/ https://reviews.llvm.org/D68049 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D73629: [analyzer] vfork checker: allow execve after vfork

janvcelak added a comment. Herald added a subscriber: martong. Please, can the reviewers respond to my comments? I would like to know if this needs additional revision or if it can be accepted as is. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73629/new/

[PATCH] D74433: [llvm-objdump] Print file format in lowercase to match GNU output.

rupprecht created this revision. rupprecht added reviewers: MaskRay, jhenderson. Herald added subscribers: llvm-commits, cfe-commits, kerbowa, nhaehnle, jvesely. Herald added a reviewer: alexshap. Herald added projects: clang, LLVM. GNU objdump prints the file format in lowercase, e.g.

[PATCH] D74374: [clang-tidy] Added check to disable bugprone-infinite-loop on known false condition

This revision was automatically updated to reflect the committed changes. Closed by commit rGc69ec6476806: [clang-tidy] Added check to disable bugprone-infinite-loop on known false… (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] c69ec64 - [clang-tidy] Added check to disable bugprone-infinite-loop on known false condition

Author: Nathan James Date: 2020-02-11T19:37:11Z New Revision: c69ec6476806147e46bf09b693acb24177982dc2 URL: https://github.com/llvm/llvm-project/commit/c69ec6476806147e46bf09b693acb24177982dc2 DIFF: https://github.com/llvm/llvm-project/commit/c69ec6476806147e46bf09b693acb24177982dc2.diff LOG:

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1870218 , @rsmith wrote: > In D71241#1788003 , @jdoerfert wrote: > > > In D71241#1787652 , @hfinkel wrote: > > > > > In D71241#1787571

[PATCH] D74423: Use C++14-style return type deduction in clang.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74423/new/ https://reviews.llvm.org/D74423

[PATCH] D72872: [ObjC generics] Fix not inheriting type bounds in categories/extensions.

vsapsai added a comment. In D72872#1868989 , @hans wrote: > I don't have the context here. Was I added as a subscriber because it's > related to the clang 10 release? It's not related to clang 10 release. I've added you because earlier you've found a

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

rsmith added a comment. In D71241#1788003 , @jdoerfert wrote: > In D71241#1787652 , @hfinkel wrote: > > > In D71241#1787571 , @ABataev wrote: > > > > > In D71241#1787265

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked 2 inline comments as done. bader added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2548 + Opts.SYCL = Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false); + Opts.SYCLIsDevice = Args.hasArg(options::OPT_fsycl_is_device); + if

[PATCH] D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate

stevewan added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:520 + +class XLClangCXXABI final : public ItaniumCXXABI { +public: The class name here is inconsistent with how our ABI kind was called previously, as David pointed out. Maybe

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

sammccall commandeered this revision. sammccall added a reviewer: ilya-biryukov. sammccall added a comment. @ilya-biryukov isn't working on clang fulltime anymore :-( I'm going to try to pick up the work on RecoveryExpr, starting with this patch. @rsmith I think this is waiting on your review

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

tejohnson marked an inline comment as done. tejohnson added a comment. In D73242#1861125 , @tejohnson wrote: > In D73242#186 , @thakis wrote: > > > This makes lld crash when linking chromium's base_unittests

[PATCH] D74412: Fix SFINAE in CFG.cpp.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0fd852fcd05: Fix SFINAE in CFG.cpp. (authored by jlebar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74412/new/ https://reviews.llvm.org/D74412 Files:

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

sammccall updated this revision to Diff 243915. sammccall added a comment. Rebase (ConceptSpecializationExpr moved). Added FIXME to use enum for concept requirement dependence, it's still murky to me. addDependencies -> addDependence, for clarity. Move variably-modified into TypeDependence

[PATCH] D74423: Use C++14-style return type deduction in clang.

jlebar created this revision. jlebar added reviewers: bkramer, MaskRay. Herald added a reviewer: martong. Herald added a reviewer: shafik. Herald added subscribers: cfe-commits, martong. Herald added a project: clang. Simplifies the C++11-style "-> decltype(...)" return-type deduction. Note that

[PATCH] D74414: Use std::foo_t rather than std::foo in clang.

This revision was automatically updated to reflect the committed changes. Closed by commit rG027eb71696f6: Use std::foo_t rather than std::foo in clang. (authored by jlebar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74414/new/

[clang] 57148e0 - [Hexagon] Fix ABI info for returning HVX vectors

Author: Krzysztof Parzyszek Date: 2020-02-11T12:38:54-06:00 New Revision: 57148e0379d30ecabd2a338c5bb9abbb3a0e314f URL: https://github.com/llvm/llvm-project/commit/57148e0379d30ecabd2a338c5bb9abbb3a0e314f DIFF:

[clang] f0fd852 - Fix SFINAE in CFG.cpp.

Author: Justin Lebar Date: 2020-02-11T10:37:08-08:00 New Revision: f0fd852fcd054297f2b07e2ca87551de9b2a39c0 URL: https://github.com/llvm/llvm-project/commit/f0fd852fcd054297f2b07e2ca87551de9b2a39c0 DIFF: https://github.com/llvm/llvm-project/commit/f0fd852fcd054297f2b07e2ca87551de9b2a39c0.diff

[clang] 027eb71 - Use std::foo_t rather than std::foo in clang.

Author: Justin Lebar Date: 2020-02-11T10:37:08-08:00 New Revision: 027eb71696f6ce4fdeb63f68c8c6b66e147ad407 URL: https://github.com/llvm/llvm-project/commit/027eb71696f6ce4fdeb63f68c8c6b66e147ad407 DIFF: https://github.com/llvm/llvm-project/commit/027eb71696f6ce4fdeb63f68c8c6b66e147ad407.diff

[PATCH] D69591: Devirtualize a call on alloca without waiting for post inline cleanup and next DevirtSCCRepeatedPass iteration.

yamauchi updated this revision to Diff 243911. yamauchi added a comment. Rebase past D71308 . PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69591/new/ https://reviews.llvm.org/D69591 Files:

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram added a comment. In D68049#1870094 , @tmsriram wrote: > In D68049#1868623 , @MaskRay wrote: > > > > In D68049#1865967 , @MaskRay > > > wrote: > > > If you don't

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram added a comment. In D68049#1868623 , @MaskRay wrote: > > In D68049#1865967 , @MaskRay wrote: > > If you don't mind, I can push a Diff to this Differential which will > > address these review comments. >

[PATCH] D71110: [clangd] A tool to evaluate cross-file rename.

kbobyrev added a comment. Thanks! Now I can build it. I was able to get some rename failures through this tool, though :( I had to disable the check for number of affected files first, but then this seems to be problematic: llvm/include/llvm/ADT/ArrayRef.h llvm::ArrayRef clangd

[PATCH] D74414: Use std::foo_t rather than std::foo in clang.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74414/new/ https://reviews.llvm.org/D74414

  1   2   3   >