[PATCH] D75040: [ASTMatchers] Adds a matcher called `hasAnyOperatorName`

2020-02-24 Thread Nathan James via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG6a0c066c6102: [ASTMatchers] Adds a matcher called `hasAnyOperatorName` (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D75040?vs=246335=246375#toc Repository: rG LLVM

[PATCH] D75096: [ASTMatchers] Matcher macros with params move params instead of copying

2020-02-24 Thread Nathan James via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3e9a7b2ba470: [ASTMatchers] Matcher macros with params move params instead of copying (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

2020-02-24 Thread Kim Viggedal via Phabricator via cfe-commits
vingeldal added a comment. In D69560#1890026 , @aaron.ballman wrote: > In D69560#1889925 , @vingeldal wrote: > > > Doesn't clang-tidy exclude warnings from system headers by default though? > > > Third-party SDKs

[clang] 6a0c066 - [ASTMatchers] Adds a matcher called `hasAnyOperatorName`

2020-02-24 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2020-02-25T07:51:20Z New Revision: 6a0c066c6102cd463e8ad48881e91e596547507a URL: https://github.com/llvm/llvm-project/commit/6a0c066c6102cd463e8ad48881e91e596547507a DIFF: https://github.com/llvm/llvm-project/commit/6a0c066c6102cd463e8ad48881e91e596547507a.diff LOG:

[clang] 3e9a7b2 - [ASTMatchers] Matcher macros with params move params instead of copying

2020-02-24 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2020-02-25T07:50:34Z New Revision: 3e9a7b2ba470bbe9cf3de3e4b15ba09dcfd206aa URL: https://github.com/llvm/llvm-project/commit/3e9a7b2ba470bbe9cf3de3e4b15ba09dcfd206aa DIFF: https://github.com/llvm/llvm-project/commit/3e9a7b2ba470bbe9cf3de3e4b15ba09dcfd206aa.diff LOG:

[PATCH] D71314: Emit a warning if a variable is uninitialized in indirect ASM goto destination.

2020-02-24 Thread Bill Wendling via Phabricator via cfe-commits
void updated this revision to Diff 246363. void added a comment. Explain what's going on in VisitGCCAsmStmt better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71314/new/ https://reviews.llvm.org/D71314 Files:

[PATCH] D71314: Emit a warning if a variable is uninitialized in indirect ASM goto destination.

2020-02-24 Thread Bill Wendling via Phabricator via cfe-commits
void marked an inline comment as done. void added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:856 +vals[VD] = MayUninitialized; } nickdesaulniers wrote: > Can you walk me through the logic of this function? > > I would

[PATCH] D69876: Support output constraints on "asm goto"

2020-02-24 Thread Bill Wendling via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG50cac248773c: Support output constraints on asm goto (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69876/new/

[clang] 50cac24 - Support output constraints on "asm goto"

2020-02-24 Thread Bill Wendling via cfe-commits
Author: Bill Wendling Date: 2020-02-24T18:51:29-08:00 New Revision: 50cac248773c3a023e8f6ceb9938bdd5e9f15da2 URL: https://github.com/llvm/llvm-project/commit/50cac248773c3a023e8f6ceb9938bdd5e9f15da2 DIFF: https://github.com/llvm/llvm-project/commit/50cac248773c3a023e8f6ceb9938bdd5e9f15da2.diff

[PATCH] D69868: Allow "callbr" to return non-void values

2020-02-24 Thread Bill Wendling via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG23c2a5ce33f0: Allow callbr to return non-void values (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69868/new/

[PATCH] D75028: Make __builtin_amdgcn_dispatch_ptr dereferenceable and align at 4

2020-02-24 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:144 def int_amdgcn_dispatch_ptr : - GCCBuiltin<"__builtin_amdgcn_dispatch_ptr">, Intrinsic<[LLVMQualPointerType], [], arsenm wrote: >

[PATCH] D75097: [cc1as] Unset UseNamesOnTempLabels

2020-02-24 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. MaskRay added a reviewer: efriedma. Herald added a project: clang. Herald added a subscriber: cfe-commits. Similar to rL236642 . This fixes https://reviews.llvm.org/D74006#1890487 Repository: rG LLVM Github Monorepo

[PATCH] D75096: [ASTMatchers] Matcher macros with params move params instead of copying

2020-02-24 Thread Nathan James via Phabricator via cfe-commits
njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use move semantics instead of copying for AST Matchers with parameters Repository: rG LLVM Github Monorepo

[clang] 5522e82 - [NFC] Cleaned up ASTMatchersInternal Code

2020-02-24 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2020-02-25T01:47:51Z New Revision: 5522e8296fc5a082ebfc2cd1904099b1ba0570d9 URL: https://github.com/llvm/llvm-project/commit/5522e8296fc5a082ebfc2cd1904099b1ba0570d9 DIFF: https://github.com/llvm/llvm-project/commit/5522e8296fc5a082ebfc2cd1904099b1ba0570d9.diff LOG:

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang-Tidy's script

2020-02-24 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh accepted this revision. alexfh added a comment. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69746/new/ https://reviews.llvm.org/D69746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75093: clang-cl: Add a `/showIncludes:user` flag.

2020-02-24 Thread Nico Weber via Phabricator via cfe-commits
thakis created this revision. thakis added a reviewer: hans. This flag is like /showIncludes, but it only includes user headers and omits system headers (similar to MD and MMD). The motivation is that projects that already track system includes though other means can use this flag to get

[PATCH] D74925: [OpenMP][Opt] Combine `struct ident_t*` during deduplication

2020-02-24 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Nice. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74925/new/ https://reviews.llvm.org/D74925

[PATCH] D69868: Allow "callbr" to return non-void values

2020-02-24 Thread Bill Wendling via Phabricator via cfe-commits
void marked 2 inline comments as done. void added inline comments. Comment at: llvm/include/llvm/CodeGen/MachineBasicBlock.h:137 + /// List of indirect targets of the callbr of a basic block. + SmallPtrSet InlineAsmBrIndirectTargets; + nickdesaulniers wrote: >

[PATCH] D74996: [arcconfig] Delete subproject arcconfigs

2020-02-24 Thread Shoaib Meenai via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe34ddc09f464: [arcconfig] Delete subproject arcconfigs (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74996/new/

[PATCH] D75040: [ASTMatchers] Adds a matcher called `hasAnyOperatorName`

2020-02-24 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 246335. njames93 added a comment. - Rebase with trunk Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75040/new/ https://reviews.llvm.org/D75040 Files: clang/docs/LibASTMatchersReference.html

[PATCH] D75046: [docs] dump_ast_matchers strips internal::(Bindable)?Matcher from Result_type

2020-02-24 Thread Nathan James via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe6f9cb025cd7: [docs] dump_ast_matchers strips internal::(Bindable)?Matcher from Result_type (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e6f9cb0 - [docs] dump_ast_matchers strips internal::(Bindable)?Matcher from Result_type

2020-02-24 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2020-02-25T00:00:39Z New Revision: e6f9cb025cd765f422b51d01f4a5714db788b3a7 URL: https://github.com/llvm/llvm-project/commit/e6f9cb025cd765f422b51d01f4a5714db788b3a7 DIFF: https://github.com/llvm/llvm-project/commit/e6f9cb025cd765f422b51d01f4a5714db788b3a7.diff LOG:

[PATCH] D66839: Fix stack address builtin for negative numbers

2020-02-24 Thread Zoe Carver via Phabricator via cfe-commits
zoecarver reopened this revision. zoecarver added a comment. This revision is now accepted and ready to land. Reverted: 698078257285a044110620d7dab2fb4451a3fa29 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 6980782 - Revert "Validate argument passed to __builtin_frame_address and __builtin_return_address"

2020-02-24 Thread via cfe-commits
Author: zoecarver Date: 2020-02-24T14:35:02-08:00 New Revision: 698078257285a044110620d7dab2fb4451a3fa29 URL: https://github.com/llvm/llvm-project/commit/698078257285a044110620d7dab2fb4451a3fa29 DIFF: https://github.com/llvm/llvm-project/commit/698078257285a044110620d7dab2fb4451a3fa29.diff

[PATCH] D66839: Fix stack address builtin for negative numbers

2020-02-24 Thread Zoe Carver via Phabricator via cfe-commits
zoecarver closed this revision. zoecarver added a comment. Resolved by c93112dc4f745b0455addb54bfe1c2f79b827c6d Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66839/new/

[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

2020-02-24 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. Current language seems fine. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74935/new/ https://reviews.llvm.org/D74935

[clang] c93112d - Validate argument passed to __builtin_frame_address and __builtin_return_address

2020-02-24 Thread via cfe-commits
Author: zoecarver Date: 2020-02-24T14:23:41-08:00 New Revision: c93112dc4f745b0455addb54bfe1c2f79b827c6d URL: https://github.com/llvm/llvm-project/commit/c93112dc4f745b0455addb54bfe1c2f79b827c6d DIFF: https://github.com/llvm/llvm-project/commit/c93112dc4f745b0455addb54bfe1c2f79b827c6d.diff

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

2020-02-24 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15712 +const std::string RTS = RT->getCanonicalTypeInternal().getAsString(); +auto CntLayer = [](char c) { return c == '*' || c == '['; }; +size_t LLayerCnt

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

2020-02-24 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen updated this revision to Diff 246304. cchen added a comment. Remove the counting in MapBaseChecker, instead, comparing the type of root with the type of LHS and RHS, and only visit the subtree having the same type as root. This scheme pass all the test I have. I'll add BinOp into

[PATCH] D71018: [ASTImporter] Improved import of TypeSourceInfo (TypeLoc)

2020-02-24 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. A few comments and I would like @teemperor to give this a look as well but it looks good to me. Comment at: clang/lib/AST/ASTImporter.cpp:3281 + // Import the function parameters. + SmallVector Parameters; I am curious, why move

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

2020-02-24 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9965 "memory order clause '%0' is specified here">; +def err_omp_non_lvalue_in_map_or_motion_clauses: Error< + "expected lvalue with no function call in '#pragma omp target update'

[PATCH] D75028: Make __builtin_amdgcn_dispatch_ptr dereferenceable and align at 4

2020-02-24 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:144 def int_amdgcn_dispatch_ptr : - GCCBuiltin<"__builtin_amdgcn_dispatch_ptr">, Intrinsic<[LLVMQualPointerType], [], I don't think you actually need to delete this. It

[PATCH] D75028: Make __builtin_amdgcn_dispatch_ptr dereferenceable and align at 4

2020-02-24 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75028/new/ https://reviews.llvm.org/D75028 ___ cfe-commits mailing list

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

2020-02-24 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen marked 4 inline comments as done. cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7616 dyn_cast(I->getAssociatedExpression()); + const auto *UO = dyn_cast(I->getAssociatedExpression()); bool IsPointer =

[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

2020-02-24 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71734/new/ https://reviews.llvm.org/D71734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

2020-02-24 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7616 dyn_cast(I->getAssociatedExpression()); + const auto *UO = dyn_cast(I->getAssociatedExpression()); bool IsPointer = What about binary operator?

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

2020-02-24 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen updated this revision to Diff 246293. cchen added a comment. Remove redundant code in test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75077/new/ https://reviews.llvm.org/D75077 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

2020-02-24 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/include/clang/Parse/Parser.h:2959 + /// if there was an error. + bool ParseOMPDeclareVariantMatchClause(SourceLocation Loc, OMPTraitInfo ); + This file is inconsistent currently, but it looks like

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

2020-02-24 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen created this revision. cchen added a reviewer: ABataev. Herald added subscribers: cfe-commits, guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. Base declaration in pointer arithmetic expression is determined by binary search with type information. Take "int *a,

[PATCH] D75057: Syndicate, test and fix base64 implementation

2020-02-24 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 246290. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75057/new/ https://reviews.llvm.org/D75057 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp compiler-rt/lib/fuzzer/FuzzerUtil.cpp

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

2020-02-24 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D69560#1889925 , @vingeldal wrote: > Doesn't clang-tidy exclude warnings from system headers by default though? Third-party SDKs are not always brought in as system headers, unfortunately. Even ignoring system and

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

2020-02-24 Thread Melanie Blower via Phabricator via cfe-commits
mibintc updated this revision to Diff 246285. mibintc marked an inline comment as done. mibintc added a comment. This patch is code complete and ready for your review and consideration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72841/new/

[PATCH] D69662: [Checkers] Avoid using evalCall in StreamChecker.

2020-02-24 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In D69662#1889545 , @Szelethus wrote: > Sorry for the slack :) > > One should never count on the invocation order of callback funcions in > between checkers. In fact, I'm not too sure that my patches affect this, but > I suspect

[PATCH] D66839: Fix stack address builtin for negative numbers

2020-02-24 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66839/new/ https://reviews.llvm.org/D66839

[PATCH] D75048: [ASTImporter] Improved import of AlignedAttr.

2020-02-24 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM aside from the comments I made. Comment at: clang/lib/AST/ASTImporter.cpp:7944 + if (auto ToEOrErr = Import(From->getAlignmentExpr())) +To =

[PATCH] D75057: Syndicate, test and fix base64 implementation

2020-02-24 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 246279. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75057/new/ https://reviews.llvm.org/D75057 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp compiler-rt/lib/fuzzer/FuzzerUtil.cpp

[PATCH] D66839: Fix stack address builtin for negative numbers

2020-02-24 Thread Zoe Carver via Phabricator via cfe-commits
zoecarver updated this revision to Diff 246277. zoecarver added a comment. - move verification to SemaChecking Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66839/new/ https://reviews.llvm.org/D66839 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D74268: [X86] Add back fmaddsub intrinsics to work towards fixing the strict fp implementation

2020-02-24 Thread Craig Topper via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG727328433ad6: [X86] Add back fmaddsub intrinsics to work towards fixing the strict fp… (authored by craig.topper). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

2020-02-24 Thread Kim Viggedal via Phabricator via cfe-commits
vingeldal added a comment. In D69560#1889719 , @aaron.ballman wrote: > In D69560#1889483 , @whisperity > wrote: > > > I'd rather not call them //false positive// because the definition of > > `false positive` is

[clang] 7273284 - [X86] Add back fmaddsub intrinsics to work towards fixing the strict fp implementation

2020-02-24 Thread Craig Topper via cfe-commits
Author: Craig Topper Date: 2020-02-24T12:07:21-08:00 New Revision: 727328433ad61b8c7acdd4d63e73241303a6beb7 URL: https://github.com/llvm/llvm-project/commit/727328433ad61b8c7acdd4d63e73241303a6beb7 DIFF: https://github.com/llvm/llvm-project/commit/727328433ad61b8c7acdd4d63e73241303a6beb7.diff

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

2020-02-24 Thread Rong Xu via Phabricator via cfe-commits
xur updated this revision to Diff 246265. xur added a comment. Uploaded a wrong patch in the last time. This is the correct one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74878/new/ https://reviews.llvm.org/D74878 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D75068: libclang: Add static build support for Windows

2020-02-24 Thread Cristian Adam via Phabricator via cfe-commits
cristian.adam created this revision. cristian.adam added reviewers: yvvan, thakis, mstorsjo. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. This patch is a squash for: https://reviews.llvm.org/D74564 https://reviews.llvm.org/D74907 And a fix for the issue that got

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44953)

2020-02-24 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D74846#1888410 , @llunak wrote: > Upon further investigation it turns out I probably should not have enabled > those two places for PCH in D69778 at all, > since they do not deal with

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

2020-02-24 Thread Rong Xu via Phabricator via cfe-commits
xur updated this revision to Diff 246260. xur added a comment. check if the -fdiscard-value-names explicitly in args (suggested by Jeroen and Serge) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74878/new/ https://reviews.llvm.org/D74878 Files:

[PATCH] D74925: [OpenMP][Opt] Combine `struct ident_t*` during deduplication

2020-02-24 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert updated this revision to Diff 246256. jdoerfert marked an inline comment as done. jdoerfert added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add tests, addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74925: [OpenMP][Opt] Combine `struct ident_t*` during deduplication

2020-02-24 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D74925#1889185 , @JonChesterfield wrote: > Cool. Can we reasonably add the reproducible from 44893 to a regression > suite, in addition to these IR tests? It's written in C so would need to be > under clang's tests.

[PATCH] D75046: [docs] dump_ast_matchers strips internal::(Bindable)?Matcher from Result_type

2020-02-24 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75046/new/ https://reviews.llvm.org/D75046

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

2020-02-24 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D69560#1889483 , @whisperity wrote: > I'd rather not call them //false positive// because the definition of `false > positive` is ugly and mushy with regards to this check. This check attempts > to enforce an interface

[PATCH] D75057: Syndicate, test and fix base64 implementation

2020-02-24 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 246248. serge-sans-paille added a comment. Other copy/paste typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75057/new/ https://reviews.llvm.org/D75057 Files:

[PATCH] D75057: Syndicate, test and fix base64 implementation

2020-02-24 Thread serge via Phabricator via cfe-commits
serge-sans-paille removed a reviewer: lebedev.ri. serge-sans-paille added a comment. As a side note, pre-reserving the buffer size gives interesting speedup, see http://quick-bench.com/Lp6OwO2etW1YEmJayVWn3U8JDiY Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops.

2020-02-24 Thread Daan De Meyer via Phabricator via cfe-commits
DaanDeMeyer updated this revision to Diff 246244. DaanDeMeyer added a comment. Added unit tests and fixed the case where stuff follows the do statement (like a comment). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75022/new/ https://reviews.llvm.org/D75022 Files:

[PATCH] D75057: Syndicate, test and fix base64 implementation

2020-02-24 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 246243. serge-sans-paille added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75057/new/ https://reviews.llvm.org/D75057 Files:

[PATCH] D75057: Syndicate, test and fix base64 implementation

2020-02-24 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 246240. serge-sans-paille added a comment. Restore duplication, fix the bug in two separate locations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75057/new/ https://reviews.llvm.org/D75057 Files:

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

2020-02-24 Thread Gabor Marton via Phabricator via cfe-commits
martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:152 +break; + default: +llvm_unreachable("Unknown RangeConstraint kind!"); This `default`

[PATCH] D74973: [analyzer] StdLibraryFunctionsChecker refactor w/ inheritance

2020-02-24 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. @balazske See https://reviews.llvm.org/D75063 about the simple independent implementation of the NotNull constraint. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74973/new/ https://reviews.llvm.org/D74973

[PATCH] D74973: [analyzer] StdLibraryFunctionsChecker refactor w/ inheritance

2020-02-24 Thread Gabor Marton via Phabricator via cfe-commits
martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:93 +ValueConstraint(ArgNo ArgN) : ArgN(ArgN) {} +virtual ProgramStateRef apply(ProgramStateRef State, const CallEvent , +

[PATCH] D75063: [analyzer] StdLibraryFunctionsChecker: Add NotNull Arg Constraint

2020-02-24 Thread Gabor Marton via Phabricator via cfe-commits
martong created this revision. martong added reviewers: NoQ, Szelethus, balazske, gamesh411, baloghadamsoftware, steakhal. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald added a project: clang.

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

2020-02-24 Thread serge via Phabricator via cfe-commits
serge-sans-paille added a comment. In D74878#1889460 , @jeroen.dobbelaere wrote: > Will this also give a warning when passing a .ll file to a release clang, > without explicitly passing the '-fdiscard-value-names' ? Is this what we > want it to be ?

[PATCH] D75006: [clang-format] Wrap lines for C# property accessors

2020-02-24 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe updated this revision to Diff 246235. jbcoe added a comment. This revision is now accepted and ready to land. Simplify logic for merging property accessors CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75006/new/ https://reviews.llvm.org/D75006 Files:

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

2020-02-24 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. In D71524#1889566 , @boga95 wrote: > @steakhal's revision is on the top of this. Changing the order will only > cause unnecessary work on both sides. He recently rebased on top of master. I'm no fan of creating unnecessary

[PATCH] D75061: [RISCV] Fix sysroot tests without GCC on RISC-V hosts with GCC

2020-02-24 Thread Luís Marques via Phabricator via cfe-commits
luismarques created this revision. luismarques added reviewers: edward-jones, lenary. Herald added subscribers: cfe-commits, evandro, apazos, sameer.abuasal, pzheng, s.egerton, Jim, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, zzheng, jrtc27, shiva0217,

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

2020-02-24 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 marked 6 inline comments as done. boga95 added a comment. @steakhal's revision is on the top of this. Changing the order will only cause unnecessary work on both sides. Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:103-132 struct FunctionData

[PATCH] D69662: [Checkers] Avoid using evalCall in StreamChecker.

2020-02-24 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. Herald added a subscriber: martong. In D69662#1744479 , @NoQ wrote: > In D69662#1736601 , @balazske wrote: > > > Anyway the checks that do not use BindExpr (all except the open functions)

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

2020-02-24 Thread Gabor Marton via Phabricator via cfe-commits
martong updated this revision to Diff 246229. martong added a comment. Rebase on top of https://reviews.llvm.org/D74973 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73898/new/ https://reviews.llvm.org/D73898 Files:

[PATCH] D74760: [Analyzer] Fix for iterator modeling and checkers: handle negative numbers correctly

2020-02-24 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. This patch is a good testament to how well those debug functions turned out. LGTM. Comment at: clang/lib/StaticAnalyzer/Checkers/Iterator.cpp:203 auto =

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

2020-02-24 Thread Whisperity via Phabricator via cfe-commits
whisperity added a comment. In D74463#1888270 , @aaron.ballman wrote: > I am also concerned about the false positives from this check because I don't > think there's going to be an easy heuristic for determining whether two > identifiers are "related"

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

2020-02-24 Thread Whisperity via Phabricator via cfe-commits
whisperity marked an inline comment as done. whisperity added a comment. I'd rather not call them //false positive// because the definition of `false positive` is ugly and mushy with regards to this check. This check attempts to enforce an interface rule, whether you(r project) wants to adhere

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

2020-02-24 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl added a comment. LGTM Comment at: llvm/unittests/IR/MetadataTest.cpp:2106 + auto *N = + DITemplateValueParameter::get(Context, Tag, Name, Type, false, Value); EXPECT_EQ(Tag, N->getTag()); For consistency, let's assign "false" to `bool

[PATCH] D74470: Seperated DIBasicType DIFlags to DIBTFlags.

2020-02-24 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl added a comment. Thank you this looks very good! Just a few questions inline. Comment at: llvm/lib/AsmParser/LLParser.cpp:4171 +template <> +bool LLParser::ParseMDField(LocTy Loc, StringRef Name, DIBTFlagField ) { + Chirag wrote: > Chirag wrote: > >

[PATCH] D75057: Syndicate, test and fix base64 implementation

2020-02-24 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri requested changes to this revision. lebedev.ri added inline comments. This revision now requires changes to proceed. Comment at: compiler-rt/lib/fuzzer/FuzzerUtil.cpp:14-16 + +#include "llvm/Support/Base64.h" + I don't believe we can do this.

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

2020-02-24 Thread Jeroen Dobbelaere via Phabricator via cfe-commits
jeroen.dobbelaere added a comment. Will this also give a warning when passing a .ll file to a release clang, without explicitly passing the '-fdiscard-value-names' ? Is this what we want it to be ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74878/new/

[PATCH] D75057: Syndicate, test and fix base64 implementation

2020-02-24 Thread serge via Phabricator via cfe-commits
serge-sans-paille created this revision. serge-sans-paille added reviewers: jvikstrom, george.karpenkov. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, usaxena95, kadircet, arphaman, jkorous, mgorny. Herald added projects: clang, Sanitizers, LLVM. As an answer to

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

2020-02-24 Thread Rong Xu via Phabricator via cfe-commits
xur added a comment. Gentle ping. Is the newest patch ok? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74878/new/ https://reviews.llvm.org/D74878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75056: [ARM][AArch64] Default to -fno-common

2020-02-24 Thread Sjoerd Meijer via Phabricator via cfe-commits
SjoerdMeijer created this revision. Herald added a subscriber: kristof.beyls. This patch proposes to default to `-fno-common` for the Arm targets because this has performance and code-size benefits. Additionally, GCC now also defaults to this, so we would be behaving the same as GCC: commit

[PATCH] D74973: [analyzer] StdLibraryFunctionsChecker refactor w/ inheritance

2020-02-24 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. In D74973#1889273 , @Szelethus wrote: > FYI I've been seeing your patches to this checker and I will respond to them, > but I need to do some learning on my own before having the confidence to > accept or request changes.

[PATCH] D74131: [analyzer][taint] Add isTainted debug expression inspection check

2020-02-24 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a reviewer: boga95. Szelethus added a comment. In D74131#1884372 , @steakhal wrote: > If this patch is good to go, could someone commit it? > I don't have commit access (yet). I think you can apply for a commit access, you have a

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

2020-02-24 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus requested changes to this revision. Szelethus added a reviewer: steakhal. Szelethus added a comment. This revision now requires changes to proceed. This patch is really cool, but I still feel anxious a bit about duplicating so much functionality, especially since we're working very

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang-Tidy's script

2020-02-24 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso updated this revision to Diff 246209. Charusso marked 4 inline comments as done. Charusso retitled this revision from "[analyzer] FixItHint: Apply and test hints with the Clang Tidy's script" to "[analyzer] FixItHint: Apply and test hints with the Clang-Tidy's script". Charusso added a

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

2020-02-24 Thread Alexey Bataev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd66d25f83824: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using… (authored by cchen, committed by ABataev). Changed prior to commit:

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang-Tidy's script

2020-02-24 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso added a comment. Thanks for the reviews! Are we good to go? Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:112 void enableFixitsAsRemarks() { FixitsAsRemarks = true; } + void enableFixItApplication() { ApplyFixIts = true; }

[PATCH] D75053: [clangd] Disable ExtractVariable for C

2020-02-24 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: usaxena95. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Currently extract variable doesn't spell the type explicitly and just uses an `auto` instead, which is not

[clang] d66d25f - [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

2020-02-24 Thread Alexey Bataev via cfe-commits
Author: cchen Date: 2020-02-24T10:30:41-05:00 New Revision: d66d25f83824e2d72e06bf0813cc9e9e564dd74c URL: https://github.com/llvm/llvm-project/commit/d66d25f83824e2d72e06bf0813cc9e9e564dd74c DIFF: https://github.com/llvm/llvm-project/commit/d66d25f83824e2d72e06bf0813cc9e9e564dd74c.diff LOG:

[PATCH] D72035: [analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker

2020-02-24 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Herald added a subscriber: martong. Wow. Its a joy to see you do C++. LGTM. Are you planning to introduce `CallDescriptionMap` at one point? :) Comment at:

[PATCH] D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate

2020-02-24 Thread Xiangling Liao via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8bee52bdb54a: [AIX][Frontend] C++ ABI customizations for AIX boilerplate (authored by Xiangling_L). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74015/new/

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

2020-02-24 Thread Michael Liao via Phabricator via cfe-commits
hliao updated this revision to Diff 246204. hliao added a comment. Rebase to the trunk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 Files: clang/include/clang/Sema/Sema.h

[PATCH] D73285: [OpenMP][OMPIRBuilder][BugFix] Handle Unreachable Finalization blocks in `parallel` generation

2020-02-24 Thread Fady Ghanim via Phabricator via cfe-commits
fghanim abandoned this revision. fghanim added a comment. The bug this revision attempted to fix has been resolved as part of patch D74562 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73285/new/

[PATCH] D75040: [ASTMatchers] Adds a matcher called `hasAnyOperatorName`

2020-02-24 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 246203. njames93 added a comment. - Improved docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75040/new/ https://reviews.llvm.org/D75040 Files: clang/docs/LibASTMatchersReference.html

[clang] 8bee52b - [AIX][Frontend] C++ ABI customizations for AIX boilerplate

2020-02-24 Thread Xiangling Liao via cfe-commits
Author: Xiangling Liao Date: 2020-02-24T10:26:51-05:00 New Revision: 8bee52bdb54a51ccfe1eb6c6ed5077132c2950a1 URL: https://github.com/llvm/llvm-project/commit/8bee52bdb54a51ccfe1eb6c6ed5077132c2950a1 DIFF:

[PATCH] D75040: [ASTMatchers] Adds a matcher called `hasAnyOperatorName`

2020-02-24 Thread Nathan James via Phabricator via cfe-commits
njames93 requested review of this revision. njames93 marked 3 inline comments as done. njames93 added a comment. I have fixed up the docs to be more in line with other matchers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75040/new/

[PATCH] D74973: [analyzer] StdLibraryFunctionsChecker refactor w/ inheritance

2020-02-24 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. FYI I've been seeing your patches to this checker and I will respond to them, but I need to do some learning on my own before having the confidence to accept or request changes. Working on it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   >