Re: r355698 - Re-fix _lrotl/_lrotr to always take Long, no matter the platform.

2020-02-26 Thread James Y Knight via cfe-commits
I'm not clear as to what you're saying is broken. On MS platforms, long is 32-bit, so either way this function takes a 32bit value, right? And, Microsoft's docs say this function takes a long. On Wed, Feb 26, 2020, 5:09 PM Michael Spencer via cfe-commits < cfe-commits@lists.llvm.org> wrote: >

[PATCH] D66564: [clang-tidy] new altera struct pack align check

2020-02-26 Thread Frank Derry Wanye via Phabricator via cfe-commits
ffrankies updated this revision to Diff 246871. ffrankies marked 5 inline comments as done. ffrankies added a comment. Addressed comments by @aaron.ballman - Removed commented-out code and irrelevant FIXMEs - Added Fix-Its to insert/amend the aligned and packed struct attributes as needed.

[PATCH] D75223: [clang-offload-wrapper] Lower priority of __tgt_register_lib in favor of __tgt_register_requires

2020-02-26 Thread George Rokos via Phabricator via cfe-commits
grokos updated this revision to Diff 246870. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75223/new/ https://reviews.llvm.org/D75223 Files: clang/test/Driver/clang-offload-wrapper.c clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp

[PATCH] D70700: [WebAssembly] Mangle the argc/argv `main` as `__main_argc_argv`

2020-02-26 Thread Sam Clegg via Phabricator via cfe-commits
sbc100 added a comment. Would you mind re-basing? I'd like to download and try this but it seems to have conflicts right now. (i'll do my best to resolve them you might do better). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70700/new/

[PATCH] D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`.

2020-02-26 Thread Alexandre Rames via Phabricator via cfe-commits
arames marked 2 inline comments as done. arames added a comment. In D72100#1855483 , @jkorous wrote: > We should either simplify the implementation to reflect that we don't support > e. g. `*:42` (seems preferable to me) or have the codepaths that are >

[PATCH] D75223: [clang-offload-wrapper] Lower priority of __tgt_register_lib in favor of __tgt_register_requires

2020-02-26 Thread Vyacheslav Zakharin via Phabricator via cfe-commits
vzakhari added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:291 // Add this function to global destructors. appendToGlobalDtors(M, Func, 0); } I think __tgt_unregister_lib should have a matching priority.

[PATCH] D75223: [clang-offload-wrapper] Lower priority of __tgt_register_lib in favor of __tgt_register_requires

2020-02-26 Thread George Rokos via Phabricator via cfe-commits
grokos created this revision. grokos added reviewers: ABataev, vzakhari. grokos added projects: OpenMP, clang. Herald added a reviewer: jdoerfert. Currently, the offload-wrapper tool inserts `__tgt_register_lib` to the list of global ctors of a target module with `Priority=0`. This means that

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

2020-02-26 Thread Amy Huang via Phabricator via cfe-commits
akhuang marked an inline comment as done. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:992 getTagForRecord(RD), RDName, Ctx, DefUnit, Line, 0, Size, Align, llvm::DINode::FlagFwdDecl, Identifier); if

[PATCH] D67112: [Sema] Add implicit cast for conversion of function references

2020-02-26 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert reclaimed this revision. aaronpuchert removed a reviewer: riccibruno. aaronpuchert added a comment. The diff between both changes might still be interesting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67112/new/

[PATCH] D67112: [Sema] Add implicit cast for conversion of function references

2020-02-26 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert updated this revision to Diff 246862. aaronpuchert added a comment. Rebase on top of D66437 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67112/new/ https://reviews.llvm.org/D67112 Files:

[PATCH] D75220: [clang-tidy] RenamerClangTidy now correctly renames decls

2020-02-26 Thread Nathan James via Phabricator via cfe-commits
njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2, JonasToth, hokein, alexfh. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. njames93 updated this revision to Diff 246853. njames93 added a comment. - Remove unnecessary include

[PATCH] D75220: [clang-tidy] RenamerClangTidy now correctly renames decls

2020-02-26 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 246853. njames93 added a comment. - Remove unnecessary include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75220/new/ https://reviews.llvm.org/D75220 Files:

[PATCH] D69591: Devirtualize a call on alloca without waiting for post inline cleanup and next DevirtSCCRepeatedPass iteration.

2020-02-26 Thread Hiroshi Yamauchi via Phabricator via cfe-commits
yamauchi closed this revision. yamauchi added a comment. Committed as https://reviews.llvm.org/rG59fb9cde7a4a Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69591/new/ https://reviews.llvm.org/D69591

[PATCH] D71314: Warn of uninitialized variables on asm goto's indirect branch

2020-02-26 Thread Bill Wendling via Phabricator via cfe-commits
void updated this revision to Diff 246849. void added a comment. Rebasing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71314/new/ https://reviews.llvm.org/D71314 Files: clang/lib/Analysis/UninitializedValues.cpp clang/test/Analysis/uninit-asm-goto.cpp Index:

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

2020-02-26 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:992 getTagForRecord(RD), RDName, Ctx, DefUnit, Line, 0, Size, Align, llvm::DINode::FlagFwdDecl, Identifier); if (CGM.getCodeGenOpts().DebugFwdTemplateParams) One

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

2020-02-26 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. I ran into this issue again, and would like to move forward with this. I'll rebase it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65543/new/ https://reviews.llvm.org/D65543

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

2020-02-26 Thread Michael Liao via Phabricator via cfe-commits
hliao added a comment. @rjmccall @rsmith @tra, could you review on this revision? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 ___ cfe-commits mailing list

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

2020-02-26 Thread Amy Huang via Phabricator via cfe-commits
akhuang created this revision. akhuang added reviewers: rnk, asmith. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. This change checks for the return type in the frontend and adds a flag to the DISubroutineType to indicate that the option

[PATCH] D75056: [Driver] Default to -fno-common for all targets

2020-02-26 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/docs/ReleaseNotes.rst:87 +- -fno-common has been enabled as the default for all targets. jyknight wrote: > Might be nice to expand upon this somewhat, to give users a clue what it > means to

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

2020-02-26 Thread Joerg Sonnenberger via Phabricator via cfe-commits
joerg added a comment. libc++ has no idea what a correct max_align_t is. The internal definition works due to historic requirements that all three fundamental types are supported for new/delete, but we don't have any such guarantees for every other context. A correctly implemented stddef.h

[clang] 98ed0c5 - PR44978: Accept as an extension some cases where destructor name lookup

2020-02-26 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-02-26T14:55:31-08:00 New Revision: 98ed0c5475df57ca5cd4df0997d8bba323c843aa URL: https://github.com/llvm/llvm-project/commit/98ed0c5475df57ca5cd4df0997d8bba323c843aa DIFF: https://github.com/llvm/llvm-project/commit/98ed0c5475df57ca5cd4df0997d8bba323c843aa.diff

[PATCH] D74784: [driver][darwin] Don't use -platform_version flag by default

2020-02-26 Thread dmajor via Phabricator via cfe-commits
dmajor added a comment. Thanks! I'm still working on getting commit access, would one of you be able to submit for me? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74784/new/ https://reviews.llvm.org/D74784 ___ cfe-commits mailing list

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

2020-02-26 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added a comment. In D73242#1894146 , @tejohnson wrote: > Sent fix for review in D75201 . > > If the new problem showed up later and not when this one first went in, then > it seems likely it is different than

[PATCH] D75202: [ASTMatchers] HasNameMatcher handles `extern "C"`

2020-02-26 Thread Nathan James via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG16cabf278fc8: [ASTMatchers] HasNameMatcher handles `extern C` (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75202/new/

[PATCH] D75202: [ASTMatchers] HasNameMatcher handles `extern "C"`

2020-02-26 Thread Nathan James via Phabricator via cfe-commits
njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchersInternal.cpp:518 +// Linkage Spec can just be ignored +// FIXME: Any other DeclContext kinds that can be safely disregarded +if (isa(Ctx))

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

2020-02-26 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a subscriber: ldionne. EricWF added a comment. @ldionne Since this has the possibility of breaking existing users of `std::max_align_t`, can you test this against your c++03 codebases? @joerg I still don't understand why you need this change. Why can't we provide the name in C++03

[PATCH] D75202: [ASTMatchers] HasNameMatcher handles `extern "C"`

2020-02-26 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 246829. njames93 marked an inline comment as done. njames93 added a comment. - Add extra test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75202/new/ https://reviews.llvm.org/D75202 Files:

Re: r355698 - Re-fix _lrotl/_lrotr to always take Long, no matter the platform.

2020-02-26 Thread Michael Spencer via cfe-commits
I believe this commit is wrong. These intrinsics were originally implemented to support Windows code which expects _lrot{l,r}'s first argument to be 32 bits, it's a breaking change to change these definitions. I'm fine with adding the Intel version of these intrinsics, but you can't just break the

[clang] 16cabf2 - [ASTMatchers] HasNameMatcher handles `extern "C"`

2020-02-26 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2020-02-26T22:07:47Z New Revision: 16cabf278fc8c14d415e677ce0bc40d46a6de30d URL: https://github.com/llvm/llvm-project/commit/16cabf278fc8c14d415e677ce0bc40d46a6de30d DIFF: https://github.com/llvm/llvm-project/commit/16cabf278fc8c14d415e677ce0bc40d46a6de30d.diff LOG:

[PATCH] D75210: [Attr] Allow ParsedAttr to be constructor for any Attribute

2020-02-26 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert marked an inline comment as done. jdoerfert added a comment. In D75210#1894370 , @erichkeane wrote: > I don't see anything glaring here, but I would love some better explanation > as to the goal here. I don't see this used anywhere, the commit

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

2020-02-26 Thread Michael Liao via Phabricator via cfe-commits
hliao updated this revision to Diff 246826. hliao added a comment. Rebase to the latest trunk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 Files: clang/include/clang/Sema/Sema.h

[clang] 7848a3c - Update the ARC docs for non-trivial ownership in structs.

2020-02-26 Thread John McCall via cfe-commits
Author: John McCall Date: 2020-02-26T16:42:08-05:00 New Revision: 7848a3c8ab54570f5875e63606ff75b5736750b4 URL: https://github.com/llvm/llvm-project/commit/7848a3c8ab54570f5875e63606ff75b5736750b4 DIFF: https://github.com/llvm/llvm-project/commit/7848a3c8ab54570f5875e63606ff75b5736750b4.diff

[PATCH] D75202: [ASTMatchers] HasNameMatcher handles `extern "C"`

2020-02-26 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/ASTMatchers/ASTMatchersInternal.cpp:518 +// Linkage Spec can just be ignored +// FIXME: Any other DeclContext kinds that

[PATCH] D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

2020-02-26 Thread Francois JEAN via Phabricator via cfe-commits
Wawha added a comment. In D44609#1893390 , @christophe-calmejane wrote: > Nice to finally see this patch integrated! > > But, it looks like you didn't include all the test case I posted 1.5y ago in > this post, that are still problematic and not

[PATCH] D75210: [Attr] Allow ParsedAttr to be constructor for any Attribute

2020-02-26 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. I don't see anything glaring here, but I would love some better explanation as to the goal here. I don't see this used anywhere, the commit message is a bit underwhelming in its reasoning, and there is no test/etc showing why I would want this.

[PATCH] D75210: [Attr] Allow ParsedAttr to be constructor for any Attribute

2020-02-26 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert created this revision. jdoerfert added reviewers: erichkeane, aaron.ballman, rjmccall, john.brawn. Herald added a subscriber: bollu. Herald added a project: clang. ParsedAttr is used for `clang attribute push/pop` a utility that is reusable in other contexts as well. This allows us to

[PATCH] D75056: [Driver] Default to -fno-common for all targets

2020-02-26 Thread James Y Knight via Phabricator via cfe-commits
jyknight added a comment. Are there any tests remaining that check that with -fcommon, IR generation creates "common" variables, now that all these tests have been modified? If there are not, one should be added. Comment at: clang/docs/ClangCommandLineReference.rst:1311

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

2020-02-26 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74941/new/ https://reviews.llvm.org/D74941

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

2020-02-26 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/test/OpenMP/target_update_codegen.cpp:371-372 + // CK6-DAG: store i32* [[ADD_PTR:%.+]], i32** [[PC0]] + // CK6-DAG: [[ADD_PTR]] = getelementptr inbounds i32, i32* [[ONE:%.+]], i{{32|64}} [[IDX_EXT:%.+]] + // CK6-DAG:

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

2020-02-26 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. Also, we cannot remove traversing of RecordDecl and CapturedDecl encountered in function body since we have OpenMP test like this: int main() { #pragma omp target { t1(0); } return 0; } This results in a kernel function embedded in a captured

[PATCH] D74704: Support -fuse-ld=lld for riscv

2020-02-26 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. Submitted fixes in d2cbaf1755ffa90300365c0d71400a5ee4ada3bd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74704/new/

[PATCH] D75056: [Driver] Default to -fno-common for all targets

2020-02-26 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Hope @tstellar and @jyknight can confirm. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75056/new/ https://reviews.llvm.org/D75056

[PATCH] D75209: [OPENMP][NVPTX]Fix PR45003: add support for complex functions.

2020-02-26 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev created this revision. ABataev added reviewers: tra, hfinkel. Herald added a subscriber: guansong. Herald added a project: clang. Inherited support for complex math functions from CUDA implementation. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75209 Files:

[clang] d2cbaf1 - Fix for the test failues introduced in https://reviews.llvm.org/D74704.

2020-02-26 Thread Leonard Chan via cfe-commits
Author: Leonard Chan Date: 2020-02-26T12:23:15-08:00 New Revision: d2cbaf1755ffa90300365c0d71400a5ee4ada3bd URL: https://github.com/llvm/llvm-project/commit/d2cbaf1755ffa90300365c0d71400a5ee4ada3bd DIFF: https://github.com/llvm/llvm-project/commit/d2cbaf1755ffa90300365c0d71400a5ee4ada3bd.diff

[PATCH] D75198: [ms] Rename ParsingInlineAsm functions/variables to reflect MS-specificity.

2020-02-26 Thread Eric Astor via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG85b641c27aec: [ms] Rename ParsingInlineAsm functions/variables to reflect MS-specificity. (authored by epastor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 85b641c - [ms] Rename ParsingInlineAsm functions/variables to reflect MS-specificity.

2020-02-26 Thread Eric Astor via cfe-commits
Author: Eric Astor Date: 2020-02-26T15:19:40-05:00 New Revision: 85b641c27aecee637d3f7ab25915f47438f55848 URL: https://github.com/llvm/llvm-project/commit/85b641c27aecee637d3f7ab25915f47438f55848 DIFF: https://github.com/llvm/llvm-project/commit/85b641c27aecee637d3f7ab25915f47438f55848.diff

[PATCH] D75056: [Driver] Default to -fno-common for all targets

2020-02-26 Thread Sjoerd Meijer via Phabricator via cfe-commits
SjoerdMeijer updated this revision to Diff 246808. SjoerdMeijer retitled this revision from "[Driver] Default to -fno-common" to "[Driver] Default to -fno-common for all targets". SjoerdMeijer edited the summary of this revision. SjoerdMeijer added a comment. Removed the CHECK-NOTs from some

Re: [PATCH] D74704: Support -fuse-ld=lld for riscv

2020-02-26 Thread Serge Guelton via cfe-commits
On Wed, Feb 26, 2020 at 08:08:49PM +, Leonard Chan via Phabricator wrote: > leonardchan added a comment. > > Unsure if my reply was sent over email so copying it here. > > Yup, adding `// REQUIRES: platform-linker` to both `*-extra.c` files seems to > fix it. Thanks. Will you be sending out

[PATCH] D74418: [clang] fix error detection in consteval calls

2020-02-26 Thread Tyker via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGca50f09db9f8: [clang] fix error detection in consteval calls (authored by Tyker). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[clang] ca50f09 - [clang] fix error detection in consteval calls

2020-02-26 Thread via cfe-commits
Author: Tyker Date: 2020-02-26T21:09:31+01:00 New Revision: ca50f09db9f86eb5ac7aa0cb53c52637f2b7effa URL: https://github.com/llvm/llvm-project/commit/ca50f09db9f86eb5ac7aa0cb53c52637f2b7effa DIFF: https://github.com/llvm/llvm-project/commit/ca50f09db9f86eb5ac7aa0cb53c52637f2b7effa.diff LOG:

[PATCH] D74704: Support -fuse-ld=lld for riscv

2020-02-26 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. Unsure if my reply was sent over email so copying it here. Yup, adding `// REQUIRES: platform-linker` to both `*-extra.c` files seems to fix it. Thanks. Will you be sending out the fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

Re: [PATCH] D74704: Support -fuse-ld=lld for riscv

2020-02-26 Thread Leonard Chan via cfe-commits
Yup, I added it to both *-extra.c files and it seemed to fix the tests. On Wed, Feb 26, 2020 at 11:37 AM Serge Guelton wrote: > Does adding > > // REQUIRES: platform-linker > > to Driver/riscv32-toolchain-extra.c fixes your issue? > > > On Wed, Feb 26, 2020 at 06:25:39PM +, Leonard Chan via

Re: [PATCH] D74704: Support -fuse-ld=lld for riscv

2020-02-26 Thread Leonard Chan via cfe-commits
Will you be sending out the patch for this? On Wed, Feb 26, 2020 at 12:05 PM Leonard Chan wrote: > Yup, I added it to both *-extra.c files and it seemed to fix the tests. > > On Wed, Feb 26, 2020 at 11:37 AM Serge Guelton > wrote: > >> Does adding >> >> // REQUIRES: platform-linker >> >> to

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

2020-02-26 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen marked 2 inline comments as done. cchen added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9965 "memory order clause '%0' is specified here">; +def err_omp_non_lvalue_in_map_or_motion_clauses: Error< + "expected lvalue with no function

Re: [PATCH] D74704: Support -fuse-ld=lld for riscv

2020-02-26 Thread Serge Guelton via cfe-commits
Does adding // REQUIRES: platform-linker to Driver/riscv32-toolchain-extra.c fixes your issue? On Wed, Feb 26, 2020 at 06:25:39PM +, Leonard Chan via Phabricator wrote: > leonardchan added a comment. > > Hi again, I think e058667a2e017d3225a9bb067dbac7f2159576f7 >

Re: [PATCH] D74704: Support -fuse-ld=lld for riscv

2020-02-26 Thread Serge Guelton via cfe-commits
On Wed, Feb 26, 2020 at 06:25:39PM +, Leonard Chan via Phabricator wrote: > leonardchan added a comment. > > Hi again, I think e058667a2e017d3225a9bb067dbac7f2159576f7 > > might've broken our toolchain again: s***t. Can

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

2020-02-26 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D70172#1894036 , @yaxunl wrote: > I tried recording functions to be emitted during normal parsing and using it > as starting point for the final traversal. It is quite promising. I only get > one lit test failure for OpenMP:

[PATCH] D74784: [driver][darwin] Don't use -platform_version flag by default

2020-02-26 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM to me too. With @steven_wu and me on board, I don't think you need to wait for @arphaman. Thanks for the fix! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74784/new/

[PATCH] D75202: [ASTMatchers] HasNameMatcher handles `extern "C"`

2020-02-26 Thread Nathan James via Phabricator via cfe-commits
njames93 created this revision. njames93 added reviewers: klimek, aaron.ballman, gribozavr2. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes hasName AST matcher is confused by extern "C" in namespace. Repository: rG

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

2020-02-26 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added a comment. Sent fix for review in D75201 . If the new problem showed up later and not when this one first went in, then it seems likely it is different than this issue. I'll see if I can reproduce and take a look. Repository: rG LLVM Github

[PATCH] D75176: [clangd] Get rid of getBeginningOfIdentifier helper

2020-02-26 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Did you want to delete the lexer check in getDeducedType or is that another patch? Comment at: clang-tools-extra/clangd/Hover.cpp:533 + } + auto TokensAroundCursor

[PATCH] D75198: [ms] Rename ParsingInlineAsm functions/variables to reflect MS-specificity.

2020-02-26 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75198/new/ https://reviews.llvm.org/D75198 ___

[PATCH] D75198: [ms] Rename ParsingInlineAsm functions/variables to reflect MS-specificity.

2020-02-26 Thread Eric Astor via Phabricator via cfe-commits
epastor created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. epastor added a child revision: D73227: [ms] [llvm-ml] Use default RIP-relative addressing for x64 MASM.. ParsingInlineAsm was a misleading name. These values are

Re: r329762 - Introduce a new builtin, __builtin_dump_struct, that is useful for dumping structure contents at runtime in circumstances where debuggers may not be easily available (such as in kernel w

2020-02-26 Thread Aaron Ballman via cfe-commits
On Tue, Feb 25, 2020 at 4:36 PM Richard Smith wrote: > > It looks like we forgot to document this builtin. Can some documentation be > added? If Paul doesn't get to it first, I can try to stub some out. ~Aaron > > On Tue, 10 Apr 2018 at 15:01, Aaron Ballman via cfe-commits > wrote: >> >>

Re: [clang] 83f4372 - [CodeGen] fix clang test that runs the optimizer pipeline; NFC

2020-02-26 Thread Sanjay Patel via cfe-commits
To be clear - the test is checking IR instructions, but it's checking -O1 IR for various targets. So there must be different expectations per target... But I just tried a test of turning everything down to -O0, and it all passed except for the "fast-math" run for AArch64. I can tweak that to not

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

2020-02-26 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. I tried recording functions to be emitted during normal parsing and using it as starting point for the final traversal. It is quite promising. I only get one lit test failure for OpenMP: int foobar2(); #pragma omp declare target int (*B)() = #pragma omp end

[PATCH] D74704: Support -fuse-ld=lld for riscv

2020-02-26 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. Hi again, I think e058667a2e017d3225a9bb067dbac7f2159576f7 might've broken our toolchain again: FAIL: Clang :: Driver/riscv32-toolchain-extra.c (5723 of 17018) TEST

[PATCH] D75056: [Driver] Default to -fno-common

2020-02-26 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/test/Driver/clang_f_opts.c:15 // CHECK-OPTIONS2: -fshort-enums -// CHECK-OPTIONS2: -fno-common +// CHECK-OPTIONS2-NOT: -fcommon // CHECK-OPTIONS2: -fno-show-source-location I think such NOT patterns should just

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

2020-02-26 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9965 "memory order clause '%0' is specified here">; +def err_omp_non_lvalue_in_map_or_motion_clauses: Error< + "expected lvalue with no function call in '#pragma omp target update'

[PATCH] D75125: [Docs][OpenCL] Release 10.0 notes for OpenCL

2020-02-26 Thread Sven van Haastregt via Phabricator via cfe-commits
svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75125/new/ https://reviews.llvm.org/D75125 ___ cfe-commits mailing list

[PATCH] D74784: [driver][darwin] Don't use -platform_version flag by default

2020-02-26 Thread Steven Wu via Phabricator via cfe-commits
steven_wu added a comment. Thanks. LGTM. I will let @arphaman to approve this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74784/new/ https://reviews.llvm.org/D74784 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [clang] 83f4372 - [CodeGen] fix clang test that runs the optimizer pipeline; NFC

2020-02-26 Thread Eric Christopher via cfe-commits
I mean anything that's testing assembly output out of clang is less than ideal. There are some circumstances, but this doesn't seem like one of them. On Wed, Feb 26, 2020, 9:10 AM Sanjay Patel wrote: > The test file dates back to: > https://reviews.llvm.org/D5698 > ...and I'm not familiar with

[PATCH] D75056: [Driver] Default to -fno-common

2020-02-26 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added a comment. I have no objections; however, it may help for the title of the patch to clearly indicate "for all targets". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75056/new/ https://reviews.llvm.org/D75056

[PATCH] D74784: [driver][darwin] Don't use -platform_version flag by default

2020-02-26 Thread dmajor via Phabricator via cfe-commits
dmajor updated this revision to Diff 246771. dmajor edited the summary of this revision. dmajor added a comment. Updated the tests: three cases for {default, old, new} linkers in the platform-version tests; left alone the tests not specifically targeting this path. CHANGES SINCE LAST ACTION

[PATCH] D75125: [Docs][OpenCL] Release 10.0 notes for OpenCL

2020-02-26 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia updated this revision to Diff 246774. Anastasia added a comment. Addressed comments from Hans and Sven. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75125/new/ https://reviews.llvm.org/D75125 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst

[clang] 59fb9cd - Devirtualize a call on alloca without waiting for post inline cleanup and next

2020-02-26 Thread Hiroshi Yamauchi via cfe-commits
Author: Hiroshi Yamauchi Date: 2020-02-26T09:51:24-08:00 New Revision: 59fb9cde7a4a96fe8485a80d9010e4420ffdca82 URL: https://github.com/llvm/llvm-project/commit/59fb9cde7a4a96fe8485a80d9010e4420ffdca82 DIFF:

[PATCH] D75056: [Driver] Default to -fno-common

2020-02-26 Thread Sjoerd Meijer via Phabricator via cfe-commits
SjoerdMeijer updated this revision to Diff 246768. SjoerdMeijer added a comment. Herald added subscribers: kerbowa, nhaehnle, jvesely. Thanks for catching that. Now it shows more changes in tests, so updated a bunch of tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75056/new/

[PATCH] D75056: [Driver] Default to -fno-common

2020-02-26 Thread Sjoerd Meijer via Phabricator via cfe-commits
SjoerdMeijer updated this revision to Diff 246770. SjoerdMeijer added a comment. minor test update CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75056/new/ https://reviews.llvm.org/D75056 Files: clang/docs/ClangCommandLineReference.rst clang/docs/ReleaseNotes.rst

[PATCH] D31338: Move ParsedAttrInfos into a registry and point to one in ParsedAttr

2020-02-26 Thread John Brawn via Phabricator via cfe-commits
john.brawn updated this revision to Diff 246763. john.brawn added a comment. Herald added a subscriber: krytarowski. This has been rewritten so that the registry is only used for attributes added by plugins, and everything else continues as before. This also removes the strange dependency I'd

[PATCH] D31337: Use virtual functions in ParsedAttrInfo instead of function pointers

2020-02-26 Thread John Brawn via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG590dc8d02cd7: Use virtual functions in ParsedAttrInfo instead of function pointers (authored by john.brawn). Changed prior to commit: https://reviews.llvm.org/D31337?vs=242363=246765#toc Repository:

[PATCH] D75193: [clangd] Get rid of lexer usage in AST.cpp

2020-02-26 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kadircet added a parent revision: D75176: [clangd] Get rid of getBeginningOfIdentifier helper.

[clang] 590dc8d - Use virtual functions in ParsedAttrInfo instead of function pointers

2020-02-26 Thread John Brawn via cfe-commits
Author: John Brawn Date: 2020-02-26T17:24:30Z New Revision: 590dc8d02cd781b110a87b82476c3557cb5957c3 URL: https://github.com/llvm/llvm-project/commit/590dc8d02cd781b110a87b82476c3557cb5957c3 DIFF: https://github.com/llvm/llvm-project/commit/590dc8d02cd781b110a87b82476c3557cb5957c3.diff LOG:

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

2020-02-26 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin updated this revision to Diff 246758. DmitryPolukhin added a comment. Rebase on top of master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75184/new/ https://reviews.llvm.org/D75184 Files:

[PATCH] D75171: [Analyzer] Fix for incorrect use of container and iterator checkers

2020-02-26 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. Im sorry, i though we talked about internal code and we're stuck with the checker interface -- this should definitely be solved by changing the parameter of the

Re: [clang] 83f4372 - [CodeGen] fix clang test that runs the optimizer pipeline; NFC

2020-02-26 Thread Sanjay Patel via cfe-commits
The test file dates back to: https://reviews.llvm.org/D5698 ...and I'm not familiar with _Complex enough to say how to fix this properly (seems like the check lines are already limited such that -O0 rather than -O1 would work?). But this file keeps wiggling unexpectedly, it's going to move again

[PATCH] D75166: [clangd] Clean-up XRefs.cpp from Lexer usages and unnecessary SourceLoc transformations

2020-02-26 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG2011d14296ee: [clangd] Clean-up XRefs.cpp from Lexer usages and unnecessary SourceLoc… (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 2011d14 - [clangd] Clean-up XRefs.cpp from Lexer usages and unnecessary SourceLoc transformations

2020-02-26 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2020-02-26T17:51:27+01:00 New Revision: 2011d14296eeaae911e898d11154ee5d1a5db1d6 URL: https://github.com/llvm/llvm-project/commit/2011d14296eeaae911e898d11154ee5d1a5db1d6 DIFF:

[PATCH] D75166: [clangd] Clean-up XRefs.cpp from Lexer usages and unnecessary SourceLoc transformations

2020-02-26 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 246750. kadircet marked 3 inline comments as done. kadircet added a comment. - Add tests for non-identifier cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75166/new/ https://reviews.llvm.org/D75166

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

2020-02-26 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea added a comment. In D73242#1893506 , @tejohnson wrote: > In D73242#1888295 , @tejohnson wrote: > > > FYI I have reproduced the failure, and am starting to debug. > > > I see what is going on and have a

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

2020-02-26 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15683 } + bool VisitUnaryOperator(UnaryOperator *UO) { +if (SemaRef.getLangOpts().OpenMP < 50) { ABataev wrote: > cchen wrote: > > ABataev

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

2020-02-26 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin created this revision. DmitryPolukhin added reviewers: alexfh, gribozavr2. DmitryPolukhin added projects: clang, clang-tools-extra. Herald added subscribers: aheejin, xazax.hun. Without this patch clang-tidy stops finding file configs on the nearest .clang-tidy file. In some cases

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

2020-02-26 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added a comment. Ping ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72705/new/ https://reviews.llvm.org/D72705 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

2020-02-26 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L added a comment. ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/ https://reviews.llvm.org/D74166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D75166: [clangd] Clean-up XRefs.cpp from Lexer usages and unnecessary SourceLoc transformations

2020-02-26 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/XRefs.cpp:432 auto References = findRefs( - getDeclAtPosition(AST, -

[PATCH] D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops.

2020-02-26 Thread Daan De Meyer via Phabricator via cfe-commits
DaanDeMeyer added a comment. Is there CI infra that runs for each revision? I verified all the format unit tests still pass but I haven't run the entire test suite on my machine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75022/new/ https://reviews.llvm.org/D75022

[PATCH] D75166: [clangd] Clean-up XRefs.cpp from Lexer usages and unnecessary SourceLoc transformations

2020-02-26 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 246734. kadircet marked 4 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75166/new/ https://reviews.llvm.org/D75166 Files:

[PATCH] D75166: [clangd] Clean-up XRefs.cpp from Lexer usages and unnecessary SourceLoc transformations

2020-02-26 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:432 auto References = findRefs( - getDeclAtPosition(AST, - SM.getMacroArgExpandedLocation(getBeginningOfIdentifier( -Pos, SM,

[PATCH] D75171: [Analyzer] Fix for incorrect use of container and iterator checkers

2020-02-26 Thread Whisperity via Phabricator via cfe-commits
whisperity added a comment. Also, //errors// should conceptually break the operation at hand, so this thing should be a warning instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75171/new/ https://reviews.llvm.org/D75171

[PATCH] D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts

2020-02-26 Thread Zinovy Nis via Phabricator via cfe-commits
zinovy.nis marked an inline comment as done. zinovy.nis added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-use-after-move.cpp:329 // CHECK-NOTES: [[@LINE-3]]:7: note: move occurred here + // CHECK-NOTES: [[@LINE-6]]:7: note:

[PATCH] D75171: [Analyzer] Fix for incorrect use of container and iterator checkers

2020-02-26 Thread Whisperity via Phabricator via cfe-commits
whisperity added a comment. Do you have access to the `Driver` somehow? Instead of a `cerr` (-ish) output, something that is formatted like a "true" error diagnostic (or warning), such as `"no such file or directory"` would be much better, I fear this `[ERROR]` will simply be flooded away with

  1   2   >