[PATCH] D75373: [Clang] Fix Hurd toolchain class hierarchy

aganea updated this revision to Diff 247400. aganea added a comment. Fix clang-formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75373/new/ https://reviews.llvm.org/D75373 Files: clang/lib/Driver/ToolChains/Hurd.cpp clang/lib/Driver/ToolChains/Hurd.h Index:

[PATCH] D75368: [clang-format] Handle ?. ?? and ?[ as C# tokens

jbcoe updated this revision to Diff 247399. jbcoe added a comment. Fix failing test by parsing tokens after '?[' in the same way as tokens after '['. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75368/new/ https://reviews.llvm.org/D75368 Files:

[clang] dd1ea9d - Reland: [Coverage] Revise format to reduce binary size

Author: Vedant Kumar Date: 2020-02-28T18:12:04-08:00 New Revision: dd1ea9de2e3e3ac80a620f71411a9a36449f2697 URL: https://github.com/llvm/llvm-project/commit/dd1ea9de2e3e3ac80a620f71411a9a36449f2697 DIFF: https://github.com/llvm/llvm-project/commit/dd1ea9de2e3e3ac80a620f71411a9a36449f2697.diff

[clang] 3388871 - Revert "[Coverage] Revise format to reduce binary size"

Author: Vedant Kumar Date: 2020-02-28T18:03:15-08:00 New Revision: 3388871714d3b718b823e76499b0c03877105e5d URL: https://github.com/llvm/llvm-project/commit/3388871714d3b718b823e76499b0c03877105e5d DIFF: https://github.com/llvm/llvm-project/commit/3388871714d3b718b823e76499b0c03877105e5d.diff

[PATCH] D75395: [clang][Modules] Add -fsystem-module flag

Bigcheese created this revision. Bigcheese added reviewers: rsmith, bruno. Bigcheese added a project: clang. Herald added a subscriber: dexonsmith. The -fsystem-module flag is used when explicitly building a module. It forces the module to be treated as a system module. This is used when

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm! So, presumably we still do the wrong thing in the non-method type cases. I came up with this, where we differ with MSVC: struct NonTrivial { NonTrivial(); NonTrivial(const

[PATCH] D69471: [Coverage] Revise format to reduce binary size

This revision was automatically updated to reflect the committed changes. Closed by commit rG99317124e1c7: [Coverage] Revise format to reduce binary size (authored by vsk). Changed prior to commit: https://reviews.llvm.org/D69471?vs=245756=247396#toc Repository: rG LLVM Github Monorepo

[PATCH] D75383: clang: Switch C compilations to C17 by default.

rsmith accepted this revision. rsmith added a comment. Looks good. Please consider updating the Clang 10 release notes to indicate that we intend to change the default in Clang 11. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75383/new/

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

MaskRay added a comment. I am of the feeling that this check should not be llvm-libc specific. It is a general need that certain system headers are not desired. This patch can provide a general mechanism (some whitelists and blacklists). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D74417: [clang][ARC] Remove invalid assertion that can crash clangd

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. In D74417#1876927 , @dgoldman wrote: > Okay, I've added this, it seems to fix the test but I'm not sure if it's > fully correct

[PATCH] D75311: [modules] Allow frameworks to have only a private module without a public one.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4069dd14124e: [modules] Allow frameworks to have only a private module without a public one. (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 2e4f5e6 - [Sema] Fix an assert when objc_externally_retained was applied to an unprototyped function

Author: Erik Pilkington Date: 2020-02-28T15:49:16-08:00 New Revision: 2e4f5e629de8ba77ae6facba5c595ef23d95acf4 URL: https://github.com/llvm/llvm-project/commit/2e4f5e629de8ba77ae6facba5c595ef23d95acf4 DIFF:

[clang] 4069dd1 - [modules] Allow frameworks to have only a private module without a public one.

Author: Volodymyr Sapsai Date: 2020-02-28T15:40:24-08:00 New Revision: 4069dd14124e9a84b46f48153d4fbc4da811a45e URL: https://github.com/llvm/llvm-project/commit/4069dd14124e9a84b46f48153d4fbc4da811a45e DIFF:

[PATCH] D75387: [Sema] Look through OpaqueValueExpr when checking implicit conversions

erik.pilkington created this revision. erik.pilkington added a reviewer: rjmccall. Herald added subscribers: ributzka, dexonsmith, jkorous. Specifically, this fixes a false-positive in -Wobjc-signed-char-bool. rdar://57372317 https://reviews.llvm.org/D75387 Files:

[clang] c54597b - [ubsan] Add support for -fsanitize=nullability-* suppressions

Author: Vedant Kumar Date: 2020-02-28T14:30:40-08:00 New Revision: c54597b99d6f6ea51616168a0c2ff3850c3869eb URL: https://github.com/llvm/llvm-project/commit/c54597b99d6f6ea51616168a0c2ff3850c3869eb DIFF: https://github.com/llvm/llvm-project/commit/c54597b99d6f6ea51616168a0c2ff3850c3869eb.diff

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:2197-2198 + if (NumBits > llvm::IntegerType::MAX_INT_BITS) { +Diag(Loc, diag::err_ext_int_max_size) << IsUnsigned + << llvm::IntegerType::MAX_INT_BITS; +

[PATCH] D75285: Mark restrict pointer or reference to const as invariant

yaxunl added a comment. In D75285#1897502 , @jeroen.dobbelaere wrote: > I don't think that 'restrict' is a good match for this behavior. For c++, the > alias_set proposal > (http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2014/n4150.pdf) would be >

[PATCH] D75383: clang: Switch C compilations to C17 by default.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM -- C17 is C11 with bugfixes, so this seems like a sensible change, especially for compatibility with GCC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

Xiangling_L updated this revision to Diff 247360. Xiangling_L added a comment. Clean the formatting issues; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/ https://reviews.llvm.org/D74166 Files: clang/include/clang/AST/Mangle.h

[PATCH] D75383: clang: Switch C compilations to C17 by default.

nickdesaulniers added a comment. My hope is that we land this with time to soak for the clang-11 release. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75383/new/ https://reviews.llvm.org/D75383 ___

[PATCH] D75383: clang: Switch C compilations to C17 by default.

nickdesaulniers created this revision. nickdesaulniers added a reviewer: rsmith. Herald added subscribers: cfe-commits, s.egerton, simoncook, aheejin, dschuff. Herald added a project: clang. nickdesaulniers added a comment. My hope is that we land this with time to soak for the clang-11 release.

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

Xiangling_L updated this revision to Diff 247355. Xiangling_L added a comment. Rebase on the latest master branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/ https://reviews.llvm.org/D74166 Files: clang/include/clang/AST/Mangle.h

[PATCH] D75285: Mark restrict pointer or reference to const as invariant

keryell added a comment. In D75285#1897502 , @jeroen.dobbelaere wrote: > I don't think that 'restrict' is a good match for this behavior. For c++, the > alias_set proposal > (http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2014/n4150.pdf) would be

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

baziotis added a comment. In D74801#1898660 , @lattner wrote: > I'd be happy to help fix that problem. Please take a look at the llvm > developer policy. :-) Oh thanks, I thought I had to submit way more patches. CHANGES SINCE LAST ACTION

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ee6fa28a74e: [OpenMP5.0] Allow pointer arithmetic in motion/map clause, by Chi Chun Chen (authored by cchen, committed by ABataev). Changed prior to commit:

[PATCH] D75298: [Clang][SVE] Parse builtin type string for scalable vectors

efriedma added a comment. Please update the documentation comment at the top of Builtins.def . Can we avoid a gigantic, expensive to parse arm_sve.h somehow? Given that the compiler has to know the signatures for all these buitins anyway, can we just make including arm_sve.h set some flag in

[clang] 6ee6fa2 - [OpenMP5.0] Allow pointer arithmetic in motion/map clause, by Chi Chun

Author: cchen Date: 2020-02-28T15:07:32-05:00 New Revision: 6ee6fa28a74e9b33475a153f35b169f0c83a6ec6 URL: https://github.com/llvm/llvm-project/commit/6ee6fa28a74e9b33475a153f35b169f0c83a6ec6 DIFF: https://github.com/llvm/llvm-project/commit/6ee6fa28a74e9b33475a153f35b169f0c83a6ec6.diff LOG:

[PATCH] D75370: [test] Fix flang test failures due to not handling .exe

efriedma added a comment. Do you have any idea why this isn't failing on the public buildbots? There are multiple Windows buildbots that are running these tests (for example, http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64, and

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

ABataev added a comment. In D75077#1898678 , @cchen wrote: > @ABataev, can you land it for me when you have time? > > Thanks, > Chi Chun Sure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75077/new/

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

cchen added a comment. @ABataev, can you land it for me when you have time? Thanks, Chi Chun Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75077/new/ https://reviews.llvm.org/D75077 ___ cfe-commits

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

lattner added a comment. I'd be happy to help fix that problem. Please take a look at the llvm developer policy. :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74801/new/ https://reviews.llvm.org/D74801 ___ cfe-commits mailing list

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75077/new/ https://reviews.llvm.org/D75077

[PATCH] D75373: [Clang] Fix Hurd toolchain class hierarchy

aganea added a comment. @hans, do you think this could be included in 10.0? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75373/new/ https://reviews.llvm.org/D75373 ___ cfe-commits mailing list

[PATCH] D75373: [Clang] Fix Hurd toolchain class hierarchy

aganea created this revision. aganea added reviewers: hans, sthibaul, kristina. Herald added subscribers: cfe-commits, dexonsmith, Prazek. Herald added a project: clang. aganea added a comment. @hans, do you think this could be included in 10.0? As noted in PR45061, a two-stage ThinLTO build

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D75365: [AST Matchers] Fix bug in 'optionally' matcher wherein all previous bindings are cleared when all inner matchers fail.

This revision was automatically updated to reflect the committed changes. Closed by commit rG586f13aeac3f: [AST Matchers] Fix bug in optionally matcher wherein all previous bindings… (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75365: [AST Matchers] Fix bug in 'optionally' matcher wherein all previous bindings are cleared when all inner matchers fail.

ymandel updated this revision to Diff 247314. ymandel added a comment. fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75365/new/ https://reviews.llvm.org/D75365 Files: clang/lib/ASTMatchers/ASTMatchersInternal.cpp

[PATCH] D75365: [AST Matchers] Fix bug in 'optionally' matcher wherein all previous bindings are cleared when all inner matchers fail.

ymandel added a comment. In D75365#1898536 , @aaron.ballman wrote: > ... > Good question! My intuition is that `optionally` should take exactly one > argument and the user should be explicit as to whether they mean `allOf` or > `anyOf` when there is

Re: [clang] d930ed1 - Disallow use of __has_c_attribute in C++ mode.

On Fri, Feb 28, 2020 at 11:42 AM Arthur O'Dwyer wrote: > On Fri, Feb 28, 2020 at 11:23 AM James Y Knight via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Fri, Feb 28, 2020 at 10:05 AM Aaron Ballman >> wrote: >> >>> On Thu, Feb 27, 2020 at 6:04 PM James Y Knight >>> wrote: >>> >

[clang] 586f13a - [AST Matchers] Fix bug in 'optionally' matcher wherein all previous bindings are cleared when all inner matchers fail.

Author: Yitzhak Mandelbaum Date: 2020-02-28T13:46:27-05:00 New Revision: 586f13aeac3fd51916774f523e30f0aee2b62d46 URL: https://github.com/llvm/llvm-project/commit/586f13aeac3fd51916774f523e30f0aee2b62d46 DIFF:

[PATCH] D75365: [AST Matchers] Fix bug in 'optionally' matcher wherein all previous bindings are cleared when all inner matchers fail.

aaron.ballman accepted this revision. aaron.ballman added a comment. Patch LGTM aside from a formatting nit. In D75365#1898466 , @ymandel wrote: > Aaron -- when fixing this bug, I had some other questions about the behavior > of this matcher.

[PATCH] D75370: [test] Fix flang test failures due to not handling .exe

ctetreau created this revision. Herald added subscribers: cfe-commits, DavidTruby. Herald added a project: clang. ctetreau added reviewers: efriedma, rsmith, peterwaller-arm. - Update flang tests to account for the fact that the binary is called flang.exe on windows Repository: rG LLVM

[PATCH] D75162: [X86][F16C] Remove cvtph2ps intrinsics and use generic half2float conversion (PR37554)

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75162/new/ https://reviews.llvm.org/D75162

[PATCH] D75368: [clang-format] Handle ?. ?? and ?[ as C# tokens

jbcoe planned changes to this revision. jbcoe added a comment. There's a weird test failure I'm unable to reproduce outside of the tests with real source code where public static void Main(string[] args) { string dirPath = args?[0]; } is (mis)-formatted as public static void

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

cchen updated this revision to Diff 247303. cchen added a comment. return RelevantExpr || Visit(LE); Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75077/new/ https://reviews.llvm.org/D75077 Files:

[PATCH] D75368: [clang-format] Handle ?. ?? and ?[ as C# tokens

jbcoe created this revision. jbcoe added a reviewer: krasimir. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. jbcoe planned changes to this revision. jbcoe added a comment. There's a weird test failure I'm unable to reproduce outside of

[PATCH] D75365: [AST Matchers] Fix bug in 'optionally' matcher wherein all previous bindings are cleared when all inner matchers fail.

ymandel added a comment. Aaron -- when fixing this bug, I had some other questions about the behavior of this matcher. Specifically, instead of adding bindings to the existing map, it creates a new match result for each matching node (with addMatch). But, I'm struggling to see how it makes

[PATCH] D75365: [AST Matchers] Fix bug in 'optionally' matcher wherein all previous bindings are cleared when all inner matchers fail.

ymandel created this revision. ymandel added reviewers: aaron.ballman, sbenza. Herald added a project: clang. ymandel updated this revision to Diff 247299. ymandel added a comment. removed change to unrelated file. The implementation of 'optionally' doesn't preserve bindings when none of the

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

cchen updated this revision to Diff 247298. cchen added a comment. Add assert to make sure that we never overwrite RelevantExpr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75077/new/ https://reviews.llvm.org/D75077 Files:

[PATCH] D75365: [AST Matchers] Fix bug in 'optionally' matcher wherein all previous bindings are cleared when all inner matchers fail.

ymandel updated this revision to Diff 247299. ymandel added a comment. removed change to unrelated file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75365/new/ https://reviews.llvm.org/D75365 Files:

[PATCH] D75271: [analyzer][NFC] Change LangOptions to CheckerManager in the shouldRegister* functions.

Szelethus added a comment. Mind that `AnalysisManager`, similarly to `CheckerManager` before D75360 , must be constructed with an `ASTContext` which is not available at the moment when the `shouldRegister*` functions run, and they must run no later than when

[clang] f16d2be - Devirtualize a call on alloca without waiting for post inline cleanup and next DevirtSCCRepeatedPass iteration.

Author: Hiroshi Yamauchi Date: 2020-02-28T09:43:32-08:00 New Revision: f16d2bec40691f4050174c99600847d024486bc5 URL: https://github.com/llvm/llvm-project/commit/f16d2bec40691f4050174c99600847d024486bc5 DIFF:

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15499-15501 RelevantExpr = DRE; // Record the component. Components.emplace_back(DRE, DRE->getDecl()); ABataev wrote: > cchen wrote: > > ABataev wrote: > > > Shall we do this

[PATCH] D75350: [OpenMP] Allow const parameters in declare simd linear clause

fpetrogalli added inline comments. Comment at: clang/test/OpenMP/declare_simd_codegen.cpp:327 +// CHECK-DAG: "_ZGVbN2l__Z11constlineari" +// CHECK-DAG: "_ZGVcN4l__Z11constlineari" I think we should add the same checks in the AArch64 test:

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15499-15501 RelevantExpr = DRE; // Record the component. Components.emplace_back(DRE, DRE->getDecl()); cchen wrote: > ABataev wrote: > > Shall we do this only if

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15499-15501 RelevantExpr = DRE; // Record the component. Components.emplace_back(DRE, DRE->getDecl()); ABataev wrote: > Shall we do this

[PATCH] D75350: [OpenMP] Allow const parameters in declare simd linear clause

huntergr updated this revision to Diff 247294. huntergr added a comment. - Added a function body to the test so that it would generate symbols - Added check lines to ensure the mangled name is present - Reformatted the params of Sema::CheckOpenMPLinearDecl to comply with coding style.

[PATCH] D75360: [analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow CheckerManager to be constructed for non-analysis purposes

Szelethus added a comment. Phabricator didn't pick up on it (because I accidentally used `mv` instead of `git mv`), but `CheckerRegistration.h` was moved to `AnalyzerHelpFlags.h`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75360/new/ https://reviews.llvm.org/D75360

[PATCH] D75271: [analyzer][NFC] Change LangOptions to CheckerManager in the shouldRegister* functions.

Szelethus updated this revision to Diff 247292. Szelethus retitled this revision from "[Analyzer][NFC] Add AnalyzerOptions parameter to shouldRegisterXXX() functions" to "[analyzer][NFC] Change LangOptions to CheckerManager in the shouldRegister* functions.". Szelethus edited the summary of this

[PATCH] D75364: [clang-format] Handle macros in function params and return value

tamas.petz created this revision. tamas.petz added reviewers: chandlerc, djasper. tamas.petz added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds support to handle macros in function parameter list and function return type.

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15499-15501 RelevantExpr = DRE; // Record the component. Components.emplace_back(DRE, DRE->getDecl()); Shall we do this only if `RelevantExpr` is nullptr?

[PATCH] D75360: [analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow CheckerManager to be constructed for non-analysis purposes

Szelethus updated this revision to Diff 247291. Szelethus added a comment. Unforget git add. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75360/new/ https://reviews.llvm.org/D75360 Files: clang/include/clang/StaticAnalyzer/Core/CheckerManager.h

[PATCH] D75162: [X86][F16C] Remove cvtph2ps intrinsics and use generic half2float conversion (PR37554)

RKSimon updated this revision to Diff 247288. RKSimon added a comment. Add strict fp codegen tests - this means the patch is now dependent on D75304 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75162/new/

[PATCH] D75271: [Analyzer][NFC] Add AnalyzerOptions parameter to shouldRegisterXXX() functions

Szelethus commandeered this revision. Szelethus edited reviewers, added: baloghadamsoftware; removed: Szelethus. Szelethus added a comment. Yoink. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75271/new/ https://reviews.llvm.org/D75271

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Type.h:6199-6200 + friend class ASTContext; + bool IsUnsigned; + unsigned NumBits; + Would it be a bad idea to use a bit-field here to smash these fields together? (I don't want to

[PATCH] D75360: [analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow CheckerManager to be constructed for non-analysis purposes

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, baloghadamsoftware, rnkovacs, balazske, martong, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet,

[clang] bfa0aaf - [AVX512] Add strict-fp cvtph2ps constrained tests

Author: Simon Pilgrim Date: 2020-02-28T16:55:00Z New Revision: bfa0aaf37f8d68cb7fb63eff5c825724c3829d09 URL: https://github.com/llvm/llvm-project/commit/bfa0aaf37f8d68cb7fb63eff5c825724c3829d09 DIFF: https://github.com/llvm/llvm-project/commit/bfa0aaf37f8d68cb7fb63eff5c825724c3829d09.diff

[clang] a06402c - [F16C] Add strict-fp constrained tests

Author: Simon Pilgrim Date: 2020-02-28T16:55:00Z New Revision: a06402cc69c07bc18c729b23bedb53b929411f36 URL: https://github.com/llvm/llvm-project/commit/a06402cc69c07bc18c729b23bedb53b929411f36 DIFF: https://github.com/llvm/llvm-project/commit/a06402cc69c07bc18c729b23bedb53b929411f36.diff

Re: [clang] d930ed1 - Disallow use of __has_c_attribute in C++ mode.

On Fri, Feb 28, 2020 at 11:23 AM James Y Knight via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Fri, Feb 28, 2020 at 10:05 AM Aaron Ballman > wrote: > >> On Thu, Feb 27, 2020 at 6:04 PM James Y Knight >> wrote: >> > >> > But, even with all that, I'm not sure why we shouldn't implement

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

yaxunl updated this revision to Diff 247275. yaxunl added a comment. Do not traverse the whole CU. Record potentially emitted functions and variables in the normal parsing and traverse them instead. Also fixed bug 44948 and regression in check-mlir. CHANGES SINCE LAST ACTION

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

__simt__ added a comment. In D74918#1897636 , @kristof.beyls wrote: > If these values are part of the C++ target platform ABI, it seems to me the > values for std::hardware_{constructive,destructive}_interference_size should > be set by whoever has the

[PATCH] D75356: [Analyzer][StreamChecker] Introduction of stream error state handling.

balazske created this revision. Herald added subscribers: cfe-commits, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. balazske added a parent

Re: [clang] d930ed1 - Disallow use of __has_c_attribute in C++ mode.

On Fri, Feb 28, 2020 at 10:05 AM Aaron Ballman wrote: > On Thu, Feb 27, 2020 at 6:04 PM James Y Knight > wrote: > > > > That all makes sense -- especially the bits about the dates needing to > be different. > > > > But, even with all that, I'm not sure why we shouldn't implement both >

[PATCH] D75285: Mark restrict pointer or reference to const as invariant

rjmccall added a comment. In D75285#1897537 , @JonChesterfield wrote: > In D75285#1897247 , @yaxunl wrote: > > > If users derive a non-const pointer from the const pointer and modify it, > > doesn't that result

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp:25 + isa(S) || + isa(S) || + isa(S) || How about `throw` expressions? Comment at:

[PATCH] D73186: [AST] Add fixed-point multiplication constant evaluation.

rjmccall added a comment. Since we've settled on not considering that to be overflow, yeah, I think the patch is fine. Might be worth being explicit about that at the point you do the shift: that it's known that this discards precision that could leave the true mathematical value outside of

[PATCH] D75210: [Attr] Allow ParsedAttr to be constructor for any Attribute

jdoerfert added a comment. In D75210#1898012 , @aaron.ballman wrote: > I think this direction is reasonable to go with, but would prefer to land > this with the code actually using this functionality (as there's not really a > good way to test it,

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

tejohnson added a comment. The last patch from my side just went in (D74162 : [Inliner] Inlining should honor nobuiltin attributes). So I think this is now complete. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

abrachet added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/RestrictSystemLibcHeadersCheck.cpp:40 +SrcMgr::CharacteristicKind FileType) { + if (SrcMgr::isSystem(FileType)) { +if (!SM.isInMainFile(HashLoc)) { Could you whitelist

[PATCH] D75350: [OpenMP] Allow const parameters in declare simd linear clause

huntergr added inline comments. Comment at: clang/test/OpenMP/declare_simd_codegen.cpp:118 +#pragma omp declare simd notinbranch linear(i) +double constlinear(const int i); + fpetrogalli wrote: > Shouldn't you check that the `_ZGV *` name is generated? Ok, and I

Re: [clang] d930ed1 - Disallow use of __has_c_attribute in C++ mode.

On Thu, Feb 27, 2020 at 6:04 PM James Y Knight wrote: > > That all makes sense -- especially the bits about the dates needing to be > different. > > But, even with all that, I'm not sure why we shouldn't implement both > __has_cpp_attribute AND __has_c_attribute in C++ mode? > > The subset of C

[PATCH] D75350: [OpenMP] Allow const parameters in declare simd linear clause

fpetrogalli added inline comments. Comment at: clang/test/OpenMP/declare_simd_codegen.cpp:118 +#pragma omp declare simd notinbranch linear(i) +double constlinear(const int i); + Shouldn't you check that the `_ZGV *` name is generated? Repository: rG LLVM

[PATCH] D75319: Remove unused parameter from CXXRecordDecl::forallBases [NFC]

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75319/new/ https://reviews.llvm.org/D75319

[PATCH] D75210: [Attr] Allow ParsedAttr to be constructor for any Attribute

aaron.ballman added a comment. I think this direction is reasonable to go with, but would prefer to land this with the code actually using this functionality (as there's not really a good way to test it, otherwise). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75350: [OpenMP] Allow const parameters in declare simd linear clause

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75350/new/ https://reviews.llvm.org/D75350

[PATCH] D75139: [hexagon] Pickup the default crt and libs when the musl target is selected

sidneym updated this revision to Diff 247251. sidneym added a comment. Move selection of the dynamic linker before user args are added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75139/new/ https://reviews.llvm.org/D75139 Files:

[PATCH] D75350: [OpenMP] Allow const parameters in declare simd linear clause

huntergr created this revision. huntergr added reviewers: ABataev, kkwli0. Herald added a subscriber: guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. Section 2.19.3 (List Item Privatization) of the OpenMP 5.0 standard does not apply to declarative directives, only to

[PATCH] D75159: [clang-tidy] Fix PR#37210 'Out-of-class template constructor only half-fixed with modernize-pass-by-value'

aaron.ballman closed this revision. aaron.ballman added a comment. In D75159#1897349 , @f00kat wrote: > Can you commit it please? Happy to do so, but you may want to consider getting git access yourself as you've authored quite a few patches. For more

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao updated this revision to Diff 247248. hliao added a comment. Fix pre-merge checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 Files: clang/include/clang/Sema/Sema.h

[clang-tools-extra] 365c99f - Skip TemplateSpecializedType in modernize-pass-by-value.

Author: Karasev Nikita Date: 2020-02-28T09:17:16-05:00 New Revision: 365c99fd7d5461be902a5cec54d773cb82b56101 URL: https://github.com/llvm/llvm-project/commit/365c99fd7d5461be902a5cec54d773cb82b56101 DIFF:

[PATCH] D71775: [ThreadPool] On Windows, extend usage to all CPU sockets and all NUMA groups

mehdi_amini added inline comments. Comment at: llvm/lib/Support/Threading.cpp:94 + // uselessly induce more context-switching and cache eviction. + if (!ThreadsRequested || ThreadsRequested > (unsigned)MaxThreadCount) +return MaxThreadCount; aganea wrote:

[PATCH] D75252: [ARM,MVE] Add ACLE intrinsics for VQMOV[U]N family.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. I had some code somewhere that was trying to produce VQMOVNbh from codegen, treating them as a saturating truncate. It would only work in certain situations thought, relying on demand bits

[PATCH] D75292: [clangd] Remove the word 'toy' from the description of vscode-clangd

hokein added a comment. I think we can even delete this file, since this is boilerplate doc generated by the vscode extension generator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75292/new/ https://reviews.llvm.org/D75292

[PATCH] D75259: [clangd] Get rid of unnecssary source transformations in locateMacroAt

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/SourceCodeTests.cpp:440 +TEST(SourceCodeTests, WorksAtBeginOfFile) { + Annotations Code("^MACRO;"); + TestTU TU =

[PATCH] D75331: [clangd] Get rid of lexer usage in locateMacroAt

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/SourceCode.h:285 }; /// Gets the macro at a specified \p Loc. It must be a spelling location and /// point to the beginning of

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

Eugene.Zelenko added a comment. Please mention new module in docs/clang-tidy/index.rst and Release Notes (new modules section is above new checks one and please add subsubsection). Comment at: clang-tools-extra/clang-tidy/llvmlibc/LLVMLibcTidyModule.cpp:21 + void

[PATCH] D75289: [clang-tidy] Added virtual isLanguageVersionSupported to ClangTidyCheck

This revision was automatically updated to reflect the committed changes. Closed by commit rG39c4246e1e5b: [clang-tidy] Added virtual isLanguageVersionSupported to ClangTidyCheck (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 39c4246 - [clang-tidy] Added virtual isLanguageVersionSupported to ClangTidyCheck

Author: Nathan James Date: 2020-02-28T13:05:05Z New Revision: 39c4246e1e5bb76b1bca2e4b0d0ebc4005d75c32 URL: https://github.com/llvm/llvm-project/commit/39c4246e1e5bb76b1bca2e4b0d0ebc4005d75c32 DIFF: https://github.com/llvm/llvm-project/commit/39c4246e1e5bb76b1bca2e4b0d0ebc4005d75c32.diff LOG:

[PATCH] D75289: [clang-tidy] Added virtual isLanguageVersionSupported to ClangTidyCheck

njames93 updated this revision to Diff 247230. njames93 marked an inline comment as done. njames93 added a comment. - Moved isLanguageVersionSupported above register functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75289/new/

[PATCH] D75336: [clang-format] Improve C# handling of spaces in square brackets

This revision was automatically updated to reflect the committed changes. Closed by commit rGf829615205f0: [clang-format] Improve C# handling of spaces in square brackets (authored by Jonathan Coe jb...@google.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   >