[PATCH] D74361: [Clang] Undef attribute for global variables

2020-03-01 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D74361#1896982 , @JonChesterfield wrote: > In D74361#1879559 , @rjmccall wrote: > > > This will need to impact static analysis and the AST, I think. Local > > variables can't be

[PATCH] D75323: Support relative dest paths in headermap files

2020-03-01 Thread Simon Que via Phabricator via cfe-commits
sque updated this revision to Diff 247558. sque added a comment. Format json according to RFC 8259 (https://jsonformatter.curiousconcept.com/) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75323/new/ https://reviews.llvm.org/D75323 Files: clang/lib/Lex/HeaderSearch.cpp

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

2020-03-01 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3055 +same spelling and syntax. For pragmas specified at file scope, a stack +is supported so that the pragma float_control settings can be pushed or popped. + `pragma float_control`

[PATCH] D75323: Support relative dest paths in headermap files

2020-03-01 Thread Takuto Ikuta via Phabricator via cfe-commits
takuto.ikuta added inline comments. Comment at: clang/test/Headers/Inputs/headermap_relpath/empty.hmap.json:1 +{"mappings":{"empty/empty.h":"include/empty.h"}} better to format like other hmap.json? CHANGES SINCE LAST ACTION

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

2020-03-01 Thread Sourabh Singh Tomar via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc2b437d53d40: [DebugInfo][clang][DWARF5]: Added support for debuginfo generation for… (authored by awpandey, committed by SouraVX). Changed prior to commit:

[clang] c2b437d - [DebugInfo][clang][DWARF5]: Added support for debuginfo generation for defaulted parameters

2020-03-01 Thread Sourabh Singh Tomar via cfe-commits
Author: Awanish Pandey Date: 2020-03-02T12:33:05+05:30 New Revision: c2b437d53d40b6dc5603c97f527398f477d9c5f1 URL: https://github.com/llvm/llvm-project/commit/c2b437d53d40b6dc5603c97f527398f477d9c5f1 DIFF:

[PATCH] D75323: Support relative dest paths in headermap files

2020-03-01 Thread Simon Que via Phabricator via cfe-commits
sque updated this revision to Diff 247554. sque added a comment. Delete unnecessary comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75323/new/ https://reviews.llvm.org/D75323 Files: clang/lib/Lex/HeaderSearch.cpp clang/test/Headers/Inputs/headermap_relpath/empty.hmap.json

[PATCH] D75423: [OpenCL] Mark pointers to constant address space as invariant

2020-03-01 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:172 + if (llvm::Constant *C = dyn_cast(Addr)) +Cast = llvm::ConstantExpr::getBitCast(C, ObjectPtr[0]); + else This check is already done by `CreateBitCast`.

[PATCH] D75387: [Sema] Look through OpaqueValueExpr when checking implicit conversions

2020-03-01 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Seems reasonable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75387/new/ https://reviews.llvm.org/D75387 ___ cfe-commits mailing

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

2020-03-01 Thread Awanish Pandey via Phabricator via cfe-commits
awpandey updated this revision to Diff 247546. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73462/new/ https://reviews.llvm.org/D73462 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/debug-info-template-parameter.cpp llvm/include/llvm/IR/DIBuilder.h

[PATCH] D75373: [Clang] Fix Hurd toolchain class hierarchy

2020-03-01 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea updated this revision to Diff 247542. aganea edited the summary of this revision. aganea added a comment. The patch did not make sense conceptually. Hurd is not Linux. I think now it makes more sense. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75373/new/

[PATCH] D75323: Support relative dest paths in headermap files

2020-03-01 Thread Simon Que via Phabricator via cfe-commits
sque updated this revision to Diff 247540. sque marked an inline comment as done. sque added a comment. Changed to generate hmap file using hmaptool. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75323/new/ https://reviews.llvm.org/D75323 Files: clang/lib/Lex/HeaderSearch.cpp

[PATCH] D75323: Support relative dest paths in headermap files

2020-03-01 Thread Simon Que via Phabricator via cfe-commits
sque marked an inline comment as done. sque added inline comments. Comment at: clang/test/Headers/headermap_relpath.cpp:8 + +// RUN: cd %S; %clang_cc1 -I %S/Inputs/empty.hmap %s + takuto.ikuta wrote: > generate header map using hmaptool like >

[PATCH] D75429: [clangd] DefineOutline removes `override` specified from overridden methods.

2020-03-01 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 247538. njames93 added a comment. - Fix assertion when no Attrs are present Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75429/new/ https://reviews.llvm.org/D75429 Files:

[PATCH] D75429: [clangd] DefineOutline removes `override` specified from overridden methods.

2020-03-01 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 247535. njames93 added a comment. - Made the replacements macro safe Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75429/new/ https://reviews.llvm.org/D75429 Files:

[PATCH] D75432: [analyzer][NFC][MallocChecker] Convert many parameters into CallEvent

2020-03-01 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, baloghadamsoftware, dcoughlin, rnkovacs, balazske, martong. Szelethus added a project: clang. Herald added subscribers: cfe-commits, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet,

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

2020-03-01 Thread Stefanos Baziotis via Phabricator via cfe-commits
baziotis added a comment. > If that happens, this Phabricator review does not close automatically. It has > to be closed manually using the "Add Action..." dropdown. Noted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74801/new/ https://reviews.llvm.org/D74801

[PATCH] D75429: [clangd] DefineOutline removes `override` specified from overridden methods.

2020-03-01 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 247533. njames93 added a comment. - Extend to add virtual and final support Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75429/new/ https://reviews.llvm.org/D75429 Files:

[PATCH] D75431: [analyzer][NFC] Merge checkNewAllocator's paramaters into CXXAllocatorCall

2020-03-01 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus created this revision. Szelethus added reviewers: NoQ, baloghadamsoftware, balazske, martong, dcoughlin, xazax.hun, rnkovacs. Szelethus added a project: clang. Herald added subscribers: cfe-commits, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet,

[PATCH] D72874: [clangd] Add a textual fallback for go-to-definition

2020-03-01 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. I've addressed some of the review comments, with a view to getting something minimal we can land, and improve on in follow-up changes. Mostly, I focused on the suggestions which reduce the number of results. I've left other suggestions which increase the number of

[PATCH] D72874: [clangd] Add a textual fallback for go-to-definition

2020-03-01 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 247529. nridge added a comment. Address some review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72874/new/ https://reviews.llvm.org/D72874 Files: clang-tools-extra/clangd/SourceCode.cpp

[PATCH] D75430: [analyzer][NFC] Introduce CXXDeallocatorCall, deploy it in MallocChecker

2020-03-01 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus created this revision. Szelethus added reviewers: balazske, martong, NoQ, xazax.hun, rnkovacs, dcoughlin, baloghadamsoftware. Herald added subscribers: cfe-commits, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. Herald added a

[PATCH] D75410: [clang-format] Fixed BraceWrapping.AfterExternBlock

2020-03-01 Thread Marcus Johnson via Phabricator via cfe-commits
MarcusJohnson91 updated this revision to Diff 247524. MarcusJohnson91 added a comment. Full Context Diff (I think?) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75410/new/ https://reviews.llvm.org/D75410 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D75429: [clangd] DefineOutline removes `override` specified from overridden methods.

2020-03-01 Thread Nathan James via Phabricator via cfe-commits
njames93 created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. njames93 edited the summary of this revision. njames93 added a project: clang-tools-extra. The define out of line refactor tool

[PATCH] D75410: [clang-format] Fixed BraceWrapping.AfterExternBlock

2020-03-01 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. This needs a full context diff, before we can even look at it properly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D41223: [libc++] Fix PR35491 - std::array of zero-size doesn't work with non-default constructible types.

2020-03-01 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. In D41223#1899394 , @jtbandes wrote: > The lack of `_LIBCPP_CONSTEXPR_AFTER_CXX14` on the `array` > specialization's `begin()`, `end()`, and other methods seems to be a bug: >

[PATCH] D72911: clang-format: fix spacing in `operator const char*()`

2020-03-01 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru added subscribers: hans, sylvestre.ledru. sylvestre.ledru added a comment. @krasimir @MyDeveloperDay @hans Looks like it is a regression from https://reviews.llvm.org/D72911 and the fix isn't in 10.0rc2. Should we take it? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D67052: Add reference type transformation builtins

2020-03-01 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. LGTM once all of the inline comments are addressed. After that, this is ready to land. Comment at: clang/lib/AST/ItaniumMangle.cpp:3412 break; + case UnaryTransformType::RemoveReferenceType: +Out << "3err";

[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

2020-03-01 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru added subscribers: hans, sylvestre.ledru. sylvestre.ledru added a comment. @MyDeveloperDay @hans what about adding this to the release notes? I was trying clang-format 10 on Firefox code base and I noticed this change which isn't documented in

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

2020-03-01 Thread Michael Kruse via Phabricator via cfe-commits
Meinersbur closed this revision. Meinersbur added a comment. In D74801#189 , @baziotis wrote: > I committed that > (https://reviews.llvm.org/rG21390eab4c05e0ed7e7d13ada9e85f62b87ea484) but as > it seems, I should have added the differential division

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

2020-03-01 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73052/new/ https://reviews.llvm.org/D73052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68165: [analyzer][MallocChecker][NFC] Split checkPostCall up, deploy CallDescriptionMap

2020-03-01 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus marked 4 inline comments as done. Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:378-379 + + using CheckFn = void (MallocChecker::*)(CheckerContext , const CallExpr *CE, +

[PATCH] D68165: [analyzer][MallocChecker][NFC] Split checkPostCall up, deploy CallDescriptionMap

2020-03-01 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus updated this revision to Diff 247512. Szelethus added a reviewer: balazske. Szelethus set the repository for this revision to rG LLVM Github Monorepo. Szelethus added a comment. Address inlines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75153: [ThinLTO] Allow usage of all SMT threads in the system

2020-03-01 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea added a comment. @mehdi_amini Agreed. In that case, I just need to slightly change this function to ensure threads are equally dispatched on all CPU sockets regardless of the thread strategy.

[PATCH] D75153: [ThinLTO] Allow usage of all SMT threads in the system

2020-03-01 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added a comment. > /opt:lldltojobs=N -- limit usage to N threads, but constrained by usage of > heavyweight_hardware_concurrency(). I really dislike this behavior: this seems user hostile to me. I would either: - honor the user request (eventually display a warning), this is in

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

2020-03-01 Thread Stefanos Baziotis via Phabricator via cfe-commits
baziotis added a comment. I committed that (https://reviews.llvm.org/rG21390eab4c05e0ed7e7d13ada9e85f62b87ea484) but as it seems, I should have added the differential division in the commit message. I'll try the next commit to be better. CHANGES SINCE LAST ACTION

[clang-tools-extra] 21390ea - [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

2020-03-01 Thread Stefanos Baziotis via cfe-commits
Author: Stefanos Baziotis Date: 2020-03-01T19:17:21+02:00 New Revision: 21390eab4c05e0ed7e7d13ada9e85f62b87ea484 URL: https://github.com/llvm/llvm-project/commit/21390eab4c05e0ed7e7d13ada9e85f62b87ea484 DIFF:

[PATCH] D68165: [analyzer][MallocChecker][NFC] Split checkPostCall up, deploy CallDescriptionMap

2020-03-01 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus marked 5 inline comments as done. Szelethus added a comment. Herald added subscribers: martong, steakhal. I've spent a lot of time on this code, and I don't think it'd be a great idea to do everything in a single step. Collapsing `CallExpr, ProgramState` into `CallEvent` is a

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

2020-03-01 Thread Alexey Bader via Phabricator via cfe-commits
bader added a comment. In D72857#1895649 , @bader wrote: > In D72857#1895625 , @thakis wrote: > > > This landed here: > > https://github.com/llvm/llvm-project/commit/bd97704eb5a95ecb048ce343c1a4be5d94e5 > > >

[PATCH] D75255: [ARM,MVE] Add ACLE intrinsics for VCVT[ANPM] family.

2020-03-01 Thread Dave Green via Phabricator via cfe-commits
dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Sound good to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75255/new/ https://reviews.llvm.org/D75255

[PATCH] D75402: [HIP] Make sure, unused hip-pinned-shadow global var is kept within device code

2020-03-01 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75402/new/ https://reviews.llvm.org/D75402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75423: [OpenCL] Mark pointers to constant address space as invariant

2020-03-01 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added reviewers: rjmccall, Anastasia, bader. OpenCL constant address space is immutable, therefore pointers to constant address space can be marked with llvm.invariant.start permanently. This should allow more optimization opportunities in LLVM passes.

[clang] 624dbfc - [Coroutines][New pass manager] Move CoroElide pass to right position

2020-03-01 Thread Jun Ma via cfe-commits
Author: Jun Ma Date: 2020-03-01T21:48:24+08:00 New Revision: 624dbfcc1b81520d2211d43a759f817d0b131de0 URL: https://github.com/llvm/llvm-project/commit/624dbfcc1b81520d2211d43a759f817d0b131de0 DIFF: https://github.com/llvm/llvm-project/commit/624dbfcc1b81520d2211d43a759f817d0b131de0.diff LOG:

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

2020-03-01 Thread Nathan James via Phabricator via cfe-commits
njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/RestrictSystemLibcHeadersCheck.cpp:40 +SrcMgr::CharacteristicKind FileType) { + if (SrcMgr::isSystem(FileType)) { +if (!SM.isInMainFile(HashLoc)) { abrachet wrote: >