[PATCH] D75569: [clang-tidy] New check for methods marked __attribute__((unavailable)) that do not override a method from a superclass.

njames93 added a comment. Can objc instance methods be redeclared, the AST suggests so, if so you should probably only warm on the first occurrence but create fix its for each. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75569/new/

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

PaulkaToast updated this revision to Diff 248900. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75786/new/ https://reviews.llvm.org/D75786 Files: clang-tools-extra/clang-tidy/fuchsia/CMakeLists.txt

[PATCH] D75788: [WIP][OpenMP] Reuse CUDA wrappers in `nvptx` target regions.

jdoerfert marked an inline comment as done. jdoerfert added a comment. In D75788#1910743 , @JonChesterfield wrote: > That's less invasive than I feared. Nicely done. We need to run some more tests to make sure it works as expected but I hope we can

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:130 ^^ +- The 'fuchsia-restrict-system-headers' check was renamed to :doc:`portability-restrict-system-includes + Please insert empty line above.

[PATCH] D75723: [X86] Make intrinsics _BitScan* not limited to Windows

skan marked an inline comment as done. skan added inline comments. Comment at: clang/include/clang/Basic/BuiltinsX86.def:1904 +// BITSCAN +TARGET_BUILTIN(_BitScanForward, "UcUNi*UNi", "n", "") +TARGET_BUILTIN(_BitScanReverse, "UcUNi*UNi", "n", "") rnk wrote: >

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

PaulkaToast updated this revision to Diff 248882. PaulkaToast marked 5 inline comments as done. PaulkaToast added a comment. Thanks for the heads up phosek, I removed the check from fuchsia's directory. Also addressed Eurgene.Zelenko's comments. (: Repository: rG LLVM Github Monorepo

[PATCH] D75700: [NFC] Let mangler accept GlobalDecl

rjmccall added inline comments. Comment at: clang/lib/AST/Expr.cpp:693 else - MC->mangleName(ND, Out); + GD = GlobalDecl(ND); +MC->mangleName(GD, Out); This will need an extension for your case, right? Maybe there should be

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:107 + + Moved fuchsia's restrict-system-includes check to portability to allow for + general use. I don't think that this statement is necessary.

[PATCH] D75788: [WIP][OpenMP] Reuse CUDA wrappers in `nvptx` target regions.

JonChesterfield added a comment. That's less invasive than I feared. Nicely done. It may worth keeping the openmp header wrapper to do architecture dispatch. Something like: #ifndef __CLANG_OPENMP_MATH_DECLARES_H__ #define __CLANG_OPENMP_MATH_DECLARES_H__ #ifndef _OPENMP #error

[PATCH] D75700: [NFC] Let mangler accept GlobalDecl

yaxunl updated this revision to Diff 248873. yaxunl added a comment. Remove mangleCXXCtor/Dtor. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75700/new/ https://reviews.llvm.org/D75700 Files: clang/include/clang/AST/GlobalDecl.h clang/include/clang/AST/Mangle.h

[PATCH] D72954: [clang-doc] Improving Markdown Output

This revision was automatically updated to reflect the committed changes. Closed by commit rG7003f64c1eb2: [clang-doc] Improving Markdown Output (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D72954?vs=248338=248875#toc Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 created this revision. MarcusJohnson91 added a reviewer: cfe-commits. Herald added a project: clang. and refactored the BraceWrapping.AfterExternBlock code so that it only deals with wrapping the brace after an extern block. Repository: rG LLVM Github Monorepo

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

MaskRay added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:123 +- New alias :doc:`fuchsia-restrict-system-includes + ` to Delete `fuchsia-restrict-system-includes` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 7003f64 - [clang-doc] Improving Markdown Output

Author: Petr Hosek Date: 2020-03-06T17:37:08-08:00 New Revision: 7003f64c1eb25e6a0dd10a4beabc3ca7bcaef7eb URL: https://github.com/llvm/llvm-project/commit/7003f64c1eb25e6a0dd10a4beabc3ca7bcaef7eb DIFF: https://github.com/llvm/llvm-project/commit/7003f64c1eb25e6a0dd10a4beabc3ca7bcaef7eb.diff

[PATCH] D75788: [WIP][OpenMP] Reuse CUDA wrappers in `nvptx` target regions.

jdoerfert created this revision. jdoerfert added reviewers: kiranchandramohan, ABataev, RaviNarayanaswamy, gtbercea, grokos, sdmitriev, JonChesterfield, hfinkel, fghanim, aaron.ballman. Herald added subscribers: guansong, bollu, mgorny. Herald added a project: clang. This is a WIP patch to show

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. We're not using this module in Fuchsia at the moment, so I'd be fine not having an alias at all, if we start using it again in the future we'll use the new name. Repository: rG LLVM

[PATCH] D75784: Avoid including Module.h from ExternalASTSource.h

aprantl added a comment. This will no doubt also need some patches to the Swift compiler, but given the NFC-ness this hopefully should be fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75784/new/ https://reviews.llvm.org/D75784

[PATCH] D75323: Support relative dest paths in headermap files

vsapsai added a comment. What use case are you trying to support? Currently the added test `headermap_relpath.cpp` is passing without the changes to `HeaderSearch.cpp`, so it's not entirely clear what problem it should address. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75323/new/

[clang] f4d791f - [CodeGen][ObjC] Extend lifetime of ObjC pointers passed to calls to

Author: Akira Hatanaka Date: 2020-03-06T16:46:50-08:00 New Revision: f4d791f8332c2bb7e89849d0fe4ef48cb0a23229 URL: https://github.com/llvm/llvm-project/commit/f4d791f8332c2bb7e89849d0fe4ef48cb0a23229 DIFF:

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

PaulkaToast created this revision. PaulkaToast added a reviewer: aaron.ballman. PaulkaToast added a project: clang-tools-extra. Herald added subscribers: cfe-commits, phosek, xazax.hun, mgorny. Herald added a project: clang. Created a general check for restrict-system-includes under portability

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

PaulkaToast updated this revision to Diff 248851. PaulkaToast added a comment. Thanks for the suggestions, the general check sounds like a great idea. I can see the use case for this as it can be used by anyone. I took the time to port out fuchsia's check and flesh out the user facing

[PATCH] D75784: Avoid including Module.h from ExternalASTSource.h

rnk created this revision. rnk added reviewers: aaron.ballman, hans. Herald added projects: clang, LLDB. Herald added a subscriber: lldb-commits. Module.h takes 86ms to parse, mostly parsing the class itself. Avoid it if possible. ASTContext.h depends on ExternalASTSource.h. A few NFC changes

[PATCH] D75700: [NFC] Let mangler accept GlobalDecl

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1028 else - MC.mangleName(ND, Out); + MC.mangleName(GD, Out); } else { yaxunl wrote: > rjmccall wrote: > > What would be

[PATCH] D75643: [Sema] Don't emit pointer to int cast warnings under -Wmicrosoft-cast

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. I re-read Richard's comment: > Would it make sense to put the MS extension warning into the > -Wpointer-to-int-cast group so that we can control this warning consistently > across platforms? You

Re: [clang] 8e4a867 - Revert "PR45083: Mark statement expressions as being dependent if they contain"

On Fri, 6 Mar 2020 at 02:11, Stephan Herhut via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: Stephan Herhut > Date: 2020-03-06T11:09:45+01:00 > New Revision: 8e4a8677be3061317056335d298d85ce60c23dff > > URL: >

[PATCH] D75210: [Attr] Allow ParsedAttr to be constructor for any Attribute

jdoerfert updated this revision to Diff 248845. jdoerfert added a comment. Pass parsed attribute kind explicitly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75210/new/ https://reviews.llvm.org/D75210 Files:

[PATCH] D75770: [WebAssembly] Add SIMD integer min/max builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rGd43fcd0c0410: [WebAssembly] Add SIMD integer min/max builtins (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75770/new/

[clang] d43fcd0 - [WebAssembly] Add SIMD integer min/max builtins

Author: Thomas Lively Date: 2020-03-06T14:28:52-08:00 New Revision: d43fcd0c0410d474a947cf51a3c67aa2e8d5a711 URL: https://github.com/llvm/llvm-project/commit/d43fcd0c0410d474a947cf51a3c67aa2e8d5a711 DIFF: https://github.com/llvm/llvm-project/commit/d43fcd0c0410d474a947cf51a3c67aa2e8d5a711.diff

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nickdesaulniers updated this revision to Diff 248827. nickdesaulniers added a comment. - add release note about change in behavior of -Wduplicate-decl-specifier Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75563/new/

[PATCH] D75517: [clang-format] Do not format C# array subscript operators as attributes

krasimir added a comment. sorry could you please take another look at the comments I left Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75517/new/ https://reviews.llvm.org/D75517 ___ cfe-commits

[PATCH] D75752: [Sema] Move pointer to int cast warnings under -Wmicrosoft-cast

aeubanks added a comment. Specifically regarding ../../base/debug/close_handle_hook_win.cc(155,16): error: cast to smaller integer type 'unsigned long' from 'void *', I sent out a change to fix that: https://chromium-review.googlesource.com/c/chromium/src/+/2091215, and tried compiling with

[PATCH] D75758: [Sema] Add -Wpointer-to-enum-cast and -Wvoid-pointer-to-enum-cast

nathanchance marked 2 inline comments as done. nathanchance added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3673 +def warn_pointer_to_enum_cast : Warning< + "cast to smaller integer type %1 from %0">, + InGroup; xbolva00

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nickdesaulniers updated this revision to Diff 248825. nickdesaulniers added a comment. - use better error name - reorder new errors - git-clang-format HEAD~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75563/new/ https://reviews.llvm.org/D75563

[PATCH] D75758: [Sema] Add -Wpointer-to-enum-cast and -Wvoid-pointer-to-enum-cast

nathanchance updated this revision to Diff 248824. nathanchance edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75758/new/ https://reviews.llvm.org/D75758 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D75719: [clang][Headers] Use __has_builtin instead of _MSC_VER.

This revision was automatically updated to reflect the committed changes. Closed by commit rG16af23fae8ad: [clang][Headers] Use __has_builtin instead of _MSC_VER. (authored by Bigcheese). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75719/new/

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:15 -def warn_asm_qualifier_ignored : Warning< - "ignored %0 qualifier on asm">, CatInlineAsm, InGroup; -def

[clang] 16af23f - [clang][Headers] Use __has_builtin instead of _MSC_VER.

Author: Michael Spencer Date: 2020-03-06T13:48:09-08:00 New Revision: 16af23fae8ad2949048e0fc34cf9114dfbe4742a URL: https://github.com/llvm/llvm-project/commit/16af23fae8ad2949048e0fc34cf9114dfbe4742a DIFF:

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nickdesaulniers updated this revision to Diff 248816. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. Herald added subscribers: jfb, aheejin. - completely drop use of Parse::ParseTypeQualifierListOpt - move paren parsing into helper - fix up test cases for

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nickdesaulniers marked 4 inline comments as done. nickdesaulniers added inline comments. Comment at: clang/lib/Parse/ParseStmtAsm.cpp:746-755 ParseTypeQualifierListOpt(DS, AR_VendorAttributesParsed); // GNU asms accept, but warn, about type-qualifiers other than

[PATCH] D75768: Add a warning for builtin_return_address/frame_address with > 0 argument

jstenglein added a comment. In D75768#1910339 , @erichkeane wrote: > In D75768#1910324 , @jstenglein > wrote: > > > In D75768#1910303 , @erichkeane > > wrote: > > > > >

[PATCH] D75768: Add a warning for builtin_return_address/frame_address with > 0 argument

erichkeane added a comment. In D75768#1910324 , @jstenglein wrote: > In D75768#1910303 , @erichkeane > wrote: > > > Any reason to not put this in -Wall like GCC? I'm not terribly > > knowledgeable about the

[libunwind] eb755df - Split findUnwindSectionsByPhdr into target-specific functions.

Author: Sterling Augustine Date: 2020-03-06T13:28:09-08:00 New Revision: eb755df5c27f5687a4f43a62e7eb0713c3f8f030 URL: https://github.com/llvm/llvm-project/commit/eb755df5c27f5687a4f43a62e7eb0713c3f8f030 DIFF:

[clang] 6d894af - PR45124: Don't leave behind pending cleanups when declaring implicit

Author: Richard Smith Date: 2020-03-06T13:22:10-08:00 New Revision: 6d894afdea433879f54e5ba07e827db006645b7b URL: https://github.com/llvm/llvm-project/commit/6d894afdea433879f54e5ba07e827db006645b7b DIFF: https://github.com/llvm/llvm-project/commit/6d894afdea433879f54e5ba07e827db006645b7b.diff

[PATCH] D75569: [clang-tidy] New check for methods marked __attribute__((unavailable)) that do not override a method from a superclass.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/MethodUnavailableNotOverrideCheck.cpp:63 + } + return FixItHint::CreateRemoval(MD->getSourceRange()); +} I'm not an ObjC expert, so I apologize if this is a dumb question, but

[PATCH] D75770: [WebAssembly] Add SIMD integer min/max builtins

tlively created this revision. tlively added reviewers: aheejin, dschuff, kripken. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100. Herald added a project: clang. Although SIMD integer min/max operations can be expressed using the ?: operator in C++, that operator is

[PATCH] D75752: [Sema] Move pointer to int cast warnings under -Wmicrosoft-cast

rnk added a comment. I agree with the reasoning, but this is likely to fire all over existing C++ code. In fact, the one we just added finds issues in Chrome https://ci.chromium.org/p/chrome/builders/ci/ToTWin/5879 ../../base/debug/close_handle_hook_win.cc(155,16): error: cast to smaller

[PATCH] D75768: Add a warning for builtin_return_address/frame_address with > 0 argument

jstenglein added a comment. In D75768#1910303 , @erichkeane wrote: > Any reason to not put this in -Wall like GCC? I'm not terribly knowledgeable > about the intended guidance for adding to Wmost, so if you can clarify this > decision I'd be grateful.

[PATCH] D75768: Add a warning for builtin_return_address/frame_address with > 0 argument

erichkeane added a comment. Any reason to not put this in -Wall like GCC? I'm not terribly knowledgeable about the intended guidance for adding to Wmost, so if you can clarify this decision I'd be grateful. Otherwise I think this patch looks fine. Repository: rG LLVM Github Monorepo

[PATCH] D74361: [Clang] Undef attribute for global variables

JonChesterfield added a comment. > I thought err_loader_uninitialized_extern says that the variable cannot have > external linkage? Embarrassing! This was a badly written error message, now fixed to: `external declaration of variable cannot have the 'loader_uninitialized' attribute` The

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

zturner added a comment. If the current listed reviewers on this patch are not the best people for reviewing this, would one of them please suggest a more appropriate reviewer so we can get some traction on this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69585/new/

[PATCH] D75768: Add a warning for builtin_return_address/frame_address with > 0 argument

jstenglein created this revision. jstenglein added reviewers: efriedma, lebedev.ri, rsmith, erichkeane. jstenglein added a project: clang. Herald added a subscriber: cfe-commits. Clang is missing a warning for __builtin_return_address/__builtin_frame_address called with > 0 argument. Gcc

[PATCH] D75758: [Sema] Add -Wpointer-to-enum-cast and -Wvoid-pointer-to-enum-cast

xbolva00 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3673 +def warn_pointer_to_enum_cast : Warning< + "cast to smaller integer type %1 from %0">, + InGroup; You can reuse warning text: warn_pointer_to_int_cast.Text I

[PATCH] D74361: [Clang] Undef attribute for global variables

JonChesterfield updated this revision to Diff 248807. JonChesterfield marked 2 inline comments as done. JonChesterfield added a comment. - Review comments, add tests for private_extern Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74361/new/

[PATCH] D75758: [Sema] Add -Wpointer-to-enum-cast and -Wvoid-pointer-to-enum-cast

manojgupta added a comment. Thanks, Verified that this fixes the kernel warnings in my local builds with https://gist.github.com/nathanchance/767cccf4d093c1342e1994083518815e! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75758/new/

[clang] 00b2a9d - Reapply "clang: Treat ieee mode as the default for denormal-fp-math"

Author: Matt Arsenault Date: 2020-03-06T11:46:55-08:00 New Revision: 00b2a9df452d25cf4a780d20bab7d557d76604ae URL: https://github.com/llvm/llvm-project/commit/00b2a9df452d25cf4a780d20bab7d557d76604ae DIFF:

[PATCH] D75723: [X86] Make intrinsics _BitScan* not limited to Windows

rnk added inline comments. Comment at: clang/include/clang/Basic/BuiltinsX86.def:1904 +// BITSCAN +TARGET_BUILTIN(_BitScanForward, "UcUNi*UNi", "n", "") +TARGET_BUILTIN(_BitScanReverse, "UcUNi*UNi", "n", "") craig.topper wrote: > skan wrote: > > craig.topper

[PATCH] D64464: [CodeGen] Emit destructor calls to destruct compound literals

ahatanak updated this revision to Diff 248797. ahatanak added a comment. Don't try to push a cleanup in C++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64464/new/ https://reviews.llvm.org/D64464 Files: clang/include/clang/AST/ASTImporter.h

[PATCH] D53327: [Hexagon] Use -fuse-ld update checks.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53327/new/ https://reviews.llvm.org/D53327 ___ cfe-commits

[PATCH] D64464: [CodeGen] Emit destructor calls to destruct compound literals

ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:4100 + if (E->getType().isDestructedType() == QualType::DK_nontrivial_c_struct) +pushDestroy(QualType::DK_nontrivial_c_struct, DeclPtr, E->getType()); +

[PATCH] D31342: Add ParsedAttrInfo::handleDeclAttribute

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6701-6707 if (!AL.isStmtAttr()) { // Type attributes are handled elsewhere; silently move on. assert(AL.isTypeAttr() && "Non-type attribute not handled"); break; }

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev updated this revision to Diff 248789. ABataev marked an inline comment as done. ABataev added a comment. Rebase + fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74144/new/ https://reviews.llvm.org/D74144 Files:

[PATCH] D31342: Add ParsedAttrInfo::handleDeclAttribute

john.brawn marked 3 inline comments as done. john.brawn added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6701-6707 if (!AL.isStmtAttr()) { // Type attributes are handled elsewhere; silently move on. assert(AL.isTypeAttr() && "Non-type

[PATCH] D75470: [SVE] Auto-generate builtins and header for svld1.

sdesmalen marked an inline comment as done. sdesmalen added a comment. Herald added a subscriber: danielkiss. In D75470#1907562 , @SjoerdMeijer wrote: > Adding @simon_tatham in case he feels wants to have a look too. Thanks Sjoerd! @simon_tatham and I

[PATCH] D75569: [clang-tidy] New check for methods marked __attribute__((unavailable)) that do not override a method from a superclass.

mwyman updated this revision to Diff 248788. mwyman added a comment. Update documentation to include description of the FixMacroNames config option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75569/new/ https://reviews.llvm.org/D75569 Files:

[PATCH] D75298: [Clang][SVE] Parse builtin type string for scalable vectors

sdesmalen added a subscriber: simon_tatham. sdesmalen added a comment. Herald added a subscriber: danielkiss. In D75298#1904561 , @efriedma wrote: > > Do you happen to know which method in Sema does this? I had a look before, > > but couldn't find where

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

martong marked 2 inline comments as done. martong added a comment. In D73898#1901142 , @balazske wrote: > Is it sure that the signedness in the ranges is handled correctly? The EOF is > a negative value but the `RangeInt` is unsigned type. The >

[PATCH] D75760: [clang-format] Do not indent C# array initialisers as continuations

jbcoe created this revision. jbcoe added a reviewer: krasimir. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. jbcoe added a comment. Needs https://reviews.llvm.org/D75731 and https://reviews.llvm.org/D75747 to be merged first. Flag

[PATCH] D75209: [OPENMP][NVPTX]Fix PR45003: add support for complex functions.

ABataev added a comment. In D75209#1909976 , @jdoerfert wrote: > I am unsure we need this with the proper math support. Sema patch for that is > going for review today. I'll try this out soon. It has nothing to do with the math functions support. These

[PATCH] D75760: [clang-format] Do not indent C# array initialisers as continuations

jbcoe added a comment. Needs https://reviews.llvm.org/D75731 and https://reviews.llvm.org/D75747 to be merged first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75760/new/ https://reviews.llvm.org/D75760

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

martong marked 9 inline comments as done. martong added a comment. In D73898#1894923 , @balazske wrote: > It may be useful to make a "macro value map" kind of object. Some macros can > be added to it as a string, and it is possible to lookup for an

[PATCH] D75209: [OPENMP][NVPTX]Fix PR45003: add support for complex functions.

jdoerfert added a comment. I am unsure we need this with the proper math support. Sema patch for that is going for review today. I'll try this out soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75209/new/ https://reviews.llvm.org/D75209

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev marked 6 inline comments as done. ABataev added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:2891 ArgExprs); } + } else if (!getLangOpts().ObjC && getLangOpts().OpenMP >= 50 && jdoerfert

[PATCH] D75758: [Sema] Add -Wpointer-to-enum-cast and -Wvoid-pointer-to-enum-cast

nathanchance created this revision. nathanchance added reviewers: Mordante, rjmccall. Herald added a project: clang. GCC does not warn on casts from pointers to enumerators, while clang currently does: https://godbolt.org/z/3DFDVG This causes a bunch of extra warnings in the Linux kernel, where

[PATCH] D74973: [analyzer] StdLibraryFunctionsChecker refactor w/ inheritance

martong marked 4 inline comments as done. martong added a comment. In D74973#1900852 , @Szelethus wrote: > I have some high level questions, you have spent far more time with this code > and I'm happy to be proven wrong! :) > > In D74973#1889188

[clang] 865456d - [Concepts] Add null check for TemplateTypeParmType::getDecl() in GetContainedInventedTypeParmVisitor

Author: Saar Raz Date: 2020-03-06T19:32:10+02:00 New Revision: 865456d589e093582acaafd17d58ad1c0cce66af URL: https://github.com/llvm/llvm-project/commit/865456d589e093582acaafd17d58ad1c0cce66af DIFF: https://github.com/llvm/llvm-project/commit/865456d589e093582acaafd17d58ad1c0cce66af.diff

[PATCH] D75723: [X86] Make intrinsics _BitScan* not limited to Windows

craig.topper added inline comments. Comment at: clang/include/clang/Basic/BuiltinsX86.def:1904 +// BITSCAN +TARGET_BUILTIN(_BitScanForward, "UcUNi*UNi", "n", "") +TARGET_BUILTIN(_BitScanReverse, "UcUNi*UNi", "n", "") skan wrote: > craig.topper wrote: > > The N

[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

jdoerfert added a comment. In D74935#1909054 , @jeroen.dobbelaere wrote: > In D74935#1908665 , @jdoerfert wrote: > > > I think we conflate two things here: > > > > 1. The modifications to the LangRef which should

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

jdoerfert added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:2891 ArgExprs); } + } else if (!getLangOpts().ObjC && getLangOpts().OpenMP >= 50 && Out of curiosity, why do we prevent Objective C here?

[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

jroelofs updated this revision to Diff 248757. jroelofs added a comment. - Drop dead include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75621/new/ https://reviews.llvm.org/D75621 Files:

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

martong added inline comments. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:365 + llvm::SmallString<256> AbsPath = CTUDir; + llvm::sys::path::append(AbsPath, Identifier); Could we check somehow if `CTUDir` is indeed an absolute path? If not then

[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

jroelofs updated this revision to Diff 248755. jroelofs added a comment. - Don't spam the deprecation message. Move that to release notes. - Drop unnecessary `const`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75621/new/

[clang] 5dadf57 - [OPENMP50]Add 'depobj' modifier in 'depend' clauses.

Author: Alexey Bataev Date: 2020-03-06T11:44:57-05:00 New Revision: 5dadf577d59b53110f2a0084dc9ef9f974116955 URL: https://github.com/llvm/llvm-project/commit/5dadf577d59b53110f2a0084dc9ef9f974116955 DIFF: https://github.com/llvm/llvm-project/commit/5dadf577d59b53110f2a0084dc9ef9f974116955.diff

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev added a comment. Ping 3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74144/new/ https://reviews.llvm.org/D74144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75209: [OPENMP][NVPTX]Fix PR45003: add support for complex functions.

ABataev added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75209/new/ https://reviews.llvm.org/D75209 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2eff1c3ce48e: [clang-format] Extend AllowShortLoopsOnASingleLine to do ... while loops. (authored by mitchell-stellar). Changed prior to commit: https://reviews.llvm.org/D75022?vs=246512=248748#toc

[PATCH] D75752: [Sema] Move pointer to int cast warnings under -Wmicrosoft-cast

aeubanks created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. aeubanks edited the summary of this revision. aeubanks added reviewers: thakis, rnk. aeubanks retitled this revision from "Move warnings added in https://reviews.llvm.org/D75708 under

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

mitchell-stellar added a comment. It's not more approval that is needed, it's just that someone with commit access (assuming you do not) needs to find the time to commit this. For what it's worth, I'm getting a patch rejection for the 4th block in lib/Format/Format.cpp. It seems the contents

[clang] 2eff1c3 - [clang-format] Extend AllowShortLoopsOnASingleLine to do ... while loops.

Author: Mitchell Balan Date: 2020-03-06T11:13:23-05:00 New Revision: 2eff1c3ce48ef529064e2dc006d57c37da0b4d84 URL: https://github.com/llvm/llvm-project/commit/2eff1c3ce48ef529064e2dc006d57c37da0b4d84 DIFF:

[PATCH] D75749: [clang-tidy] extend bugprone-signed-char-misuse check.

ztamas added a comment. In the LibreOffice codebase, I found 8 catches: https://gist.github.com/tzolnai/2b22492c0cf79f5dba577f6a878657e3 All catches seem valid to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75749/new/

[PATCH] D75171: [Analyzer] Fix for incorrect use of container and iterator checkers

Szelethus added a comment. Actually, this is the diff: diff --git a/clang/include/clang/Basic/DiagnosticDriverKinds.td b/clang/include/clang/Basic/DiagnosticDriverKinds.td index ecd871e36ee..1f2c8c50a01 100644 --- a/clang/include/clang/Basic/DiagnosticDriverKinds.td +++

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

yaxunl added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70172/new/ https://reviews.llvm.org/D70172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D68165: [analyzer][MallocChecker][NFC] Split checkPostCall up, deploy CallDescriptionMap

Szelethus marked an inline comment as done. Szelethus added a comment. In D68165#1902702 , @Charusso wrote: > I wish for a third map, something like `ReallocationMap`. Other than that it > is a great direction, I love it. Thanks! Hah, that is a neat

[PATCH] D75749: [clang-tidy] extend bugprone-signed-char-misuse check.

ztamas created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. ztamas added a reviewer: aaron.ballman. ztamas added a comment. I run the check on LLVM code and found only one catch of suspicious comparison: clang-tidy -p=/home/zolnai/clang/build

[PATCH] D75749: [clang-tidy] extend bugprone-signed-char-misuse check.

ztamas added a comment. I run the check on LLVM code and found only one catch of suspicious comparison: clang-tidy -p=/home/zolnai/clang/build /home/zolnai/clang/llvm-project/clang/lib/Lex/Lexer.cpp /home/zolnai/clang/llvm-project/clang/lib/Lex/Lexer.cpp:1293:39: warning: comparison

[PATCH] D75700: [NFC] Let mangler accept GlobalDecl

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1028 else - MC.mangleName(ND, Out); + MC.mangleName(GD, Out); } else { rjmccall wrote: > What would be necessary in order for

[PATCH] D75356: [Analyzer][StreamChecker] Introduction of stream error state handling.

Szelethus added a comment. In D75356#1909610 , @balazske wrote: > The D75682 is the one that should be used > now, If this patch is supposed to be a followup to D75682 , could you

[PATCH] D75356: [Analyzer][StreamChecker] Introduction of stream error state handling.

Szelethus added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75356/new/ https://reviews.llvm.org/D75356 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75745: [clang-tidy] Added AllowMissingMoveFunctionsWhenCopyIsDeleted flag to cppcoreguidelines-special-member-functions

pbaran updated this revision to Diff 248729. pbaran added a comment. Herald added a subscriber: wuzish. Removed unintendedly added comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75745/new/ https://reviews.llvm.org/D75745 Files:

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

aaron.ballman added reviewers: aaron.ballman, rjmccall, erik.pilkington, MadCoder. aaron.ballman added a comment. Herald added a subscriber: dexonsmith. Adding some more knowledgeable reviewers for comments on your RFC. I pointed out a few minor nits, but I'll hold off on a technical review

[PATCH] D75171: [Analyzer] Fix for incorrect use of container and iterator checkers

Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. You seem to have uploaded the wrong diff :) In D75171#1908259 , @baloghadamsoftware wrote: > This is the so called "correct"

  1   2   >