[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 updated this revision to Diff 249838. MarcusJohnson91 added a comment. New squashed commit with all changes present CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Format

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

shiva0217 updated this revision to Diff 249835. shiva0217 added a comment. Update the patch to address @apazos's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57497/new/ https://reviews.llvm.org/D57497 Files: clang/docs/ClangCommandLin

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

shiva0217 added a comment. In D57497#1917835 , @apazos wrote: > Shiva, I see a warning always being printed: > > '+small-data-limit=' is not a recognized feature for this target (ignoring > feature) > > > This is because it is being passed down as a

[PATCH] D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake

vvereschaka added a comment. I tried to reproduce the problem on the builder in a temporary folder and I found that CMAKE_SOURCE_DIR == CMAKE_BINARY_DIR == . Here is a list of all CMAKE_ variables available on a moment of initial configuration: -- CMAKE_AR: c:/buildbot/temp/build/bin/llvm-ar.

[PATCH] D76040: [TableGen] Move generated *Attr class methods out of line

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, thanks. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76040/new/ https://reviews.llvm.org/D76040 __

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

rjmccall added a comment. In D72841#1917459 , @rjmccall wrote: > In D72841#1917340 , @mibintc wrote: > > > @rjmccall Since CompoundAssignmentOperator derives from BinaryOperator, > > it's not simple to add Trailing

[PATCH] D76040: [TableGen] Move generated *Attr class methods out of line

rnk marked an inline comment as done. rnk added a comment. The main things going out of line are: - Create* factory methods - Constructors - Enum/string converters (use StringSwitch -> slow to instantiate) Here's two examples from before & after: https://reviews.llvm.org/P8203 https://reviews.ll

[PATCH] D76040: [TableGen] Move generated *Attr class methods out of line

rjmccall added a comment. Are there any classes of methods which are worth continuing to generate inline? Surely some of the accessors are trivial. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76040/new/ https://reviews.llvm.org/D76040 __

[clang] c4d23d8 - Add a missing include to clang unit tests

Author: Reid Kleckner Date: 2020-03-11T21:05:20-07:00 New Revision: c4d23d8854840294bf49c524f93e2be85a401f00 URL: https://github.com/llvm/llvm-project/commit/c4d23d8854840294bf49c524f93e2be85a401f00 DIFF: https://github.com/llvm/llvm-project/commit/c4d23d8854840294bf49c524f93e2be85a401f00.diff

[clang-tools-extra] d7c5037 - Prune TargetInfo.h include from ParsedAttr.h, NFC

Author: Reid Kleckner Date: 2020-03-11T20:47:11-07:00 New Revision: d7c5037e6b9f0ac76f4880c529ae4e14b78e0bf0 URL: https://github.com/llvm/llvm-project/commit/d7c5037e6b9f0ac76f4880c529ae4e14b78e0bf0 DIFF: https://github.com/llvm/llvm-project/commit/d7c5037e6b9f0ac76f4880c529ae4e14b78e0bf0.diff

[PATCH] D76038: PR45000: Use Sema::SetParamDefaultArgument in TransformLambdaExpr

aaronpuchert added a comment. Seems the same issue in `Sema::SubstParmVarDecl` was fixed in rGdc40b618cf397df7369406b3f61e91ccb57fb9f6 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D75897: [X86] Support intrinsic _mm_broadcastsi128_si256

This revision was automatically updated to reflect the committed changes. Closed by commit rG214d24e1f8e0: [X86] Support intrinsic _mm_broadcastsi128_si256 (authored by skan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75897/new/ https://reviews.

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

logan-5 marked an inline comment as done. logan-5 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-unintended-adl.cpp:202 +void macro_test(T t) { +#define MACRO(x) find_if(x, x, x) + Quuxplusone wrote: > logan-5 wrote: > > E

[PATCH] D76038: PR45000: Use Sema::SetParamDefaultArgument in TransformLambdaExpr

aaronpuchert planned changes to this revision. aaronpuchert added a comment. In D76038#1918571 , @aaronpuchert wrote: > @rsmith, should I put a testcase under `test/SemaTemplate/`, perhaps as > `instantiate-lambda.cpp`? I'll probably put it into `test/

[PATCH] D76038: PR45000: Use Sema::SetParamDefaultArgument in TransformLambdaExpr

aaronpuchert added a comment. @rsmith, should I put a testcase under `test/SemaTemplate/`, perhaps as `instantiate-lambda.cpp`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76038/new/ https://reviews.llvm.org/D76038 ___

[PATCH] D76040: [TableGen] Move generated *Attr class methods out of line

rnk created this revision. rnk added reviewers: aaron.ballman, rjmccall, jdoerfert. Herald added a project: clang. After this change, clang spends ~200ms parsing Attrs.inc instead of ~560ms. A large part of the cost was from the StringSwitch instantiations, but this is a good way to avoid similar

[PATCH] D76039: [HIP] Let clang recognize .hip extension

yaxunl created this revision. yaxunl added a reviewer: tra. https://reviews.llvm.org/D76039 Files: clang/lib/Frontend/FrontendOptions.cpp clang/test/CodeGenCUDA/hip-pinned-shadow.cu clang/test/CodeGenCUDA/hip-pinned-shadow.hip clang/test/Driver/hip-autolink.hip clang/test/Driver/hip-def

[clang] 214d24e - [X86] Support intrinsic _mm_broadcastsi128_si256

Author: Shengchen Kan Date: 2020-03-12T10:56:39+08:00 New Revision: 214d24e1f8e0737a5aa2e2c52a1ae095fb1c1abd URL: https://github.com/llvm/llvm-project/commit/214d24e1f8e0737a5aa2e2c52a1ae095fb1c1abd DIFF: https://github.com/llvm/llvm-project/commit/214d24e1f8e0737a5aa2e2c52a1ae095fb1c1abd.diff

Re: [PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

On Wed, Mar 11, 2020 at 8:35 PM Arthur O'Dwyer via Phabricator < revi...@reviews.llvm.org> wrote: > Quuxplusone added inline comments. > > > > Comment at: clang-tools-extra/clang-tidy/bugprone/UnintendedADLCheck.h:27 > +class UnintendedADLCheck : public ClangTidyCheck { > + const

[PATCH] D76038: PR45000: Use Sema::SetParamDefaultArgument in TransformLambdaExpr

aaronpuchert created this revision. aaronpuchert added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. We have to properly initialize from the given initialization expression to make types match. Repository: rG LLVM Github Monorepo https://reviews.ll

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

Quuxplusone added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-unintended-adl.cpp:202 +void macro_test(T t) { +#define MACRO(x) find_if(x, x, x) + logan-5 wrote: > EricWF wrote: > > Arguably this is *exactly* the kind of code

[PATCH] D75573: [Sema][SVE] Reject aligned/_Alignas for sizeless types

efriedma added a comment. LGTM Technically, you could still do math on the address, and the difference would be visible. Granted, it's unlikely to matter in practice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75573/new/ https://reviews.llvm.o

[PATCH] D75736: [Sema][SVE] Don't allow static or thread-local variables to have sizeless type

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75736/new/ https://reviews.llvm.org/D75736 ___

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

logan-5 marked 2 inline comments as done. logan-5 added a comment. Thanks for the feedback. In D72282#1918253 , @EricWF wrote: > - This check should suggest fixes. It knows what function is actually being > resolved, and it has enough information to crea

[PATCH] D75737: [Sema][SVE] Don't allow fields to have sizeless type

efriedma added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1633 +if (RequireCompleteSizedType(Loc, FieldType, + diag::err_field_incomplete_or_sizeless)) { RD->setInvalidDecl(); Can BuildCaptureField actual

[PATCH] D75734: [Sema][SVE] Reject atomic sizeless types

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75734/new/ https://reviews.llvm.org/D75734 ___

[PATCH] D75571: [Sema][SVE] Add tests for valid and invalid type usage

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75571/new/ https://reviews.llvm.org/D75571 ___

[PATCH] D75738: [Sema][SVE] Reject by-copy capture of sizeless types

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75738/new/ https://reviews.llvm.org/D75738 ___

[clang] ab69cd0 - [X86] Support intrinsic _mm_cldemote

Author: Shengchen Kan Date: 2020-03-12T10:03:41+08:00 New Revision: ab69cd0779c529519eb7d26e0fa1b8dfb505f838 URL: https://github.com/llvm/llvm-project/commit/ab69cd0779c529519eb7d26e0fa1b8dfb505f838 DIFF: https://github.com/llvm/llvm-project/commit/ab69cd0779c529519eb7d26e0fa1b8dfb505f838.diff

[PATCH] D75896: [X86] Support intrinsic _mm_cldemote

This revision was automatically updated to reflect the committed changes. Closed by commit rGab69cd0779c5: [X86] Support intrinsic _mm_cldemote (authored by skan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75896/new/ https://reviews.llvm.org/D75

[PATCH] D75894: [X86] Support intrinsics _bextr2*

This revision was automatically updated to reflect the committed changes. Closed by commit rG560aa53f8fe5: [X86] Support intrinsics _bextr2* (authored by skan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75894/new/ https://reviews.llvm.org/D75894

[PATCH] D75690: [SVE][Inline-Asm] Add constraints for SVE ACLE types

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75690/new/ https://reviews.llvm.org/D75690 ___ cfe-commits mailing list cfe-commi

[clang] 560aa53 - [X86] Support intrinsics _bextr2*

Author: Shengchen Kan Date: 2020-03-12T09:26:51+08:00 New Revision: 560aa53f8fe58abcbc4bb441b631e8a401ee78fe URL: https://github.com/llvm/llvm-project/commit/560aa53f8fe58abcbc4bb441b631e8a401ee78fe DIFF: https://github.com/llvm/llvm-project/commit/560aa53f8fe58abcbc4bb441b631e8a401ee78fe.diff

[PATCH] D75298: [Clang][SVE] Parse builtin type string for scalable vectors

efriedma added a comment. Changing the way we expose the builtins isn't going to affect most of the code related to the SVE intrinsics. I'm fine sticking with a known working approach, and trying to address that issue later. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75298/new/ ht

[PATCH] D76037: [clang] tooling replacements are escaped when exporting to YAML

njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2, AlexanderLanin. Herald added a project: clang. Herald added a subscriber: cfe-commits. Escapes replacement text when exporting to yaml and unescapes when importing from yaml. Repository: rG LLVM Github Monore

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

apazos added a comment. Shiva, I am not sure how the SDataLimit is being honored in LTO mode. Where does getModuleMetadata get called? If the SelectSectionForGlobal api is called without getModuleMetadata being called first, it will use the default 8 instead of honoring the SDataLimit. Reposit

[PATCH] D75570: [AST][SVE] Add new Type queries for sizeless types

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75570/new/ https://reviews.llvm.org/D75570 ___

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

Quuxplusone added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnintendedADLCheck.h:27 +class UnintendedADLCheck : public ClangTidyCheck { + const bool IgnoreOverloadedOperators; + const std::vector AllowedIdentifiers; EricWF wrote: > I th

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

PaulkaToast updated this revision to Diff 249802. PaulkaToast added a comment. Mocked the header files so that we don't experience failures due to differences in systems. Mind taking a quick look @aaron.ballman? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[clang-tools-extra] d6497a5 - Add missing StringMap.h inclusion, apparently clangd is not covered by check-clang-tools zzz

Author: Reid Kleckner Date: 2020-03-11T16:47:49-07:00 New Revision: d6497a521bbd4024ed39a384b44af5f4f4a81e05 URL: https://github.com/llvm/llvm-project/commit/d6497a521bbd4024ed39a384b44af5f4f4a81e05 DIFF: https://github.com/llvm/llvm-project/commit/d6497a521bbd4024ed39a384b44af5f4f4a81e05.diff

[PATCH] D76032: [HIP] Fix duplicate clang -cc1 options on MSVC toolchain

tra added a reviewer: rnk. tra added a comment. LGTM, but I'm not familiar with the details of clang-cl. I've added Reid who'd have a better idea. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76032/new/ https://reviews.llvm.org/D76032 ___

[PATCH] D76030: [CUDA] Warn about unsupported CUDA SDK version only if it's used.

tra updated this revision to Diff 249792. tra added a comment. clang-formatted the changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76030/new/ https://reviews.llvm.org/D76030 Files: clang/lib/Driver/ToolChains/Cuda.cpp clang/lib/Driver/T

[clang] 8527c1e - Added constraints on cl-options.cu test

Author: Artem Belevich Date: 2020-03-11T16:06:09-07:00 New Revision: 8527c1ed66c63db0590cd69320ba0bf8fad59b87 URL: https://github.com/llvm/llvm-project/commit/8527c1ed66c63db0590cd69320ba0bf8fad59b87 DIFF: https://github.com/llvm/llvm-project/commit/8527c1ed66c63db0590cd69320ba0bf8fad59b87.diff

[Diffusion] rG825235c140e7: Revert "[Sema] Use the canonical type in function isVector"

ahatanak added a comment. Can we change the element type of the vector to `_Float16`? `typedef __attribute__((neon_vector_type(4))) _Float16 float16x4_t;` It seems that the original plan discussed on llvm-dev (http://lists.llvm.org/pipermail/cfe-dev/2017-May/053768.html) was to introduce `_Flo

[PATCH] D75560: Make Decl:: setOwningModuleID() public. (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b366e75d413: Make Decl::setOwningModuleID() public. (NFC) (authored by aprantl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

ldionne added a comment. In D73245#1918148 , @EricWF wrote: > I've already stated my disapproval of this patch. Libc++ has never and will > never provide nor value C++03 conformance. > Moving backwards to C++03 is inconsistent with the libraries general

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. - This check should suggest fixes. It knows what function is actually being resolved, and it has enough information to create a minimally qualified name that resolves it. - This ch

[clang] 2b366e7 - Make Decl::setOwningModuleID() public. (NFC)

Author: Adrian Prantl Date: 2020-03-11T15:50:03-07:00 New Revision: 2b366e75d41341e7cb2e763b20c4fc8fd3bd4b3c URL: https://github.com/llvm/llvm-project/commit/2b366e75d41341e7cb2e763b20c4fc8fd3bd4b3c DIFF: https://github.com/llvm/llvm-project/commit/2b366e75d41341e7cb2e763b20c4fc8fd3bd4b3c.diff

[clang] 213aea4 - Remove unused Endian.h includes, NFC

Author: Reid Kleckner Date: 2020-03-11T15:45:34-07:00 New Revision: 213aea4c5836934771eb97eb97e4c964053a8596 URL: https://github.com/llvm/llvm-project/commit/213aea4c5836934771eb97eb97e4c964053a8596 DIFF: https://github.com/llvm/llvm-project/commit/213aea4c5836934771eb97eb97e4c964053a8596.diff

[PATCH] D76030: [CUDA] Warn about unsupported CUDA SDK version only if it's used.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76030/new/ https://reviews.llvm.org/D76030 __

[PATCH] D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake

broadwaylamb updated this revision to Diff 249779. broadwaylamb added a comment. Add one more libc++abi header search path when building libc++ @vvereschaka this is supposed to fix the buildbot failure. It's more of a sweep under the rug type of fix. The real problem is that the value of the `C

[PATCH] D76032: [HIP] Fix duplicate clang -cc1 options on MSVC toolchain

yaxunl created this revision. yaxunl added a reviewer: tra. HIPToolChain::TranslateArgs call TranslateArgs of host toolchain with the input args to get a list of derived args called DAL, then go through the input args by itself and append them to DAL. This assumes that the host toolchain should

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

EricWF added a comment. I'll be picking this up seriously this week. I'm currently getting an internal version of this clang-tidy reviewed, and my plan was to submit it upstream after because I didn't see this patch until now (bad email filters). I think we can unify the two checks, Thanks for w

[PATCH] D76030: [CUDA] Warn about unsupported CUDA SDK version only if it's used.

tra updated this revision to Diff 249773. tra retitled this revision from "[CUDA] Warn about unsupported CUDA SDK version only if it's used. " to "[CUDA] Warn about unsupported CUDA SDK version only if it's used.". tra added a comment. Added a test. Repository: rG LLVM Github Monorepo C

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. I've already stated my disapproval of this patch. Libc++ has never and will never provide nor value C++03 conformance. Moving backwards to C++03 is inconsistent with the libraries gen

[PATCH] D73231: [CUDA] Assume the latest known CUDA version if we've found an unknown one.

tra added a comment. This patch should fix it: https://reviews.llvm.org/D76030 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73231/new/ https://reviews.llvm.org/D73231 ___ cfe-commits mailing list cfe-

[PATCH] D76030: [CUDA] Warn about unsupported CUDA SDK version only if it's used.

tra created this revision. tra added a reviewer: yaxunl. Herald added subscribers: sanjoy.google, bixia. Herald added a project: clang. tra updated this revision to Diff 249773. tra retitled this revision from "[CUDA] Warn about unsupported CUDA SDK version only if it's used. " to "[CUDA] Warn

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/5]

sconstab updated this revision to Diff 249765. sconstab added a comment. Added help text for the CLI options CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75936/new/ https://reviews.llvm.org/D75936 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Arch/X86.cp

[PATCH] D76029: Summary: Fix DanglingHandleCheck to match conversion operator whose return type is a type alias, e.g. `std::string`'s conversion operator to `std::string_view`.

zhangxy988 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. zhangxy988 added a reviewer: alexfh. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76029 Files: clang-tools-extra/clang-tidy/bugprone/DanglingHandleCheck.cpp clang-tools

[PATCH] D75934: Add Indirect Thunk Support to X86 to mitigate Load Value Injection (LVI) [2/5]

sconstab updated this revision to Diff 249763. sconstab added a comment. Added help text for driver CLI options. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75934/new/ https://reviews.llvm.org/D75934 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Arch/X8

[clang] 828fe79 - Revert "Temporarily re-apply https://reviews.llvm.org/D74347"

Author: Vladimir Vereschaka Date: 2020-03-11T15:00:56-07:00 New Revision: 828fe7916f91fb7aed5e711bfeb1a30ad197a2c3 URL: https://github.com/llvm/llvm-project/commit/828fe7916f91fb7aed5e711bfeb1a30ad197a2c3 DIFF: https://github.com/llvm/llvm-project/commit/828fe7916f91fb7aed5e711bfeb1a30ad197a2c3

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nickdesaulniers updated this revision to Diff 249760. nickdesaulniers added a comment. - drop `auto` as type is no longer implicit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75563/new/ https://reviews.llvm.org/D75563 Files: clang/docs/Release

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nickdesaulniers updated this revision to Diff 249754. nickdesaulniers marked 8 inline comments as done. nickdesaulniers added a comment. - address latest review comments, more refactoring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75563/new/ htt

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nickdesaulniers updated this revision to Diff 249757. nickdesaulniers added a comment. - remove isUnspecified(), was partially committed from refactoring I changed my mind on Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75563/new/ https://reviews

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nickdesaulniers added inline comments. Comment at: clang/lib/Parse/ParseStmtAsm.cpp:937 +case AQ_goto: return "goto"; +case AQ_unspecified:; + } aaron.ballman wrote: > This looks wrong to me -- it flows through to an unreachable despite being > reachabl

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

joerg added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73245/new/ https://reviews.llvm.org/D73245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D75406: Avoid including FileManager.h from SourceManager.h

This revision was automatically updated to reflect the committed changes. Closed by commit rGe08464fb4504: Avoid including FileManager.h from SourceManager.h (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D75406?vs=247479&id=249752#toc Repository: rG LLVM Github Monorep

[PATCH] D75310: [CUDA, clang-cl] Filter out unsupported arguments for device-side compilation.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c06a389e593: [CUDA,clang-cl] Filter out unsupported arguments for device-side compilation. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D75784: Avoid including Module.h from ExternalASTSource.h

This revision was automatically updated to reflect the committed changes. rnk marked an inline comment as done. Closed by commit rGc915cb957dc3: Avoid including Module.h from ExternalASTSource.h (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D75784: Avoid including Module.h from ExternalASTSource.h

rnk added a comment. Thanks! In D75784#1917181 , @aprantl wrote: > To avoid bot breakage, I would recommend testing -DLLVM_ENABLE_MODULES=1 > stage2 build works before landing this, as it is notoriously sensitive to > header reshuffling. Good idea, I

[PATCH] D75998: [ARM,MVE] Add intrinsics and isel for MVE fused multiply-add.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. LGTM. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75998/new/ https://reviews.llvm.org/D75998 _

[clang] e08464f - Avoid including FileManager.h from SourceManager.h

Author: Reid Kleckner Date: 2020-03-11T13:53:12-07:00 New Revision: e08464fb450456881733c885267b32dc7339cf11 URL: https://github.com/llvm/llvm-project/commit/e08464fb450456881733c885267b32dc7339cf11 DIFF: https://github.com/llvm/llvm-project/commit/e08464fb450456881733c885267b32dc7339cf11.diff

[clang] 526a4f2 - Fix formatting after Module.h include adjustment, NFC

Author: Reid Kleckner Date: 2020-03-11T13:52:47-07:00 New Revision: 526a4f2ac365a5babbc80e0f7c17be310728a538 URL: https://github.com/llvm/llvm-project/commit/526a4f2ac365a5babbc80e0f7c17be310728a538 DIFF: https://github.com/llvm/llvm-project/commit/526a4f2ac365a5babbc80e0f7c17be310728a538.diff

[clang] 0c06a38 - [CUDA,clang-cl] Filter out unsupported arguments for device-side compilation.

Author: Artem Belevich Date: 2020-03-11T13:42:16-07:00 New Revision: 0c06a389e5937895579effd5e608c79bc6332e53 URL: https://github.com/llvm/llvm-project/commit/0c06a389e5937895579effd5e608c79bc6332e53 DIFF: https://github.com/llvm/llvm-project/commit/0c06a389e5937895579effd5e608c79bc6332e53.diff

[clang] c915cb9 - Avoid including Module.h from ExternalASTSource.h

Author: Reid Kleckner Date: 2020-03-11T13:37:41-07:00 New Revision: c915cb957dc37275ce1ca1a0b993239c82f12692 URL: https://github.com/llvm/llvm-project/commit/c915cb957dc37275ce1ca1a0b993239c82f12692 DIFF: https://github.com/llvm/llvm-project/commit/c915cb957dc37275ce1ca1a0b993239c82f12692.diff

[PATCH] D71219: Fix conflict value for metadata "Objective-C Garbage Collection" in the mix of swift and Objective-C bitcode

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0cacb60549f: Fix conflict value for metadata "Objective-C Garbage Collection" in the mix of… (authored by jinlin). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

mitchell-stellar reopened this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. Reverted this commit due to an unexpected test failure: TEST 'Clang :: Format/dump-config-objc.h' FAILED Script: -- : 'RUN

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

tejohnson added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75655/new/ https://reviews.llvm.org/D75655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 added a comment. In D75791#1917837 , @MyDeveloperDay wrote: > your patch seems to be missing the other files Which other files? I made a new commit and did the full context diff, now sure why it's only showing the documentation update.

[PATCH] D74386: [SVE] Update API ConstantVector::getSplat() to use ElementCount.

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:4497 Value *CodeGenFunction::EmitNeonSplat(Value *V, Constant *C) { - unsigned nElts = V->getType()->getVectorNumElements(); - Value* SV = llvm::ConstantVector::getSplat(nElts, C); + auto EC = V->getT

[clang] a0cacb6 - Fix conflict value for metadata "Objective-C Garbage Collection" in the mix of swift and Objective-C bitcode

Author: Jin Lin Date: 2020-03-11T13:26:06-07:00 New Revision: a0cacb60549f2346f7addf9205cd32720afc8fb4 URL: https://github.com/llvm/llvm-project/commit/a0cacb60549f2346f7addf9205cd32720afc8fb4 DIFF: https://github.com/llvm/llvm-project/commit/a0cacb60549f2346f7addf9205cd32720afc8fb4.diff LOG:

[clang] c5c487f - Revert "[clang-format] Add option to specify explicit config file"

Author: Mitchell Balan Date: 2020-03-11T16:14:42-04:00 New Revision: c5c487f0d4c6720f4384f670490086e723f5fe32 URL: https://github.com/llvm/llvm-project/commit/c5c487f0d4c6720f4384f670490086e723f5fe32 DIFF: https://github.com/llvm/llvm-project/commit/c5c487f0d4c6720f4384f670490086e723f5fe32.diff

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

This revision was automatically updated to reflect the committed changes. Closed by commit rG10b1a87ba35d: [clang-format] Add option to specify explicit config file Summary: This diff… (authored by mitchell-stellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

wristow added a comment. Revisiting this patch. I think that before fixing the `-ffp-contract=off` problem I originally raised here, there are two questions that have come up in this discussion that we should first resolve. Specifically: (1) Do we want to enable FMA transformations by defaul

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

apazos added a comment. Shiva, I see a warning always being printed: '+small-data-limit=' is not a recognized feature for this target (ignoring feature) This is because it is being passed down as a target feature. Might be good to add a test case to make sure the SmallDataLimit module flag is

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added a comment. your patch seems to be missing the other files CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] 10b1a87 - [clang-format] Add option to specify explicit config file

Author: Mitchell Balan Date: 2020-03-11T15:56:44-04:00 New Revision: 10b1a87ba35d386b718f0e83c1d750631705b220 URL: https://github.com/llvm/llvm-project/commit/10b1a87ba35d386b718f0e83c1d750631705b220 DIFF: https://github.com/llvm/llvm-project/commit/10b1a87ba35d386b718f0e83c1d750631705b220.diff

[PATCH] D76015: [clang-tidy] Mock system headers for portability-restrict-system-includes tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf1736f7a2a66: [clang-tidy] Mock system headers for portability-restrict-system-includes tests. (authored by PaulkaToast). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 249717. oontvoo added a comment. Wrong name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/Preprocessor.h clang/lib/Lex/HeaderSearch

[clang-tools-extra] f1736f7 - [clang-tidy] Mock system headers for portability-restrict-system-includes tests.

Author: Paula Toth Date: 2020-03-11T12:13:27-07:00 New Revision: f1736f7a2a660944c24aac45e24cdf1ea6c6effa URL: https://github.com/llvm/llvm-project/commit/f1736f7a2a660944c24aac45e24cdf1ea6c6effa DIFF: https://github.com/llvm/llvm-project/commit/f1736f7a2a660944c24aac45e24cdf1ea6c6effa.diff LO

[PATCH] D75569: [clang-tidy] New check for methods marked __attribute__((unavailable)) that do not override a method from a superclass.

mwyman marked 3 inline comments as done. mwyman added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/MethodUnavailableNotOverrideCheck.cpp:34 +// Matches Objective-C methods that are not overriding a superclass method. +AST_MATCHER(ObjCMethodDecl, isNotOverriding

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 249712. oontvoo added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/Preprocessor.h clang/lib/Lex/HeaderSearch.cpp

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 249711. oontvoo added a comment. More typo correction Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/Preprocessor.h clang/lib/Lex/He

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 249708. oontvoo added a comment. Updated typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/Preprocessor.h clang/lib/Lex/HeaderSear

[PATCH] D75569: [clang-tidy] New check for methods marked __attribute__((unavailable)) that do not override a method from a superclass.

mwyman updated this revision to Diff 249709. mwyman marked 5 inline comments as done. mwyman added a comment. After some discussion, have decided to remove the fix-it entirely and update the diagnostic message; removing the method altogether may not be the correct behavior, as previously depreca

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/clang-tidy/llvmlibc/RestrictSystemLibcHeadersCheck.cpp:66-67 +const SourceManager &SM, Preprocessor *PP, Preprocessor *

[PATCH] D74813: [RFC] Add hash of block contents to function block names

manmanren added a comment. There are a few concerns about the approach: 1> Compile time: dumping AST as string then hashing the string. Alex measured it on a synthetic benchmark, it shows insignificant impact. 2> Stability: from my understanding, the main goal of this patch is to increase stabil

[clang] 0197eac - Temporarily re-apply https://reviews.llvm.org/D74347

Author: Sergej Jaskiewicz Date: 2020-03-11T21:35:14+03:00 New Revision: 0197eac3330c04a49519f3e4dac38c4de605c654 URL: https://github.com/llvm/llvm-project/commit/0197eac3330c04a49519f3e4dac38c4de605c654 DIFF: https://github.com/llvm/llvm-project/commit/0197eac3330c04a49519f3e4dac38c4de605c654.d

RE: [PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

Sorry I don't understand. I have to add "final" onto BinaryOperator in order to use Trailing storage. But when I do that I can't derive CompoundAssignmentOperator from BinaryOperator. So I think I must fold these 2 classes together. Is there another way? > -Original Message- > From: Jo

[PATCH] D76015: [clang-tidy] Mock system headers for portability-restrict-system-includes tests.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76015/new/ https://reviews.llvm.org/D76015

  1   2   3   >