[PATCH] D75010: [OpenMP] Adding InaccessibleMemOnly and InaccessibleMemOrArgMemOnly for runtime calls.

jdoerfert added a comment. I always thought there was a test for this, turns out I never committed it. Since I did now (1c9c23d60ea7656174ad3d76293c2a90dd25e24f ) you need to rebase and adjust it, sorry. Com

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

logan-5 updated this revision to Diff 250130. logan-5 marked 3 inline comments as done. logan-5 added a comment. The check now suggests fixes for concrete (i.e. non-template) uses of ADL. Re-enabled the check for macros, and eliminated some false positives with arrays of dependent size. The chec

[Diffusion] rG825235c140e7: Revert "[Sema] Use the canonical type in function isVector"

ahatanak added a comment. In rG825235c140e7747f686bd7902cb0f9af77590841#909794 , @SjoerdMeijer wrote: > > I'm still not sure why __fp16, which is a storage-only type, is used for > > the element type of float16x4_t if

[PATCH] D76100: Debug Info: Store the SDK in the DICompileUnit.

JDevlieghere added a comment. Looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76100/new/ https://reviews.llvm.org/D76100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

shiva0217 added a comment. In D57497#1920097 , @apazos wrote: > Thanks Shiva, I res-ynced and rebuilt the patch. It is working fine. > > I see there is a msmall-data-threshold flag used by Mips and Hexagon, and now > we are adding a new flag msmall-data-l

[PATCH] D75169: [ARM] Enforcing calling convention for half-precision FP arguments and returns for big-endian AArch32

lattner resigned from this revision. lattner added a comment. I'm not a qualified reviewer for this at this point. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75169/new/ https://reviews.llvm.org/D75169 _

[PATCH] D75723: [X86] Enable intrinsics _BitScan*

skan abandoned this revision. skan added a comment. Reconsidered the advice of @rnk , we can use `-fms-extensions` to supported _BitScan* on linux. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75723/new/ https://reviews.llvm.org/D75723 ___

[PATCH] D76099: [Clang][Driver] In -fintegrated-cc1 mode, avoid crashing on exit after a compiler crash

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm The timer linked list is an interesting complication. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76099/new/ https://reviews.llvm.org/D76099

[libunwind] 3758b85 - Only run frameheader_cache_test.pass.cpp on x86_64.

Author: Sterling Augustine Date: 2020-03-12T18:14:22-07:00 New Revision: 3758b858ef3b39b3081bf9a567ead8bc69c9a208 URL: https://github.com/llvm/llvm-project/commit/3758b858ef3b39b3081bf9a567ead8bc69c9a208 DIFF: https://github.com/llvm/llvm-project/commit/3758b858ef3b39b3081bf9a567ead8bc69c9a208.

[PATCH] D75529: [analyzer] Limit UCharMax to min of max uchar or max int

vabridgers marked 6 inline comments as done. vabridgers added a comment. I believe all comments have been addressed. Please let me know if there's anything else required. Thanks Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:519 + // architecture

[PATCH] D75529: [analyzer] Limit UCharMax to min of max uchar or max int

vabridgers updated this revision to Diff 250109. vabridgers marked 2 inline comments as not done. vabridgers added a comment. fix pre merge checkswq Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75529/new/ https://reviews.llvm.org/D75529 Files:

[PATCH] D35732: Update system_error tests for more platforms.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa9740ff1585a: Update system_error tests for more platforms. (authored by danalbert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D35732/new/ https://review

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

fghanim added a comment. Done with `private` `firstprivate` `copyin` - working on modifying the clang test, and fixing some bugs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 _

[PATCH] D75911: [clang-tidy] Added hasAnyListedName matcher

alexfh added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/Matchers.h:53-55 +ast_matchers::internal::Matcher +hasAnyListedName(std::vector Names); + We could change all checks to use the other overload and drop this one (and the utils::options:

[PATCH] D76096: [clang] allow const structs to be constant expressions in initializer lists

efriedma added a comment. I think the code that disables constant evaluation for C is just https://github.com/llvm/llvm-project/blob/dcaf13a4048df3dad55f1a28cde7cefc99ccc057/clang/lib/AST/ExprConstant.cpp#L13918 and https://github.com/llvm/llvm-project/blob/dcaf13a4048df3dad55f1a28cde7cefc99ccc

[PATCH] D76096: [clang] allow const structs to be constant expressions in initializer lists

efriedma added inline comments. Comment at: clang/lib/AST/Expr.cpp:3164 + const QualType &QT = cast(this)->getDecl()->getType(); + if (QT->isStructureType() && QT.isConstQualified()) +return true; nickdesaulniers wrote: > efriedma wrote: > > nic

[clang] 461566b - Add a test triple to avoid failure under MS ABI.

Author: Richard Smith Date: 2020-03-12T16:44:09-07:00 New Revision: 461566b0465c57793c70b0daff87f071d9e5906a URL: https://github.com/llvm/llvm-project/commit/461566b0465c57793c70b0daff87f071d9e5906a DIFF: https://github.com/llvm/llvm-project/commit/461566b0465c57793c70b0daff87f071d9e5906a.diff

[PATCH] D76103: [clangd] Extend findTarget()'s dependent name heuristic to handle enumerators

sammccall added a comment. Thanks! Just a couple of Qs... Comment at: clang-tools-extra/clangd/FindTarget.cpp:105 + if (auto *ET = T->getAs()) { +LookupInDecl = ET->getDecl(); + } else { Is this the bit that "breaks" the dependence? getDecl() works even i

[PATCH] D76083: [clang-tidy] Expand the list of functions in bugprone-unused-return-value

njames93 added a comment. Please upload diffs with full context. If you are using `git diff` to generate the patch, pass the flag `-U99` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76083/new/ https://reviews.llvm.org/D76083 __

[PATCH] D76096: [clang] allow const structs to be constant expressions in initializer lists

nickdesaulniers marked an inline comment as done and an inline comment as not done. nickdesaulniers added a comment. In D76096#1920477 , @efriedma wrote: > But that's probably a larger project than you really want to mess with. Maybe with some coaching;

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

ldionne added inline comments. Comment at: libcxx/include/new:240 return __align > __STDCPP_DEFAULT_NEW_ALIGNMENT__; +#elif defined(_LIBCPP_CXX03_LANG) + return __align > alignment_of<__libcpp_max_align_t>::value; So, IIUC what you're saying, `__STDCPP_DEFAUL

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

This revision was automatically updated to reflect the committed changes. Closed by commit rG246398ece711: [clang][Parse] properly parse asm-qualifiers, asm inline (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75563/new

[PATCH] D76086: [Sema][SVE] Reject arithmetic on pointers to sizeless types

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM People are going to want to iterate over arrays in memory to write simple intrinsic loops. If we don't allow `p + i` to work, people will be forced to write `(__SVInt8_t*)((char*)p

[PATCH] D76037: [clang] tooling replacements are escaped when exporting to YAML

AlexanderLanin added a comment. Fine for me. Fixes newline bug in https://bugs.llvm.org/show_bug.cgi?id=45150. However I don't have "review privileges" here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76037/new/ https://reviews.llvm.org/D76037

[PATCH] D76054: [clang-apply-replacements] No longer deduplucates replacements from the same TU

AlexanderLanin added a comment. Unfortunately I cannot say whether the code is good, but the fix works and certainly helps readability-braces-around-statements which can sometimes add multiple } at the same offset to close several scopes. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D76087: [Sema][SVE] Reject sizeless types in exception specs

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM In theory, we actually could allow throwing sizeless types; as far as I know, nothing in the ABI actually blocks it. But probably not worth the work to implement it. Repository:

[PATCH] D76103: [clangd] Extend findTarget()'s dependent name heuristic to handle enumerators

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76103 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tool

[PATCH] D76088: [Sema][SVE] Don't allow sizeless objects to be thrown

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76088/new/ https://reviews.llvm.org/D76088 ___

[clang] 246398e - [clang][Parse] properly parse asm-qualifiers, asm inline

Author: Nick Desaulniers Date: 2020-03-12T15:13:59-07:00 New Revision: 246398ece7115b57a02dbe7876d86ae8e72406ef URL: https://github.com/llvm/llvm-project/commit/246398ece7115b57a02dbe7876d86ae8e72406ef DIFF: https://github.com/llvm/llvm-project/commit/246398ece7115b57a02dbe7876d86ae8e72406ef.di

[PATCH] D76096: [clang] allow const structs to be constant expressions in initializer lists

efriedma added a comment. I would like to kill off all the code you're modifying, and let ExprConstant be the final arbiter of whether a constant is in fact constant. But that's probably a larger project than you really want to mess with. The big missing piece of that is that we currently don

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

rnk added a comment. I believe folks are in agreement about this direction, but I'm waiting for someone to mark the revision accepted. Let me know if that's not the case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65543/new/ https://reviews.llv

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

rnk updated this revision to Diff 250068. rnk added a comment. - rebase, ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65543/new/ https://reviews.llvm.org/D65543 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Driver/ToolChain.h

[PATCH] D76083: [clang-tidy] Expand the list of functions in bugprone-unused-return-value

alexfh added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp:57 + "::std::map::lower_bound;" + "::std::move;" + "::std::multimap::eq

[PATCH] D76088: [Sema][SVE] Don't allow sizeless objects to be thrown

rsandifo-arm added a comment. In D76088#1920241 , @efriedma wrote: > We already have a special case for void* here; it's trivial to extend that to > also check for sizeless types. I don't want to add weird semantic > restrictions just to save a few chara

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

andrew.w.kaylor added a comment. In D72675#1920309 , @lebedev.ri wrote: > I may be wrong, but i suspect those failures aren't actually due to the fact > that we pessimize optimizations with this change, but that the whole > execution > just fails. Can y

[PATCH] D76088: [Sema][SVE] Don't allow sizeless objects to be thrown

rsandifo-arm updated this revision to Diff 250066. rsandifo-arm added a comment. Allow pointers to sizeless types to be thrown. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76088/new/ https://reviews.llvm.org/D76088 Files: clang/include/clang/B

[PATCH] D76087: [Sema][SVE] Reject sizeless types in exception specs

rsandifo-arm updated this revision to Diff 250062. rsandifo-arm added a comment. Allow pointers to sizeless types to be thrown. In response to Eli's comments in D76088 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D75901: [clang-tidy] misc-unconventional-assign-operator suggest to use rvalue references in C++03 mode

njames93 added a comment. In D75901#1916119 , @tetsuo-cpp wrote: > @njames93 @MaskRay > Thanks for helping me with testing. I'll remember this for next time. > > I also saw this pattern of retrieving `LangOptions` from an `ASTContext` in > some other ch

[PATCH] D76100: Debug Info: Store the SDK in the DICompileUnit.

aprantl created this revision. aprantl added reviewers: davide, shafik, teemperor, JDevlieghere. aprantl added a project: debug-info. Herald added a subscriber: ormris. This is another intermediate step for PR44213 (https://bugs.llvm.org/show_bug.cgi?id=44213). This stores the SDK *name*

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75563/new/ https://reviews.llvm.org/D75563 ___ cfe-commits mailing list cfe-comm

[PATCH] D72872: [ObjC generics] Fix not inheriting type bounds in categories/extensions.

vsapsai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72872/new/ https://reviews.llvm.org/D72872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D76099: [Clang][Driver] In -fintegrated-cc1 mode, avoid crashing on exit after a compiler crash

aganea created this revision. aganea added reviewers: rnk, hans, hubert.reinterpretcast, daltenty. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. As reported here: https://reviews.llvm.org/D69825#1916865 and in PR45164, in case of a compiler cr

[PATCH] D70265: [clang-tidy] Add CppCoreGuidelines I.2 "Avoid non-const global variables" check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Do you need someone to commit on your behalf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70265/new/ https://reviews.llvm.

[PATCH] D76098: [WIP] [clangd] Do not trigger go-to-def textual fallback inside string literals

nridge added a comment. This is my attempt to avoid triggering the textual fallback for string literals, as per the discussion in the issue . To classify tokens into the categories discussed in the issue, I resurrected and modified the `getTokenFlav

[PATCH] D76054: [clang-apply-replacements] No longer deduplucates replacements from the same TU

njames93 updated this revision to Diff 250054. njames93 added a comment. - Added test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76054/new/ https://reviews.llvm.org/D76054 Files: clang-tools-extra/clang-apply-replacements/lib/Tooling/Ap

[PATCH] D75542: [Sema] Prevent UB for uninitialized `IsSurrogate`

aaron.ballman added a comment. Sorry for the delay in review, but I believe this was already fixed in the meantime: https://github.com/llvm/llvm-project/commit/a5704f92b835d1810d83a223f70dfe6c92a34c03 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake

vvereschaka added a comment. LGTM I was able to build with these changes successfully on the local builder host. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74347/new/ https://reviews.llvm.org/D74347 ___

[PATCH] D76037: [clang] tooling replacements are escaped when exporting to YAML

njames93 updated this revision to Diff 250053. njames93 marked 6 inline comments as done. njames93 added a comment. - Extend tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76037/new/ https://reviews.llvm.org/D76037 Files: clang-tools-extra/

[PATCH] D76037: [clang] tooling replacements are escaped when exporting to YAML

njames93 added inline comments. Comment at: clang/lib/Tooling/ReplacementsYaml.cpp:22 +static constexpr Escapes EscapeChars[] = { +{'\n', 'n'}, {'\r', 'r'}, {'\t', 't'}, {'\\', '\\'}}; + AlexanderLanin wrote: > Just so I have asked ;-) > Escaping every \ woul

[PATCH] D76098: [WIP] [clangd] Do not trigger go-to-def textual fallback inside string literals

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76098 Files: clang-tools-extr

[PATCH] D74361: [Clang] Undef attribute for global variables

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from the diagnostic wording, I think this LG to me. However, I'd appreciate if @rjmccall would also sign off. Comment at: clang/include/clang/Basic/Diagn

[PATCH] D76097: improve performance of getSDKName()

aprantl created this revision. aprantl added a reviewer: arphaman. Herald added a subscriber: dexonsmith. The ".sdk" component is usually the last one in the -isysroot, so it makes more sense to scan from the back. Also, technically, someone could install Xcode into a directory ending with .sdk,

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

lebedev.ri added a comment. I may be wrong, but i suspect those failures aren't actually due to the fact that we pessimize optimizations with this change, but that the whole execution just fails. Can you try running test-suite locally? Do tests themselves actually pass, ignoring the question of t

[PATCH] D76096: [clang] allow const structs to be constant expressions in initializer lists

nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: clang/lib/AST/Expr.cpp:3164 + const QualType &QT = cast(this)->getDecl()->getType(); + if (QT->isStructureType() && QT.isConstQualified()) +return true;

[PATCH] D76096: [clang] allow const structs to be constant expressions in initializer lists

nickdesaulniers updated this revision to Diff 250046. nickdesaulniers added a comment. - add 2 missing CHECKs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76096/new/ https://reviews.llvm.org/D76096 Files: clang/lib/AST/Expr.cpp clang/lib/Code

[PATCH] D76096: [clang] allow const structs to be constant expressions in initializer lists

nickdesaulniers marked an inline comment as not done. nickdesaulniers added inline comments. Comment at: clang/lib/AST/Expr.cpp:3164 + const QualType &QT = cast(this)->getDecl()->getType(); + if (QT->isStructureType() && QT.isConstQualified()) +return true;

[PATCH] D76096: [clang] allow const structs to be constant expressions in initializer lists

nickdesaulniers created this revision. nickdesaulniers added reviewers: eli.friedman, aaron.ballman, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. nickdesaulniers updated this revision to Diff 250046. nickdesaulniers added a comment. nickdesaulniers marked an inline

[PATCH] D72874: [clangd] Add a textual fallback for go-to-definition

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc4cd43904df: [clangd] Add a textual fallback for go-to-definition (authored by sammccall, committed by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D74386: [SVE] Update API ConstantVector::getSplat() to use ElementCount.

This revision was automatically updated to reflect the committed changes. Closed by commit rG118abf201738: [SVE] Update API ConstantVector::getSplat() to use ElementCount. (authored by huihuiz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74386/new

[PATCH] D76076: [HIP] Mark kernels with uniform-work-group-size=true

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76076/new/ https://reviews.llvm.org/D76076 ___ cfe-commits mailing list cfe-commi

[PATCH] D76037: [clang] tooling replacements are escaped when exporting to YAML

njames93 updated this revision to Diff 250038. njames93 added a comment. - Fix another broken dependency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76037/new/ https://reviews.llvm.org/D76037 Files: clang-tools-extra/clang-apply-replacements/C

[PATCH] D75788: [WIP][OpenMP] Reuse CUDA wrappers in `nvptx` target regions.

jdoerfert marked 3 inline comments as done. jdoerfert added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:1621 case BuiltinType::LongDouble: -if (getLangOpts().OpenMP && getLangOpts().OpenMPIsDevice) return AuxTarget->getLongDoubleFormat(); -

[PATCH] D76086: [Sema][SVE] Reject arithmetic on pointers to sizeless types

rsandifo-arm added a comment. In D76086#1920096 , @efriedma wrote: > Do we really want to forbid this? The expected semantics are clear, and the > obvious lowering to getelementptr just works. The problem is that pointer arithmetic is really a form of

[PATCH] D76088: [Sema][SVE] Don't allow sizeless objects to be thrown

efriedma added a comment. We already have a special case for void* here; it's trivial to extend that to also check for sizeless types. I don't want to add weird semantic restrictions just to save a few characters in the compiler. I agree that most people won't run into it either way. Reposito

[PATCH] D72874: [clangd] Add a textual fallback for go-to-definition

nridge added a comment. (Also just to clarify: while I said on Discord that I already implemented exclusion of string literals, I actually ended up deferring that part to a follow-up because it wasn't working as I expected.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[clang-tools-extra] dc4cd43 - [clangd] Add a textual fallback for go-to-definition

Author: Sam McCall Date: 2020-03-12T16:33:08-04:00 New Revision: dc4cd43904df92565dbacaa501db98eb9683551b URL: https://github.com/llvm/llvm-project/commit/dc4cd43904df92565dbacaa501db98eb9683551b DIFF: https://github.com/llvm/llvm-project/commit/dc4cd43904df92565dbacaa501db98eb9683551b.diff LO

[clang] 118abf2 - [SVE] Update API ConstantVector::getSplat() to use ElementCount.

Author: Huihui Zhang Date: 2020-03-12T13:22:41-07:00 New Revision: 118abf20173899e9e1667db1a9c850dc5570b6ae URL: https://github.com/llvm/llvm-project/commit/118abf20173899e9e1667db1a9c850dc5570b6ae DIFF: https://github.com/llvm/llvm-project/commit/118abf20173899e9e1667db1a9c850dc5570b6ae.diff

[clang] 9975dc3 - Defer checking for mismatches between the deletedness of and overriding

Author: Richard Smith Date: 2020-03-12T13:07:22-07:00 New Revision: 9975dc38bf734b4d86eab61269080ca231379d23 URL: https://github.com/llvm/llvm-project/commit/9975dc38bf734b4d86eab61269080ca231379d23 DIFF: https://github.com/llvm/llvm-project/commit/9975dc38bf734b4d86eab61269080ca231379d23.diff

Re: [clang] d052a57 - [c++2a] Allow comparison functions to be explicitly defaulted.

I believe the case you're describing is one like this: struct A { virtual void f() = delete; }; template struct B : A { virtual void f() = delete; }; B b; Fixed in llvmorg-11-init-5618-g9975dc38bf7. On Tue, 10 Mar 2020 at 18:01, Hubert Tong via cfe-commits < cfe-commits@lists.llvm.org> wrote: >

[PATCH] D75298: [Clang][SVE] Parse builtin type string for scalable vectors

efriedma added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:86 + OS << "#ifndef __cplusplus\n"; + OS << "#include \n"; + OS << "#endif\n\n"; I'd prefer to avoid depending on stdbool if it isn't necessary. Comment at: cla

[PATCH] D74541: [Analyzer] Use note tags to track iterator increments and decrements

baloghadamsoftware marked 4 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:519-520 +const NoteTag *IteratorModeling::getChangeTag(CheckerContext &C, StringRef Text, +

[PATCH] D75788: [WIP][OpenMP] Reuse CUDA wrappers in `nvptx` target regions.

jdoerfert updated this revision to Diff 250035. jdoerfert marked an inline comment as done. jdoerfert added a comment. Adjust to new scheme, tested locally with some math functions, seems to work Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75788/n

[PATCH] D76079: [Hexagon] Enable init_arrays when target is linux-musl

This revision was automatically updated to reflect the committed changes. Closed by commit rG6174fddbe3d4: [Hexagon] Enable init_arrays when target is linux-musl (authored by sidneym). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76079/new/ https:/

[PATCH] D72874: [clangd] Add a textual fallback for go-to-definition

nridge added a comment. I should mention that in my local usage, I've found the restriction on no more than 3 results (even if they're not in the current file) to be somewhat limiting. For example, a comment can easily reference the name of a function which has more than 3 overloads. But we ca

[PATCH] D75210: [Attr] Allow ParsedAttr to be constructor for any Attribute

jdoerfert planned changes to this revision. jdoerfert added a comment. The reason for this patch is not there anymore. I'm fine with postponing this patch until there is a user again, thoughts? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75210/ne

[PATCH] D72874: [clangd] Add a textual fallback for go-to-definition

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:436 +if (ScoredResults.size() >= 3) { + // Assume we don't have results from the current file, otherwise the + // findNearbyIdentifier() mechanism w

[PATCH] D72874: [clangd] Add a textual fallback for go-to-definition

nridge updated this revision to Diff 250031. nridge added a comment. Tweak a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72874/new/ https://reviews.llvm.org/D72874 Files: clang-tools-extra/clangd/FindSymbols.cpp clang-tools-extra/cla

[PATCH] D76088: [Sema][SVE] Don't allow sizeless objects to be thrown

rsandifo-arm added a comment. In D76088#1920070 , @efriedma wrote: > Why is throwing an `svint8_t *` an error? I don't see any obvious reason to > forbid that. Yeah, I agree there's no obvious reason why it wouldn't work. The same reasoning applies h

[PATCH] D76078: [AArch64][SVE] Add a pass for SVE intrinsic optimisations

efriedma added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64TargetMachine.cpp:441 + // Expand any SVE vector library calls that we can't code generate directly. + bool ExpandToOptimize = (TM->getOptLevel() != CodeGenOpt::None); + if (EnableSVEIntrinsicOpts && TM

[PATCH] D76094: [clangd] Change line break behaviour for hoverinfo

lolleko created this revision. lolleko added a reviewer: sammccall. lolleko added a project: clang. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. `convertLineBreaks` retains hard line breaks and removes soft line breaks. Wether a line break

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

mibintc added a comment. @David.Bolvansky told me “https://lnt.llvm.org/ -> Test suite nts -> watch for > LNT-Broadwell-AVX2-O3__clang_PROD__x86_64:1364” The fails were seen on aarch too and a couple other arch. AFAIK the old results are no longer availble. i scraped the list of fails, pastin

[clang] 6174fdd - [Hexagon] Enable init_arrays when target is linux-musl

Author: Sid Manning Date: 2020-03-12T15:00:15-05:00 New Revision: 6174fddbe3d40972d97f63d9bf6bb1c4236de0e3 URL: https://github.com/llvm/llvm-project/commit/6174fddbe3d40972d97f63d9bf6bb1c4236de0e3 DIFF: https://github.com/llvm/llvm-project/commit/6174fddbe3d40972d97f63d9bf6bb1c4236de0e3.diff L

[PATCH] D73521: [analyzer] add-new-checker.py: Introduction

Charusso marked an inline comment as done. Charusso added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:24 def CoreBuiltin : Package<"builtin">, ParentPackage, Hidden; -def CoreUninitialized : Package<"uninitialized">, ParentPackage; +def

[PATCH] D75737: [Sema][SVE] Don't allow fields to have sizeless type

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Sema/SemaLambda.cpp:1633 +if (RequireCompleteSizedType(Loc, FieldType, + diag::err_field_incomplete_or_size

[PATCH] D74386: [SVE] Update API ConstantVector::getSplat() to use ElementCount.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74386/new/ https://reviews.llvm.org/D74386 ___

[PATCH] D73521: [analyzer] add-new-checker.py: Introduction

Charusso updated this revision to Diff 250020. Charusso marked 3 inline comments as done. Charusso retitled this revision from "[analyzer][WIP] add-new-checker.py: Introduction" to "[analyzer] add-new-checker.py: Introduction". Charusso added a comment. Herald added a subscriber: mgorny. - Try to

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

joerg added a comment. In D73245#1918287 , @ldionne wrote: > In D73245#1918148 , @EricWF wrote: > > > I've already stated my disapproval of this patch. Libc++ has never and will > > never provide nor value C++03 co

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

apazos added a comment. Thanks Shiva, I res-ynced and rebuilt the patch. It is working fine. I see there is a msmall-data-threshold flag used by Mips and Hexagon, and now we are adding a new flag msmall-data-limit. Should't we reuse the flag? Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D76084: [Sema][SVE] Reject subscripts on pointers to sizeless types

efriedma added a comment. I'm not sure we actually want to reject this; let's discuss on the review for D76086 , since subscripting is sort of a special case of arithmetic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D76061: [Sema] Fix location of star ('*') inside MemberPointerTypeLoc

hlopko updated this revision to Diff 250024. hlopko added a comment. Herald added a subscriber: mgorny. [Sema] Fix location of star ('*') inside MemberPointerTypeLoc Copy of https://reviews.llvm.org/D72073?id=235842, submitting with ilya-biryukov's permission. Repository: rG LLVM Github Mono

[PATCH] D72874: [clangd] Add a textual fallback for go-to-definition

nridge marked 2 inline comments as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:436 +if (ScoredResults.size() >= 3) { + // Assume we don't have results from the current file, otherwise the + // findNearbyIdentifier() mechanism w

[PATCH] D76086: [Sema][SVE] Reject arithmetic on pointers to sizeless types

efriedma added a comment. Do we really want to forbid this? The expected semantics are clear, and the obvious lowering to getelementptr just works. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76086/new/ https://reviews.llvm.org/D76086 __

[PATCH] D76082: [Sema][SVE] Reject arrays of sizeless types

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. It might be reasonable to support this at some point, but sure, I'm fine rejecting it for now. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D72874: [clangd] Add a textual fallback for go-to-definition

nridge updated this revision to Diff 250018. nridge marked 9 inline comments as done. nridge added a comment. Herald added a subscriber: mgrang. - Remove fuzzy matching - Rebase to apply to head, taking only the parts from D75479 that I need for index-based looku

[PATCH] D76090: [Sema][SVE] Don't allow sizeless types to be caught

rsandifo-arm created this revision. rsandifo-arm added reviewers: sdesmalen, efriedma, rovka, rjmccall. Herald added subscribers: cfe-commits, psnobl, rkruppe, tschuett. Herald added a project: clang. rsandifo-arm added a parent revision: D76088: [Sema][SVE] Don't allow sizeless objects to be thro

[PATCH] D76088: [Sema][SVE] Don't allow sizeless objects to be thrown

efriedma added a comment. Why is throwing an `svint8_t *` an error? I don't see any obvious reason to forbid that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76088/new/ https://reviews.llvm.org/D76088 ___

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

This revision was automatically updated to reflect the committed changes. Closed by commit rGeb41cc619866: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check. (authored by PaulkaToast). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D74386: [SVE] Update API ConstantVector::getSplat() to use ElementCount.

huihuiz added inline comments. Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:6542 -unsigned End = getTransitionType()->getVectorNumElements(); +auto EC = getTransitionType()->getVectorElementCount(); if (UseSplat) efriedma wrote: > Please write o

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

evgeny777 added a comment. @pcc > That case seems somewhat questionable to me. If the symbols are being > exported, it is presumably for the purpose of allowing the symbols to be used > outside of the defining DSO. But LTO visibility based optimizations could > make any such use of the symbols

[PATCH] D76087: [Sema][SVE] Reject sizeless types in exception specs

rsandifo-arm created this revision. rsandifo-arm added reviewers: sdesmalen, efriedma, rovka, rjmccall. Herald added subscribers: cfe-commits, psnobl, rkruppe, tschuett. Herald added a project: clang. rsandifo-arm added a parent revision: D76086: [Sema][SVE] Reject arithmetic on pointers to sizele

  1   2   3   >