[PATCH] D76587: [BPF] support 128bit int explicitly in layout spec

yonghong-song created this revision. yonghong-song added a reviewer: ast. Herald added subscribers: cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added a project: clang. Currently, bpf does not specify 128bit alignment in its layout spec. So for a structure like struct ipv6_key_t {

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

jdoerfert added a comment. Did you add the warning @lebedev.ri mentioned? (@lebedev.ri I assume/hope a warning is sufficient here?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 ___

[PATCH] D66332: [clang-format] Fix the bug that joins template closer and > or >>

owenpan added a comment. The culprit is `AnnotatingParser::parseAngle()` in clang/lib/Format/TokenAnnotator.cpp. This commit merely uncovered it. :) Upon reading a `<` token, `parseAngle()` tries to scan the rest of the line to find a matching `>`. If found, it's given the type `TT_TemplateClos

[clang] 2ec59a0 - Buildbot debugging of 0d0b90105f92f6cd9cc7004d565834f4429183fb (lambda/function_ref lifetime issues)

Author: David Blaikie Date: 2020-03-22T22:43:44-07:00 New Revision: 2ec59a0a40f4ec02e6b2dbe5f12261959c191aa9 URL: https://github.com/llvm/llvm-project/commit/2ec59a0a40f4ec02e6b2dbe5f12261959c191aa9 DIFF: https://github.com/llvm/llvm-project/commit/2ec59a0a40f4ec02e6b2dbe5f12261959c191aa9.diff

Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

Reverted in 0d0b90105f92f6cd9cc7004d565834f4429183fb & I'll see what happens with the buildbots. On Sun, Mar 22, 2020 at 5:47 PM Johannes Doerfert wrote: > > Apologies for the confusion. > > I wrote the commit message after looking into this and I though the > issue was related to the capture by

[clang] 0d0b901 - Revert "[FIX] Do not copy an llvm::function_ref if it has to be reused"

Author: David Blaikie Date: 2020-03-22T18:43:39-07:00 New Revision: 0d0b90105f92f6cd9cc7004d565834f4429183fb URL: https://github.com/llvm/llvm-project/commit/0d0b90105f92f6cd9cc7004d565834f4429183fb DIFF: https://github.com/llvm/llvm-project/commit/0d0b90105f92f6cd9cc7004d565834f4429183fb.diff

[PATCH] D70555: [coroutines] Don't build promise init with no args

junparser added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70555/new/ https://reviews.llvm.org/D70555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D76582: [Hexagon] Don't clear libpath when target is linux-musl

sidneym created this revision. sidneym added reviewers: kparzysz, bcain, adasgupt. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use the default libpath when the target is linux-musl Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76582 Files: clang/l

[PATCH] D76054: [clang-apply-replacements] No longer deduplucates replacements from the same TU

njames93 added a comment. In D76054#1935533 , @ymandel wrote: > Thanks for expanding the description, including the helpful example. I'm not > sure, though, that this is the "right" behavior, at least not always. Worse, > I'm not sure there is a single

[clang] 72fd103 - Doc: Links should use https

Author: Sylvestre Ledru Date: 2020-03-22T22:49:33+01:00 New Revision: 72fd1033ea577a769cc855fde6b5576b82380715 URL: https://github.com/llvm/llvm-project/commit/72fd1033ea577a769cc855fde6b5576b82380715 DIFF: https://github.com/llvm/llvm-project/commit/72fd1033ea577a769cc855fde6b5576b82380715.dif

[libunwind] 72fd103 - Doc: Links should use https

Author: Sylvestre Ledru Date: 2020-03-22T22:49:33+01:00 New Revision: 72fd1033ea577a769cc855fde6b5576b82380715 URL: https://github.com/llvm/llvm-project/commit/72fd1033ea577a769cc855fde6b5576b82380715 DIFF: https://github.com/llvm/llvm-project/commit/72fd1033ea577a769cc855fde6b5576b82380715.dif

[clang-tools-extra] 9860517 - doc: use the right url to bugzilla

Author: Sylvestre Ledru Date: 2020-03-22T22:49:40+01:00 New Revision: 986051749cb12992461626e8e37d7c0923816763 URL: https://github.com/llvm/llvm-project/commit/986051749cb12992461626e8e37d7c0923816763 DIFF: https://github.com/llvm/llvm-project/commit/986051749cb12992461626e8e37d7c0923816763.dif

[PATCH] D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support

stuij added inline comments. Comment at: clang/test/Driver/aarch64-cpus.c:622 + +// The BFloat16 extension is a mandatory component of the Armv8.6-A extensions, but is permitted as an +// optional feature for any implementation of Armv8.2-A to Armv8.5-A (inclusive)

[PATCH] D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support

stuij updated this revision to Diff 251916. stuij marked 9 inline comments as done. stuij added a comment. reindenting a few lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76062/new/ https://reviews.llvm.org/D76062 Files: clang/lib/Basic/Ta

[clang] 7cfd5de - clang/release notes: s/Subversion/git/

Author: Sylvestre Ledru Date: 2020-03-22T22:18:40+01:00 New Revision: 7cfd5de61b8191bbd5a405a05163b71802e8fb8d URL: https://github.com/llvm/llvm-project/commit/7cfd5de61b8191bbd5a405a05163b71802e8fb8d DIFF: https://github.com/llvm/llvm-project/commit/7cfd5de61b8191bbd5a405a05163b71802e8fb8d.dif

[PATCH] D76572: Replace `T(x)` with `reinterpret_cast(x)` everywhere it means reinterpret_cast. No functional change

lebedev.ri added a comment. Passing-by remark: > I wrote a Clang warning [not pictured] to diagnose any use of `T(x)` which > was not equivalent to `static_cast(x)`. I'm not sure whether or not this will pass the bar for a clang diagnostic, but that does sound like a good clang-tidy readability

[PATCH] D76572: Replace `T(x)` with `reinterpret_cast(x)` everywhere it means reinterpret_cast. No functional change

Quuxplusone created this revision. Quuxplusone added reviewers: rsmith, espindola, DiggerLin, ahatanak, reames. Herald added subscribers: cfe-commits, rupprecht, dexonsmith, MaskRay, hiraditya. Herald added a reviewer: jhenderson. Herald added a project: clang. I wrote a Clang warning [not pictur

Re: [clang] 4a0267e - Convert a reachable llvm_unreachable into an assert.

On Sun, Mar 22, 2020 at 9:34 AM Aaron Ballman wrote: > On Sun, Mar 22, 2020 at 12:19 PM David Blaikie wrote: > > > > On Sun, Mar 22, 2020 at 6:34 AM Aaron Ballman > wrote: > >> > >> On Sat, Mar 21, 2020 at 11:31 PM David Blaikie > wrote: > >> > > >> > Why the change? this seems counter to LLVM

[PATCH] D76549: [clang-tidy] Fix RenamerClangTidy handling qualified TypeLocs

njames93 updated this revision to Diff 251910. njames93 added a comment. - Address `auto` and add test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76549/new/ https://reviews.llvm.org/D76549 Files: clang-tools-extra/clang-tidy/utils/Rena

[PATCH] D76455: [NFC] Refactor handling of Xarch option

This revision was automatically updated to reflect the committed changes. Closed by commit rG78957bab5515: [NFC] Refactor handling of Xarch option (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7645

[PATCH] D76140: [InlineFunction] update attributes during inlining

lebedev.ri added inline comments. Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1172 + if (NumInstChecked++ > MaxInstCheckedForThrow || + isGuaranteedToTransferExecutionToSuccessor(&I)) +return true; anna wrote: > lebedev.ri wrote

[clang] 78957ba - [NFC] Refactor handling of Xarch option

Author: Yaxun (Sam) Liu Date: 2020-03-22T14:42:09-04:00 New Revision: 78957bab5515d044caa4ec611b30c952ed63de2d URL: https://github.com/llvm/llvm-project/commit/78957bab5515d044caa4ec611b30c952ed63de2d DIFF: https://github.com/llvm/llvm-project/commit/78957bab5515d044caa4ec611b30c952ed63de2d.dif

Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

On Sun, Mar 22, 2020 at 1:48 PM David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Sun, Mar 22, 2020 at 10:40 AM Johannes Doerfert > wrote: > >> Some buildbots, I think only Windows buildbots for some reason, crashed >> in this function. >> >> The reason, as described, is tha

Re: [clang] 4a0267e - Convert a reachable llvm_unreachable into an assert.

Hi Dave, Aaron, and I spent a lot more time debugging than I should have because I was using > a release + asserts build and the semantics of llvm_unreachable made > unfortunate codegen (switching to an assert makes the issue > immediately obvious). Huh. I think we should be using llvm_unreachab

Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

Some buildbots, I think only Windows buildbots for some reason, crashed in this function. The reason, as described, is that an `llvm::function_ref` cannot be copied and then reused. It just happened to work on almost all configurations. The change was not a "shot in the dark" but identified

[PATCH] D76140: [InlineFunction] update attributes during inlining

anna marked an inline comment as done. anna added inline comments. Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1172 + if (NumInstChecked++ > MaxInstCheckedForThrow || + isGuaranteedToTransferExecutionToSuccessor(&I)) +return true; --

[PATCH] D76140: [InlineFunction] update attributes during inlining

anna updated this revision to Diff 251901. anna added a comment. Noticed while adding couple more tests, there were 2 bugs: 1 the isGuaranteedToTransferExecutionToSuccessor check should be inverted 2. make_range should be until the return instruction - so we do not want std::prev on the returnI

Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

On Sun, Mar 22, 2020 at 10:40 AM Johannes Doerfert wrote: > Some buildbots, I think only Windows buildbots for some reason, crashed > in this function. > > The reason, as described, is that an `llvm::function_ref` cannot be > copied and then reused. It just happened to work on almost all > config

[PATCH] D72810: [LifetimeAnalysis] Add support for lifetime annotations on functions

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7727 +// Move function type attribute to the declarator. +case ParsedAttr::AT_LifetimeContract: aaron.ballman wrote: > xazax.hun wrote:

[PATCH] D76140: [InlineFunction] update attributes during inlining

lebedev.ri added inline comments. Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1172 + if (NumInstChecked++ > MaxInstCheckedForThrow || + isGuaranteedToTransferExecutionToSuccessor(&I)) +return true; anna wrote: > Noticed while ad

[PATCH] D76546: [Hexagon] MaxAtomicPromoteWidth, MaxAtomicInlineWidth are not getting set.

sidneym updated this revision to Diff 251896. sidneym added a comment. remove extra line break. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76546/new/ https://reviews.llvm.org/D76546 Files: clang/lib/Basic/Targets/Hexagon.h clang/test/Prepro

[PATCH] D76140: [InlineFunction] update attributes during inlining

anna marked an inline comment as done. anna added inline comments. Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1172 + if (NumInstChecked++ > MaxInstCheckedForThrow || + isGuaranteedToTransferExecutionToSuccessor(&I)) +return true; --

Re: [clang] 4a0267e - Convert a reachable llvm_unreachable into an assert.

On Sun, Mar 22, 2020 at 12:19 PM David Blaikie wrote: > > On Sun, Mar 22, 2020 at 6:34 AM Aaron Ballman wrote: >> >> On Sat, Mar 21, 2020 at 11:31 PM David Blaikie wrote: >> > >> > Why the change? this seems counter to LLVM's style which pretty >> > consistently uses unreachable rather than ass

Re: [clang] 4a0267e - Convert a reachable llvm_unreachable into an assert.

On Sun, Mar 22, 2020 at 6:34 AM Aaron Ballman wrote: > On Sat, Mar 21, 2020 at 11:31 PM David Blaikie wrote: > > > > Why the change? this seems counter to LLVM's style which pretty > consistently uses unreachable rather than assert(false), so far as I know? > > We're not super consistent (at lea

[PATCH] D76545: [clang-tidy] Add a new check group 'experimental-'

aaron.ballman added a comment. I think we want to keep the experimental checks grouped to their parent module rather than being in a module of their own. Also, if we want to allow experimental checks, I think we should have some rough community consensus on 1) what are the criteria for somethin

[PATCH] D76549: [clang-tidy] Fix RenamerClangTidy handling qualified TypeLocs

aaron.ballman added a comment. I'd appreciate seeing your test cases from the summary added to a test somewhere. Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:206 if (const auto *Loc = Result.Nodes.getNodeAs("typeLoc")) { +auto Unqual = Loc->g

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

tejohnson marked 2 inline comments as done. tejohnson added a comment. PTAL Comment at: llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp:1999 +WholeProgramDevirtResolution *Res = nullptr; +if (ExportSummary && isa(S.first.TypeID)) + // Create the type id summary reso

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

tejohnson updated this revision to Diff 251893. tejohnson added a comment. Includes fixe for 2-stage clang bootstrap test failures and an expanded fix for Chromium issue, plus new tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73242/new/ http

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

tejohnson reopened this revision. tejohnson added a comment. This revision is now accepted and ready to land. Updating with fixes since this was reverted in 80bf137fa132ea33204e98bbefa924afe9258a4e . Repository: rG LLVM Git

Re: [clang] 7a42bab - Reland "[DebugInfo][clang][DWARF5]: Added support for debuginfo generation for defaulted parameters

In the future, please include more detail in the commit message of a recommit about how the patch addresses the problems that lead to the previous revert. This makes it easier for someone reviewing the code to examine the new changes & ensure they're correct/appropriate. On Mon, Mar 2, 2020 at 3:1

Re: [clang] d9b9621 - Reland D73534: [DebugInfo] Enable the debug entry values feature by default

Also, this patch was reverted and recommitted several times (more than I think would be ideal) - please include more details in the commit message about what went wrong, what was fixed, what testing was missed in the first place and done in subsequent precommit validation (& is there anything more

[PATCH] D76054: [clang-apply-replacements] No longer deduplucates replacements from the same TU

ymandel added a comment. Thanks for expanding the description, including the helpful example. I'm not sure, though, that this is the "right" behavior, at least not always. Worse, I'm not sure there is a single "right" behavior. I can easily imagine a tidy that matches multiple times in the sam

Re: [clang] 4a0267e - Convert a reachable llvm_unreachable into an assert.

On Sat, Mar 21, 2020 at 11:31 PM David Blaikie wrote: > > Why the change? this seems counter to LLVM's style which pretty consistently > uses unreachable rather than assert(false), so far as I know? We're not super consistent (at least within Clang), but the rules as I've generally understood th

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth added a comment. Ping @MyDeveloperDay , any clue about what's going on here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 ___ cfe-commits mailing lis

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

estan added a comment. It would be great to get something like this in. In our project we're currently using a kludge of overriding the `RULE_LAUNCH_COMPILE` CMake variable to insert our own shell script as the compiler. The script strips the clang-tidy invocation inserted by CMake if the sour