[PATCH] D76772: [AMDGPU] Add __builtin_amdgcn_workgroup_size_x/y/z

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG369e26ca9e0d: [AMDGPU] Add __builtin_amdgcn_workgroup_size_x/y/z (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

LevitatingLion added a comment. Thanks for the ping. I hadn't looked at this since, but I'll update the patch this weekend. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70366/new/ https://reviews.llvm.org/D70366 ___

[clang] 369e26c - [AMDGPU] Add __builtin_amdgcn_workgroup_size_x/y/z

Author: Yaxun (Sam) Liu Date: 2020-03-28T01:03:20-04:00 New Revision: 369e26ca9e0d9ceb87c70d26e9f13e793ee1ab40 URL: https://github.com/llvm/llvm-project/commit/369e26ca9e0d9ceb87c70d26e9f13e793ee1ab40 DIFF: https://github.com/llvm/llvm-project/commit/369e26ca9e0d9ceb87c70d26e9f13e793ee1ab40.dif

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 253289. oontvoo added a comment. cleanup logging Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/clang/L

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

hliao added a comment. In D76365#1947462 , @hliao wrote: > In D76365#1947103 , @tra wrote: > > > In D76365#1946938 , @hliao wrote: > > > > > The new revision is accepted, rig

[clang] 499b2a8 - PR45294: Fix handling of assumed template names looked up in the lexical

Author: Richard Smith Date: 2020-03-27T21:07:06-07:00 New Revision: 499b2a8d63ca9b319ce3aae462029f37ce7d96dd URL: https://github.com/llvm/llvm-project/commit/499b2a8d63ca9b319ce3aae462029f37ce7d96dd DIFF: https://github.com/llvm/llvm-project/commit/499b2a8d63ca9b319ce3aae462029f37ce7d96dd.diff

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

hliao added a comment. In D76365#1947103 , @tra wrote: > In D76365#1946938 , @hliao wrote: > > > The new revision is accepted, right? Just want to confirm as it seems you > > accept it before I posted the new chang

[clang] 88c7ffa - Form invalid template-id annotations when parsing a construct that is

Author: Richard Smith Date: 2020-03-27T20:27:42-07:00 New Revision: 88c7ffaf947642b0cb2d13e5d1a4a54fc633d014 URL: https://github.com/llvm/llvm-project/commit/88c7ffaf947642b0cb2d13e5d1a4a54fc633d014 DIFF: https://github.com/llvm/llvm-project/commit/88c7ffaf947642b0cb2d13e5d1a4a54fc633d014.diff

[PATCH] D76887: AMDGPU: Make HIPToolChain a subclass of ROCMToolChain

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:271 const ToolChain &HostTC, const ArgList &Args) -: ToolChain(D, Triple, Args), HostTC(HostTC) { +: ROCMToolChain(D, Triple, Args), HostTC(HostTC) { // Lookup b

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

DiggerLin updated this revision to Diff 253281. DiggerLin added a comment. clang reformat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76932/new/ https://reviews.llvm.org/D76932 Files: clang/lib/Driver/ToolChains/AIX.cpp llvm/include/llvm/Cod

[PATCH] D76959: [WebAssembly] Import wasm_simd128.h from Emscripten

sbc100 added inline comments. Comment at: clang/lib/Headers/wasm_simd128.h:10 + +#pragma once + tlively wrote: > sunfish wrote: > > Do you know why other clang headers, such as `lib/Headers/xmmintrin.h`, > > don't use `#pragma once`? > No, I don't know. Accordin

[clang] 0c42539 - Improve error recovery from missing '>' in template argument list.

Author: Richard Smith Date: 2020-03-27T18:59:01-07:00 New Revision: 0c42539df3d4c697fa3bf6fc88e94b127d334a57 URL: https://github.com/llvm/llvm-project/commit/0c42539df3d4c697fa3bf6fc88e94b127d334a57 DIFF: https://github.com/llvm/llvm-project/commit/0c42539df3d4c697fa3bf6fc88e94b127d334a57.diff

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram updated this revision to Diff 253271. tmsriram marked 5 inline comments as done. tmsriram added a reviewer: eli.friedman. tmsriram added a comment. Clang options for Basic Block Sections enabled in D68063 and D73674 1.

[PATCH] D76916: [Darwin] Respect -fno-unroll-loops during LTO.

dexonsmith added a subscriber: Florian. dexonsmith added a comment. @fhahn, please revert, this isn't how we usually pass options in LTO. If this is something we expect developers to use, it should be specifiable on a per-TU basis. The way we do this is by specifying it during compilation, att

[PATCH] D76959: [WebAssembly] Import wasm_simd128.h from Emscripten

tlively marked 2 inline comments as done. tlively added inline comments. Comment at: clang/lib/Headers/wasm_simd128.h:10 + +#pragma once + sunfish wrote: > Do you know why other clang headers, such as `lib/Headers/xmmintrin.h`, don't > use `#pragma once`? No, I

[PATCH] D76959: [WebAssembly] Import wasm_simd128.h from Emscripten

sunfish added a comment. Very cool, thanks for putting this together! Comment at: clang/lib/Headers/wasm_simd128.h:10 + +#pragma once + Do you know why other clang headers, such as `lib/Headers/xmmintrin.h`, don't use `#pragma once`? Comment

[clang] b3f6e3d - Improve recovery from invalid template-ids.

Author: Richard Smith Date: 2020-03-27T17:11:04-07:00 New Revision: b3f6e3d6d64d77a9c840b8407b7e3c49b62b46dd URL: https://github.com/llvm/llvm-project/commit/b3f6e3d6d64d77a9c840b8407b7e3c49b62b46dd DIFF: https://github.com/llvm/llvm-project/commit/b3f6e3d6d64d77a9c840b8407b7e3c49b62b46dd.diff

Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

On Fri, Mar 27, 2020 at 8:16 PM Arthur O'Dwyer wrote: > Richard: Okay, filed https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94376 ! > > David: You are correct, the bug in function_ref appeared only when > constructing from `const function_ref&&`. When I said that the constructor > template suppress

Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

Richard: Okay, filed https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94376 ! David: You are correct, the bug in function_ref appeared only when constructing from `const function_ref&&`. When I said that the constructor template suppressed the copy constructor, I was wrong. The implicitly generated co

[PATCH] D76818: [clang-tidy] Add check llvmlibc-implementation-in-namespace.

PaulkaToast marked 3 inline comments as done. PaulkaToast added a comment. In D76818#1943781 , @njames93 wrote: > If you want to make it a general check, you should consider making the > default module options set the correct namespace > RequiredNamespace

[PATCH] D76818: [clang-tidy] Add check llvmlibc-implementation-in-namespace.

PaulkaToast updated this revision to Diff 253250. PaulkaToast added a comment. Updated to handle nested namespaces, exclude C linkages functions, and made check language specific. (: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76818/new/ https:

[PATCH] D76959: [WebAssembly] Import wasm_simd128.h from Emscripten

tlively created this revision. tlively added reviewers: aheejin, sunfish. Herald added subscribers: cfe-commits, jgravelle-google, sbc100, mgorny, dschuff. Herald added a project: clang. tlively updated this revision to Diff 253249. tlively added a comment. - Update license to match xmmintrin.h f

[PATCH] D76943: [clang analysis] Make mutex guard detection more reliable.

efriedma updated this revision to Diff 253253. efriedma added a comment. Add support for conversion operators. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76943/new/ https://reviews.llvm.org/D76943 Files: clang/lib/Analysis/ThreadSafety.cpp

[PATCH] D76959: [WebAssembly] Import wasm_simd128.h from Emscripten

tlively updated this revision to Diff 253249. tlively added a comment. - Update license to match xmmintrin.h format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76959/new/ https://reviews.llvm.org/D76959 Files: clang/lib/Headers/CMakeLists.txt

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

hliao added a comment. In D76365#1947103 , @tra wrote: > In D76365#1946938 , @hliao wrote: > > > The new revision is accepted, right? Just want to confirm as it seems you > > accept it before I posted the new chang

Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

On Fri, 27 Mar 2020 at 16:35, David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Thu, Mar 26, 2020 at 8:49 PM Richard Smith > wrote: > >> On Thu, 26 Mar 2020 at 17:07, David Blaikie via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> On Thu, Mar 26, 2020 at 3:12 PM

Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

On Thu, 26 Mar 2020 at 21:50, Arthur O'Dwyer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Thu, Mar 26, 2020 at 11:49 PM Richard Smith > wrote: > >> On Thu, 26 Mar 2020 at 17:07, David Blaikie via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> On Thu, Mar 26, 2020 at 3:12

Re: [clang] 2ec59a0 - Buildbot debugging of 0d0b90105f92f6cd9cc7004d565834f4429183fb (lambda/function_ref lifetime issues)

Underlying function_ref fix made in https://github.com/llvm/llvm-project/commit/cbce88dd3a9ea7161da3c57749cf03873dc7ea79 But I'm still happy to leave this code in as-is, though function_ref is small enough to be cheap to copy, I think it's simpler to write local/non-escaping lambdas with "[&]" for

Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

On Thu, Mar 26, 2020 at 8:49 PM Richard Smith wrote: > On Thu, 26 Mar 2020 at 17:07, David Blaikie via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Thu, Mar 26, 2020 at 3:12 PM Arthur O'Dwyer >> wrote: >> >>> I'm not sure, but I do see that the call stack contains a call to >>> >>>

[PATCH] D76943: [clang analysis] Make mutex guard detection more reliable.

aaronpuchert added subscribers: aaron.ballman, aaronpuchert. aaronpuchert added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:2144-2145 + if (auto *CE = dyn_cast(E)) +if (CE->getCastKind() == CK_NoOp || +CE->getCastKind() == CK_Construc

[PATCH] D76939: [AST] Add a Dependence bitmask to use for calculations with multiple node types.

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGd68c09ac8795: [AST] Add a Dependence bitmask to use for calculations with multiple node types. (authored by sammccall). Changed prior to commit: https://revie

[PATCH] D76939: [AST] Add a Dependence bitmask to use for calculations with multiple node types.

sammccall marked 3 inline comments as done. sammccall added inline comments. Comment at: clang/include/clang/AST/DependenceFlags.h:120 + + Dependence(Bits V) : V(V) {} + hokein wrote: > nit: this seems to be unused? Removed. (It'll be back in the next patch, tho

[PATCH] D76432: [clangd] Add a tweak for adding "using" statement.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp:245 + auto &SM = Inputs.AST->getSourceManager(); + auto TB = Inputs.AST->getTokens(); + // Determine the length of the qualifier under the cursor, then remove it. ---

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 253245. oontvoo added a comment. Updated tests and get it to pass Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clan

[clang] d68c09a - [AST] Add a Dependence bitmask to use for calculations with multiple node types.

Author: Sam McCall Date: 2020-03-28T00:15:50+01:00 New Revision: d68c09ac87959694fbb4895ff49443afc2b582f9 URL: https://github.com/llvm/llvm-project/commit/d68c09ac87959694fbb4895ff49443afc2b582f9 DIFF: https://github.com/llvm/llvm-project/commit/d68c09ac87959694fbb4895ff49443afc2b582f9.diff LO

[clang] 94938d7 - [Syntax] Prevent (accidentally) copying TokenBuffer

Author: Sam McCall Date: 2020-03-28T00:09:09+01:00 New Revision: 94938d7d41cd11c4539ff93b801fe53cb4fddba2 URL: https://github.com/llvm/llvm-project/commit/94938d7d41cd11c4539ff93b801fe53cb4fddba2 DIFF: https://github.com/llvm/llvm-project/commit/94938d7d41cd11c4539ff93b801fe53cb4fddba2.diff LO

Re: [PATCH] D75791: [clang-format] Added new option IndentExternBlock

I’m wondering if theres a way to tell if an option has been set in the clang-format config file. If IndentExternBlock is not set, we should default to the old behavior. As for your suggestion of setting IndentExternBlock to BraceWrapping.AfterExternBlock or negating it, neither way works with t

[PATCH] D76432: [clangd] Add a tweak for adding "using" statement.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG, thanks! Let me know if/when I should land this for you. Comment at: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp:105 +// argument. +bool isInMacroNotArg(co

[PATCH] D76496: [clang-tidy] StringFindStartswith should ignore 3-arg find()

njames93 added a comment. In D76496#1947059 , @niko wrote: > In D76496#1935127 , @njames93 wrote: > > > I'm not hugely familiar with the abseil library, but from what I can see > > `absl::StartsWith` takes `absl::s

[PATCH] D76957: HIP: Merge builtin library handling

arsenm created this revision. arsenm added reviewers: yaxunl, gregrodgers. Herald added subscribers: kerbowa, Anastasia, nhaehnle, wdng, jvesely. arsenm added parent revisions: D76862: HIP: Ensure new denormal mode attributes are set, D76950: HIP: Link correct denormal mode library, D59321: AMDGPU

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

tra added a comment. In D76365#1946938 , @hliao wrote: > The new revision is accepted, right? Just want to confirm as it seems you > accept it before I posted the new change. The approval was for the old version. I didn't undo it when I reopened the re

[PATCH] D76939: [AST] Add a Dependence bitmask to use for calculations with multiple node types.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. nice, thanks! Comment at: clang/include/clang/AST/DependenceFlags.h:120 + + Dependence(Bits V) : V(V) {} + nit: this seems to be unused?

[PATCH] D76916: [Darwin] Respect -fno-unroll-loops during LTO.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ce198d6ed37: [Darwin] Respect -fno-unroll-loops during LTO. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76916/new/ https://reviews.l

[PATCH] D76496: [clang-tidy] StringFindStartswith should ignore 3-arg find()

niko added a comment. In D76496#1935127 , @njames93 wrote: > I'm not hugely familiar with the abseil library, but from what I can see > `absl::StartsWith` takes `absl::string_view` as args. Therefore surely it > makes sense to handle the 3rd arg for `str

[clang] 9ce198d - [Darwin] Respect -fno-unroll-loops during LTO.

Author: Florian Hahn Date: 2020-03-27T22:19:03Z New Revision: 9ce198d6ed371399e9bd9ba8b48fbab0f4e60240 URL: https://github.com/llvm/llvm-project/commit/9ce198d6ed371399e9bd9ba8b48fbab0f4e60240 DIFF: https://github.com/llvm/llvm-project/commit/9ce198d6ed371399e9bd9ba8b48fbab0f4e60240.diff LOG:

[clang] 0fca766 - [OPENMP50]Fix PR45117: Orphaned task reduction should be allowed.

Author: Alexey Bataev Date: 2020-03-27T17:47:30-04:00 New Revision: 0fca766458da04bbc6d33b3f9ecd57e615c556c1 URL: https://github.com/llvm/llvm-project/commit/0fca766458da04bbc6d33b3f9ecd57e615c556c1 DIFF: https://github.com/llvm/llvm-project/commit/0fca766458da04bbc6d33b3f9ecd57e615c556c1.diff

[PATCH] D76942: Add BitWidth trait to BitmaskEnum, and use for clang DependenceFlags. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b3bedec999a: Add BitWidth trait to BitmaskEnum, and use for clang DependenceFlags. NFC (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D76385: Allow remapping Clang module include paths

This revision was automatically updated to reflect the committed changes. Closed by commit rG22d5bd0e3b32: Allow remapping Clang module include paths (authored by aprantl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76385/new/ https://reviews.llv

[PATCH] D76385: Allow remapping Clang module include paths

aprantl added a comment. LLDB didn't apply DW_AT_comp_dir to DW_AT_LLVM_include_path. I fixed that now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76385/new/ https://reviews.llvm.org/D76385 ___ cfe-

[PATCH] D68115: Zero initialize padding in unions

jfb added a comment. In D68115#1946757 , @rsmith wrote: > In D68115#1946668 , > @hubert.reinterpretcast wrote: > > > It sounds like we are looking for `-fzero-union-padding`. That's been where > > the discussion h

[PATCH] D75561: Remove const qualifier from Modules returned by ExternalASTSource. (NFC)

aprantl added a comment. Pinging @teemperor CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75561/new/ https://reviews.llvm.org/D75561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D76953: [AST] Fix a crash on invalid bitwidth exprs when preserving the recoveryexprs.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/ASTContext.cpp:2165 +if (ObjCI->getDecl()->isInvalidDecl()) { + // FIXME: are the numbers correct? + Width = 8;

[clang] 6b3bede - Add BitWidth trait to BitmaskEnum, and use for clang DependenceFlags. NFC

Author: Sam McCall Date: 2020-03-27T22:40:21+01:00 New Revision: 6b3bedec999a57015339fa5eed276710e87cbb0f URL: https://github.com/llvm/llvm-project/commit/6b3bedec999a57015339fa5eed276710e87cbb0f DIFF: https://github.com/llvm/llvm-project/commit/6b3bedec999a57015339fa5eed276710e87cbb0f.diff LO

[clang] 22d5bd0 - Allow remapping Clang module include paths

Author: Adrian Prantl Date: 2020-03-27T14:23:30-07:00 New Revision: 22d5bd0e3b32530785bc7b5c0f32b32a1f907342 URL: https://github.com/llvm/llvm-project/commit/22d5bd0e3b32530785bc7b5c0f32b32a1f907342 DIFF: https://github.com/llvm/llvm-project/commit/22d5bd0e3b32530785bc7b5c0f32b32a1f907342.diff

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5be9b8cbe2b2: [cuda][hip] Add CUDA builtin surface/texture reference support. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76365/new/

[clang] 5be9b8c - [cuda][hip] Add CUDA builtin surface/texture reference support.

Author: Michael Liao Date: 2020-03-27T17:18:49-04:00 New Revision: 5be9b8cbe2b2253f78a09a863bef18e574737465 URL: https://github.com/llvm/llvm-project/commit/5be9b8cbe2b2253f78a09a863bef18e574737465 DIFF: https://github.com/llvm/llvm-project/commit/5be9b8cbe2b2253f78a09a863bef18e574737465.diff

[PATCH] D76949: Replace subtract-from-zero float in version with fneg in PowerPC special fma compiler builtins

cameron.mcinally accepted this revision. cameron.mcinally added a comment. This revision is now accepted and ready to land. LGTM, assuming Harbormaster whines are addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76949/new/ https://reviews.l

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

hliao added a comment. In D76365#1946925 , @hliao wrote: > Fix Sema checks on partial template specialization. > > - Revise Sema checks on the template class. The new revision is accepted, right? Just want to confirm as it seems you accept it before I p

[PATCH] D76953: [AST] Fix a crash on invalid bitwidth exprs when preserving the recoveryexprs.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. If the bitwith expr contains errors, we mark the field decl invalid. This patch also tweaks the behavior of ObjCInterfaceDecl to be consistent with existing RecordDecl -- getObjCLayout method is only

[PATCH] D76942: Add BitWidth trait to BitmaskEnum, and use for clang DependenceFlags. NFC

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. look nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76942/new/ https://reviews.llvm.org/D76942 _

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

hliao updated this revision to Diff 253214. hliao added a comment. Fix Sema checks on partial template specialization. - Revise Sema checks on the template class. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76365/new/ https://reviews.llvm.org/D7

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

tra reopened this revision. tra added a comment. This revision is now accepted and ready to land. Reopened for further work Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76365/new/ https://reviews.llvm.org/D76365

[PATCH] D76948: [cuda][hip] Add CUDA builtin surface/texture reference support.

tra added a comment. In D76948#1946878 , @hliao wrote: > I tried that before submitting this one. But, as it's in the closed state, I > cannot submit that anymore. I will attach the difference against the previous > change somewhere. I've reopened it.

[PATCH] D76948: [cuda][hip] Add CUDA builtin surface/texture reference support.

hliao marked an inline comment as done. hliao added inline comments. Comment at: clang/test/SemaCUDA/bad-attributes.cu:74-75 + +typedef __attribute__((device_builtin_surface_type)) unsigned long long s0_ty; // expected-warning {{'device_builtin_surface_type' attribute only appli

[PATCH] D68115: Zero initialize padding in unions

hubert.reinterpretcast added a comment. In D68115#1946757 , @rsmith wrote: > 3. After doing (1), extend `__builtin_bit_cast` support to properly handle > padding bits. > 4. After doing (1) and (2), extend constant aggregate emission to always zero > padd

[PATCH] D76948: [cuda][hip] Add CUDA builtin surface/texture reference support.

hliao added a comment. In D76948#1946861 , @tra wrote: > Would it be possible to update the old review with the new diff? It would > make it easier to see the incremental changes you've made. If the old review > can be reopened that would be great as it

[PATCH] D76948: [cuda][hip] Add CUDA builtin surface/texture reference support.

hliao added a comment. In D76948#1946861 , @tra wrote: > Would it be possible to update the old review with the new diff? It would > make it easier to see the incremental changes you've made. If the old review > can be reopened that would be great as it

[PATCH] D76948: [cuda][hip] Add CUDA builtin surface/texture reference support.

tra added a comment. Would it be possible to update the old review with the new diff? It would make it easier to see the incremental changes you've made. If the old review can be reopened that would be great as it would keep all relevant info in one place, but I'm fine doing the review here, to

[PATCH] D76943: [clang analysis] Make mutex guard detection more reliable.

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/ThreadSafety.cpp:2144-2145 + if (auto *CE = dyn_cast(E)) +if (CE->getCastKind() == CK_NoOp || +CE->getCastKind() =

[PATCH] D33029: [clang-format] add option for dangling parenthesis

bbassi added a comment. I don't think that's quite right. Then you will also have to have a `AlignWithDanglingParenthesis` for cases when people still want closing parenthesis on new line but want parameters as well as closing parenthesis to be aligned with opening parenthesis. I think we need

[PATCH] D76949: Replace subtract-from-zero float in version with fneg in PowerPC special fma compiler builtins

ajwock created this revision. ajwock added reviewers: kpn, cameron.mcinally, spatel, hfinkel. Herald added subscribers: cfe-commits, steven.zhang, shchenz, kbarton, nemanjai. Herald added a project: clang. ajwock added a reviewer: nemanjai. Herald added a subscriber: wuzish. This patch adds a test

[PATCH] D76948: [cuda][hip] Add CUDA builtin surface/texture reference support.

hliao added a comment. This's revised change from https://reviews.llvm.org/D76365 after fixing Sema checks on the template partial specialization. With this change, I could compile the following sample code using surface reference. kernel.cu #include surface surf; #if defined(__cl

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

rsmith added a comment. In D69585#1943222 , @llunak wrote: > In D69585#1942431 , @rsmith wrote: > > > This needs to be done behind a flag. It's an explicit design goal that > > compilation behavior using a PCH or p

[PATCH] D76948: [cuda][hip] Add CUDA builtin surface/texture reference support.

hliao created this revision. hliao added reviewers: tra, rjmccall, yaxunl. Herald added a reviewer: a.sidorin. Herald added a project: clang. Herald added a subscriber: cfe-commits. hliao added a comment. This's revised change from https://reviews.llvm.org/D76365 after fixing Sema checks on the t

[PATCH] D76950: HIP: Link correct denormal mode library

arsenm created this revision. arsenm added a reviewer: yaxunl. Herald added a subscriber: wdng. arsenm added parent revisions: D59321: AMDGPU: Teach toolchain to link rocm device libs, D76862: HIP: Ensure new denormal mode attributes are set. This wasn't respecting the flush mode based on the def

[PATCH] D68115: Zero initialize padding in unions

rsmith added a comment. In D68115#1946668 , @hubert.reinterpretcast wrote: > It sounds like we are looking for `-fzero-union-padding`. That's been where > the discussion has left off twice for months. I believe the state of Clang prior to this patch is

LLVM buildmaster will be updated and restarted after 6PM PST today.

Hello everyone, LLVM buildmaster will be updated and restarted after 7PM PST today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

arsenm updated this revision to Diff 253194. arsenm added a comment. Fix negating backwards logic for default FTZ mode CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59321/new/ https://reviews.llvm.org/D59321 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/cl

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

rjmccall added inline comments. Comment at: clang/include/clang/Sema/Sema.h:12248 + /// SYCLDiagIfDeviceCode(Loc, diag::err_type_unsupported) << "__float128"; + DeviceDiagBuilder SYCLDiagIfDeviceCode(SourceLocation Loc, unsigned DiagID); + Will this collect n

[PATCH] D68115: Zero initialize padding in unions

hubert.reinterpretcast added a comment. In D68115#1946612 , @jfb wrote: > What's the verdict then? It sounds like we are looking for `-fzero-union-padding`. That's been where the discussion has left off twice for months. Repository: rG LLVM Github M

[clang] ee7510d - Fix a Diag call not to assume option spelling

Author: Paul Robinson Date: 2020-03-27T12:12:44-07:00 New Revision: ee7510dc86656b739881466fddd59253d008139d URL: https://github.com/llvm/llvm-project/commit/ee7510dc86656b739881466fddd59253d008139d DIFF: https://github.com/llvm/llvm-project/commit/ee7510dc86656b739881466fddd59253d008139d.diff

[PATCH] D75153: [ThinLTO] Allow usage of all SMT threads in the system

MaskRay added inline comments. Comment at: lld/test/ELF/basic.s:252 -# RUN: not ld.lld %t --thinlto-jobs=0 2>&1 | FileCheck --check-prefix=NOTHREADSTHIN %s -# RUN: not ld.lld %t --plugin-opt=jobs=0 2>&1 | FileCheck --check-prefix=NOTHREADSTHIN %s -# NOTHREADSTHIN: --thinlto-j

[PATCH] D76943: [clang analysis] Make mutex guard detection more reliable.

efriedma created this revision. efriedma added a reviewer: rsmith. Herald added a project: clang. -Wthread-safety was failing to detect certain AST patterns it should detect. Make the pattern detection a bit more comprehensive. Due to an unrelated bug involving template instantiation, this showe

[PATCH] D76942: Add BitWidth trait to BitmaskEnum, and use for clang DependenceFlags. NFC

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76942 Files: clang/include/clang/AST/DependenceFlags.h clang/include/clang/AS

[PATCH] D76830: [Analyzer][MallocChecker] No warning for kfree of ZERO_SIZE_PTR.

Szelethus accepted this revision. Szelethus added a comment. LGTM, thanks! Comment at: clang/test/Analysis/kmalloc-linux-1.c:1 +// RUN: %clang_analyze_cc1 -triple x86_64-unknown-linux -analyzer-checker=unix.Malloc -verify %s + Oh, I almost forgot, the `core` p

[PATCH] D68115: Zero initialize padding in unions

jfb added a comment. What's the verdict then? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68115/new/ https://reviews.llvm.org/D68115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang] 018ad3b - [AST] Fix typo on NoInitExpr dependence computation

Author: Sam McCall Date: 2020-03-27T19:40:25+01:00 New Revision: 018ad3b05ec7c1c217ef203042c652a1535d3588 URL: https://github.com/llvm/llvm-project/commit/018ad3b05ec7c1c217ef203042c652a1535d3588 DIFF: https://github.com/llvm/llvm-project/commit/018ad3b05ec7c1c217ef203042c652a1535d3588.diff LO

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 253175. oontvoo added a comment. Merge master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/clang/Lex/

[PATCH] D33029: [clang-format] add option for dangling parenthesis

stringham added a comment. I think that adding `AlwaysBreakWithDanglingParenthesis` as an option to `BracketAlignmentStyle` should not impact any of the binpacking settings - they should be distinct configuration. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D33029/new/ https://review

[PATCH] D76790: [analyzer] StdLibraryFunctionsChecker: fix bug with arg constraints

martong updated this revision to Diff 253174. martong added a comment. - Add tests with a subchecker Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76790/new/ https://reviews.llvm.org/D76790 Files: clang/include/clang/StaticAnalyzer/Checkers/Chec

[PATCH] D66831: [ObjC] Fix type checking for qualified id block parameters.

vsapsai added a comment. There should be no error for `blockWithParam = genericBlockWithParam;` because `blockWithParam` is called with `I *` and it is safe to substitute `genericBlockWithParam`. Basically you have I *blockArg; id genericParam = blockArg; And for `genericBlockWithParam = b

[PATCH] D76774: [cmake] Link libc++ tests against static libc++/libc++abi in CrossWinToARMLinux.cmake

vvereschaka accepted this revision. vvereschaka added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76774/new/ https://reviews.llvm.org/D76774 _

[clang] 49764dc - [OPENMP50]Add basic support for inscan reduction modifier.

Author: Alexey Bataev Date: 2020-03-27T13:54:38-04:00 New Revision: 49764dc30c4c14ed546e44b67b591902277819f7 URL: https://github.com/llvm/llvm-project/commit/49764dc30c4c14ed546e44b67b591902277819f7 DIFF: https://github.com/llvm/llvm-project/commit/49764dc30c4c14ed546e44b67b591902277819f7.diff

[PATCH] D76692: [AST][SVE] Treat built-in SVE types as trivial

This revision was automatically updated to reflect the committed changes. Closed by commit rGc6824883cc9d: [AST][SVE] Treat built-in SVE types as trivial (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76692/new/ https://re

[PATCH] D76691: [AST][SVE] Treat built-in SVE types as trivially copyable

This revision was automatically updated to reflect the committed changes. Closed by commit rG35392660e6d5: [AST][SVE] Treat built-in SVE types as trivially copyable (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76691/new/

[PATCH] D76939: [AST] Add a Dependence bitmask to use for calculations with multiple node types.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: clang. Herald added a subscriber: cfe-commits. This makes it easier/safer to add bits (error) to other node types without worrying about bit layout all the time. For now, just use to implement the ad-hoc

[PATCH] D33029: [clang-format] add option for dangling parenthesis

bbassi added a comment. @stringham @MyDeveloperDay I have some questions. - As some have pointed out DanglingParenthesis might be a confusing name, so should we try to call it something like BreakBeforeClosingBracket? When this option when is set to true we will always break before closing brac

[PATCH] D76432: [clangd] Add a tweak for adding "using" statement.

adamcz updated this revision to Diff 253165. adamcz added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76432/new/ https://reviews.llvm.org/D76432 Files: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp clang-tools

[PATCH] D76432: [clangd] Add a tweak for adding "using" statement.

adamcz updated this revision to Diff 253164. adamcz marked 22 inline comments as done. adamcz added a comment. Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76432/new/ https://reviews.llvm.org/D76432 Files: clang-tools-

[PATCH] D76830: [Analyzer][MallocChecker] No warning for kfree of ZERO_SIZE_PTR.

balazske updated this revision to Diff 253163. balazske added a comment. - Removed test file malloc-linux-1.c - Prevent warning only if "malloc family" free is done (Do not recognize `ZERO_SIZE_PTR` at a `delete` call.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

  1   2   >