[PATCH] D77628: [Driver][X86] Add -mpad-max-prefix-size

2020-04-06 Thread Kan Shengchen via Phabricator via cfe-commits
skan added a comment. The remote build failed due to a bug of Pre-merge checks, which tried to apply a landed patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77628/new/ https://reviews.llvm.org/D77628

[PATCH] D77628: [Driver][X86] Add -mpad-max-prefix-size

2020-04-06 Thread Kan Shengchen via Phabricator via cfe-commits
skan updated this revision to Diff 255583. skan added a comment. format the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77628/new/ https://reviews.llvm.org/D77628 Files: clang/include/clang/Driver/Options.td

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

2020-04-06 Thread Sameer Sahasrabuddhe via Phabricator via cfe-commits
sameerds added inline comments. Comment at: clang/test/CodeGenHIP/builtin_memory_fence.cpp:9 + // CHECK: fence syncscope("workgroup") seq_cst + __builtin_memory_fence(__ATOMIC_SEQ_CST, "workgroup"); + JonChesterfield wrote: > JonChesterfield wrote: > >

[PATCH] D77628: [Driver][X86] Add -mpad-max-prefix-size

2020-04-06 Thread Kan Shengchen via Phabricator via cfe-commits
skan created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. skan edited the summary of this revision. The option `-mpad-max-prefix-size` performs some checking and delegate to MC option `-x86-pad-max-prefix-size`. This option is designed for eliminate NOPs

[PATCH] D76211: OpenMP Metadirective with user defined condition

2020-04-06 Thread Alok Mishra via Phabricator via cfe-commits
alokmishra.besu updated this revision to Diff 255575. alokmishra.besu added a comment. Updated the test cases. Fixed an issue where correct code was not generated if directive variant was not provided in when/default clause Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77583: [hip] Remove `hip_pinned_shadow`.

2020-04-06 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77583/new/ https://reviews.llvm.org/D77583

[PATCH] D62445: [test] Fix plugin tests

2020-04-06 Thread Don Hinton via Phabricator via cfe-commits
hintonda marked an inline comment as done. hintonda added inline comments. Comment at: cfe/trunk/test/CMakeLists.txt:140 - set_target_properties(check-clang-analyzer PROPERTIES FOLDER "Clang tests") - - if (LLVM_WITH_Z3) thakis wrote: > Did you intentionally

[clang] c56975e - Fix template instantiation of a non-dependent call to an inherited

2020-04-06 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-04-06T19:20:30-07:00 New Revision: c56975e299e17a503066c98a3afaf02c5b231f9e URL: https://github.com/llvm/llvm-project/commit/c56975e299e17a503066c98a3afaf02c5b231f9e DIFF: https://github.com/llvm/llvm-project/commit/c56975e299e17a503066c98a3afaf02c5b231f9e.diff

[PATCH] D77484: [Vector] Pass VectLib to LTO backend so TLI build correct vector function list

2020-04-06 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added a comment. In D77484#1965629 , @wenlei wrote: > > Ok then it does sound like these could be handled on a per-function basis, > > similar to how -fno-builtin* are handled. I.e. a function attribute to > > indicate the veclib, which would

[PATCH] D77583: [hip] Remove `hip_pinned_shadow`.

2020-04-06 Thread Michael Liao via Phabricator via cfe-commits
hliao added a comment. In D77583#1965823 , @yaxunl wrote: > Is the runtime and HIP directed test change in place? yeah, I verified several tests using texture references. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77290: [OpenMP] Specialize OpenMP calls after template instantiation

2020-04-06 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert updated this revision to Diff 255560. jdoerfert added a comment. Override `RebuildCallExpr` in the template instantiation and specialize calls only there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77290/new/

[PATCH] D77290: [OpenMP] Specialize OpenMP calls after template instantiation

2020-04-06 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:8260 } -return Result; + +if (!SemaRef.getLangOpts().OpenMP || !Result.isUsable() || mikerice wrote: > I was expecting the code

[PATCH] D77290: [OpenMP] Specialize OpenMP calls after template instantiation

2020-04-06 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. I figured in TreeTransform everyone would get this behavior but actually only template instantiation wants it so I put it there instead. Do you think it is better placed in the generic TreeTransform code after all? At least this time I verified the test passes. Sorry

[PATCH] D77507: [clangd] Fix HitMapping assertion in Tokens.cpp

2020-04-06 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. In D77507#1964309 , @vabridgers wrote: > Thank you for the comments. I'll keep looking at this to find a proper fix, > but any hints you may have would be greatly appreciated (debugging tips, > strategies, areas of code to

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

2020-04-06 Thread Vy Nguyen via Phabricator via cfe-commits
oontvoo added a comment. jyknight@ Hi, pinging again  (sorry!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 ___ cfe-commits mailing list

Re: [clang] a8c8b62 - [ObjC generics] Fix not inheriting type bounds in categories/extensions.

2020-04-06 Thread Nico Weber via cfe-commits
This isn't bot-dependent, it's been flaking on many different bots over the last few days. Here's one from just now: http://lab.llvm.org:8011/builders/clang-atom-d525-fedora-rel/builds/34705 On Mon, Apr 6, 2020 at 4:40 PM Volodymyr Sapsai wrote: > Is there anything special in the builedbot

[PATCH] D77615: [Syntax] Merge overlapping top-level macros in TokenBuffer

2020-04-06 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added reviewers: kadircet, vabridgers. Herald added a project: clang. Herald added a subscriber: cfe-commits. sammccall added a parent revision: D77614: [Syntax] Simplify TokenCollector::Builder, use captured expansion bounds. NFC. Our previous

[PATCH] D77290: [OpenMP] Specialize OpenMP calls after template instantiation

2020-04-06 Thread Mike Rice via Phabricator via cfe-commits
mikerice added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:8260 } -return Result; + +if (!SemaRef.getLangOpts().OpenMP || !Result.isUsable() || I was expecting the code would be added to RebuildCallExpr in TreeTransform.h. This

[PATCH] D77614: [Syntax] Simplify TokenCollector::Builder, use captured expansion bounds. NFC

2020-04-06 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a project: clang. Herald added a subscriber: cfe-commits. sammccall updated this revision to Diff 21. sammccall added a comment. sammccall added a child revision: D77615: [Syntax] Merge overlapping top-level

[PATCH] D77614: [Syntax] Simplify TokenCollector::Builder, use captured expansion bounds. NFC

2020-04-06 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 21. sammccall added a comment. drop accidental change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77614/new/ https://reviews.llvm.org/D77614 Files: clang/lib/Tooling/Syntax/Tokens.cpp Index:

[PATCH] D75661: Remove SequentialType from the type heirarchy.

2020-04-06 Thread Eli Friedman via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG68b03aee1a15: Remove SequentialType from the type heirarchy. (authored by efriedma). Changed prior to commit: https://reviews.llvm.org/D75661?vs=252659=255546#toc Repository: rG LLVM Github Monorepo

[PATCH] D77583: [hip] Remove `hip_pinned_shadow`.

2020-04-06 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. Is the runtime and HIP directed test change in place? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77583/new/ https://reviews.llvm.org/D77583 ___ cfe-commits mailing list

[PATCH] D77611: [Sema] fix -Wunused-result in StmtExpr

2020-04-06 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers created this revision. nickdesaulniers added a reviewer: dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. nickdesaulniers planned changes to this revision. nickdesaulniers added a comment. ah, using this to build a Linux kernel triggers tons of

[PATCH] D77611: [Sema] fix -Wunused-result in StmtExpr

2020-04-06 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers planned changes to this revision. nickdesaulniers added a comment. ah, using this to build a Linux kernel triggers tons of warnings. So the behavior of GCC is even more subtle than captured in the test cases here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

2020-04-06 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4205 + +class PPCAIX32TargetCodeGenInfo : public TargetCodeGenInfo { +public: I have a question here. AIX32 falls into PPC32 target, so why we don't inherit from

[clang] 68b03ae - Remove SequentialType from the type heirarchy.

2020-04-06 Thread Eli Friedman via cfe-commits
Author: Eli Friedman Date: 2020-04-06T17:03:49-07:00 New Revision: 68b03aee1a15678ab5b518148d5e75c9dc0436fd URL: https://github.com/llvm/llvm-project/commit/68b03aee1a15678ab5b518148d5e75c9dc0436fd DIFF: https://github.com/llvm/llvm-project/commit/68b03aee1a15678ab5b518148d5e75c9dc0436fd.diff

[PATCH] D76680: [SveEmitter] Add immediate checks for lanes and complex imms

2020-04-06 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76680/new/ https://reviews.llvm.org/D76680 ___ cfe-commits mailing list

[PATCH] D77591: [SveEmitter] Explicitly merge with zero/undef

2020-04-06 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77591/new/ https://reviews.llvm.org/D77591

[PATCH] D77596: [SveEmitter] Add NoOverload flag and builtin for svpfalse

2020-04-06 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. Would it make sense to generalize getSVEType() to getSVETypeList()? It seems like the current approach won't generalize well once you're dealing with more than one overloaded type (for example, llvm.aarch64.sve.scvtf.nxv8f16.nxv8i16). Comment at:

[clang] 8f2d2a7 - For PR45333: Move AnalyzeImplicitConversions to using data recursion

2020-04-06 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-04-06T16:49:27-07:00 New Revision: 8f2d2a7cb46572d51a7dddcf151fb202e4abeb4d URL: https://github.com/llvm/llvm-project/commit/8f2d2a7cb46572d51a7dddcf151fb202e4abeb4d DIFF: https://github.com/llvm/llvm-project/commit/8f2d2a7cb46572d51a7dddcf151fb202e4abeb4d.diff

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

2020-04-06 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D74387#1964483 , @Fznamznon wrote: > In D74387#1950593 , @jdoerfert wrote: > > > This is needed for OpenMP as well. Does it make sense to include it in this > > patch or in another

[PATCH] D77484: [Vector] Pass VectLib to LTO backend so TLI build correct vector function list

2020-04-06 Thread Wenlei He via Phabricator via cfe-commits
wenlei added a comment. > Ok then it does sound like these could be handled on a per-function basis, > similar to how -fno-builtin* are handled. I.e. a function attribute to > indicate the veclib, which would then be naturally preserved during LTO even > after merging/importing across modules.

[PATCH] D77593: [SveEmitter] Implement zeroing of false lanes

2020-04-06 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. Maybe better to emit llvm.aarch64.sve.sel for now, if you're trying to avoid IR operations. Otherwise looks fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77593/new/ https://reviews.llvm.org/D77593

[clang] 7545be0 - fix comment typo to cycle bots

2020-04-06 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-04-06T18:58:27-04:00 New Revision: 7545be074d478297ac60efaee3cf919d436d6f32 URL: https://github.com/llvm/llvm-project/commit/7545be074d478297ac60efaee3cf919d436d6f32 DIFF: https://github.com/llvm/llvm-project/commit/7545be074d478297ac60efaee3cf919d436d6f32.diff

[PATCH] D77290: [OpenMP] Specialize OpenMP calls after template instantiation

2020-04-06 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert updated this revision to Diff 255524. jdoerfert added a comment. Move code as suggested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77290/new/ https://reviews.llvm.org/D77290 Files: clang/lib/Sema/SemaExprCXX.cpp

[PATCH] D77571: [clang-tidy] Add check to find calls to NSInvocation methods under ARC that don't have proper object argument lifetimes.

2020-04-06 Thread Michael Wyman via Phabricator via cfe-commits
mwyman updated this revision to Diff 255513. mwyman added a comment. Trying to fix Harbormaster build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77571/new/ https://reviews.llvm.org/D77571 Files:

[PATCH] D77598: Integral template argument suffix printing

2020-04-06 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added a comment. Is this actually appropriate for an argument to `template ` or should the type be reflected in more than the suffix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598

[PATCH] D77581: Add map-type check for target and target data directive

2020-04-06 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. Sure, will do it later Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77581/new/ https://reviews.llvm.org/D77581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77571: [clang-tidy] Add check to find calls to NSInvocation methods under ARC that don't have proper object argument lifetimes.

2020-04-06 Thread Michael Wyman via Phabricator via cfe-commits
mwyman updated this revision to Diff 255519. mwyman added a comment. Missed CHECK-FIXES for block argument. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77571/new/ https://reviews.llvm.org/D77571 Files:

[PATCH] D77595: [SveEmitter] Add NoAuto flag and builtins for svwhile.

2020-04-06 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen created this revision. sdesmalen added reviewers: SjoerdMeijer, efriedma, rovka. Herald added a subscriber: tschuett. Herald added a project: clang. sdesmalen added a parent revision: D77594: [SveEmitter] Add support for _n form builtins. sdesmalen added a child revision: D77596:

[PATCH] D77592: [NFC}[CodeGen] Make VTable initialization a method of CGCXXABI

2020-04-06 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan created this revision. leonardchan added reviewers: pcc, rjmccall, rsmith. leonardchan added a project: clang. This patch moves the following instances of this snippet: ConstantInitBuilder builder(CGM); auto components = builder.beginStruct();

[PATCH] D77597: [SveEmitter] Add ExpandOp1SVALL and builtin for svptrue

2020-04-06 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen created this revision. sdesmalen added reviewers: SjoerdMeijer, efriedma, rovka. Herald added a subscriber: tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. sdesmalen added a parent revision: D77596: [SveEmitter] Add NoOverload flag and builtin for svpfalse.

[PATCH] D77596: [SveEmitter] Add NoOverload flag and builtin for svpfalse

2020-04-06 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen created this revision. sdesmalen added reviewers: SjoerdMeijer, efriedma, rovka. Herald added a subscriber: tschuett. Herald added a project: clang. sdesmalen added a parent revision: D77595: [SveEmitter] Add NoAuto flag and builtins for svwhile.. sdesmalen added a child revision:

[PATCH] D77598: Integral template argument suffix printing

2020-04-06 Thread Aristotelis Koutsouridis via Phabricator via cfe-commits
arisKoutsou created this revision. arisKoutsou added a reviewer: v.g.vassilev. arisKoutsou added a project: clang. Herald added a subscriber: cfe-commits. Added 'U' suffix for unsigned integral types and 'LL' for 64-bit types. Some tests fail to pass due to this change, because they expect a

[PATCH] D77581: Add map-type check for target and target data directive

2020-04-06 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen added a comment. @ABataev , can you land it for me when you have time? thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77581/new/ https://reviews.llvm.org/D77581 ___ cfe-commits mailing

[PATCH] D76680: [SveEmitter] Add immediate checks for lanes and complex imms

2020-04-06 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen updated this revision to Diff 255500. sdesmalen added a comment. - Addressed comments - added spaces to `0, 90, 180 or 270` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76680/new/ https://reviews.llvm.org/D76680 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D77591: [SveEmitter] Explicitly merge with zero/undef

2020-04-06 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen created this revision. sdesmalen added reviewers: SjoerdMeijer, efriedma, rovka. Herald added a subscriber: tschuett. Herald added a project: clang. sdesmalen added a child revision: D77593: [SveEmitter] Implement zeroing of false lanes. Builtins that have the merge type MergeAnyExp or

[PATCH] D76680: [SveEmitter] Add immediate checks for lanes and complex imms

2020-04-06 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen marked 3 inline comments as done. sdesmalen added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9208 +def err_rotation_argument_to_cmla +: Error<"argument should be the value 0,90,180 or 270">; def

[PATCH] D77581: Add map-type check for target and target data directive

2020-04-06 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen updated this revision to Diff 255497. cchen added a comment. Reuse existing function for target/target data check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77581/new/ https://reviews.llvm.org/D77581 Files:

[PATCH] D77039: [clang-format] Don't break multi block parameters on ObjCBreakBeforeNestedBlockParam

2020-04-06 Thread Jin Lin via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG28ecd7f0b086: [clang-format] Dont break multi block parameters on… (authored by ghvg1313, committed by jinlin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77581: Add map-type check for target and target data directive

2020-04-06 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77581/new/ https://reviews.llvm.org/D77581

[PATCH] D77581: Add map-type check for target and target data directive

2020-04-06 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:17001-17038 + // target, target data + // OpenMP 5.0 [2.12.2, Restrictions, p. 163] + // OpenMP 5.0 [2.12.5, Restrictions, p. 174] + // A map-type

[clang] 28ecd7f - [clang-format] Don't break multi block parameters on ObjCBreakBeforeNestedBlockParam

2020-04-06 Thread Jin Lin via cfe-commits
Author: Kanglei Fang Date: 2020-04-06T14:20:09-07:00 New Revision: 28ecd7f0b0865878a12d814a6d0de92cb7529d22 URL: https://github.com/llvm/llvm-project/commit/28ecd7f0b0865878a12d814a6d0de92cb7529d22 DIFF: https://github.com/llvm/llvm-project/commit/28ecd7f0b0865878a12d814a6d0de92cb7529d22.diff

[PATCH] D77581: Add map-type check for target and target data directive

2020-04-06 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:17001-17038 + // target, target data + // OpenMP 5.0 [2.12.2, Restrictions, p. 163] + // OpenMP 5.0 [2.12.5, Restrictions, p. 174] + // A map-type in a map clause must be to, from,

[PATCH] D77502: [clang][CodeGen] Handle throw expression in conditional operator constant folding

2020-04-06 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good (with the comment suitably tweaked). Thanks! Comment at: clang/lib/CodeGen/CGExpr.cpp:4334 incrementProfileCounter(expr); + // If a throw expression

[PATCH] D73307: Unique Names for Functions with Internal Linkage

2020-04-06 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/docs/UsersManual.rst:1684 + linkage symbols. The unique name is obtained by appending the hash of the + full module name to the original symbol. This option is particularly useful + in attributing profile

[PATCH] D76680: [SveEmitter] Add immediate checks for lanes and complex imms

2020-04-06 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9208 +def err_rotation_argument_to_cmla +: Error<"argument should be the value 0,90,180 or 270">; def warn_neon_vector_initializer_non_portable : Warning<

[PATCH] D76678: [SveEmitter] Add range checks for immediates and predicate patterns.

2020-04-06 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76678/new/ https://reviews.llvm.org/D76678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77581: Add map-type check for target and target data directive

2020-04-06 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen updated this revision to Diff 255481. cchen added a comment. Do not use lint on test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77581/new/ https://reviews.llvm.org/D77581 Files: clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D77519: Fix __is_pointer builtin type trait to work with Objective-C pointer types.

2020-04-06 Thread Louis Dionne via Phabricator via cfe-commits
ldionne accepted this revision. ldionne added inline comments. This revision is now accepted and ready to land. Comment at: libcxx/include/type_traits:901 +// In clang 10.0.0 and earlier __is_pointer didn't work with Objective-C types. +#if __has_keyword(__is_pointer) &&

[PATCH] D77572: [clang-tidy] add new check readability-use-anyofallof

2020-04-06 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. See also suggestion for more generic loop-to-algorithm transformations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77572/new/ https://reviews.llvm.org/D77572

[PATCH] D73307: Unique Names for Functions with Internal Linkage

2020-04-06 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/docs/UsersManual.rst:1684 + linkage symbols. The unique name is obtained by appending the hash of the + full module name to the original symbol. This option is particularly useful + in attributing profile information to the

[PATCH] D77519: Fix __is_pointer builtin type trait to work with Objective-C pointer types.

2020-04-06 Thread Louis Dionne via Phabricator via cfe-commits
ldionne added inline comments. Comment at: clang/test/SemaObjCXX/type-traits-is-pointer.mm:1 +// RUN: %clang_cc1 -fsyntax-only -fobjc-arc -fobjc-runtime-has-weak -verify %s +// expected-no-diagnostics Why do you run this through `-verify`? Can't you just drop

[PATCH] D76389: [NewPM] Run the Speculative Execution Pass only if the target has divergent branches

2020-04-06 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan marked an inline comment as done. leonardchan added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:435 if (Level.getSpeedupLevel() > 1) { -FPM.addPass(SpeculativeExecutionPass()); +FPM.addPass(SpeculativeExecutionIfHasBranchDivergencePass());

[PATCH] D76182: [AVR] Support aliases in non-zero address space

2020-04-06 Thread John McCall via Phabricator via cfe-commits
rjmccall requested changes to this revision. rjmccall added a comment. This revision now requires changes to proceed. I agree this needs a test case. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4550 // Create the new alias itself, but don't set a name yet. + unsigned

[PATCH] D77534: [clangd] DefineOutline: removes static token from static CXXMethodDecl

2020-04-06 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 255472. njames93 marked an inline comment as done. njames93 added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77534/new/ https://reviews.llvm.org/D77534 Files:

[PATCH] D77534: [clangd] DefineOutline: removes static token from static CXXMethodDecl

2020-04-06 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 255473. njames93 added a comment. - Fix issue with last revision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77534/new/ https://reviews.llvm.org/D77534 Files:

Re: [clang] a8c8b62 - [ObjC generics] Fix not inheriting type bounds in categories/extensions.

2020-04-06 Thread Volodymyr Sapsai via cfe-commits
Is there anything special in the builedbot configuration? Are you still observing intermittent failures? I’m double checking if we see similar failures internally but so far looks like everything is working fine. I’ve only seen a single failure

[PATCH] D76389: [NewPM] Run the Speculative Execution Pass only if the target has divergent branches

2020-04-06 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 255474. leonardchan edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76389/new/ https://reviews.llvm.org/D76389 Files:

[PATCH] D77534: [clangd] DefineOutline: removes static token from static CXXMethodDecl

2020-04-06 Thread Nathan James via Phabricator via cfe-commits
njames93 marked 9 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:294 + if (isa(FD) && cast(FD)->isStatic()) +DeleteKeyword(tok::kw_static, {FD->getBeginLoc(), FD->getLocation()});

[PATCH] D77572: [clang-tidy] add new check readability-use-anyofallof

2020-04-06 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. As no FixIts are made the `IncludeInserter` can be removed. I'm struggling to see the value of this check though. If it was reworked to check for loop in the middle of a function it would have a lot more value. bool all_of = true; for (auto X : V) { if (!X) {

[PATCH] D77451: Accept -x cu to indicate language is CUDA, transfer CUDA language flag to header-file arguments

2020-04-06 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. In D77451#1964971 , @sammccall wrote: > > NVCC uses different options that should be properly translated > > Interested to see how this will work. Is clang itself going to support these > args (act compatibly with nvcc, or is the

[PATCH] D77586: Allow parameter names to be elided in a function definition in C

2020-04-06 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, rjmccall, erik.pilkington. Herald added a subscriber: dexonsmith. WG14 has adopted N2480 (http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2480.pdf) into C2x at the meetings last week, allowing parameter names of a

[PATCH] D77585: Stop passing site cfg files via --param to llvm-lit.

2020-04-06 Thread Nico Weber via Phabricator via cfe-commits
thakis created this revision. thakis added a reviewer: rnk. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, mgorny. This has been unnecessary since https://reviews.llvm.org/D37756. https://reviews.llvm.org/D37838 removed it for llvm. This removes it for clang, lld,

[PATCH] D62445: [test] Fix plugin tests

2020-04-06 Thread Nico Weber via Phabricator via cfe-commits
thakis added inline comments. Comment at: cfe/trunk/test/CMakeLists.txt:140 - set_target_properties(check-clang-analyzer PROPERTIES FOLDER "Clang tests") - - if (LLVM_WITH_Z3) Did you intentionally delete the 2 targets here? Repository: rL LLVM CHANGES

[PATCH] D77571: [clang-tidy] Add check to find calls to NSInvocation methods under ARC that don't have proper object argument lifetimes.

2020-04-06 Thread Michael Wyman via Phabricator via cfe-commits
mwyman marked an inline comment as done. mwyman added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/NsinvocationArgumentLifetimeCheck.cpp:71-73 + // Currently there is no way to directly get the source range for the + // __weak/__strong ObjC lifetime

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

2020-04-06 Thread Jason Liu via Phabricator via cfe-commits
jasonliu accepted this revision. jasonliu added a comment. This revision is now accepted and ready to land. Not sure if you want to wait for the feedback from @sfertile and @cebowleratibm , but I'm good with the current revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77571: [clang-tidy] Add check to find calls to NSInvocation methods under ARC that don't have proper object argument lifetimes.

2020-04-06 Thread Michael Wyman via Phabricator via cfe-commits
mwyman updated this revision to Diff 255461. mwyman marked 6 inline comments as done. mwyman added a comment. Responding to review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77571/new/ https://reviews.llvm.org/D77571 Files:

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

2020-04-06 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:26-28 +#define ASSERT_STREAMSTATE_OPENED \ + assert(SS->isOpened() && \ +

[PATCH] D73307: Unique Names for Functions with Internal Linkage

2020-04-06 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. Sorry for the delay, thanks for the update. Code looks good, but I want the documentation to be specific. Comment at: clang/docs/UsersManual.rst:1684 + linkage symbols. The unique name is obtained by appending the hash of the + full module name to the

[PATCH] D77583: [hip] Remove `hip_pinned_shadow`.

2020-04-06 Thread Michael Liao via Phabricator via cfe-commits
hliao created this revision. hliao added a reviewer: yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Use `device_builtin_surface` and `device_builtin_texture` for surface/texture reference support. So far, both the host and device use the same reference type,

[libunwind] 649f042 - [libunwind] Support the new libc++ test format

2020-04-06 Thread Sergej Jaskiewicz via cfe-commits
Author: Sergej Jaskiewicz Date: 2020-04-06T23:26:59+03:00 New Revision: 649f042802d3ed9648da4b1939ac387bc4fe9976 URL: https://github.com/llvm/llvm-project/commit/649f042802d3ed9648da4b1939ac387bc4fe9976 DIFF:

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

2020-04-06 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L updated this revision to Diff 255456. Xiangling_L added a comment. Rebase on the latest master branch; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/ https://reviews.llvm.org/D74166 Files: clang/include/clang/AST/Mangle.h

[PATCH] D77581: Add map-type check for target and target data directive

2020-04-06 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen created this revision. cchen added a reviewer: ABataev. Herald added a reviewer: jdoerfert. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77581 Files: clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D76782: [CodeGenObjC] Fix a crash when attempting to copy a zero-sized bit-field in a non-trivial C struct

2020-04-06 Thread Erik Pilkington via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd33c7de8e11f: [CodeGenObjC] Fix a crash when attempting to copy a zero-sized bit-field in a… (authored by erik.pilkington). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D77150: [Analyzer] New Option for ContainerModeling: AggressiveEraseModeling

2020-04-06 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:647-653 CmdLineOption ]>, Szelethus wrote: > NoQ wrote: > > baloghadamsoftware wrote: > > > Szelethus wrote: > > > > Ah, okay, I see which one you refer

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

2020-04-06 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:26-28 +#define ASSERT_STREAMSTATE_OPENED \ + assert(SS->isOpened() && \ +

[PATCH] D77150: [Analyzer] New Option for ContainerModeling: AggressiveEraseModeling

2020-04-06 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. Please mind that my inline is NOT an objection to this patch. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:647-653 CmdLineOption ]>, NoQ wrote: > baloghadamsoftware wrote: > > Szelethus wrote: > > > Ah,

[PATCH] D77451: Accept -x cu to indicate language is CUDA, transfer CUDA language flag to header-file arguments

2020-04-06 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. > NVCC uses different options that should be properly translated Interested to see how this will work. Is clang itself going to support these args (act compatibly with nvcc, or is the

[PATCH] D77572: [clang-tidy] add new check readability-use-anyofallof

2020-04-06 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/UseAnyOfAllOfCheck.cpp:26 +AST_MATCHER_P(Stmt, nextStmt, internal::Matcher, InnerMatcher) { + const auto = Finder->getASTContext().getParents(Node); + if (Parents.size() != 1)

[clang] d33c7de - [CodeGenObjC] Fix a crash when attempting to copy a zero-sized bit-field in a non-trivial C struct

2020-04-06 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-04-06T16:04:13-04:00 New Revision: d33c7de8e11f2727ef5e325d931ae94af8619bf9 URL: https://github.com/llvm/llvm-project/commit/d33c7de8e11f2727ef5e325d931ae94af8619bf9 DIFF:

[clang-tools-extra] 549e87f - [clangd] Fix bad include

2020-04-06 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2020-04-06T21:36:54+02:00 New Revision: 549e87f3d04bbae91bc7bc38609ce7073e2c8a6d URL: https://github.com/llvm/llvm-project/commit/549e87f3d04bbae91bc7bc38609ce7073e2c8a6d DIFF:

[PATCH] D76725: [clangd] Build ASTs only with fresh preambles or after building a new preamble

2020-04-06 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc31367e95ce1: [clangd] Build ASTs only with fresh preambles or after building a new preamble (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77571: Add ClangTidy check to find calls to NSInvocation methods under ARC that don't have proper object argument lifetimes.

2020-04-06 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/NsinvocationArgumentLifetimeCheck.cpp:35 + +constexpr StringRef WeakText = "__weak"; +constexpr StringRef StrongText = "__strong"; Please use static instead of anonymous

[PATCH] D76304: [clangd] Update TUStatus api to accommodate preamble thread

2020-04-06 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG6b85032c95be: [clangd] Update TUStatus api to accommodate preamble thread (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76304/new/

[PATCH] D77503: [ASTMatchers] Fixed CastKind being parsed incorrectly for dynamic matchers

2020-04-06 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 255440. njames93 added a comment. - Added support for giving suggestions on invalid inputs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77503/new/ https://reviews.llvm.org/D77503 Files:

[PATCH] D76125: [clangd] Decouple preambleworker from astworker, NFCI

2020-04-06 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG276a95bdf27c: [clangd] Decouple preambleworker from astworker, NFCI (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76125/new/

[PATCH] D77571: Add ClangTidy check to find calls to NSInvocation methods under ARC that don't have proper object argument lifetimes.

2020-04-06 Thread Ben Hamilton via Phabricator via cfe-commits
benhamilton accepted this revision. benhamilton added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/objc/NsinvocationArgumentLifetimeCheck.cpp:71-73 + // Currently there is no way to directly get the source range for

[PATCH] D77534: [clangd] DefineOutline: removes static token from static CXXMethodDecl

2020-04-06 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:242 - if (FD->isVirtualAsWritten()) { -SourceRange SpecRange{FD->getBeginLoc(), FD->getLocation()}; -bool HasErrors = true; - -// Clang allows duplicating

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

2020-04-06 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield added inline comments. Comment at: clang/test/CodeGenHIP/builtin_memory_fence.cpp:1 // REQUIRES: amdgpu-registered-target // RUN: %clang_cc1 %s -x hip -emit-llvm -O0 -o - \ Codegen test should be under CodeGen and/or CodeGenCXX Repository:

  1   2   3   4   >