[PATCH] D76896: [clangd] Color dependent names based on their heuristic target if they have one

2020-04-09 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:157 +resolveConflict(ArrayRef Tokens) { + if (Tokens.size() != 2) +return llvm::None; sammccall wrote: > why a limit of 2, vs a loop? I'm not aware of a scenario

[PATCH] D76896: [clangd] Color dependent names based on their heuristic target if they have one

2020-04-09 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 256502. nridge marked 7 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76896/new/ https://reviews.llvm.org/D76896 Files:

[PATCH] D77545: Represent FP options in AST by special Expression node

2020-04-09 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff added a comment. In D77545#1973169 , @rjmccall wrote: > Pragma nodes don't require AST changes to existing nodes, but they require > large changes to a number of clients, If a client is unaware of peculiarities of floating point operations,

[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews

2020-04-09 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D77683#1973757 , @jdoerfert wrote: > In D77683#1970826 , @mehdi_amini > wrote: > > > I am still not sure what "if someone has asked for extra review of a > > specific area" refers to?

[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews

2020-04-09 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added a comment. But this sentence alone at the end of this paragraph does not solve anything to me: how is one know that someone in an "area" (whatever that means) is expected to review all the "non-trivial" patches pre-commit? I don't necessarily disagree with your underlying

[PATCH] D77257: Clean up usages of asserting vector getters in Type

2020-04-09 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added inline comments. Comment at: clang/lib/CodeGen/PatternInit.cpp:60 unsigned BitWidth = llvm::APFloat::semanticsSizeInBits( -(Ty->isVectorTy() ? Ty->getVectorElementType() : Ty) +(Ty->isVectorTy() ? cast(Ty)->getElementType() : Ty)

[PATCH] D77571: [clang-tidy] Add check to find calls to NSInvocation methods under ARC that don't have proper object argument lifetimes.

2020-04-09 Thread Stephane Moore via Phabricator via cfe-commits
stephanemoore accepted this revision. stephanemoore added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/objc-nsinvocation-argument-lifetime.m:64-69 +- (void)processInvocation:(NSInvocation *)Invocation { + [Invocation getArgument: atIndex:2]; + //

[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews

2020-04-09 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D77683#1970826 , @mehdi_amini wrote: > I am still not sure what "if someone has asked for extra review of a specific > area" refers to? As said earlier >> If I understand this correctly, this is meant to cover

[PATCH] D77774: [OpenMP] Allow to go first in C++-mode in target regions

2020-04-09 Thread Johannes Doerfert via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG17d83342235f: [OpenMP] Allow math.h to go first in C++-mode in target regions (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 17d8334 - [OpenMP] Allow to go first in C++-mode in target regions

2020-04-09 Thread Johannes Doerfert via cfe-commits
Author: Johannes Doerfert Date: 2020-04-09T22:10:31-05:00 New Revision: 17d83342235f01d4b110dc5d4664fe96f6597f11 URL: https://github.com/llvm/llvm-project/commit/17d83342235f01d4b110dc5d4664fe96f6597f11 DIFF:

[PATCH] D77806: [analyzer] Do not report CFError null dereference for nonnull params

2020-04-09 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. We're doing much more here than just fixing the CFError behavior; we're actually making the whole analyzer respect these annotations in top frame. Let's add checker-inspecific tests. We have a test checker `debug.ExprInspection` just for that: // RUN: %clang_analyze_cc1

Re: [PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

2020-04-09 Thread Alina Sbirlea via cfe-commits
I'm hoping rG5da1671bf823 fixes them. Please let me know if not and I will revert. Alina On Thu, Apr 9, 2020 at 7:03 PM Stella Stamenova via Phabricator < revi...@reviews.llvm.org> wrote: > stella.stamenova added a comment. > > It looks like this broke the windows lldb buildbot: > >

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

2020-04-09 Thread Stella Stamenova via Phabricator via cfe-commits
stella.stamenova added a comment. It looks like this broke the windows lldb buildbot: lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/15542 It already had a test failure, so you probably didn’t get the email. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

2020-04-09 Thread Scott Constable via Phabricator via cfe-commits
sconstab added inline comments. Comment at: llvm/lib/Target/X86/X86LoadValueInjectionLoadHardening.cpp:233 + if (!STI->useLVILoadHardening() || !STI->is64Bit()) +return false; // FIXME: support 32-bit + craig.topper wrote: > sconstab wrote: > > mattdr

[PATCH] D77632: [TLI] Per-function fveclib for math library used for vectorization

2020-04-09 Thread Wenlei He via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG60c642e74be6: [TLI] Per-function fveclib for math library used for vectorization (authored by wenlei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77632: [TLI] Per-function fveclib for math library used for vectorization

2020-04-09 Thread Wenlei He via Phabricator via cfe-commits
wenlei updated this revision to Diff 256465. wenlei marked an inline comment as done. wenlei added a comment. rebase, update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77632/new/ https://reviews.llvm.org/D77632 Files:

[PATCH] D77846: [analyzer][CallAndMessage][NFC] Split up checkPreCall

2020-04-09 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, balazske, martong, baloghadamsoftware, rnkovacs, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho,

[PATCH] D77847: [clangd] Rebuild dependent files when a header is saved.

2020-04-09 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Caveats: - only works when the header is changed in the editor and the editor provides the

[PATCH] D77845: [analyzer][CallAndMessage][NFC] Change old callbacks to rely on CallEvent

2020-04-09 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, baloghadamsoftware, balazske, martong, rnkovacs, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho,

[clang] 60c642e - [TLI] Per-function fveclib for math library used for vectorization

2020-04-09 Thread Wenlei He via cfe-commits
Author: Wenlei He Date: 2020-04-09T18:26:38-07:00 New Revision: 60c642e74be6af86906d9f3d982728be7bd4329f URL: https://github.com/llvm/llvm-project/commit/60c642e74be6af86906d9f3d982728be7bd4329f DIFF: https://github.com/llvm/llvm-project/commit/60c642e74be6af86906d9f3d982728be7bd4329f.diff

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

2020-04-09 Thread Alina Sbirlea via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa90374988e4e: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff. (authored by asbirlea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a903749 - [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

2020-04-09 Thread Alina Sbirlea via cfe-commits
Author: Alina Sbirlea Date: 2020-04-09T18:08:39-07:00 New Revision: a90374988e4eb8c50d91e11f4e61cdbd5debb235 URL: https://github.com/llvm/llvm-project/commit/a90374988e4eb8c50d91e11f4e61cdbd5debb235 DIFF: https://github.com/llvm/llvm-project/commit/a90374988e4eb8c50d91e11f4e61cdbd5debb235.diff

[PATCH] D77766: [clangd] Set up machinery for gtests of ClangdLSPServer.

2020-04-09 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1229245df7c7: [clangd] Set up machinery for gtests of ClangdLSPServer. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77766/new/

[clang-tools-extra] 1229245 - [clangd] Set up machinery for gtests of ClangdLSPServer.

2020-04-09 Thread Sam McCall via cfe-commits
Author: Sam McCall Date: 2020-04-10T02:50:57+02:00 New Revision: 1229245df7c7323fa916054bf20edc01b3606dd2 URL: https://github.com/llvm/llvm-project/commit/1229245df7c7323fa916054bf20edc01b3606dd2 DIFF: https://github.com/llvm/llvm-project/commit/1229245df7c7323fa916054bf20edc01b3606dd2.diff

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

2020-04-09 Thread Alina Sbirlea via Phabricator via cfe-commits
asbirlea marked 2 inline comments as done. asbirlea added a comment. Thank you for all the comments. Comment at: llvm/include/llvm/Support/GenericDomTreeConstruction.h:325 +auto = BUI ? BUI->PreViewCFG : EmptyGD; +return !empty(children({, N})); }

[PATCH] D77766: [clangd] Set up machinery for gtests of ClangdLSPServer.

2020-04-09 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 256449. sammccall marked 12 inline comments as done. sammccall added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77766/new/ https://reviews.llvm.org/D77766 Files:

[PATCH] D77766: [clangd] Set up machinery for gtests of ClangdLSPServer.

2020-04-09 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/LSPClient.cpp:65 + + void reply(llvm::json::Value ID, + llvm::Expected V) override { kadircet wrote: > put methods before fields Done - I don't care much, but curious

[PATCH] D77794: [clangd] Pull installed gRPC and introduce shared-index-(server|client)

2020-04-09 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clang-tools-extra/clangd/CMakeLists.txt:135 ) add_subdirectory(refactor/tweaks) can you somewhere (shared/README.md?) write down how to get the build working on at least one platform? e.g. 1. install

[PATCH] D77774: [OpenMP] Allow to go first in C++-mode in target regions

2020-04-09 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. The cmath/math.h story makes me sad, but this is a good workaround. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77772: [Clang] Expose RequiresNullTerminator in FileManager.

2020-04-09 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. In D2#1973250 , @Bigcheese wrote: > Not really. It's a static function in MemoryBuffer.cpp, and the > `MemoryBuffer` class doesn't have a `Kind` member so we can't check for > `MemoryBufferMMapFile`. Ah, but there's a

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

2020-04-09 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! You may need to wait for @phosek to confirm. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73845/new/ https://reviews.llvm.org/D73845

[PATCH] D77074: [FPEnv][AArch64] Platform-specific builtin constrained FP enablement

2020-04-09 Thread Diogo N. Sampaio via Phabricator via cfe-commits
dnsampaio accepted this revision. dnsampaio added a comment. This revision is now accepted and ready to land. LGTM, not forgetting to remove the exit comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77074/new/ https://reviews.llvm.org/D77074

[PATCH] D77772: [Clang] Expose RequiresNullTerminator in FileManager.

2020-04-09 Thread Michael Spencer via Phabricator via cfe-commits
Bigcheese added a comment. Not really. It's a static function in MemoryBuffer.cpp, and the `MemoryBuffer` class doesn't have a `Kind` member so we can't check for `MemoryBufferMMapFile`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D2/new/

[PATCH] D77632: [TLI] Per-function fveclib for math library used for vectorization

2020-04-09 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm. I think one check is missing in the test, see comment below. Comment at: llvm/test/Transforms/Inline/veclib-compat.ll:28 + %rslt = call i32 @callee_massv(i8

[PATCH] D49074: [Analyzer] Basic support for multiplication and division in the constraint manager

2020-04-09 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers added a comment. ping! Any chance of this patch being accepted? This patch can help some SA false positives. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49074/new/ https://reviews.llvm.org/D49074 ___ cfe-commits mailing list

[PATCH] D77632: [TLI] Per-function fveclib for math library used for vectorization

2020-04-09 Thread Wenlei He via Phabricator via cfe-commits
wenlei marked 4 inline comments as done. wenlei added inline comments. Comment at: llvm/include/llvm/Analysis/TargetLibraryInfo.h:272 +else + VectLibrary = Impl.ClVectorLibrary; + tejohnson wrote: > wenlei wrote: > > tejohnson wrote: > > > Suggest

[PATCH] D77632: [TLI] Per-function fveclib for math library used for vectorization

2020-04-09 Thread Wenlei He via Phabricator via cfe-commits
wenlei updated this revision to Diff 256437. wenlei marked an inline comment as done. wenlei added a comment. Herald added subscribers: haicheng, eraman. address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77632/new/

[PATCH] D50256: [Analyzer] Basic support for multiplication and division in the constraint manager (for == and != only)

2020-04-09 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers added a comment. ping! Any chance of this patch being accepted? This patch can help some SA false positives. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50256/new/ https://reviews.llvm.org/D50256 ___ cfe-commits mailing list

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

2020-04-09 Thread Samuel Thibault via Phabricator via cfe-commits
sthibaul updated this revision to Diff 256436. sthibaul marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73845/new/ https://reviews.llvm.org/D73845 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/lib/Driver/ToolChains/Gnu.h

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

2020-04-09 Thread Samuel Thibault via Phabricator via cfe-commits
sthibaul marked 2 inline comments as done. sthibaul added a comment. In D73845#1971282 , @MaskRay wrote: > Moving functions from Linux.cpp to Gnu.cpp is definitely appropriate. Have > you made any adjustment? No, it's really pure code move (and the

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

2020-04-09 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a subscriber: probinson. jdoerfert added a comment. Found the commit: dcbe35bad518 The way I see it we just have to teach the inliner about `optnone` so we can uncouple the two (`optnone` and `noinline`). @probinson WDTY? CHANGES SINCE LAST ACTION

[PATCH] D77794: [clangd] Pull installed gRPC and introduce shared-index-(server|client)

2020-04-09 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Oops, hit enter too soon. Well done getting this to work, will patch it and try out locally. Comment at: clang-tools-extra/clangd/index/shared/SharedIndexServer.cpp:43 +// FIXME(kbobyrev): This is copied +std::vector

[PATCH] D77794: [clangd] Pull installed gRPC and introduce shared-index-(server|client)

2020-04-09 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Naming throughout - sorry to be a pain. I think "shared index" is less precise than it could be. WDYT about "Remote index"? Comment at: clang-tools-extra/clangd/CMakeLists.txt:156 + +option(GRPC_INSTALL_PATH "Path to gRPC library installation." OFF)

[PATCH] D77772: [Clang] Expose RequiresNullTerminator in FileManager.

2020-04-09 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. Code change LGTM. Is there a way to add a `MemoryBuffer` unit test for the change to `shouldUseMmap`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D2/new/ https://reviews.llvm.org/D2

[PATCH] D77836: [Attribute] Fix noderef attribute false-negatives

2020-04-09 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan created this revision. leonardchan added reviewers: rsmith, aaron.ballman. leonardchan added a project: clang. `noderef` was failing to trigger warnings in some cases related to c++ style casting. This patch addresses them. Repository: rG LLVM Github Monorepo

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

2020-04-09 Thread Matt Morehouse via Phabricator via cfe-commits
morehouse requested changes to this revision. morehouse added a comment. This revision now requires changes to proceed. In D63616#1961449 , @tuktuk wrote: > Am I missing an additional step for test integration, after adding the test > file? Just tried

[PATCH] D77545: Represent FP options in AST by special Expression node

2020-04-09 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D77545#1972344 , @sepavloff wrote: > The solution in D76384 (Move FPFeatures > from BinaryOperator bitfields to Trailing storage) causes several concerns. > > 1. It requires substantial code

[libunwind] f3d460c - [libunwind] Clean up __arm64__

2020-04-09 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2020-04-09T15:46:48-07:00 New Revision: f3d460ce5874e4dd12b8cf8b227de4cec43a685c URL: https://github.com/llvm/llvm-project/commit/f3d460ce5874e4dd12b8cf8b227de4cec43a685c DIFF: https://github.com/llvm/llvm-project/commit/f3d460ce5874e4dd12b8cf8b227de4cec43a685c.diff

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

2020-04-09 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. In D77792#1971921 , @Szelethus wrote: > You seem to have forgotten `-U` :^) Nice catch! Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:774 +Optional

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

2020-04-09 Thread Balázs Benics via Phabricator via cfe-commits
steakhal updated this revision to Diff 256420. steakhal marked 4 inline comments as done. steakhal added a comment. - add full diff context - NFC refactored `RangeSet` comparison function - add tests for compund `RangeSet`s like: `{[0,1],[5,6]} < {[9,9],[11,42],[44,44]}` - NFC clang-format test

[PATCH] D76831: [AST] Preserve the DeclRefExpr when it refers to an invalid decl.

2020-04-09 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. Generally I think we should be moving towards finer-grained "invalid" / "contains errors" bits, so that we can preserve as much of the AST as possible and produce accurate diagnostics for independent errors wherever possible. To that end, I think generally the "invalid"

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

2020-04-09 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D70366#1972880 , @LevitatingLion wrote: > In D70366#1971137 , @dexonsmith > wrote: > > > In D70366#1970758 , @jdoerfert > > wrote: > > > > >

[PATCH] D77831: [clang-tidy] Convert config options that are bools to use the bool overload of get(GlobalOrLocal)?

2020-04-09 Thread Nathan James via Phabricator via cfe-commits
njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, gribozavr2. Herald added subscribers: cfe-commits, kbarton, xazax.hun, nemanjai. Herald added a project: clang. This was done with a script that looks for calls to Options.get(GlobalOrLocal) that take an integer for

[PATCH] D77732: [clangd] Shard preamble symbols in dynamic index

2020-04-09 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Can't believe we didn't do this before. Nice catch. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:97 +/// paths used by \p FileSyms. +void shardSlabToFiles(const SymbolSlab , const RelationSlab , + FileSymbols ,

[PATCH] D77081: [MS] Mark vbase dtors ref'd when ref'ing dtor

2020-04-09 Thread Reid Kleckner via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG55efb68c19b4: [MS] Mark vbase dtors used when marking dtor used (authored by rnk). Changed prior to commit:

[PATCH] D77702: [clangd] Use token modifiers and more token types for semanticTokens

2020-04-09 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. Thanks for your thoughts! In D77702#1972495 , @sammccall wrote: > Some context for me: I did also start some work on supporting modifiers, and > after some experiments with VSCode concluded it was too early (no support in > any

[PATCH] D77257: Clean up usages of asserting vector getters in Type

2020-04-09 Thread Christopher Tetreault via Phabricator via cfe-commits
ctetreau updated this revision to Diff 256408. ctetreau added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77257/new/ https://reviews.llvm.org/D77257 Files: clang/lib/CodeGen/CGAtomic.cpp clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D77374: Fix -fsanitize=array-bounds with comma operator

2020-04-09 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:882-887 + while (const BinaryOperator *BO = dyn_cast(E)) { +if (!BO->isCommaOp()) + break; +E = BO->getRHS(); +E = E->IgnoreParens(); + }

[PATCH] D77669: [clangd] Update TUStatus test to handle async PreambleThread

2020-04-09 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Now having read it, I'm slightly nervous we're not catching all the interleavings. An alternate approach if this is too messy would be just to capture the two streams of enums

[clang] 55efb68 - [MS] Mark vbase dtors used when marking dtor used

2020-04-09 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-04-09T14:19:36-07:00 New Revision: 55efb68c19b4911f780ec4d074f8ff2f8529883f URL: https://github.com/llvm/llvm-project/commit/55efb68c19b4911f780ec4d074f8ff2f8529883f DIFF: https://github.com/llvm/llvm-project/commit/55efb68c19b4911f780ec4d074f8ff2f8529883f.diff

[PATCH] D77611: [Sema] Check calls to __attribute__((warn_unused_result)) from StmtExprs

2020-04-09 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D77611#1968236 , @nickdesaulniers wrote: > In D77611#1968227 , @dblaikie wrote: > > > Looks like GCC warns on everything but the last unused expression (the last > > one being the

[PATCH] D77081: [MS] Mark vbase dtors ref'd when ref'ing dtor

2020-04-09 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. I'm going to go ahead and push this today. Richard hasn't stamped it, but I did incorporate the feedback, and I'm fairly happy with the results and confident that I addressed the feedback adquately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77451: Accept -x cu to indicate language is CUDA, transfer CUDA language flag to header-file arguments

2020-04-09 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. Thank you! A apologize for not checking the patch before landing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77451/new/ https://reviews.llvm.org/D77451 ___ cfe-commits

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

2020-04-09 Thread LevitatingLion via Phabricator via cfe-commits
LevitatingLion added a comment. In D70366#1971137 , @dexonsmith wrote: > In D70366#1970758 , @jdoerfert wrote: > > > In D70366#1970526 , @dexonsmith > > wrote: > > > > > In

[PATCH] D77632: [TLI] Per-function fveclib for math library used for vectorization

2020-04-09 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added inline comments. Comment at: llvm/include/llvm/Analysis/TargetLibraryInfo.h:272 +else + VectLibrary = Impl.ClVectorLibrary; + wenlei wrote: > tejohnson wrote: > > Suggest moving the implementation of this constructor to the .cpp file, in

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

2020-04-09 Thread Zarko Todorovski via Phabricator via cfe-commits
ZarkoCA updated this revision to Diff 256398. ZarkoCA edited the summary of this revision. ZarkoCA added a comment. Addressed comments -added error for -msvr4-struct-return on AIX and modified appropriate test case -changed code structure as per comment -renamed test file Repository: rG LLVM

[PATCH] D77825: Fix syntax error

2020-04-09 Thread Christopher Tetreault via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG2a1418f242ab: Fix syntax error (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76269: [opaque pointer types] Remove deprecated Instruction/IRBuilder APIs.

2020-04-09 Thread Eli Friedman via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG836ce9db7f13: [opaque pointer types] Remove deprecated Instruction/IRBuilder APIs. (authored by efriedma). Changed prior to commit: https://reviews.llvm.org/D76269?vs=254971=256395#toc Repository:

[PATCH] D77451: Accept -x cu to indicate language is CUDA, transfer CUDA language flag to header-file arguments

2020-04-09 Thread Christopher Tetreault via Phabricator via cfe-commits
ctetreau added inline comments. Comment at: clang/lib/Tooling/InterpolatingCompilationDatabase.cpp:119 + case types::TY_CUDA_DEVICE: +return types::TY_CUDA: default: ctetreau wrote: > Syntax error here, master is broken I went ahead and fixed it.

[PATCH] D77825: Fix syntax error

2020-04-09 Thread Christopher Tetreault via Phabricator via cfe-commits
ctetreau created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ctetreau added reviewers: tra, sammccall, ADRAADRA. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77825 Files: clang/lib/Tooling/InterpolatingCompilationDatabase.cpp

[clang] 2a1418f - Fix syntax error

2020-04-09 Thread Christopher Tetreault via cfe-commits
Author: Christopher Tetreault Date: 2020-04-09T13:46:23-07:00 New Revision: 2a1418f242ab17d8d8fef6fe829fc1b9363877ca URL: https://github.com/llvm/llvm-project/commit/2a1418f242ab17d8d8fef6fe829fc1b9363877ca DIFF:

[PATCH] D76078: [AArch64][SVE] Add a pass for SVE intrinsic optimisations

2020-04-09 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76078/new/ https://reviews.llvm.org/D76078 ___ cfe-commits mailing list

[PATCH] D77632: [TLI] Per-function fveclib for math library used for vectorization

2020-04-09 Thread Wenlei He via Phabricator via cfe-commits
wenlei marked 4 inline comments as done. wenlei added inline comments. Comment at: llvm/include/llvm/Analysis/TargetLibraryInfo.h:272 +else + VectLibrary = Impl.ClVectorLibrary; + tejohnson wrote: > Suggest moving the implementation of this constructor

[PATCH] D77451: Accept -x cu to indicate language is CUDA, transfer CUDA language flag to header-file arguments

2020-04-09 Thread Christopher Tetreault via Phabricator via cfe-commits
ctetreau added inline comments. Comment at: clang/lib/Tooling/InterpolatingCompilationDatabase.cpp:119 + case types::TY_CUDA_DEVICE: +return types::TY_CUDA: default: Syntax error here, master is broken Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D77451: Accept -x cu to indicate language is CUDA, transfer CUDA language flag to header-file arguments

2020-04-09 Thread Artem Belevich via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG6ed88afd780c: [CUDA] Accept -x cu to indicate language is CUDA, transfer CUDA language flag… (authored by ADRAADRA, committed by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77621: Change BitcodeWriter buffer to std::vector instead of SmallVector.

2020-04-09 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D77621#1970015 , @dexonsmith wrote: > In D77621#1968647 , @browneee wrote: > > > Do we want to increase the complexity of SmallVector somewhat? or do we > > want to keep the limit and

[PATCH] D77680: [clang-tidy] misc-unused-parameters: Don't remove parameter from lambda

2020-04-09 Thread Matthias Gehre via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGeaa55590945a: [clang-tidy] misc-unused-parameters: Dont remove parameter from lambda (authored by mgehre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

2020-04-09 Thread Simon Cook via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG61ff29637501: [RISCV] Add Clang frontend support for Bitmanip extension (authored by s.egerton, committed by simoncook). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73891: [RISCV] Support experimental/unratified extensions

2020-04-09 Thread Simon Cook via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGdd1ee6dc076f: [RISCV] Support experimental/unratified extensions (authored by simoncook). Changed prior to commit: https://reviews.llvm.org/D73891?vs=250770=256369#toc Repository: rG LLVM Github

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

2020-04-09 Thread Jason Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG085689d44cb9: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX (authored by jasonliu). Changed prior to commit: https://reviews.llvm.org/D76130?vs=255321=256367#toc

[PATCH] D76831: [AST] Preserve the DeclRefExpr when it refers to an invalid decl.

2020-04-09 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Yeah, so I guess the point of marking decls invalid is in large part to stop recovery using it. It's not surprising 1 has recovery regressions. 3 should have fewer (basically because you'll get the dependent bits too), but likely still some. 2 definitely seems the way

[clang] 6ed88af - [CUDA] Accept -x cu to indicate language is CUDA, transfer CUDA language flag to header-file arguments

2020-04-09 Thread Artem Belevich via cfe-commits
Author: ADRA Date: 2020-04-09T13:08:41-07:00 New Revision: 6ed88afd780cc2cd04e50e25c5d3ffafc07b1c1b URL: https://github.com/llvm/llvm-project/commit/6ed88afd780cc2cd04e50e25c5d3ffafc07b1c1b DIFF: https://github.com/llvm/llvm-project/commit/6ed88afd780cc2cd04e50e25c5d3ffafc07b1c1b.diff LOG:

[PATCH] D77392: [WIP][clangd] Make signatureHelp work with stale preambles

2020-04-09 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet marked 3 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1076 + if (PatchAdditionalIncludes) { +for (const auto : newIncludes( + Input.Preamble.LexedIncludes, sammccall

[PATCH] D77777: [nvptx] Add `nvvm.texsurf.handle` internalizer.

2020-04-09 Thread Michael Liao via Phabricator via cfe-commits
hliao added a comment. In D7#1972349 , @tra wrote: > The patch could use a more detailed description. Specifically, it does not > describe the purpose of these changes. > > > Replace them with the internal version, i.e. nvvm.texsurf.handle.internal

[PATCH] D77632: [TLI] Per-function fveclib for math library used for vectorization

2020-04-09 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added a comment. Great, thanks! A few minor comments below. Looks like it needs a clang-format too. Comment at: llvm/include/llvm/Analysis/TargetLibraryInfo.h:272 +else + VectLibrary = Impl.ClVectorLibrary; + Suggest moving the

[PATCH] D77392: [WIP][clangd] Make signatureHelp work with stale preambles

2020-04-09 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 256359. kadircet added a comment. Herald added a subscriber: mgorny. - Encapsulate logic into `PreamblePatch` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77392/new/ https://reviews.llvm.org/D77392 Files:

[PATCH] D76269: [opaque pointer types] Remove deprecated Instruction/IRBuilder APIs.

2020-04-09 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good - thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76269/new/ https://reviews.llvm.org/D76269

[PATCH] D77395: [AST] Dont invalidate VarDecl even the default initializaiton is failed.

2020-04-09 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. the `attempt to use a deleted function` diagnostic is a bit spammy, because the default-constructor and destructor are often deleted for similar reasons. But I guess this is probably

[PATCH] D77701: [Sema] refactor static functions into private methods NFC

2020-04-09 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. Yeah, if these were already member-function static, I'd agree it was a code smell - but function-scope static functions that take "this" as the first parameter don't seem like a bad thing to me - it reduces the header surface area/dependence. Repository: rG LLVM

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

2020-04-09 Thread Matt Morehouse via Phabricator via cfe-commits
morehouse accepted this revision. morehouse added a comment. Thanks again for the patch. Sorry about the delay in landing it; I'll work on it today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63616/new/ https://reviews.llvm.org/D63616

[PATCH] D77451: Accept -x cu to indicate language is CUDA, transfer CUDA language flag to header-file arguments

2020-04-09 Thread ADRA via Phabricator via cfe-commits
ADRAADRA added a comment. In D77451#1970461 , @tra wrote: > Thank you for the patch. I assume you don't have commit access to LLVM. I can > land the patch for you. > How should I attribute it? Will `ADRA ` (used in > phabricator emails) do or do you

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

2020-04-09 Thread Sean Fertile via Phabricator via cfe-commits
sfertile added a comment. A couple minor comments, but patch is almost ready otherwise. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4249 uint64_t Size; // -msvr4-struct-return puts small aggregates in GPR3 and GPR4. Pedantic nit: Can we emit a fatal

[PATCH] D77682: [clang-format] Always break line after enum opening brace

2020-04-09 Thread Omar Sandoval via Phabricator via cfe-commits
osandov updated this revision to Diff 256352. osandov edited the summary of this revision. osandov added a comment. Update summary and test case to better reflect the issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77682/new/

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

2020-04-09 Thread Zarko Todorovski via Phabricator via cfe-commits
ZarkoCA updated this revision to Diff 256351. ZarkoCA marked 2 inline comments as done. ZarkoCA added a comment. Rebased on https://reviews.llvm.org/D73290 and this patch now depends on it. Removed PPCAIX32TargetCodegenClass from previous diff. Corrected behaviour

[PATCH] D77632: [TLI] Per-function fveclib for math library used for vectorization

2020-04-09 Thread Wenlei He via Phabricator via cfe-commits
wenlei updated this revision to Diff 256350. wenlei added a comment. address feedback, allow functions within a module to have different vectlib setting. add test case for inline compatibility check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77776: [Driver] Drop support for FreeBSD < 10

2020-04-09 Thread Dimitry Andric via Phabricator via cfe-commits
dim added a comment. In D6#1971543 , @arichardson wrote: > Alternatively, the checks could be changed to also handle OSMajorVersion == 0 > and translate that to 10. > This seems to be what NetBSD.cpp does. Darwin.cpp also infers the version > from

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

2020-04-09 Thread Eli Friedman via Phabricator via cfe-commits
efriedma removed a reviewer: eli.friedman. efriedma added a comment. Looks roughly fine to me, but I'm not an appropriate reviewer for static analyzer code. Comment at: clang/lib/Analysis/CFG.cpp:2859 // Of everything that can be declared in a DeclStmt, only VarDecls

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

2020-04-09 Thread Zarko Todorovski via Phabricator via cfe-commits
ZarkoCA marked 8 inline comments as done. ZarkoCA added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4205 + +class PPCAIX32TargetCodeGenInfo : public TargetCodeGenInfo { +public: Xiangling_L wrote: > sfertile wrote: > > Xiangling_L wrote: > > >

[PATCH] D75726: [ConstExprPreter] Updated constant interpreter documentation

2020-04-09 Thread Nandor Licker via Phabricator via cfe-commits
nand added a comment. Thanks for the comments! I tried to clarify what could be done in the future and what is already supported. Comment at: clang/docs/ConstantInterpreter.rst:174 A block containing a primitive reserved storage only for the primitive.

[PATCH] D75726: [ConstExprPreter] Updated constant interpreter documentation

2020-04-09 Thread Nandor Licker via Phabricator via cfe-commits
nand updated this revision to Diff 256346. nand marked 15 inline comments as done. nand added a comment. addressed comments, fixed typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75726/new/ https://reviews.llvm.org/D75726 Files:

  1   2   3   >