[PATCH] D77621: ADT: SmallVector size/capacity use word-size integers when elements are small

browneee marked an inline comment as done. browneee added inline comments. Comment at: llvm/include/llvm/ADT/SmallVector.h:19 #include "llvm/Support/Compiler.h" +#include "llvm/Support/ErrorHandling.h" #include "llvm/Support/MathExtras.h" nikic wrote: > Is

[PATCH] D77621: ADT: SmallVector size/capacity use word-size integers when elements are small

browneee updated this revision to Diff 260064. browneee added a comment. Change uintptr_t to uint64_t to ensure this does not instantiate the same template twice on platforms where uintptr_t is equivalent to uint32_t. Also considered using the preprocessor to disable the uintptr_t

[PATCH] D78853: [Sema] Fix null pointer dereference warnings [1/n]

mgrang created this revision. mgrang added reviewers: rsmith, efriedma, rnk, dblaikie. Running the PREfast static analysis tool on clang resulted in several null pointer dereference warnings. This is the first of several patches to fix these. The full list of warnings reported is here:

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

kadircet added inline comments. Comment at: clang/lib/Tooling/ArgumentsAdjusters.cpp:101 // -MF, -MG, -MP, -MT, -MQ, -MD, and -MMD. - if (!Arg.startswith("-M")) { + if (!Arg.startswith("-M") && Arg != "/showIncludes") { AdjustedArgs.push_back(Args[i]);

[PATCH] D77621: ADT: SmallVector size/capacity use word-size integers when elements are small

browneee added a comment. Reverted in 5cb4c3776a34d48e43d9118921d2191aee0e3d21 Fails on plaforms where uintptr_t is the same type as uint32_t. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77621: ADT: SmallVector size/capacity use word-size integers when elements are small

browneee closed this revision. browneee added a comment. Comitted: b5f0eae1dc3c09c020cdf9d07238dec9acdacf5f Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77621/new/

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

saiislam updated this revision to Diff 260053. saiislam added a comment. Updated description and added a failing test case for integer scope. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75917/new/ https://reviews.llvm.org/D75917 Files:

Re: [PATCH] D78192: Support compiler extensions as a normal component

Weird. I already tried the patch under Windows/msvc and had no such problem. Michael Am Fr., 24. Apr. 2020 um 04:15 Uhr schrieb Russell Gallop : > > Hi Serge, > > It looks like this is failing to build on Windows bots (e.g. >

[PATCH] D78659: Add nomerge function attribute to supress tail merge optimization in simplifyCFG

rnk added a comment. In D78659#2003152 , @zequanwu wrote: > Add check in LICM to prevent sink or hoist on `nomerge` call Does sinking and hoisting remove the debug source location? I assumed that it wouldn't, but now after all the smooth stepping work,

[PATCH] D78848: [clangd] Disable delayed template parsing in the main file

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is on by default in windows and breaks most features in template bodies. We'd already disabled

[PATCH] D78843: [clangd] Remove unused bits after 67b2dbd5a33583. NFC

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/Features.inc.in:2 #define CLANGD_BUILD_XPC @CLANGD_BUILD_XPC@ -#define CLANGD_ENABLE_REMOTE @CLANGD_ENABLE_REMOTE@ I don't know how much code will have with `ifdefs` in the Clangd itself, but

[PATCH] D78659: Add nomerge function attribute to supress tail merge optimization in simplifyCFG

zequanwu updated this revision to Diff 260039. zequanwu added a comment. Add check in LICM to prevent sink or hoist on `nomerge` call CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78659/new/ https://reviews.llvm.org/D78659 Files: clang/include/clang/Basic/Attr.td

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

aeubanks updated this revision to Diff 260040. aeubanks added a comment. Add test in ToolingTest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78836/new/ https://reviews.llvm.org/D78836 Files:

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

aeubanks marked an inline comment as done. aeubanks added inline comments. Comment at: clang-tools-extra/clangd/unittests/CompileCommandsTests.cpp:82 +TEST(CommandMangler, StripShowIncludes) { + auto Mangler = CommandMangler::forTests(); sammccall wrote: >

[PATCH] D78659: Add nomerge function attribute to supress tail merge optimization in simplifyCFG

zequanwu updated this revision to Diff 260038. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78659/new/ https://reviews.llvm.org/D78659 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/attr-nomerge.c

[clang-tools-extra] 226b045 - [clangd] Look for compilation database in `build` subdirectory of parents.

Author: Sam McCall Date: 2020-04-25T02:18:17+02:00 New Revision: 226b045b1fe5c436ebd4d9bc1023e508789822c9 URL: https://github.com/llvm/llvm-project/commit/226b045b1fe5c436ebd4d9bc1023e508789822c9 DIFF: https://github.com/llvm/llvm-project/commit/226b045b1fe5c436ebd4d9bc1023e508789822c9.diff

[PATCH] D78843: [clangd] Remove unused bits after 67b2dbd5a33583. NFC

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. I think these are all safe to remove, but this doesn't build for me right now

[PATCH] D78760: Check a class has a definition before iterating over its base classes

rsmith added a comment. We should reject a definition of a class that has a non-dependent base class that's an incomplete type. We need non-dependent bases to be complete in order to be able to do name lookup into them when processing the template definition. (The C++ standard permits us to

[PATCH] D78629: [clangd] Look for compilation database in `build` subdirectory of parents.

This revision was automatically updated to reflect the committed changes. Closed by commit rG226b045b1fe5: [clangd] Look for compilation database in `build` subdirectory of parents. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78842: [SVE][NFC] Use ScalableVectorType in CGBuiltin

ctetreau created this revision. Herald added subscribers: cfe-commits, psnobl, rkruppe, tschuett. Herald added a reviewer: efriedma. Herald added a project: clang. ctetreau added a parent revision: D78841: [SVE] Add specialized overloads of VectorType::get. ctetreau added reviewers: david-arm,

[PATCH] D76452: Use LLD by default for Android.

danalbert added a comment. In D76452#2002981 , @danalbert wrote: > In D76452#2002917 , @MaskRay wrote: > > > In D76452#2002875 , @danalbert > > wrote: > > > > > In

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/unittests/CompileCommandsTests.cpp:82 +TEST(CommandMangler, StripShowIncludes) { + auto Mangler =

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

aeubanks added a comment. Herald added a subscriber: ormris. I did verify that clangd on vscode now works on Windows on the LLVM codebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78836/new/ https://reviews.llvm.org/D78836

[clang] 65f5887 - [ObjC generics] Fix not inheriting type bounds in categories/extensions.

Author: Volodymyr Sapsai Date: 2020-04-24T16:32:28-07:00 New Revision: 65f58878e72a40d68ef3899c766846ee9ec7cf29 URL: https://github.com/llvm/llvm-project/commit/65f58878e72a40d68ef3899c766846ee9ec7cf29 DIFF:

[PATCH] D76452: Use LLD by default for Android.

danalbert abandoned this revision. danalbert added a comment. In D76452#2002917 , @MaskRay wrote: > In D76452#2002875 , @danalbert wrote: > > > In D76452#2002856 , @int3

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commandsIn command lines with /showIncludes, clangd would output includes to stdout, breaking clients.

aeubanks created this revision. aeubanks added reviewers: sammccall, kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/322. Repository: rG LLVM Github Monorepo

[PATCH] D78762: build: use `find_package(Python3)` if available

compnerd updated this revision to Diff 260010. compnerd added a comment. Add missed case of `PYTHON_EXECUTABLE` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78762/new/ https://reviews.llvm.org/D78762 Files:

[PATCH] D76452: Use LLD by default for Android.

MaskRay added a comment. In D76452#2002875 , @danalbert wrote: > In D76452#2002856 , @int3 wrote: > > > Yes, I was referring to that question too :) I'm working on the new > > lld-macho implementation, under the

[PATCH] D76452: Use LLD by default for Android.

danalbert added a comment. In D76452#2002856 , @int3 wrote: > Yes, I was referring to that question too :) I'm working on the new lld-macho > implementation, under the `DarwinNew` flavor. I'm not sure if anything > depends on the old `Darwin` flavor,

[PATCH] D77621: ADT: SmallVector size/capacity use word-size integers when elements are small

browneee updated this revision to Diff 260006. browneee marked 4 inline comments as done. browneee added a comment. - Change SizeTypeMax to a static constexpr function. - Fix comment typos. - Add comment to alert others to possible performance loss if that function is moved to the header.

[PATCH] D76452: Use LLD by default for Android.

int3 added a comment. Yes, I was referring to that question too :) I'm working on the new lld-macho implementation, under the `DarwinNew` flavor. I'm not sure if anything depends on the old `Darwin` flavor, which is why we haven't removed it yet, though we plan to do that once we get the new

[PATCH] D77836: [Attribute] Fix noderef attribute false-negatives

rsmith added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:734 void CastOperation::CheckDynamicCast() { + CheckNoDerefRAII noderef_check(*this); + Please use UpperCamelCase for local variables. Comment at:

[PATCH] D78833: [clangd] Disable all dependency outputs

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/322 Repository: rG LLVM Github Monorepo

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn added a comment. Thanks, I plan to submit this on Monday and then make sure the patches on the clang side align with the draft. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76612/new/ https://reviews.llvm.org/D76612

[PATCH] D77621: ADT: SmallVector size/capacity use word-size integers when elements are small

nikic added inline comments. Comment at: llvm/include/llvm/ADT/SmallVector.h:84 +template const size_t SmallVectorBase::SizeTypeMax; + dblaikie wrote: > nikic wrote: > > Is this needed? I don't think it makes a lot of sense to allow odr-use of > >

[PATCH] D76452: Use LLD by default for Android.

danalbert added a comment. In D76452#2002620 , @int3 wrote: > I don't think I have enough context here to answer the question, but I'm > pretty sure that change wouldn't affect what I'm working on Sorry, wasn't referring to that question specifically,

[PATCH] D78762: build: use `find_package(Python3)` if available

compnerd updated this revision to Diff 259987. compnerd added a comment. Adjust clang-tools-extra at the same time Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78762/new/ https://reviews.llvm.org/D78762 Files:

[PATCH] D77704: [gold] Add support for loading pass plugins

ddcc added a comment. In order to reload the gold plugin, I'm modifying the Clang driver to pass in our own path as a separate argument, which is the most generic approach. Another method would be to use e.g. `dladdr()` to grab our own path from one of our exported functions, but that method

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

yaxunl added a comment. In D77954#2002580 , @tra wrote: > Go ahead. I'll revert it if it breaks anything on our side. Thanks. Done by b46b1a916d44216f0c70de55ae2123eb9de69027

[PATCH] D77704: [gold] Add support for loading pass plugins

ddcc marked an inline comment as done. ddcc added a comment. Thanks, seems to be working now for statically-built passes on a default LLVM build without `LLVM_LINK_LLVM_DYLIB`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77704/new/

[PATCH] D77704: [gold] Add support for loading pass plugins

ddcc updated this revision to Diff 259981. ddcc added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Support statically-built passes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77704/new/

[PATCH] D78655: [HIP] Let lambda be host device by default

tra added inline comments. Comment at: clang/test/CodeGenCUDA/lambda.cu:16-26 +template +__global__ void g(F f) { f(); } + +template +void h(F f) { g<<<1,1>>>(f); } + +__device__ int a; yaxunl wrote: > tra wrote: > > The test example may not be doing what it's

[PATCH] D76452: Use LLD by default for Android.

int3 added a comment. I don't think I have enough context here to answer the question, but I'm pretty sure that change wouldn't affect what I'm working on Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76452/new/ https://reviews.llvm.org/D76452

[PATCH] D77621: ADT: SmallVector size/capacity use word-size integers when elements are small

dblaikie added inline comments. Comment at: llvm/include/llvm/ADT/SmallVector.h:84 +template const size_t SmallVectorBase::SizeTypeMax; + nikic wrote: > Is this needed? I don't think it makes a lot of sense to allow odr-use of > `SizeTypeMax`. As it's a

[clang] b46b1a9 - recommit c77a4078e01033aa2206c31a579d217c8a07569b

Author: Yaxun (Sam) Liu Date: 2020-04-24T16:53:18-04:00 New Revision: b46b1a916d44216f0c70de55ae2123eb9de69027 URL: https://github.com/llvm/llvm-project/commit/b46b1a916d44216f0c70de55ae2123eb9de69027 DIFF:

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

tra added a comment. Go ahead. I'll revert it if it breaks anything on our side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77954/new/ https://reviews.llvm.org/D77954 ___ cfe-commits mailing list

[PATCH] D77621: ADT: SmallVector size/capacity use word-size integers when elements are small

nikic accepted this revision. nikic added inline comments. Comment at: llvm/include/llvm/ADT/SmallVector.h:19 #include "llvm/Support/Compiler.h" +#include "llvm/Support/ErrorHandling.h" #include "llvm/Support/MathExtras.h" Is this include still needed?

[PATCH] D78812: [SVE][CodeGen] Fix legalisation for scalable types

efriedma added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:738 + *DAG.getContext(), IntermediateVT.getScalarType(), DestVectorNoElts, + ValueVT.isScalableVector()); if (ValueVT != BuiltVectorTy) { Can we use

[PATCH] D78827: Add support for #pragma clang fp reassoc(on|off) -- floating point control of associative math transformations

mibintc marked an inline comment as done. mibintc added a comment. added an inline comment Comment at: clang/include/clang/AST/Stmt.h:618 // Only meaningful for floating point types. -unsigned FPFeatures : 8; +unsigned FPFeatures : 14; }; This

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. noted bug in an inline comment. i will upload a fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72841/new/ https://reviews.llvm.org/D72841 ___ cfe-commits mailing list

[PATCH] D78767: [Sema] Teach -Wcast-align to compute a more accurate alignment when the source expression has array subscript or pointer arithmetic operators

ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:14844 + if (auto *VD = Result.Base.dyn_cast()) +return Ctx.getDeclAlign(VD).alignmentAtOffset(Result.Offset); + rjmccall wrote: > Does this

[PATCH] D78659: Add nomerge function attribute to supress tail merge optimization in simplifyCFG

asbirlea added a comment. I think that expanding the patch description will help motivate this and clarify the use-cases for which this is useful, and how it differentiates from `noinline`. Perhaps include that the attribute aims to avoid merging identical calls so as to keep the separate

[PATCH] D78827: Add support for #pragma clang fp reassoc(on|off) -- floating point control of associative math transformations

mibintc created this revision. mibintc added reviewers: rjmccall, sepavloff, andrew.w.kaylor. Herald added a project: clang. mibintc marked an inline comment as done. mibintc added a comment. added an inline comment Comment at: clang/include/clang/AST/Stmt.h:618 // Only

[PATCH] D78687: [Fuchsia] Build compiler-rt builtins for 32-bit x86

This revision was automatically updated to reflect the committed changes. Closed by commit rG063128f97930: [Fuchsia] Build compiler-rt builtins for 32-bit x86 (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78687/new/

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

This revision was automatically updated to reflect the committed changes. Closed by commit rGc77a4078e010: [CUDA][HIP] Fix host/device based overload resolution (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77621: ADT: SmallVector size/capacity use word-size integers when elements are small

dblaikie accepted this revision. dblaikie added a comment. In D77621#2001099 , @dexonsmith wrote: > In D77621#2000237 , @nikic wrote: > > > Okay, I'm basically fine with that, if it is our stance that SmallVector

[PATCH] D78655: [HIP] Let lambda be host device by default

yaxunl updated this revision to Diff 259957. yaxunl marked 2 inline comments as done. yaxunl added a comment. Fix typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78655/new/ https://reviews.llvm.org/D78655 Files: clang/lib/Sema/SemaCUDA.cpp clang/test/CodeGenCUDA/lambda.cu

[PATCH] D77597: [SveEmitter] Add IsAppendSVALL and builtins for svptrue and svcnt[bhwd]

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77597/new/ https://reviews.llvm.org/D77597 ___ cfe-commits mailing list

[PATCH] D77621: ADT: SmallVector size/capacity use word-size integers when elements are small

browneee updated this revision to Diff 259949. browneee added a comment. Switch back to size and capacity type conditionally larger approach (appologies for the noise here). Apply performance regression solutions from @nikic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76452: Use LLD by default for Android.

danalbert added a comment. In D76452#2000812 , @nickdesaulniers wrote: > Can we use `-DCLANG_DEFAULT_LINKER=lld` to configure AOSP's distribution of > LLD, then require the use of `-fuse-ld= that is currently used>` when targeting OSX host tools? It'd

[PATCH] D78762: build: use `find_package(Python3)` if available

compnerd added a comment. @JDevlieghere I dont think that adding another mechanism for finding the python executable is not the right approach. You already have the variables that you are talking about, you just need to specify it in triplicate if you want compatibility across all the

[clang] 063128f - [Fuchsia] Build compiler-rt builtins for 32-bit x86

Author: Petr Hosek Date: 2020-04-24T12:18:30-07:00 New Revision: 063128f97930c551a43a657084f1632e33245bf6 URL: https://github.com/llvm/llvm-project/commit/063128f97930c551a43a657084f1632e33245bf6 DIFF: https://github.com/llvm/llvm-project/commit/063128f97930c551a43a657084f1632e33245bf6.diff

[clang] 7eae004 - Revert "[CUDA][HIP] Fix host/device based overload resolution"

Author: Yaxun (Sam) Liu Date: 2020-04-24T14:57:10-04:00 New Revision: 7eae00477fddf3943b92d485a6055f4043852f9b URL: https://github.com/llvm/llvm-project/commit/7eae00477fddf3943b92d485a6055f4043852f9b DIFF:

[clang] c77a407 - [CUDA][HIP] Fix host/device based overload resolution

Author: Yaxun (Sam) Liu Date: 2020-04-24T14:55:18-04:00 New Revision: c77a4078e01033aa2206c31a579d217c8a07569b URL: https://github.com/llvm/llvm-project/commit/c77a4078e01033aa2206c31a579d217c8a07569b DIFF:

[PATCH] D77979: [clang-tidy] modernize-use-using: Fix broken fixit with InjectedClassName

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a commenting nit. Comment at: clang/include/clang/AST/PrettyPrinter.h:248 + /// Whether to print an InjectedClassNameType with template

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

yaxunl added a comment. @tra Is it OK I commit it now? Or better wait next Monday morning? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77954/new/ https://reviews.llvm.org/D77954 ___ cfe-commits mailing list

[PATCH] D78777: [AST] Use PrintingPolicy for format string diagnosis

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78777/new/ https://reviews.llvm.org/D78777

[PATCH] D78762: build: use `find_package(Python3)` if available

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. I would strongly prefer to do this differently. While we hope to drop Python 2 support in LLDB as soon as possible, we are not there yet. This patch as it stands will

[PATCH] D78192: Support compiler extensions as a normal component

serge-sans-paille added a comment. The patch landed without much errors, only added the patchset e307eeba0137700e75893089cf0de03383d851ca Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72959: Relative VTables ABI on Fuchsia

leonardchan marked an inline comment as done. leonardchan added inline comments. Comment at: clang/lib/CodeGen/CGVTables.cpp:623 +llvm::Constant *C, llvm::GlobalVariable *VTable, unsigned vtableIdx, +unsigned lastAddrPoint) const { + // No need to get the offset of a

[PATCH] D78817: clang: Allow backend unsupported warnings

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78817/new/ https://reviews.llvm.org/D78817 ___ cfe-commits mailing list

[PATCH] D78659: Add nomerge function attribute to supress tail merge optimization in simplifyCFG

zequanwu updated this revision to Diff 259938. Herald added subscribers: dexonsmith, steven_wu. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78659/new/ https://reviews.llvm.org/D78659 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td

[PATCH] D77621: Change BitcodeWriter buffer to std::vector instead of SmallVector.

dexonsmith added a comment. @nikic, great news! Thanks for doing the detailed analysis. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77621/new/ https://reviews.llvm.org/D77621 ___ cfe-commits

[clang] 0ed5b0d - [X86] Don't use types when getting the intrinsic declaration for x86_avx512_mask_vcvtph2ps_512.

Author: Craig Topper Date: 2020-04-24T11:01:22-07:00 New Revision: 0ed5b0d517cb781d4949cc4bfa9854bc276ee13a URL: https://github.com/llvm/llvm-project/commit/0ed5b0d517cb781d4949cc4bfa9854bc276ee13a DIFF: https://github.com/llvm/llvm-project/commit/0ed5b0d517cb781d4949cc4bfa9854bc276ee13a.diff

[PATCH] D77592: [NFC][CodeGen] Add enum for selecting the layout of components in the vtable

leonardchan added a comment. In D77592#2002148 , @rjmccall wrote: > Okay. The plan sounds good to me. So you want to roll out this enum in this > patch, but not really use it for much until the follow-up? That was the plan, but I can also add include

[PATCH] D78762: build: use `find_package(Python3)` if available

compnerd updated this revision to Diff 259923. compnerd added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Include clang as some of the CI uses the unified build which fails without the update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D72959: Relative VTables ABI on Fuchsia

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGVTables.cpp:623 +llvm::Constant *C, llvm::GlobalVariable *VTable, unsigned vtableIdx, +unsigned lastAddrPoint) const { + // No need to get the offset of a nullptr. There's already an

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

erichkeane marked an inline comment as done. erichkeane added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:2980 -return (Ty->isPromotableIntegerType() ? ABIArgInfo::getExtend(Ty) - : ABIArgInfo::getDirect()); +

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

rjmccall added a comment. Is there something currently restricting these types to just x86, or do you need to do a much broader audit? Comment at: clang/lib/CodeGen/TargetInfo.cpp:2980 -return (Ty->isPromotableIntegerType() ? ABIArgInfo::getExtend(Ty) -

[PATCH] D77592: [NFC][CodeGen] Add enum for selecting the layout of components in the vtable

rjmccall added a comment. Okay. The plan sounds good to me. So you want to roll out this enum in this patch, but not really use it for much until the follow-up? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77592/new/

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

rjmccall added a comment. LGTM with one very minor fix. Comment at: clang/docs/LanguageExtensions.rst:511 +*r = *a + (*b * *c); + } + fhahn wrote: > rjmccall wrote: > > This is kindof an unnecessarily unreadable example. I know you haven't > > decided

[PATCH] D78655: [HIP] Let lambda be host device by default

rjmccall added a comment. Seems reasonable Comment at: clang/test/CodeGenCUDA/lambda.cu:29 + +// Check lambda is emitted in device compilation and accessind device variable. +// DEV-LABEL: define internal void @_ZZ4mainENKUlvE_clEv Typo CHANGES SINCE LAST

[PATCH] D78767: [Sema] Teach -Wcast-align to compute a more accurate alignment when the source expression has array subscript or pointer arithmetic operators

rjmccall added inline comments. Comment at: clang/include/clang/AST/Expr.h:710 + /// possible to compute the alignment, return zero. + CharUnits getAlignmentFromDecl(ASTContext ) const; + Nothing about the name here suggests that it only works on expressions

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

rjmccall accepted this revision. rjmccall added a comment. Thanks, Yaxun. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77954/new/ https://reviews.llvm.org/D77954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

tra added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9749 + if (isBetterMultiversionCandidate(Cand1, Cand2)) +return true; + yaxunl wrote: > rjmccall wrote: > > tra wrote: > > > rjmccall wrote: > > > > erichkeane wrote: > > > > > yaxunl

[PATCH] D78817: clang: Allow backend unsupported warnings

arsenm created this revision. arsenm added reviewers: yaxunl, Anastasia, olista01, ostannard, xur. Herald added subscribers: tpr, wdng. Currently this asserts on anything other than errors. In one workaround scenario, AMDGPU emits DiagnosticInfoUnsupported as a warning for functions that can't be

Re: [Lldb-commits] [PATCH] D78807: Fix gendered documentation

A lot of our comments and documentation was written a while ago when the “good” practice was to be careful to use “he” and “she” in equal measure when referring to our users. The consensus has shifted to using “they” instead, so there are probably a bunch of other places using he and she.

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

This revision was automatically updated to reflect the committed changes. Closed by commit rG63959803702c: [Driver] Move GCC multilib/multiarch paths support from Linux.cpp to Gnu.cpp (authored by sthibaul, committed by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78807: Fix gendered documentation

JDevlieghere accepted this revision. JDevlieghere added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78807/new/ https://reviews.llvm.org/D78807 ___ cfe-commits mailing list

[PATCH] D78812: [SVE][CodeGen] Fix legalisation for scalable types

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, efriedma, huntergr. Herald added subscribers: psnobl, rkruppe, hiraditya, tschuett. Herald added a project: LLVM. This patch handles illegal scalable types when lowering IR operations, addressing several places where the

[clang] 6395980 - [Driver] Move GCC multilib/multiarch paths support from Linux.cpp to Gnu.cpp

Author: Samuel Thibault Date: 2020-04-24T09:33:19-07:00 New Revision: 63959803702c66cbd72f6526f43914039c1a027b URL: https://github.com/llvm/llvm-project/commit/63959803702c66cbd72f6526f43914039c1a027b DIFF:

[PATCH] D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support

LukeGeeson abandoned this revision. LukeGeeson added a comment. Sub-issues all closed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77540/new/ https://reviews.llvm.org/D77540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 marked 2 inline comments as done. wxz2020 added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:849-857 +// These pointer authentication instructions require armv8.3a +let Predicates = [HasV8_3a, HasPA] in { let Uses = [LR], Defs = [LR] in {

[PATCH] D78374: [Analyzer][StreamChecker] Added evaluation of fread and fwrite.

Szelethus added a comment. I gave a lot of thought to the high level logic, but I need some time to really internalize whats happening here. In D78374#1993858 , @balazske wrote: > Finally I had to make the decision to remove the `ErrorKindTy` enum and

[PATCH] D78129: Add Marvell ThunderX3T110 support

ktkachov added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:849-857 +// These pointer authentication instructions require armv8.3a +let Predicates = [HasV8_3a, HasPA] in { let Uses = [LR], Defs = [LR] in { def PACIAZ : SystemNoOperands<0b000,

[PATCH] D78457: [analyzer][Z3-refutation] Fix refutation BugReporterVisitor bug and refactor

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2871 + // Overwrite the associated constraint of the Symbol. + Constraints = CF.remove(Constraints, Sym); Constraints = CF.add(Constraints, Sym, C.second);

[PATCH] D77875: [ARM] Armv8.6-a Matrix Mul cmd line support

This revision was automatically updated to reflect the committed changes. Closed by commit rG740a1dd050ee: [ARM] Armv8.6-a Matrix Mul cmd line support (authored by LukeGeeson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77875/new/

[PATCH] D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics

This revision was automatically updated to reflect the committed changes. LukeGeeson marked an inline comment as done. Closed by commit rG7da190512532: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics (authored by LukeGeeson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77871: [AArch64] Armv8.6-a Matrix Mult Assembly + Intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG832cd749131b: [AArch64] Armv8.6-a Matrix Mult Assembly + Intrinsics (authored by LukeGeeson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77871/new/

[PATCH] D78457: [analyzer][Z3-refutation] Fix refutation BugReporterVisitor bug and refactor

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2869 + Constraints = CF.add(Constraints, Sym, C.second); +} else if (!OnlyForNewSymbols) { + // Overwrite the associated constraint of the Symbol. If

  1   2   >