[PATCH] D76451: [clangd] Enable textual fallback for go-to-definition on dependent names

This revision was automatically updated to reflect the committed changes. Closed by commit rG230cae89db3f: [clangd] Enable textual fallback for go-to-definition on dependent names (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78870: [SourceMgr] Tidy up the SourceMgr header file to include less stuff.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG919dcc7f6858: [SourceMgr] Tidy up the SourceMgr header file to include less stuff. (authored by lattner). Changed prior

[PATCH] D78784: [clangd] Add some logging to explain why textual fallback navigation failed

nridge added a comment. The intent is to be able to run a production build on a production codebase and see why a particular instance of navigation failed. However, it's not super important that this land; if you don't think it's useful for others, I can just run with it applied locally.

[clang-tools-extra] 230cae8 - [clangd] Enable textual fallback for go-to-definition on dependent names

Author: Nathan Ridge Date: 2020-04-26T00:38:38-04:00 New Revision: 230cae89db3f8619e2b5383ae797462434f69d50 URL: https://github.com/llvm/llvm-project/commit/230cae89db3f8619e2b5383ae797462434f69d50 DIFF: https://github.com/llvm/llvm-project/commit/230cae89db3f8619e2b5383ae797462434f69d50.diff

[clang] 919dcc7 - [SourceMgr] Tidy up the SourceMgr header file to include less stuff.

Author: Chris Lattner Date: 2020-04-25T21:18:59-07:00 New Revision: 919dcc7f6858cf0d9a7442673acafdf495e46c7a URL: https://github.com/llvm/llvm-project/commit/919dcc7f6858cf0d9a7442673acafdf495e46c7a DIFF: https://github.com/llvm/llvm-project/commit/919dcc7f6858cf0d9a7442673acafdf495e46c7a.diff

[PATCH] D75068: libclang: Add static build support for Windows

davezarzycki added a comment. This breaks building libclang on Fedora 32 with clang 10.0 and lld 10.0. Do you mind if I revert this tomorrow if a quick fix cannot be found? Here is the relevant diagnostics: FAILED: lib64/libclang.so.11 : && /usr/bin/clang++ -fPIC -Werror=switch -stdlib=libc++

[PATCH] D78870: [SourceMgr] Tidy up the SourceMgr header file to include less stuff.

lattner updated this revision to Diff 260140. lattner added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang depended on the transitive include, update it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78163: [AVR][NFC] Move preprocessor tests to Preprocessor directory

This revision was automatically updated to reflect the committed changes. Closed by commit rGceba881aeac1: [AVR][NFC] Move preprocessor tests to Preprocessor directory (authored by aykevl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78163/new/

[clang] ceba881 - [AVR][NFC] Move preprocessor tests to Preprocessor directory

Author: Ayke van Laethem Date: 2020-04-26T01:29:25+02:00 New Revision: ceba881aeac1e24dcffb1eecdc6507c0701f6865 URL: https://github.com/llvm/llvm-project/commit/ceba881aeac1e24dcffb1eecdc6507c0701f6865 DIFF:

[PATCH] D78853: [Sema] Fix null pointer dereference warnings [1/n]

efriedma added a comment. Please don't add null checks for pointers that can't be null. It makes the code slower and harder to understand. And least one of the checks you added is actively breaking the code. In some cases, the analysis is pointing to cases where the code could be made more

[PATCH] D61756: Add a __FILE_NAME__ macro.

MaskRay added a comment. In D61756#2003847 , @kristina wrote: > In D61756#2003836 , @MaskRay wrote: > > > > @rmisth wrote: "Clang should drive the standard, not diverge from it", > > > and we should at least try

[PATCH] D61756: Add a __FILE_NAME__ macro.

kristina added a comment. In D61756#2003836 , @MaskRay wrote: > > @rmisth wrote: "Clang should drive the standard, not diverge from it", and > > we should at least try to push for standardizing this if we think it's > > worthwhile as an alternative to

[PATCH] D61756: Add a __FILE_NAME__ macro.

MaskRay added a comment. > @rmisth wrote: "Clang should drive the standard, not diverge from it", and we > should at least try to push for standardizing this if we think it's > worthwhile as an alternative to __FILE__. In D61756#1505296 , @kristina

[PATCH] D78655: [HIP] Let lambda be host device by default

yaxunl marked an inline comment as done. yaxunl added a comment. In D78655#2003681 , @hliao wrote: > I though the goal of adding HD/D attributes for lambda is to make the static > check easier as lambda used in device code or device lambda is sensitive

[PATCH] D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens

DaanDeMeyer created this revision. DaanDeMeyer added a reviewer: clang-format. DaanDeMeyer added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. systemd recently added a clang-format file. One issue I

[PATCH] D78862: [IR] Convert null-pointer-is-valid into an enum attribute

nikic added a comment. In D78862#2003684 , @arsenm wrote: > FWIW I think this attribute should be replaced with a data layout property, > so this would eventually be removed Is this change planned more for the near term or the long term? I'm not really

[PATCH] D75068: libclang: Add static build support for Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG6fb80d9383e4: libclang: Add static build support for Windows (authored by cristian.adam, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 6fb80d9 - libclang: Add static build support for Windows

Author: Cristian Adam Date: 2020-04-25T20:19:17+03:00 New Revision: 6fb80d9383e415c35204b62569972f70ae7dcb0a URL: https://github.com/llvm/llvm-project/commit/6fb80d9383e415c35204b62569972f70ae7dcb0a DIFF: https://github.com/llvm/llvm-project/commit/6fb80d9383e415c35204b62569972f70ae7dcb0a.diff

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

kadircet accepted this revision. kadircet added a comment. thanks, lgtm. do you have commit access? Comment at: clang/lib/Tooling/ArgumentsAdjusters.cpp:101 // -MF, -MG, -MP, -MT, -MQ, -MD, and -MMD. - if (!Arg.startswith("-M")) { + if (!Arg.startswith("-M")

Re: [PATCH] D76801: [AST] Print a> without extra spaces in C++11 or later.

I completed the bisect, and it is indeed the change in spacing between the `>`s that triggers the problem with the visualizers. That said, I'm still suspicious that the std::map visualizer isn't quite right with how it uses the wild cards and the template parameter placeholder(s), but I don't

[PATCH] D74765: [compiler-rt] Addd FreeBSD arm64 sanitizer support

myfreeweb added a comment. With TBI enabled in the system , HWASAN should also work, I've had it running some time ago Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp:1836 return fsr & FSR_WRITE ? WRITE : READ; -#elif

[PATCH] D78862: [IR] Convert null-pointer-is-valid into an enum attribute

arsenm added a comment. In D78862#2003684 , @arsenm wrote: > FWIW I think this attribute should be replaced with a data layout property, > so this would eventually be removed Also would be address space specific Repository: rG LLVM Github Monorepo

[PATCH] D78655: [HIP] Let lambda be host device by default

hliao added inline comments. Comment at: clang/test/CodeGenCUDA/lambda.cu:83 +void test_resolve(void) { + test_resolve_helper([&](){ overloaded();}); +} We are allowing regular lambda to be used in the device functions. That should be explicitly marked by

[PATCH] D78655: [HIP] Let lambda be host device by default

hliao requested changes to this revision. hliao added a comment. This revision now requires changes to proceed. In D78655#1997491 , @tra wrote: > Summoning @rsmith as I'm sure that there are interesting corner cases in > lambda handling that we didn't

[PATCH] D78862: [IR] Convert null-pointer-is-valid into an enum attribute

arsenm added a comment. FWIW I think this attribute should be replaced with a data layout property, so this would eventually be removed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78862/new/ https://reviews.llvm.org/D78862

[PATCH] D78457: [analyzer][Z3-refutation] Fix a refutation BugReporterVisitor bug

steakhal updated this revision to Diff 260108. steakhal retitled this revision from "[analyzer][Z3-refutation] Fix refutation BugReporterVisitor bug and refactor" to "[analyzer][Z3-refutation] Fix a refutation BugReporterVisitor bug". steakhal edited the summary of this revision. steakhal added

[PATCH] D78862: [IR] Convert null-pointer-is-valid into an enum attribute

nikic updated this revision to Diff 260105. nikic added a comment. Herald added subscribers: cfe-commits, Kayjukh, frgossen, grosul1, Joonsoo, liufengdb, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, jpienaar, rriddle, mehdi_amini, asbirlea, jfb, george.burgess.iv.

[PATCH] D78704: [analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor

steakhal updated this revision to Diff 260104. steakhal edited the summary of this revision. steakhal added a comment. - added `GTEST_SKIP` FIXME comment - reformatted the summary of the patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78704/new/ https://reviews.llvm.org/D78704

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

aeubanks marked an inline comment as done. aeubanks added inline comments. Comment at: clang/lib/Tooling/ArgumentsAdjusters.cpp:101 // -MF, -MG, -MP, -MT, -MQ, -MD, and -MMD. - if (!Arg.startswith("-M")) { + if (!Arg.startswith("-M") && Arg != "/showIncludes") {

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

aeubanks updated this revision to Diff 260103. aeubanks added a comment. Handle /showIncludes:user Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78836/new/ https://reviews.llvm.org/D78836 Files:

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

kadircet added inline comments. Comment at: clang/lib/Tooling/ArgumentsAdjusters.cpp:101 // -MF, -MG, -MP, -MT, -MQ, -MD, and -MMD. - if (!Arg.startswith("-M")) { + if (!Arg.startswith("-M") && Arg != "/showIncludes") { AdjustedArgs.push_back(Args[i]);

[PATCH] D78655: [HIP] Let lambda be host device by default

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/test/CodeGenCUDA/lambda.cu:16-26 +template +__global__ void g(F f) { f(); } + +template +void h(F f) { g<<<1,1>>>(f); } + +__device__ int a; tra wrote: > yaxunl wrote: > >

[PATCH] D78655: [HIP] Let lambda be host device by default

yaxunl updated this revision to Diff 260094. yaxunl added a comment. Added more tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78655/new/ https://reviews.llvm.org/D78655 Files: clang/lib/Sema/SemaCUDA.cpp clang/test/CodeGenCUDA/lambda.cu clang/test/SemaCUDA/lambda.cu

[PATCH] D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics

LukeGeeson marked an inline comment as done. LukeGeeson added inline comments. Comment at: llvm/lib/Target/ARM/ARMInstrNEON.td:4846 + VDOT { + let hasNoSchedulingInfo = 1; + dmgreen wrote: > I don't think that hasNoSchedulingInfo is necessarily the best

[PATCH] D78848: [clangd] Disable delayed template parsing in the main file

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78848/new/ https://reviews.llvm.org/D78848

[PATCH] D78833: [clangd] Disable all dependency outputs

This revision was automatically updated to reflect the committed changes. Closed by commit rG294b9d43cae7: [clangd] Disable all dependency outputs (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78833/new/

[clang-tools-extra] a940a24 - [clangd] Disable dependency-output lit test on windows

Author: Kadir Cetinkaya Date: 2020-04-25T13:55:38+02:00 New Revision: a940a246f5e14a8fd44586f609b8a675eb949469 URL: https://github.com/llvm/llvm-project/commit/a940a246f5e14a8fd44586f609b8a675eb949469 DIFF:

[clang-tools-extra] 294b9d4 - [clangd] Disable all dependency outputs

Author: Kadir Cetinkaya Date: 2020-04-25T13:51:33+02:00 New Revision: 294b9d43cae77ea15453ec82203368903db4f538 URL: https://github.com/llvm/llvm-project/commit/294b9d43cae77ea15453ec82203368903db4f538 DIFF:

[PATCH] D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics

dmgreen added inline comments. Comment at: llvm/lib/Target/ARM/ARMInstrNEON.td:4846 + VDOT { + let hasNoSchedulingInfo = 1; + I don't think that hasNoSchedulingInfo is necessarily the best way to handle this. That flag is intended for instructions that

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 added a comment. @whisperity Thanks for the review :3 Comment at: clang/docs/analyzer/user-docs/CrossTranslationUnit.rst:111-114 + -Xclang -analyzer-config -Xclang experimental-enable-naive-ctu-analysis=true \ + -Xclang -analyzer-config -Xclang ctu-dir=. \

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 updated this revision to Diff 260078. gamesh411 marked 15 inline comments as done. gamesh411 added a comment. Fix issues in documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files:

[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

sylvestre.ledru added a comment. FYI, in Mozilla build of clang-format, we reverted this change. It was causing more issues than fixes. https://bugzilla.mozilla.org/show_bug.cgi?id=1629853 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69573/new/

[PATCH] D74299: [clang-tidy] extend tests of run-clang-tidy

AlexanderLanin added a comment. *ping* CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74299/new/ https://reviews.llvm.org/D74299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org