[PATCH] D79393: [clang][codegen] Refactor argument loading in function prolog. NFC.

hliao created this revision. hliao added reviewers: rjmccall, kerbowa, yaxunl. Herald added subscribers: cfe-commits, nhaehnle, jvesely. Herald added a project: clang. hliao abandoned this revision. - Skip copying function arguments and unnecessary casting by using them directly.

[PATCH] D78660: [SemaObjC] Add a warning for dictionary literals with duplicate keys

rjmccall added a comment. Some part of me wishes we could use expression profiling or ODR hashing or something like that for this, but I guess the semantics we're going for don't really match. Comment at: clang/lib/Sema/SemaExprObjC.cpp:948 +checkOneKey(IntegralKeys,

[PATCH] D79276: [FileCheck] Support comment directives

jdenny updated this revision to Diff 261998. jdenny added a comment. Fixed a missed rename in the test code in the last update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79276/new/ https://reviews.llvm.org/D79276 Files: clang/test/CodeGen/default-address-space.c

[PATCH] D72281: [Matrix] Add matrix type to Clang.

rjmccall added a comment. The test cases for function template partial specialization would look something like this: template using matrix = T __attribute__((matrix_type(R, C))); template struct selector {}; template selector<0> use_matrix(matrix m) {} template

[PATCH] D72281: [Matrix] Add matrix type to Clang.

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:2112 + llvm::APSInt ArgRows(S.Context.getTypeSize(S.Context.IntTy), + ConstantMatrixArg->getNumRows()); + Result = DeduceNonTypeTemplateArgument(

[PATCH] D79388: [clang-format] Fix AlignConsecutive on PP blocks

JakeMerdichAMD created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently the 'AlignConsecutive*' options incorrectly align across elif and else statements, even if they are very far away and across unrelated preprocessor macros. This failed since on

[PATCH] D79213: [hip] Add noalias on restrict qualified coerced hip pointers

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2556-2563 + // Restrict qualified HIP pointers that were coerced to global pointers + // can be marked with the noalias attribute. + if (isCoercedHIPGlobalPointer(*this, getLangOpts(), ArgI,

[PATCH] D79378: PR34581: Don't remove an 'if (p)' guarding a call to 'operator delete(p)' under -Oz.

rjmccall added a comment. Is it reasonable to figure out ahead of time that we can skip the null check completely? It'd be kindof nice to also take advantage of this at -O0 whenever we don't have real work to do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78655: [HIP] Add -fhip-lambda-host-device

rjmccall added a comment. I agree with Richard that just making lambdas HD by default in all modes seems like the right rule. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78655/new/ https://reviews.llvm.org/D78655 ___ cfe-commits mailing

[clang] d75a6e9 - [CUDA][HIP] Fix empty ctor/dtor check for union

Author: Yaxun (Sam) Liu Date: 2020-05-04T21:52:04-04:00 New Revision: d75a6e93ae99bfcd67219454307da56ebd155d45 URL: https://github.com/llvm/llvm-project/commit/d75a6e93ae99bfcd67219454307da56ebd155d45 DIFF:

[PATCH] D79367: [CUDA][HIP] Fix empty ctor/dtor check for union

This revision was automatically updated to reflect the committed changes. Closed by commit rGd75a6e93ae99: [CUDA][HIP] Fix empty ctor/dtor check for union (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79236: [docs] Regenerate DiagnosticsReference.rst

rjmccall added a comment. In D79236#2019184 , @rsmith wrote: > In D79236#2019005 , @rjmccall wrote: > > > Okay. So it doesn't just run `ninja docs-clang-html`? That's unfortunate. > > > It didn't last time I

[PATCH] D78655: [HIP] Add -fhip-lambda-host-device

rsmith added a comment. There are two behaviors that seem to make sense: - Treat lambdas as implicitly HD (like constexpr functions) in all CUDA / HIP language modes. I don't think it makes sense for lambdas to become implicitly HD in C++17 simply because they become implicitly `constexpr`,

[PATCH] D66831: [ObjC] Fix type checking for qualified id block parameters.

jyknight added a comment. In D66831#2019125 , @vsapsai wrote: > Agree that is a mistake in `NSItemProvider` API. The solution I offer is not > to revert the change but to add cc1 flag > `-fcompatibility-qualified-id-block-type-checking` and to make the

[PATCH] D79265: Let normalize() for posix style convert backslash to slash unconditionally.

thakis updated this revision to Diff 261980. thakis added a comment. restore else CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79265/new/ https://reviews.llvm.org/D79265 Files: clang/test/Lexer/case-insensitive-include-ms.c llvm/lib/Support/Path.cpp

[PATCH] D79121: Add nomerge function attribute to clang

rsmith added inline comments. Comment at: clang/lib/Sema/SemaStmtAttr.cpp:178 +return true; + return llvm::any_of(S->children(), hasCallExpr); +} This will recurse into too much (eg, the bodies of lambdas and blocks, and unevaluated operands). It would be

[PATCH] D79265: Let normalize() for posix style convert backslash to slash unconditionally.

thakis added a comment. In D79265#2018770 , @compnerd wrote: > What happens if you encounter a `"\t"` as a string? This would convert that > to a `"/t"` would it not? Although, I suppose that in practice the treatment > of escaped characters is not

[PATCH] D74813: Function block naming - add hash of parameter type to end of block name

alexbdv updated this revision to Diff 261978. alexbdv added a comment. Herald added subscribers: kerbowa, nhaehnle, jvesely. Updating tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74813/new/ https://reviews.llvm.org/D74813 Files:

[PATCH] D74668: [Clang][BPF] implement __builtin_btf_type_id() builtin function

yonghong-song updated this revision to Diff 261976. yonghong-song edited the summary of this revision. yonghong-song added a comment. Herald added subscribers: ormris, hiraditya, mgorny. add second argument to __builtin_btf_type_id() to indicate whether a relocation should be generated or not.

[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

yonghong-song updated this revision to Diff 261977. yonghong-song edited the summary of this revision. yonghong-song added a comment. add second argument to __builtin_btf_type_id(var, flag) to indicate whether a .BTF.ext relocation should be generated or not. flag == 0, no reloc, flag == 1,

[PATCH] D79236: [docs] Regenerate DiagnosticsReference.rst

rsmith added a comment. In D79236#2019005 , @rjmccall wrote: > Okay. So it doesn't just run `ninja docs-clang-html`? That's unfortunate. It didn't last time I looked into this. And http://clang.llvm.org/docs/DiagnosticsReference.html shows the

[PATCH] D79121: Add nomerge function attribute to clang

zequanwu added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:611 void CodeGenFunction::EmitAttributedStmt(const AttributedStmt ) { + for (const auto *A: S.getAttrs()) +if (A->getKind() == attr::NoMerge) { rnk wrote: > Can we use S.hasAttr, or

[PATCH] D79121: Add nomerge function attribute to clang

zequanwu updated this revision to Diff 261973. zequanwu marked 10 inline comments as done. zequanwu added a comment. To keep it simple, `nomerge` attribute should not be applied to decl statement. Since label statement calls `ProcessDeclAttributeList` to handle attributes, label statement

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

sconstab updated this revision to Diff 261968. sconstab marked 9 inline comments as done. sconstab added a comment. Herald added a subscriber: mgrang. Addressed the previously unaddressed comments, as pointed out by @craig.topper. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75936/new/

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

sconstab added inline comments. Comment at: llvm/lib/Target/X86/X86LoadValueInjectionLoadHardening.cpp:322 + DenseSet> GadgetEdgeSet; + auto AnalyzeUse = [&](NodeAddr Use, MachineInstr *MI) { +assert(!(Use.Addr->getFlags() & NodeAttrs::PhiRef));

[PATCH] D79380: [clang-tidy] In TransformerClangTidyCheck, support option SourceNamingStyle.

ymandel created this revision. ymandel added a reviewer: gribozavr2. Herald added a subscriber: xazax.hun. Herald added a project: clang. The new option allows the user to specify which file naming convention is used by the source code ('llvm' or 'google'). Repository: rG LLVM Github Monorepo

[PATCH] D79378: PR34581: Don't remove an 'if (p)' guarding a call to 'operator delete(p)' under -Oz.

rsmith created this revision. rsmith added reviewers: davide, dnsampaio, rjmccall. Herald added a subscriber: hiraditya. Herald added projects: clang, LLVM. This transformation is correct for a builtin call to 'free(p)', but not for 'operator delete(p)'. There is no guarantee that a user

[PATCH] D66831: [ObjC] Fix type checking for qualified id block parameters.

vsapsai added a comment. Agree that is a mistake in `NSItemProvider` API. The solution I offer is not to revert the change but to add cc1 flag `-fcompatibility-qualified-id-block-type-checking` and to make the driver for Darwin platforms to add this flag. Thus developers using Apple SDKs will

[PATCH] D79276: [FileCheck] Support comment directives

jdenny added inline comments. Comment at: llvm/docs/CommandGuide/FileCheck.rst:57 + By default, FileCheck ignores any occurrence in ``match-filename`` of any check + prefix if it is preceded on the same line by "``COM:``" or "``RUN:``". See the + section `The "COM:"

[PATCH] D79276: [FileCheck] Support comment directives

jdenny updated this revision to Diff 261962. jdenny marked 11 inline comments as done. jdenny added a comment. Addressed most reviewer comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79276/new/ https://reviews.llvm.org/D79276 Files: clang/test/CodeGen/default-address-space.c

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

jasonliu marked 2 inline comments as done. jasonliu added inline comments. Comment at: clang/test/CodeGen/ppc32-dwarf.c:2 +// RUN: %clang_cc1 -triple powerpc-unknown-aix -emit-llvm %s -o - | FileCheck %s +// RUN: %clang_cc1 -triple powerpc-unknown-unknown -emit-llvm %s -o - |

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

jasonliu marked 2 inline comments as done. jasonliu added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4317 + if (isAggregateTypeForABI(RetTy)) +return getNaturalAlignIndirect(RetTy); + Xiangling_L wrote: > This method uses the ABI

[PATCH] D79244: [Sema] Put existing warning under -Wexcess-initializers

efriedma added a comment. Should we stick ext_excess_initializers_in_char_array_initializer and ext_initializer_string_for_char_array_too_long in the same warning group? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79244/new/

[PATCH] D78659: Add nomerge function attribute to supress tail merge optimization in simplifyCFG

asbirlea accepted this revision. asbirlea added a comment. This revision is now accepted and ready to land. Thank you for adding this! Please update first sentence in the description to: We want to add a way to avoid merging identical calls so as to keep the separate debug-information for

[PATCH] D79236: [docs] Regenerate DiagnosticsReference.rst

rjmccall added a comment. In D79236#2018891 , @rsmith wrote: > In D79236#2018812 , @rjmccall wrote: > > > In D79236#2018661 , @rsmith wrote: > > > > > We do generate this

[PATCH] D79336: [analyzer] Generalize bitwise OR rules for ranges

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:77 + assert(!isEmpty()); + // NOTE: It's a shame that we can't implement 'getMaxValue' without scanning + // the whole tree to get to the last element.

[PATCH] D79367: [CUDA][HIP] Fix empty ctor/dtor check for union

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Nice! Thank you for the patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79367/new/ https://reviews.llvm.org/D79367 ___ cfe-commits

[PATCH] D79372: [clang-format] [PR45126] Help text is missing all available formats

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, sammccall, mitchell-stellar. MyDeveloperDay added projects: clang, clang-format. https://bugs.llvm.org/show_bug.cgi?id=45126 GNU and Microsoft styles are built in supported styles but are not displayed in the help

[PATCH] D79213: [hip] Add noalias on restrict qualified coerced hip pointers

kerbowa added a comment. In D79213#2018820 , @hliao wrote: > Any more comments? As this should be a performance-critical issue, shall we > get conclusion and make progress for the next step? We applied this current version of the patch internally for

[PATCH] D79236: [docs] Regenerate DiagnosticsReference.rst

rsmith added a comment. In D79236#2018812 , @rjmccall wrote: > In D79236#2018661 , @rsmith wrote: > > > We do generate this document with tblgen already. The problem is that it's > > not automatically regenerated

[PATCH] D79054: [NFC] Improve documentation for -i and update example git one liner

efriedma added a comment. We should probably encourage people to use git-clang-format with git repositories. It naturally doesn't have this sort of fragility because it integrates with the repository more tightly. Comment at: clang/tools/clang-format/clang-format-diff.py:41

[PATCH] D79344: [cuda] Start diagnosing variables with bad target.

tra added a comment. In D79344#2018693 , @hliao wrote: > OK, I will add one option, But, do we turn it on by default or off? As a rule of thumb, if it's an experimental feature, then the default would be off. For a change which should be the default,

[PATCH] D79367: [CUDA][HIP] Fix empty ctor/dtor check for union

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall. union ctor does not call ctors of its data members. union dtor does not call dtors of its data members. Also union does not have base class. https://godbolt.org/z/8RxZeG Currently when clang checks whether union has an empty

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4179 + // This is calculated from the LLVM and GCC tables and verified + // against gcc output. AFAIK all ABIs use the same encoding. + Minor comment about comment style: Though I

[PATCH] D76646: Rename/refactor isIntegerConstantExpression to getIntegerConstantExpression

dblaikie added a comment. Herald added a reviewer: aaron.ballman. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76646/new/ https://reviews.llvm.org/D76646 ___ cfe-commits mailing list

[PATCH] D79121: Add nomerge function attribute to clang

rnk added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:611 void CodeGenFunction::EmitAttributedStmt(const AttributedStmt ) { + for (const auto *A: S.getAttrs()) +if (A->getKind() == attr::NoMerge) { Can we use S.hasAttr, or does that not exist

[PATCH] D79336: [analyzer] Generalize bitwise OR rules for ranges

vsavchenko marked 3 inline comments as done. vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:77 + assert(!isEmpty()); + // NOTE: It's a shame that we can't implement 'getMaxValue' without scanning + // the whole

[PATCH] D79213: [hip] Add noalias on restrict qualified coerced hip pointers

hliao added a comment. Any more comments? As this should be a performance-critical issue, shall we get conclusion and make progress for the next step? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79213/new/ https://reviews.llvm.org/D79213

[PATCH] D79236: [docs] Regenerate DiagnosticsReference.rst

rjmccall added a comment. In D79236#2018661 , @rsmith wrote: > In D79236#2015982 , @rjmccall wrote: > > > There's no good reason for this file to exist; documenting the warning > > options is useful, but the file

[PATCH] D79337: Silence warnings when compiling x86 with latest MSVC

aganea added a comment. Will do, thank you for your time! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79337/new/ https://reviews.llvm.org/D79337 ___ cfe-commits mailing list

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

echristo updated this revision to Diff 261928. echristo edited the summary of this revision. echristo added a comment. Herald added a subscriber: zzheng. Add a testcase with opt and command line option so we can enable it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79265: Let normalize() for posix style convert backslash to slash unconditionally.

compnerd added a comment. What happens if you encounter a `"\t"` as a string? This would convert that to a `"/t"` would it not? Although, I suppose that in practice the treatment of escaped characters is not important. I think I still prefer the `} else {` here over the early return.

[PATCH] D79337: Silence warnings when compiling x86 with latest MSVC

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, this lgtm. If you could split this up into two commits before landing it, I'd appreciate it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79344: [cuda] Start diagnosing variables with bad target.

hliao added a comment. In D79344#2018683 , @tra wrote: > In D79344#2018628 , @hliao wrote: > > > In D79344#2018561 , @tra wrote: > > > > > This has a good chance of breaking

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

mibintc updated this revision to Diff 261921. mibintc added a comment. I fixed the issues that @rjmccall mentioned. I don't yet have an answer for @scanon, need to get back to you about that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78750: [SveEmitter] Add builtins for svdupq and svdupq_lane

sdesmalen added a comment. I have reverted the patch in the meantime Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78750/new/ https://reviews.llvm.org/D78750 ___ cfe-commits mailing list

[PATCH] D78750: [SveEmitter] Add builtins for svdupq and svdupq_lane

sdesmalen added a comment. In D78750#2018673 , @thakis wrote: > Looks like this breaks check-clang on Windows: > http://45.33.8.238/win/14483/step_7.txt > > And some other bots: > >

[clang] 90f3f62 - Revert "[SveEmitter] Add builtins for svdupq and svdupq_lane"

Author: Sander de Smalen Date: 2020-05-04T21:31:55+01:00 New Revision: 90f3f62cb087782fe2608e95d686c29067281b6e URL: https://github.com/llvm/llvm-project/commit/90f3f62cb087782fe2608e95d686c29067281b6e DIFF:

[PATCH] D78750: [SveEmitter] Add builtins for svdupq and svdupq_lane

thakis added a comment. Looks like this breaks check-clang on Windows: http://45.33.8.238/win/14483/step_7.txt And some other bots: http://lab.llvm.org:8011/builders/clang-cmake-x86_64-sde-avx512-linux/builds/37883/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Aacle_sve_dupq.c

[PATCH] D78190: Add Bfloat IR type

fpetrogalli added a comment. Hi @stuij, thank you for working on this! Admittedly, I don't know much about the Asm parser, but I have left some comments anyway. 1. Shouldn't we test also that the parser is happy with the following expressions? bfloat * %... = fadd %..., %... similar

[PATCH] D79274: Fix template class debug info for Visual Studio visualizers

rnk added a comment. I think testing it is a matter of adding later C++ standard versions to the existing test here: `../clang/test/CodeGenCXX/debug-info-codeview-display-name.cpp` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79274/new/ https://reviews.llvm.org/D79274

[PATCH] D79344: [cuda] Start diagnosing variables with bad target.

tra added a comment. In D79344#2018628 , @hliao wrote: > In D79344#2018561 , @tra wrote: > > > This has a good chance of breaking existing code. It would be great to add > > an escape hatch option to revert to the

[PATCH] D79357: [SveEmitter] Add builtins for svdup and svindex

efriedma added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:1050 def SVCOMPACT: SInst<"svcompact[_{d}]", "dPd", "ilUiUlfd", MergeNone, "aarch64_sve_compact">; -// SVDUP_LANE(to land in D78750) +def SVDUP_LANE :

[PATCH] D79344: [cuda] Start diagnosing variables with bad target.

hliao marked an inline comment as done. hliao added inline comments. Comment at: clang/lib/Sema/SemaCUDA.cpp:156 + if (VD->getType()->isCUDADeviceBuiltinSurfaceType() || + VD->getType()->isCUDADeviceBuiltinTextureType()) +return CFT_HostDevice; yaxunl

[PATCH] D79344: [cuda] Start diagnosing variables with bad target.

yaxunl added inline comments. Comment at: clang/test/SemaCUDA/variable-target.cu:42 + return 0; +} hliao wrote: > yaxunl wrote: > > we need to have a test to check captured local host variable is allowed in > > device lambda. > > > > we need to have some test

[PATCH] D78232: [OPENMP50]Codegen for scan directive in simd loops.

ABataev updated this revision to Diff 261917. ABataev added a comment. Rebase and simplify Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78232/new/ https://reviews.llvm.org/D78232 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D79236: [docs] Regenerate DiagnosticsReference.rst

rsmith added a comment. In D79236#2015982 , @rjmccall wrote: > There's no good reason for this file to exist; documenting the warning > options is useful, but the file should be generated as an intermediate output > of the documentation build and then

[PATCH] D79344: [cuda] Start diagnosing variables with bad target.

hliao marked an inline comment as done. hliao added inline comments. Comment at: clang/test/SemaCUDA/variable-target.cu:6 + +static int gvar; +// expected-note@-1{{'gvar' declared here}} tra wrote: > The current set of tests only verifies access of host variable

[clang] 9fbf998 - Reject operations between vectors and enum types.

Author: Erich Keane Date: 2020-05-04T13:11:24-07:00 New Revision: 9fbf9989a2bf0edfbe1b482de470dcccd1108e24 URL: https://github.com/llvm/llvm-project/commit/9fbf9989a2bf0edfbe1b482de470dcccd1108e24 DIFF: https://github.com/llvm/llvm-project/commit/9fbf9989a2bf0edfbe1b482de470dcccd1108e24.diff

[PATCH] D79344: [cuda] Start diagnosing variables with bad target.

hliao marked an inline comment as done. hliao added inline comments. Comment at: clang/test/SemaCUDA/variable-target.cu:42 + return 0; +} yaxunl wrote: > we need to have a test to check captured local host variable is allowed in > device lambda. > > we need

[PATCH] D72281: [Matrix] Add matrix type to Clang.

fhahn updated this revision to Diff 261915. fhahn added a comment. Add missing early exit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72281/new/ https://reviews.llvm.org/D72281 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D78750: [SveEmitter] Add builtins for svdupq and svdupq_lane

This revision was automatically updated to reflect the committed changes. sdesmalen marked an inline comment as done. Closed by commit rG6b90a6887d25: [SveEmitter] Add builtins for svdupq and svdupq_lane (authored by sdesmalen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79118: Implement _ExtInt ABI for all ABIs in Clang, enable type for ABIs

erichkeane updated this revision to Diff 261820. erichkeane marked 5 inline comments as done. Herald added a reviewer: jdoerfert. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79118/new/ https://reviews.llvm.org/D79118 Files: clang/lib/Basic/Targets/AArch64.h

[PATCH] D72281: [Matrix] Add matrix type to Clang.

fhahn updated this revision to Diff 261911. fhahn marked 9 inline comments as done. fhahn added a comment. Address comments, thanks: - Use MatrixType as base class for ConstantMatrixType and DependentSizedMatrixType. - Handle both ConstantMatrixType and DependentSizedMatrixType arguments in

[PATCH] D79118: Implement _ExtInt ABI for all ABIs in Clang, enable type for ABIs

rjmccall added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4938 +if (EIT->getNumBits() > 128) + return getNaturalAlignIndirect(Ty, /*ByVal=*/true); + erichkeane wrote: > rjmccall wrote: > > Does this need to consider the

[PATCH] D79344: [cuda] Start diagnosing variables with bad target.

hliao added a comment. In D79344#2018561 , @tra wrote: > This has a good chance of breaking existing code. It would be great to add an > escape hatch option to revert to the old behavior if we run into problems. > The change is relatively simple, so

[PATCH] D72281: [Matrix] Add matrix type to Clang.

fhahn marked an inline comment as done. fhahn added inline comments. Comment at: clang/include/clang/Basic/TypeNodes.td:73 def ExtVectorType : TypeNode; +def MatrixType : TypeNode; def FunctionType : TypeNode; rjmccall wrote: > I think some parts of your life

[PATCH] D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range

MyDeveloperDay added a comment. If we are concerned about affecting other workflows about if we added a new command line option to trigger your behavior? I'd also like to see some lit tests in clang/test/Format to exercise the -lines so we really understand its usage I also wonder if anyone

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

scanon added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3182 +enabled for the translation unit with the ``-fassociative-math`` flag. +The pragma can take two values: ``on`` and ``off``. + mibintc wrote: > scanon wrote: > > rjmccall wrote: > >

[PATCH] D79344: [cuda] Start diagnosing variables with bad target.

tra added a comment. This has a good chance of breaking existing code. It would be great to add an escape hatch option to revert to the old behavior if we run into problems. The change is relatively simple, so reverting it in case something goes wrong should work, too. Up to you.

[PATCH] D79357: [SveEmitter] Add builtins for svdup and svindex

sdesmalen created this revision. sdesmalen added reviewers: efriedma, SjoerdMeijer, kmclaughlin. Herald added subscribers: arphaman, tschuett. sdesmalen added a parent revision: D79356: [CodeGen][SVE] Add patterns for whole vector predicate select. https://reviews.llvm.org/D79357 Files:

[PATCH] D70073: [ConstExprPreter] Implemented function calls and if statements

nand added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70073/new/ https://reviews.llvm.org/D70073 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79358: [analyzer] CERT: STR37-C

zukatsinadze created this revision. zukatsinadze added reviewers: NoQ, Charusso, Szelethus. zukatsinadze added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, mgorny. This

[PATCH] D79334: [clang-tidy]: Add cert-str34-c alias for bugprone-signed-char-misuse.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignedCharMisuseCheck.cpp:33 + CharTypdefsToIgnoreList(Options.get("CharTypdefsToIgnore", "")), + CertSTR34C(Options.get("CertSTR34C", false)) {} Same request for

[PATCH] D79344: [cuda] Start diagnosing variables with bad target.

yaxunl added inline comments. Comment at: clang/lib/Sema/SemaCUDA.cpp:156 + if (VD->getType()->isCUDADeviceBuiltinSurfaceType() || + VD->getType()->isCUDADeviceBuiltinTextureType()) +return CFT_HostDevice; We may need to mark constexpr variables as

[PATCH] D79344: [cuda] Start diagnosing variables with bad target.

hliao updated this revision to Diff 261904. hliao added a comment. Reformatting test code following pre-merge checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79344/new/ https://reviews.llvm.org/D79344 Files:

[PATCH] D78756: [SveEmitter] Add builtins for svreinterpret

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78756/new/ https://reviews.llvm.org/D78756 ___ cfe-commits mailing list

[clang] 6b90a68 - [SveEmitter] Add builtins for svdupq and svdupq_lane

Author: Sander de Smalen Date: 2020-05-04T20:38:47+01:00 New Revision: 6b90a6887d25e3375bb916a3ed09f7ccec819d0c URL: https://github.com/llvm/llvm-project/commit/6b90a6887d25e3375bb916a3ed09f7ccec819d0c DIFF:

[PATCH] D79354: [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, sammccall, marejde, mitchell-stellar. MyDeveloperDay added projects: clang, clang-format. https://bugs.llvm.org/show_bug.cgi?id=34574 https://bugs.llvm.org/show_bug.cgi?id=38401 template class [[nodiscard]]

[PATCH] D78756: [SveEmitter] Add builtins for svreinterpret

sdesmalen updated this revision to Diff 261892. sdesmalen added a comment. - Added FIXME in CGBuiltins for big-endian svreinterpret. - Added diagnostic in arm_sve.h that big-endian is not yet supported. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78756/new/

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

mibintc marked an inline comment as done. mibintc added a comment. A reply to @scanon Comment at: clang/docs/LanguageExtensions.rst:3182 +enabled for the translation unit with the ``-fassociative-math`` flag. +The pragma can take two values: ``on`` and ``off``. +

[PATCH] D79113: Revert "Remove false positive in AvoidNonConstGlobalVariables."

vingeldal added a comment. In D79113#2016294 , @aaron.ballman wrote: > I only see a comment on the issue, but not that the issue was resolved in > favor of that comment (unless I've missed something). If the issue gets > resolved in the direction that

[clang] 54fa46a - [SveEmitter] Add builtins for Int & FP reductions

Author: Sander de Smalen Date: 2020-05-04T19:50:16+01:00 New Revision: 54fa46aa0a82bd281d0ba31fad69a227de4a622c URL: https://github.com/llvm/llvm-project/commit/54fa46aa0a82bd281d0ba31fad69a227de4a622c DIFF:

[PATCH] D77542: [PowerPC] Treat 'Z' inline asm constraint as a true memory constraint

lei accepted this revision as: lei. lei added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77542/new/ https://reviews.llvm.org/D77542

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

rjmccall added a comment. Just minor requests now. Comment at: clang/docs/LanguageExtensions.rst:3177 +Both floating point reassociation and floating point contraction can be +controlled with this pragma. +``#pragma clang fp reassoc`` allows control over the reassociation

[PATCH] D79344: [cuda] Start diagnosing variables with bad target.

hliao added a comment. That test code just passed compilation on clang trunk if only assembly code is generated, https://godbolt.org/z/XYjRcT. But NVCC generates errors on all cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79344/new/

[PATCH] D79344: [cuda] Start diagnosing variables with bad target.

hliao created this revision. hliao added reviewers: tra, rjmccall, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. hliao added a comment. That test code just passed compilation on clang trunk if only assembly code is generated, https://godbolt.org/z/XYjRcT. But

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

scanon added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3182 +enabled for the translation unit with the ``-fassociative-math`` flag. +The pragma can take two values: ``on`` and ``off``. + rjmccall wrote: > Do you want to add an example here?

[PATCH] D78756: [SveEmitter] Add builtins for svreinterpret

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7880 +return Builder.CreateBitCast(Val, Ty); + } + efriedma wrote: > sdesmalen wrote: > > efriedma wrote: > > > sdesmalen wrote: > > > > efriedma wrote: > > > > > I'm vaguely

[PATCH] D78750: [SveEmitter] Add builtins for svdupq and svdupq_lane

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78750/new/ https://reviews.llvm.org/D78750 ___ cfe-commits mailing list

  1   2   >