[PATCH] D79548: Fix false positive with warning -Wnon-c-typedef-for-linkage

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79548/new/ https://reviews.llvm.org/D79548

[PATCH] D79548: Fix false positive with warning -Wnon-c-typedef-for-linkage

rtrieu created this revision. rtrieu added a reviewer: rsmith. Herald added a project: clang. Fix false positives for -Wnon-c-typedef-for-linkage Implicit methods for structs can confuse the warning, so exclude checking the Decl's that are implicit. Implicit Decl's for lambdas still need to be

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

hyd-dev updated this revision to Diff 262541. hyd-dev retitled this revision from "[clang-tidy] Add --color-diagnostics command line option and ColorDiagnostics option to control colors in diagnostics" to "[clang-tidy] Add --use-color command line option and UseColor option to control colors in

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

asmith added a comment. really happy for native bfloat support! Comment at: clang/include/clang/AST/ASTContext.h:965 CanQualType HalfTy; // [OpenCL 6.1.1.1], ARM NEON + CanQualType BFloat16Ty; // ARM NEON CanQualType Float16Ty; // C11 extension ISO/IEC TS 18661-3

[PATCH] D79477: [clang-tidy] Add --color-diagnostics command line option and ColorDiagnostics option to control colors in diagnostics

hyd-dev updated this revision to Diff 262537. hyd-dev added a comment. Rename `--color-diagnostics` and `ColorDiagnostics` to `--use-color` and `UseColor`. Also, improve the comment of `UseColor` option and the help text of `--use-color`, and add `cl::init(false)` to `cl::opt UseColor`.

[PATCH] D62368: Add vendor identity check for Hygon Dhyana processor in Scudo

fanjinke updated this revision to Diff 262529. fanjinke retitled this revision from "Add support for Hygon Dhyana processor" to "Add vendor identity check for Hygon Dhyana processor in Scudo". fanjinke edited the summary of this revision. fanjinke added a comment. Changelog: v3: Remove the

[PATCH] D79059: Fix and re-submit D78534 - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c9230dad169: Reland [libclang] Install both libclang.a and libclang.so when… (authored by zhuhan0, committed by smeenai). Changed prior to commit: https://reviews.llvm.org/D79059?vs=262506=262530#toc

[PATCH] D79059: Fix and re-submit D78534 - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

smeenai added a comment. Committed. Please let me know of any buildbot failure emails you receive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79059/new/ https://reviews.llvm.org/D79059 ___

[clang] 0c9230d - Reland [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

Author: Han Zhu Date: 2020-05-06T19:33:58-07:00 New Revision: 0c9230dad1692bc3d8f1ce2dddae413a115f2532 URL: https://github.com/llvm/llvm-project/commit/0c9230dad1692bc3d8f1ce2dddae413a115f2532 DIFF: https://github.com/llvm/llvm-project/commit/0c9230dad1692bc3d8f1ce2dddae413a115f2532.diff LOG:

[PATCH] D79059: Fix and re-submit D78534 - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

zhuhan0 added a comment. @smeenai Yes please. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79059/new/ https://reviews.llvm.org/D79059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79531: Make -Wnonportable-include-path ignore drive case on Windows.

thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:2118 +// given drive letter case as correct for the purpose of this warning. +SmallString<128> FixedDriveRealPath; +if

[PATCH] D79504: [Clang] Wrong return type of atomic_is_lock_free

kamleshbhalui updated this revision to Diff 262518. kamleshbhalui added a comment. Addressed @rsmith concerns. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79504/new/ https://reviews.llvm.org/D79504 Files: clang/include/clang/Basic/Builtins.def clang/test/CodeGen/atomic-ops.c

[PATCH] D79534: [clang][WebAssembly] Only expose wait and notify builtins with atomics

sbc100 accepted this revision. sbc100 added a comment. This revision is now accepted and ready to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79534/new/ https://reviews.llvm.org/D79534 ___

[PATCH] D74262: [clang-offload-bundler] Enable handling of partially-linked fat objects

grokos abandoned this revision. grokos added a comment. The partial linking scheme has been found to not work correctly in all cases (it fails when we have libraries with device code only). A new patch will be uploaded which will be based on archive extraction. Repository: rG LLVM Github

[PATCH] D79274: Fix template class debug info for Visual Studio visualizers

rnk added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-codeview-display-name.cpp:10 +// RUN: %clang_cc1 -fblocks -debug-info-kind=limited -gcodeview -emit-llvm %s \ +// RUN: -o - -triple=x86_64-pc-win32 -Wno-new-returns-null -fms-compatibility | \ +//

[PATCH] D79531: Make -Wnonportable-include-path ignore drive case on Windows.

rnk added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:2118 +// given drive letter case as correct for the purpose of this warning. +SmallString<128> FixedDriveRealPath; +if (llvm::sys::path::is_absolute(Name) && It seems like

[PATCH] D79534: [clang][WebAssembly] Only expose wait and notify builtins with atomics

tlively created this revision. tlively added reviewers: aheejin, sunfish. Herald added subscribers: cfe-commits, jfb, jgravelle-google, sbc100, dschuff. Herald added a project: clang. Since the underlying wait and notify instructions are only available when the atomics feature is enabled, it only

[PATCH] D79059: Fix and re-submit D78534 - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

smeenai added a comment. Do you need me to commit this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79059/new/ https://reviews.llvm.org/D79059 ___ cfe-commits mailing list

[PATCH] D79059: Fix and re-submit D78534 - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

zhuhan0 updated this revision to Diff 262506. zhuhan0 added a comment. Address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79059/new/ https://reviews.llvm.org/D79059 Files: clang/cmake/modules/AddClang.cmake Index:

[PATCH] D79531: Make -Wnonportable-include-path ignore drive case on Windows.

thakis created this revision. thakis added a reviewer: hans. Herald added subscribers: llvm-commits, mgorny. Herald added a project: LLVM. See PR45812 for motivation. No explicit test since I couldn't figure out how to get the current disk drive in lower case into a form in lit where I could

[PATCH] D79511: [ObjC] Add compatibility mode for type checking of qualified id block parameters.

vsapsai added inline comments. Comment at: clang/test/SemaObjC/block-type-safety.m:170 +genericBlockWithParam = blockWithParam; +blockWithParam = genericBlockWithParam; // expected-error {{incompatible block pointer types assigning to 'void (^)(NSAllArray *)' from 'void

[PATCH] D78129: Add Marvell ThunderX3T110 support

evandro added a comment. In D78129#2023772 , @joelkevinjones wrote: > list UnsupportedFeatures = !listconcat(SVEUnsupported.F, > PAUnsupported.F); > Agree. Methinks that this is easier to read. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D79274: Fix template class debug info for Visual Studio visualizers

amccarth updated this revision to Diff 262499. amccarth added a comment. Updated an existing test. Thanks for the pointer; I had gotten myself completely confused about the organization of the test directories. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79274/new/

[PATCH] D79274: Fix template class debug info for Visual Studio visualizers

amccarth added a comment. Updated test to validate the change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79274/new/ https://reviews.llvm.org/D79274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79343: [libc++][test] Adjust move_iterator tests to allow C++20

CaseyCarter marked 2 inline comments as done. CaseyCarter added a comment. Format issues addressed. Comment at: libcxx/test/std/iterators/predef.iterators/move.iterators/move.iterator/types.pass.cpp:33 struct DummyIt { - typedef std::forward_iterator_tag iterator_category;

[PATCH] D79522: Allow -fsanitize-minimal-runtime with memtag sanitizer.

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79522/new/ https://reviews.llvm.org/D79522 ___

[PATCH] D79343: [libc++][test] Adjust move_iterator tests to allow C++20

CaseyCarter updated this revision to Diff 262494. CaseyCarter added a comment. clang-format new/changed sections of code per policy. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79343/new/ https://reviews.llvm.org/D79343 Files:

[PATCH] D79526: [CUDA][HIP] Workaround for resolving host device function against wrong-sided function

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall. https://reviews.llvm.org/D77954 caused regressions due to diagnostics in implicit host device functions. The implicit host device functions are often functions in system headers forced to be device host by pragmas. Some of

[PATCH] D79525: [Sema] require -fcf-runtime-abi= for __NSConstantString

nickdesaulniers created this revision. nickdesaulniers added a reviewer: compnerd. Herald added a project: clang. Herald added a subscriber: cfe-commits. commit 81a650ee87eb ("Driver,CodeGen: introduce support for Swift CFString layout") r345222 added support for implicit typedefs for

[PATCH] D79279: Allow volatile parameters to __builtin_mem{cpy,move,set}

jfb added a comment. Here's the RFC: http://lists.llvm.org/pipermail/cfe-dev/2020-May/065385.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79279/new/ https://reviews.llvm.org/D79279 ___

[PATCH] D79054: [NFC] Improve doc string to mention that paths in diff are used as-is

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a77b958e250: [NFC] Improve doc string to mention that paths in diff are used as-is (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 5a77b95 - [NFC] Improve doc string to mention that paths in diff are used as-is

Author: Christopher Tetreault Date: 2020-05-06T15:20:05-07:00 New Revision: 5a77b958e250fbf156474b42ccf5a82e8a36db72 URL: https://github.com/llvm/llvm-project/commit/5a77b958e250fbf156474b42ccf5a82e8a36db72 DIFF:

[PATCH] D78129: Add Marvell ThunderX3T110 support

joelkevinjones added a comment. I don't think it makes sense to combine two unrelated things SVE and PA support into a combined thing. Since we already have UnsupportedFeatures in every sub-target .td file, I think it would be better to instead have: def PAUnsupported : AArch64Unsupported {

[PATCH] D79343: [libc++][test] Adjust move_iterator tests to allow C++20

dexonsmith added a comment. In D79343#2023658 , @CaseyCarter wrote: > I'm not going to reformat *only* my additions per the clang-format > instructions - that would be silly - and I suspect that folks would > clang-format all of the tests if they

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

Anastasia marked 4 inline comments as done. Anastasia added inline comments. Comment at: lib/Sema/SemaCast.cpp:279 + case tok::kw_addrspace_cast: +if (!TypeDependent) { + Op.CheckAddrspaceCast(); mantognini wrote: > Still learning here, so could

[clang] 16c800b - [X86] Remove support for Y0 constraint as an alias for Yz in inline assembly.

Author: Craig Topper Date: 2020-05-06T14:58:53-07:00 New Revision: 16c800b8b7155b531b53da0ca18b81980ac6a45b URL: https://github.com/llvm/llvm-project/commit/16c800b8b7155b531b53da0ca18b81980ac6a45b DIFF: https://github.com/llvm/llvm-project/commit/16c800b8b7155b531b53da0ca18b81980ac6a45b.diff

[PATCH] D79522: Allow -fsanitize-minimal-runtime with memtag sanitizer.

eugenis created this revision. eugenis added a reviewer: pcc. Herald added a subscriber: cryptoad. Herald added a project: clang. MemTag does not have any runtime at the moment, it's strictly code instrumentation. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D79522 Files:

[PATCH] D79515: [CUDA] Enable existing builtins for PTX7.0 as well.

This revision was automatically updated to reflect the committed changes. Closed by commit rG314f99e7d42d: [CUDA] Enable existing builtins for PTX7.0 as well. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79515/new/

[PATCH] D74813: Function block naming - add hash of parameter type to end of block name

alexbdv added a comment. @dexonsmith @erik.pilkington The change is final now, could we get this in ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74813/new/ https://reviews.llvm.org/D74813 ___ cfe-commits mailing list

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

Anastasia added a comment. In D60193#1549806 , @mantognini wrote: > When compiling this I get the following warning: > > clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:1213:10: warning: enumeration > value 'CXXAddrspaceCastExprClass' not handled in

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

Anastasia updated this revision to Diff 262479. Anastasia added a subscriber: jeroen.dobbelaere. Anastasia added a comment. Herald added subscribers: martong, arphaman. Sorry for long latency. I have rebased the patch to the current master and addressed the comments from @mantognini too.

[PATCH] D79054: [NFC] Improve doc string to mention that paths in diff are used as-is

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79054/new/ https://reviews.llvm.org/D79054

[clang] 314f99e - [CUDA] Enable existing builtins for PTX7.0 as well.

Author: Artem Belevich Date: 2020-05-06T14:24:21-07:00 New Revision: 314f99e7d42ded663386190a54b5831dc4a6f3c1 URL: https://github.com/llvm/llvm-project/commit/314f99e7d42ded663386190a54b5831dc4a6f3c1 DIFF:

[clang] 9bb9ff0 - [X86] Remove incomplete support for 'Y' has an inline assembly constraint by itself.

Author: Craig Topper Date: 2020-05-06T14:23:04-07:00 New Revision: 9bb9ff09573cf9178341f76a97e2a85b99cc7ae1 URL: https://github.com/llvm/llvm-project/commit/9bb9ff09573cf9178341f76a97e2a85b99cc7ae1 DIFF: https://github.com/llvm/llvm-project/commit/9bb9ff09573cf9178341f76a97e2a85b99cc7ae1.diff

[PATCH] D79343: [libc++][test] Adjust move_iterator tests to allow C++20

CaseyCarter added a comment. I'm not going to reformat *only* my additions per the clang-format instructions - that would be silly - and I suspect that folks would clang-format all of the tests if they actually wanted them formatted, so I won't format the entire file, either. Repository:

[PATCH] D79515: [CUDA] Enable existing builtins for PTX7.0 as well.

tra updated this revision to Diff 262473. tra added a comment. Updates test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79515/new/ https://reviews.llvm.org/D79515 Files: clang/include/clang/Basic/BuiltinsNVPTX.def

[PATCH] D79401: [clang-format] [PR45639] clang-format splits up the brackets of C++17 attribute [[ ]] when used with the first parameter

MyDeveloperDay added a comment. > You could adapt that code to not break before the second `TT_AttributeSquare` > in `[[` or `]]`; this will have the same effect and generalize. sounds good... let me try that change and see if we like it better Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

scanon added a comment. TS18661-5 is quite vague on what the intended semantics for the pragma are. These pragmas are intended to be bindings of clause 10.4 of IEEE 754, which is also pretty wishy-washy on the whole, but it's worth noting that clause 10 is titled *expression evaluation*

[PATCH] D79510: [PATCH] When pragma FENV_ACCESS is ignored do not modify Sema.CurFPFeatures

This revision was automatically updated to reflect the committed changes. Closed by commit rGe5578013b199: When pragma FENV_ACCESS is ignored do not modify Sema.CurFPFeatures Bug… (authored by mibintc). Changed prior to commit: https://reviews.llvm.org/D79510?vs=262434=262467#toc Repository:

[PATCH] D79515: [CUDA] Enable existing builtins for PTX7.0 as well.

timshen accepted this revision. timshen added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGen/builtins-nvptx-ptx60.cu:6 // RUN: %clang_cc1 -triple nvptx64-unknown-unknown -target-cpu sm_80 \ -// RUN:-fcuda-is-device

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

mibintc added a comment. The ISO C proposal is here http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2407.pdf but the details are in the IEEE standards documents. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78827/new/

[PATCH] D79511: [ObjC] Add compatibility mode for type checking of qualified id block parameters.

jyknight added inline comments. Comment at: clang/test/SemaObjC/block-type-safety.m:170 +genericBlockWithParam = blockWithParam; +blockWithParam = genericBlockWithParam; // expected-error {{incompatible block pointer types assigning to 'void (^)(NSAllArray *)' from

[clang] e557801 - When pragma FENV_ACCESS is ignored do not modify Sema.CurFPFeatures

Author: Melanie Blower Date: 2020-05-06T13:18:59-07:00 New Revision: e5578013b199e142864cbf374b4a143e5d0c184a URL: https://github.com/llvm/llvm-project/commit/e5578013b199e142864cbf374b4a143e5d0c184a DIFF:

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. In D69088#2023114 , @kbarton wrote: > @Meinersbur I missed the RFC and discussion on the cfe-dev mailing list. > Could you post a link here so that it's included in the history? See the collection of links in a previous

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

echristo marked 6 inline comments as done. echristo added a comment. OK, ready again :) Comment at: llvm/test/Transforms/LoopUnroll/FullUnroll.ll:4-6 +; We don't end up deleting the loop, but we remove everything inside of it so checking for any +; reasonable instruction from

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

echristo updated this revision to Diff 262458. echristo added a comment. Update and reduce testcase a bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71687/new/ https://reviews.llvm.org/D71687 Files: clang/test/Misc/loop-opt-setup.c

[PATCH] D79510: [PATCH] When pragma FENV_ACCESS is ignored do not modify Sema.CurFPFeatures

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79510/new/ https://reviews.llvm.org/D79510

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware added a comment. I also tried to compare the exploded graphs, but unfortunately the rewriter Python script crashed on them. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77229/new/ https://reviews.llvm.org/D77229 ___

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

rjmccall added a comment. That's actually really interesting. Is there a paper describing the desired model in more detail? I think the natural interpretation of this pragma is to say that the specific operations written within the pragma are considered to be associative and are therefore

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 added a comment. I can confirm your findings, basically as long as we comment out the new instructions, it will be OK to build. Agree with your changes 1), 2) and 3). 4. this seems does not matter to build, as long as we comment out the new instructions in 5), setting it "1" or "0",

[PATCH] D72281: [Matrix] Add matrix type to Clang.

rjmccall added a comment. In D72281#2023111 , @fhahn wrote: > Ah right, thanks for clarifying. I think I managed to fix the remaining > problems. Previously the patch did not handle DependentSizedMatrixTypes with > non-dependent constant dimensions

[PATCH] D79515: [CUDA] Enable existing builtins for PTX7.0 as well.

tra created this revision. tra added a reviewer: timshen. Herald added subscribers: sanjoy.google, bixia, yaxunl, jholewinski. Herald added a project: clang. I've missed PXT7.0 in D79449 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D79515

[clang] dc4e25d - [CodeGen][ObjC] Don't try to retain a __unsafe_unretained ARC pointer

Author: Akira Hatanaka Date: 2020-05-06T12:47:17-07:00 New Revision: dc4e25d4f238afb171aacb3774e1162c69574a0a URL: https://github.com/llvm/llvm-project/commit/dc4e25d4f238afb171aacb3774e1162c69574a0a DIFF:

[PATCH] D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens

This revision was automatically updated to reflect the committed changes. Closed by commit rGf21c704553a8: clang-format: Add ControlStatementsExceptForEachMacros option to… (authored by DaanDeMeyer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

mibintc added a comment. BTW there is a proposal http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2421.pdf at the ISO C meeting to support some new floating point pragmas including #pragma STDC FENV_ALLOW_ASSOCIATIVE_LAW on-off-switch The committee wants to see an implementation(s) to ensure

[PATCH] D46317: [clang-tidy] New check bugprone-map-subscript-operator-lookup

khuttun added a comment. Any comments on this? Is this checker something that could be part of clang-tidy? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46317/new/ https://reviews.llvm.org/D46317 ___ cfe-commits mailing list

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. I posted a patch to fix the bug reported by @uabelho here https://reviews.llvm.org/D79510 @rjmccall I used check-clang and check-all on D71841 from my linux x86-64 server before submitting, and the testing was clear. Maybe your branch

[PATCH] D79401: [clang-format] [PR45639] clang-format splits up the brackets of C++17 attribute [[ ]] when used with the first parameter

krasimir added a comment. I think we should never break apart the two `[[` and `]]` of attributes. Running that example with `-debug` shows that we consider breaking between the two `[` tokens a valid possibility. - `C=1` means breaking before the token is OK, which is probably computed by

[PATCH] D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens

DaanDeMeyer added a comment. I pushed the commit to github. Thanks for the help! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78869/new/ https://reviews.llvm.org/D78869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79496: [clangd] Fix AddUsing tweak for out-of-line functions.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:2673 +void foo::fun() { + one::two::f^f(); +})cpp", IIUC, before this patch, the

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:588 + // AnyX2 means that two expressions marked as `Any` are met in code, + // and there is a special column for that, for example: + // if (x >= y)

[PATCH] D66831: [ObjC] Fix type checking for qualified id block parameters.

vsapsai added a comment. Patch for the suggested compatibility flag is available at https://reviews.llvm.org/D79511 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66831/new/ https://reviews.llvm.org/D66831 ___

[PATCH] D79510: [PATCH] When pragma FENV_ACCESS is ignored do not modify Sema.CurFPFeatures

mibintc marked 2 inline comments as done. mibintc added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:111 PP.Diag(Tok, diag::warn_stdc_fenv_access_not_supported); + return; } Modified this to return instead of making changes which

[PATCH] D79504: [Clang] Wrong return type of atomic_is_lock_free

jfb added a comment. In D79504#2023274 , @rsmith wrote: > Clang's `` uses the builtin as follows: > > #define atomic_is_lock_free(obj) __c11_atomic_is_lock_free(sizeof(*(obj))) > > > ... which, combined with the builtin returning `int`, results in a

[PATCH] D79186: [OPENMP]Consider 'omp_null_allocator' as a predefined allocator.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. In D79186#2016893 , @ABataev wrote: > In D79186#2016737 , @jdoerfert wrote: > > > In

[PATCH] D79511: [ObjC] Add compatibility mode for type checking of qualified id block parameters.

vsapsai created this revision. vsapsai added reviewers: arphaman, dexonsmith. Herald added subscribers: ributzka, jkorous. Herald added a project: clang. Commit 73152a2ec20766ac45673a129bf1f5fc97ca9bbe fixed type checking for blocks with qualified id parameters. But there are existing APIs in

[clang] f21c704 - clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens

Author: Daan De Meyer Date: 2020-05-06T20:59:24+02:00 New Revision: f21c704553a8af7012eaf1ab777e2aa1a55cc86d URL: https://github.com/llvm/llvm-project/commit/f21c704553a8af7012eaf1ab777e2aa1a55cc86d DIFF: https://github.com/llvm/llvm-project/commit/f21c704553a8af7012eaf1ab777e2aa1a55cc86d.diff

[PATCH] D79510: [PATCH] When pragma FENV_ACCESS is ignored do not modify Sema.CurFPFeatures

mibintc created this revision. mibintc added reviewers: uabelho, rjmccall, erichkeane. Herald added a project: clang. Herald added a subscriber: cfe-commits. Bug reported by @uabelho against reviews.llvm.org/D72841 pragma STDC FENV_ACCESS ON is ignored, but the

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added a comment. F11870916: correct.txt F11870922: incorrect.txt See the difference between the correct (master branch) and the incorrect (my

[PATCH] D79054: [NFC] Improve doc string to mention that paths in diff are used as-is

ctetreau added a comment. In D79054#2018912 , @efriedma wrote: > We should probably encourage people to use git-clang-format with git > repositories. It naturally doesn't have this sort of fragility because it > integrates with the repository more

[PATCH] D79325: [clang-format] [PR42164] Add Option to Break before While

krasimir marked an inline comment as done. krasimir added inline comments. Comment at: clang/lib/Format/Format.cpp:691 +/*SplitEmptyRecord=*/true, +/*SplitEmptyNamespace=*/true}; switch (Style.BreakBeforeBraces) {

[PATCH] D79054: [NFC] Improve doc string to mention that paths in diff are used as-is

ctetreau updated this revision to Diff 262433. ctetreau added a comment. address code review issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79054/new/ https://reviews.llvm.org/D79054 Files: clang/tools/clang-format/clang-format-diff.py

[PATCH] D79504: [Clang] Wrong return type of atomic_is_lock_free

rsmith added a comment. Clang's `` uses the builtin as follows: #define atomic_is_lock_free(obj) __c11_atomic_is_lock_free(sizeof(*(obj))) ... which, combined with the builtin returning `int`, results in a call having the wrong type. So there's definitely a bug *somewhere*. I think what

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware updated this revision to Diff 262430. baloghadamsoftware added a comment. Fixed and error in `call_once.cpp` but stuck with debugging of `objc-radar17039661.m`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77229/new/ https://reviews.llvm.org/D77229 Files:

[PATCH] D79354: [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration

krasimir added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2405 tok::kw___attribute, tok::kw___declspec, -tok::kw_alignas) || +tok::kw_alignas, tok::l_square) ||

[PATCH] D79293: [clang-format] [PR45218] Fix an issue where < and > and >> in a for loop gets incorrectly interpreted at a TemplateOpener/Closer

krasimir added a comment. I think these examples are too ambiguous for clang-format to try and format correctly. Sadly for C++, correctly distinguishing between `>>`, the binary operator, and `>>`, the sequence of two closing template brackets, requires semantic analysis, I believe. Such

[PATCH] D79495: [Sema] Allow function attribute patchable_function_entry on aarch64_be

MaskRay added a comment. In D79495#2023108 , @nickdesaulniers wrote: > @MaskRay can you please cherry pick this to release-10? cc @tstellar Already done. https://github.com/llvm/llvm-project/commit/98f9f73f6d2367aa8001c4d16de9d3b347febb08 Verified

[PATCH] D78129: Add Marvell ThunderX3T110 support

SjoerdMeijer added a comment. Since debugging on phabricator is a bit difficult, I took the patch and had a little play. Now I actually remember seeing this before. I think the way this works is that when you describe new instructions (PA in this case) that other models don't have, they start

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

jdoerfert added a comment. In D74387#1992682 , @Fznamznon wrote: > Okay, seems like OpenMP needs unsupported types diagnosing as well. I'm > trying to adapt this patch for OpenMP, but it doesn't work out of the box > because it diagnoses memcpy like

[PATCH] D79445: [MSan] Pass MSan command line options under new pass manager

aeubanks updated this revision to Diff 262426. aeubanks added a comment. Revert back to initial patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79445/new/ https://reviews.llvm.org/D79445 Files: clang/lib/CodeGen/BackendUtil.cpp Index:

[PATCH] D79504: [Clang] Wrong return type of atomic_is_lock_free

jfb added a comment. Just a guess, but maybe the return type was intended to match what a C implementation does with `atomic_is_lock_free` as a macro: https://en.cppreference.com/w/c/atomic/atomic_is_lock_free If so, maybe the expectation is that a macro could define `atomic_is_lock_free`

[PATCH] D78374: [Analyzer][StreamChecker] Added evaluation of fread and fwrite.

balazske added a comment. The "indeterminate file position" case is now handled separately and is always error. The current implementation looks to be wrong because the indeterminate position is set at `fread` when a **FEOF** error is produced. This can be solved probably only with more state

[PATCH] D79423: [analyzer][NFC] StdLibraryFunctionsChecker: Add empty Signatures

balazske added a comment. Probably something like `IsCStdLibraryFunction` can be included in the signature, and empty signature is allowed only for functions that are in a C standard library. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72281: [Matrix] Add matrix type to Clang.

fhahn added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:2112 + llvm::APSInt ArgRows(S.Context.getTypeSize(S.Context.IntTy), + ConstantMatrixArg->getNumRows()); + Result = DeduceNonTypeTemplateArgument(

[PATCH] D72281: [Matrix] Add matrix type to Clang.

fhahn updated this revision to Diff 262413. fhahn marked 2 inline comments as done. fhahn added a comment. Fix template deduction. In D72281#2022004 , @rjmccall wrote: > > The type of m1 matches the matrix argument in all 3 definitions of > > use_matrix

[PATCH] D69088: [Lex] #pragma clang transform

kbarton added a comment. @Meinersbur I missed the RFC and discussion on the cfe-dev mailing list. Could you post a link here so that it's included in the history? I don't have any opposition to this, and it seems that you have addressed all the comments from reviewers. So, unless there was

[PATCH] D79000: [clang-format] C# property formatting can be controlled by config options

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. I think this is OK as-is. @MyDeveloperDay's suggestion of adding AfterProperty to the BraceWrapping style makes sense. However I think in this case it is natural to use the same style for

[PATCH] D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens

MyDeveloperDay added a comment. In D78869#2022850 , @mitchell-stellar wrote: > I often: I develop and run on windows (using a cygwin shell), but with visual studio compiler (configured with CMake for ninja) 0.5 after doing git add of the files, I

[PATCH] D79495: [Sema] Allow function attribute patchable_function_entry on aarch64_be

nickdesaulniers added a subscriber: tstellar. nickdesaulniers added a comment. @MaskRay can you please cherry pick this to release-10? cc @tstellar Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79495/new/ https://reviews.llvm.org/D79495

[PATCH] D79504: [Clang] Wrong return type of atomic_is_lock_free

kamleshbhalui created this revision. kamleshbhalui added reviewers: aaron.ballman, rsmith. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. kamleshbhalui added a reviewer: rnk. Fixing the return type of atomic_is_lock_free as per

  1   2   3   >