[clang] 6bf0ad7 - [Driver] Don't pass -u__llvm_profile_runtime for clang -fprofile-arcs a.o

Author: Fangrui Song Date: 2020-05-08T23:36:29-07:00 New Revision: 6bf0ad78dc01020c9036ad49de2e0f4d59b6def9 URL: https://github.com/llvm/llvm-project/commit/6bf0ad78dc01020c9036ad49de2e0f4d59b6def9 DIFF: https://github.com/llvm/llvm-project/commit/6bf0ad78dc01020c9036ad49de2e0f4d59b6def9.diff

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

hyd-dev added a comment. None of the clang-tidy command line options are prefixed with `-f`. This command line option used to be `--color-diagnostics`, but I've followed @hokein's advice to change it to `--use-color`. If you mean to use the `-fcolor-diagnostics` option from `compile_commands.jso

[PATCH] D46317: [clang-tidy] New check bugprone-map-subscript-operator-lookup

lbrandy added a comment. Someone pointed this patch/thread out to me so I wanted to give some background on what prompted the mention of this in my talk. I think this particular bug is a _huge_ and _recurring_ problem (we've had yet more examples recently, internally) but I also believe that th

[clang] c90e198 - Fix parsing of enum-base to follow C++11 rules.

Author: Richard Smith Date: 2020-05-08T19:32:00-07:00 New Revision: c90e198107431f64b73686bdce31c293e3380ac7 URL: https://github.com/llvm/llvm-project/commit/c90e198107431f64b73686bdce31c293e3380ac7 DIFF: https://github.com/llvm/llvm-project/commit/c90e198107431f64b73686bdce31c293e3380ac7.diff

[PATCH] D62368: Add vendor identity check for Hygon Dhyana processor in Scudo

fanjinke added a comment. Hi Cryptoad， Could you help me to commit the patch? Because I don't have access. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62368/new/ https://reviews.llvm.org/D62368 ___

[clang] 03cb328 - clang: Cleanup usage of CreateMemCpy

Author: Matt Arsenault Date: 2020-05-08T20:57:56-04:00 New Revision: 03cb328d6f691bde88c754341ff3859d1c1ecc2f URL: https://github.com/llvm/llvm-project/commit/03cb328d6f691bde88c754341ff3859d1c1ecc2f DIFF: https://github.com/llvm/llvm-project/commit/03cb328d6f691bde88c754341ff3859d1c1ecc2f.diff

[PATCH] D79655: [WebAssembly] Ignore exception specifications

aheejin marked an inline comment as done. aheejin added inline comments. Comment at: clang/lib/CodeGen/CGException.cpp:23 #include "clang/AST/StmtVisitor.h" +#include "clang/Basic/DiagnosticSema.h" #include "clang/Basic/TargetBuiltins.h" aheejin wrote: > One th

LLVM buildmaster will be updated and restarted after 7PM PST today

Hello everyone, LLVM buildmaster will be updated and restarted after 7PM PST today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D79655: [WebAssembly] Ignore exception specifications

aheejin marked an inline comment as done. aheejin added inline comments. Comment at: clang/lib/CodeGen/CGException.cpp:23 #include "clang/AST/StmtVisitor.h" +#include "clang/Basic/DiagnosticSema.h" #include "clang/Basic/TargetBuiltins.h" One thing I'm not sure

[clang] 9a11174 - [Driver] Add -fno-test-coverage

Author: Fangrui Song Date: 2020-05-08T17:01:53-07:00 New Revision: 9a11174287c78e6f807823fdfbdf4c27c0cad3d9 URL: https://github.com/llvm/llvm-project/commit/9a11174287c78e6f807823fdfbdf4c27c0cad3d9 DIFF: https://github.com/llvm/llvm-project/commit/9a11174287c78e6f807823fdfbdf4c27c0cad3d9.diff

[PATCH] D78659: Add nomerge function attribute to supress tail merge optimization in simplifyCFG

zequanwu updated this revision to Diff 262977. zequanwu added a comment. add `nomerge` case in `CodeExtractor.cpp` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78659/new/ https://reviews.llvm.org/D78659 Files: llvm/docs/LangRef.rst llvm/include/llvm/Bitcode/LLVMBitCodes.h llvm/i

[PATCH] D79655: [WebAssembly] Ignore exception specifications

aheejin created this revision. aheejin added a reviewer: dschuff. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100. Herald added a project: clang. Wasm does not currently handle exception specifications such as `throw()` or `throw(int)`. We have a plan to correctly implemen

[clang] 0d4a33b - [Driver] Don't warn -Wunused-command-line-argument for --coverage -ftest-coverage -fprofile-arcs

Author: Fangrui Song Date: 2020-05-08T16:31:15-07:00 New Revision: 0d4a33ba61b7f1622eda4ec60c74a7eb7b1fcbcf URL: https://github.com/llvm/llvm-project/commit/0d4a33ba61b7f1622eda4ec60c74a7eb7b1fcbcf DIFF: https://github.com/llvm/llvm-project/commit/0d4a33ba61b7f1622eda4ec60c74a7eb7b1fcbcf.diff

[PATCH] D79121: Add nomerge function attribute to clang

zequanwu updated this revision to Diff 262971. zequanwu marked an inline comment as done. zequanwu added a comment. use `ConstEvaluatedExprVisitor` to recursively looking up for call expr CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79121/new/ https://reviews.llvm.org/D79121 Files:

[PATCH] D79344: [cuda] Start diagnosing variables with bad target.

tra added a comment. This triggers an assertion: clang: /usr/local/google/home/tra/work/llvm/repo/clang/lib/AST/Decl.cpp:2697: clang::Expr *clang::ParmVarDecl::getDefaultArg(): Assertion `!hasUninstantiatedDefaultArg() && "Default argument is not yet instantiated!"' failed. #2 0x7f

[clang] e1815eb - [Driver] Reorganize --coverage -ftest-coverage -fprofile-arcs related tests

Author: Fangrui Song Date: 2020-05-08T16:06:33-07:00 New Revision: e1815eb2e1016d74ed8f8e2f459182886cacf733 URL: https://github.com/llvm/llvm-project/commit/e1815eb2e1016d74ed8f8e2f459182886cacf733 DIFF: https://github.com/llvm/llvm-project/commit/e1815eb2e1016d74ed8f8e2f459182886cacf733.diff

[PATCH] D79653: [sanitizer] Enable whitelist/blacklist in new PM

jsji created this revision. jsji added reviewers: tuktuk, vitalybuka, morehouse, kcc. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, hiraditya. Herald added projects: clang, Sanitizers, LLVM. https://reviews.llvm.org/D63616 added `-fsanitize-coverage-whitelist` and `-fsanitize-co

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

plotfi added a comment. Hi @rjmccall, I am also seeing similar failures. It is failing on apple's master (and the swift branches as well) because ParseLangArgs and ParseCodeGenArgs are getting called in the opposite order in apple/master from the order they are called in llvm/master. I posted a

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

jasonliu added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:1547 // Otherwise, if the type contains an SSE vector type, the alignment is 16. + if (Align >= 16 && (isSIMDVectorType(getContext(), Ty) || Xiangling_L wrote: > Also update the co

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

jasonliu updated this revision to Diff 262964. jasonliu marked 5 inline comments as done. jasonliu added a comment. Address Xiangling's comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79035/new/ https://reviews.llvm.org/D79035 Files: clang/lib/CodeGen/TargetInfo.cpp clang/li

[PATCH] D79526: [CUDA][HIP] Workaround for resolving host device function against wrong-sided function

tra added a comment. This one is just a FYI. I've managed to reduce the failure in the first version of this patch and it looks rather odd because the reduced test case has nothing to do with CUDA. Instead it appears to introduce a difference in compilation of regular host-only C++ code with `-

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

jasonliu updated this revision to Diff 262958. jasonliu marked 2 inline comments as done. jasonliu added a comment. Address Zarko's comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79035/new/ https://reviews.llvm.org/D79035 Files: clang/lib/CodeGen/TargetInfo.cpp clang/lib/Dr

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:1547 // Otherwise, if the type contains an SSE vector type, the alignment is 16. + if (Align >= 16 && (isSIMDVectorType(getContext(), Ty) || Also update the comment? =

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

smeenai added inline comments. Comment at: lld/test/lit.site.cfg.py.in:16 config.target_triple = "@TARGET_TRIPLE@" -config.python_executable = "@Python3_EXECUTABLE@" -config.have_zlib = @HAVE_LIBZ@ +config.python_executable = "@PYTHON_EXECUTABLE@" +config.have_zlib = @LLVM_ENABL

[PATCH] D79534: [clang][WebAssembly] Only expose wait and notify builtins with atomics

This revision was automatically updated to reflect the committed changes. Closed by commit rGebb69b8bafad: [clang][WebAssembly] Only expose wait and notify builtins with atomics (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D795

[PATCH] D79044: [AIX] Avoid structor alias; die before bad alias codegen

This revision was automatically updated to reflect the committed changes. Closed by commit rGb116ded57da3: [AIX] Avoid structor alias; die before bad alias codegen (authored by hubert.reinterpretcast). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79

[PATCH] D79121: Add nomerge function attribute to clang

rsmith added inline comments. Comment at: clang/lib/Sema/SemaStmtAttr.cpp:178 +return true; + return llvm::any_of(S->children(), hasCallExpr); +} zequanwu wrote: > rsmith wrote: > > This will recurse into too much (eg, the bodies of lambdas and blocks, and

[clang] ebb69b8 - [clang][WebAssembly] Only expose wait and notify builtins with atomics

Author: Thomas Lively Date: 2020-05-08T13:54:29-07:00 New Revision: ebb69b8bafad6948ee6a14b4087fb7b440c73d0d URL: https://github.com/llvm/llvm-project/commit/ebb69b8bafad6948ee6a14b4087fb7b440c73d0d DIFF: https://github.com/llvm/llvm-project/commit/ebb69b8bafad6948ee6a14b4087fb7b440c73d0d.diff

[clang] b116ded - [AIX] Avoid structor alias; die before bad alias codegen

Author: Hubert Tong Date: 2020-05-08T16:51:34-04:00 New Revision: b116ded57da3530e661f871f4191c59cd9e091cd URL: https://github.com/llvm/llvm-project/commit/b116ded57da3530e661f871f4191c59cd9e091cd DIFF: https://github.com/llvm/llvm-project/commit/b116ded57da3530e661f871f4191c59cd9e091cd.diff L

[PATCH] D79526: [CUDA][HIP] Workaround for resolving host device function against wrong-sided function

tra added a subscriber: wash. tra added a comment. In D79526#2027470 , @yaxunl wrote: > For implicit host device functions, since they are not guaranteed to work in > device compilation, we can only resolve them as if they are host functions. > This caus

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 added a comment. Sure I will add Joel's suggestion and other fixes later. Thanks, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/ https://reviews.llvm.org/D78129 ___ cfe-commits maili

[PATCH] D78659: Add nomerge function attribute to supress tail merge optimization in simplifyCFG

zequanwu updated this revision to Diff 262933. zequanwu marked an inline comment as done. zequanwu added a comment. update comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78659/new/ https://reviews.llvm.org/D78659 Files: llvm/docs/LangRef.rst llvm/include/llvm/Bitcode/LLVMBi

[PATCH] D79526: [CUDA][HIP] Workaround for resolving host device function against wrong-sided function

yaxunl added a comment. In D79526#2027242 , @tra wrote: > The latest version of the patch works well enough to compile tensorflow. > That's the good news. > > In D79526#2026857 , @yaxunl wrote: > > > Looks like we

[PATCH] D72959: Relative VTables ABI on Fuchsia

rjmccall added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:357 +"allow use of clang's relative C++ ABI " +"for classes with vtables on targets that support this") "Use an ABI-incompatible v-table layout that uses relat

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73052/new/ https://reviews.llvm.org/D73052

[PATCH] D46317: [clang-tidy] New check bugprone-map-subscript-operator-lookup

aaron.ballman added a comment. In D46317#2027330 , @khuttun wrote: > In D46317#2027071 , @aaron.ballman > wrote: > > > In D46317#2023406 , @khuttun wrote: > > > > > Any comm

[PATCH] D78659: Add nomerge function attribute to supress tail merge optimization in simplifyCFG

lebedev.ri added inline comments. Comment at: llvm/include/llvm/IR/Attributes.td:106 +/// Disable tail merge for this function +def NoMerge : EnumAttr<"nomerge">; Elsewhere we seem to be preventing any kind of movement, not just disabling inlining of such funct

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

ZarkoCA added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:5244 llvm::Value *Address) const { - - return PPC64_initDwarfEHRegSizeTable(CGF, Address); + return PPC_initDwarfEHRegSizeTable(CGF, Address, /* Is64Bit*

[PATCH] D79121: Add nomerge function attribute to clang

zequanwu updated this revision to Diff 262922. zequanwu added a comment. use `ConstStmtVisitor` to do recursive lookup for call expression. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79121/new/ https://reviews.llvm.org/D79121 Files: clang/include/clang/Basic/Attr.td clang/includ

[PATCH] D79639: [SveEmitter] Builtins for SVE matrix multiply `mmla`.

fpetrogalli updated this revision to Diff 262923. fpetrogalli added a comment. I replaced the lines `Signed = !Signed` in the tablegen emitter with `Signed = false`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79639/new/ https://reviews.llvm.org

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

njames93 added a comment. Could this not use the `-fcolor-diagnostics` and `fno-color-diagnostics` command line flags that clang uses for its diagnostics to keep everything the same? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79477/new/ https://reviews.llvm.org/D79477 __

[PATCH] D79636: [LangRef] Clarify the semantics of the `byval` attribute

efriedma added inline comments. Comment at: llvm/docs/LangRef.rst:1050 +the call site argument and function argument are associated with the +original and copied memory respectively. The copy is considered to be local +memory of the callee. That means, a callee can wr

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

njames93 updated this revision to Diff 262920. njames93 marked 3 inline comments as done. njames93 added a comment. - Tweaked options to remove second virtual method Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73052/new/ https://reviews.llvm.org/

[PATCH] D78129: Add Marvell ThunderX3T110 support

SjoerdMeijer added a comment. In D78129#2023772 , @joelkevinjones wrote: > I don't think it makes sense to combine two unrelated things SVE and PA > support into a combined thing. Since we already have UnsupportedFeatures in > every sub-target .td file,

[PATCH] D79631: #pragma float_control should be permitted at namespace scope

mibintc added a comment. No this patch isn't ready yet. i see an assertion if try to instantiate a template function when the template has enabled floating point settings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79631/new/ https://reviews.llv

[PATCH] D79639: [SveEmitter] Builtins for SVE matrix multiply `mmla`.

fpetrogalli created this revision. fpetrogalli added reviewers: sdesmalen, kmclaughlin, efriedma. Herald added subscribers: cfe-commits, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. fpetrogalli added a parent revision: D79638: [llvm][SVE] IR intrinscs f

[PATCH] D46317: [clang-tidy] New check bugprone-map-subscript-operator-lookup

khuttun added a comment. In D46317#2027071 , @aaron.ballman wrote: > In D46317#2023406 , @khuttun wrote: > > > Any comments on this? Is this checker something that could be part of > > clang-tidy? > > > Thank you

[PATCH] D78862: [IR] Convert null-pointer-is-valid into an enum attribute

arsenm added a comment. In D78862#2012560 , @jdoerfert wrote: > I think this is an improvement over the status quo and it looks fine to me. > > @arsenm I agree that we should tie this to the data layout (or at least > should try) but I guess there are ope

[PATCH] D76793: [Matrix] Implement + and - operators for MatrixType.

fhahn updated this revision to Diff 262901. fhahn added a comment. Rebase on top of the final version of D72281 . I think this patch is now ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76793/new/

[PATCH] D79636: [LangRef] Clarify the semantics of the `byval` attribute

jdoerfert created this revision. jdoerfert added reviewers: arsenm, spatel, efriedma, lebedev.ri, fhahn, rnk, hfinkel, regehr, nlopes. Herald added subscribers: dmgreen, bollu, wdng. Herald added a project: LLVM. After the discussion in D79454 it seemed clear we

[PATCH] D79526: [CUDA][HIP] Workaround for resolving host device function against wrong-sided function

tra added a comment. The latest version of the patch works well enough to compile tensorflow. That's the good news. In D79526#2026857 , @yaxunl wrote: > Looks like we went overboard to treat implicit host device candidate as > inferior. They should be t

[PATCH] D79595: Fix bugs when an included file name is typo corrected.

This revision was automatically updated to reflect the committed changes. Closed by commit rG51d938bc9443: Fix bugs when an included file name is typo corrected. (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

fhahn updated this revision to Diff 262893. fhahn added a comment. Rebase on top of the latest version of D72281 . Refactor code to re-use new address conversion helper. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[clang] 51d938b - Fix bugs when an included file name is typo corrected.

Author: Nico Weber Date: 2020-05-08T13:33:39-04:00 New Revision: 51d938bc94433b03cfbe60758642dbe70269ae3b URL: https://github.com/llvm/llvm-project/commit/51d938bc94433b03cfbe60758642dbe70269ae3b DIFF: https://github.com/llvm/llvm-project/commit/51d938bc94433b03cfbe60758642dbe70269ae3b.diff LO

[PATCH] D41720: [clang-tidy] Add a -show-color flag.

leoleoasd added a comment. Any update on this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41720/new/ https://reviews.llvm.org/D41720 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

jdoerfert added a comment. In D74387#2026844 , @Fznamznon wrote: > I'm not sure that I've discovered all examples and problems, but I have a > couple of ones. I started with adapting current implementation for OpenMP and > right now I'm analyzing corresp

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

hyd-dev updated this revision to Diff 262887. hyd-dev marked an inline comment as done. hyd-dev added a comment. Change incorrect `detect` to `detected` in the comment of `UseColor` option. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79477/new/ https://reviews.llvm.org/D79477 Files:

[clang-tools-extra] e20fcf0 - Unbreak clang-tidy tests after D79599 / e9b4113902850.

Author: Nico Weber Date: 2020-05-08T12:37:33-04:00 New Revision: e20fcf0504e598c4f9f6ee77ca56d7431f9194c3 URL: https://github.com/llvm/llvm-project/commit/e20fcf0504e598c4f9f6ee77ca56d7431f9194c3 DIFF: https://github.com/llvm/llvm-project/commit/e20fcf0504e598c4f9f6ee77ca56d7431f9194c3.diff LO

[PATCH] D79599: Add a flag that controls if clang-tidy and clang-include-fixer are built into libclang.

This revision was automatically updated to reflect the committed changes. thakis marked an inline comment as done. Closed by commit rGe9b411390285: Add a flag that controls if clang-tidy and clang-include-fixer are built into… (authored by thakis). Herald added a project: clang. Changed prior to

[PATCH] D78124: [analyzer][ObjCGenerics] Don't emit diagnostics under the name core.DynamicTypePropagation

balazske accepted this revision. balazske added a comment. This revision is now accepted and ready to land. Did not found problems. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78124/new/ https://reviews.llvm.org/D78124

[PATCH] D46317: [clang-tidy] New check bugprone-map-subscript-operator-lookup

aaron.ballman added a comment. In D46317#2023406 , @khuttun wrote: > Any comments on this? Is this checker something that could be part of > clang-tidy? Thank you for posting some of the diagnostics found by the check, that was really helpful informati

[PATCH] D79599: Add a flag that controls if clang-tidy and clang-include-fixer are built into libclang.

thakis marked 2 inline comments as done. thakis added a comment. Thanks! Added a release note. I had cc'd everyone who had commented on D55415 -- did I miss anyone? Comment at: clang/tools/libclang/CMakeLists.txt:65 + else () +message(FAT

[PATCH] D79595: Fix bugs when an included file name is typo corrected.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79595/new/ https://reviews.llvm.org/D79595 ___ cfe-commits mailing list cfe-commits@lists

[clang] e9b4113 - Add a flag that controls if clang-tidy and clang-include-fixer are built into libclang.

Author: Nico Weber Date: 2020-05-08T11:41:45-04:00 New Revision: e9b4113902850667e4e96b0aabe158b87670d051 URL: https://github.com/llvm/llvm-project/commit/e9b4113902850667e4e96b0aabe158b87670d051 DIFF: https://github.com/llvm/llvm-project/commit/e9b4113902850667e4e96b0aabe158b87670d051.diff LO

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.h:44 + virtual void storeCheckOptions(ClangTidyOptions::OptionMap &Opts) {} + njames93 wrote: > aaron.ballman wrote: > > I'd appreciate some comments here

[PATCH] D78121: [analyzer][DirectIvarAssignment] Turn DirectIvarAssignmentForAnnotatedFunctions into a checker option

balazske accepted this revision. balazske added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78121/new/ https://reviews.llvm.org/D78121 __

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.h:130 + + /// Use colors in diagnostics. If missing, colors will be used if standard + /// output is connected to a terminal. hokein wrote: > nit: ... wil be used if

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. I got a report that this patch was causing a problem with Windows header because #pragma float_control should be supported in namespace context. I've posted a patch for review here https://reviews.llvm.org/D79631 Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D79631: #pragma float_control should be permitted at namespace scope

mibintc created this revision. mibintc added reviewers: rjmccall, erichkeane. Herald added a project: clang. Herald added a subscriber: cfe-commits. I got a bug report from Intel that https://reviews.llvm.org/D72841 was causing a crash on Windows in vs2017 header in /std:c++17 mode, because #p

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

jasonliu updated this revision to Diff 262878. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79035/new/ https://reviews.llvm.org/D79035 Files: clang/lib/CodeGen/TargetInfo.cpp clang/lib/Driver/ToolChains/Clang.cpp clang/test/CodeGen/aix-complex.c clang/test/CodeGen/aix-return.c

[PATCH] D79599: Add a flag that controls if clang-tidy and clang-include-fixer are built into libclang.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks very reasonable to be. Maybe worth a release note in case this is surprising to any libclang users? And maybe cc the other folks from D55415 ? ===

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 added a comment. I think I made all the changes mentioned in the feedbacks. Please take sometime to review the current version. We are eager to get the first thunderx3t110 checked in. There are a few things we plan to do after the 1st version: 1. add more tests as suggested in the revi

[PATCH] D79160: [AST] Preserve the type in RecoveryExprs for broken function calls.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/test/SemaCXX/enable_if.cpp:417 -constexpr int B = 10 + // the carat for the error should be pointing to the problematic call (on the next line), not here. -callTemplated<0>(); // expec

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 updated this revision to Diff 262876. wxz2020 added a comment. Removed the PA related instructions from the .md file as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/ https://reviews.llvm.org/D78129 Files: llvm/inclu

[PATCH] D79629: [Clang][Driver]Pass LLVM options to lld in case of LTO

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. `-mllvm,foobar` is for compilation (.c/.cc -> .o) `-Wl,-mllvm,foobar` for LTO options. For linking, `-mllvm,foobar` is not used and thus warned. Comment at: cla

[PATCH] D79160: [AST] Preserve the type in RecoveryExprs for broken function calls.

hokein updated this revision to Diff 262874. hokein marked an inline comment as done. hokein added a comment. add a missing test file during the rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79160/new/ https://reviews.llvm.org/D79160 Files

[PATCH] D79160: [AST] Preserve the type in RecoveryExprs for broken function calls.

hokein updated this revision to Diff 262872. hokein added a comment. rebase to master (not the D78350 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79160/new/ https://reviews.llvm.org/D79160 Files: clang/includ

[PATCH] D79629: [Clang][Driver]Pass LLVM options to lld in case of LTO

bin.narwal created this revision. bin.narwal added a reviewer: MaskRay. bin.narwal added a project: clang. Herald added subscribers: cfe-commits, dexonsmith, inglorion. Hi, When debugging ThinLTO with clang -mllvm -debug-only=function-import -flto=thin -fuse-ld=lld ..., it gives me below warning

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

jasonliu updated this revision to Diff 262869. jasonliu added a comment. Address comments. Add in over aligned structure and structure containing vector type handling for argument on AIX. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79035/new/ https://reviews.llvm.org/D79035 Files:

[PATCH] D79628: [Clang][Driver] Add Bounds and Thread to SupportsCoverage list

melver created this revision. melver added a reviewer: vitalybuka. Herald added a project: clang. Herald added a subscriber: cfe-commits. This permits combining -fsanitize-coverage with -fsanitize=bounds or -fsanitize=thread. Note that, GCC already supports combining these. Bugzilla: https://bugs

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

njames93 updated this revision to Diff 262865. njames93 added a comment. - Address nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73052/new/ https://reviews.llvm.org/D73052 Files: clang-tools-extra/clang-tidy/bugprone/ReservedIdentifierCheck

[PATCH] D79627: [AST] Fix an assertion violation in FieldDecl::getParent.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. FieldDecl::getParent assumes that the FiledDecl::getDeclContext returns a RecordDecl, this is true for C/C++, but not for ObjCIvarDecl:

[clang-tools-extra] ad811a2 - [clangd] Update the new clangd url, NFC.

Author: Haojian Wu Date: 2020-05-08T15:11:44+02:00 New Revision: ad811a27283c6e39d42499d6564f84c224f4d29e URL: https://github.com/llvm/llvm-project/commit/ad811a27283c6e39d42499d6564f84c224f4d29e DIFF: https://github.com/llvm/llvm-project/commit/ad811a27283c6e39d42499d6564f84c224f4d29e.diff LO

[PATCH] D76083: [clang-tidy] Expand the list of functions in bugprone-unused-return-value

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D76083#2026375 , @jranieri-grammatech wrote: > Ping? It sounds like the consensus is to commit this as-is and, if there's a > negativ

[PATCH] D79582: [clangd] Fix crash in AddUsing tweak due to non-identifier DeclName

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e7bb37dfb00: [clangd] Fix crash in AddUsing tweak due to non-identifier DeclName (authored by adamcz, committed by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[clang-tools-extra] 8e7bb37 - [clangd] Fix crash in AddUsing tweak due to non-identifier DeclName

Author: Adam Czachorowski Date: 2020-05-08T14:26:21+02:00 New Revision: 8e7bb37dfb00bddd12cb44b75d57548330d32527 URL: https://github.com/llvm/llvm-project/commit/8e7bb37dfb00bddd12cb44b75d57548330d32527 DIFF: https://github.com/llvm/llvm-project/commit/8e7bb37dfb00bddd12cb44b75d57548330d32527.d

[PATCH] D79582: [clangd] Fix crash in AddUsing tweak due to non-identifier DeclName

adamcz updated this revision to Diff 262857. adamcz marked an inline comment as done. adamcz added a comment. Addressed review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79582/new/ https://reviews.llvm.org/D79582 Files: clang-tools-ex

[PATCH] D79526: [CUDA][HIP] Workaround for resolving host device function against wrong-sided function

yaxunl added a comment. In D79526#2025761 , @tra wrote: > I've tested the patch on our sources and it still breaks tensorflow > compilation, though in a different way: > > In file included from > third_party/tensorflow/core/kernels/slice_op_gpu.cu.cc:2

[PATCH] D79526: [CUDA][HIP] Workaround for resolving host device function against wrong-sided function

yaxunl updated this revision to Diff 262858. yaxunl edited the summary of this revision. yaxunl added a comment. fix regression. only treat implicit host device candidate inferior in device compilation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79526/new/ https://reviews.llvm.org/D

[PATCH] D75430: [analyzer][NFC] Introduce CXXDeallocatorCall, deploy it in MallocChecker

Szelethus marked 5 inline comments as done. Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:59 enum CallEventKind { + CE_CXXDeallocator, CE_Function, xazax.hun wrote: > Szelethus wrote: > > I nee

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

xazax.hun marked an inline comment as done. xazax.hun added a comment. Thanks! I still have some nits inline, but overall the implementation looks good to me. I think, however, that we should not only focus on the implementation but on the high-level questions. Is this the way forward we want?

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

Fznamznon added a comment. In D74387#2023200 , @jdoerfert wrote: > In D74387#1992682 , @Fznamznon wrote: > > > Okay, seems like OpenMP needs unsupported types diagnosing as well. I'm > > trying to adapt this patch

[PATCH] D75430: [analyzer][NFC] Introduce CXXDeallocatorCall, deploy it in MallocChecker

xazax.hun added a comment. Overall looks good to me some questions and nits inline. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:59 enum CallEventKind { + CE_CXXDeallocator, CE_Function, Szelethus wrote: > I need to move th

[PATCH] D79500: [clangd] Refactor code completion signal's utility properties.

usaxena95 updated this revision to Diff 262852. usaxena95 added a comment. - Added DerivedSignals struct containing all the derived signals. - Added NameMatchesContext and proximtiy signals to this struct. - We need to call computeDerivedSignals() before calling evaluate() if we set non-concrete

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware updated this revision to Diff 262845. baloghadamsoftware added a comment. Added support for `ParamRegions` as original region for captured variables by blocks and lambdas. Only 2 failing tests left. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77229/new/ https://rev

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/Store.cpp:472 + break; +} + baloghadamsoftware wrote: > baloghadamsoftware wrote: > > Probably this loop could be wri

[PATCH] D77846: [analyzer][CallAndMessage][NFC] Split up checkPreCall

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp:27 #include "llvm/Support/Casting.h" +#include "llvm/Support/ErrorHandling.h" #include "llvm/Support/raw_ostream.h" Are these new includes needed? Reposito

[PATCH] D77846: [analyzer][CallAndMessage][NFC] Split up checkPreCall

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp:481 + ProgramStateRef State = C.getState(); + if (isa(Call) || isa(Call)) { + The one thing where I am not sure is if this condition is really needed for ev

[PATCH] D79487: [clangd] NFC: Use deprecated grpc++ headers for compatibility

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c198b550ebb: [clangd] NFC: Use deprecated grpc++ headers for compatibility (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79487/new/

  1   2   >