[PATCH] D79918: [clangd] Don't create as much garbage while building Dex index.

2020-05-13 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev added a comment. Wow, nice work, thank you! Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:51 +public: + // Returns the tokens which are given symbol's characteristics. Currently, the + // generated tokens only contain fuzzy matching trigrams and symbol's

[PATCH] D79830: Add support of __builtin_expect_with_probability

2020-05-13 Thread Zhi Zhuang via Phabricator via cfe-commits
LukeZhuang added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2195 +Value *ExpectedValue = EmitScalarExpr(E->getArg(1)); +Value *Confidence = EmitScalarExpr(E->getArg(2)); +// Don't generate llvm.expect.with.probability on -O0 as the backend

[PATCH] D78134: [Sema] Don't apply an lvalue-to-rvalue conversion to a discarded-value expression if it has an array type

2020-05-13 Thread Akira Hatanaka via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG50a81ea2bce3: Dont apply lvalue-to-rvalue conversion in DefaultLValueConversion to the… (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79834: Speed up preamble building by replacing the slow translateFile call by a new, faster isMainFile check

2020-05-13 Thread Jan Korous via Phabricator via cfe-commits
jkorous added a comment. Could you please add a test for this method to `clang/unittests/Basic/SourceManagerTest.cpp`? Comment at: clang/include/clang/Basic/SourceManager.h:816 + /// Returns true when the given FileEntry corresponds to the main file. + bool

[clang] 50a81ea - Don't apply lvalue-to-rvalue conversion in DefaultLValueConversion to

2020-05-13 Thread Akira Hatanaka via cfe-commits
Author: Akira Hatanaka Date: 2020-05-13T20:12:10-07:00 New Revision: 50a81ea2bce3aec01ae6fae1505e57ec7aa36ac7 URL: https://github.com/llvm/llvm-project/commit/50a81ea2bce3aec01ae6fae1505e57ec7aa36ac7 DIFF:

[PATCH] D79919: [Driver] Pass -plugin-opt=O2 for -Os -Oz and -plugin-opt=O1 for -Og

2020-05-13 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added a comment. LGTM, probably want @pcc to approve as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79919/new/ https://reviews.llvm.org/D79919 ___ cfe-commits mailing list

[PATCH] D79631: #pragma float_control should be permitted at namespace scope

2020-05-13 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79631/new/ https://reviews.llvm.org/D79631 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79914: [CodeGen][NFC] Fix test/CodeGen/pr45476.cpp to specify target triple.

2020-05-13 Thread Huihui Zhang via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfd842d362662: [CodeGen][NFC] Fix test/CodeGen/pr45476.cpp to specify target triple. (authored by huihuiz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

2020-05-13 Thread Matthew Riley via Phabricator via cfe-commits
mattdr added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:248-249 + def warn_slh_does_not_support_gcc_asm_goto : Warning< +"speculative load hardening does not support use of GCC asm goto. asm goto " +"detected with SLH">,

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

2020-05-13 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. In D79743#2035575 , @mattdr wrote: > Not sure we want to move this into the Parser -- SLH is a property of code > generation, and I think it's possible (through LTO?) to mismatch the flags > between parse and codegen.

[clang] fd842d3 - [CodeGen][NFC] Fix test/CodeGen/pr45476.cpp to specify target triple.

2020-05-13 Thread Huihui Zhang via cfe-commits
Author: Huihui Zhang Date: 2020-05-13T18:04:14-07:00 New Revision: fd842d3626625d8075b0ecbd4d24de70d7ac2456 URL: https://github.com/llvm/llvm-project/commit/fd842d3626625d8075b0ecbd4d24de70d7ac2456 DIFF: https://github.com/llvm/llvm-project/commit/fd842d3626625d8075b0ecbd4d24de70d7ac2456.diff

[PATCH] D79788: AMDGPU/OpenCL: Accept -nostdlib in place of -nogpulib

2020-05-13 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79788/new/ https://reviews.llvm.org/D79788 ___ cfe-commits mailing list

[PATCH] D79918: [clangd] Don't create as much garbage while building Dex index.

2020-05-13 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, mgrang, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. The Token objects are relatively expensive and we were spending a lot of CPU

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

2020-05-13 Thread Matthew Riley via Phabricator via cfe-commits
mattdr added a comment. Not sure we want to move this into the Parser -- SLH is a property of code generation, and I think it's possible (through LTO?) to mismatch the flags between parse and codegen. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79919: [Driver] Pass -plugin-opt=O2 for -Os -Oz and -plugin-opt=O1 for -Og

2020-05-13 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. MaskRay added reviewers: mehdi_amini, pcc, phosek, tejohnson. Herald added subscribers: cfe-commits, dexonsmith, steven_wu, hiraditya. Herald added a project: clang. MaskRay added a parent revision: D79916: Map -O to -O1 instead of -O2. Fixes PR42445 (-Os -Oz

[PATCH] D79916: Map -O to -O1 instead of -O2

2020-05-13 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. MaskRay added a reviewer: hans. Herald added a project: clang. Herald added a subscriber: cfe-commits. MaskRay added a child revision: D79919: [Driver] Pass -plugin-opt=O2 for -Os -Oz and -plugin-opt=O1 for -Og. rL187583 mapped

[PATCH] D78129: Add Marvell ThunderX3T110 support

2020-05-13 Thread Joel Jones via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG382d3a85e2a9: [AARch64] Add Marvell ThunderX3T110 support (authored by wxz2020, committed by joelkevinjones). Changed prior to commit: https://reviews.llvm.org/D78129?vs=263582=263896#toc Repository:

[PATCH] D79914: [CodeGen][NFC] Fix test/CodeGen/pr45476.cpp to specify target triple.

2020-05-13 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79914/new/ https://reviews.llvm.org/D79914

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

2020-05-13 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2632 +.. option:: -mseses, -mno-seses + This file is in alphabetical order and is normally generated by a running clang-tblgen. See comment at the top of the file.

[clang] 382d3a8 - [AARch64] Add Marvell ThunderX3T110 support

2020-05-13 Thread Joel Jones via cfe-commits
Author: Wei Zhao Date: 2020-05-13T16:58:51-07:00 New Revision: 382d3a85e2a9269569e7fb8caa487d7ef57900c6 URL: https://github.com/llvm/llvm-project/commit/382d3a85e2a9269569e7fb8caa487d7ef57900c6 DIFF: https://github.com/llvm/llvm-project/commit/382d3a85e2a9269569e7fb8caa487d7ef57900c6.diff

[PATCH] D79914: [CodeGen][NFC] Fix test/CodeGen/pr45476.cpp to specify target triple.

2020-05-13 Thread Huihui Zhang via Phabricator via cfe-commits
huihuiz created this revision. huihuiz added reviewers: efriedma, ekatz, rjmccall, rsmith, luismarques. huihuiz added a project: LLVM. Herald added subscribers: cfe-commits, jfb, kristof.beyls. Herald added a project: clang. Use explicit target triple to match more accurately the output for

[PATCH] D79830: Add support of __builtin_expect_with_probability

2020-05-13 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:567 BUILTIN(__builtin_expect, "LiLiLi" , "nc") +BUILTIN(__builtin_expect_with_probability, "LiLiLid" , "nc") BUILTIN(__builtin_prefetch, "vvC*.", "nc") I assume we don't have

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

2020-05-13 Thread Joe Burzinski via Phabricator via cfe-commits
Tridacnid added a comment. I don't think that did what I wanted. Looks like I should submit the whole change as a single patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79912/new/ https://reviews.llvm.org/D79912 ___ cfe-commits

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

2020-05-13 Thread Joe Burzinski via Phabricator via cfe-commits
Tridacnid updated this revision to Diff 263887. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79912/new/ https://reviews.llvm.org/D79912 Files: clang-tools-extra/test/clang-tidy/checkers/bugprone-infinite-loop.cpp clang/lib/Analysis/ExprMutationAnalyzer.cpp

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

2020-05-13 Thread Joe Burzinski via Phabricator via cfe-commits
Tridacnid updated this revision to Diff 263885. Tridacnid added a comment. Apply clang-format patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79912/new/ https://reviews.llvm.org/D79912 Files: clang/unittests/Analysis/ExprMutationAnalyzerTest.cpp Index:

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

2020-05-13 Thread Florian Hahn via Phabricator via cfe-commits
fhahn updated this revision to Diff 263879. fhahn edited the summary of this revision. fhahn added a comment. ping. Simplify code, extend tests. This should now be ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72781/new/

[PATCH] D72782: [Matrix] Add __builtin_matrix_column_store to Clang.

2020-05-13 Thread Florian Hahn via Phabricator via cfe-commits
fhahn updated this revision to Diff 263880. fhahn added a comment. ping. Simplify code, extend tests. This should now be ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72782/new/ https://reviews.llvm.org/D72782 Files:

[PATCH] D72778: [Matrix] Add __builtin_matrix_transpose to Clang.

2020-05-13 Thread Florian Hahn via Phabricator via cfe-commits
fhahn updated this revision to Diff 263878. fhahn added a comment. ping. Simplify code, extend tests. This should now be ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72778/new/ https://reviews.llvm.org/D72778 Files:

[PATCH] D79830: Add support of __builtin_expect_with_probability

2020-05-13 Thread Zhi Zhuang via Phabricator via cfe-commits
LukeZhuang added a comment. In D79830#2034796 , @lebedev.ri wrote: > In D79830#2034779 , @LukeZhuang > wrote: > > > In D79830#2033367 , @lebedev.ri > > wrote: > > > > >

[PATCH] D79830: Add support of __builtin_expect_with_probability

2020-05-13 Thread Zhi Zhuang via Phabricator via cfe-commits
LukeZhuang marked 4 inline comments as done. LukeZhuang added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2049 +ConstantFP *Confidence_f = dyn_cast(Confidence); +if (!Confidence_f) { + CGM.Error(E->getArg(2)->getLocStart(),

[PATCH] D79830: Add support of __builtin_expect_with_probability

2020-05-13 Thread Zhi Zhuang via Phabricator via cfe-commits
LukeZhuang updated this revision to Diff 263877. LukeZhuang added a comment. 1. fix code format 2. move probability type and value check from codegen to semacheck 3. update patch with full context CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/ https://reviews.llvm.org/D79830

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2020-05-13 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D69778#2035006 , @llunak wrote: > In D69778#2032363 , @dblaikie wrote: > > > So the original commit ( cbc9d22e49b4 > >

[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

2020-05-13 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D79744#2035109 , @arsenm wrote: > In D79744#2030710 , @rjmccall wrote: > > > Okay. So the only real ABI here is the layout of the memory that the > > arguments are actually written

[PATCH] D79595: Fix bugs when an included file name is typo corrected.

2020-05-13 Thread Abhinav Gaba via Phabricator via cfe-commits
abhinavgaba added inline comments. Comment at: clang/test/Lexer/case-insensitive-include-win.c:8 // RUN: touch %t.dir/foo.h -// RUN: not %clang_cl /FI\\?\%t.dir\FOO.h /WX -Xclang -verify -fsyntax-only %s 2>&1 | FileCheck %s +// RUN: not %clang_cl /FI\\?\%t.dir\FOO.h /WX

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

2020-05-13 Thread Joe Burzinski via Phabricator via cfe-commits
Tridacnid created this revision. Tridacnid added reviewers: llvm-commits, alexfh, klimek. Tridacnid added projects: clang-tools-extra, clang. Herald added a subscriber: cfe-commits. Add ignoringParenImpCasts to assignment and inc/dec mutation checks in ExprMutationAnalyzer to fix clang-tidy bug

[PATCH] D79511: [ObjC] Add compatibility mode for type checking of qualified id block parameters.

2020-05-13 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak accepted this revision. ahatanak added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79511/new/ https://reviews.llvm.org/D79511 ___ cfe-commits mailing list

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

2020-05-13 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2943 + if (Opts.FastRelaxedMath) +Opts.setDefaultFPContractMode(LangOptions::FPM_Fast); Opts.HexagonQdsp6Compat = Args.hasArg(OPT_mqdsp6_compat); mibintc wrote: >

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

2020-05-13 Thread Jason Liu via Phabricator via cfe-commits
jasonliu updated this revision to Diff 263864. jasonliu added a comment. Remove driver's error. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79035/new/ https://reviews.llvm.org/D79035 Files: clang/lib/CodeGen/TargetInfo.cpp clang/lib/Frontend/CompilerInvocation.cpp

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

2020-05-13 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:7899 +if (FpPragmaCurrentLocation.isInvalid()) { + assert(*FpPragmaCurrentValue == SemaObj->FpPragmaStack.DefaultValue && + "Expected a default pragma float_control value");

[PATCH] D79866: [HIP] Do not emit debug info for stub function

2020-05-13 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1b7bf1bd75dc: [HIP] Do not emit debug info for stub function (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79511: [ObjC] Add compatibility mode for type checking of qualified id block parameters.

2020-05-13 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai updated this revision to Diff 263865. vsapsai added a comment. Squash the commits, so that reviewers can review the entire change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79511/new/ https://reviews.llvm.org/D79511 Files:

[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

2020-05-13 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. In D79744#2035109 , @arsenm wrote: > >> Unfortunately, I think `byval` just doesn't match what you want because of >> the mutability — the frontend *has* to have a copy into a local to get IR >> with correct semantics,

[clang] 1b7bf1b - [HIP] Do not emit debug info for stub function

2020-05-13 Thread Yaxun Liu via cfe-commits
Author: Yaxun (Sam) Liu Date: 2020-05-13T17:55:40-04:00 New Revision: 1b7bf1bd75dcc4a362a83e4abc1200aaa75a38be URL: https://github.com/llvm/llvm-project/commit/1b7bf1bd75dcc4a362a83e4abc1200aaa75a38be DIFF:

[PATCH] D79274: Fix template class debug info for Visual Studio visualizers

2020-05-13 Thread Adrian McCarthy via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa549c0d00486: Fix template class debug info for Visual Studio visualizers (authored by amccarth). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79910: [WIP][seses] Add clang flag; Use lvi-cfi with seses

2020-05-13 Thread Zola Bridges via Phabricator via cfe-commits
zbrid created this revision. zbrid added reviewers: sconstab, craig.topper, mattdr. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. This patch creates a clang flag to enable SESES. This flag also ensures that lvi-cfi is on when using seses via

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

2020-05-13 Thread Melanie Blower via Phabricator via cfe-commits
mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2943 + if (Opts.FastRelaxedMath) +Opts.setDefaultFPContractMode(LangOptions::FPM_Fast); Opts.HexagonQdsp6Compat =

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

2020-05-13 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai requested changes to this revision. smeenai added a comment. This revision now requires changes to proceed. Requesting changes to remove from my review queue while the above comments are being addressed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/

[clang] a549c0d - Fix template class debug info for Visual Studio visualizers

2020-05-13 Thread Adrian McCarthy via cfe-commits
Author: Adrian McCarthy Date: 2020-05-13T14:20:18-07:00 New Revision: a549c0d00486bf01cb485e343d778fe4a3649a43 URL: https://github.com/llvm/llvm-project/commit/a549c0d00486bf01cb485e343d778fe4a3649a43 DIFF:

[PATCH] D79834: Speed up preamble building by replacing the slow translateFile call by a new, faster isMainFile check

2020-05-13 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman updated this revision to Diff 263847. arphaman added a comment. Drop caching, it's not need for the speedup. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79834/new/ https://reviews.llvm.org/D79834 Files: clang/include/clang/Basic/SourceManager.h

[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

2020-05-13 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. In D79744#2030710 , @rjmccall wrote: > Okay. So the only real ABI here is the layout of the memory that the > arguments are actually written into? And that memory needs to be treated as > constant? Yes, the actual kernel ABI

[PATCH] D79237: [CUDA][HIP] Fix constexpr variables for C++17

2020-05-13 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D79237#2031870 , @tra wrote: > > constexpr variables are compile time constants and implicitly const, > > therefore > > they are safe to emit on both device and host side. Besides, in many cases > > they are intended for both

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

2020-05-13 Thread Melanie Blower via Phabricator via cfe-commits
mibintc marked 2 inline comments as done. mibintc added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:227 + FMF.setAllowContract(FPFeatures.allowFPContractAcrossStatement() || + FPFeatures.allowFPContractWithinStatement()); }

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

2020-05-13 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2943 + if (Opts.FastRelaxedMath) +Opts.setDefaultFPContractMode(LangOptions::FPM_Fast); Opts.HexagonQdsp6Compat = Args.hasArg(OPT_mqdsp6_compat); mibintc wrote: > I

[PATCH] D79834: Speed up preamble building by replacing the slow translateFile call by a new, faster isMainFile check

2020-05-13 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. @jkorous it looks like dropping caching works too, this achieves similar perf results. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79834/new/ https://reviews.llvm.org/D79834 ___ cfe-commits mailing list

[PATCH] D74813: Function block naming - add hash of parameter type to end of block name

2020-05-13 Thread Alex Borcan via Phabricator via cfe-commits
alexbdv added a comment. Could I please get a review on this ? Thanks :) ! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74813/new/ https://reviews.llvm.org/D74813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

2020-05-13 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 added a comment. In D79743#2034945 , @zbrid wrote: > In D79743#2034792 , @jyu2 wrote: > > > Two questions: > > 1> What happen under SLH, will asm goto gets removed, or a runtime problem? > > 2> Should we

[PATCH] D79905: [clang-format] [PR44476] Add space between template and attribute

2020-05-13 Thread Jake Merdich via Phabricator via cfe-commits
JakeMerdichAMD added a comment. One spelling nit, but otherwise looks good to me. Comment at: clang/lib/Format/TokenAnnotator.cpp:2900 + + // Space between tempalte and attribute + // e.g. template [[nodiscard]] ... Nit: template Repository: rG LLVM

[PATCH] D79905: [clang-format] [PR44476] Add space between template and attribute

2020-05-13 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, JakeMerdichAMD, mitchell-stellar, sammccall. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay added a reviewer: abrachet. https://bugs.llvm.org/show_bug.cgi?id=44476 template [[nodiscard]] int

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

2020-05-13 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L updated this revision to Diff 263843. Xiangling_L added a comment. Fix a minor issue in the testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/ https://reviews.llvm.org/D74166 Files: clang/include/clang/AST/Mangle.h

[PATCH] D78659: Add nomerge function attribute to supress tail merge optimization in simplifyCFG

2020-05-13 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added inline comments. Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:1305 +if (const auto *CB1 = dyn_cast(I1)) + if (CB1->cannotMerge()) +return Changed; zequanwu wrote: > rnk wrote: > > It seems inconsistent that we don't apply the

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2020-05-13 Thread Luboš Luňák via Phabricator via cfe-commits
llunak updated this revision to Diff 263839. llunak edited the summary of this revision. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69778/new/ https://reviews.llvm.org/D69778 Files: clang/lib/Serialization/ASTReader.cpp

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2020-05-13 Thread Luboš Luňák via Phabricator via cfe-commits
llunak added a comment. In D69778#2032363 , @dblaikie wrote: > So the original commit ( cbc9d22e49b4 > ) was > reverted at some point, and now you're proposing recommitting it with a

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

2020-05-13 Thread Yvan Roux via Phabricator via cfe-commits
yroux updated this revision to Diff 263830. yroux added a comment. I found a last issue when doing a full bootstrap with -moutline used to build clang, there was a case of thunk outlining where the original was call a `BLX LR` which was broken by the outlining call `BL OUTLINE_FUNCTION_X` I

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2020-05-13 Thread Luboš Luňák via Phabricator via cfe-commits
llunak updated this revision to Diff 263838. llunak edited the summary of this revision. llunak added a comment. Updated commit message. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69778/new/ https://reviews.llvm.org/D69778 Files:

[PATCH] D72893: [NewPassManager] Add assertions when getting statefull cached analysis.

2020-05-13 Thread Alina Sbirlea via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbd541b217f4d: [NewPassManager] Add assertions when getting statefull cached analysis. (authored by asbirlea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

2020-05-13 Thread Atmn Patel via Phabricator via cfe-commits
atmnpatel updated this revision to Diff 263832. atmnpatel added a comment. Addresses inline comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 Files:

[PATCH] D79866: [HIP] Do not emit debug info for stub function

2020-05-13 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 263831. yaxunl retitled this revision from "[CUDA][HIP] Do not emit debug info for stub function" to "[HIP] Do not emit debug info for stub function". yaxunl added a comment. limit change to HIP CHANGES SINCE LAST ACTION

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

2020-05-13 Thread Louis Dionne via Phabricator via cfe-commits
ldionne added a comment. @Tyker @rsmith You might be interested in reading https://llvm.org/PR45912, which describes what I believe to be an issue with this patch (or another related patch for `consteval` -- not sure). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79834: Speed up preamble building by replacing the slow translateFile call by a new, faster isMainFile check

2020-05-13 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. In D79834#2034666 , @jkorous wrote: > IIUC the issue is that `SourceManager::translateFile()` basically consists of > two blocks of code: > > // First, check the main file ID, since it is common to look for a > // location

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

2020-05-13 Thread Zola Bridges via Phabricator via cfe-commits
zbrid added a comment. In D79743#2034792 , @jyu2 wrote: > Two questions: > 1> What happen under SLH, will asm goto gets removed, or a runtime problem? > 2> Should we emit error or warning in the Parser instead? 1. SLH crashes with an unhelpful

[PATCH] D79866: [HIP] Do not emit debug info for stub function

2020-05-13 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D79866#2034748 , @tra wrote: > In D79866#2034683 , @yaxunl wrote: > > > can you try set bp by using file name and line number on the kernel? > > > In regular gdb it is set on the stub. >

[PATCH] D79895: Fix warning about using uninitialized variable as function const reference parameter

2020-05-13 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. Arthur recently went through the process of refining a diagnostic, so he should be able to help guide you in this if you have more questions. Comment at: clang/lib/Analysis/UninitializedValues.cpp:425 if ((*I)->getType().isConstQualified()) -

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

2020-05-13 Thread Melanie Blower via Phabricator via cfe-commits
mibintc marked 3 inline comments as done. mibintc added a comment. added some inline explanation Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2943 + if (Opts.FastRelaxedMath) +Opts.setDefaultFPContractMode(LangOptions::FPM_Fast); Opts.HexagonQdsp6Compat =

[PATCH] D79274: Fix template class debug info for Visual Studio visualizers

2020-05-13 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79274/new/ https://reviews.llvm.org/D79274 ___ cfe-commits mailing list

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

2020-05-13 Thread Melanie Blower via Phabricator via cfe-commits
mibintc created this revision. mibintc added reviewers: rjmccall, scanon. Herald added a project: clang. mibintc marked 3 inline comments as done. mibintc added a comment. added some inline explanation Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2943 + if

[clang] bd541b2 - [NewPassManager] Add assertions when getting statefull cached analysis.

2020-05-13 Thread Alina Sbirlea via cfe-commits
Author: Alina Sbirlea Date: 2020-05-13T12:38:38-07:00 New Revision: bd541b217f4d750391677144ccaa586874236f38 URL: https://github.com/llvm/llvm-project/commit/bd541b217f4d750391677144ccaa586874236f38 DIFF: https://github.com/llvm/llvm-project/commit/bd541b217f4d750391677144ccaa586874236f38.diff

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

2020-05-13 Thread Zola Bridges via Phabricator via cfe-commits
zbrid updated this revision to Diff 263819. zbrid added a comment. Update to fix failing test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79743/new/ https://reviews.llvm.org/D79743 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td

[PATCH] D79830: Add support of __builtin_expect_with_probability

2020-05-13 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D79830#2034779 , @LukeZhuang wrote: > In D79830#2033367 , @lebedev.ri > wrote: > > > Thanks for working on this. > > Please upload patch with full context. > > > Hi, sorry but I'm

[PATCH] D79830: Add support of __builtin_expect_with_probability

2020-05-13 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. In D79830#2034779 , @LukeZhuang wrote: > In D79830#2033367 , @lebedev.ri > wrote: > > > Thanks for working on this. > > Please upload patch with full context. > > > Hi, sorry but I'm

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

2020-05-13 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 added a comment. Two questions: 1> What happen under SLH, will asm goto gets removed, or a runtime problem? 2> Should we emit error or warning in the Parser instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79743/new/

[PATCH] D79830: Add support of __builtin_expect_with_probability

2020-05-13 Thread Zhi Zhuang via Phabricator via cfe-commits
LukeZhuang added a comment. In D79830#2033367 , @lebedev.ri wrote: > Thanks for working on this. > Please upload patch with full context. Hi, sorry but I'm not sure what does full context means, is that means I need to show more lines(for example 10

[PATCH] D79894: [clang][slh] Add test for SLH feature checking macro

2020-05-13 Thread Zola Bridges via Phabricator via cfe-commits
zbrid created this revision. zbrid added reviewers: craig.topper, mattdr. Herald added a project: clang. Herald added a subscriber: cfe-commits. I forgot to include a test in this commit: https://reviews.llvm.org/rG379e68a763097bed6c6dc7453e4b732e3d68 Here's the test. It passes after that

[PATCH] D79866: [CUDA][HIP] Do not emit debug info for stub function

2020-05-13 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. In D79866#2034683 , @yaxunl wrote: > can you try set bp by using file name and line number on the kernel? In regular gdb it is set on the stub. In cuda-gdb the behavior is interesting -- it initially gets set and breaks on the

[PATCH] D79895: Fix warning about using uninitialized variable as function const reference parameter

2020-05-13 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu created this revision. zequanwu added reviewers: rsmith, rnk. zequanwu added a project: clang. Herald added a subscriber: cfe-commits. bug filed here: https://bugs.llvm.org/show_bug.cgi?id=45624 Uninitialized variable as function const reference parameter should be use. Repository:

[PATCH] D79796: [DO NOT REVIEW] Sketch support for generating CC1 command line from CompilerInvocation

2020-05-13 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added inline comments. Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:162 // The option identifier name. -OS << ", "<< getOptionName(R); +OS << ", " << getOptionName(R); This whitespace fixup LGTM, but you should commit it

[PATCH] D79866: [CUDA][HIP] Do not emit debug info for stub function

2020-05-13 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D79866#2034460 , @tra wrote: > I do not see the behavior the patch is supposed to fix in CUDA. > If I compile a simple program, host-side debugger does not see the `kernel`, > sees `__device_stub_kernel` and, if the breakpoint

[PATCH] D78120: [analyzer][StreamChecker] Don't make StreamTestChecker depend on StreamChecker for the time being

2020-05-13 Thread Kristóf Umann via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG2a12acda4c9f: [analyzer][StreamChecker] Dont make StreamTestChecker depend on StreamChecker… (authored by Szelethus). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78134: [Sema] Don't apply an lvalue-to-rvalue conversion to a discarded-value expression if it has an array type

2020-05-13 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak updated this revision to Diff 263792. ahatanak marked an inline comment as done. ahatanak added a comment. Check function types in `DefaultLvalueConversion`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78134/new/

[PATCH] D79796: [DO NOT REVIEW] Sketch support for generating CC1 command line from CompilerInvocation

2020-05-13 Thread Daniel Grumberg via Phabricator via cfe-commits
dang updated this revision to Diff 263795. dang added a comment. Rebase on top of llvm/master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://reviews.llvm.org/D79796 Files: clang/include/clang/Frontend/CompilerInvocation.h

[PATCH] D79877: [clang][SveEmitter] SVE builtins for `svusdot` and `svsudot` ACLE.

2020-05-13 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM with one small comment. Comment at: clang/include/clang/Basic/arm_sve.td:1249 +def SVSUDOT_S: SInst<"svsudot[_s32]","ddqb", "i", MergeNone,

[PATCH] D79796: [DO NOT REVIEW] Sketch support for generating CC1 command line from CompilerInvocation

2020-05-13 Thread Daniel Grumberg via Phabricator via cfe-commits
dang updated this revision to Diff 263796. dang added a comment. Upload the right patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://reviews.llvm.org/D79796 Files: clang/include/clang/Driver/CC1Options.td

[PATCH] D79834: Speed up preamble building by replacing the slow translateFile call by a new, faster isMainFile check

2020-05-13 Thread Jan Korous via Phabricator via cfe-commits
jkorous added a comment. IIUC the issue is that `SourceManager::translateFile()` basically consists of two blocks of code: // First, check the main file ID, since it is common to look for a // location in the main file. if (MainFileID.isValid()) { bool Invalid = false; const

[PATCH] D79330: [Analyzer][VLASizeChecker] Check for VLA size overflow.

2020-05-13 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. In D79330#2034414 , @martong wrote: > I am not sure if I can follow your concern here. > `sizeof(size_t)` is typically 8, so that is not a bug,

[PATCH] D79274: Fix template class debug info for Visual Studio visualizers

2020-05-13 Thread Adrian McCarthy via Phabricator via cfe-commits
amccarth updated this revision to Diff 263790. amccarth added a comment. Addressed feedback, specifically: - Distinction is now on CodeView generation rather than -fms-compatibility. - Tests two --std= levels plus the default one. CHANGES SINCE LAST ACTION

[PATCH] D79274: Fix template class debug info for Visual Studio visualizers

2020-05-13 Thread Adrian McCarthy via Phabricator via cfe-commits
amccarth marked 2 inline comments as done. amccarth added a comment. Made the requested changes after an in-person conversation to clear up my earlier confusion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79274/new/ https://reviews.llvm.org/D79274

[PATCH] D79388: [clang-format] Fix AlignConsecutive on PP blocks

2020-05-13 Thread Jake Merdich via Phabricator via cfe-commits
JakeMerdichAMD added a comment. Thanks for the commit and review @MyDeveloperDay! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79388/new/ https://reviews.llvm.org/D79388 ___ cfe-commits mailing list

[PATCH] D78190: Add Bfloat IR type

2020-05-13 Thread Sjoerd Meijer via Phabricator via cfe-commits
SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. Nothing much has changed here: there was already broad consensus on this change and direction, and the last few weeks we have only seen a few rounds of minor comments and nits, so still LGTM. Please wait a day with committing to

[clang] 2a12acd - [analyzer][StreamChecker] Don't make StreamTestChecker depend on StreamChecker for the time being

2020-05-13 Thread Kirstóf Umann via cfe-commits
Author: Kirstóf Umann Date: 2020-05-13T20:05:11+02:00 New Revision: 2a12acda4c9fad4d69dce7a43e99690df357648c URL: https://github.com/llvm/llvm-project/commit/2a12acda4c9fad4d69dce7a43e99690df357648c DIFF: https://github.com/llvm/llvm-project/commit/2a12acda4c9fad4d69dce7a43e99690df357648c.diff

[PATCH] D79201: [clang-format] : Fix additional pointer alignment for overloaded operators

2020-05-13 Thread MyDeveloperDay via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc82243d0675b: [clang-format] : Fix additional pointer alignment for overloaded operators (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79388: [clang-format] Fix AlignConsecutive on PP blocks

2020-05-13 Thread MyDeveloperDay via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb2eb43931757: [clang-format] Fix AlignConsecutive on PP blocks (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79388/new/

  1   2   >