[PATCH] D80966: [codeview] Put !heapallocsite on calls to operator new

dyung added a comment. I've reverted this change in g059ba74bb6f6166ca7c1783ef81dd37a5209b758 to get the bots green again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80966/new/ https://reviews.llvm.org/D80966

[clang] 059ba74 - Revert "[codeview] Put !heapallocsite on calls to operator new"

Author: Douglas Yung Date: 2020-06-06T23:30:46Z New Revision: 059ba74bb6f6166ca7c1783ef81dd37a5209b758 URL: https://github.com/llvm/llvm-project/commit/059ba74bb6f6166ca7c1783ef81dd37a5209b758 DIFF: https://github.com/llvm/llvm-project/commit/059ba74bb6f6166ca7c1783ef81dd37a5209b758.diff LOG:

[PATCH] D72778: [Matrix] Add __builtin_matrix_transpose to Clang.

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:15051 + + Expr *Arg = TheCall->getArg(0); + if (!Arg->getType()->isConstantMatrixType()) { fhahn wrote: > rjmccall wrote: > > When a builtin has custom type-checking (`t`), you need to

[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, lebedev.ri, gribozavr2. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Ignore template instantiations in the matchers, Addresses readability-simplify-boolean-expr false-positive for

[PATCH] D72778: [Matrix] Add __builtin_matrix_transpose to Clang.

fhahn updated this revision to Diff 269032. fhahn marked an inline comment as done. fhahn added a comment. Thanks for all the comments! Simplified code as suggested, handle placeholder expressions and add tests for them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72778: [Matrix] Add __builtin_matrix_transpose to Clang.

fhahn marked 3 inline comments as done. fhahn added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1642 + return cast(Ty.getCanonicalType()); +}; + rjmccall wrote: > Unnecessary semicolon. I think it's probably clearer just to > `castAs()`

[PATCH] D76794: [Matrix] Implement * binary operator for MatrixType.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76794/new/ https://reviews.llvm.org/D76794

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang updated this revision to Diff 269028. LukeZhuang added a reviewer: dexonsmith. LukeZhuang added a comment. **updated: 06/06/2020** (1) updated llvm.expect.with.probability intrinsic document in LangRef.rst CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/

[PATCH] D76794: [Matrix] Implement * binary operator for MatrixType.

fhahn updated this revision to Diff 269027. fhahn marked 2 inline comments as done. fhahn added a comment. In D76794#2078232 , @rjmccall wrote: > Your IRGen test cases cover a lot of ground, but please add more Sema test > cases that go over the basics:

[PATCH] D76794: [Matrix] Implement * binary operator for MatrixType.

fhahn added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:12130 + QualType LHSType = LHS.get()->getType().getUnqualifiedType(); + QualType RHSType = RHS.get()->getType().getUnqualifiedType(); + rjmccall wrote: > You never actually do anything with

[PATCH] D79842: [clang][Driver] Correct tool search path priority

MaskRay added inline comments. Comment at: clang/test/Driver/program-path-priority.c:15 +// "program path" for these tests +// RUN: rm -rf %t +// RUN: mkdir -p %t `rm -rf %t && mkdir -p %t` You can do this on one line Comment at:

[PATCH] D72778: [Matrix] Add __builtin_matrix_transpose to Clang.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1642 + return cast(Ty.getCanonicalType()); +}; + Unnecessary semicolon. I think it's probably clearer just to `castAs()` inline in the code rather than introducing this trivial

[PATCH] D76794: [Matrix] Implement * binary operator for MatrixType.

rjmccall added a comment. Your IRGen test cases cover a lot of ground, but please add more Sema test cases that go over the basics: element types matching, column/row counts matching, multiplication by inappropriate scalars, etc. Otherwise LGTM! Comment at:

[PATCH] D81311: [RFC] LangRef: Define inmem parameter attribute

rjmccall added a comment. In D81311#2077944 , @arsenm wrote: > In D81311#2077868 , @rjmccall wrote: > > > Most of the generalized optimization properties of this attribute seem to > > be redundant with existing

[PATCH] D81311: [RFC] LangRef: Define inmem parameter attribute

rjmccall added a comment. I wonder if `byref` would be a better name for this, as a way to say that the object is semantically a direct argument that's being passed by implicit reference. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81311/new/ https://reviews.llvm.org/D81311

[PATCH] D81254: [analyzer] Produce symbolic values for C-array elements

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1709 if (!O.getRegion()) -return UnknownVal(); +return svalBuilder.getRegionValueSymbolVal(R); As soon as contents of the array change during analysis, this becomes

[PATCH] D81176: [HIP] Add default header and include path

yaxunl added a comment. In D81176#2077940 , @thakis wrote: > One more example failure: > http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/16333 > > (Note I had re-reverted your reland, see the 2 comments above your comment.) Sorry I

[PATCH] D80876: [clang] Default to windows response files when running on windows

mstorsjo added a comment. In D80876#2071997 , @sbc100 wrote: > In D80876#2070233 , @mstorsjo wrote: > > > In D80876#2069970 , @sbc100 wrote: > > > > > Do you know how gcc

[clang] cdd683b - [gcov] Support big-endian .gcno and simplify version handling in .gcda

Author: Fangrui Song Date: 2020-06-06T11:01:47-07:00 New Revision: cdd683b516d147925212724b09ec6fb792a40041 URL: https://github.com/llvm/llvm-project/commit/cdd683b516d147925212724b09ec6fb792a40041 DIFF: https://github.com/llvm/llvm-project/commit/cdd683b516d147925212724b09ec6fb792a40041.diff

[PATCH] D78717: [SystemZ] Implement -fstack-clash-protection

This revision was automatically updated to reflect the committed changes. jonpa marked an inline comment as done. Closed by commit rG515bfc66eace (authored by jonpa). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[clang] 515bfc6 - [SystemZ] Implement -fstack-clash-protection

Author: Jonas Paulsson Date: 2020-06-06T18:38:36+02:00 New Revision: 515bfc66eaced830c03b2ec187bef0d8c4dc6915 URL: https://github.com/llvm/llvm-project/commit/515bfc66eaced830c03b2ec187bef0d8c4dc6915 DIFF:

[PATCH] D81332: Thread safety analysis: Support deferring locks

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, delesley. Herald added a project: clang. Herald added a subscriber: cfe-commits. The standard std::unique_lock can be constructed to manage a lock without initially acquiring it by passing std::defer_lock as second

[PATCH] D81252: [SVE ACLE] Remove redundant bool_t typedef.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd6d2f78fe504: [SVE ACLE] Remove redundant bool_t typedef. (authored by paulwalker-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81252/new/

[clang] d6d2f78 - [SVE ACLE] Remove redundant bool_t typedef.

Author: Paul Walker Date: 2020-06-06T12:31:38Z New Revision: d6d2f78fe504fb7b749b08c10558f42180d83d73 URL: https://github.com/llvm/llvm-project/commit/d6d2f78fe504fb7b749b08c10558f42180d83d73 DIFF: https://github.com/llvm/llvm-project/commit/d6d2f78fe504fb7b749b08c10558f42180d83d73.diff LOG:

[PATCH] D81330: [clang][Sema] SequenceChecker: C++17 sequencing rule for overloaded operators.

riccibruno created this revision. riccibruno added a reviewer: rsmith. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. riccibruno added a parent revision: D81003: [clang][Sema] SequenceChecker: Also visit default arguments.. In C++17 the operand(s) of an overloaded

[PATCH] D80804: [AMDGPU] Introduce Clang builtins to be mapped to AMDGCN atomic inc/dec intrinsics

saiislam updated this revision to Diff 269013. saiislam added a comment. 1. Added 64 bit variants of inc/dec as well 2. Added test cases for 64 bit variants Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80804/new/ https://reviews.llvm.org/D80804

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

riccibruno marked an inline comment as done. riccibruno added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2031-2033 + "%select{|member |static member }0%2" + "%select{| of %3| of struct %4| of union %4| of class %4" + "| of structured binding

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 marked an inline comment as done. Daniel599 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:777 + "or make sure they are both configured the same. " + "Aliased checkers:

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:777 + "or make sure they are both configured the same. " + "Aliased checkers: '{0}', '{1}'", +

[clang] 97a6709 - [ASan][Test] Fix globals test on 32-bit architectures

Author: Marco Elver Date: 2020-06-06T11:23:16+02:00 New Revision: 97a670958c240d469c6baf2d3c601d4dea286069 URL: https://github.com/llvm/llvm-project/commit/97a670958c240d469c6baf2d3c601d4dea286069 DIFF: https://github.com/llvm/llvm-project/commit/97a670958c240d469c6baf2d3c601d4dea286069.diff

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang updated this revision to Diff 269002. LukeZhuang added a comment. Herald added subscribers: Jim, dylanmckay. **updated: 06/06/2020** (1) convert argument to IEEEdouble for different target (2) update tests, add edge cases and llvm test (3) minor change CHANGES SINCE LAST ACTION

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang marked 12 inline comments as done. LukeZhuang added a comment. In D79830#2075038 , @davidxl wrote: > Can you add some tests at the LLVM side? added ll test case Comment at: clang/lib/Sema/SemaChecking.cpp:1818-1819 +

[PATCH] D81315: [Draft] [Prototype] warning for default constructed unique pointer dereferences

xazax.hun added a comment. Hi! Please add the [analyzer] tag in front of your patches as some folks have automated scripts based on that tag to add themselves as subscriber/reviewer. A small debugging/productivity tip, if you add a `printState` method to your checker like in

[PATCH] D81315: [Draft] [Prototype] warning for default constructed unique pointer dereferences

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:46 +}; +} // end of anonymous namespace + You can merge the two anonymous namespaces, this and the one below. Comment at:

[PATCH] D81131: [DebugInfo] Fix assertion for extern void type

yonghong-song updated this revision to Diff 268995. yonghong-song edited the summary of this revision. yonghong-song added a comment. Herald added subscribers: llvm-commits, hiraditya, aprantl. Herald added a project: LLVM. instead of skipping generating debuginfo for "extern void var_name", do