[PATCH] D77592: [clang] Frontend components for the relative vtables ABI

2020-06-09 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Yes, alright. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77592/new/ https://reviews.llvm.org/D77592

[PATCH] D80286: [Analyzer] Allow creation of stack frame for functions without definition

2020-06-09 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware added a comment. In D80286#2083753 , @saugustine wrote: > Unfortunately, after this change there are several variables only used in > asserts, which creates build failures when assertions are disabled. > > I will be submitting

[PATCH] D74731: [Clangd] Fixed assertion when processing extended ASCII characters.

2020-06-09 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Sorry this got stalled, it's important (I hadn't realized we were crashing on *indexing* when boost was included). I've created D81530 derived from this which addresses the previous round of comments and adds a testcase for indexing.

[PATCH] D81530: [clangd] Log rather than assert on bad UTF-8.

2020-06-09 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. sammccall added a subscriber: jaafar. sammccall added a comment. @jaafar would you be able to verify

[PATCH] D81420: Fix size for _ExtInt types with builtins

2020-06-09 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7939 "to a non-const integer (%0 invalid)">; +def err_overflow_builtin_extint_size : Error< + "_ExtInt argument larger than 64-bits to overflow builtin requires runtime "

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

2020-06-09 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/include/clang/Sema/Sema.h:12126 + ExprResult SemaBuiltinMatrixColumnMajorLoadOverload(CallExpr *TheCall, +

[PATCH] D81311: [RFC] LangRef: Define inmem parameter attribute

2020-06-09 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D81311#2083295 , @arsenm wrote: > In D81311#2078235 , @rjmccall wrote: > > > I wonder if `byref` would be a better name for this, as a way to say that > > the object is semantically a

[PATCH] D81530: [clangd] Log rather than assert on bad UTF-8.

2020-06-09 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a subscriber: jaafar. sammccall added a comment. @jaafar would you be able to verify this is equivalent to D74731 for your purposes? If so I'd like to cherrypick this into tho 10.x branch after landing. Repository: rG LLVM Github Monorepo

[PATCH] D81420: Fix size for _ExtInt types with builtins

2020-06-09 Thread Mott, Jeffrey T via Phabricator via cfe-commits
jtmott-intel updated this revision to Diff 269727. jtmott-intel added a comment. Limited diagnostic to *signed* _ExtInt, and added test to verify unsigned works. Reused existing diagnostic message rather than make a new one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81420/new/

[PATCH] D81420: Fix size for _ExtInt types with builtins

2020-06-09 Thread Mott, Jeffrey T via Phabricator via cfe-commits
jtmott-intel marked an inline comment as done. jtmott-intel added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7939 "to a non-const integer (%0 invalid)">; +def err_overflow_builtin_extint_size : Error< + "_ExtInt argument larger than 64-bits

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

2020-06-09 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. @jaafar Thanks for the list, this is really useful for us. These all look reasonable to me, I've filed bugs to track them and if they look good to Haojian too we'll get them merged. See https://github.com/clangd/clangd/issues?q=is%3Aissue+label%3Acherrypick I've

[PATCH] D81479: [BPF] introduce __builtin_bpf_load_u32_to_ptr() intrinsic

2020-06-09 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song added a comment. In D81479#2083933 , @ast wrote: > It feels that the same thing can be represented as inline asm. > What advantage builtin has? Yes, this can be represented as an inline asm. I have a tendency not liking inline assembly

[PATCH] D81479: [BPF] introduce __builtin_bpf_load_u32_to_ptr() intrinsic

2020-06-09 Thread Alexei Starovoitov via Phabricator via cfe-commits
ast added a comment. It feels that the same thing can be represented as inline asm. What advantage builtin has? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81479/new/ https://reviews.llvm.org/D81479

[PATCH] D81479: [BPF] introduce __builtin_bpf_load_u32_to_ptr() intrinsic

2020-06-09 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song updated this revision to Diff 269721. yonghong-song retitled this revision from "[BPF] introduce __builtin_load_u32_to_ptr() intrinsic" to "[BPF] introduce __builtin_bpf_load_u32_to_ptr() intrinsic". yonghong-song edited the summary of this revision. yonghong-song added a comment.

[PATCH] D81522: Fix variables used only in asserts.

2020-06-09 Thread Sterling Augustine via Phabricator via cfe-commits
saugustine created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. saugustine edited the summary of this revision. saugustine added a reviewer: baloghadamsoftware. Herald added a subscriber: rnkovacs. Fix variables used only in asserts. For post-commit

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

2020-06-09 Thread Jeff Trull via Phabricator via cfe-commits
jaafar added a comment. Thnaks very much @hokein . The ones I need are: 9a5c448a31bacc08e73fcae4636094f9b6e2be6a eaf0c89ec5f866b6cef296c542c030bb2cf8481d

[PATCH] D81522: Fix variables used only in asserts.

2020-06-09 Thread Sterling Augustine via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGccd192204da4: Fix variables used only in asserts. (authored by saugustine). Repository: rG LLVM Github Monorepo

[PATCH] D80286: [Analyzer] Allow creation of stack frame for functions without definition

2020-06-09 Thread Sterling Augustine via Phabricator via cfe-commits
saugustine added a comment. Unfortunately, after this change there are several variables only used in asserts, which creates build failures when assertions are disabled. I will be submitting https://reviews.llvm.org/D81522 shortly to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] ccd1922 - Fix variables used only in asserts.

2020-06-09 Thread Sterling Augustine via cfe-commits
Author: Sterling Augustine Date: 2020-06-09T17:19:38-07:00 New Revision: ccd192204da45cc3f4b42f585f04c4f934b21bef URL: https://github.com/llvm/llvm-project/commit/ccd192204da45cc3f4b42f585f04c4f934b21bef DIFF:

[clang] 641d5ac - [X86] Assign a feature to tremont, goldmont, goldmont-plus, icelake-client, and icelake for target multiversioning priority.

2020-06-09 Thread Craig Topper via cfe-commits
Author: Craig Topper Date: 2020-06-09T16:39:41-07:00 New Revision: 641d5ac4d1965990fcf981f153369b038816cd16 URL: https://github.com/llvm/llvm-project/commit/641d5ac4d1965990fcf981f153369b038816cd16 DIFF: https://github.com/llvm/llvm-project/commit/641d5ac4d1965990fcf981f153369b038816cd16.diff

[PATCH] D81444: Make the diagnostic-missing-prototypes put the suggested `static` in front of `const` if exists.

2020-06-09 Thread Vy Nguyen via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa21a46205165: Make the diagnostic-missing-prototypes put the suggested `static` in front of… (authored by oontvoo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

2020-06-09 Thread Joe Burzinski via Phabricator via cfe-commits
Tridacnid added a comment. I did run both of the testing targets you mentioned, but only on Linux. I'll keep an eye on the buildbot, thanks for the info! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79912/new/ https://reviews.llvm.org/D79912

[clang] a21a462 - Make the diagnostic-missing-prototypes put the suggested `static` in front of `const` if exists.

2020-06-09 Thread Vy Nguyen via cfe-commits
Author: Vy Nguyen Date: 2020-06-09T19:34:57-04:00 New Revision: a21a462051659d8e1281af7d11738b8abc0557dc URL: https://github.com/llvm/llvm-project/commit/a21a462051659d8e1281af7d11738b8abc0557dc DIFF: https://github.com/llvm/llvm-project/commit/a21a462051659d8e1281af7d11738b8abc0557dc.diff

[clang] f56659d - Don't use a variable that isn't defined

2020-06-09 Thread Akira Hatanaka via cfe-commits
Author: Akira Hatanaka Date: 2020-06-09T16:07:29-07:00 New Revision: f56659d2bae67b26c016aed6503585d93fbafd23 URL: https://github.com/llvm/llvm-project/commit/f56659d2bae67b26c016aed6503585d93fbafd23 DIFF:

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

2020-06-09 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:524 + CallConv)) +return; EVT ValueVT = Val.getValueType(); I'm not sure I understand why the standard

[PATCH] D81514: [Fuchsia] Set projects and runtimes in the cache file

2020-06-09 Thread Petr Hosek via Phabricator via cfe-commits
phosek created this revision. phosek added a reviewer: leonardchan. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. We make assumptions about what projects and runtimes are enabled when configuring our toolchain build, so we should enable those in the cache file as

[PATCH] D81479: [BPF] introduce __builtin_load_u32_to_ptr() intrinsic

2020-06-09 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song added a comment. In D81479#2083510 , @anakryiko wrote: > IntrinsicsBPF.td uses `__builtin_bpf_load_u32_to_ptr`, while everywhere it is > just `__builtin_load_u32_to_ptr`. I think having bpf prefix there is good, > given this is

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

2020-06-09 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. In D79912#2083477 , @Tridacnid wrote: > Bug report has been closed. I'm seeing some build failures in my inbox but > eyeballing them doesn't make me think this change is related. What is the > expectation for me in this

[PATCH] D80409: [MS ABI] Add mangled type for auto template parameter whose argument kind is Integeral

2020-06-09 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu added a comment. Do you think adding `MSVC2019` to make the name mangling compatible with `MSVC v19.20` is acceptable? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80409/new/ https://reviews.llvm.org/D80409 ___ cfe-commits

[PATCH] D81479: [BPF] introduce __builtin_load_u32_to_ptr() intrinsic

2020-06-09 Thread Andrii Nakryiko via Phabricator via cfe-commits
anakryiko added a comment. IntrinsicsBPF.td uses `__builtin_bpf_load_u32_to_ptr`, while everywhere it is just `__builtin_load_u32_to_ptr`. I think having bpf prefix there is good, given this is bpf-specific. But either way, probably should be consistent everywhere? Repository: rG LLVM

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

2020-06-09 Thread Joe Burzinski via Phabricator via cfe-commits
Tridacnid added a comment. Bug report has been closed. I'm seeing some build failures in my inbox but eyeballing them doesn't make me think this change is related. What is the expectation for me in this scenario? Will I get an email letting me know once the build has been fixed? Repository:

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-06-09 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 269677. gamesh411 added a comment. add ambiguity checking during invocation list parsing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files:

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

2020-06-09 Thread Jason Liu via Phabricator via cfe-commits
jasonliu added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:5217 + else +Mangler.getStream() << D->getName(); +} If I understand correctly, this function will come in pair with `__cxx_global_var_init`. `__cxx_global_var_init` use number as

[PATCH] D79830: Add support of __builtin_expect_with_probability

2020-06-09 Thread David Li via Phabricator via cfe-commits
davidxl accepted this revision. davidxl added a comment. This revision is now accepted and ready to land. LLVM side of change LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/ https://reviews.llvm.org/D79830 ___ cfe-commits

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

2020-06-09 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen added a comment. In D79972#2082017 , @ABataev wrote: > Do you have a test for mapping of something like `arr[0][:n]`, where the base > is an array subscript and the remaining part is an array section? I'm not having it right now, but it seems

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

2020-06-09 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen updated this revision to Diff 269663. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D81444: Make the diagnostic-missing-prototypes put the suggested `static` in front of `const` if exists.

2020-06-09 Thread Vy Nguyen via Phabricator via cfe-commits
oontvoo updated this revision to Diff 269657. oontvoo marked an inline comment as done. oontvoo added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81444/new/ https://reviews.llvm.org/D81444 Files:

[PATCH] D81444: Make the diagnostic-missing-prototypes put the suggested `static` in front of `const` if exists.

2020-06-09 Thread Vy Nguyen via Phabricator via cfe-commits
oontvoo marked 7 inline comments as done. oontvoo added inline comments. Comment at: clang/test/Sema/warn-missing-prototypes.c:62 + +const struct MyStruct get_struct() { // expected-warning{{no previous prototype for function 'get_struct'}} +

[clang-tools-extra] 2a3ac01 - Reland [clangd] Resolve driver symlinks, and look up unknown relative drivers in PATH.

2020-06-09 Thread Sam McCall via cfe-commits
Author: Sam McCall Date: 2020-06-09T23:07:28+02:00 New Revision: 2a3ac01b689bb662d4b59ecf03e5f779d640a4ce URL: https://github.com/llvm/llvm-project/commit/2a3ac01b689bb662d4b59ecf03e5f779d640a4ce DIFF: https://github.com/llvm/llvm-project/commit/2a3ac01b689bb662d4b59ecf03e5f779d640a4ce.diff

[PATCH] D81311: [RFC] LangRef: Define inmem parameter attribute

2020-06-09 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. In D81311#2078235 , @rjmccall wrote: > I wonder if `byref` would be a better name for this, as a way to say that the > object is semantically a direct argument that's being passed by implicit > reference. This is probably a

[clang] 856ba63 - [clang][NFC] Fix and simplify the test added in 8dcc7eecb75b39d723fd6fee566369bf67e43fdf

2020-06-09 Thread Bruno Ricci via cfe-commits
Author: Bruno Ricci Date: 2020-06-09T21:17:19+01:00 New Revision: 856ba638d57ead6df85a4ff39531282c6c110232 URL: https://github.com/llvm/llvm-project/commit/856ba638d57ead6df85a4ff39531282c6c110232 DIFF: https://github.com/llvm/llvm-project/commit/856ba638d57ead6df85a4ff39531282c6c110232.diff

[PATCH] D81439: [X86] Move CPUKind enum from clang to llvm/lib/Support. NFCI

2020-06-09 Thread Craig Topper via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd5c28c409432: [X86] Move CPUKind enum from clang to llvm/lib/Support. NFCI (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-06-09 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 269644. gamesh411 added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files: clang/docs/analyzer/user-docs/CrossTranslationUnit.rst

[PATCH] D80462: Fix floating point math function attributes definition.

2020-06-09 Thread Michele Scandale via Phabricator via cfe-commits
michele.scandale added a comment. As far as I can tell the failures reported shouldn't be caused by this change. John, would you be able to land this on my behalf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80462/new/

[PATCH] D80263: [HeaderSearch] Fix processing #import-ed headers multiple times with modules enabled.

2020-06-09 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai added a comment. Ping. Also suggested clang-format linter changes make the test useless as the order of imports is important. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80263/new/ https://reviews.llvm.org/D80263

[PATCH] D79830: Add support of __builtin_expect_with_probability

2020-06-09 Thread Zhi Zhuang via Phabricator via cfe-commits
LukeZhuang updated this revision to Diff 269642. LukeZhuang added a comment. **updated: 06/09/2020** (1) improve code in LowerExpectIntrinsic (2) update and simplify test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/ https://reviews.llvm.org/D79830 Files:

[PATCH] D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs

2020-06-09 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM (after a minor comment), thank you for fixing this! Comment at: clang/lib/Serialization/ASTReaderStmt.cpp:3598 + S = new (Context)

[PATCH] D81444: Make the diagnostic-missing-prototypes put the suggested `static` in front of `const` if exists.

2020-06-09 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:1302 +bool Lexer::isConst(SourceLocation Loc, const SourceManager , +const LangOptions ) { I'm concerned about putting this API into Lexer, given this implementation. It

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-06-09 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 269639. gamesh411 added a comment. add ambiguous invocation list test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files:

[PATCH] D80932: [SYCL] Make default address space a superset of OpenCL address spaces.

2020-06-09 Thread Alexey Bader via Phabricator via cfe-commits
bader added a comment. In D80932#2080631 , @Anastasia wrote: > > @Anastasia, if we make this change specific to SYCL mode, will it address > > your concerns? > > I can't answer this question for the reasons I have explained above. Sorry, I'm not sure

[libunwind] 168681a - [libc++abi][libunwind] Don't override libc++'s handling of exception features

2020-06-09 Thread Louis Dionne via cfe-commits
Author: Louis Dionne Date: 2020-06-09T16:03:22-04:00 New Revision: 168681abce63d9cc0cec24cfc1d0caef6fa3a25f URL: https://github.com/llvm/llvm-project/commit/168681abce63d9cc0cec24cfc1d0caef6fa3a25f DIFF: https://github.com/llvm/llvm-project/commit/168681abce63d9cc0cec24cfc1d0caef6fa3a25f.diff

[clang] d5c28c4 - [X86] Move CPUKind enum from clang to llvm/lib/Support. NFCI

2020-06-09 Thread Craig Topper via cfe-commits
Author: Craig Topper Date: 2020-06-09T12:52:41-07:00 New Revision: d5c28c4094324e94f6eee403022ca21c8d76998e URL: https://github.com/llvm/llvm-project/commit/d5c28c4094324e94f6eee403022ca21c8d76998e DIFF: https://github.com/llvm/llvm-project/commit/d5c28c4094324e94f6eee403022ca21c8d76998e.diff

[clang] 90ee8cf - Undo change inadvertently added in 113b0d7d

2020-06-09 Thread Erich Keane via cfe-commits
Author: Erich Keane Date: 2020-06-09T12:41:52-07:00 New Revision: 90ee8cf63613df525c4dab5e715fbae5f7310a78 URL: https://github.com/llvm/llvm-project/commit/90ee8cf63613df525c4dab5e715fbae5f7310a78 DIFF: https://github.com/llvm/llvm-project/commit/90ee8cf63613df525c4dab5e715fbae5f7310a78.diff

[PATCH] D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option

2020-06-09 Thread Zixu Wang via Phabricator via cfe-commits
zixuw added inline comments. Comment at: clang/lib/Lex/PPExpressions.cpp:262 + // string to UndefPrefixes as an explicit "-Wundef" does. + if (UndefPrefixes.empty() || + llvm::any_of(UndefPrefixes, ributzka wrote: > What happens

[PATCH] D57626: Disallow trivial_abi on a class if all copy and move constructors are deleted

2020-06-09 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added a comment. Yes, I'm still interested in pursuing this. I'll rebase the patch and commit it if I don't get any more feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57626/new/ https://reviews.llvm.org/D57626

[PATCH] D57626: Disallow trivial_abi on a class if all copy and move constructors are deleted

2020-06-09 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak updated this revision to Diff 269633. ahatanak added a comment. Rebase patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57626/new/ https://reviews.llvm.org/D57626 Files: clang/include/clang/Basic/AttrDocs.td

[PATCH] D77836: [Attribute] Fix noderef attribute false-negatives

2020-06-09 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. Lemme know if there's any more feedback. Will aim for committing this sometime at the end of the day. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77836/new/ https://reviews.llvm.org/D77836

[libunwind] 0e04342 - [NFCI] Clean up exceptions related CMake and Lit options in libc++abi and libunwind

2020-06-09 Thread Louis Dionne via cfe-commits
Author: Louis Dionne Date: 2020-06-09T15:34:29-04:00 New Revision: 0e04342ae0399876f3488464d12f5a4da5085456 URL: https://github.com/llvm/llvm-project/commit/0e04342ae0399876f3488464d12f5a4da5085456 DIFF: https://github.com/llvm/llvm-project/commit/0e04342ae0399876f3488464d12f5a4da5085456.diff

[clang] 113b0d7 - PR46255: Fix field diagnostics for C records with anonymous members.

2020-06-09 Thread Erich Keane via cfe-commits
Author: Erich Keane Date: 2020-06-09T12:27:44-07:00 New Revision: 113b0d7d0bd637743efb050ad619dd0c6d306e96 URL: https://github.com/llvm/llvm-project/commit/113b0d7d0bd637743efb050ad619dd0c6d306e96 DIFF: https://github.com/llvm/llvm-project/commit/113b0d7d0bd637743efb050ad619dd0c6d306e96.diff

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

2020-06-09 Thread Nathan James via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGce5fecb7d0a1: Assignment and Inc/Dec operators wouldnt register as a mutation when Implicit… (authored by Tridacnid, committed by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

2020-06-09 Thread Daniel via Phabricator via cfe-commits
Daniel599 added a comment. Any additional changes/fixes regarding this patch? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80753/new/ https://reviews.llvm.org/D80753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

2020-06-09 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. In D79912#2082337 , @Tridacnid wrote: > tridac...@gmail.com > > https://github.com/Tridacnid > > Thanks! I've commited it on your behalf,

[PATCH] D81444: Make the diagnostic-missing-prototypes put the suggested `static` in front of `const` if exists.

2020-06-09 Thread Vy Nguyen via Phabricator via cfe-commits
oontvoo updated this revision to Diff 269627. oontvoo marked an inline comment as done. oontvoo added a comment. - Less brittle way to find the loc of const. - Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81444/new/

[PATCH] D81444: Make the diagnostic-missing-prototypes put the suggested `static` in front of `const` if exists.

2020-06-09 Thread Vy Nguyen via Phabricator via cfe-commits
oontvoo marked an inline comment as done. oontvoo added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14252 + FD->getReturnType().isConstQualified()) +return FD->getReturnTypeSourceRange().getBegin().getLocWithOffset( +

[PATCH] D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option

2020-06-09 Thread Zixu Wang via Phabricator via cfe-commits
zixuw updated this revision to Diff 269628. zixuw added a comment. Update test case for `#pragma clang diagnostic` Update test case to verify that the state of `-Wundef` can still be modified using `#pragma clang diagnostic` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d31c9e5 - Change filecheck default to dump input on failure

2020-06-09 Thread Mehdi Amini via cfe-commits
Author: Mehdi Amini Date: 2020-06-09T18:57:46Z New Revision: d31c9e5a46ee692daf2430b52626afcea1db18ab URL: https://github.com/llvm/llvm-project/commit/d31c9e5a46ee692daf2430b52626afcea1db18ab DIFF: https://github.com/llvm/llvm-project/commit/d31c9e5a46ee692daf2430b52626afcea1db18ab.diff LOG:

[clang-tools-extra] ce5fecb - Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

2020-06-09 Thread Nathan James via cfe-commits
Author: Tridacnid Date: 2020-06-09T19:45:57+01:00 New Revision: ce5fecb7d0a12c27763afe3f89d1d7e8a1893dc0 URL: https://github.com/llvm/llvm-project/commit/ce5fecb7d0a12c27763afe3f89d1d7e8a1893dc0 DIFF: https://github.com/llvm/llvm-project/commit/ce5fecb7d0a12c27763afe3f89d1d7e8a1893dc0.diff

[PATCH] D81481: Change debuginfo check for addHeapAllocSiteMetadata

2020-06-09 Thread Arthur Eubanks via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbc38793852c0: Change debuginfo check for addHeapAllocSiteMetadata (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81481/new/

[PATCH] D81422: Change filecheck default to dump input on failure

2020-06-09 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny accepted this revision. jdenny added a comment. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81422/new/ https://reviews.llvm.org/D81422 ___ cfe-commits mailing list

[PATCH] D80730: [OPENMP50]Codegen for use_device_addr clauses.

2020-06-09 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev updated this revision to Diff 269618. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80730/new/ https://reviews.llvm.org/D80730 Files: clang/lib/AST/OpenMPClause.cpp clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-06-09 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 269615. gamesh411 added a comment. use consumeError in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files:

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

2020-06-09 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. Bumping for review. Are there additional reviewers we can entrust code review to, to help share the code review responsibility? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/

[PATCH] D81439: [X86] Move CPUKind enum from clang to llvm/lib/Support. NFCI

2020-06-09 Thread Craig Topper via Phabricator via cfe-commits
craig.topper updated this revision to Diff 269610. craig.topper added a comment. Flip polarity of the bool and rename it. Add doxygen comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81439/new/ https://reviews.llvm.org/D81439 Files: clang/include/clang/Basic/X86Target.def

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

2020-06-09 Thread Dave Green via Phabricator via cfe-commits
dmgreen added reviewers: efriedma, ostannard, SjoerdMeijer. dmgreen added a comment. Love it. This will help optimise these more too. We can currently get into places where we can't prove only the bottom bits of a returned value are demanded so can't remove unnecessary vmovs. Test look good too

[PATCH] D81479: [BPF] introduce __builtin_load_u32_to_ptr() intrinsic

2020-06-09 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song marked an inline comment as done. yonghong-song added inline comments. Comment at: clang/test/CodeGen/builtin-bpf-load-u32-to-ptr.c:5 +struct t { int a; int b; }; +void *test(struct t *arg) { return __builtin_load_u32_to_ptr(arg, 4); } + ast wrote:

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

2020-06-09 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:11571 + Diag(Loc, + getLangOpts().C11 + ? diag::ext_typecheck_compare_complete_incomplete_pointers rsmith wrote: > pestctrl wrote: > > efriedma

[clang] bc38793 - Change debuginfo check for addHeapAllocSiteMetadata

2020-06-09 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2020-06-09T11:01:06-07:00 New Revision: bc38793852c0552337bae54961eb14fb0bacf356 URL: https://github.com/llvm/llvm-project/commit/bc38793852c0552337bae54961eb14fb0bacf356 DIFF:

[PATCH] D81484: [Clang][OpenMP][OMPBuilder] (4/4) Privatize `parallel` for `OMPBuilder`

2020-06-09 Thread Fady Ghanim via Phabricator via cfe-commits
fghanim marked 6 inline comments as done. fghanim added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1777 } + +bool CodeGenFunction::OMPBuilderCBHelpers::EmitOMPFirstprivateClause( Same as current implementation, with certain changes around

[PATCH] D81481: Change debuginfo check for addHeapAllocSiteMetadata

2020-06-09 Thread Amy Huang via Phabricator via cfe-commits
akhuang accepted this revision. akhuang added a comment. This revision is now accepted and ready to land. lgtm, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81481/new/ https://reviews.llvm.org/D81481

[PATCH] D81479: [BPF] introduce __builtin_load_u32_to_ptr() intrinsic

2020-06-09 Thread Alexei Starovoitov via Phabricator via cfe-commits
ast added inline comments. Comment at: clang/test/CodeGen/builtin-bpf-load-u32-to-ptr.c:5 +struct t { int a; int b; }; +void *test(struct t *arg) { return __builtin_load_u32_to_ptr(arg, 4); } + can it be expressed as: __builtin_load_u32_to_ptr(>b) ?

[PATCH] D81422: Change filecheck default to dump input on failure

2020-06-09 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini updated this revision to Diff 269581. mehdi_amini marked 4 inline comments as done. mehdi_amini edited the summary of this revision. mehdi_amini added a comment. Address @jdenny's comments: - fix the example in lit.local.cfg - Test the default value for dump-input Repository: rG

[PATCH] D81422: Change filecheck default to dump input on failure

2020-06-09 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added inline comments. Comment at: llvm/test/FileCheck/lit.local.cfg:42 # ; RUN: %ProtectFileCheckOutput FILECHECK_OPTS=-v \ # ; RUN: FileCheck -input-file %s %s 2>&1 \ # ; RUN: | FileCheck -check-prefix TRACE %s jdenny wrote: > Please add

[PATCH] D81222: [WebAssembly] Implement prototype SIMD rounding instructions

2020-06-09 Thread Thomas Lively via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb7d369280ba6: [WebAssembly] Implement prototype SIMD rounding instructions (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81222/new/

[PATCH] D80944: Add begin source location for the attributed statement created from PragmaLoopHint decorated loop

2020-06-09 Thread Yuanfang Chen via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9c2e770034d0: Add begin source location for the attributed statement created from… (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80804: [AMDGPU] Introduce Clang builtins to be mapped to AMDGCN atomic inc/dec intrinsics

2020-06-09 Thread Saiyedul Islam via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG675cefbf6027: [AMDGPU] Introduce Clang builtins to be mapped to AMDGCN atomic inc/dec… (authored by saiislam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81483: [Clang][OpenMP][OMPBuilder] (3/4) Privatize `parallel` for `OMPBuilder`

2020-06-09 Thread Fady Ghanim via Phabricator via cfe-commits
fghanim marked 3 inline comments as done. fghanim added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1554 llvm::SmallVectorImpl &) {} +bool CodeGenFunction::OMPBuilderCBHelpers::EmitOMPCopyinClause( Note

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

2020-06-09 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:11571 + Diag(Loc, + getLangOpts().C11 + ? diag::ext_typecheck_compare_complete_incomplete_pointers pestctrl wrote: > efriedma wrote: > > I think this

[PATCH] D79677: [clang][OpenMP][OMPIRBuilder] Adding some Privatization clauses to OpenMP `parallel` Directive

2020-06-09 Thread Fady Ghanim via Phabricator via cfe-commits
fghanim added a comment. @jdoerfert Please suggest reviewer's for this, and I will add them to other clang related patches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79677/new/ https://reviews.llvm.org/D79677

[PATCH] D79677: [clang][OpenMP][OMPIRBuilder] Adding some Privatization clauses to OpenMP `parallel` Directive

2020-06-09 Thread Fady Ghanim via Phabricator via cfe-commits
fghanim updated this revision to Diff 269589. fghanim added a comment. Herald added subscribers: aaron.ballman, sstefan1. - rebase - splitting patch into 4 ( this, D81482 , D81483 , D81484 ) -

[PATCH] D81484: [Clang][OpenMP][OMPBuilder] (4/4) Privatize `parallel` for `OMPBuilder`

2020-06-09 Thread Fady Ghanim via Phabricator via cfe-commits
fghanim created this revision. fghanim added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl. Herald added a project: clang. fghanim added a child revision: D79677: [clang][OpenMP][OMPIRBuilder] Adding some Privatization clauses to OpenMP `parallel`

[PATCH] D80944: Add begin source location for the attributed statement created from PragmaLoopHint decorated loop

2020-06-09 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen updated this revision to Diff 269586. ychen added a comment. - address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80944/new/ https://reviews.llvm.org/D80944 Files: clang/lib/Parse/ParsePragma.cpp

[PATCH] D81482: [Clang][OpenMP][OMPBuilder] (2/4) Privatize `parallel` for `OMPBuilder`

2020-06-09 Thread Fady Ghanim via Phabricator via cfe-commits
fghanim created this revision. fghanim added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl. Herald added a project: clang. fghanim added a child revision: D79677: [clang][OpenMP][OMPIRBuilder] Adding some Privatization clauses to OpenMP `parallel`

[PATCH] D81483: [Clang][OpenMP][OMPBuilder] (3/4) Privatize `parallel` for `OMPBuilder`

2020-06-09 Thread Fady Ghanim via Phabricator via cfe-commits
fghanim created this revision. fghanim added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, aaron.ballman, sstefan1, guansong, yaxunl. Herald added a project: clang. fghanim added a child revision: D79677: [clang][OpenMP][OMPIRBuilder] Adding some Privatization clauses to OpenMP

[PATCH] D79676: [Clang][OpenMP][OMPBuilder] Moving OMP allocation and cache creation code to OMPBuilderCBHelpers

2020-06-09 Thread Fady Ghanim via Phabricator via cfe-commits
fghanim updated this revision to Diff 269584. fghanim added a comment. Herald added a subscriber: sstefan1. - rebase - addressing reviewer's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79676/new/ https://reviews.llvm.org/D79676 Files:

[PATCH] D81481: Change debuginfo check for addHeapAllocSiteMetadata

2020-06-09 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks created this revision. aeubanks added a reviewer: akhuang. Herald added a project: clang. Herald added a subscriber: cfe-commits. Move check inside of addHeapAllocSiteMetadata(). Change check to DebugInfo <= DebugLineTablesOnly. Repository: rG LLVM Github Monorepo

[PATCH] D81390: [KernelAddressSanitizer] Make globals constructors compatible with kernel [v2]

2020-06-09 Thread Marco Elver via Phabricator via cfe-commits
melver updated this revision to Diff 269582. melver added a comment. Fix test broken by linter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81390/new/ https://reviews.llvm.org/D81390 Files: clang/test/CodeGen/asan-globals.cpp

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

2020-06-09 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79719/new/ https://reviews.llvm.org/D79719

[PATCH] D81439: [X86] Move CPUKind enum from clang to llvm/lib/Support. NFCI

2020-06-09 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: clang/lib/Basic/Targets/X86.h:132 protected: - /// Enumeration of all of the X86 CPUs supported by Clang. - /// - /// Each enumeration represents a particular CPU supported by Clang. These - /// loosely correspond to the options

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

2020-06-09 Thread Fady Ghanim via Phabricator via cfe-commits
fghanim updated this revision to Diff 269583. fghanim added a comment. Herald added a subscriber: aaron.ballman. - Rebase + refactor based on D80222 - addressed reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81427: [hip] Fix device-only relocatable code compilation.

2020-06-09 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81427/new/ https://reviews.llvm.org/D81427

  1   2   3   >