[clang] b3d1092 - Restore part of D80450 [CUDA][HIP] Fix implicit HD function resolution

2020-06-10 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2020-06-10T22:33:33-07:00 New Revision: b3d10920e13446efaebb201612328cf0644709f8 URL: https://github.com/llvm/llvm-project/commit/b3d10920e13446efaebb201612328cf0644709f8 DIFF: https://github.com/llvm/llvm-project/commit/b3d10920e13446efaebb201612328cf0644709f8.diff

[clang] ed34140 - [X86] Move X86 stuff out of TargetParser.h and into the recently created X86TargetParser.h. NFC

2020-06-10 Thread Craig Topper via cfe-commits
Author: Craig Topper Date: 2020-06-10T22:06:34-07:00 New Revision: ed34140e1146e188686f479bd954dea11a2d26d8 URL: https://github.com/llvm/llvm-project/commit/ed34140e1146e188686f479bd954dea11a2d26d8 DIFF: https://github.com/llvm/llvm-project/commit/ed34140e1146e188686f479bd954dea11a2d26d8.diff

[PATCH] D81622: [Clang] Search computed sysroot for libc++ header paths

2020-06-10 Thread Ryan Prichard via Phabricator via cfe-commits
rprichard updated this revision to Diff 270030. rprichard added a comment. Remove unnecessary `virtual` keyword. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81622/new/ https://reviews.llvm.org/D81622 Files:

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

2020-06-10 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/include/clang/AST/Mangle.h:178 + virtual void mangleDynamicDestructor(const VarDecl *D, raw_ostream ) = 0; + I am not sure "destructor" is the right term here. This seems to be an analogue to

[PATCH] D81624: [CodeGen] Simplify the way lifetime of block captures is extended

2020-06-10 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. This is a great improvement, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81624/new/ https://reviews.llvm.org/D81624

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

2020-06-10 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:562 +static std::string getTransformedFileName(llvm::Module ) { + SmallString<128> FileName = llvm::sys::path::filename(M.getName()); Consider having the

[PATCH] D81622: [Clang] Search computed sysroot for libc++ header paths

2020-06-10 Thread Stephen Hines via Phabricator via cfe-commits
srhines added a comment. Thanks, Ryan, for diagnosing and addressing this bug. Comment at: clang/lib/Driver/ToolChains/Linux.h:45 llvm::opt::ArgStringList ) const override; - virtual std::string computeSysRoot() const; + virtual std::string

[clang] af00eb2 - Fix __clang_cuda_math_forward_declares.h

2020-06-10 Thread Yaxun Liu via cfe-commits
Author: Yaxun (Sam) Liu Date: 2020-06-10T23:47:13-04:00 New Revision: af00eb25f890ecbf02818f1466da8f30d93e6298 URL: https://github.com/llvm/llvm-project/commit/af00eb25f890ecbf02818f1466da8f30d93e6298 DIFF:

[PATCH] D81420: Fix size for _ExtInt types with builtins

2020-06-10 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/test/Sema/builtins-overflow.c:39 +_ExtInt(129) result; +_Bool status = __builtin_mul_overflow(x, y, ); // expected-error {{signed _ExtInt of bit sizes greater than 128 not supported}} + } jtmott-intel

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

2020-06-10 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:4447 + + // Create __dtor function for the var decl. + llvm::Function *dtorStub = CGF.createAtExitStub(D, dtor, addr); We should probably report_fatal_error if

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

2020-06-10 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:524 + CallConv)) +return; EVT ValueVT = Val.getValueType(); pratlucas wrote: > efriedma wrote: > > I'm not sure I

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

2020-06-10 Thread Jason Liu via Phabricator via cfe-commits
jasonliu added inline comments. Comment at: clang/lib/CodeGen/CGCXXABI.h:113 + + virtual bool isCXXGlobalInitAndDtorFuncInternal() const { return true; } + Xiangling_L wrote: > jasonliu wrote: > > Do we need this isCXXGlobalInitAndDtorFuncInternal? Looks like

[PATCH] D81627: [HIP] Do not call opt/llc for -fno-gpu-rdc

2020-06-10 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a subscriber: tpr. Currently HIP toolchain calls clang to emit bitcode then calls opt/llc for device compilation for the default -fno-gpu-rdc case, which is unnecessary since clang is able to compile a single source file

[PATCH] D81045: [LLVM] Change isa<> to a variadic function template

2020-06-10 Thread Rahul Joshi via Phabricator via cfe-commits
jurahul updated this revision to Diff 270015. jurahul edited the summary of this revision. jurahul added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81045/new/ https://reviews.llvm.org/D81045 Files:

[PATCH] D81622: [Clang] Search computed sysroot for libc++ header paths

2020-06-10 Thread Ryan Prichard via Phabricator via cfe-commits
rprichard added reviewers: srhines, danalbert, libc++, kristina. rprichard added a comment. FWIW, `computeSysRoot` is overridden by these toolchains: - Linux - MSP430ToolChain - MipsLLVMToolChain - RISCVToolChain I think this change restores the pre D69758

[PATCH] D81624: [CodeGen] Simplify the way lifetime of block captures is extended

2020-06-10 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added a comment. To clarify my comment, the lifetime of the block capture in `test22` gets extended to the end of the enclosing scope, but of course not beyond the end of the return statement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81624: [CodeGen] Simplify the way lifetime of block captures is extended

2020-06-10 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak created this revision. ahatanak added a reviewer: rjmccall. ahatanak added a project: clang. Herald added subscribers: ributzka, jfb, dexonsmith, jkorous. Rather than pushing inactive cleanups for the block captures at the entry of a full expression and activating them during the

[PATCH] D81622: [Clang] Search computed sysroot for libc++ header paths

2020-06-10 Thread Ryan Prichard via Phabricator via cfe-commits
rprichard updated this revision to Diff 270009. rprichard added a comment. Reverse clang-format's change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81622/new/ https://reviews.llvm.org/D81622 Files: clang/include/clang/Driver/ToolChain.h

[PATCH] D81622: [Clang] Search computed sysroot for libc++ header paths

2020-06-10 Thread Ryan Prichard via Phabricator via cfe-commits
rprichard updated this revision to Diff 270005. rprichard added a comment. Rerun after installing clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81622/new/ https://reviews.llvm.org/D81622 Files:

[PATCH] D81622: [Clang] Search computed sysroot for libc++ header paths

2020-06-10 Thread Ryan Prichard via Phabricator via cfe-commits
rprichard created this revision. Herald added subscribers: cfe-commits, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, MaskRay, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb.

[PATCH] D81615: [clang] CWG 2082 and 2346: loosen the restrictions on parameters and local variables in default arguments.

2020-06-10 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: clang/test/CXX/dcl.decl/dcl.meaning/dcl.fct.default/p9.cpp:8 + // expected-error@-1 {{default argument references parameter 'x'}} + void f4(int x, int y = x + 0); + // expected-error@-1 {{default argument references parameter 'x'}}

[clang] dfc0d94 - Revert D80450 "[CUDA][HIP] Fix implicit HD function resolution"

2020-06-10 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2020-06-10T17:42:28-07:00 New Revision: dfc0d9475556cb04f443f728e68cf8c7afa904eb URL: https://github.com/llvm/llvm-project/commit/dfc0d9475556cb04f443f728e68cf8c7afa904eb DIFF: https://github.com/llvm/llvm-project/commit/dfc0d9475556cb04f443f728e68cf8c7afa904eb.diff

[PATCH] D81552: [ASTMatchers] Added hasDirectBase and hasClass Matchers

2020-06-10 Thread Nathan James via Phabricator via cfe-commits
njames93 marked 2 inline comments as done. njames93 added a comment. In D81552#2086420 , @jkorous wrote: > @njames93 `hasDirectBase` seems like a useful matcher to me! OTOH I am not > totally convinced about `hasType` -> `hasClass`. Anyway, don't you

[PATCH] D81420: Fix size for _ExtInt types with builtins

2020-06-10 Thread Mott, Jeffrey T via Phabricator via cfe-commits
jtmott-intel updated this revision to Diff 269995. jtmott-intel added a comment. This updated patch prepared before John's latest comments. - Changed diagnostic message to something halfway between John and Erich's suggestions. - Removed superfluous calls to Arg.get. - Combined call to Diag and

[PATCH] D81552: [ASTMatchers] Added hasDirectBase and hasClass Matchers

2020-06-10 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 27. njames93 added a comment. - Added back `hasType` overload for `CXXBaseSpecifier` - Added `hasClassTemplate` and `hasClassOrClassTemplate` matcher for `CXXBaseSpecifier` - Added `hasTemplatedDecl` for `ClassTemplateDecl` Repository: rG LLVM

[PATCH] D77194: [clang] Persist Attr::IsPackExpansion into the PCH

2020-06-10 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In D77194#2086245 , @sammccall wrote: > @rsmith are you OK with merging this into the release branch for 10.0.1? > cc @tstellar Yes, please do. (I would like for us to eventually maintain AST file format compatibility between

[PATCH] D81552: [ASTMatchers] Added hasDirectBase and hasClass Matchers

2020-06-10 Thread Jan Korous via Phabricator via cfe-commits
jkorous added a comment. @njames93 `hasDirectBase` seems like a useful matcher to me! OTOH I am not totally convinced about `hasType` -> `hasClass`. Anyway, don't you want to land `hasDirectBase` as a separate patch first and then discuss the rest? One more thing - I'm just thinking if there

[PATCH] D81420: Fix size for _ExtInt types with builtins

2020-06-10 Thread Mott, Jeffrey T via Phabricator via cfe-commits
jtmott-intel marked 6 inline comments as done. jtmott-intel added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7939 "to a non-const integer (%0 invalid)">; +def err_overflow_builtin_extint_size : Error< + "_ExtInt argument larger than 64-bits

[PATCH] D81615: [clang] CWG 2082 and 2346: loosen the restrictions on parameters and local variables in default arguments.

2020-06-10 Thread Erich Keane via Phabricator via cfe-commits
erichkeane accepted this revision. erichkeane added a comment. This looks like the right interpretation of the standard/implementation to me. But please do not commit on this accept for another day or two to give the rest a chance to look. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D81615: [clang] CWG 2082 and 2346: loosen the restrictions on parameters and local variables in default arguments.

2020-06-10 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith marked 2 inline comments as done. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:98 +// +if (DRE->isNonOdrUse() != NOUR_Unevaluated) + return

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

2020-06-10 Thread Jason Liu via Phabricator via cfe-commits
jasonliu added inline comments. Comment at: clang/include/clang/AST/RecordLayout.h:75 + // can be different than Alignment in cases where it is beneficial for + // performance. + CharUnits PreferredAlignment; nit for comment: I don't think it's related to

[PATCH] D81311: [RFC] LangRef: Define inmem parameter attribute

2020-06-10 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D81311#2086227 , @jdoerfert wrote: > Do we allow `inmem` to be used for other purposes? I would assume the answer > is yes, as we do not forbid it. I don't know what else we might use it for off-hand, but yes, I think the

[PATCH] D81420: Fix size for _ExtInt types with builtins

2020-06-10 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:327 return true; TheCall->setArg(2, Arg.get()); } I know this is existing code, but this is a broken mess. Please change this to: ``` ExprResult Arg =

[PATCH] D81530: [clangd] Log rather than assert on bad UTF-8.

2020-06-10 Thread Jeff Trull via Phabricator via cfe-commits
jaafar added a comment. Thanks for the detailed analysis! I have filed https://github.com/boostorg/spirit/issues/612 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81530/new/ https://reviews.llvm.org/D81530

[PATCH] D81616: [clang] Convert a default argument expression to the parameter type before checking that the default argument is valid with CheckDefaultArgumentVisitor.

2020-06-10 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno created this revision. riccibruno added reviewers: bkramer, rjmccall, rsmith, erichkeane. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. riccibruno added a parent revision: D81615: [clang] CWG 2082 and 2346: loosen the restrictions on parameters and local

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

2020-06-10 Thread Fady Ghanim via Phabricator via cfe-commits
fghanim added a comment. you are responding to a comment from 2 weeks ago, so let's just move on. I uploaded a new patch yesterday. You have any comments on this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79675/new/

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

2020-06-10 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers updated this revision to Diff 269981. nickdesaulniers added a comment. - update comment to CODEGENOPT - avoid BooleanFFlag group Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 Files:

[PATCH] D77194: [clang] Persist Attr::IsPackExpansion into the PCH

2020-06-10 Thread Sam McCall via Phabricator via cfe-commits
sammccall added subscribers: tstellar, rsmith, sammccall. sammccall added a comment. @rsmith are you OK with merging this into the release branch for 10.0.1? cc @tstellar Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77194/new/

[PATCH] D81311: [RFC] LangRef: Define inmem parameter attribute

2020-06-10 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. Do we allow `inmem` to be used for other purposes? I would assume the answer is yes, as we do not forbid it. I ask because front-ends might use this as a way to add type information to a pointer (especially after we strip them). Or am I confusing something here? >

[PATCH] D81420: Fix size for _ExtInt types with builtins

2020-06-10 Thread Mott, Jeffrey T via Phabricator via cfe-commits
jtmott-intel marked an inline comment as done. jtmott-intel added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:337 + QualType Ty = + I < 2 ? Arg.get()->getType() +: Arg.get()->getType()->getAs()->getPointeeType();

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

2020-06-10 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6451 + "%1 is %select{|in}3complete">, + InGroup; def ext_typecheck_ordered_comparison_of_function_pointers : ExtWarn< pestctrl wrote: > efriedma wrote: > > `InGroup` >

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

2020-06-10 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers updated this revision to Diff 269977. nickdesaulniers added a comment. - rebase - fix docs (use declare consistently, avoid define) - add driver test - fix command line check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/

[PATCH] D81615: [clang] CWG 2082 and 2346: loosen the restrictions on parameters and local variables in default arguments.

2020-06-10 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno created this revision. riccibruno added reviewers: bkramer, rjmccall, rsmith, erichkeane. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. This patch implements the resolution of CWG 2082 and CWG 2346. The resolution of CWG 2082 changed [dcl.fct.default]p7

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

2020-06-10 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added subscribers: raghavendhra, jhuber6, anchu-rajendran, kiranktp, DavidTruby, ronlieb, kiranchandramohan. jdoerfert added a comment. In D79675#2058657 , @fghanim wrote: > I am moving on because we are not getting anywhere. However, There are

[PATCH] D57626: Disallow trivial_abi on a class if all copy and move constructors are deleted

2020-06-10 Thread Akira Hatanaka via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGf466f0beda59: Disallow trivial_abi on a class if all copy and move constructors are deleted (authored by ahatanak).

[PATCH] D81530: [clangd] Log rather than assert on bad UTF-8.

2020-06-10 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. In D81530#2085725 , @jaafar wrote: > I can confirm that this commit works equally well for the UTF-8 assertion > failure. Thank you! > > Is there some way to easily modify the source to produce a diagnostic > pointing to the

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

2020-06-10 Thread Benson Chu via Phabricator via cfe-commits
pestctrl marked 2 inline comments as done. pestctrl added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6451 + "%1 is %select{|in}3complete">, + InGroup; def ext_typecheck_ordered_comparison_of_function_pointers : ExtWarn<

[PATCH] D80730: [OPENMP50]Codegen for use_device_addr clauses.

2020-06-10 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev marked an inline comment as done. ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:18508 + // Component = CreateBuiltinUnaryOp(ELoc, UO_Deref, Component).get(); + // Component = DefaultFunctionArrayLvalueConversion(Component).get(); +

[clang] f466f0b - Disallow trivial_abi on a class if all copy and move constructors are

2020-06-10 Thread Akira Hatanaka via cfe-commits
Author: Akira Hatanaka Date: 2020-06-10T14:12:13-07:00 New Revision: f466f0beda59af1af182deb3cc8c006093d5a169 URL: https://github.com/llvm/llvm-project/commit/f466f0beda59af1af182deb3cc8c006093d5a169 DIFF:

[PATCH] D80730: [OPENMP50]Codegen for use_device_addr clauses.

2020-06-10 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. One nit below, the others seem silent. LGTM. Comment at: clang/lib/Sema/SemaOpenMP.cpp:18508 + // Component = CreateBuiltinUnaryOp(ELoc, UO_Deref,

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

2020-06-10 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen updated this revision to Diff 269961. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h

[clang] 1727c6a - [clang] Use IsVolatile=true and RequiresNullTerminator=false for PCMs

2020-06-10 Thread Michael Spencer via cfe-commits
Author: Michael Spencer Date: 2020-06-10T14:37:30-06:00 New Revision: 1727c6aab34012f0cefc8a3f29ede5f1f718c832 URL: https://github.com/llvm/llvm-project/commit/1727c6aab34012f0cefc8a3f29ede5f1f718c832 DIFF:

[PATCH] D81285: [builtins] Change si_int to int in some helper declarations

2020-06-10 Thread Ayke via Phabricator via cfe-commits
aykevl added a comment. I need to recompile LLVM to test this patch so it might take a while. In D81285#2082517 , @atrosinenko wrote: > In D81285#2082394 , @aykevl wrote: > > > Also note that the libgcc

[PATCH] D81455: [clang][NFC] Generate the {Type,ArrayType,UnaryExprOrType,Expression}Traits enumerations from TokenKinds.def...

2020-06-10 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno marked 2 inline comments as done. riccibruno added a comment. Thanks for the review Aaron! I have added some comments inline. Comment at: clang/lib/Basic/ExpressionTraits.cpp:29-34 + assert(T <= ET_Last && "invalid enum value!"); + return ExpressionTraitNames[T];

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

2020-06-10 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:11571 + Diag(Loc, + getLangOpts().C11 + ? diag::ext_typecheck_compare_complete_incomplete_pointers efriedma wrote: > pestctrl wrote: > > efriedma

[PATCH] D78232: [OPENMP50]Codegen for scan directive in simd loops.

2020-06-10 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Thx! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78232/new/ https://reviews.llvm.org/D78232

[PATCH] D77836: [Attribute] Fix noderef attribute false-negatives

2020-06-10 Thread Leonard Chan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG2f6bb2a69215: [clang][Attribute] Fix noderef attribute false-negatives (authored by leonardchan). Changed prior to commit: https://reviews.llvm.org/D77836?vs=267684=269951#toc Repository: rG LLVM

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

2020-06-10 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, with one more comment inline. Comment at: clang/lib/Serialization/ASTWriter.cpp:2345 FirstMacroID -

[PATCH] D81608: Fix incorrect call to ExprResult::get()

2020-06-10 Thread Alexander Richardson via Phabricator via cfe-commits
arichardson created this revision. arichardson added reviewers: Anastasia, pekka.jaaskelainen. Herald added a project: clang. Herald added a subscriber: cfe-commits. Res is already a ExprResult, so if we call .get() we convert an ExprError() result into an unset result. I discovered this in our

[PATCH] D81455: [clang][NFC] Generate the {Type,ArrayType,UnaryExprOrType,Expression}Traits enumerations from TokenKinds.def...

2020-06-10 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/lib/Basic/ExpressionTraits.cpp:29-34 + assert(T <= ET_Last && "invalid enum value!"); + return ExpressionTraitNames[T]; +} + +const char *clang::getTraitSpelling(ExpressionTrait T) { + assert(T <= ET_Last && "invalid enum

[clang] 2f6bb2a - [clang][Attribute] Fix noderef attribute false-negatives

2020-06-10 Thread Leonard Chan via cfe-commits
Author: Leonard Chan Date: 2020-06-10T12:20:54-07:00 New Revision: 2f6bb2a69215f9cae883da12f8f596d3f80f8d71 URL: https://github.com/llvm/llvm-project/commit/2f6bb2a69215f9cae883da12f8f596d3f80f8d71 DIFF: https://github.com/llvm/llvm-project/commit/2f6bb2a69215f9cae883da12f8f596d3f80f8d71.diff

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

2020-06-10 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6451 + "%1 is %select{|in}3complete">, + InGroup; def ext_typecheck_ordered_comparison_of_function_pointers : ExtWarn< `InGroup` Comment at:

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

2020-06-10 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added inline comments. Comment at: clang/include/clang/Driver/CC1Options.td:216-221 def mrelocation_model : Separate<["-"], "mrelocation-model">, - HelpText<"The relocation model to use">, Values<"static,pic,ropi,rwpi,ropi-rwpi,dynamic-no-pic">; + HelpText<"The

[PATCH] D81427: [hip] Fix device-only relocatable code compilation.

2020-06-10 Thread Michael Liao via Phabricator via cfe-commits
hliao added a comment. In D81427#2085739 , @thakis wrote: > This doesn't pass tests: http://45.33.8.238/linux/19977/step_7.txt > > Please take a look, and please revert for now if fixing takes a while. Fixed in

[PATCH] D80932: [SYCL] Make default address space a superset of OpenCL address spaces.

2020-06-10 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a subscriber: rjmccall. Anastasia added a comment. In D80932#2083185 , @bader wrote: > In D80932#2080631 , @Anastasia wrote: > > > > @Anastasia, if we make this change specific to SYCL mode, will it

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

2020-06-10 Thread Paul Robinson via Phabricator via cfe-commits
probinson added a subscriber: debug-info. probinson added a comment. +debug-info tag Needs a Driver test to show that the Right Thing gets passed to cc1. Comment at: clang/docs/CommandGuide/clang.rst:438 + + By default, Clang does not emit type information for types that are

[clang] 6dd0580 - [hip] Fix the failed test case due to the additional backend phase.

2020-06-10 Thread Michael Liao via cfe-commits
Author: Michael Liao Date: 2020-06-10T15:06:06-04:00 New Revision: 6dd058083208d58c6a7005bfb092cee085fd9a48 URL: https://github.com/llvm/llvm-project/commit/6dd058083208d58c6a7005bfb092cee085fd9a48 DIFF: https://github.com/llvm/llvm-project/commit/6dd058083208d58c6a7005bfb092cee085fd9a48.diff

[PATCH] D81098: [OpenMP] Upgrade default version of OpenMP to 5.0

2020-06-10 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In D81098#2085786 , @saiislam wrote: > [Work in progress] Requesting early comments. 28 tests are still failing. Looks good in general Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81427: [hip] Fix device-only relocatable code compilation.

2020-06-10 Thread Michael Liao via Phabricator via cfe-commits
hliao added a comment. In D81427#2085739 , @thakis wrote: > This doesn't pass tests: http://45.33.8.238/linux/19977/step_7.txt > > Please take a look, and please revert for now if fixing takes a while. Thanks. I am building with PowerPC enabled to

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

2020-06-10 Thread Daniel Grumberg via Phabricator via cfe-commits
dang updated this revision to Diff 269926. dang added a comment. This address a bunch of existing feedback and makes the TableGen definitions of the additional information significantly nicer to write. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81427: [hip] Fix device-only relocatable code compilation.

2020-06-10 Thread Michael Liao via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8b6821a5843b: [hip] Fix device-only relocatable code compilation. (authored by hliao). Changed prior to commit: https://reviews.llvm.org/D81427?vs=269555=269928#toc Repository: rG LLVM Github

[PATCH] D80917: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 2

2020-06-10 Thread Saiyedul Islam via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4022bc2a6c5e: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 2 (authored by saiislam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D63852: [Clang] Move assembler into a separate file

2020-06-10 Thread Ayke via Phabricator via cfe-commits
aykevl added a comment. @echristo any chance you could take a look at this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63852/new/ https://reviews.llvm.org/D63852 ___ cfe-commits mailing list

[PATCH] D81567: [analyzer] SATest: Introduce a single entrypoint for regression scripts

2020-06-10 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko added a comment. In D81567#2085622 , @Szelethus wrote: > I failed to follow much of this project so my question may be dumb -- but > have you considered other run comparing tools such as csa-testbench >

[PATCH] D81427: [hip] Fix device-only relocatable code compilation.

2020-06-10 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. This doesn't pass tests: http://45.33.8.238/linux/19977/step_7.txt Please take a look, and please revert for now if fixing takes a while. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81427/new/

[PATCH] D81530: [clangd] Log rather than assert on bad UTF-8.

2020-06-10 Thread Jeff Trull via Phabricator via cfe-commits
jaafar added a comment. I can confirm that this commit works equally well for the UTF-8 assertion failure. Thank you! Is there some way to easily modify the source to produce a diagnostic pointing to the issue's source location? I would like to file an appropriate bug in Boost. Repository:

[PATCH] D81045: [LLVM] Change isa<> to a variadic function template

2020-06-10 Thread River Riddle via Phabricator via cfe-commits
rriddle accepted this revision. rriddle marked an inline comment as done. rriddle added a comment. This revision is now accepted and ready to land. I have run into the desire to have this on many occasions, so LGTM for me. Comment at: clang/include/clang/AST/DeclBase.h:521

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

2020-06-10 Thread Lucas Prates via Phabricator via cfe-commits
pratlucas marked an inline comment as done. pratlucas added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:524 + CallConv)) +return; EVT ValueVT = Val.getValueType(); efriedma wrote:

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

2020-06-10 Thread Lucas Prates via Phabricator via cfe-commits
pratlucas updated this revision to Diff 269915. pratlucas marked 2 inline comments as done. pratlucas added a comment. Clean-ups + fixing failure in CodeGen/ARM/half.ll test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75169/new/

[clang] 52cae05 - [ASan][Test] Fix expected strings for globals test

2020-06-10 Thread Marco Elver via cfe-commits
Author: Marco Elver Date: 2020-06-10T20:26:24+02:00 New Revision: 52cae05e087b3d4fd02849fc37c387c720055ffb URL: https://github.com/llvm/llvm-project/commit/52cae05e087b3d4fd02849fc37c387c720055ffb DIFF: https://github.com/llvm/llvm-project/commit/52cae05e087b3d4fd02849fc37c387c720055ffb.diff

[clang] 8b6821a - [hip] Fix device-only relocatable code compilation.

2020-06-10 Thread Michael Liao via cfe-commits
Author: Michael Liao Date: 2020-06-10T14:10:41-04:00 New Revision: 8b6821a5843bb321b3738e2519beae7142e62928 URL: https://github.com/llvm/llvm-project/commit/8b6821a5843bb321b3738e2519beae7142e62928 DIFF: https://github.com/llvm/llvm-project/commit/8b6821a5843bb321b3738e2519beae7142e62928.diff

[clang] 4022bc2 - [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 2

2020-06-10 Thread Saiyedul Islam via cfe-commits
Author: Saiyedul Islam Date: 2020-06-10T18:09:59Z New Revision: 4022bc2a6c5e585d99a76b1b2f14c2986b823ce9 URL: https://github.com/llvm/llvm-project/commit/4022bc2a6c5e585d99a76b1b2f14c2986b823ce9 DIFF: https://github.com/llvm/llvm-project/commit/4022bc2a6c5e585d99a76b1b2f14c2986b823ce9.diff

[PATCH] D81564: [analyzer] SATest: Add posibility to download source from git and zip

2020-06-10 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/utils/analyzer/ProjectMap.py:14 +class DownloadType(str, Enum): +GIT = "git" xazax.hun wrote: > I was wondering what is the point of inheriting from `str`. I

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

2020-06-10 Thread Momchil Velikov via Phabricator via cfe-commits
chill added inline comments. Comment at: llvm/test/CodeGen/AArch64/aarch64-bf16-ldst-intrinsics.ll:264 +; Function Attrs: argmemonly nounwind readonly +declare { <8 x bfloat>, <8 x bfloat> } @llvm.aarch64.neon.ld2lane.v8bf16.p0i8(<8 x bfloat>, <8 x bfloat>, i64, i8*) #3 +

[PATCH] D81591: [ASan][Test] Split out global alias test

2020-06-10 Thread Marco Elver via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0f04f104537b: [ASan][Test] Split out global alias test (authored by melver). Changed prior to commit: https://reviews.llvm.org/D81591?vs=269898=269911#toc Repository: rG LLVM Github Monorepo

[PATCH] D81601: [analyzer] SATest: Use logger in single-threaded mode as well

2020-06-10 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. It generalizes the way

[PATCH] D81600: [analyzer] SATest: Fix package versions for test dependencies

2020-06-10 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Another possible

[PATCH] D81567: [analyzer] SATest: Introduce a single entrypoint for regression scripts

2020-06-10 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. I failed to follow much of this project so my question may be dumb -- but have you considered other run comparing tools such as csa-testbench (https://github.com/Xazax-hun/csa-testbench) and CodeChecker? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D81595: [analyzer] SATest: Make main script Python2 compatible

2020-06-10 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. If the user has only python2 installed and wants to use the

[PATCH] D81596: [analyzer] SATest: Do not re-run CMake in Docker if not needed

2020-06-10 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

2020-06-10 Thread Sjoerd Meijer via Phabricator via cfe-commits
SjoerdMeijer added inline comments. Comment at: llvm/test/CodeGen/AArch64/aarch64-bf16-ldst-intrinsics.ll:264 +; Function Attrs: argmemonly nounwind readonly +declare { <8 x bfloat>, <8 x bfloat> } @llvm.aarch64.neon.ld2lane.v8bf16.p0i8(<8 x bfloat>, <8 x bfloat>, i64, i8*) #3

[PATCH] D81598: [analyzer] SATest: Add an easy option to connect to docker for debugging

2020-06-10 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Docker on its own has a

[PATCH] D81311: [RFC] LangRef: Define inmem parameter attribute

2020-06-10 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. In D81311#2084066 , @rjmccall wrote: > In D81311#2083295 , @arsenm wrote: > > > In D81311#2078235 , @rjmccall > > wrote: > > > > > I wonder if

[PATCH] D81599: [analyzer] SATest: Add 5 more projects for testing

2020-06-10 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Repository: rG LLVM

[PATCH] D81564: [analyzer] SATest: Add posibility to download source from git and zip

2020-06-10 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added inline comments. Comment at: clang/utils/analyzer/ProjectMap.py:14 +class DownloadType(str, Enum): +GIT = "git" I was wondering what is the point of inheriting from `str`. I am not well-versed in Python so it is more of a curiosity.

[PATCH] D81593: [analyzer] SATest: Make docker interfaces transparent

2020-06-10 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Forward results of every command executed in docker. The actual

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

2020-06-10 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:5217 + else +Mangler.getStream() << D->getName(); +} jasonliu wrote: > If I understand correctly, this function will come in pair with > `__cxx_global_var_init`. >

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

2020-06-10 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L updated this revision to Diff 269900. Xiangling_L marked 17 inline comments as done. Xiangling_L added a comment. Address the comments Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/ https://reviews.llvm.org/D74166 Files:

[PATCH] D80917: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 2

2020-06-10 Thread Saiyedul Islam via Phabricator via cfe-commits
saiislam added a comment. In D80917#2085377 , @jdoerfert wrote: > I am fine with this. @arsenm feel free to accept. > > --- > > In D80917#2085138 , @saiislam wrote: > > > Ping. > > > Afaik, pings should be

[clang] 0f04f10 - [ASan][Test] Split out global alias test

2020-06-10 Thread Marco Elver via cfe-commits
Author: Marco Elver Date: 2020-06-10T19:58:50+02:00 New Revision: 0f04f104537bf037d07933cc306d0a0c0772e78f URL: https://github.com/llvm/llvm-project/commit/0f04f104537bf037d07933cc306d0a0c0772e78f DIFF: https://github.com/llvm/llvm-project/commit/0f04f104537bf037d07933cc306d0a0c0772e78f.diff

  1   2   3   >