[PATCH] D81420: Fix size for _ExtInt types with builtins

2020-06-11 Thread Mott, Jeffrey T via Phabricator via cfe-commits
jtmott-intel added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:327 return true; TheCall->setArg(2, Arg.get()); } rjmccall wrote: > I know this is existing code, but this is a broken mess. Please change this > to: > > ``` >

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

2020-06-11 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:682 void CodeGenModule::EmitCXXGlobalDtorFunc() { if (CXXGlobalDtors.empty()) return; hubert.reinterpretcast wrote: > Following from my previous comments on

[PATCH] D81627: [HIP] Do not call opt/llc for -fno-gpu-rdc

2020-06-11 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked 4 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Driver/Driver.cpp:2725-2726 for (unsigned I = 0, E = GpuArchList.size(); I != E; ++I) { // Create a link action to link device IR with device library //

[PATCH] D81627: [HIP] Do not call opt/llc for -fno-gpu-rdc

2020-06-11 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 270302. yaxunl marked 2 inline comments as done. yaxunl added a reviewer: ashi1. yaxunl added a comment. revised by Artem's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81627/new/ https://reviews.llvm.org/D81627 Files:

[PATCH] D81627: [HIP] Do not call opt/llc for -fno-gpu-rdc

2020-06-11 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D81627#2088502 , @arsenm wrote: > In D81627#2088500 , @arsenm wrote: > > > It doesn't matter if we don't support isa linking. We should just use clang > > and default to -flto. LTO "just

[PATCH] D81713: [HIP] Fix rocm not found on rocm3.5

2020-06-11 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added reviewers: tra, arsenm. Herald added subscribers: kerbowa, nhaehnle, wdng, jvesely. Currently rocm detector expects device library bitcodes named as *.bc instead of *.amdgcn.bc. However in rocm3.5 the device library bitcodes are named as *.amdgcn.bc,

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

2020-06-11 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:824 std::tie(CalleeTy, Callee, Arg) = DtorsAndObjects[e - i - 1]; - llvm::CallInst *CI = Builder.CreateCall(CalleeTy, Callee, Arg); + llvm::CallInst *CI = (Arg == nullptr)

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

2020-06-11 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:5231 + CXXNameMangler Mangler(*this, Out); + Mangler.getStream() << "__cxx_global_var_destruct_"; + if (shouldMangleDeclName(D)) I believe these are actually paired with

[PATCH] D81045: [LLVM] Change isa<> to a variadic function template

2020-06-11 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added a comment. Do you need someone to land this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81045/new/ https://reviews.llvm.org/D81045 ___ cfe-commits mailing list

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

2020-06-11 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:293 +CodeGenFunction::unregisterGlobalDtorWithUnAtExit(llvm::Function *dtorStub) { + // extern "C" int unatexit(void (*f)(void)); + assert(dtorStub->getFunctionType() ==

[PATCH] D80743: (PR46111) Properly handle elaborated types in an implicit deduction guide

2020-06-11 Thread Erich Keane via Phabricator via cfe-commits
erichkeane marked an inline comment as done. erichkeane added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:1967 +TransformType(InnerTLB, OrigDecl->getTypeSourceInfo()->getTypeLoc()); +TypeSourceInfo *TSI =

[PATCH] D81707: [PowerPC][Power10] Implement Vector Clear Left/Rightmost Bytes Builtins in LLVM/Clang

2020-06-11 Thread Amy Kwan via Phabricator via cfe-commits
amyk created this revision. amyk added reviewers: saghir, nemanjai, power-llvm-team, PowerPC, hfinkel. amyk added projects: clang, LLVM, PowerPC. Herald added subscribers: shchenz, hiraditya. This patch implements builtins for the following prototypes: vector signed char vec_clrl (vector

[PATCH] D81543: [CodeGen][TLS] Set TLS Model for __tls_guard as well.

2020-06-11 Thread JunMa via Phabricator via cfe-commits
junparser added a comment. kindly ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81543/new/ https://reviews.llvm.org/D81543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D81242: [StackSafety] Run ThinLTO

2020-06-11 Thread Evgenii Stepanov via Phabricator via cfe-commits
eugenis added inline comments. Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:618 +ConstantRange Access = Found->sextOrTrunc(Use.Range.getBitWidth()); +if (Access.signedAddMayOverflow(C.Offset) != +ConstantRange::OverflowResult::NeverOverflows)

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

2020-06-11 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L added inline comments. Comment at: clang/include/clang/AST/Mangle.h:178 + virtual void mangleDynamicDestructor(const VarDecl *D, raw_ostream ) = 0; + hubert.reinterpretcast wrote: > I am not sure "destructor" is the right term here. This seems to

[PATCH] D81703: [Clang] Don't leave Expr::Classification fields uninitialized in default constructor

2020-06-11 Thread Gui Andrade via Phabricator via cfe-commits
guiand created this revision. guiand added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. guiand edited the summary of this revision. This changes `Expr::Classification::{Kind, Modifiable}` fields so that they are initialized as `Unknown` rather than

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

2020-06-11 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L updated this revision to Diff 270267. Xiangling_L marked 21 inline comments as done. Xiangling_L added a comment. Address another round of reviews; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/ https://reviews.llvm.org/D74166 Files:

[PATCH] D80743: (PR46111) Properly handle elaborated types in an implicit deduction guide

2020-06-11 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaTemplate.cpp:1967 +TransformType(InnerTLB, OrigDecl->getTypeSourceInfo()->getTypeLoc()); +TypeSourceInfo *TSI =

[PATCH] D80977: Diagnose cases where the name of a class member is used within a class definition before the member name is declared.

2020-06-11 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. I'm not entirely happy with this approach; there are lots of places where we perform lookups that are incidental and shouldn't result in an error if we end up looking outside the class, and I'm not sure I've marked them all as "synthetic". That said, I've tested this

[PATCH] D77982: [Windows SEH] Fix the frame-ptr of a nested-filter within a _finally

2020-06-11 Thread Ten Tzen via Phabricator via cfe-commits
tentzen added a comment. this patch has lasted for a couple of months. a bug in this area is hard and time-consuming to diagnose. it's better to get this fix in sooner than later. could someone review and approve it? thanks, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81624: [CodeGen] Simplify the way lifetime of block captures is extended

2020-06-11 Thread Akira Hatanaka via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc9a52de00260: [CodeGen] Simplify the way lifetime of block captures is extended (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

2020-06-11 Thread Ten Tzen via Phabricator via cfe-commits
tentzen added a comment. does it look good to you? or any more comment? thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 ___ cfe-commits mailing list

[PATCH] D81691: [clangd] Set CWD in semaCodeComplete

2020-06-11 Thread Jan Korous via Phabricator via cfe-commits
jkorous added a comment. A slightly tangential thing - we recently got an internal bugreport about clangd handling combination of working directory and relative paths for `-fmodules-cache-path` combination in compile_command.json incorrectly. I tried some quick hacks but failed - it seems that

[clang] c9a52de - [CodeGen] Simplify the way lifetime of block captures is extended

2020-06-11 Thread Akira Hatanaka via cfe-commits
Author: Akira Hatanaka Date: 2020-06-11T16:06:22-07:00 New Revision: c9a52de0026093327daedda7ea2eead8b64657b4 URL: https://github.com/llvm/llvm-project/commit/c9a52de0026093327daedda7ea2eead8b64657b4 DIFF:

[PATCH] D81552: [ASTMatchers] Added hasDirectBase and hasClass Matchers

2020-06-11 Thread Nathan James via Phabricator via cfe-commits
njames93 marked 2 inline comments as done. njames93 added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3537 AST_POLYMORPHIC_MATCHER_P_OVERLOAD( -hasType, -AST_POLYMORPHIC_SUPPORTED_TYPES(Expr, FriendDecl, ValueDecl, -

[PATCH] D81311: [RFC] LangRef: Define inmem parameter attribute

2020-06-11 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. > But it does mess with the ABI; that's why it's being added. My worry is, that we do not clearly sate it does. I'm worried front-ends will use it to attach types to pointers once pointers do not have types anymore. I'll stop arguing on this one now, if you think

[PATCH] D80462: Fix floating point math function attributes definition.

2020-06-11 Thread John McCall via Phabricator via cfe-commits
rjmccall closed this revision. rjmccall added a comment. To ssh://github.com/llvm/llvm-project a98d618f6e5f..7fac1acc6171 master -> master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80462/new/ https://reviews.llvm.org/D80462

[PATCH] D81311: [RFC] LangRef: Define inmem parameter attribute

2020-06-11 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D81311#2088568 , @jdoerfert wrote: > In D81311#2088075 , @rjmccall wrote: > > > In D81311#2087592 , @jdoerfert > > wrote: > > > > > In

[PATCH] D81311: [RFC] LangRef: Define inmem parameter attribute

2020-06-11 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. In D81311#2088568 , @jdoerfert wrote: > In D81311#2088075 , @rjmccall wrote: > > > In D81311#2087592 , @jdoerfert > > wrote: > > > > > In

[clang] 7fac1ac - Set the LLVM FP optimization flags conservatively.

2020-06-11 Thread John McCall via cfe-commits
Author: John McCall Date: 2020-06-11T18:16:41-04:00 New Revision: 7fac1acc617113b7a3276ee0f0664bedca978292 URL: https://github.com/llvm/llvm-project/commit/7fac1acc617113b7a3276ee0f0664bedca978292 DIFF: https://github.com/llvm/llvm-project/commit/7fac1acc617113b7a3276ee0f0664bedca978292.diff

[PATCH] D81691: [clangd] Set CWD in semaCodeComplete

2020-06-11 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGf44d2424f8d7: [clangd] Set CWD in semaCodeComplete (authored by kadircet). Repository: rG LLVM Github Monorepo

[PATCH] D81608: Fix incorrect call to ExprResult::get()

2020-06-11 Thread Alexander Richardson via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG385e5f7e147f: Fix incorrect call to ExprResult::get() (authored by arichardson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81608/new/

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

2020-06-11 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:305 + if (llvm::Function *unatexitFn = + dyn_cast(unatexit.getCallee())) +unatexitFn->setDoesNotThrow(); Xiangling_L wrote: > jasonliu wrote: > > Is there a

[PATCH] D81244: [StackSafety] Control paramer access summary from frontend

2020-06-11 Thread Evgenii Stepanov via Phabricator via cfe-commits
eugenis added a comment. I like this in principle. Makes a lot more sense to control this directly from clang than to rely on function attributes. Comment at: llvm/lib/Bitcode/Writer/BitcodeWriterPass.cpp:31 + EmitModuleHash); + } return

[PATCH] D81311: [RFC] LangRef: Define inmem parameter attribute

2020-06-11 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D81311#2088075 , @rjmccall wrote: > In D81311#2087592 , @jdoerfert wrote: > > > In D81311#2086326 , @rjmccall > > wrote: > > > > > In

[PATCH] D81031: [OpenMP] Add Additional Function Attribute Information to OMPKinds.def

2020-06-11 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 updated this revision to Diff 270239. jhuber6 added a comment. Herald added subscribers: cfe-commits, aaron.ballman. Herald added a project: clang. Adding parameter and return attributes for pointers. There are some arguments I wasn't sure how they should be classified, like if every

[clang-tools-extra] f44d242 - [clangd] Set CWD in semaCodeComplete

2020-06-11 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2020-06-11T23:35:47+02:00 New Revision: f44d2424f8d7735d7ab5ffd96f75300221afd099 URL: https://github.com/llvm/llvm-project/commit/f44d2424f8d7735d7ab5ffd96f75300221afd099 DIFF:

LLVM buildmaster will be updated and restarted tonight

2020-06-11 Thread Galina Kistanova via cfe-commits
Hello everyone, LLVM buildmaster will be updated and restarted after 6PM PST today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 385e5f7 - Fix incorrect call to ExprResult::get()

2020-06-11 Thread Alex Richardson via cfe-commits
Author: Alex Richardson Date: 2020-06-11T22:23:33+01:00 New Revision: 385e5f7e147fcf792085b365cc48380850612025 URL: https://github.com/llvm/llvm-project/commit/385e5f7e147fcf792085b365cc48380850612025 DIFF:

[PATCH] D81627: [HIP] Do not call opt/llc for -fno-gpu-rdc

2020-06-11 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. In D81627#2088500 , @arsenm wrote: > It doesn't matter if we don't support isa linking. We should just use clang > and default to -flto. LTO "just works" as is This is a step forward, but the lack of ISA linking shouldn't block

[PATCH] D81670: [TTI] Expose isNoopAddrSpaceCast from TLI.[SROA] Teach SROA to recognize no-op addrspacecast.

2020-06-11 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. In D81670#2088304 , @hliao wrote: > In D81670#2087974 , @arsenm wrote: > > > We should instead allow bitcast to perform no-op addrspacecasts > > > That may be a little bit challenging as so

[PATCH] D81627: [HIP] Do not call opt/llc for -fno-gpu-rdc

2020-06-11 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. It doesn't matter if we don't support isa linking. We should just use clang and default to -flto. LTO "just works" as is CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81627/new/ https://reviews.llvm.org/D81627 ___

[PATCH] D81641: [SYCL] Implement thread-local storage restriction

2020-06-11 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. OpenMP has the same restriction (no surprise I guess). Thanks for the ping! I think we do not emit diagnosis right now: https://godbolt.org/z/srDkXZ I think we also should diagnose this the same way, though it might be beyond the scope of this patch:

[PATCH] D81691: [clangd] Set CWD in semaCodeComplete

2020-06-11 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81691 Files: clang-tools-extra/clangd/CodeComplete.cpp Index:

[PATCH] D81608: Fix incorrect call to ExprResult::get()

2020-06-11 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Great spot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81608/new/ https://reviews.llvm.org/D81608

[PATCH] D81688: [WebAssembly] WebAssembly doesn't support "protected" visibility

2020-06-11 Thread Dan Gohman via Phabricator via cfe-commits
sunfish created this revision. Herald added subscribers: llvm-commits, aheejin, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. mplement the `hasProtectedVisibility()` hook to indicate that, like Darwin, WebAssembly doesn't support "protected" visibility. On ELF,

[PATCH] D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

2020-06-11 Thread Kevin P. Neal via Phabricator via cfe-commits
kpn updated this revision to Diff 270219. kpn retitled this revision from "[FPEnv][Clang][Driver][WIP] Disable constrained floating point on targets lacking support." to "[FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.". kpn added a comment. Herald added a

[libunwind] 96e6cbb - [libc++] Allow specifying arbitrary custom executors with the new format

2020-06-11 Thread Louis Dionne via cfe-commits
Author: Louis Dionne Date: 2020-06-11T16:24:29-04:00 New Revision: 96e6cbbf941d0f937b7e823433d4c222967a1817 URL: https://github.com/llvm/llvm-project/commit/96e6cbbf941d0f937b7e823433d4c222967a1817 DIFF: https://github.com/llvm/llvm-project/commit/96e6cbbf941d0f937b7e823433d4c222967a1817.diff

[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

2020-06-11 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:376-377 +std::string operator()(PathSensitiveBugReport ) const { + if (BR.isInteresting(StreamSym)) +return Message; + Another thing you might want to

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

2020-06-11 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In D72705#1871996 , @Szelethus wrote: > @NoQ, @xazax.hun, @baloghadamsoftware, how do you like this patch? I think > the high level idea is correct. I still don't understand how do we enable this checker, i.e. for whom and how

[PATCH] D81670: [TTI] Expose isNoopAddrSpaceCast from TLI.[SROA] Teach SROA to recognize no-op addrspacecast.

2020-06-11 Thread Michael Liao via Phabricator via cfe-commits
hliao added a comment. In D81670#2087974 , @arsenm wrote: > We should instead allow bitcast to perform no-op addrspacecasts That may be a little bit challenging as so far no-op `addrspacecast` is target-specific. There may be no TTI available when

[PATCH] D80947: Add to the Coding Standard our that single-line bodies omit braces

2020-06-11 Thread Erich Keane via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc08ea0771682: Add to the Coding Standard our that single-line bodies omit braces (authored by erichkeane). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78122: [analyzer][Nullability] Don't emit under the checker name NullabilityBase

2020-06-11 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Nope, false alarm! Our buildbot configuration change was at fault. Sorry for forgetting to follow up >.< Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78122/new/ https://reviews.llvm.org/D78122

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

2020-06-11 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin updated this revision to Diff 270206. DmitryPolukhin added a comment. Fix single new line handling, it should be replace with space Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80301/new/ https://reviews.llvm.org/D80301 Files:

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

2020-06-11 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7327-7330 + bool IsNonContiguous = false, + MapNonContiguousArrayTy *const Offsets = nullptr, + MapNonContiguousArrayTy *const Counts = nullptr, + MapNonContiguousArrayTy *const

[clang] efb0413 - [clang][NFC] Assert that the enumerator value of {Type,ArrayType,UnaryExprOrType,Expression}Traits

2020-06-11 Thread Bruno Ricci via cfe-commits
Author: Bruno Ricci Date: 2020-06-11T20:27:40+01:00 New Revision: efb0413a5cf9b1481c9b6169c8685f8d71f6de84 URL: https://github.com/llvm/llvm-project/commit/efb0413a5cf9b1481c9b6169c8685f8d71f6de84 DIFF: https://github.com/llvm/llvm-project/commit/efb0413a5cf9b1481c9b6169c8685f8d71f6de84.diff

[clang] a9250c2 - [clang] TextNodeDumper: Dump the trait spelling of {Type,ArrayType,Expression}TraitExpr

2020-06-11 Thread Bruno Ricci via cfe-commits
Author: Bruno Ricci Date: 2020-06-11T20:27:40+01:00 New Revision: a9250c281a875d91fb5dd1c8f4ad8ee4ff61b75d URL: https://github.com/llvm/llvm-project/commit/a9250c281a875d91fb5dd1c8f4ad8ee4ff61b75d DIFF: https://github.com/llvm/llvm-project/commit/a9250c281a875d91fb5dd1c8f4ad8ee4ff61b75d.diff

[clang] a06f000 - [clang][NFC] Remove two hard-coded lists of ArrayTypeTrait and ExpressionTrait

2020-06-11 Thread Bruno Ricci via cfe-commits
Author: Bruno Ricci Date: 2020-06-11T20:27:40+01:00 New Revision: a06f000326e3362ffb5634957447dd434abab0f9 URL: https://github.com/llvm/llvm-project/commit/a06f000326e3362ffb5634957447dd434abab0f9 DIFF: https://github.com/llvm/llvm-project/commit/a06f000326e3362ffb5634957447dd434abab0f9.diff

[PATCH] D79155: [CodeGen] Increase applicability of ffine-grained-bitfield-accesses for targets with limited native integer widths

2020-06-11 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. Please add a comment explaining what OffsetInRecord means; then LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79155/new/ https://reviews.llvm.org/D79155 ___ cfe-commits mailing list

[PATCH] D81627: [HIP] Do not call opt/llc for -fno-gpu-rdc

2020-06-11 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. Looks OK in general. I'm happy to see reduced opt/llc use. You may want to get someone more familiar with the AMD GPU compilation process to double-check that the compilation pipeline still does the right thing. Comment at:

[PATCH] D81552: [ASTMatchers] Added hasDirectBase and hasClass Matchers

2020-06-11 Thread Jan Korous via Phabricator via cfe-commits
jkorous added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3553 +/// \endcode +AST_MATCHER_P(CXXBaseSpecifier, hasClass, internal::Matcher, + InnerMatcher) { aaron.ballman wrote: > jkorous wrote: > > Nit: while "[base

[PATCH] D81552: [ASTMatchers] Added hasDirectBase and hasClass Matchers

2020-06-11 Thread Jan Korous via Phabricator via cfe-commits
jkorous added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3621 +/// \endcode +AST_MATCHER_P(CXXBaseSpecifier, hasClassOrClassTemplate, + internal::Matcher, InnerMatcher) { I think we should just use `eachOf` matcher

[PATCH] D81392: [clang] Rename Decl::isHidden() to isUnconditionallyVisible()

2020-06-11 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. I think renaming the flag in the AST dump output would be a good idea, though it'll be a lot of churn in the tests. I would prefer that we continue to dump a marker only if the declaration is

[PATCH] D80450: [CUDA][HIP] Fix implicit HD function resolution

2020-06-11 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. In D80450#2087938 , @tra wrote: > Reproducer for the regression. > https://gist.github.com/Artem-B/183e9cfc28c6b04c1c862c853b5d9575 > It's not particularly small, but that's as far as I could get it reduced. > > With the patch, an

[clang] 43101d1 - [OPENMP50]Codegen for scan directive in simd loops.

2020-06-11 Thread Alexey Bataev via cfe-commits
Author: Alexey Bataev Date: 2020-06-11T14:48:43-04:00 New Revision: 43101d10dbd58d48df732f974e078fd82376039e URL: https://github.com/llvm/llvm-project/commit/43101d10dbd58d48df732f974e078fd82376039e DIFF: https://github.com/llvm/llvm-project/commit/43101d10dbd58d48df732f974e078fd82376039e.diff

[PATCH] D81311: [RFC] LangRef: Define inmem parameter attribute

2020-06-11 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D81311#2087592 , @jdoerfert wrote: > In D81311#2086326 , @rjmccall wrote: > > > In D81311#2086227 , @jdoerfert > > wrote: > > > > > Do we allow

[PATCH] D81552: [ASTMatchers] Added hasDirectBase and hasClass Matchers

2020-06-11 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3537 AST_POLYMORPHIC_MATCHER_P_OVERLOAD( -hasType, -AST_POLYMORPHIC_SUPPORTED_TYPES(Expr, FriendDecl, ValueDecl, -CXXBaseSpecifier), +

[PATCH] D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v8.3.1

2020-06-11 Thread Anatoly Trosinenko via Phabricator via cfe-commits
atrosinenko created this revision. atrosinenko added reviewers: broadwaylamb, sepavloff. Herald added subscribers: s.egerton, dexonsmith, simoncook, emaste. Herald added a reviewer: espindola. Herald added a project: clang. atrosinenko edited the summary of this revision. This patch updates the

[PATCH] D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs

2020-06-11 Thread Erik Pilkington via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG95d7ccb70b9c: [PCH] Support writing BuiltinBitCastExprs to PCHs (authored by hyd-dev, committed by erik.pilkington). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

2020-06-11 Thread Florian Hahn via Phabricator via cfe-commits
fhahn added a comment. In D72781#2084077 , @rjmccall wrote: > LGTM. Thank you very much again John! This patch is pending on a few smallish improvements to the load/store intrinsics (D81472 ) and I'll land once that

[clang] 95d7ccb - [PCH] Support writing BuiltinBitCastExprs to PCHs

2020-06-11 Thread Erik Pilkington via cfe-commits
Author: hyd-dev Date: 2020-06-11T13:37:01-04:00 New Revision: 95d7ccb70b9cbd53f1f137c0b2411852c42c122b URL: https://github.com/llvm/llvm-project/commit/95d7ccb70b9cbd53f1f137c0b2411852c42c122b DIFF: https://github.com/llvm/llvm-project/commit/95d7ccb70b9cbd53f1f137c0b2411852c42c122b.diff LOG:

[PATCH] D81670: [TTI] Expose isNoopAddrSpaceCast from TLI.[SROA] Teach SROA to recognize no-op addrspacecast.

2020-06-11 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. We should instead allow bitcast to perform no-op addrspacecasts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81670/new/ https://reviews.llvm.org/D81670 ___ cfe-commits mailing

[PATCH] D81672: [Driver] When forcing a crash call abort to get the correct diagnostic

2020-06-11 Thread John Brawn via Phabricator via cfe-commits
john.brawn created this revision. john.brawn added reviewers: gbreynoo, jhenderson, probinson. Herald added a project: clang. Commit a945037e8fd0c30e250a62211469eea6765a36ae moved the printing of the "PLEASE submit a bug

[PATCH] D81670: [TTI] Expose isNoopAddrSpaceCast from TLI.[SROA] Teach SROA to recognize no-op addrspacecast.

2020-06-11 Thread Michael Liao via Phabricator via cfe-commits
hliao updated this revision to Diff 270177. hliao added a comment. Revise the formatting. Updating D81670: [TTI] Expose isNoopAddrSpaceCast from TLI. === [SROA] Teach SROA to recognize no-op addrspacecast. Repository: rG LLVM Github

[PATCH] D80450: [CUDA][HIP] Fix implicit HD function resolution

2020-06-11 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. Reproducer for the regression. https://gist.github.com/Artem-B/183e9cfc28c6b04c1c862c853b5d9575 It's not particularly small, but that's as far as I could get it reduced. With the patch, an attempt to instantiate `ag` on line 36 (in the reproducer sources I linked to above)

[PATCH] D81670: [TTI] Expose isNoopAddrSpaceCast from TLI.[SROA] Teach SROA to recognize no-op addrspacecast.

2020-06-11 Thread Michael Liao via Phabricator via cfe-commits
hliao created this revision. hliao added reviewers: arsenm, chandlerc. Herald added subscribers: llvm-commits, cfe-commits, kerbowa, dexonsmith, steven_wu, hiraditya, nhaehnle, wdng, jvesely. Herald added projects: clang, LLVM. So far, SROA could only handle convertible pointer pairs if they are

[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

2020-06-11 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. In D81407#2087624 , @balazske wrote: > - Report every path of resource leak. I thought we agreed on the uniqueing being great? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

2020-06-11 Thread Sjoerd Meijer via Phabricator via cfe-commits
SjoerdMeijer added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:524 + CallConv)) +return; EVT ValueVT = Val.getValueType(); efriedma wrote: > pratlucas wrote: > > efriedma wrote: >

[PATCH] D81223: Size LTO (1/3): Standardizing the use of OptimizationLevel

2020-06-11 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added a comment. In D81223#2087660 , @rcorcs wrote: > The way I see it, with size level for LTO, we could have a different LTO > optimization pipeline for size or runtime performance. So this is the important point to settle before going on

[PATCH] D80730: [OPENMP50]Codegen for use_device_addr clauses.

2020-06-11 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Hi, you can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` with the following script arcfilter () { arc amend git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p &&

[PATCH] D81223: Size LTO (1/3): Standardizing the use of OptimizationLevel

2020-06-11 Thread Mircea Trofin via Phabricator via cfe-commits
mtrofin added inline comments. Comment at: llvm/include/llvm/IR/PassManager.h:413 +/// LLVM-provided high-level optimization levels. +/// I think this change - moving OptimizationLevel out - should be in its own patch, to avoid noise.

[PATCH] D78024: [FileCheck] - Fix the false positive when -implicit-check-not is used with an unknown -check-prefix.

2020-06-11 Thread Xing GUO via Phabricator via cfe-commits
Higuoxing added a comment. Herald added a project: LLVM. > btw, do you know why FileCheck seems intentionally allows the case when > --check-prefixes=KNOWN,UNKNOWN? > I've mentioned in the description of D78110 > that there are about 1000 tests that have >

[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

2020-06-11 Thread Balázs Kéri via Phabricator via cfe-commits
balazske updated this revision to Diff 270161. balazske added a comment. - Added tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81407/new/ https://reviews.llvm.org/D81407 Files: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp

[PATCH] D78122: [analyzer][Nullability] Don't emit under the checker name NullabilityBase

2020-06-11 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. @NoQ Have you unearthed anything on this matter? Do I need to step in/revert? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78122/new/ https://reviews.llvm.org/D78122 ___

[PATCH] D81428: [ARM] Moving CMSE handling of half arguments and return to the backend

2020-06-11 Thread Lucas Prates via Phabricator via cfe-commits
pratlucas marked 4 inline comments as done. pratlucas added inline comments. Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:2267 +// Mask f16 arguments if this is a CMSE nonsecure call +auto ArgVT = Outs[realArgIdx].ArgVT; ostannard wrote: > Could

[PATCH] D81223: Size LTO (1/3): Standardizing the use of OptimizationLevel

2020-06-11 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added a comment. Sorry I haven't had a chance to review this yet. Added @mtrofin who recently added the OptimizationLevel class that this is leveraging, and @yamauchi who has also been looking at size optimizations in llvm. At a first glance it isn't clear to me how much of this is

[PATCH] D81428: [ARM] Moving CMSE handling of half arguments and return to the backend

2020-06-11 Thread Lucas Prates via Phabricator via cfe-commits
pratlucas updated this revision to Diff 270160. pratlucas added a comment. Addressing review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81428/new/ https://reviews.llvm.org/D81428 Files: llvm/lib/Target/ARM/ARMISelLowering.cpp

[PATCH] D81428: [ARM] Moving CMSE handling of half arguments and return to the backend

2020-06-11 Thread Lucas Prates via Phabricator via cfe-commits
pratlucas updated this revision to Diff 270149. pratlucas added a comment. Rebasing and simplifying function attributes on test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81428/new/ https://reviews.llvm.org/D81428 Files:

[clang] fac7259 - Revert "[OPENMP50]Codegen for scan directive in simd loops."

2020-06-11 Thread Alexey Bataev via cfe-commits
Author: Alexey Bataev Date: 2020-06-11T11:22:51-04:00 New Revision: fac7259c81671c37140374f3e6ec1fc7472c677c URL: https://github.com/llvm/llvm-project/commit/fac7259c81671c37140374f3e6ec1fc7472c677c DIFF: https://github.com/llvm/llvm-project/commit/fac7259c81671c37140374f3e6ec1fc7472c677c.diff

[PATCH] D81223: Size LTO (1/3): Standardizing the use of OptimizationLevel

2020-06-11 Thread Rodrigo Caetano Rocha via Phabricator via cfe-commits
rcorcs added a comment. The way I see it, with size level for LTO, we could have a different LTO optimization pipeline for size or runtime performance. For example, we could have a different tuning for inlining, vectorization, etc. We could also use the size level to automatically enable

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

2020-06-11 Thread Lucas Prates via Phabricator via cfe-commits
pratlucas updated this revision to Diff 270143. pratlucas added a comment. Fixing failure on CodeGen/ARM/GlobalISel/arm-unsupported.ll and making clang-format happy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75169/new/

[PATCH] D81658: [OPENMP50]Codegen for scan directive in for simd regions.

2020-06-11 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: sstefan1, guansong, yaxunl. Herald added a project: clang. Added codegen for scan directives in parallel for regions. Emits the code for the directive with inscan reductions. Original code: #pragma

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

2020-06-11 Thread Benson Chu via Phabricator via cfe-commits
pestctrl updated this revision to Diff 270139. pestctrl added a comment. Moved the extension to C11 group Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79945/new/ https://reviews.llvm.org/D79945 Files:

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

2020-06-11 Thread Benson Chu via Phabricator via cfe-commits
pestctrl marked an inline comment as done. pestctrl added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6451 + "%1 is %select{|in}3complete">, + InGroup; def ext_typecheck_ordered_comparison_of_function_pointers : ExtWarn<

[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

2020-06-11 Thread Balázs Kéri via Phabricator via cfe-commits
balazske updated this revision to Diff 270140. balazske added a comment. - Report every path of resource leak. - Do not report if non-returning function was encountered. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81407/new/

[PATCH] D81641: [SYCL] Implement thread-local storage restriction

2020-06-11 Thread Mariya Podchishchaeva via Phabricator via cfe-commits
Fznamznon marked 2 inline comments as done. Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:216 + if (getLangOpts().SYCLIsDevice) +if (auto VD = dyn_cast(D)) + if (VD->getTLSKind() != VarDecl::TLS_None) riccibruno wrote: > Nit:

[PATCH] D81311: [RFC] LangRef: Define inmem parameter attribute

2020-06-11 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D81311#2086326 , @rjmccall wrote: > In D81311#2086227 , @jdoerfert wrote: > > > Do we allow `inmem` to be used for other purposes? I would assume the > > answer is yes, as we do not

[PATCH] D81641: [SYCL] Implement thread-local storage restriction

2020-06-11 Thread Mariya Podchishchaeva via Phabricator via cfe-commits
Fznamznon updated this revision to Diff 270135. Fznamznon added a comment. Fixed code style. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81641/new/ https://reviews.llvm.org/D81641 Files: clang/lib/Sema/SemaDecl.cpp

[PATCH] D80730: [OPENMP50]Codegen for use_device_addr clauses.

2020-06-11 Thread Alexey Bataev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG90b54fa045e3: [OPENMP50]Codegen for use_device_addr clauses. (authored by ABataev). Changed prior to commit: https://reviews.llvm.org/D80730?vs=269618=270131#toc Repository: rG LLVM Github Monorepo

[clang] 90b54fa - [OPENMP50]Codegen for use_device_addr clauses.

2020-06-11 Thread Alexey Bataev via cfe-commits
Author: Alexey Bataev Date: 2020-06-11T09:54:51-04:00 New Revision: 90b54fa045e3f8711e0bfb2d22626b28fd3b131f URL: https://github.com/llvm/llvm-project/commit/90b54fa045e3f8711e0bfb2d22626b28fd3b131f DIFF: https://github.com/llvm/llvm-project/commit/90b54fa045e3f8711e0bfb2d22626b28fd3b131f.diff

  1   2   >