[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:277 + llvm::FunctionType::get(CGM.VoidTy, false) && + "atexit has wrong parameter type."); + s/atexit has wrong parameter type/Argument to atexit has a

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/static-init.cpp:8 +// RUN: FileCheck %s struct test { Xiangling_L wrote: > jasonliu wrote: > > Looks like the non-inline comments are easier to get ignored and missed, so > > I

[PATCH] D81688: [WebAssembly] WebAssembly doesn't support "protected" visibility

sunfish closed this revision. sunfish added a comment. Landed in 66042959590d6db9d2a12803a16476d4e3508f3f . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81688/new/

[clang] 6604295 - [WebAssembly] WebAssembly doesn't support "protected" visibility

Author: Dan Gohman Date: 2020-06-12T19:52:35-07:00 New Revision: 66042959590d6db9d2a12803a16476d4e3508f3f URL: https://github.com/llvm/llvm-project/commit/66042959590d6db9d2a12803a16476d4e3508f3f DIFF: https://github.com/llvm/llvm-project/commit/66042959590d6db9d2a12803a16476d4e3508f3f.diff

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/static-init.cpp:31 +// CHECK: @llvm.global_ctors = appending global [1 x { i32, void ()*, i8* }] [{ i32, void ()*, i8* } { i32 65535, void ()* @__sinit8000_clang_510e898aa8d263cac999dd03eeed5b51,

[PATCH] D81781: Add additional text format functions to Google style.

nseckar updated this revision to Diff 270559. nseckar added a comment. Add reviewers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81781/new/ https://reviews.llvm.org/D81781 Files: clang/lib/Format/Format.cpp Index:

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

hubert.reinterpretcast marked an inline comment as done. hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:700 + +Fn = CreateGlobalInitOrDestructFunction( +FTy, llvm::Twine("__sterm8000_clang_") + GlobalUniqueModuleId, FI,

[PATCH] D81781: Add additional text format functions to Google style.

nseckar created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. nseckar updated this revision to Diff 270559. nseckar added a comment. nseckar added a reviewer: djasper. Add reviewers This adds a few more function names expecting a text proto argument.

[PATCH] D81242: [StackSafety] Run ThinLTO

This revision was automatically updated to reflect the committed changes. Closed by commit rGc1e47b47f884: [StackSafety] Run ThinLTO (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81242/new/ https://reviews.llvm.org/D81242

[PATCH] D81242: [StackSafety] Run ThinLTO

vitalybuka added inline comments. Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:618 +ConstantRange Access = Found->sextOrTrunc(Use.Range.getBitWidth()); +if (Access.signedAddMayOverflow(C.Offset) != +ConstantRange::OverflowResult::NeverOverflows)

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dexonsmith added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3845 + IS_POSITIVE != DEFAULT_VALUE && this->KEYPATH != DEFAULT_VALUE) \ +Args.push_back(StringAllocator(Twine(PREFIX_TYPE[0]) + NAME)); +#include

[PATCH] D81242: [StackSafety] Run ThinLTO

vitalybuka updated this revision to Diff 270553. vitalybuka marked 3 inline comments as done. vitalybuka added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81242/new/ https://reviews.llvm.org/D81242 Files:

[clang] c1e47b4 - [StackSafety] Run ThinLTO

Author: Vitaly Buka Date: 2020-06-12T18:11:29-07:00 New Revision: c1e47b47f8848bb4c1ead8c530940d783c1fbf46 URL: https://github.com/llvm/llvm-project/commit/c1e47b47f8848bb4c1ead8c530940d783c1fbf46 DIFF: https://github.com/llvm/llvm-project/commit/c1e47b47f8848bb4c1ead8c530940d783c1fbf46.diff

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

Xiangling_L updated this revision to Diff 270548. Xiangling_L marked 35 inline comments as done. Xiangling_L edited the summary of this revision. Xiangling_L added a comment. Address another round of reviews; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:639 + if (CXXGlobalInits.empty()) +return; hubert.reinterpretcast wrote: > Can this part be committed in a separate patch? It does not appear to have > dependencies on other

[PATCH] D81774: [PowerPC][Power10] Implement VSX PCV Generate Operations in LLVM/Clang

amyk created this revision. amyk added reviewers: nemanjai, saghir, power-llvm-team, PowerPC, hfinkel. amyk added projects: LLVM, clang, PowerPC. Herald added subscribers: shchenz, hiraditya. This patch implements builtins for the following prototypes for the VSX Permute Control Vector Generate

[PATCH] D81721: [SVE] Ensure proper mangling of ACLE tuple types

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81721/new/ https://reviews.llvm.org/D81721

[PATCH] D81041: Use existing path sep style in clang::FileManager::FixupRelativePath

amccarth added a comment. In D81041#2072396 , @ctetreau wrote: > After some further investigation, I have come to believe that the root cause > of the issue I am seeing is on line 783 of clang/lib/Lex/HeaderSearch.cpp. A > path is constructed using

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 270536. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen marked 4 inline comments as done. cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7821 + Context.getTypeSizeInChars(ElementType).getQuantity(); +} else if (VAT) { + ElementType =

[PATCH] D81772: Reduce -Wregister from DefaultError to a default-on warning.

jyknight created this revision. jyknight added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. There is a lot of C++ code in the wild still using 'register', which will become broken if we switch the default compilation mode to C++17. A default-on

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

amccarth accepted this revision. amccarth added a comment. My only real concern was about the possible reproducibility impact of introducing absolute paths into the binaries. If @thakis and @hans are satisfied this is OK, then LGTM. Comment at:

[PATCH] D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option

zixuw added inline comments. Comment at: clang/lib/Lex/PPExpressions.cpp:262 + // string to UndefPrefixes as an explicit "-Wundef" does. + if (UndefPrefixes.empty() || + llvm::any_of(UndefPrefixes, arphaman wrote: > zixuw wrote: >

[PATCH] D81771: [CUDA,HIP] Use VFS for SDK detection.

tra created this revision. tra added reviewers: yaxunl, arsenm. Herald added subscribers: kerbowa, sanjoy.google, bixia, nhaehnle, wdng, jvesely. Herald added a project: clang. tra updated this revision to Diff 270533. tra edited the summary of this revision. tra added a comment. Replaced

[PATCH] D81771: [CUDA,HIP] Use VFS for SDK detection.

tra updated this revision to Diff 270533. tra edited the summary of this revision. tra added a comment. Replaced another use of D.getVFS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81771/new/ https://reviews.llvm.org/D81771 Files:

[PATCH] D81242: [StackSafety] Run ThinLTO

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM with 2 notes Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:618 +ConstantRange Access = Found->sextOrTrunc(Use.Range.getBitWidth()); +if

[PATCH] D81769: Repair various issues with modernize-avoid-bind

jaafar marked 3 inline comments as done. jaafar added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp:38 enum BindArgumentKind { BK_Temporary, BK_Placeholder, BK_CallExpr, BK_Other }; -enum CaptureMode { CM_None, CM_ByRef, CM_ByValue,

[PATCH] D81769: Repair various issues with modernize-avoid-bind

jaafar created this revision. jaafar added reviewers: aaron.ballman, alexfh, hokein. jaafar added a project: clang-tools-extra. Herald added a project: clang. Herald added a subscriber: cfe-commits. In the process of running this check on a large codebase

[PATCH] D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option

arphaman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:108 +def Undefined : DiagGroup<"undef">; +def UndefinedPrefix : DiagGroup<"undef-prefix", [Undefined]>; def UnsupportedNan : DiagGroup<"unsupported-nan">; zixuw wrote: >

[PATCH] D80961: Ignore template instantiations if not in AsIs mode

steveire updated this revision to Diff 270517. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80961/new/ https://reviews.llvm.org/D80961 Files: clang-tools-extra/clang-tidy/abseil/TimeSubtractionCheck.cpp

[PATCH] D81757: [WebAssembly] Add intrinsic for i64x2.mul

This revision was automatically updated to reflect the committed changes. Closed by commit rGd2c394e74fc5: [WebAssembly] Add intrinsic for i64x2.mul (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81757/new/

[PATCH] D81420: Fix size for _ExtInt types with builtins

rjmccall accepted this revision. rjmccall added a comment. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81420/new/ https://reviews.llvm.org/D81420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] d2c394e - [WebAssembly] Add intrinsic for i64x2.mul

Author: Thomas Lively Date: 2020-06-12T14:08:18-07:00 New Revision: d2c394e74fc5eb33581b58f238a745d7dd18f219 URL: https://github.com/llvm/llvm-project/commit/d2c394e74fc5eb33581b58f238a745d7dd18f219 DIFF: https://github.com/llvm/llvm-project/commit/d2c394e74fc5eb33581b58f238a745d7dd18f219.diff

[PATCH] D81552: [ASTMatchers] Added hasDirectBase and hasClass Matchers

jkorous added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3553 +/// \endcode +AST_MATCHER_P(CXXBaseSpecifier, hasClass, internal::Matcher, + InnerMatcher) { aaron.ballman wrote: > njames93 wrote: > > jkorous wrote: > >

[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

LegalizeAdulthood added a comment. Yeah, the restriction to the header file is a bug. It was a misconception on my part when I originally wrote the matcher. See https://bugs.llvm.org/show_bug.cgi?id=26332 which should also be fixed by the change here. I had attempted to make progress on

[PATCH] D78126: [analyzer][NFC] Don't allow dependency checkers to emit diagnostics

Szelethus reopened this revision. Szelethus added a comment. This revision is now accepted and ready to land. Reverted in rGe64059828f19f629081220bffeb3ef7582870111 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D81627: [HIP] Do not call opt/llc for -fno-gpu-rdc

yaxunl added a comment. In D81627#2090499 , @tra wrote: > LGTM. Good to go if @arsenm is OK with fixing -fgpu-rdc in a separate patch. @arsenm Are you OK with fixing -fgpu-rdc in a separate patch? The fix for that is orthogonal to the current patch.

[PATCH] D81761: [analyzer] Force dependency checkers to be hidden

Szelethus created this revision. Szelethus added reviewers: NoQ, vsavchenko, dcoughlin, xazax.hun, balazske, martong, baloghadamsoftware. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho,

[PATCH] D81752: Revert "[analyzer][NFC] Don't allow dependency checkers to emit diagnostics"

This revision was automatically updated to reflect the committed changes. Closed by commit rGe64059828f19: Revert [analyzer][NFC] Dont allow dependency checkers to emit diagnostics (authored by saugustine). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81757: [WebAssembly] Add intrinsic for i64x2.mul

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: clang. This instruction was implemented in 3181273be7

[PATCH] D81420: Fix size for _ExtInt types with builtins

jtmott-intel marked an inline comment as done. jtmott-intel added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:327 return true; TheCall->setArg(2, Arg.get()); } rjmccall wrote: > jtmott-intel wrote: > > rjmccall wrote: > > > I know

[PATCH] D81420: Fix size for _ExtInt types with builtins

jtmott-intel updated this revision to Diff 270482. jtmott-intel added a comment. - Removed sign/unsign select. - Added test and support for placeholder types in builtins. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81420/new/ https://reviews.llvm.org/D81420 Files:

[clang] f8d87ce - [CMake] Use 'ssh.py' executor to run the remote library tests.

Author: Vladimir Vereschaka Date: 2020-06-12T12:31:59-07:00 New Revision: f8d87ce9ca23a696dbcc52b4b3458272a2ba8091 URL: https://github.com/llvm/llvm-project/commit/f8d87ce9ca23a696dbcc52b4b3458272a2ba8091 DIFF:

[clang] e640598 - Revert "[analyzer][NFC] Don't allow dependency checkers to emit diagnostics"

Author: Sterling Augustine Date: 2020-06-12T12:10:13-07:00 New Revision: e64059828f19f629081220bffeb3ef7582870111 URL: https://github.com/llvm/llvm-project/commit/e64059828f19f629081220bffeb3ef7582870111 DIFF:

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

clementval updated this revision to Diff 270481. clementval added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Keep same ordering than OMPKinds.def + add dependency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81713: [HIP] Fix rocm not found on rocm3.5

tra added a comment. In D81713#2090309 , @arsenm wrote: > > I can tell that it does not. We're still looking under `/opt/rocm` by > > default. I've ran into it trying to get comgr working with the recent LLVM > > which prompted my comment on Github > >

[PATCH] D81627: [HIP] Do not call opt/llc for -fno-gpu-rdc

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. Good to go if @arsenm is OK with fixing -fgpu-rdc in a separate patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81627/new/ https://reviews.llvm.org/D81627

[PATCH] D60620: [HIP] Support target id by --offload-arch

tra added a comment. In D60620#2089722 , @yaxunl wrote: > In D60620#2067134 , @tra wrote: > > > Do you expect users to specify these IDs? How do you see it being used in > > practice? I think you do need to

[PATCH] D80961: Ignore template instantiations if not in AsIs mode

steveire updated this revision to Diff 270472. steveire edited the summary of this revision. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80961/new/ https://reviews.llvm.org/D80961 Files:

[PATCH] D81752: Revert "[analyzer][NFC] Don't allow dependency checkers to emit diagnostics"

Szelethus accepted this revision. Szelethus added a comment. Yup, I agree. Detailed my answer here a bit: D78126#inline-751477 . Thanks for taking initiative! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78126: [analyzer][NFC] Don't allow dependency checkers to emit diagnostics

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:43 #include "clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h" +#include "clang/StaticAnalyzer/Frontend/CheckerRegistry.h" #include

[clang] 58de24c - [AMDGPU] Sorted targets in amdgpu-features.cl. NFC.

Author: Stanislav Mekhanoshin Date: 2020-06-12T11:57:40-07:00 New Revision: 58de24ce6cb413afea1470ec183f3fc5d9ca6817 URL: https://github.com/llvm/llvm-project/commit/58de24ce6cb413afea1470ec183f3fc5d9ca6817 DIFF:

[PATCH] D81752: Revert "[analyzer][NFC] Don't allow dependency checkers to emit diagnostics"

saugustine created this revision. saugustine added reviewers: echristo, Szelethus, martong. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. This

[PATCH] D80681: [clang][SourceManager] cache Macro Expansions

kadircet added a comment. Also forgot to say, thanks a lot for taking your time to investigate this issue and coming up with a patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80681/new/ https://reviews.llvm.org/D80681

[PATCH] D81713: [HIP] Fix rocm not found on rocm3.5

arsenm added a comment. In D81713#2090265 , @tra wrote: > In D81713#2089760 , @arsenm wrote: > > > In D81713#2089680 , @yaxunl wrote: > > > > > In D81713#2089672

[PATCH] D81751: [SemaObjC] Fix a -Wobjc-signed-char-bool false-positive with binary conditional operator

erik.pilkington created this revision. erik.pilkington added a reviewer: rjmccall. Herald added subscribers: ributzka, dexonsmith, jkorous. We were previously bypassing the conditional expression special case for binary conditional expressions. Also, dig through the OpaqueValueExpr on the left

[PATCH] D80681: [clang][SourceManager] cache Macro Expansions

kadircet added a comment. I am not the best person to review this, but dig a little bit into your issues and history of this file. Your diagnosis and fix seems reasonable, AFAICT the existing caching behavior was chosen to optimize files with many macro invocations that are expanding into

[PATCH] D81739: [clangd] Turn on RecoveryAST for clangd by default.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:285 +desc("Preserve expressions in AST for broken code (C++ only)."), +init(true), }; Ah actually in other options, we set the default in the struct and reference

[PATCH] D81713: [HIP] Fix rocm not found on rocm3.5

tra added a comment. In D81713#2089760 , @arsenm wrote: > In D81713#2089680 , @yaxunl wrote: > > > In D81713#2089672 , @arsenm wrote: > > > > > Can you add tests for this?

[PATCH] D81678: Introduce partialinit attribute at call sites for stricter poison analysis

guiand added inline comments. Comment at: clang/include/clang/AST/Type.h:2139-2141 + /// Check if this type has only two possible values, and so may be lowered to + /// a bool. + bool hasBooleanRepresentation() const; rsmith wrote: > This seems like a

[PATCH] D81750: [analyzer] Don't allow hidden checkers to emit diagnostics

Szelethus created this revision. Szelethus added reviewers: NoQ, vsavchenko, dcoughlin, martong, balazske, baloghadamsoftware, xazax.hun. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho,

[PATCH] D80961: Ignore template instantiations if not in AsIs mode

steveire added a comment. In D80961#2079419 , @aaron.ballman wrote: > In D80961#2079044 , @klimek wrote: > > > In D80961#2076242 , @aaron.ballman > > wrote: > > > > > In

[PATCH] D78126: [analyzer][NFC] Don't allow dependency checkers to emit diagnostics

saugustine added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:43 #include "clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h" +#include "clang/StaticAnalyzer/Frontend/CheckerRegistry.h" #include "llvm/ADT/ArrayRef.h"

[clang] c32d261 - Don't diagnose a redeclaration of a deduction guide if the prior

Author: Richard Smith Date: 2020-06-12T10:29:01-07:00 New Revision: c32d261e27c8c63653799fa6e411c373bd81d519 URL: https://github.com/llvm/llvm-project/commit/c32d261e27c8c63653799fa6e411c373bd81d519 DIFF: https://github.com/llvm/llvm-project/commit/c32d261e27c8c63653799fa6e411c373bd81d519.diff

[PATCH] D80681: [clang][SourceManager] cache Macro Expansions

nickdesaulniers added a comment. Bumping for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80681/new/ https://reviews.llvm.org/D80681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 270445. dang edited the summary of this revision. dang added a comment. Implemented a draft of normalizer generation for simple enum based options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/

[PATCH] D81392: [clang] Rename Decl::isHidden() to isUnconditionallyVisible()

rsmith added a comment. In D81392#2089251 , @mboehme wrote: > In D81392#2088131 , @rsmith wrote: > > > Maybe we should dump the ModuleOwnershipKind in general, not only an > > indicator of whether it's Visible or

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:807 void CodeGenFunction::GenerateCXXGlobalDtorsFunc( llvm::Function *Fn, This function is to be renamed. Comment at:

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/static-init.cpp:12 ~test(); -} t; +} t1, t2; I suggest adding also one each of the following: - a dynamic initialization of a non-local variable of type `int` - a `constinit`

Re: [clang] 1eddce4 - Fix non-determinism issue with implicit lambda captures.

On Fri, 12 Jun 2020 at 09:17, Erich Keane via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Erich Keane > Date: 2020-06-12T09:16:43-07:00 > New Revision: 1eddce4177cfddc86d4696b758904443b0b4f193 > > URL: >

[clang] 270d580 - [analyzer] Avoid unused variable warning in opt build

Author: Jacques Pienaar Date: 2020-06-12T09:48:49-07:00 New Revision: 270d580a0e9ff2f2e1b6240fccedee7c25dc3bfa URL: https://github.com/llvm/llvm-project/commit/270d580a0e9ff2f2e1b6240fccedee7c25dc3bfa DIFF:

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

xazax.hun accepted this revision. xazax.hun added a comment. I would not call the results of the measurement within the margin of error but the results do not look bad. Unless there is some objection from someone else I am ok with committing this but please change the title of revision before

[clang] 1eddce4 - Fix non-determinism issue with implicit lambda captures.

Author: Erich Keane Date: 2020-06-12T09:16:43-07:00 New Revision: 1eddce4177cfddc86d4696b758904443b0b4f193 URL: https://github.com/llvm/llvm-project/commit/1eddce4177cfddc86d4696b758904443b0b4f193 DIFF: https://github.com/llvm/llvm-project/commit/1eddce4177cfddc86d4696b758904443b0b4f193.diff

[PATCH] D81745: [analyzer][MallocChecker] PR46253: Correctly recognize standard realloc

Szelethus created this revision. Szelethus added reviewers: NoQ, hokein, baloghadamsoftware, balazske, xazax.hun, dcoughlin, vsavchenko, martong. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy,

[PATCH] D81163: [AST][RecoveryExpr] Preserve the AST for invalid conditions.

hokein updated this revision to Diff 270413. hokein added a comment. rebase and adjust the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81163/new/ https://reviews.llvm.org/D81163 Files: clang/lib/Sema/SemaExpr.cpp

[clang] b2a37cf - [Analyzer] Replace `assert` with `ASSERT_TRUE` in a unit test to silence warnings

Author: Adam Balogh Date: 2020-06-12T17:09:34+02:00 New Revision: b2a37cfe2bda0bc8c4d2e981922b5ac59c429bdc URL: https://github.com/llvm/llvm-project/commit/b2a37cfe2bda0bc8c4d2e981922b5ac59c429bdc DIFF: https://github.com/llvm/llvm-project/commit/b2a37cfe2bda0bc8c4d2e981922b5ac59c429bdc.diff

[PATCH] D81090: [AST][RecoveryExpr] Preserve the AST for invalid class constructions.

hokein updated this revision to Diff 270402. hokein added a comment. rebase to master and adjust the diagnostic tests after "-frecovery-ast" is flipped on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81090/new/ https://reviews.llvm.org/D81090

[PATCH] D81474: Handle delayed-template-parsing functions imported into a non-dtp TU

This revision was automatically updated to reflect the committed changes. Closed by commit rG05ed3efc2ac7: Handle delayed-template-parsing functions imported into a non-dtp TU (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

vrnithinkumar marked 38 inline comments as done. vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:31 namespace { -class SmartPtrModeling : public Checker { +struct RegionState { +private: vsavchenko wrote:

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

stuij accepted this revision. stuij added a comment. This revision is now accepted and ready to land. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80716/new/ https://reviews.llvm.org/D80716 ___ cfe-commits mailing list

[PATCH] D81740: [AArch32]: BFloat MatMul Intrinsics

LukeGeeson created this revision. LukeGeeson added reviewers: stuij, t.p.northover, SjoerdMeijer, sdesmalen, fpetrogalli. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. LukeGeeson added a parent revision: D81486: [ARM][BFloat]

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

vrnithinkumar updated this revision to Diff 270391. vrnithinkumar retitled this revision from "[analyzer][Draft] [Prototype] warning for default constructed unique pointer dereferences" to "[analyzer] Warning for default constructed unique pointer dereferences". vrnithinkumar added a comment.

[PATCH] D81739: [clangd] Turn on RecoveryAST for clangd by default.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81739 Files:

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

LukeGeeson updated this revision to Diff 270387. LukeGeeson added a comment. - removed unnecessary contents of test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80716/new/ https://reviews.llvm.org/D80716 Files: clang/include/clang/Basic/arm_neon.td clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D81713: [HIP] Fix rocm not found on rocm3.5

arsenm added a comment. In D81713#2089680 , @yaxunl wrote: > In D81713#2089672 , @arsenm wrote: > > > Can you add tests for this? Is this also sufficient with the directory > > layout change? > > > You mean does

[clang-tools-extra] 4160f4c - Reland [clangd] Parse std::make_unique, and emit template diagnostics at expansion.

Author: Sam McCall Date: 2020-06-12T16:18:26+02:00 New Revision: 4160f4c37615f6d5b7615666eb202d9cbb58f4bb URL: https://github.com/llvm/llvm-project/commit/4160f4c37615f6d5b7615666eb202d9cbb58f4bb DIFF: https://github.com/llvm/llvm-project/commit/4160f4c37615f6d5b7615666eb202d9cbb58f4bb.diff

[clang] 05ed3ef - Handle delayed-template-parsing functions imported into a non-dtp TU

Author: Sam McCall Date: 2020-06-12T16:09:38+02:00 New Revision: 05ed3efc2ac7b34bd62b1cbac88ff9a47b649cc5 URL: https://github.com/llvm/llvm-project/commit/05ed3efc2ac7b34bd62b1cbac88ff9a47b649cc5 DIFF: https://github.com/llvm/llvm-project/commit/05ed3efc2ac7b34bd62b1cbac88ff9a47b649cc5.diff

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

pratlucas added a comment. Hi @efriedma, From @SjoerdMeijer's comment and the links he pointed to, it seems to me that making `f16` types legal for all ARM subtargets would be a major undertaking and far from trivial to implement. It's also not clear to me how significant would be the returns

[PATCH] D60620: [HIP] Support target id by --offload-arch

yaxunl added a comment. In D60620#2067134 , @tra wrote: > Do you expect users to specify these IDs? How do you see it being used in > practice? I think you do need to implement a user-friendly shortcut and > expand it to the detailed offload-id

[PATCH] D81734: Initial smart pointer check

vrnithinkumar created this revision. Herald added subscribers: cfe-commits, martong. Herald added a project: clang. vrnithinkumar abandoned this revision. vrnithinkumar added a comment. It was a mistake I was supposed to update an existing review. first time use of arc Repository: rG LLVM

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

jasonliu added inline comments. Comment at: clang/test/CodeGen/static-init.cpp:8 +// RUN: FileCheck %s struct test { Looks like the non-inline comments are easier to get ignored and missed, so I will copy paste the non-inlined comment I previously had: ```

[PATCH] D81734: Initial smart pointer check

vrnithinkumar abandoned this revision. vrnithinkumar added a comment. It was a mistake I was supposed to update an existing review. first time use of arc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81734/new/ https://reviews.llvm.org/D81734

[PATCH] D81713: [HIP] Fix rocm not found on rocm3.5

yaxunl added a comment. In D81713#2089672 , @arsenm wrote: > Can you add tests for this? Is this also sufficient with the directory layout > change? You mean does this work after we move device lib from /opt/rocm/lib to /opt/rocm/amdgcn/bitcode ?

[clang] e4b3fc1 - Get rid of -Wunused warnings in release build, NFC.

Author: Haojian Wu Date: 2020-06-12T15:42:29+02:00 New Revision: e4b3fc18d33199e2081d300f14687d81be48b6a0 URL: https://github.com/llvm/llvm-project/commit/e4b3fc18d33199e2081d300f14687d81be48b6a0 DIFF: https://github.com/llvm/llvm-project/commit/e4b3fc18d33199e2081d300f14687d81be48b6a0.diff

[PATCH] D78126: [analyzer][NFC] Don't allow dependency checkers to emit diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rG33fb9cbe211d: [analyzer][NFC] Dont allow dependency checkers to emit diagnostics (authored by Szelethus). Changed prior to commit: https://reviews.llvm.org/D78126?vs=262387=270372#toc Repository: rG

[PATCH] D81713: [HIP] Fix rocm not found on rocm3.5

arsenm added a comment. Can you add tests for this? Is this also sufficient with the directory layout change? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81713/new/ https://reviews.llvm.org/D81713 ___ cfe-commits mailing list

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

This revision was automatically updated to reflect the committed changes. Closed by commit rG58ea1059df97: [AST][RecoveryExpr] Build recovery expressions by default for C++. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81552: [ASTMatchers] Added hasDirectBase and hasClass Matchers

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3553 +/// \endcode +AST_MATCHER_P(CXXBaseSpecifier, hasClass, internal::Matcher, + InnerMatcher) { njames93 wrote: > jkorous wrote: > > aaron.ballman

[PATCH] D69599: [analyzer] DynamicSize: Remove 'getSizeInElements()' from store

ASDenysPetrov added a comment. Herald added subscribers: martong, steakhal. @Charusso I think this patch may fix this bug https://bugs.llvm.org/show_bug.cgi?id=25284 Could you please verify and close it if so? At least I couldn't reproduce it on the latest build. Repository: rG LLVM Github

[PATCH] D81718: [Analyzer][NFC] Add methods `getReturnObject()` and `getArgObject()` to `CallEvent`

baloghadamsoftware added a comment. Thank you for taking a look on this! Let me explain! An iterator may be implemented by multiple ways. It can be a simple pointer, which means that it is a basic type passed by value both as argument and return value. Thus here `getArgSVal()` and

  1   2   >