[PATCH] D81972: [NFC] Cleanup of EmitCXXGlobalInitFunc() and EmitCXXGlobalDtorFunc()

2020-06-17 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:600 + // with priority emitted above. + SmallString<128> FileName; llvm::Function *Fn = CreateGlobalInitOrDestructFunction( In the less complex context of this patch,

[PATCH] D81713: [HIP] Fix rocm not found on rocm3.5

2020-06-17 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. I will commit this patch since it allows hipcc to use old rocm device library. Will fix other issues later. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81713/new/ https://reviews.llvm.org/D81713 ___ cfe-commits

[PATCH] D81995: [xray] Option to omit the function index

2020-06-17 Thread Ian Levesque via Phabricator via cfe-commits
ianlevesque marked 2 inline comments as done. ianlevesque added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:114 +///< Set with -fno-xray-function-index to omit the index section. +CODEGENOPT(XRayOmitFunctionIndex , 1, 0) + MaskRay

[PATCH] D81938: [InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`.

2020-06-17 Thread Michael Liao via Phabricator via cfe-commits
hliao updated this revision to Diff 271551. hliao added a comment. Add TTI hooks to double-check that address space casting is no-op. NOTE: This change depends on - https://reviews.llvm.org/D82025 (exposing `isNoopAddrSpaceCast` from TLI into TTI) to be compiled. -

[PATCH] D81995: [xray] Option to omit the function index

2020-06-17 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:114 +///< Set with -fno-xray-function-index to omit the index section. +CODEGENOPT(XRayOmitFunctionIndex , 1, 0) + ianlevesque wrote: > MaskRay wrote: > > ianlevesque wrote:

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

2020-06-17 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:708 +" based on strong external symbols"); + GlobalUniqueModuleId = GlobalUniqueModuleId.substr(1); +} jasonliu wrote: > Correct me if I'm wrong... >

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

2020-06-17 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L updated this revision to Diff 271550. Xiangling_L marked 11 inline comments as done. Xiangling_L edited the summary of this revision. Xiangling_L added a comment. Herald added a subscriber: jfb. Remove trailing spaces; Update the testcase; Adjust the EmitGuardedInitBranch function;

[PATCH] D81995: [xray] Option to omit the function index

2020-06-17 Thread Ian Levesque via Phabricator via cfe-commits
ianlevesque marked 4 inline comments as done. ianlevesque added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:114 +///< Set with -fno-xray-function-index to omit the index section. +CODEGENOPT(XRayOmitFunctionIndex , 1, 0) + MaskRay

[PATCH] D82020: PowerPC-specific builtin constrained FP enablement

2020-06-17 Thread Qing Shan Zhang via Phabricator via cfe-commits
steven.zhang added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14069 + BuiltinID == PPC::BI__builtin_vsx_xvrspim) +ID = Intrinsic::floor; + else if (BuiltinID == PPC::BI__builtin_vsx_xvrdpi || Can we do it like this to

[PATCH] D81622: [Clang] Search computed sysroot for libc++ header paths

2020-06-17 Thread Ryan Prichard via Phabricator via cfe-commits
rprichard added a comment. Ok, I'll run that command in the future, and I'll watch D80978 for updates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81622/new/ https://reviews.llvm.org/D81622

[PATCH] D81995: [xray] Option to omit the function index

2020-06-17 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:114 +///< Set with -fno-xray-function-index to omit the index section. +CODEGENOPT(XRayOmitFunctionIndex , 1, 0) + ianlevesque wrote: > MaskRay wrote: > > Nit: a variable

[PATCH] D81622: [Clang] Search computed sysroot for libc++ header paths

2020-06-17 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Hi, you can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential

[PATCH] D79249: [NOT FOR REVIEW] Experimental support for zero-or-trap behavior foruninitialized variables.

2020-06-17 Thread JF Bastien via Phabricator via cfe-commits
jfb added a comment. Overall I like this approach. I think it needs three more things to make it: - Better size optimizations. I measured the code size impact on a codebase which deploys variable auto-init already, and it's a 0.5% code size hit. Considering that auto-init itself was 1%, it

[PATCH] D81622: [Clang] Search computed sysroot for libc++ header paths

2020-06-17 Thread Ryan Prichard via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG6c4ce202267e: [Driver] Search computed sysroot for libc++ header paths (authored by rprichard). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81622/new/

[clang] 6c4ce20 - [Driver] Search computed sysroot for libc++ header paths

2020-06-17 Thread Ryan Prichard via cfe-commits
Author: Ryan Prichard Date: 2020-06-17T16:17:37-07:00 New Revision: 6c4ce202267ee089e611b7bee1dc4f3eb07ba23d URL: https://github.com/llvm/llvm-project/commit/6c4ce202267ee089e611b7bee1dc4f3eb07ba23d DIFF: https://github.com/llvm/llvm-project/commit/6c4ce202267ee089e611b7bee1dc4f3eb07ba23d.diff

[PATCH] D82059: [clang-tidy] RenamerClangTidy group redecls into 1 warning.

2020-06-17 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 271509. njames93 added a comment. New line... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82059/new/ https://reviews.llvm.org/D82059 Files: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp

[PATCH] D71491: [ubsan] Check implicit casts in ObjC for-in statements

2020-06-17 Thread Vedant Kumar via Phabricator via cfe-commits
vsk updated this revision to Diff 271508. vsk added a comment. Herald added projects: clang, Sanitizers. Herald added a subscriber: Sanitizers. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71491/new/ https://reviews.llvm.org/D71491

[clang] 973cfa9 - Revert "When performing a substitution into a dependent alias template, mark the"

2020-06-17 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-06-17T16:07:58-07:00 New Revision: 973cfa9ef5cb32b859744e5435df049bf315 URL: https://github.com/llvm/llvm-project/commit/973cfa9ef5cb32b859744e5435df049bf315 DIFF: https://github.com/llvm/llvm-project/commit/973cfa9ef5cb32b859744e5435df049bf315.diff

[clang] 55b6f68 - Revert "Fix rejects-valid when referencing an implicit operator== from within a"

2020-06-17 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-06-17T16:05:26-07:00 New Revision: 55b6f68f4b254bd1506ff844fa511b6658607992 URL: https://github.com/llvm/llvm-project/commit/55b6f68f4b254bd1506ff844fa511b6658607992 DIFF: https://github.com/llvm/llvm-project/commit/55b6f68f4b254bd1506ff844fa511b6658607992.diff

[PATCH] D82059: [clang-tidy] RenamerClangTidy group redecls into 1 warning.

2020-06-17 Thread Nathan James via Phabricator via cfe-commits
njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, jbcoe, gribozavr2. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. This changes the behavious of `RenamerClangTidyCheck` based checks by grouping declarations of the same thing into

[PATCH] D81622: [Clang] Search computed sysroot for libc++ header paths

2020-06-17 Thread Dan Albert via Phabricator via cfe-commits
danalbert accepted this revision. danalbert added a comment. In D81622#2094409 , @ldionne wrote: > While this doesn't look wrong to me -- and the correctness of this depends > entirely on where vendors decide to put their headers so it's hard for me to

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

2020-06-17 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. In D80242#2093785 , @dblaikie wrote: > > - fix docs (use declare consistently, avoid define) > > Defined would be the right word here (declaring a type is code like "struct > foo;" - and this change probably

[PATCH] D81995: [xray] Option to omit the function index

2020-06-17 Thread Ian Levesque via Phabricator via cfe-commits
ianlevesque marked 3 inline comments as done. ianlevesque added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:114 +///< Set with -fno-xray-function-index to omit the index section. +CODEGENOPT(XRayOmitFunctionIndex , 1, 0) + MaskRay

[PATCH] D81395: [AST][RecoveryExpr] Preserve the invalid "undef_var" initializer.

2020-06-17 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. (this looks reasonable now but it'd be nice to have a rebased diff!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81395/new/ https://reviews.llvm.org/D81395 ___ cfe-commits

[PATCH] D82047: [AST] Move the "fallback to recovery expr" mechanism to CorrectDelayedTyposInExpr, NFC

2020-06-17 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! This leaves a natural followup of working out where we can set this to true :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

2020-06-17 Thread Ahsan Saghir via Phabricator via cfe-commits
saghir updated this revision to Diff 271498. saghir marked an inline comment as done. saghir added a comment. Updated tests features to check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81816/new/ https://reviews.llvm.org/D81816 Files:

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

2020-06-17 Thread Ahsan Saghir via Phabricator via cfe-commits
saghir marked 2 inline comments as done. saghir added inline comments. Comment at: clang/test/Parser/p10-vector-bool-128.c:2 +// RUN: %clang_cc1 -triple=powerpc64-unknown-linux-gnu -target-feature +altivec -target-feature +vsx -fsyntax-only -verify %s +// RUN: %clang_cc1

[clang] ac20150 - [CUDA] make the test more hermetic

2020-06-17 Thread Artem Belevich via cfe-commits
Author: Artem Belevich Date: 2020-06-17T15:22:45-07:00 New Revision: ac20150e299a41ade860f432741c1b8557ac8058 URL: https://github.com/llvm/llvm-project/commit/ac20150e299a41ade860f432741c1b8557ac8058 DIFF:

[clang] 7c1c2d9 - [clang-format] NFC 3% improvement in the overall clang-formatted status

2020-06-17 Thread via cfe-commits
Author: mydeveloperday Date: 2020-06-17T23:16:08+01:00 New Revision: 7c1c2d9775813e8ec3c71b50677cb20b2c71cf7a URL: https://github.com/llvm/llvm-project/commit/7c1c2d9775813e8ec3c71b50677cb20b2c71cf7a DIFF:

[clang] c851d6c - When performing a substitution into a dependent alias template, mark the

2020-06-17 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-06-17T15:12:04-07:00 New Revision: c851d6cf4a4ab803d01d0059f4659f4f9f4435ea URL: https://github.com/llvm/llvm-project/commit/c851d6cf4a4ab803d01d0059f4659f4f9f4435ea DIFF: https://github.com/llvm/llvm-project/commit/c851d6cf4a4ab803d01d0059f4659f4f9f4435ea.diff

[clang] c7fbe21 - Fix rejects-valid when referencing an implicit operator== from within a

2020-06-17 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-06-17T15:12:04-07:00 New Revision: c7fbe2191b8b9cd64570ed3906d1bed1dd5fff8e URL: https://github.com/llvm/llvm-project/commit/c7fbe2191b8b9cd64570ed3906d1bed1dd5fff8e DIFF: https://github.com/llvm/llvm-project/commit/c7fbe2191b8b9cd64570ed3906d1bed1dd5fff8e.diff

[PATCH] D81972: [NFC] Cleanup of EmitCXXGlobalInitFunc() and EmitCXXGlobalDtorFunc()

2020-06-17 Thread Jason Liu via Phabricator via cfe-commits
jasonliu accepted this revision. jasonliu added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:596 } + // Include the filename in the symbol name. Including "sub_" matches gcc Xiangling_L

[PATCH] D81972: [NFC] Cleanup of EmitCXXGlobalInitFunc() and EmitCXXGlobalDtorFunc()

2020-06-17 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L updated this revision to Diff 271492. Xiangling_L added a comment. Add the context to the patch; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81972/new/ https://reviews.llvm.org/D81972 Files: clang/lib/CodeGen/CGDeclCXX.cpp Index: clang/lib/CodeGen/CGDeclCXX.cpp

[PATCH] D81972: [NFC] Cleanup of EmitCXXGlobalInitFunc() and EmitCXXGlobalDtorFunc()

2020-06-17 Thread Jason Liu via Phabricator via cfe-commits
jasonliu added a comment. New diff does not have context available. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81972/new/ https://reviews.llvm.org/D81972 ___ cfe-commits mailing list

[PATCH] D81003: [clang] SequenceChecker: Also visit default arguments and default initializers.

2020-06-17 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno updated this revision to Diff 271480. riccibruno added a comment. Remove the FIXME comment in the `default_init` test. The behavior is actually fine since `struct S { int b = ++a; };` is not an aggregate in C++11 but is an aggregate in C++17. Repository: rG LLVM Github Monorepo

[PATCH] D81972: [NFC] Cleanup of EmitCXXGlobalInitFunc() and EmitCXXGlobalDtorFunc()

2020-06-17 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:596 } + // Include the filename in the symbol name. Including "sub_" matches gcc jasonliu wrote: > jasonliu wrote: > > jasonliu wrote: > > > I think this patch is missing what

[PATCH] D81972: [NFC] Cleanup of EmitCXXGlobalInitFunc() and EmitCXXGlobalDtorFunc()

2020-06-17 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L updated this revision to Diff 271486. Xiangling_L marked 3 inline comments as done. Xiangling_L added a comment. Remove early return part; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81972/new/ https://reviews.llvm.org/D81972 Files:

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

2020-06-17 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added a comment. Thanks for addressing my comments. As @jdoerfert says, let's give others time to review. Comment at: llvm/test/TableGen/directive1.td:1 +// RUN: llvm-tblgen -gen-directive-decls -I %p/../../include %s | FileCheck %s + I realize that

[PATCH] D81003: [clang] SequenceChecker: Also visit default arguments and default initializers.

2020-06-17 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno marked an inline comment as done. riccibruno added inline comments. Comment at: clang/test/SemaCXX/warn-unsequenced.cpp:313 +// +// However SequenceChecker::VisitCXXConstructExpr only visit the arguments +// of the CXXConstructExpr and is not visiting the

[PATCH] D80961: Ignore template instantiations if not in AsIs mode

2020-06-17 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added a comment. In D80961#2095254 , @klimek wrote: > 1. the scare quotes around "standing objections" reads like you're not > respecting the opinions of others here; Hmm, this wasn't intended. I sometimes quote things if they are a particular

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

2020-06-17 Thread Benson Chu via Phabricator via cfe-commits
pestctrl added a comment. Benson Chu Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79945/new/ https://reviews.llvm.org/D79945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

2020-06-17 Thread Lei Huang via Phabricator via cfe-commits
lei added inline comments. Comment at: clang/test/Parser/p10-vector-bool-128.c:2 +// RUN: %clang_cc1 -triple=powerpc64-unknown-linux-gnu -target-feature +altivec -target-feature +vsx -fsyntax-only -verify %s +// RUN: %clang_cc1 -triple=powerpc64le-unknown-linux-gnu

[PATCH] D81003: [clang] SequenceChecker: Also visit default arguments and default initializers.

2020-06-17 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno marked an inline comment as done. riccibruno added inline comments. Comment at: clang/test/SemaCXX/warn-unsequenced.cpp:313 +// +// However SequenceChecker::VisitCXXConstructExpr only visit the arguments +// of the CXXConstructExpr and is not visiting the

[PATCH] D81972: [NFC] Cleanup of EmitCXXGlobalInitFunc() and EmitCXXGlobalDtorFunc()

2020-06-17 Thread Jason Liu via Phabricator via cfe-commits
jasonliu added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:596 } + // Include the filename in the symbol name. Including "sub_" matches gcc jasonliu wrote: > jasonliu wrote: > > I think this patch is missing what @hubert.reinterpretcast

[PATCH] D81003: [clang] SequenceChecker: Also visit default arguments and default initializers.

2020-06-17 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno updated this revision to Diff 271464. riccibruno retitled this revision from "[clang] SequenceChecker: Also visit default arguments." to "[clang] SequenceChecker: Also visit default arguments and default initializers.". riccibruno edited the summary of this revision. riccibruno added

[PATCH] D81003: [clang] SequenceChecker: Also visit default arguments and default initializers.

2020-06-17 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno marked 3 inline comments as done. riccibruno added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2126 + "in default initializer used here">; def select_initialized_entity_kind : TextSubstitution< I should just use

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

2020-06-17 Thread Ahsan Saghir via Phabricator via cfe-commits
saghir marked 2 inline comments as done. saghir added inline comments. Comment at: clang/lib/Sema/DeclSpec.cpp:1170 // Only 'short' and 'long long' are valid with vector bool. (PIM 2.1) if ((TypeSpecWidth != TSW_unspecified) && (TypeSpecWidth != TSW_short) &&

[PATCH] D81713: [HIP] Fix rocm not found on rocm3.5

2020-06-17 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. This only solves compatability with the old layout in the case where the hipcc wrapper is pointing directly to the library directory. I think this will still fail with the native clang search

[PATCH] D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions

2020-06-17 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. I think this should go on, could you address the minor comments so we can merge it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71739/new/ https://reviews.llvm.org/D71739

[PATCH] D81938: [InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`.

2020-06-17 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. In D81938#2096732 , @hliao wrote: > In D81938#2096500 , @arsenm wrote: > > > I'm not entirely convinced this is safe in all contexts. I think you can > > argue that this is safe if it

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

2020-06-17 Thread Ahsan Saghir via Phabricator via cfe-commits
saghir marked 3 inline comments as done. saghir added inline comments. Comment at: clang/lib/Sema/DeclSpec.cpp:1155 + // TODO: Update comment with correct Programming Interface Manual + // version once it is available. __int128 has also been added + // to vector

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

2020-06-17 Thread Valentin Clement via Phabricator via cfe-commits
clementval marked 10 inline comments as done. clementval added a comment. @jdenny I will have a look at your suggestion to dump the name instead of the id. If it looks straight forward I will do it. Other comments were addressed. Thanks. Comment at:

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

2020-06-17 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM I'll merge for you; how do you want to be credited on the "Author" line of the commit message? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

2020-06-17 Thread Ahsan Saghir via Phabricator via cfe-commits
saghir updated this revision to Diff 271459. saghir marked 2 inline comments as done. saghir added a comment. Updated tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81816/new/ https://reviews.llvm.org/D81816 Files:

[PATCH] D81825: [Clang] Add support for -Wno-inline-namespace-reopened-noninline

2020-06-17 Thread Elvina Yakubova via Phabricator via cfe-commits
Elvina added a comment. Thanks for looking at this. I don't have commit rights, could you please commit the change on my behalf? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81825/new/ https://reviews.llvm.org/D81825 ___ cfe-commits

[clang] 9d8d064 - [NFC] Silence compiler warning [-Wmissing-braces].

2020-06-17 Thread Huihui Zhang via cfe-commits
Author: Huihui Zhang Date: 2020-06-17T13:01:53-07:00 New Revision: 9d8d0646d751326e2766caeaa20f6e0d4b89a4f6 URL: https://github.com/llvm/llvm-project/commit/9d8d0646d751326e2766caeaa20f6e0d4b89a4f6 DIFF: https://github.com/llvm/llvm-project/commit/9d8d0646d751326e2766caeaa20f6e0d4b89a4f6.diff

[clang] f39000b - [Driver] Delete CC1 -fxray-function-index and clean up some tests

2020-06-17 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2020-06-17T13:00:22-07:00 New Revision: f39000b4505bcfe3d2fcf23487096fb4703082bd URL: https://github.com/llvm/llvm-project/commit/f39000b4505bcfe3d2fcf23487096fb4703082bd DIFF: https://github.com/llvm/llvm-project/commit/f39000b4505bcfe3d2fcf23487096fb4703082bd.diff

[PATCH] D81995: [xray] Option to omit the function index

2020-06-17 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:114 +///< Set with -fno-xray-function-index to omit the index section. +CODEGENOPT(XRayOmitFunctionIndex , 1, 0) + Nit: a variable name with a positive meaning may be easier

[PATCH] D81861: [HIP] Do not use llvm-link/opt/llc for -fgpu-rdc

2020-06-17 Thread Hiroshi Yamauchi via Phabricator via cfe-commits
yamauchi added inline comments. Comment at: clang/test/Driver/hip-toolchain-no-rdc.hip:164 +// LKONLY-NOT: llvm-link +// LKONLY-NOT: opt +// LKONLY-NOT: llc yaxunl wrote: > arsenm wrote: > > yamauchi wrote: > > > Hi, this test seems to fail for me because I

[PATCH] D81395: [AST][RecoveryExpr] Preserve the invalid "undef_var" initializer.

2020-06-17 Thread Haojian Wu via Phabricator via cfe-commits
hokein marked 5 inline comments as done. hokein added inline comments. Comment at: clang/include/clang/Sema/Sema.h:3876 +llvm::function_ref Filter, +bool RecoverUncorrectedTypos = false) { +return

[PATCH] D82046: [HIP] Improve check patterns to avoid test failures in case string "opt",etc. happens to be in the InstallDir path in the -### output.

2020-06-17 Thread Hiroshi Yamauchi via Phabricator via cfe-commits
yamauchi added a comment. Context: https://reviews.llvm.org/D81861#inline-753520 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82046/new/ https://reviews.llvm.org/D82046 ___ cfe-commits mailing list

[PATCH] D82047: [AST] Move the "fallback to recovery expr" mechanism to CorrectDelayedTyposInExpr, NFC

2020-06-17 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. Also delete two overloads, which don't seem necessary. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82047 Files: clang/include/clang/Sema/Sema.h

[PATCH] D82046: [HIP] Improve check patterns to avoid test failures in case string "opt",etc. happens to be in the InstallDir path in the -### output.

2020-06-17 Thread Hiroshi Yamauchi via Phabricator via cfe-commits
yamauchi created this revision. yamauchi added a reviewer: yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. yamauchi added a comment. Context: https://reviews.llvm.org/D81861#inline-753520 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82046

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

2020-06-17 Thread Zola Bridges via Phabricator via cfe-commits
zbrid marked 2 inline comments as done. zbrid added a comment. Thanks for the ping, Scott. I'll update this so I can get it submitted soon. Comment at: clang/lib/Driver/ToolChains/Arch/X86.cpp:200 +if (!Args.hasArg(options::OPT_mno_lvi_cfi)) { +

[PATCH] D80873: [clang][cmake] Force CMAKE_LINKER for multistage build in case of BOOTSTRAP_LLVM_ENABLE_LLD and MSVC

2020-06-17 Thread Kristina Bessonova via Phabricator via cfe-commits
krisb added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80873/new/ https://reviews.llvm.org/D80873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D78190: Add Bfloat IR type

2020-06-17 Thread Tom Stellard via Phabricator via cfe-commits
tstellar added inline comments. Comment at: llvm/include/llvm-c/Core.h:149 LLVMHalfTypeKind,/**< 16 bit floating point type */ + LLVMBFloatTypeKind, /**< 16 bit brain floating point type */ LLVMFloatTypeKind, /**< 32 bit floating point type */

[PATCH] D81478: [OPENMP50]Codegen for scan directives in parallel for regions.

2020-06-17 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev updated this revision to Diff 271437. ABataev added a comment. Rebase + avoid copy paste. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81478/new/ https://reviews.llvm.org/D81478 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp

[clang-tools-extra] c76edaa - [clang-tidy] Prune dead code. NFC.

2020-06-17 Thread Benjamin Kramer via cfe-commits
Author: Benjamin Kramer Date: 2020-06-17T21:16:59+02:00 New Revision: c76edaabddea8a9b077859fcfa4d1465b7ce6a46 URL: https://github.com/llvm/llvm-project/commit/c76edaabddea8a9b077859fcfa4d1465b7ce6a46 DIFF:

[PATCH] D81463: [SveEmitter] Add builtins for tuple creation (svcreate2/svcreate3/etc)

2020-06-17 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81463/new/ https://reviews.llvm.org/D81463 ___ cfe-commits mailing list

[PATCH] D82004: [clang-tidy][NFC] Remove the double look-up on IncludeInserter

2020-06-17 Thread Nathan James via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG08c83ed75752: [clang-tidy][NFC] Remove the double look-up on IncludeInserter (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D82004?vs=271334=271432#toc Repository: rG LLVM

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

2020-06-17 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp:88 // C checkers // CON Please use //check// here. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D82016: [clang-format] [PR462254] fix indentation of default and break correctly in whitesmiths style

2020-06-17 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius accepted this revision. curdeius added a comment. Great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82016/new/ https://reviews.llvm.org/D82016 ___ cfe-commits mailing list

[PATCH] D79167: [SVE][CodeGen] Legalisation of vsetcc with scalable types

2020-06-17 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. Is it possible to write tests for this that don't result in a "max" or "min" operation? Or does that fail for some other reason? Otherwise LGTM. CHANGES SINCE LAST ACTION

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

2020-06-17 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added a comment. This patch looks like a good idea to me. Thanks. In D81736#2090419 , @clementval wrote: > @jdoerfert Some tests in clang relies on the position of the specific enum in > the declaration. TableGen is sorting the records so the

[clang-tools-extra] 08c83ed - [clang-tidy][NFC] Remove the double look-up on IncludeInserter

2020-06-17 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2020-06-17T19:48:34+01:00 New Revision: 08c83ed75752169bdf27df8f5ea5978c53f2e258 URL: https://github.com/llvm/llvm-project/commit/08c83ed75752169bdf27df8f5ea5978c53f2e258 DIFF: https://github.com/llvm/llvm-project/commit/08c83ed75752169bdf27df8f5ea5978c53f2e258.diff

[PATCH] D81995: [xray] Option to omit the function index

2020-06-17 Thread Ian Levesque via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7c7c8e0da4e0: [xray] Option to omit the function index (authored by ianlevesque). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81995/new/

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

2020-06-17 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added inline comments. Comment at: clang/test/Sema/builtins-memcpy-inline.c:7 +#warning defined as expected +// expected-warning@-1 {{defined as expected}} +#endif melver wrote: > It appears that the expected-warning check here is guarded by the #if as

[PATCH] D72782: [Matrix] Add __builtin_matrix_column_store to Clang.

2020-06-17 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10792 def err_builtin_matrix_pointer_arg: Error< - "%select{first|second}0 argument must be a pointer

[PATCH] D82024: [clangd] Rename FSProvider to TFS in case of ThreadsafeFS

2020-06-17 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. (I'm also happy to zap a few of these as a followup) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82024/new/ https://reviews.llvm.org/D82024 ___ cfe-commits mailing list

[PATCH] D81998: [clangd][NFC] Rename FSProvider and getFileSystem

2020-06-17 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/TestFS.h:34 // A VFS provider that returns TestFSes containing a provided set of files. -class MockFSProvider : public FileSystemProvider { +class MockFSProvider : public ThreadsafeFS { public:

[PATCH] D82024: [clangd] Rename FSProvider to TFS in case of ThreadsafeFS

2020-06-17 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/ParsedASTTests.cpp:252 TEST(ParsedASTTest, CanBuildInvocationWithUnknownArgs) { MockFSProvider FSProvider;

[PATCH] D77493: [clang-tidy] Add do-not-refer-atomic-twice check

2020-06-17 Thread Kocsis Ábel via Phabricator via cfe-commits
abelkocsis added a comment. Would you give me some feedback according to this checker? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77493/new/ https://reviews.llvm.org/D77493 ___ cfe-commits mailing

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

2020-06-17 Thread Kocsis Ábel via Phabricator via cfe-commits
abelkocsis updated this revision to Diff 271414. abelkocsis added a comment. Fixes on description and documentation Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75229/new/ https://reviews.llvm.org/D75229 Files: asd.diff

[PATCH] D81998: [clangd][NFC] Rename FSProvider and getFileSystem

2020-06-17 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/support/ThreadsafeFS.h:31 + virtual ~ThreadsafeFS() = default; + /// Obtain a vfs::FileSystem with an arbitrary initial

[PATCH] D82011: [clangd] Don't mangle workdir-relevant driver path in compile commands

2020-06-17 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:141 +// Let's hope it's not a symlink. +if (llvm::any_of(Driver, + [](char C) { return

[PATCH] D82004: [clang-tidy][NFC] Remove the double look-up on IncludeInserter

2020-06-17 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82004/new/ https://reviews.llvm.org/D82004

[clang] 7c7c8e0 - [xray] Option to omit the function index

2020-06-17 Thread Ian Levesque via cfe-commits
Author: Ian Levesque Date: 2020-06-17T13:49:01-04:00 New Revision: 7c7c8e0da4e0c400e7e06c4c6658372ea0b487ea URL: https://github.com/llvm/llvm-project/commit/7c7c8e0da4e0c400e7e06c4c6658372ea0b487ea DIFF: https://github.com/llvm/llvm-project/commit/7c7c8e0da4e0c400e7e06c4c6658372ea0b487ea.diff

[PATCH] D78903: [Driver] Add option -fproc-stat-report

2020-06-17 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3782 + = Cmd.getProcessStatistics(); + if (ProcStat) { +if (PrintProcessStat) { sepavloff wrote: > aganea wrote: > > In the case where `!ProcStat`, I am wondering if we

[PATCH] D82029: [Coroutines] Ensure co_await promise.final_suspend() does not throw

2020-06-17 Thread Xun Li via Phabricator via cfe-commits
lxfind created this revision. lxfind added reviewers: lewissbaker, modocache. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch addresses https://bugs.llvm.org/show_bug.cgi?id=46256 The spec of coroutine requires that the expression co_­await

[PATCH] D82019: [OPENMP]Fix PR46357: Do not allow types declarations in pragmas.

2020-06-17 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In D82019#2098509 , @jdoerfert wrote: > Hm, does the standard say this is not allowed? I can see that we don't want > it but I'm not 100% certain here. It does not say anything specific, but I don't think it is a good idea to

[PATCH] D81967: [clang-tools-extra] Prevent linking to duplicate .a libs and dylib

2020-06-17 Thread Michał Górny via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd4f298c8206b: [clang-tools-extra] Prevent linking to duplicate .a libs and dylib (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81970: [Clang][Driver] Remove gold linker support for PS4 toolchain

2020-06-17 Thread Yuanfang Chen via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG2956cc50f340: [Clang][Driver] Remove gold linker support for PS4 toolchain (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81970/new/

[PATCH] D81478: [OPENMP50]Codegen for scan directives in parallel for regions.

2020-06-17 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev marked an inline comment as done. ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:3627 + emitScanBasedDirective(CGF, S, NumIteratorsGen, FirstGen, SecondGen); +} else { + OMPCancelStackRAII CancelRegion(CGF, OMPD_parallel_for,

[PATCH] D72782: [Matrix] Add __builtin_matrix_column_store to Clang.

2020-06-17 Thread Florian Hahn via Phabricator via cfe-commits
fhahn updated this revision to Diff 271401. fhahn added a comment. Ping :) Rebased and applied feedback from D72781 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72782/new/ https://reviews.llvm.org/D72782

[PATCH] D82026: [OPENMP50]Allow nonmonotonic modifier for all schedule kinds.

2020-06-17 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: sstefan1, guansong, yaxunl. Herald added a project: clang. According to OpenMP 5.0, nonmonotonic modifier can be used with all schedule kinds, not only dynamic and guided as in OpenMP 4.5. Repository:

[PATCH] D82019: [OPENMP]Fix PR46357: Do not allow types declarations in pragmas.

2020-06-17 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added reviewers: dreachem, kkwli0, trws. jdoerfert added a comment. Hm, does the standard say this is not allowed? I can see that we don't want it but I'm not 100% certain here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82019/new/

[clang-tools-extra] d4f298c - [clang-tools-extra] Prevent linking to duplicate .a libs and dylib

2020-06-17 Thread Michał Górny via cfe-commits
Author: Michał Górny Date: 2020-06-17T19:00:26+02:00 New Revision: d4f298c8206b435ce627b022efa0d5da620019cd URL: https://github.com/llvm/llvm-project/commit/d4f298c8206b435ce627b022efa0d5da620019cd DIFF: https://github.com/llvm/llvm-project/commit/d4f298c8206b435ce627b022efa0d5da620019cd.diff

[clang] 2956cc5 - [Clang][Driver] Remove gold linker support for PS4 toolchain

2020-06-17 Thread Yuanfang Chen via cfe-commits
Author: Yuanfang Chen Date: 2020-06-17T09:45:14-07:00 New Revision: 2956cc50f3405ae32c8c6d6e2c63fe8cb6456fa2 URL: https://github.com/llvm/llvm-project/commit/2956cc50f3405ae32c8c6d6e2c63fe8cb6456fa2 DIFF: https://github.com/llvm/llvm-project/commit/2956cc50f3405ae32c8c6d6e2c63fe8cb6456fa2.diff

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

2020-06-17 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Thanks a lot! Sorry for the delay in reviewing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79675/new/

[PATCH] D81964: [clangd] Make use of preamble bounds from the patch inside ReplayPreamble

2020-06-17 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4317ee27bd64: [clangd] Make use of preamble bounds from the patch inside ReplayPreamble (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   3   >