[PATCH] D77334: [AVR] Remove duplicate specification of lib directory

2020-06-18 Thread Dylan McKay via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG03b0831144a9: [AVR] Remove duplicate specification of lib directory (authored by dylanmckay). Changed prior to commit: https://reviews.llvm.org/D77334?vs=254606=271915#toc Repository: rG LLVM Github

[PATCH] D77334: [AVR] Remove duplicate specification of lib directory

2020-06-18 Thread Dylan McKay via Phabricator via cfe-commits
dylanmckay added a comment. Sorry, I lost track of this. Committed in 01741d6dbec11c0a0c8e610f0033831735c78d1e Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77334/new/

[clang] 01741d6 - [AVR] Remove duplicate specification of lib directory

2020-06-18 Thread Dylan McKay via cfe-commits
Author: Dylan McKay Date: 2020-06-19T17:39:18+12:00 New Revision: 01741d6dbec11c0a0c8e610f0033831735c78d1e URL: https://github.com/llvm/llvm-project/commit/01741d6dbec11c0a0c8e610f0033831735c78d1e DIFF: https://github.com/llvm/llvm-project/commit/01741d6dbec11c0a0c8e610f0033831735c78d1e.diff

[clang] aeaa09e - Revert "[AVR] Remove duplicate specification of lib directory"

2020-06-18 Thread Dylan McKay via cfe-commits
Author: Dylan McKay Date: 2020-06-19T17:37:15+12:00 New Revision: aeaa09ec10ee41ef2469f4d69320d386d492bf23 URL: https://github.com/llvm/llvm-project/commit/aeaa09ec10ee41ef2469f4d69320d386d492bf23 DIFF: https://github.com/llvm/llvm-project/commit/aeaa09ec10ee41ef2469f4d69320d386d492bf23.diff

[clang] 03b0831 - [AVR] Remove duplicate specification of lib directory

2020-06-18 Thread Dylan McKay via cfe-commits
Author: Dylan McKay Date: 2020-06-19T17:35:09+12:00 New Revision: 03b0831144a9fe25aac81498b0a1dec82f4ec5df URL: https://github.com/llvm/llvm-project/commit/03b0831144a9fe25aac81498b0a1dec82f4ec5df DIFF: https://github.com/llvm/llvm-project/commit/03b0831144a9fe25aac81498b0a1dec82f4ec5df.diff

[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

2020-06-18 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added a comment. It seems like this pass was added in lib/Transforms but does not have any unit-tests (lit tests) provided. It isn't even linked into `opt`. As it is an LLVM IR pass it should be tested as such I believe. Can you provide tests for this? Repository: rG LLVM

[PATCH] D82141: [sve][acle] Add SVE BFloat16 extensions.

2020-06-18 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli created this revision. fpetrogalli added reviewers: sdesmalen, ctetreau, efriedma, david-arm. Herald added subscribers: llvm-commits, cfe-commits, psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added projects: clang, LLVM. List of

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

2020-06-18 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:103-118 + case Decl::CXXRecord: // struct/union/class X; [C++] +if (CGDebugInfo *DI = getDebugInfo()) + if (CGM.getCodeGenOpts().hasMaybeUnusedDebugInfo() && + cast(D).hasDefinition()) +

[clang] 6f9fe31 - More test cleanup for c36b03e32556a966e584386ac7dbb110bc7e4bc5.

2020-06-18 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-06-18T18:17:35-07:00 New Revision: 6f9fe31cff083c3bc93ffe9fa80346c1c594a359 URL: https://github.com/llvm/llvm-project/commit/6f9fe31cff083c3bc93ffe9fa80346c1c594a359 DIFF: https://github.com/llvm/llvm-project/commit/6f9fe31cff083c3bc93ffe9fa80346c1c594a359.diff

[clang] 9ca50e8 - [libTooling] Add parser for string representation of `RangeSelector`.

2020-06-18 Thread Yitzhak Mandelbaum via cfe-commits
Author: Yitzhak Mandelbaum Date: 2020-06-19T01:11:29Z New Revision: 9ca50e887db7f903c04a90593d2beed8a96794f1 URL: https://github.com/llvm/llvm-project/commit/9ca50e887db7f903c04a90593d2beed8a96794f1 DIFF: https://github.com/llvm/llvm-project/commit/9ca50e887db7f903c04a90593d2beed8a96794f1.diff

LLVM buildmaster will be updated and restarted tonight

2020-06-18 Thread Galina Kistanova via cfe-commits
Hello everyone, LLVM buildmaster will be updated and restarted after 8PM PST today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c36b03e - The type of a reference to a non-type template parameter pack should

2020-06-18 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-06-18T17:52:13-07:00 New Revision: c36b03e32556a966e584386ac7dbb110bc7e4bc5 URL: https://github.com/llvm/llvm-project/commit/c36b03e32556a966e584386ac7dbb110bc7e4bc5 DIFF: https://github.com/llvm/llvm-project/commit/c36b03e32556a966e584386ac7dbb110bc7e4bc5.diff

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

2020-06-18 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers updated this revision to Diff 271887. nickdesaulniers added a comment. - git clang-format HEAD~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 Files:

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

2020-06-18 Thread Derek Schuff via Phabricator via cfe-commits
dschuff added a comment. Yeah I think a 64-bit version of userstack.ll makes sense. (a fork or a second set of CHECKs, whatever you think would be cleaner). There's also `stack-alignment.ll` which covers dynamic stack adjustment. Comment at: lld/wasm/Driver.cpp:385 +

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

2020-06-18 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers updated this revision to Diff 271884. nickdesaulniers added a comment. - rebase - make feature progression of debug-info-kind - fix docs (define, not declare) - add driver tests - use OptOutFFlag tablegen helper - rename helper to EmitAndRetainType - dont emit debug info for

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

2020-06-18 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. Ok, I think I have all feedback addresses locally. One issue I'm hitting is that I'm regressing clang/test/OpenMP/parallel_codegen.cpp. Specifically, it seems it has code like: template

[clang] 0f92096 - Revert "Hook up OpenBSD 64-bit PowerPC support"

2020-06-18 Thread Brad Smith via cfe-commits
Author: Brad Smith Date: 2020-06-18T20:05:39-04:00 New Revision: 0f92096c0a9aa97a2818a8cc8e23e0bfc5d3831f URL: https://github.com/llvm/llvm-project/commit/0f92096c0a9aa97a2818a8cc8e23e0bfc5d3831f DIFF: https://github.com/llvm/llvm-project/commit/0f92096c0a9aa97a2818a8cc8e23e0bfc5d3831f.diff

[PATCH] D78190: Add Bfloat IR type

2020-06-18 Thread Ties Stuij via Phabricator via cfe-commits
stuij marked an inline comment as done. stuij added inline comments. Comment at: llvm/include/llvm-c/Core.h:149 LLVMHalfTypeKind,/**< 16 bit floating point type */ + LLVMBFloatTypeKind, /**< 16 bit brain floating point type */ LLVMFloatTypeKind, /**< 32

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

2020-06-18 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. @eduucaldas Hi, you can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed

[clang-tools-extra] 8b0df1c - [NFC] Refactor Registry loops to range for

2020-06-18 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2020-06-19T00:40:10+01:00 New Revision: 8b0df1c1a992d203212901c1139665261e0bbc1c URL: https://github.com/llvm/llvm-project/commit/8b0df1c1a992d203212901c1139665261e0bbc1c DIFF: https://github.com/llvm/llvm-project/commit/8b0df1c1a992d203212901c1139665261e0bbc1c.diff

[clang] 8b0df1c - [NFC] Refactor Registry loops to range for

2020-06-18 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2020-06-19T00:40:10+01:00 New Revision: 8b0df1c1a992d203212901c1139665261e0bbc1c URL: https://github.com/llvm/llvm-project/commit/8b0df1c1a992d203212901c1139665261e0bbc1c DIFF: https://github.com/llvm/llvm-project/commit/8b0df1c1a992d203212901c1139665261e0bbc1c.diff

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

2020-06-18 Thread Ahsan Saghir via Phabricator via cfe-commits
saghir updated this revision to Diff 271874. saghir added a reviewer: stefanp. saghir added a comment. Updated comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81816/new/ https://reviews.llvm.org/D81816 Files:

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

2020-06-18 Thread Michael Kruse via Phabricator via cfe-commits
Meinersbur added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/new/ https://reviews.llvm.org/D76342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 3008609 - Hook up OpenBSD 64-bit PowerPC support

2020-06-18 Thread Brad Smith via cfe-commits
Author: Brad Smith Date: 2020-06-18T19:19:45-04:00 New Revision: 3008609d4509c3efc577c0ccbe9d80a8a2eef31a URL: https://github.com/llvm/llvm-project/commit/3008609d4509c3efc577c0ccbe9d80a8a2eef31a DIFF: https://github.com/llvm/llvm-project/commit/3008609d4509c3efc577c0ccbe9d80a8a2eef31a.diff

[PATCH] D81972: [NFC] Cleanup of EmitCXXGlobalInitFunc() and EmitCXXGlobalDtorFunc()

2020-06-18 Thread Xiangling Liao via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGed1b556954eb: [NFC] Cleanup of EmitCXXGlobalInitFunc() and EmitCXXGlobalDtorFunc() (authored by Xiangling_L). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

2020-06-18 Thread Ahsan Saghir via Phabricator via cfe-commits
saghir updated this revision to Diff 271860. saghir edited the summary of this revision. saghir added a comment. Updated comment to reflect the change in allowed types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81816/new/

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

2020-06-18 Thread Wouter van Oortmerssen via Phabricator via cfe-commits
aardappel created this revision. aardappel added reviewers: sbc100, dschuff. Herald added subscribers: llvm-commits, cfe-commits, sunfish, aheejin, hiraditya, jgravelle-google. Herald added projects: clang, LLVM. aardappel updated this revision to Diff 271859. aardappel added a comment. This is

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

2020-06-18 Thread Wouter van Oortmerssen via Phabricator via cfe-commits
aardappel updated this revision to Diff 271859. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82130/new/ https://reviews.llvm.org/D82130 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp lld/wasm/Config.h lld/wasm/Driver.cpp lld/wasm/InputChunks.cpp lld/wasm/Options.td

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

2020-06-18 Thread Wouter van Oortmerssen via Phabricator via cfe-commits
aardappel added a comment. This is a first iteration, probably needs more tests :) I was thinking of forking `userstack.ll` since it has most `__stack_pointer` tests, but I am not sure if it's that useful. Needs a test that uses the new wasm-ld flag. Opinions welcome. CHANGES SINCE LAST

[clang] ed1b556 - [NFC] Cleanup of EmitCXXGlobalInitFunc() and EmitCXXGlobalDtorFunc()

2020-06-18 Thread Xiangling Liao via cfe-commits
Author: Xiangling Liao Date: 2020-06-18T18:49:23-04:00 New Revision: ed1b556954eb2b1bb50db973860b7cf20494ce15 URL: https://github.com/llvm/llvm-project/commit/ed1b556954eb2b1bb50db973860b7cf20494ce15 DIFF:

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

2020-06-18 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. In D82089#2100802 , @Eugene.Zelenko wrote: > It'll be interesting to run improved check over LLVM code base. I haven't tried running it over llvm, but I have had success using it with clangd in my editor, every loop I've

[PATCH] D69088: [Lex] #pragma clang transform

2020-06-18 Thread Michael Kruse via Phabricator via cfe-commits
Meinersbur added a comment. Herald added a subscriber: sstefan1. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69088/new/ https://reviews.llvm.org/D69088 ___ cfe-commits mailing list

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

2020-06-18 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 271856. njames93 added a comment. - Change default c++20 include to `ranges` instead of `algorithm` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82089/new/ https://reviews.llvm.org/D82089 Files:

[PATCH] D81923: [clang-tidy] Add modernize-use-ranges check.

2020-06-18 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 271855. njames93 added a comment. Added `IncludeInserter` to include the `` header. Added support for reverse iteration controlled by config. Added support for begin/end calls via pointers. Made the begin/end call matcher more robust if other checks want to

[clang] d8c9729 - [docs] Regenerate clang/docs/ClangCommandLineReference.rst

2020-06-18 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2020-06-18T14:52:39-07:00 New Revision: d8c9729216032e82adeb4965ae4e118c01f6b321 URL: https://github.com/llvm/llvm-project/commit/d8c9729216032e82adeb4965ae4e118c01f6b321 DIFF: https://github.com/llvm/llvm-project/commit/d8c9729216032e82adeb4965ae4e118c01f6b321.diff

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

2020-06-18 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast accepted this revision. hubert.reinterpretcast marked an inline comment as done. hubert.reinterpretcast added a comment. Thanks; LGTM with minor nit. Comment at: clang/lib/CodeGen/CodeGenModule.h:1060 + + /// Add a sterm finalizer to the C++ global

[PATCH] D80935: [PowerPC][Power10] Implement Parallel Bits Deposit/Extract Builtins in LLVM/Clang

2020-06-18 Thread Amy Kwan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc45c1611303b: [PowerPC][Power10] Implement Parallel Bits Deposit/Extract Builtins in… (authored by amyk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82029: [Coroutines] Ensure co_await promise.final_suspend() does not throw

2020-06-18 Thread Xun Li via Phabricator via cfe-commits
lxfind marked an inline comment as done. lxfind added inline comments. Comment at: clang/test/SemaCXX/coroutine-final-suspend-noexcept.cpp:14 +struct coroutine_handle { + static coroutine_handle from_address(void *); // expected-note {{must be declared with 'noexcept'}} +};

[clang] c45c161 - [PowerPC][Power10] Implement Parallel Bits Deposit/Extract Builtins in LLVM/Clang

2020-06-18 Thread Amy Kwan via cfe-commits
Author: Amy Kwan Date: 2020-06-18T16:23:56-05:00 New Revision: c45c1611303b4609016fa69c1c987ede3bf92006 URL: https://github.com/llvm/llvm-project/commit/c45c1611303b4609016fa69c1c987ede3bf92006 DIFF: https://github.com/llvm/llvm-project/commit/c45c1611303b4609016fa69c1c987ede3bf92006.diff

[PATCH] D82085: [TRE] markTails marks call sites as tailcalls though some of them are not.

2020-06-18 Thread Alexey Lapshin via Phabricator via cfe-commits
avl added a comment. > It makes sense to teach tail recursion elimination not to depend so heavily > on tail markings. But I don't think that implies we want to mess with the > markings themselves. Ok. Thus I need to drop part of this patch related to more strict tail marking, and continue

[PATCH] D82029: [Coroutines] Ensure co_await promise.final_suspend() does not throw

2020-06-18 Thread Lewis Baker via Phabricator via cfe-commits
lewissbaker added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10521 +def err_coroutine_promise_final_suspend_requires_nothrow : Error< + "all code generated by co_await __promise.final_suspend() must not throw" +>; I'd perhaps

[PATCH] D82085: [TRE] markTails marks call sites as tailcalls though some of them are not.

2020-06-18 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. All "tail" needs to mean is "this call does not reference the current function's stack." That's all, no more or less. The relevant documentation and APIs are a bit confusing. A "tail" marking is a prerequisite for tailcall optimization, but it's not really related

[PATCH] D82126: [libTooling] Change `selection` stencil to handle some cases of text in macros.

2020-06-18 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel created this revision. ymandel added a reviewer: gribozavr2. Herald added a project: clang. Currently, the `selection` stencil validates the selection before extracting the text. However, this means that any range inside a macro is rejected as an error. This patch changes the

[PATCH] D81466: [SveEmitter] Add builtins for struct loads/stores (ld2/ld3/etc)

2020-06-18 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7890 + Value *Predicate = EmitSVEPredicateCast(Ops[0], VTy); + Value *BasePtr= Builder.CreateBitCast(Ops[1],

[PATCH] D81959: [HIP] Enable -amdgpu-internalize-symbols

2020-06-18 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc830d517b4e4: [HIP] Enable -amdgpu-internalize-symbols (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82085: [TRE] markTails marks call sites as tailcalls though some of them are not.

2020-06-18 Thread Layton Kifer via Phabricator via cfe-commits
laytonio added a comment. Relevant llvm-dev thread. Noncapture use of locals disabling TailRecursionElimination Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82085/new/

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

2020-06-18 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. I took a look. It consistently fails for me on mac and on Windows in a `git bash` shell, but it passes in cmd with unxutils. Maybe this needs something like eac56724fd955af0f8521557cacc57a83f371649 ?

[PATCH] D82122: [analyzer][Liveness][RFC][NFC] Propose to turn statement liveness into expression liveness

2020-06-18 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus created this revision. Szelethus added reviewers: xazax.hun, NoQ, vsavchenko, balazske, martong, baloghadamsoftware, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho,

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

2020-06-18 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea added a comment. Reverted in rG2ae0df5be7408a79524743762b6c74953f31b805 . I'll investigate the issue on my end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80833/new/

[clang] c830d51 - [HIP] Enable -amdgpu-internalize-symbols

2020-06-18 Thread Yaxun Liu via cfe-commits
Author: Yaxun (Sam) Liu Date: 2020-06-18T16:34:37-04:00 New Revision: c830d517b4e46abb617a80b3967b26546370c928 URL: https://github.com/llvm/llvm-project/commit/c830d517b4e46abb617a80b3967b26546370c928 DIFF:

[clang] 2ae0df5 - [CodeView] Revert 8374bf43634725dc02a262a77b5f940fca25938c and 403f9537924b8910ed4f741ed96c61f5e657915b

2020-06-18 Thread Alexandre Ganea via cfe-commits
Author: Alexandre Ganea Date: 2020-06-18T16:18:46-04:00 New Revision: 2ae0df5be7408a79524743762b6c74953f31b805 URL: https://github.com/llvm/llvm-project/commit/2ae0df5be7408a79524743762b6c74953f31b805 DIFF:

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

2020-06-18 Thread Dmitri Gribenko via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1b2f6b4a08ba: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions (authored by eduucaldas, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82085: [TRE] markTails marks call sites as tailcalls though some of them are not.

2020-06-18 Thread Alexey Lapshin via Phabricator via cfe-commits
avl added a comment. > It's OK to set "tail" on any call that satisfies these requirements (from > https://llvm.org/docs/LangRef.html#call-instruction): "Both markers [tail and > musttail] imply that the callee does not access allocas from the caller. The > tail marker additionally implies

[PATCH] D82118: [clang][module] Improve incomplete-umbrella warning

2020-06-18 Thread Zixu Wang via Phabricator via cfe-commits
zixuw created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Upstream methods for action wrappers in generating modules; - Change the warning message for -Wincomplete-umbrella to report the location of the umbrella header; - Add a fix-it hint to include

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

2020-06-18 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea added a comment. In D80833#2101690 , @thakis wrote: > Hm http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/16533 is > happy so it's not broken on all Windows machines. Guess I'll take a look on > what's going on. You can hold off on

[clang] 1b2f6b4 - Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

2020-06-18 Thread Dmitri Gribenko via cfe-commits
Author: Eduardo Caldas Date: 2020-06-18T21:05:23+02:00 New Revision: 1b2f6b4a08ba74d965dcf7c9fee97d286c0250f8 URL: https://github.com/llvm/llvm-project/commit/1b2f6b4a08ba74d965dcf7c9fee97d286c0250f8 DIFF:

[PATCH] D80981: [AST] Fix a crash on accessing a class without definition in constexpr function context.

2020-06-18 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4320 +if (!RD->hasDefinition()) + return APValue(); APValue Struct(APValue::UninitStruct(), RD->getNumBases(), hokein wrote: > rsmith wrote: > > hokein wrote: > > > sammccall

[PATCH] D82029: [Coroutines] Ensure co_await promise.final_suspend() does not throw

2020-06-18 Thread Xun Li via Phabricator via cfe-commits
lxfind updated this revision to Diff 271801. lxfind added a comment. Herald added a subscriber: arphaman. Address feedback and update failed tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82029/new/ https://reviews.llvm.org/D82029 Files:

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

2020-06-18 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Hm http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/16533 is happy so it's not broken on all Windows machines. Guess I'll take a look on what's going on. You can hold off on the revert for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

2020-06-18 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea added a comment. In D80833#2101636 , @thakis wrote: > This is still broken; bots have been red for a few hours now. Can we revert > and analyze async, to keep the bots green please? Yes I will revert, but I don't understand. All the tests pass

[PATCH] D82115: [OPENMP50]Codegen for scan directives in parallel for simd regions.

2020-06-18 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: sstefan1, guansong, yaxunl. Herald added a project: clang. Added codegen for scan directives in parallel for simd regions. Emits the code for the directive with inscan reductions. Original code:

[PATCH] D81678: Introduce partialinit attribute at call sites for stricter poison analysis

2020-06-18 Thread Gui Andrade via Phabricator via cfe-commits
guiand added a comment. In an email conversation with @rsmith and @eugenis, they raised the issue that it's not necessarily wrong to pass aggregate types by value, even when some fields are uninit. A relevant excerpt from Richard: > In addition to the union case, there's another strange case

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

2020-06-18 Thread Kocsis Ábel via Phabricator via cfe-commits
abelkocsis updated this revision to Diff 271789. abelkocsis added a comment. Small comment fix Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75229/new/ https://reviews.llvm.org/D75229 Files:

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

2020-06-18 Thread Daniel Grumberg via Phabricator via cfe-commits
dang updated this revision to Diff 271790. dang added a comment. Address the clang-tidy issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://reviews.llvm.org/D79796 Files: clang/include/clang/Driver/CC1Options.td

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

2020-06-18 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. This is still broken; bots have been red for a few hours now. Can we revert and analyze async, to keep the bots green please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80833/new/ https://reviews.llvm.org/D80833

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

2020-06-18 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas updated this revision to Diff 271784. eduucaldas added a comment. change if -> asserts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81168/new/ https://reviews.llvm.org/D81168 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D77493: [clang-tidy] Add do-not-refer-atomic-twice check

2020-06-18 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/DoNotReferAtomicTwiceCheck.cpp:21 + Finder->addMatcher( + declRefExpr(hasType(hasUnqualifiedDesugaredType(atomicType())), + to(varDecl().bind("atomic")), I

[PATCH] D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list

2020-06-18 Thread Anatoly Trosinenko via Phabricator via cfe-commits
atrosinenko added a comment. @samsonov Something strange happens with the compiler-rt tests: when this patch was initially uploaded, the tests were failed with seemingly unrelated failures: B59287 . Some tests are broken upstream, I concluded. Today I have

[PATCH] D81868: [libTooling] Add parser for string representation of `RangeSelector`.

2020-06-18 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel added a comment. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81868/new/ https://reviews.llvm.org/D81868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80935: [PowerPC][Power10] Implement Parallel Bits Deposit/Extract Builtins in LLVM/Clang

2020-06-18 Thread Amy Kwan via Phabricator via cfe-commits
amyk marked an inline comment as done. amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCScheduleP9.td:47 + let UnsupportedFeatures = [HasQPX, HasSPE, PrefixInstrs, PCRelativeMemops, + IsISA3_1]; lei wrote: > Are

[PATCH] D81868: [libTooling] Add parser for string representation of `RangeSelector`.

2020-06-18 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 271782. ymandel marked 3 inline comments as done. ymandel added a comment. removed Twine argument per clang-tidy warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81868/new/

[PATCH] D81885: [Coroutines] Return false on error of buildSuspends

2020-06-18 Thread Xun Li via Phabricator via cfe-commits
lxfind abandoned this revision. lxfind added a comment. Makes sense. I will abandon this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81885/new/ https://reviews.llvm.org/D81885 ___

[PATCH] D81837: [ARM][bfloat] Removing lowering of bfloat arguments and returns from Clang's CodeGen

2020-06-18 Thread Ties Stuij via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG035795659b60: [ARM][bfloat] Do not coerce bfloat arguments and returns to integers (authored by stuij). Changed prior to commit: https://reviews.llvm.org/D81837?vs=271130=271775#toc Repository: rG

[PATCH] D81311: [RFC] LangRef: Define byref parameter attribute

2020-06-18 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. This LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81311/new/ https://reviews.llvm.org/D81311 ___ cfe-commits mailing list

[PATCH] D82112: [RFC][BPF] Implement getUserCost() for BPFTargetTransformInfo

2020-06-18 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song created this revision. yonghong-song added a reviewer: ast. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. This patch tries to partially prevent speculative code motion for BPF. First, some use cases on why we want to prevent

[PATCH] D81868: [libTooling] Add parser for string representation of `RangeSelector`.

2020-06-18 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 271770. ymandel marked 3 inline comments as done. ymandel added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81868/new/ https://reviews.llvm.org/D81868 Files:

[PATCH] D81672: [Driver] When forcing a crash call abort to get the correct diagnostic

2020-06-18 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea added a comment. But that won't work when compiling & crashing with `-fno-integrated-cc1`, would it? (or if building with `cmake ... -DCLANG_SPAWN_CC1=1`). In that case, normal crashes (not -gen-reproducer) won't go through the `CrashRecoveryContext`. Try running: $

[clang] eed45b5 - [OPENMP][DOCS]Update status of supported constructs, NFC.

2020-06-18 Thread Alexey Bataev via cfe-commits
Author: Alexey Bataev Date: 2020-06-18T13:29:33-04:00 New Revision: eed45b5fa2b638360ebfde037d284b9dc69e54c0 URL: https://github.com/llvm/llvm-project/commit/eed45b5fa2b638360ebfde037d284b9dc69e54c0 DIFF: https://github.com/llvm/llvm-project/commit/eed45b5fa2b638360ebfde037d284b9dc69e54c0.diff

[clang] 0357956 - [ARM][bfloat] Do not coerce bfloat arguments and returns to integers

2020-06-18 Thread Ties Stuij via cfe-commits
Author: Ties Stuij Date: 2020-06-18T18:26:01+01:00 New Revision: 035795659b604246b873f659f8feed8084898247 URL: https://github.com/llvm/llvm-project/commit/035795659b604246b873f659f8feed8084898247 DIFF: https://github.com/llvm/llvm-project/commit/035795659b604246b873f659f8feed8084898247.diff

[PATCH] D82019: [OPENMP]Fix PR46357: Do not allow types declarations in pragmas.

2020-06-18 Thread Alexey Bataev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG437cbad3b35c: [OPENMP]Fix PR46357: Do not allow types declarations in pragmas. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80913: [update_cc_test_checks.py] Correctly skip function definitions

2020-06-18 Thread Alexander Richardson via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGead7a8beccc1: [update_cc_test_checks.py] Correctly skip function definitions (authored by arichardson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80914: [update_cc_test_checks.py] Handle C++ methods

2020-06-18 Thread Alexander Richardson via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3ce0e92f45f5: [update_cc_test_checks.py] Handle C++ methods (authored by arichardson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80914/new/

[PATCH] D82046: [HIP] Improve check patterns to avoid test failures in case string "opt",etc. happens to be in the InstallDir path in the -### output.

2020-06-18 Thread Hiroshi Yamauchi via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGce82b8e8af6d: [HIP] Improve check patterns to avoid test failures in case string opt, etc. (authored by yamauchi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

2020-06-18 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp:88 // C checkers // CON abelkocsis wrote: > Eugene.Zelenko wrote: > > Please use //check// here. > Should I replace the `// C++ checkers` comment

[clang] 437cbad - [OPENMP]Fix PR46357: Do not allow types declarations in pragmas.

2020-06-18 Thread Alexey Bataev via cfe-commits
Author: Alexey Bataev Date: 2020-06-18T13:17:03-04:00 New Revision: 437cbad3b35c7cf0f49d2bcea0a521651113 URL: https://github.com/llvm/llvm-project/commit/437cbad3b35c7cf0f49d2bcea0a521651113 DIFF: https://github.com/llvm/llvm-project/commit/437cbad3b35c7cf0f49d2bcea0a521651113.diff

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

2020-06-18 Thread Jason Liu via Phabricator via cfe-commits
jasonliu accepted this revision. jasonliu added a comment. This revision is now accepted and ready to land. LGTM. But I suggest to wait for @hubert.reinterpretcast to have another scan at this before landing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

2020-06-18 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin added a comment. @njames93 - friendly ping, could you please take another look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80301/new/ https://reviews.llvm.org/D80301 ___ cfe-commits

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

2020-06-18 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Syntax/Nodes.cpp:182 + for (auto *C = firstChild(); C; C = C->nextSibling()) { +if (C->role() ==

[PATCH] D81868: [libTooling] Add parser for string representation of `RangeSelector`.

2020-06-18 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Transformer/Parsing.cpp:169 + +// For consistency with matcher parser and C++ code, node id's are written as +// strings. However,

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

2020-06-18 Thread Kocsis Ábel via Phabricator via cfe-commits
abelkocsis marked an inline comment as done. abelkocsis added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp:88 // C checkers // CON Eugene.Zelenko wrote: > Please use //check// here. Should I replace the `// C++

[PATCH] D81672: [Driver] When forcing a crash call abort to get the correct diagnostic

2020-06-18 Thread John Brawn via Phabricator via cfe-commits
john.brawn updated this revision to Diff 271757. john.brawn edited the summary of this revision. john.brawn added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Moved BugReportMsg printing into CrashRecoveryContext, and stopped printing of backtrace

[clang] ce82b8e - [HIP] Improve check patterns to avoid test failures in case string "opt",

2020-06-18 Thread Hiroshi Yamauchi via cfe-commits
Author: Hiroshi Yamauchi Date: 2020-06-18T10:14:31-07:00 New Revision: ce82b8e8af6d9e95e15624c4fb8af2faac68ff63 URL: https://github.com/llvm/llvm-project/commit/ce82b8e8af6d9e95e15624c4fb8af2faac68ff63 DIFF:

[clang] 3ce0e92 - [update_cc_test_checks.py] Handle C++ methods

2020-06-18 Thread Alex Richardson via cfe-commits
Author: Alex Richardson Date: 2020-06-18T18:09:21+01:00 New Revision: 3ce0e92f45f56fc1b93db35dec8c53dceb5c54a5 URL: https://github.com/llvm/llvm-project/commit/3ce0e92f45f56fc1b93db35dec8c53dceb5c54a5 DIFF:

[clang] ead7a8b - [update_cc_test_checks.py] Correctly skip function definitions

2020-06-18 Thread Alex Richardson via cfe-commits
Author: Alex Richardson Date: 2020-06-18T18:09:21+01:00 New Revision: ead7a8beccc18c2cbcde980d2f593267d63c5dc2 URL: https://github.com/llvm/llvm-project/commit/ead7a8beccc18c2cbcde980d2f593267d63c5dc2 DIFF:

[PATCH] D81672: [Driver] When forcing a crash call abort to get the correct diagnostic

2020-06-18 Thread John Brawn via Phabricator via cfe-commits
john.brawn marked an inline comment as done. john.brawn added inline comments. Comment at: clang/tools/driver/driver.cpp:518 + CRC.DumpStackAndCleanupOnFailure = true; + CRC.RunSafely([&]() { abort(); }); } aganea wrote: > The only concern I have

[PATCH] D81304: [llvm][SveEmitter] Emit the bfloat version of `svld1ro`.

2020-06-18 Thread Francesco Petrogalli via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3e59dfc30124: [llvm][SveEmitter] Emit the bfloat version of `svld1ro`. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81304/new/

[PATCH] D82026: [OPENMP50]Allow nonmonotonic modifier for all schedule kinds.

2020-06-18 Thread Alexey Bataev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4971d0b8ec6e: [OPENMP50]Allow nonmonotonic modifier for all schedule kinds. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82026/new/

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

2020-06-18 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:345 +// rarely. +Weights = nullptr; + } else if (Kind == GuardKind::VariableGuard && !D->isLocalVarDecl()) { jasonliu wrote: > Do we need to change/complicate the interface

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

2020-06-18 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas marked 2 inline comments as done. eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:190 +return N->kind() == NodeKind::NameSpecifier; + } +}; eduucaldas wrote: > gribozavr2 wrote: > > Should there be getters

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

2020-06-18 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L updated this revision to Diff 271747. Xiangling_L marked 3 inline comments as done. Xiangling_L added a comment. Removed a redundant header file; Addressed comments; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/ https://reviews.llvm.org/D74166 Files:

  1   2   3   >